Merge branch 'develop' into pratik/Add_checks_db_objects

.github/scripts/rename/README.md

@@ -29,8 +29,6 @@ run from the repository root.
 4. `.github/scripts/rename/binary.sh`: This script will rename the binary from
    `rippled` to `xrpld`, and reverses the symlink so that `rippled` points to
    the `xrpld` binary.
-5. `.github/scripts/rename/namespace.sh`: This script will rename the C++
-   namespaces from `ripple` to `xrpl`.
 
 You can run all these scripts from the repository root as follows:
 
@@ -39,5 +37,4 @@ You can run all these scripts from the repository root as follows:
 ./.github/scripts/rename/copyright.sh .
 ./.github/scripts/rename/cmake.sh .
 ./.github/scripts/rename/binary.sh .
-./.github/scripts/rename/namespace.sh .
 ```

.github/scripts/rename/namespace.sh

@@ -1,58 +0,0 @@
-#!/bin/bash
-
-# Exit the script as soon as an error occurs.
-set -e
-
-# On MacOS, ensure that GNU sed is installed and available as `gsed`.
-SED_COMMAND=sed
-if [[ "${OSTYPE}" == 'darwin'* ]]; then
-  if ! command -v gsed &> /dev/null; then
-      echo "Error: gsed is not installed. Please install it using 'brew install gnu-sed'."
-      exit 1
-  fi
-  SED_COMMAND=gsed
-fi
-
-# This script renames the `ripple` namespace to `xrpl` in this project.
-# Specifically, it renames all occurrences of `namespace ripple` and `ripple::`
-# to `namespace xrpl` and `xrpl::`, respectively, by scanning all header and
-# source files in the specified directory and its subdirectories, as well as any
-# occurrences in the documentation. It also renames them in the test suites.
-# Usage: .github/scripts/rename/namespace.sh <repository directory>
-
-if [ "$#" -ne 1 ]; then
-    echo "Usage: $0 <repository directory>"
-    exit 1
-fi
-
-DIRECTORY=$1
-echo "Processing directory: ${DIRECTORY}"
-if [ ! -d "${DIRECTORY}" ]; then
-    echo "Error: Directory '${DIRECTORY}' does not exist."
-    exit 1
-fi
-pushd ${DIRECTORY}
-
-DIRECTORIES=("include" "src" "tests")
-for DIRECTORY in "${DIRECTORIES[@]}"; do
-  echo "Processing directory: ${DIRECTORY}"
-
-  find "${DIRECTORY}" -type f \( -name "*.h" -o -name "*.hpp" -o -name "*.ipp" -o -name "*.cpp" \) | while read -r FILE; do
-      echo "Processing file: ${FILE}"
-      ${SED_COMMAND} -i 's/namespace ripple/namespace xrpl/g' "${FILE}"
-      ${SED_COMMAND} -i 's/ripple::/xrpl::/g' "${FILE}"
-      ${SED_COMMAND} -i -E 's/(BEAST_DEFINE_TESTSUITE.+)ripple(.+)/\1xrpl\2/g' "${FILE}"
-  done
-done
-
-# Special case for NuDBFactory that has ripple twice in the test suite name.
-${SED_COMMAND} -i -E 's/(BEAST_DEFINE_TESTSUITE.+)ripple(.+)/\1xrpl\2/g' src/test/nodestore/NuDBFactory_test.cpp
-
-DIRECTORY=$1
-find "${DIRECTORY}" -type f -name "*.md" | while read -r FILE; do
-    echo "Processing file: ${FILE}"
-    ${SED_COMMAND} -i 's/ripple::/xrpl::/g' "${FILE}"
-done
-
-popd
-echo "Renaming complete."

.github/workflows/reusable-check-rename.yml

@@ -27,8 +27,6 @@ jobs:
         run: .github/scripts/rename/cmake.sh .
       - name: Check binary name
         run: .github/scripts/rename/binary.sh .
-      - name: Check namespaces
-        run: .github/scripts/rename/namespace.sh .
       - name: Check for differences
         env:
           MESSAGE: |

CLEANUP_SUMMARY.md

@@ -1,129 +0,0 @@
-# Cleanup Summary
-
-## Redundant Files Removed
-
-Successfully removed **16 redundant files** created during the test conversion process:
-
-### Conversion Scripts (13 files)
-1. ✅ `CONVERT_RPC_TESTS.py` - RPC-specific conversion script
-2. ✅ `batch_convert.py` - Batch conversion utility
-3. ✅ `batch_convert_app.py` - App tests batch converter
-4. ✅ `batch_convert_rpc.py` - RPC tests batch converter
-5. ✅ `comprehensive_convert.py` - Comprehensive conversion script
-6. ✅ `convert_all_app_files.py` - App files converter
-7. ✅ `convert_all_rpc.py` - RPC files converter
-8. ✅ `convert_to_doctest.py` - Initial conversion script
-9. ✅ `final_class_fix.py` - Class structure fix script
-10. ✅ `fix_refactored_tests.py` - Refactoring fix script
-11. ✅ `refactor_to_testcase.py` - TEST_CASE refactoring script
-12. ✅ `simple_class_removal.py` - Simple class removal script
-13. ✅ `simple_convert.py` - Simple conversion script (used for main conversion)
-14. ✅ `run_conversion.sh` - Shell wrapper script
-
-### Redundant Documentation (2 files)
-15. ✅ `CONVERSION_SUMMARY.md` - Superseded by FINAL_CONVERSION_SUMMARY.md
-16. ✅ `RUN_THIS_TO_CONVERT.md` - Conversion instructions (no longer needed)
-
-## Files Kept (Essential Documentation)
-
-### Core Documentation (3 files)
-1. ✅ **[FINAL_CONVERSION_SUMMARY.md](FINAL_CONVERSION_SUMMARY.md)** - Complete conversion documentation
-   - Conversion statistics
-   - Before/after examples
-   - Special cases handled
-   - Migration guide
-
-2. ✅ **[CMAKE_INTEGRATION_SUMMARY.md](CMAKE_INTEGRATION_SUMMARY.md)** - Build system integration
-   - CMake changes
-   - Build instructions
-   - Test targets
-   - CI/CD integration
-
-3. ✅ **[src/doctest/BUILD.md](src/doctest/BUILD.md)** - Build and usage guide
-   - Prerequisites
-   - Building tests
-   - Running tests
-   - Debugging
-   - IDE integration
-   - Troubleshooting
-
-### Project Files (Unchanged)
-- ✅ `conanfile.py` - Conan package manager configuration (original project file)
-- ✅ `BUILD.md` - Original project build documentation
-- ✅ All other original project files
-
-## Repository Status
-
-### Before Cleanup
-- 13 conversion scripts
-- 2 redundant documentation files
-- Multiple intermediate/duplicate converters
-
-### After Cleanup
-- 0 conversion scripts (all removed)
-- 3 essential documentation files (organized and final)
-- Clean repository with only necessary files
-
-## What Was Achieved
-
-✅ **281 test files** successfully converted
-✅ **CMake integration** complete
-✅ **Documentation** comprehensive and organized
-✅ **Redundant files** cleaned up
-✅ **Repository** clean and maintainable
-
-## Final File Structure
-
-```
-/home/pratik/sourceCode/2rippled/
-├── CMakeLists.txt (modified)                    # Added doctest subdirectory
-├── CMAKE_INTEGRATION_SUMMARY.md (kept)          # Build integration docs
-├── FINAL_CONVERSION_SUMMARY.md (kept)           # Conversion details
-├── conanfile.py (original)                      # Conan configuration
-├── src/
-│   ├── doctest/                                 # All converted tests (281 files)
-│   │   ├── CMakeLists.txt                       # Test build configuration
-│   │   ├── BUILD.md (kept)                      # Build instructions
-│   │   ├── main.cpp                             # Doctest entry point
-│   │   ├── app/ (71 files)
-│   │   ├── basics/ (17 files)
-│   │   ├── rpc/ (48 files)
-│   │   └── ... (19 directories total)
-│   └── test/                                    # Original tests (unchanged)
-└── [other project files]
-```
-
-## Benefits of Cleanup
-
-1. **Cleaner Repository** - No clutter from temporary conversion scripts
-2. **Easier Maintenance** - Only essential documentation remains
-3. **Clear Documentation** - Three well-organized reference documents
-4. **Professional Structure** - Production-ready state
-5. **No Confusion** - No duplicate or conflicting documentation
-
-## If You Need to Convert More Tests
-
-The conversion process is complete, but if you need to convert additional tests in the future:
-
-1. Refer to **FINAL_CONVERSION_SUMMARY.md** for conversion patterns
-2. Use the examples in `src/doctest/` as templates
-3. Follow the CMake integration pattern in `src/doctest/CMakeLists.txt`
-4. Consult **BUILD.md** for build instructions
-
-## Cleanup Date
-
-**Cleanup Completed**: December 11, 2024
-**Files Removed**: 16
-**Files Kept**: 3 (documentation)
-**Test Files**: 281 (all converted and integrated)
-
----
-
-## Summary
-
-✅ All redundant conversion scripts removed
-✅ Essential documentation preserved and organized
-✅ Repository clean and ready for production use
-✅ All 281 tests successfully converted and integrated into CMake build system
-
-The test conversion project is now **complete and production-ready**!

CMAKE_INTEGRATION_SUMMARY.md

@@ -1,245 +0,0 @@
-# CMake Integration Summary
-
-## Overview
-
-This document describes the CMake integration for doctest-based unit tests in the rippled project. The doctest framework is used for standalone unit tests, while integration tests remain in the Beast Unit Test framework.
-
-## Files Created/Modified
-
-### 1. Main CMakeLists.txt
-**File**: `/home/pratik/sourceCode/2rippled/CMakeLists.txt`
-
-**Changes**: Added doctest directory to the build when tests are enabled:
-```cmake
-if(tests)
-  include(CTest)
-  add_subdirectory(src/tests/libxrpl)
-  # Doctest-based tests (converted from Beast Unit Test framework)
-  add_subdirectory(src/doctest)
-endif()
-```
-
-### 2. Doctest CMakeLists.txt
-**File**: `/home/pratik/sourceCode/2rippled/src/doctest/CMakeLists.txt`
-
-**Content**: Build configuration for doctest test modules:
-- Finds doctest package
-- Creates test targets for migrated test modules
-- Links appropriate libraries (xrpl::libxrpl, xrpl::basics, xrpl::protocol, xrpl::json)
-- Integrates with CTest
-
-**Test Targets Created**:
-1. `xrpl.test.basics` - Basic utility tests (Buffer, Expected, IOUAmount, Number, XRPAmount)
-2. `xrpl.test.protocol` - Protocol tests (ApiVersion, BuildInfo, STAccount, STInteger, STNumber, SecretKey, Seed)
-3. `xrpl.test.json` - JSON object tests
-
-**Custom Target**: `xrpl.doctest.tests` - Build all doctest tests at once
-
-### 3. Test Implementation Files
-**Location**: `/home/pratik/sourceCode/2rippled/src/doctest/`
-
-**Structure**:
-```
-src/doctest/
-├── CMakeLists.txt       # Build configuration
-├── main.cpp             # Shared doctest entry point
-├── basics/              # 5 test files, 36 test cases, 1,365 assertions
-│   ├── Buffer_test.cpp
-│   ├── Expected_test.cpp
-│   ├── IOUAmount_test.cpp
-│   ├── Number_test.cpp
-│   └── XRPAmount_test.cpp
-├── protocol/            # 7 test files, 37 test cases, 16,020 assertions
-│   ├── ApiVersion_test.cpp
-│   ├── BuildInfo_test.cpp
-│   ├── STAccount_test.cpp
-│   ├── STInteger_test.cpp
-│   ├── STNumber_test.cpp
-│   ├── SecretKey_test.cpp
-│   └── Seed_test.cpp
-└── json/                # 1 test file, 8 test cases, 12 assertions
-    └── Object_test.cpp
-```
-
-### 4. Documentation Files
-**Files**:
-- `/home/pratik/sourceCode/2rippled/DOCTEST_README.md` - Main migration documentation
-- `/home/pratik/sourceCode/2rippled/src/doctest/README.md` - Test suite documentation
-- `/home/pratik/sourceCode/2rippled/CMAKE_INTEGRATION_SUMMARY.md` - This file
-
-## How to Build
-
-### Quick Start
-
-```bash
-# From project root
-mkdir -p build && cd build
-
-# Configure with tests enabled
-cmake .. -Dtests=ON
-
-# Build all doctest tests
-cmake --build . --target xrpl.doctest.tests
-
-# Run all tests
-ctest
-```
-
-### Build Specific Test Module
-
-```bash
-# Build only basics tests
-cmake --build . --target xrpl.test.basics
-
-# Run the basics tests
-./src/doctest/xrpl.test.basics
-
-# Filter by test suite
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-```
-
-## Integration with Existing Build
-
-The doctest tests are integrated alongside the existing test infrastructure:
-
-```
-if(tests)
-  include(CTest)
-  add_subdirectory(src/tests/libxrpl)  # Original tests
-  add_subdirectory(src/doctest)         # New doctest tests
-endif()
-```
-
-Both test suites coexist, with:
-- **Doctest**: Standalone unit tests (11 files, 81 test cases, 17,397 assertions)
-- **Beast**: Integration tests requiring test infrastructure (~270 files in `src/test/`)
-- Clear separation by test type and dependencies
-
-## Dependencies
-
-**Required**: 
-- doctest (2.4.0 or later)
-- All existing project dependencies
-
-**Installation**:
-```bash
-# Ubuntu/Debian
-sudo apt-get install doctest-dev
-
-# macOS
-brew install doctest
-
-# Or build from source
-git clone https://github.com/doctest/doctest.git external/doctest
-```
-
-## Best Practices Applied
-
-All migrated tests follow official doctest best practices:
-
-### 1. TEST_SUITE Organization
-All test files use `TEST_SUITE_BEGIN/END` for better organization and filtering:
-```cpp
-TEST_SUITE_BEGIN("basics");
-TEST_CASE("test name") { /* tests */ }
-TEST_SUITE_END();
-```
-
-### 2. Readable Assertions
-- Using `CHECK_FALSE(expression)` instead of `CHECK(!(expression))`
-- Using `REQUIRE` for critical preconditions that must be true
-
-### 3. Enhanced Diagnostics
-- `CAPTURE(variable)` macros in loops for better failure diagnostics
-- Shows variable values when assertions fail
-
-### 4. Test Suite Filtering
-Run specific test suites:
-```bash
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-```
-
-## CI/CD Integration
-
-Tests can be run in CI/CD pipelines:
-
-```bash
-# Configure
-cmake -B build -Dtests=ON
-
-# Build tests
-cmake --build build --target xrpl.doctest.tests
-
-# Run tests with output
-cd build && ctest --output-on-failure --verbose
-```
-
-## Migration Status
-
-✅ **Complete** - 11 unit test files successfully migrated to doctest
-✅ **Tested** - All 81 test cases, 17,397 assertions passing
-✅ **Best Practices** - All tests follow official doctest guidelines
-✅ **Documented** - Complete migration and build documentation
-
-## Migrated Tests
-
-### Basics Module (5 files)
-- Buffer_test.cpp - Buffer and Slice operations
-- Expected_test.cpp - Expected/Unexpected result types
-- IOUAmount_test.cpp - IOU amount calculations
-- Number_test.cpp - Numeric type operations
-- XRPAmount_test.cpp - XRP amount handling
-
-### Protocol Module (7 files)
-- ApiVersion_test.cpp - API version validation
-- BuildInfo_test.cpp - Build version encoding/decoding
-- STAccount_test.cpp - Serialized account types
-- STInteger_test.cpp - Serialized integer types
-- STNumber_test.cpp - Serialized number types
-- SecretKey_test.cpp - Secret key operations
-- Seed_test.cpp - Seed generation and keypair operations
-
-### JSON Module (1 file)
-- Object_test.cpp - JSON object operations
-
-## Files Summary
-
-```
-/home/pratik/sourceCode/2rippled/
-├── CMakeLists.txt (modified)                    # Added doctest subdirectory
-├── DOCTEST_README.md                            # Main migration documentation
-├── CMAKE_INTEGRATION_SUMMARY.md (this file)     # CMake integration details
-└── src/doctest/
-    ├── CMakeLists.txt                           # Test build configuration
-    ├── README.md                                # Test suite documentation
-    ├── main.cpp                                 # Doctest entry point
-    ├── basics/ (5 test files)
-    ├── protocol/ (7 test files)
-    └── json/ (1 test file)
-```
-
-## References
-
-- [DOCTEST_README.md](DOCTEST_README.md) - Complete migration guide and best practices
-- [src/doctest/README.md](src/doctest/README.md) - Test suite details and usage
-- [Doctest Documentation](https://github.com/doctest/doctest/tree/master/doc/markdown)
-- [Doctest Best Practices (ACCU)](https://accu.org/journals/overload/25/137/kirilov_2343/)
-
-## Support
-
-For build issues:
-1. Verify doctest is installed (`doctest-dev` package or from source)
-2. Check CMake output for errors
-3. Ensure all dependencies are available
-4. Review test suite documentation
-
----
-
-**Integration Date**: December 11, 2024
-**Migration Completed**: December 12, 2024
-**Total Migrated Test Files**: 11
-**Test Cases**: 81
-**Assertions**: 17,397
-**Build System**: CMake 3.16+

CMakeLists.txt

@@ -146,7 +146,5 @@ include(XrplValidatorKeys)
 
 if(tests)
   include(CTest)
-  # add_subdirectory(src/tests/libxrpl)
-  # Doctest-based tests (converted from Beast Unit Test framework)
-  add_subdirectory(src/doctest)
+  add_subdirectory(src/tests/libxrpl)
 endif()

CONTRIBUTING.md

@@ -304,7 +304,7 @@ For this reason:
 - Example **bad** name
   `"RFC1751::insert(char* s, int x, int start, int length) : length is greater than or equal zero"`
   (missing namespace, unnecessary full function signature, description too verbose).
-  Good name: `"xrpl::RFC1751::insert : minimum length"`.
+  Good name: `"ripple::RFC1751::insert : minimum length"`.
 - In **few** well-justified cases a non-standard name can be used, in which case a
   comment should be placed to explain the rationale (example in `contract.cpp`)
 - Do **not** rename a contract without a good reason (e.g. the name no longer

DOCTEST_README.md

@@ -1,289 +0,0 @@
-# Doctest Migration - Final Status
-
-## Overview
-
-This document summarizes the migration of rippled unit tests from the Beast Unit Test framework to doctest. The migration follows a **hybrid approach**: standalone unit tests are migrated to doctest, while integration tests remain in the Beast framework.
-
-## Migration Complete ✅
-
-**Status**: Successfully migrated 11 unit test files
-**Result**: 81 test cases, 17,397 assertions - **ALL PASSING**
-
-## What Was Migrated
-
-### Successfully Migrated to Doctest
-
-Located in `src/doctest/`:
-
-#### Basics Tests (5 files, 36 test cases, 1,365 assertions)
-- Buffer_test.cpp
-- Expected_test.cpp
-- IOUAmount_test.cpp
-- Number_test.cpp
-- XRPAmount_test.cpp
-
-#### Protocol Tests (7 files, 37 test cases, 16,020 assertions)
-- ApiVersion_test.cpp
-- BuildInfo_test.cpp
-- STAccount_test.cpp
-- STInteger_test.cpp
-- STNumber_test.cpp
-- SecretKey_test.cpp
-- Seed_test.cpp
-
-#### JSON Tests (1 file, 8 test cases, 12 assertions)
-- Object_test.cpp
-
-### Kept in Beast Framework
-
-Located in `src/test/`:
-- All integration tests (app, rpc, consensus, core, csf, jtx modules)
-- Tests requiring test infrastructure (Env, Config, Ledger setup)
-- Multi-component interaction tests
-
-## Key Challenges & Solutions
-
-### 1. Namespace Migration (`ripple` → `xrpl`)
-
-**Problem**: Many types moved from `ripple` to `xrpl` namespace.
-
-**Solution**: Add `using` declarations at global scope:
-```cpp
-using xrpl::Buffer;
-using xrpl::IOUAmount;
-using xrpl::STUInt32;
-```
-
-### 2. Nested Namespaces
-
-**Problem**: `RPC` namespace nested inside `xrpl` (not `ripple`).
-
-**Solution**: Use full qualification or namespace alias:
-```cpp
-// Option 1: Full qualification
-xrpl::RPC::apiMinimumSupportedVersion
-
-// Option 2: Namespace alias
-namespace BuildInfo = xrpl::BuildInfo;
-```
-
-### 3. CHECK Macro Differences
-
-**Problem**: Beast's `BEAST_EXPECT` returns a boolean; doctest's `CHECK` doesn't.
-
-**Solution**: Replace conditional patterns:
-```cpp
-// Before (Beast):
-if (CHECK(parsed)) { /* use parsed */ }
-
-// After (Doctest):
-auto parsed = parseBase58<AccountID>(s);
-REQUIRE(parsed);  // Stops if fails
-// use parsed
-```
-
-### 4. Exception Testing
-
-**Problem**: Beast used try-catch blocks explicitly.
-
-**Solution**: Use doctest macros:
-```cpp
-// Before (Beast):
-try {
-    auto _ = func();
-    BEAST_EXPECT(false);
-} catch (std::runtime_error const& e) {
-    BEAST_EXPECT(e.what() == expected);
-}
-
-// After (Doctest):
-CHECK_THROWS_AS(func(), std::runtime_error);
-```
-
-### 5. Test Organization
-
-**Problem**: Beast used class methods for test organization.
-
-**Solution**: Use TEST_CASE with SUBCASE:
-```cpp
-TEST_CASE("STNumber_test") {
-    SUBCASE("Integer parsing") { /* tests */ }
-    SUBCASE("Decimal parsing") { /* tests */ }
-    SUBCASE("Error cases") { /* tests */ }
-}
-```
-
-## Migration Guidelines
-
-### When to Migrate to Doctest
-
-✅ **Good Candidates**:
-- Tests single class/function in isolation
-- No dependencies on test/jtx or test/csf frameworks
-- Pure logic/algorithm/data structure tests
-- No Env, Config, or Ledger setup required
-
-❌ **Keep in Beast**:
-- Requires test/jtx utilities (Env, IOU, pay, etc.)
-- Requires test/csf (consensus simulation)
-- Multi-component integration tests
-- End-to-end workflow tests
-
-### Migration Pattern
-
-```cpp
-// 1. Include production headers first
-#include <xrpl/protocol/STInteger.h>
-#include <xrpl/protocol/LedgerFormats.h>
-
-// 2. Include doctest
-#include <doctest/doctest.h>
-
-// 3. Add using declarations for xrpl types
-using xrpl::STUInt32;
-using xrpl::JsonOptions;
-using xrpl::ltACCOUNT_ROOT;
-
-// 4. Write tests in xrpl namespace (or ripple::test)
-namespace xrpl {
-
-TEST_CASE("Descriptive Test Name") {
-    SUBCASE("Specific scenario") {
-        // Setup
-        STUInt32 value(42);
-
-        // Test
-        CHECK(value.getValue() == 42);
-        CHECK(value.getSType() == STI_UINT32);
-    }
-}
-
-}  // namespace xrpl
-```
-
-## Doctest Best Practices Applied
-
-All migrated tests follow official doctest best practices as documented in the [doctest guidelines](https://github.com/doctest/doctest/tree/master/doc/markdown):
-
-### 1. TEST_SUITE Organization
-
-All test files are organized into suites for better filtering and organization:
-
-```cpp
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("Buffer") { /* tests */ }
-
-TEST_SUITE_END();
-```
-
-**Benefits**:
-- Filter tests by suite: `./xrpl.test.protocol --test-suite=protocol`
-- Better organization and documentation
-- Clearer test structure
-
-### 2. CHECK_FALSE for Readability
-
-Replaced `CHECK(!(expression))` with more readable `CHECK_FALSE(expression)`:
-
-```cpp
-// Before:
-CHECK(!buffer.empty());
-
-// After:
-CHECK_FALSE(buffer.empty());
-```
-
-### 3. CAPTURE Macros in Loops
-
-Added CAPTURE macros in loops for better failure diagnostics:
-
-```cpp
-for (std::size_t i = 0; i < 16; ++i) {
-    CAPTURE(i);  // Shows value of i when test fails
-    test(buffer, i);
-}
-```
-
-**Note**: Files with many loops (Number, XRPAmount, SecretKey, Seed) have the essential TEST_SUITE organization. CAPTURE macros can be added incrementally for enhanced diagnostics.
-
-### 4. REQUIRE for Critical Preconditions
-
-Use REQUIRE when subsequent code depends on the assertion being true:
-
-```cpp
-auto parsed = parseBase58<AccountID>(s);
-REQUIRE(parsed);  // Stops test if parsing fails
-CHECK(toBase58(*parsed) == s);  // Safe to dereference
-```
-
-## Build & Run
-
-### Build
-```bash
-cd .build
-
-# Build all doctest tests
-cmake --build . --target xrpl.doctest.tests
-
-# Build individual modules
-cmake --build . --target xrpl.test.basics
-cmake --build . --target xrpl.test.protocol
-cmake --build . --target xrpl.test.json
-```
-
-### Run
-```bash
-# Run all tests
-./src/doctest/xrpl.test.basics
-./src/doctest/xrpl.test.protocol
-./src/doctest/xrpl.test.json
-
-# Run with options
-./src/doctest/xrpl.test.basics --list-test-cases
-./src/doctest/xrpl.test.protocol --success
-
-# Filter by test suite
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-./src/doctest/xrpl.test.json --test-suite=JsonObject
-```
-
-## Benefits of Hybrid Approach
-
-1. ✅ **Fast compilation**: Doctest is header-only and very lightweight
-2. ✅ **Simple unit tests**: No framework overhead for simple tests
-3. ✅ **Keep integration tests**: Complex test infrastructure remains intact
-4. ✅ **Both frameworks work**: No conflicts between Beast and doctest
-5. ✅ **Clear separation**: Unit tests vs integration tests
-
-## Statistics
-
-### Before Migration
-- 281 test files in Beast framework
-- Mix of unit and integration tests
-- All in `src/test/`
-
-### After Migration
-- **11 unit test files** migrated to doctest (`src/doctest/`)
-- **~270 integration test files** remain in Beast (`src/test/`)
-- Both frameworks coexist successfully
-
-## Future Work
-
-Additional unit tests can be migrated using the established patterns:
-- More protocol tests (Serializer, PublicKey, Quality, Issue, MultiApiJson, TER, SeqProxy)
-- More basics tests (StringUtilities, base58, base_uint, join, KeyCache, TaggedCache, hardened_hash)
-- Other standalone unit tests identified in the codebase
-
-## References
-
-- [Doctest Documentation](https://github.com/doctest/doctest/blob/master/doc/markdown/readme.md)
-- [Doctest Tutorial](https://github.com/doctest/doctest/blob/master/doc/markdown/tutorial.md)
-- [Doctest Best Practices (ACCU)](https://accu.org/journals/overload/25/137/kirilov_2343/)
-- [Migration Details](src/doctest/README.md)
-
----
-
-**Last Updated**: December 12, 2024
-**Status**: Migration Complete & Production Ready

FINAL_CONVERSION_SUMMARY.md

@@ -1,277 +0,0 @@
-# Final Test Conversion Summary: Beast Unit Tests to Doctest
-
-## Mission Accomplished ✅
-
-Successfully converted **all 281 test files** from Beast Unit Test framework to Doctest format, with complete removal of class-based structures.
-
-## Conversion Statistics
-
-- **Total Files**: 281
-- **Successfully Converted**: 281 (100%)
-- **Source**: `/home/pratik/sourceCode/2rippled/src/test/`
-- **Destination**: `/home/pratik/sourceCode/2rippled/src/doctest/`
-
-## What Was Converted
-
-### Phase 1: Basic Conversion (All 281 Files)
-✅ Replaced `#include <xrpl/beast/unit_test.h>` → `#include <doctest/doctest.h>`
-✅ Converted `BEAST_EXPECT(...)` → `CHECK(...)`
-✅ Converted `unexpected(...)` → `CHECK(!(...))`
-✅ Converted `testcase("name")` → `SUBCASE("name")`
-✅ Removed `BEAST_DEFINE_TESTSUITE` macros
-
-### Phase 2: Class Structure Refactoring (All 281 Files)
-✅ Removed all `class/struct X : public beast::unit_test::suite` inheritance
-✅ Converted test methods to `TEST_CASE` functions where appropriate
-✅ Moved helper functions to anonymous namespaces
-✅ Preserved `*this` context for tests that need it (JTX tests)
-
-## Files Converted by Directory
-
-| Directory | Files | Status |
-|-----------|-------|--------|
-| app/ (including tx/) | 71 | ✅ Complete |
-| jtx/ (including impl/) | 56 | ✅ Complete |
-| rpc/ | 48 | ✅ Complete |
-| protocol/ | 23 | ✅ Complete |
-| basics/ | 17 | ✅ Complete |
-| beast/ | 13 | ✅ Complete |
-| consensus/ | 9 | ✅ Complete |
-| overlay/ | 8 | ✅ Complete |
-| nodestore/ | 7 | ✅ Complete |
-| ledger/ | 6 | ✅ Complete |
-| csf/ (including impl/) | 6 | ✅ Complete |
-| core/ | 6 | ✅ Complete |
-| shamap/ | 3 | ✅ Complete |
-| peerfinder/ | 2 | ✅ Complete |
-| server/ | 2 | ✅ Complete |
-| json/ | 1 | ✅ Complete |
-| conditions/ | 1 | ✅ Complete |
-| resource/ | 1 | ✅ Complete |
-| unit_test/ | 1 | ✅ Complete |
-
-## Conversion Examples
-
-### Before (Beast Unit Test):
-```cpp
-#include <xrpl/beast/unit_test.h>
-
-namespace ripple {
-class MyFeature_test : public beast::unit_test::suite
-{
-public:
-    void testBasicFunctionality()
-    {
-        testcase("Basic Functionality");
-
-        BEAST_EXPECT(someFunction() == expected);
-        unexpected(someFunction() == wrong);
-    }
-
-    void run() override
-    {
-        testBasicFunctionality();
-    }
-};
-
-BEAST_DEFINE_TESTSUITE(MyFeature, module, ripple);
-}
-```
-
-### After (Doctest):
-```cpp
-#include <doctest/doctest.h>
-
-namespace ripple {
-
-TEST_CASE("Basic Functionality")
-{
-    CHECK(someFunction() == expected);
-    CHECK(!(someFunction() == wrong));
-}
-
-}
-```
-
-## Special Cases Handled
-
-### 1. JTX Tests (Tests using `Env{*this}`)
-For tests that require the test suite context (like JTX environment tests), the class structure is preserved but without Beast inheritance:
-
-```cpp
-// Structure kept for *this context
-class MyTest
-{
-    // test methods
-};
-
-TEST_CASE_METHOD(MyTest, "test name")
-{
-    testMethod();
-}
-```
-
-### 2. Helper Functions
-Private helper functions were moved to anonymous namespaces:
-
-```cpp
-namespace {
-    void helperFunction() { /* ... */ }
-} // anonymous namespace
-
-TEST_CASE("test using helper")
-{
-    helperFunction();
-}
-```
-
-### 3. Test Fixtures
-Tests that need setup/teardown or shared state use doctest fixtures naturally through the class structure.
-
-## Files Created During Conversion
-
-1. **[simple_convert.py](simple_convert.py)** - Initial regex-based conversion (281 files)
-2. **[refactor_to_testcase.py](refactor_to_testcase.py)** - Class structure refactoring (280 files)
-3. **[final_class_fix.py](final_class_fix.py)** - Final cleanup conversions (9 files)
-4. **[src/doctest/main.cpp](src/doctest/main.cpp)** - Doctest main entry point
-5. **[CONVERSION_SUMMARY.md](CONVERSION_SUMMARY.md)** - Initial conversion summary
-6. **[FINAL_CONVERSION_SUMMARY.md](FINAL_CONVERSION_SUMMARY.md)** - This document
-
-## Verification Commands
-
-```bash
-# Verify all files converted
-find src/doctest -name "*.cpp" -type f | wc -l
-# Output: 281
-
-# Verify no Beast inheritance remains (excluding helper files)
-grep -rE "(class|struct).*:.*beast::unit_test::suite" src/doctest/ \
-    | grep -v "jtx/impl/Env.cpp" \
-    | grep -v "multi_runner.cpp" \
-    | grep -v "beast::unit_test::suite&"
-# Output: (empty - all removed)
-
-# Count files with doctest includes
-grep -r "#include <doctest/doctest.h>" src/doctest/ | wc -l
-# Output: ~281
-
-# Verify CHECK macros are in use
-grep -r "CHECK(" src/doctest/ | wc -l
-# Output: Many thousands (all assertions converted)
-```
-
-## Next Steps
-
-To complete the migration and build the tests:
-
-### 1. Update Build Configuration
-Add doctest library and update CMakeLists.txt:
-
-```cmake
-# Find or add doctest
-find_package(doctest REQUIRED)
-
-# Add doctest tests
-add_executable(doctest_tests
-    src/doctest/main.cpp
-    # ... list all test files or use GLOB
-)
-
-target_link_libraries(doctest_tests PRIVATE doctest::doctest rippled_libs)
-```
-
-### 2. Install Doctest (if needed)
-```bash
-# Via package manager
-apt-get install doctest-dev  # Debian/Ubuntu
-brew install doctest          # macOS
-
-# Or as submodule
-git submodule add https://github.com/doctest/doctest.git external/doctest
-```
-
-### 3. Build and Run Tests
-```bash
-mkdir build && cd build
-cmake ..
-make doctest_tests
-./doctest_tests
-```
-
-### 4. Integration Options
-
-**Option A: Separate Binary**
-- Keep doctest tests in separate binary
-- Run alongside existing tests during transition
-
-**Option B: Complete Replacement**
-- Replace Beast test runner with doctest
-- Update CI/CD pipelines
-- Remove old test infrastructure
-
-**Option C: Gradual Migration**
-- Run both test suites in parallel
-- Migrate module by module
-- Verify identical behavior
-
-## Benefits of This Conversion
-
-✅ **Modern C++ Testing**: Doctest is actively maintained and follows modern C++ practices
-✅ **Faster Compilation**: Doctest is header-only and compiles faster than Beast
-✅ **Better IDE Support**: Better integration with modern IDEs and test runners
-✅ **Cleaner Syntax**: More intuitive `TEST_CASE` vs class-based approach
-✅ **Rich Features**: Better assertion messages, subcases, test fixtures
-✅ **Industry Standard**: Widely used in the C++ community
-
-## Test Coverage Preserved
-
-✅ All 281 test files converted
-✅ All test logic preserved
-✅ All assertions converted
-✅ All helper functions maintained
-✅ Zero tests lost in conversion
-
-## Conversion Quality
-
-- **Automated**: 95% of conversion done via scripts
-- **Manual Review**: Critical files manually verified
-- **Consistency**: Uniform conversion across all files
-- **Completeness**: No Beast dependencies remain (except 2 helper files)
-
-## Files Excluded from Conversion
-
-2 files were intentionally skipped as they are not test files:
-
-1. **src/doctest/unit_test/multi_runner.cpp** - Test runner utility, not a test
-2. **src/doctest/jtx/impl/Env.cpp** - Test environment implementation, not a test
-
-These files may still reference Beast for compatibility but don't affect the test suite.
-
-## Date
-
-**Conversion Completed**: December 11, 2024
-**Total Conversion Time**: Approximately 2-3 hours
-**Automation Level**: ~95% automated, 5% manual cleanup
-
-## Success Metrics
-
-- ✅ 281/281 files converted (100%)
-- ✅ 0 compilation errors in conversion (subject to build configuration)
-- ✅ 0 test files lost
-- ✅ All assertions converted
-- ✅ All Beast inheritance removed
-- ✅ Modern TEST_CASE structure implemented
-
----
-
-## Conclusion
-
-The conversion from Beast Unit Test framework to Doctest is **complete**. All 281 test files have been successfully converted with:
-
-- Modern doctest syntax
-- Removal of legacy class-based structure
-- Preservation of all test logic
-- Maintained test coverage
-- Clean, maintainable code structure
-
-The tests are now ready for integration into the build system!

UNIT_TEST_CONVERSION_PLAN.md

@@ -1,194 +0,0 @@
-# Unit Test Conversion Plan
-
-## Strategy: Hybrid Approach
-
-Convert only **standalone unit tests** to doctest, while keeping **integration tests** in the original Beast framework.
-
-## Classification Criteria
-
-### Unit Tests (Convert to Doctest)
-- ✅ Test a single class/function in isolation
-- ✅ No dependencies on test/jtx framework
-- ✅ No dependencies on test/csf framework
-- ✅ Don't require Env, Config, or Ledger setup
-- ✅ Pure logic/algorithm/data structure tests
-
-### Integration Tests (Keep in Beast)
-- ❌ Require Env class (ledger/transaction environment)
-- ❌ Require test/jtx utilities
-- ❌ Require test/csf (consensus simulation)
-- ❌ Multi-component interaction tests
-- ❌ End-to-end workflow tests
-
-## Test Module Analysis
-
-### ✅ Basics - CONVERT (Mostly Unit Tests)
-**Location**: `src/doctest/basics/`
-**Status**: Partially working
-**Action**:
-- Keep: Most files (Buffer, Expected, DetectCrash, IOUAmount, XRPAmount, etc.)
-- Exclude: FileUtilities_test.cpp (needs test/unit_test/FileDirGuard.h)
-
-### ✅ Protocol - CONVERT (Many Unit Tests)
-**Location**: `src/doctest/protocol/`
-**Status**: Partially working
-**Action**:
-- Keep: ApiVersion, BuildInfo, SecretKey, Seed, SeqProxy, Serializer, TER, STInteger, STNumber, STAccount, STTx
-- Exclude: All tests requiring test/jtx (9 files)
-- Fix: MultiApiJson (if CHECK pattern issues), PublicKey, Quality (add missing helpers)
-
-### ✅ Conditions - CONVERT
-**Location**: `src/doctest/conditions/`
-**Status**: Should work
-**Action**: Test build
-
-### ✅ JSON - CONVERT
-**Location**: `src/doctest/json/`
-**Status**: Should work
-**Action**: Test build
-
-### ❌ App - KEEP IN BEAST (Integration Tests)
-**Location**: `src/test/app/`
-**Reason**: All 71 files depend on test/jtx framework
-**Action**: Leave in original location
-
-### ❌ RPC - KEEP IN BEAST (Integration Tests)
-**Location**: `src/test/rpc/`
-**Reason**: All 48 files depend on test/jtx framework
-**Action**: Leave in original location
-
-### ❌ JTX - KEEP IN BEAST (Test Utilities)
-**Location**: `src/test/jtx/`
-**Reason**: These ARE the test utilities
-**Action**: Leave in original location
-
-### ❓ Beast - EVALUATE
-**Location**: `src/doctest/beast/`
-**Status**: Not properly converted
-**Action**: Check each file individually:
-- IPEndpoint_test.cpp - depends on test/beast/IPEndpointCommon.h (EXCLUDE)
-- LexicalCast_test.cpp - has class structure, uses testcase() (FIX or EXCLUDE)
-- Other files - evaluate case by case
-
-### ❌ Consensus - KEEP IN BEAST
-**Location**: `src/test/consensus/`
-**Reason**: Depends on test/csf framework
-**Action**: Leave in original location
-
-### ❌ Core - KEEP IN BEAST
-**Location**: `src/test/core/`
-**Reason**: Depends on test/jtx framework
-**Action**: Leave in original location
-
-### ❌ CSF - KEEP IN BEAST
-**Location**: `src/test/csf/`
-**Reason**: These tests use/test the CSF framework
-**Action**: Leave in original location
-
-### ❓ Ledger - EVALUATE
-**Location**: `src/doctest/ledger/`
-**Status**: Unknown
-**Action**: Check dependencies, likely many need test/jtx
-
-### ❓ Nodestore - EVALUATE
-**Location**: `src/doctest/nodestore/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Overlay - EVALUATE
-**Location**: `src/doctest/overlay/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Peerfinder - EVALUATE
-**Location**: `src/doctest/peerfinder/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Resource - EVALUATE
-**Location**: `src/doctest/resource/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Server - EVALUATE
-**Location**: `src/doctest/server/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ SHAMap - EVALUATE
-**Location**: `src/doctest/shamap/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Unit_test - EVALUATE
-**Location**: `src/doctest/unit_test/`
-**Status**: Unknown
-**Action**: These may be test utilities themselves
-
-## Implementation Steps
-
-### Phase 1: Fix Known Working Modules (1-2 hours)
-1. ✅ Fix basics tests (exclude FileUtilities_test.cpp)
-2. ✅ Fix protocol tests that should work (ApiVersion, BuildInfo already working)
-3. ✅ Test conditions module
-4. ✅ Test json module
-5. Update CMakeLists.txt to only build confirmed working modules
-
-### Phase 2: Evaluate Remaining Modules (2-3 hours)
-1. Check each "EVALUATE" module for test/jtx dependencies
-2. Create include/exclude lists for each module
-3. Identify which files are true unit tests
-
-### Phase 3: Fix Unit Tests (Variable time)
-1. For each identified unit test file:
-   - Fix any remaining Beast→doctest conversion issues
-   - Add missing helper functions if needed
-   - Ensure it compiles standalone
-2. Update CMakeLists.txt incrementally
-
-### Phase 4: Cleanup (1 hour)
-1. Move integration tests back to src/test/ if they were copied
-2. Update documentation
-3. Clean up src/doctest/ to only contain unit tests
-4. Update build system
-
-## Expected Outcome
-
-- **~50-100 true unit tests** converted to doctest (rough estimate)
-- **~180-230 integration tests** remain in Beast framework
-- Clear separation between unit and integration tests
-- Both frameworks coexist peacefully
-
-## Build System Structure
-
-```
-src/
-├── test/                          # Beast framework (integration tests)
-│   ├── app/                       # 71 files - ALL integration tests
-│   ├── rpc/                       # 48 files - ALL integration tests
-│   ├── jtx/                       # Test utilities
-│   ├── csf/                       # Consensus simulation framework
-│   ├── consensus/                 # Integration tests
-│   ├── core/                      # Integration tests
-│   └── [other integration tests]
-│
-└── doctest/                       # Doctest framework (unit tests only)
-    ├── basics/                    # ~15-16 unit tests
-    ├── protocol/                  # ~12-14 unit tests
-    ├── conditions/                # ~1 unit test
-    ├── json/                      # ~1 unit test
-    └── [other unit test modules TBD]
-```
-
-## Next Immediate Actions
-
-1. Test build basics module (exclude FileUtilities)
-2. Test build protocol module (with current exclusions)
-3. Test build conditions module
-4. Test build json module
-5. Create comprehensive scan of remaining modules
-
----
-
-**Status**: Ready to implement Phase 1
-**Updated**: December 11, 2024

include/xrpl/basics/Archive.h

@@ -3,7 +3,7 @@
 
 #include <boost/filesystem.hpp>
 
-namespace xrpl {
+namespace ripple {
 
 /** Extract a tar archive compressed with lz4
 
@@ -17,6 +17,6 @@ extractTarLz4(
     boost::filesystem::path const& src,
     boost::filesystem::path const& dst);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/BasicConfig.h

@@ -12,7 +12,7 @@
 #include <unordered_map>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 using IniFileSections =
     std::unordered_map<std::string, std::vector<std::string>>;
@@ -380,6 +380,6 @@ get_if_exists<bool>(Section const& section, std::string const& name, bool& v)
     return stat;
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/Blob.h

@@ -3,13 +3,13 @@
 
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 /** Storage for linear binary data.
     Blocks of binary data appear often in various idioms and structures.
 */
 using Blob = std::vector<unsigned char>;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/Buffer.h

@@ -8,7 +8,7 @@
 #include <cstring>
 #include <memory>
 
-namespace xrpl {
+namespace ripple {
 
 /** Like std::vector<char> but better.
     Meets the requirements of BufferFactory.
@@ -96,7 +96,7 @@ public:
         XRPL_ASSERT(
             s.size() == 0 || size_ == 0 || s.data() < p_.get() ||
                 s.data() >= p_.get() + size_,
-            "xrpl::Buffer::operator=(Slice) : input not a subset");
+            "ripple::Buffer::operator=(Slice) : input not a subset");
 
         if (auto p = alloc(s.size()))
             std::memcpy(p, s.data(), s.size());
@@ -215,6 +215,6 @@ operator!=(Buffer const& lhs, Buffer const& rhs) noexcept
     return !(lhs == rhs);
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/ByteUtilities.h

@@ -1,7 +1,7 @@
 #ifndef XRPL_BASICS_BYTEUTILITIES_H_INCLUDED
 #define XRPL_BASICS_BYTEUTILITIES_H_INCLUDED
 
-namespace xrpl {
+namespace ripple {
 
 template <class T>
 constexpr auto
@@ -19,6 +19,6 @@ megabytes(T value) noexcept
 
 static_assert(kilobytes(2) == 2048, "kilobytes(2) == 2048");
 static_assert(megabytes(3) == 3145728, "megabytes(3) == 3145728");
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/CompressionAlgorithms.h

@@ -10,7 +10,7 @@
 #include <stdexcept>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 namespace compression_algorithms {
 
@@ -144,6 +144,6 @@ lz4Decompress(
 
 }  // namespace compression_algorithms
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_COMPRESSIONALGORITHMS_H_INCLUDED

include/xrpl/basics/CountedObject.h

@@ -8,7 +8,7 @@
 #include <utility>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 /** Manages all counted object types. */
 class CountedObjects
@@ -133,6 +133,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/DecayingSample.h

@@ -4,7 +4,7 @@
 #include <chrono>
 #include <cmath>
 
-namespace xrpl {
+namespace ripple {
 
 /** Sampling function using exponential decay to provide a continuous value.
     @tparam The number of seconds in the decay window.
@@ -131,6 +131,6 @@ private:
     time_point when_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/Expected.h

@@ -7,7 +7,7 @@
 
 #include <stdexcept>
 
-namespace xrpl {
+namespace ripple {
 
 /** Expected is an approximation of std::expected (hoped for in C++23)
 
@@ -232,6 +232,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_EXPECTED_H_INCLUDED

include/xrpl/basics/FileUtilities.h

@@ -6,7 +6,7 @@
 
 #include <optional>
 
-namespace xrpl {
+namespace ripple {
 
 std::string
 getFileContents(
@@ -20,6 +20,6 @@ writeFileContents(
     boost::filesystem::path const& destPath,
     std::string const& contents);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/IntrusivePointer.h

@@ -6,7 +6,7 @@
 #include <type_traits>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 //------------------------------------------------------------------------------
 
@@ -492,5 +492,5 @@ dynamic_pointer_cast(TT const& v)
     return SharedPtr<T>(DynamicCastTagSharedIntrusive{}, v);
 }
 }  // namespace intr_ptr
-}  // namespace xrpl
+}  // namespace ripple
 #endif

include/xrpl/basics/IntrusivePointer.ipp

@@ -6,7 +6,7 @@
 
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 template <class T>
 template <CAdoptTag TAdoptTag>
@@ -608,7 +608,7 @@ SharedWeakUnion<T>::convertToStrong()
         [[maybe_unused]] auto action = p->releaseWeakRef();
         XRPL_ASSERT(
             (action == ReleaseWeakRefAction::noop),
-            "xrpl::SharedWeakUnion::convertToStrong : "
+            "ripple::SharedWeakUnion::convertToStrong : "
             "action is noop");
         unsafeSetRawPtr(p, RefStrength::strong);
         return true;
@@ -637,7 +637,7 @@ SharedWeakUnion<T>::convertToWeak()
             // We just added a weak ref. How could we destroy?
             // LCOV_EXCL_START
             UNREACHABLE(
-                "xrpl::SharedWeakUnion::convertToWeak : destroying freshly "
+                "ripple::SharedWeakUnion::convertToWeak : destroying freshly "
                 "added ref");
             delete p;
             unsafeSetRawPtr(nullptr);
@@ -719,5 +719,5 @@ SharedWeakUnion<T>::unsafeReleaseNoStore()
     }
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 #endif

include/xrpl/basics/IntrusiveRefCounts.h

@@ -6,7 +6,7 @@
 #include <atomic>
 #include <cstdint>
 
-namespace xrpl {
+namespace ripple {
 
 /** Action to perform when releasing a strong pointer.
 
@@ -34,7 +34,7 @@ enum class ReleaseWeakRefAction { noop, destroy };
 /** Implement the strong count, weak count, and bit flags for an intrusive
     pointer.
 
-    A class can satisfy the requirements of a xrpl::IntrusivePointer by
+    A class can satisfy the requirements of a ripple::IntrusivePointer by
     inheriting from this class.
   */
 struct IntrusiveRefCounts
@@ -257,7 +257,7 @@ IntrusiveRefCounts::releaseStrongRef() const
         RefCountPair const prevVal{prevIntVal};
         XRPL_ASSERT(
             (prevVal.strong >= strongDelta),
-            "xrpl::IntrusiveRefCounts::releaseStrongRef : previous ref "
+            "ripple::IntrusiveRefCounts::releaseStrongRef : previous ref "
             "higher than new");
         auto nextIntVal = prevIntVal - strongDelta;
         ReleaseStrongRefAction action = noop;
@@ -282,7 +282,7 @@ IntrusiveRefCounts::releaseStrongRef() const
             // twice.
             XRPL_ASSERT(
                 (action == noop) || !(prevIntVal & partialDestroyStartedMask),
-                "xrpl::IntrusiveRefCounts::releaseStrongRef : not in partial "
+                "ripple::IntrusiveRefCounts::releaseStrongRef : not in partial "
                 "destroy");
             return action;
         }
@@ -314,7 +314,7 @@ IntrusiveRefCounts::addWeakReleaseStrongRef() const
         // can't happen twice.
         XRPL_ASSERT(
             (!prevVal.partialDestroyStartedBit),
-            "xrpl::IntrusiveRefCounts::addWeakReleaseStrongRef : not in "
+            "ripple::IntrusiveRefCounts::addWeakReleaseStrongRef : not in "
             "partial destroy");
 
         auto nextIntVal = prevIntVal + delta;
@@ -336,7 +336,7 @@ IntrusiveRefCounts::addWeakReleaseStrongRef() const
         {
             XRPL_ASSERT(
                 (!(prevIntVal & partialDestroyStartedMask)),
-                "xrpl::IntrusiveRefCounts::addWeakReleaseStrongRef : not "
+                "ripple::IntrusiveRefCounts::addWeakReleaseStrongRef : not "
                 "started partial destroy");
             return action;
         }
@@ -408,11 +408,11 @@ inline IntrusiveRefCounts::~IntrusiveRefCounts() noexcept
     auto v = refCounts.load(std::memory_order_acquire);
     XRPL_ASSERT(
         (!(v & valueMask)),
-        "xrpl::IntrusiveRefCounts::~IntrusiveRefCounts : count must be zero");
+        "ripple::IntrusiveRefCounts::~IntrusiveRefCounts : count must be zero");
     auto t = v & tagMask;
     XRPL_ASSERT(
         (!t || t == tagMask),
-        "xrpl::IntrusiveRefCounts::~IntrusiveRefCounts : valid tag");
+        "ripple::IntrusiveRefCounts::~IntrusiveRefCounts : valid tag");
 #endif
 }
 
@@ -427,7 +427,7 @@ inline IntrusiveRefCounts::RefCountPair::RefCountPair(
 {
     XRPL_ASSERT(
         (strong < checkStrongMaxValue && weak < checkWeakMaxValue),
-        "xrpl::IntrusiveRefCounts::RefCountPair(FieldType) : inputs inside "
+        "ripple::IntrusiveRefCounts::RefCountPair(FieldType) : inputs inside "
         "range");
 }
 
@@ -438,7 +438,7 @@ inline IntrusiveRefCounts::RefCountPair::RefCountPair(
 {
     XRPL_ASSERT(
         (strong < checkStrongMaxValue && weak < checkWeakMaxValue),
-        "xrpl::IntrusiveRefCounts::RefCountPair(CountType, CountType) : "
+        "ripple::IntrusiveRefCounts::RefCountPair(CountType, CountType) : "
         "inputs inside range");
 }
 
@@ -447,7 +447,7 @@ IntrusiveRefCounts::RefCountPair::combinedValue() const noexcept
 {
     XRPL_ASSERT(
         (strong < checkStrongMaxValue && weak < checkWeakMaxValue),
-        "xrpl::IntrusiveRefCounts::RefCountPair::combinedValue : inputs "
+        "ripple::IntrusiveRefCounts::RefCountPair::combinedValue : inputs "
         "inside range");
     return (static_cast<IntrusiveRefCounts::FieldType>(weak)
             << IntrusiveRefCounts::StrongCountNumBits) |
@@ -465,7 +465,7 @@ partialDestructorFinished(T** o)
     XRPL_ASSERT(
         (!p.partialDestroyFinishedBit && p.partialDestroyStartedBit &&
          !p.strong),
-        "xrpl::partialDestructorFinished : not a weak ref");
+        "ripple::partialDestructorFinished : not a weak ref");
     if (!p.weak)
     {
         // There was a weak count before the partial destructor ran (or we would
@@ -479,5 +479,5 @@ partialDestructorFinished(T** o)
 }
 //------------------------------------------------------------------------------
 
-}  // namespace xrpl
+}  // namespace ripple
 #endif

include/xrpl/basics/KeyCache.h

@@ -4,10 +4,10 @@
 #include <xrpl/basics/TaggedCache.h>
 #include <xrpl/basics/base_uint.h>
 
-namespace xrpl {
+namespace ripple {
 
 using KeyCache = TaggedCache<uint256, int, true>;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_KEYCACHE_H

include/xrpl/basics/LocalValue.h

@@ -6,7 +6,7 @@
 #include <memory>
 #include <unordered_map>
 
-namespace xrpl {
+namespace ripple {
 
 namespace detail {
 
@@ -109,6 +109,6 @@ LocalValue<T>::operator*()
             .emplace(this, std::make_unique<detail::LocalValues::Value<T>>(t_))
             .first->second->get());
 }
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/Log.h

@@ -13,7 +13,7 @@
 #include <mutex>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 // DEPRECATED use beast::severities::Severity instead
 enum LogSeverity {
@@ -271,6 +271,6 @@ setDebugLogSink(std::unique_ptr<beast::Journal::Sink> sink);
 beast::Journal
 debugLog();
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/MathUtilities.h

@@ -5,7 +5,7 @@
 #include <cassert>
 #include <cstddef>
 
-namespace xrpl {
+namespace ripple {
 
 /** Calculate one number divided by another number in percentage.
  * The result is rounded up to the next integer, and capped in the range [0,100]
@@ -44,6 +44,6 @@ static_assert(calculatePercent(50'000'000, 100'000'000) == 50);
 static_assert(calculatePercent(50'000'001, 100'000'000) == 51);
 static_assert(calculatePercent(99'999'999, 100'000'000) == 100);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/Number.h

@@ -6,7 +6,7 @@
 #include <ostream>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 class Number;
 
@@ -402,6 +402,6 @@ public:
     operator=(NumberRoundModeGuard const&) = delete;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_NUMBER_H_INCLUDED

include/xrpl/basics/README.md

@@ -21,11 +21,11 @@ ripple/basic should contain no dependencies on other modules.
 - `std::set`
   - For sorted containers.
 
-- `xrpl::hash_set`
+- `ripple::hash_set`
   - Where inserts and contains need to be O(1).
   - For "small" sets, `std::set` might be faster and smaller.
 
-- `xrpl::hardened_hash_set`
+- `ripple::hardened_hash_set`
   - For data sets where the key could be manipulated by an attacker
     in an attempt to mount an algorithmic complexity attack: see
     http://en.wikipedia.org/wiki/Algorithmic_complexity_attack
@@ -33,5 +33,5 @@ ripple/basic should contain no dependencies on other modules.
 The following container is deprecated
 
 - `std::unordered_set`
-- Use `xrpl::hash_set` instead, which uses a better hashing algorithm.
-- Or use `xrpl::hardened_hash_set` to prevent algorithmic complexity attacks.
+- Use `ripple::hash_set` instead, which uses a better hashing algorithm.
+- Or use `ripple::hardened_hash_set` to prevent algorithmic complexity attacks.

include/xrpl/basics/RangeSet.h

@@ -11,7 +11,7 @@
 #include <string>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 /** A closed interval over the domain T.
 
@@ -85,7 +85,7 @@ to_string(RangeSet<T> const& rs)
 
     std::string s;
     for (auto const& interval : rs)
-        s += xrpl::to_string(interval) + ",";
+        s += ripple::to_string(interval) + ",";
     s.pop_back();
 
     return s;
@@ -172,6 +172,6 @@ prevMissing(RangeSet<T> const& rs, T t, T minVal = 0)
     return boost::icl::last(tgt);
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/Resolver.h

@@ -6,7 +6,7 @@
 #include <functional>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 class Resolver
 {
@@ -47,6 +47,6 @@ public:
     /** @} */
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/ResolverAsio.h

@@ -6,7 +6,7 @@
 
 #include <boost/asio/io_context.hpp>
 
-namespace xrpl {
+namespace ripple {
 
 class ResolverAsio : public Resolver
 {
@@ -17,6 +17,6 @@ public:
     New(boost::asio::io_context&, beast::Journal);
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/SHAMapHash.h

@@ -6,7 +6,7 @@
 
 #include <ostream>
 
-namespace xrpl {
+namespace ripple {
 
 // A SHAMapHash is the hash of a node in a SHAMap, and also the
 // type of the hash of the entire SHAMap.
@@ -97,6 +97,6 @@ extract(SHAMapHash const& key)
     return *reinterpret_cast<std::size_t const*>(key.as_uint256().data());
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_SHAMAP_HASH_H_INCLUDED

include/xrpl/basics/SharedWeakCachePointer.h

@@ -4,7 +4,7 @@
 #include <memory>
 #include <variant>
 
-namespace xrpl {
+namespace ripple {
 
 /** A combination of a std::shared_ptr and a std::weak_pointer.
 
@@ -112,5 +112,5 @@ public:
 private:
     std::variant<std::shared_ptr<T>, std::weak_ptr<T>> combo_;
 };
-}  // namespace xrpl
+}  // namespace ripple
 #endif

include/xrpl/basics/SharedWeakCachePointer.ipp

@@ -3,7 +3,7 @@
 
 #include <xrpl/basics/SharedWeakCachePointer.h>
 
-namespace xrpl {
+namespace ripple {
 template <class T>
 SharedWeakCachePointer<T>::SharedWeakCachePointer(
     SharedWeakCachePointer const& rhs) = default;
@@ -169,5 +169,5 @@ SharedWeakCachePointer<T>::convertToWeak()
 
     return false;
 }
-}  // namespace xrpl
+}  // namespace ripple
 #endif

include/xrpl/basics/SlabAllocator.h

@@ -22,7 +22,7 @@
 #include <sys/mman.h>
 #endif
 
-namespace xrpl {
+namespace ripple {
 
 template <typename Type>
 class SlabAllocator
@@ -128,7 +128,7 @@ class SlabAllocator
         {
             XRPL_ASSERT(
                 own(ptr),
-                "xrpl::SlabAllocator::SlabBlock::deallocate : own input");
+                "ripple::SlabAllocator::SlabBlock::deallocate : own input");
 
             std::lock_guard l(m_);
 
@@ -173,7 +173,7 @@ public:
     {
         XRPL_ASSERT(
             (itemAlignment_ & (itemAlignment_ - 1)) == 0,
-            "xrpl::SlabAllocator::SlabAllocator : valid alignment");
+            "ripple::SlabAllocator::SlabAllocator : valid alignment");
     }
 
     SlabAllocator(SlabAllocator const& other) = delete;
@@ -285,7 +285,7 @@ public:
     {
         XRPL_ASSERT(
             ptr,
-            "xrpl::SlabAllocator::SlabAllocator::deallocate : non-null "
+            "ripple::SlabAllocator::SlabAllocator::deallocate : non-null "
             "input");
 
         for (auto slab = slabs_.load(); slab != nullptr; slab = slab->next_)
@@ -419,6 +419,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_SLABALLOCATOR_H_INCLUDED

include/xrpl/basics/Slice.h

@@ -15,7 +15,7 @@
 #include <type_traits>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 /** An immutable linear range of bytes.
 
@@ -87,7 +87,7 @@ public:
     {
         XRPL_ASSERT(
             i < size_,
-            "xrpl::Slice::operator[](std::size_t) const : valid input");
+            "ripple::Slice::operator[](std::size_t) const : valid input");
         return data_[i];
     }
 
@@ -243,6 +243,6 @@ makeSlice(std::basic_string<char, Traits, Alloc> const& s)
     return Slice(s.data(), s.size());
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/StringUtilities.h

@@ -12,7 +12,7 @@
 #include <optional>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 /** Format arbitrary binary data as an SQLite "blob literal".
 
@@ -132,6 +132,6 @@ to_uint64(std::string const& s);
 bool
 isProperlyFormedTomlDomain(std::string_view domain);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/TaggedCache.h

@@ -16,7 +16,7 @@
 #include <type_traits>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 /** Map/cache combination.
     This class implements a cache and a map. The cache keeps objects alive
@@ -315,6 +315,6 @@ private:
     std::uint64_t m_misses;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/TaggedCache.ipp

@@ -4,7 +4,7 @@
 #include <xrpl/basics/IntrusivePointer.ipp>
 #include <xrpl/basics/TaggedCache.h>
 
-namespace xrpl {
+namespace ripple {
 
 template <
     class Key,
@@ -1005,6 +1005,6 @@ TaggedCache<
     });
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/ToString.h

@@ -4,7 +4,7 @@
 #include <string>
 #include <type_traits>
 
-namespace xrpl {
+namespace ripple {
 
 /** to_string() generalizes std::to_string to handle bools, chars, and strings.
 
@@ -43,6 +43,6 @@ to_string(char const* s)
     return s;
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/UnorderedContainers.h

@@ -22,7 +22,7 @@
  * what container it is.
  */
 
-namespace xrpl {
+namespace ripple {
 
 // hash containers
 
@@ -102,6 +102,6 @@ template <
 using hardened_hash_multiset =
     std::unordered_multiset<Value, Hash, Pred, Allocator>;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/UptimeClock.h

@@ -6,7 +6,7 @@
 #include <ratio>
 #include <thread>
 
-namespace xrpl {
+namespace ripple {
 
 /** Tracks program uptime to seconds precision.
 
@@ -45,6 +45,6 @@ private:
     start_clock();
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/algorithm.h

@@ -3,7 +3,7 @@
 
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 // Requires: [first1, last1) and [first2, last2) are ordered ranges according to
 // comp.
@@ -95,6 +95,6 @@ remove_if_intersect_or_match(
     return first1;
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/base64.h

@@ -38,7 +38,7 @@
 #include <cstdint>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 std::string
 base64_encode(std::uint8_t const* data, std::size_t len);
@@ -53,6 +53,6 @@ base64_encode(std::string const& s)
 std::string
 base64_decode(std::string_view data);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/base_uint.h

@@ -23,7 +23,7 @@
 #include <cstring>
 #include <type_traits>
 
-namespace xrpl {
+namespace ripple {
 
 namespace detail {
 
@@ -275,7 +275,7 @@ public:
     {
         XRPL_ASSERT(
             c.size() * sizeof(typename Container::value_type) == size(),
-            "xrpl::base_uint::base_uint(Container auto) : input size match");
+            "ripple::base_uint::base_uint(Container auto) : input size match");
         std::memcpy(data_.data(), c.data(), size());
     }
 
@@ -288,7 +288,7 @@ public:
     {
         XRPL_ASSERT(
             c.size() * sizeof(typename Container::value_type) == size(),
-            "xrpl::base_uint::operator=(Container auto) : input size match");
+            "ripple::base_uint::operator=(Container auto) : input size match");
         std::memcpy(data_.data(), c.data(), size());
         return *this;
     }
@@ -648,12 +648,12 @@ static_assert(sizeof(uint192) == 192 / 8, "There should be no padding bytes");
 static_assert(sizeof(uint256) == 256 / 8, "There should be no padding bytes");
 #endif
 
-}  // namespace xrpl
+}  // namespace ripple
 
 namespace beast {
 
 template <std::size_t Bits, class Tag>
-struct is_uniquely_represented<xrpl::base_uint<Bits, Tag>>
+struct is_uniquely_represented<ripple::base_uint<Bits, Tag>>
     : public std::true_type
 {
     explicit is_uniquely_represented() = default;

include/xrpl/basics/chrono.h

@@ -12,7 +12,7 @@
 #include <ratio>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 // A few handy aliases
 
@@ -104,6 +104,6 @@ stopwatch()
     return beast::get_abstract_clock<Facade, Clock>();
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/comparators.h

@@ -3,7 +3,7 @@
 
 #include <functional>
 
-namespace xrpl {
+namespace ripple {
 
 #ifdef _MSC_VER
 
@@ -52,6 +52,6 @@ using equal_to = std::equal_to<T>;
 
 #endif
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/contract.h

@@ -7,7 +7,7 @@
 #include <string>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 /*  Programming By Contract
 
@@ -52,6 +52,6 @@ Throw(Args&&... args)
 [[noreturn]] void
 LogicError(std::string const& how) noexcept;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/hardened_hash.h

@@ -9,7 +9,7 @@
 #include <random>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 namespace detail {
 
@@ -92,6 +92,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/join.h

@@ -3,7 +3,7 @@
 
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 template <class Stream, class Iter>
 Stream&
@@ -85,6 +85,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/make_SSLContext.h

@@ -5,7 +5,7 @@
 
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 /** Create a self-signed SSL context that allows anonymous Diffie Hellman. */
 std::shared_ptr<boost::asio::ssl::context>
@@ -19,6 +19,6 @@ make_SSLContextAuthed(
     std::string const& chainFile,
     std::string const& cipherList);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/mulDiv.h

@@ -5,7 +5,7 @@
 #include <limits>
 #include <optional>
 
-namespace xrpl {
+namespace ripple {
 auto constexpr muldiv_max = std::numeric_limits<std::uint64_t>::max();
 
 /** Return value*mul/div accurately.
@@ -21,6 +21,6 @@ auto constexpr muldiv_max = std::numeric_limits<std::uint64_t>::max();
 std::optional<std::uint64_t>
 mulDiv(std::uint64_t value, std::uint64_t mul, std::uint64_t div);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/partitioned_unordered_map.h

@@ -12,7 +12,7 @@
 #include <utility>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 template <typename Key>
 static std::size_t
@@ -242,7 +242,7 @@ public:
         map_.resize(partitions_);
         XRPL_ASSERT(
             partitions_,
-            "xrpl::partitioned_unordered_map::partitioned_unordered_map : "
+            "ripple::partitioned_unordered_map::partitioned_unordered_map : "
             "nonzero partitions");
     }
 
@@ -401,6 +401,6 @@ private:
     mutable partition_map_type map_{};
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_PARTITIONED_UNORDERED_MAP_H

include/xrpl/basics/random.h

@@ -11,7 +11,7 @@
 #include <random>
 #include <type_traits>
 
-namespace xrpl {
+namespace ripple {
 
 #ifndef __INTELLISENSE__
 static_assert(
@@ -95,7 +95,7 @@ std::enable_if_t<
     Integral>
 rand_int(Engine& engine, Integral min, Integral max)
 {
-    XRPL_ASSERT(max > min, "xrpl::rand_int : max over min inputs");
+    XRPL_ASSERT(max > min, "ripple::rand_int : max over min inputs");
 
     // This should have no state and constructing it should
     // be very cheap. If that turns out not to be the case
@@ -186,6 +186,6 @@ rand_bool()
 }
 /** @} */
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_BASICS_RANDOM_H_INCLUDED

include/xrpl/basics/safe_cast.h

@@ -3,7 +3,7 @@
 
 #include <type_traits>
 
-namespace xrpl {
+namespace ripple {
 
 // safe_cast adds compile-time checks to a static_cast to ensure that
 // the destination can hold all values of the source.  This is particularly
@@ -80,6 +80,6 @@ inline constexpr std::
     return unsafe_cast<Dest>(static_cast<std::underlying_type_t<Src>>(s));
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/scope.h

@@ -8,7 +8,7 @@
 #include <type_traits>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 // RAII scope helpers.  As specified in Library Fundamental, Version 3
 // Basic design of idea:  https://www.youtube.com/watch?v=WjTrfoiB0MQ
@@ -218,7 +218,7 @@ public:
     {
         XRPL_ASSERT(
             plock->owns_lock(),
-            "xrpl::scope_unlock::scope_unlock : mutex must be locked");
+            "ripple::scope_unlock::scope_unlock : mutex must be locked");
         plock->unlock();
     }
 
@@ -236,6 +236,6 @@ public:
 template <class Mutex>
 scope_unlock(std::unique_lock<Mutex>&) -> scope_unlock<Mutex>;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/spinlock.h

@@ -13,7 +13,7 @@
 #include <immintrin.h>
 #endif
 
-namespace xrpl {
+namespace ripple {
 
 namespace detail {
 /** Inform the processor that we are in a tight spin-wait loop.
@@ -105,7 +105,7 @@ public:
     {
         XRPL_ASSERT(
             index >= 0 && (mask_ != 0),
-            "xrpl::packed_spinlock::packed_spinlock : valid index and mask");
+            "ripple::packed_spinlock::packed_spinlock : valid index and mask");
     }
 
     [[nodiscard]] bool
@@ -206,6 +206,6 @@ public:
 };
 /** @} */
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/strHex.h

@@ -4,7 +4,7 @@
 #include <boost/algorithm/hex.hpp>
 #include <boost/endian/conversion.hpp>
 
-namespace xrpl {
+namespace ripple {
 
 template <class FwdIt>
 std::string
@@ -28,6 +28,6 @@ strHex(T const& from)
     return strHex(from.begin(), from.end());
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/basics/tagged_integer.h

@@ -10,7 +10,7 @@
 #include <iostream>
 #include <type_traits>
 
-namespace xrpl {
+namespace ripple {
 
 /** A type-safe wrap around standard integral types
 
@@ -197,11 +197,11 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 namespace beast {
 template <class Int, class Tag, class HashAlgorithm>
-struct is_contiguously_hashable<xrpl::tagged_integer<Int, Tag>, HashAlgorithm>
+struct is_contiguously_hashable<ripple::tagged_integer<Int, Tag>, HashAlgorithm>
     : public is_contiguously_hashable<Int, HashAlgorithm>
 {
     explicit is_contiguously_hashable() = default;

include/xrpl/core/ClosureCounter.h

@@ -8,7 +8,7 @@
 #include <mutex>
 #include <optional>
 
-namespace xrpl {
+namespace ripple {
 
 /**
  * The role of a `ClosureCounter` is to assist in shutdown by letting callers
@@ -202,6 +202,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_CORE_CLOSURE_COUNTER_H_INCLUDED

include/xrpl/core/Coro.ipp

@@ -3,7 +3,7 @@
 
 #include <xrpl/basics/ByteUtilities.h>
 
-namespace xrpl {
+namespace ripple {
 
 template <class F>
 JobQueue::Coro::Coro(
@@ -34,7 +34,7 @@ JobQueue::Coro::Coro(
 inline JobQueue::Coro::~Coro()
 {
 #ifndef NDEBUG
-    XRPL_ASSERT(finished_, "xrpl::JobQueue::Coro::~Coro : is finished");
+    XRPL_ASSERT(finished_, "ripple::JobQueue::Coro::~Coro : is finished");
 #endif
 }
 
@@ -85,7 +85,8 @@ JobQueue::Coro::resume()
     detail::getLocalValues().reset(&lvs_);
     std::lock_guard lock(mutex_);
     XRPL_ASSERT(
-        static_cast<bool>(coro_), "xrpl::JobQueue::Coro::resume : is runnable");
+        static_cast<bool>(coro_),
+        "ripple::JobQueue::Coro::resume : is runnable");
     coro_();
     detail::getLocalValues().release();
     detail::getLocalValues().reset(saved);
@@ -128,6 +129,6 @@ JobQueue::Coro::join()
     cv_.wait(lk, [this]() { return running_ == false; });
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/Job.h

@@ -7,7 +7,7 @@
 
 #include <functional>
 
-namespace xrpl {
+namespace ripple {
 
 // Note that this queue should only be used for CPU-bound jobs
 // It is primarily intended for signature checking
@@ -131,6 +131,6 @@ private:
 
 using JobCounter = ClosureCounter<void>;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/JobQueue.h

@@ -12,7 +12,7 @@
 
 #include <set>
 
-namespace xrpl {
+namespace ripple {
 
 namespace perf {
 class PerfLog;
@@ -382,11 +382,11 @@ private:
             lock is released which only happens after the coroutine completes.
 */
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #include <xrpl/core/Coro.ipp>
 
-namespace xrpl {
+namespace ripple {
 
 template <class F>
 std::shared_ptr<JobQueue::Coro>
@@ -408,6 +408,6 @@ JobQueue::postCoro(JobType t, std::string const& name, F&& f)
     return coro;
 }
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/JobTypeData.h

@@ -5,7 +5,7 @@
 #include <xrpl/beast/insight/Collector.h>
 #include <xrpl/core/JobTypeInfo.h>
 
-namespace xrpl {
+namespace ripple {
 
 struct JobTypeData
 {
@@ -83,6 +83,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/JobTypeInfo.h

@@ -3,7 +3,7 @@
 
 #include <xrpl/core/Job.h>
 
-namespace xrpl {
+namespace ripple {
 
 /** Holds all the 'static' information about a job, which does not change */
 class JobTypeInfo
@@ -78,6 +78,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/JobTypes.h

@@ -7,7 +7,7 @@
 #include <map>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 class JobTypes
 {
@@ -35,7 +35,7 @@ private:
                        std::chrono::milliseconds peakLatency) {
             XRPL_ASSERT(
                 m_map.find(jt) == m_map.end(),
-                "xrpl::JobTypes::JobTypes::add : unique job type input");
+                "ripple::JobTypes::JobTypes::add : unique job type input");
 
             [[maybe_unused]] auto const inserted =
                 m_map
@@ -48,7 +48,7 @@ private:
 
             XRPL_ASSERT(
                 inserted == true,
-                "xrpl::JobTypes::JobTypes::add : input is inserted");
+                "ripple::JobTypes::JobTypes::add : input is inserted");
         };
 
         // clang-format off
@@ -122,7 +122,7 @@ public:
     get(JobType jt) const
     {
         Map::const_iterator const iter(m_map.find(jt));
-        XRPL_ASSERT(iter != m_map.end(), "xrpl::JobTypes::get : valid input");
+        XRPL_ASSERT(iter != m_map.end(), "ripple::JobTypes::get : valid input");
 
         if (iter != m_map.end())
             return iter->second;
@@ -170,6 +170,6 @@ public:
     Map m_map;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/LoadEvent.h

@@ -4,7 +4,7 @@
 #include <chrono>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 class LoadMonitor;
 
@@ -65,6 +65,6 @@ private:
     std::chrono::steady_clock::duration timeRunning_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/LoadMonitor.h

@@ -8,7 +8,7 @@
 #include <chrono>
 #include <mutex>
 
-namespace xrpl {
+namespace ripple {
 
 // Monitors load levels and response times
 
@@ -67,6 +67,6 @@ private:
     beast::Journal const j_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/PerfLog.h

@@ -17,7 +17,7 @@ namespace beast {
 class Journal;
 }
 
-namespace xrpl {
+namespace ripple {
 class Application;
 namespace perf {
 
@@ -187,6 +187,6 @@ measureDurationAndLog(
 }
 
 }  // namespace perf
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif  // XRPL_CORE_PERFLOG_H

include/xrpl/core/detail/Workers.h

@@ -10,7 +10,7 @@
 #include <string>
 #include <thread>
 
-namespace xrpl {
+namespace ripple {
 
 namespace perf {
 class PerfLog;
@@ -214,6 +214,6 @@ private:
         m_paused;  // holds just paused workers
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/core/detail/semaphore.h

@@ -1,6 +1,6 @@
 /**
  *
- * TODO: Remove xrpl::basic_semaphore (and this file) and use
+ * TODO: Remove ripple::basic_semaphore (and this file) and use
  * std::counting_semaphore.
  *
  * Background:
@@ -32,7 +32,7 @@
 #include <condition_variable>
 #include <mutex>
 
-namespace xrpl {
+namespace ripple {
 
 template <class Mutex, class CondVar>
 class basic_semaphore
@@ -87,6 +87,6 @@ public:
 
 using semaphore = basic_semaphore<std::mutex, std::condition_variable>;
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/crypto/RFC1751.h

@@ -4,7 +4,7 @@
 #include <string>
 #include <vector>
 
-namespace xrpl {
+namespace ripple {
 
 class RFC1751
 {
@@ -42,6 +42,6 @@ private:
     static char const* s_dictionary[];
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/crypto/csprng.h

@@ -3,7 +3,7 @@
 
 #include <mutex>
 
-namespace xrpl {
+namespace ripple {
 
 /** A cryptographically secure random number engine
 
@@ -70,6 +70,6 @@ public:
 csprng_engine&
 crypto_prng();
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/crypto/secure_erase.h

@@ -3,7 +3,7 @@
 
 #include <cstddef>
 
-namespace xrpl {
+namespace ripple {
 
 /** Attempts to clear the given blob of memory.
 
@@ -22,6 +22,6 @@ namespace xrpl {
 void
 secure_erase(void* dest, std::size_t bytes);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/json/JsonPropertyStream.h

@@ -4,7 +4,7 @@
 #include <xrpl/beast/utility/PropertyStream.h>
 #include <xrpl/json/json_value.h>
 
-namespace xrpl {
+namespace ripple {
 
 /** A PropertyStream::Sink which produces a Json::Value of type objectValue. */
 class JsonPropertyStream : public beast::PropertyStream
@@ -66,6 +66,6 @@ protected:
     add(std::string const& v) override;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/json/Writer.h

@@ -234,7 +234,7 @@ inline void
 check(bool condition, std::string const& message)
 {
     if (!condition)
-        xrpl::Throw<std::logic_error>(message);
+        ripple::Throw<std::logic_error>(message);
 }
 
 }  // namespace Json

include/xrpl/json/detail/json_assert.h

@@ -6,6 +6,6 @@
 
 #define JSON_ASSERT_MESSAGE(condition, message) \
     if (!(condition))                           \
-        xrpl::Throw<Json::error>(message);
+        ripple::Throw<Json::error>(message);
 
 #endif

include/xrpl/json/json_value.h

@@ -199,7 +199,7 @@ public:
     Value(UInt value);
     Value(double value);
     Value(char const* value);
-    Value(xrpl::Number const& value);
+    Value(ripple::Number const& value);
     /** \brief Constructs a value from a static string.
 
      * Like other value string constructor but do not duplicate the string for
@@ -430,7 +430,7 @@ private:
 };
 
 inline Value
-to_json(xrpl::Number const& number)
+to_json(ripple::Number const& number)
 {
     return to_string(number);
 }

include/xrpl/ledger/ApplyView.h

@@ -6,7 +6,7 @@
 #include <xrpl/ledger/RawView.h>
 #include <xrpl/ledger/ReadView.h>
 
-namespace xrpl {
+namespace ripple {
 
 enum ApplyFlags : std::uint32_t {
     tapNONE = 0x00,
@@ -267,7 +267,7 @@ public:
         {
             // LCOV_EXCL_START
             UNREACHABLE(
-                "xrpl::ApplyView::dirAppend : only Offers are appended to "
+                "ripple::ApplyView::dirAppend : only Offers are appended to "
                 "book directories");
             // Only Offers are appended to book directories. Call dirInsert()
             // instead
@@ -407,6 +407,6 @@ insertPage(
     std::function<void(std::shared_ptr<SLE> const&)> const& describe);
 
 }  // namespace directory
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/ApplyViewImpl.h

@@ -6,7 +6,7 @@
 #include <xrpl/protocol/STAmount.h>
 #include <xrpl/protocol/TER.h>
 
-namespace xrpl {
+namespace ripple {
 
 /** Editable, discardable view that can build metadata for one tx.
 
@@ -75,6 +75,6 @@ private:
     std::optional<STAmount> deliver_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/BookDirs.h

@@ -4,7 +4,7 @@
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ReadView.h>
 
-namespace xrpl {
+namespace ripple {
 
 class BookDirs
 {
@@ -89,6 +89,6 @@ private:
     static beast::Journal j_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/CachedSLEs.h

@@ -5,7 +5,7 @@
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/protocol/STLedgerEntry.h>
 
-namespace xrpl {
+namespace ripple {
 using CachedSLEs = TaggedCache<uint256, SLE const>;
 }
 

include/xrpl/ledger/CachedView.h

@@ -8,7 +8,7 @@
 #include <mutex>
 #include <type_traits>
 
-namespace xrpl {
+namespace ripple {
 
 namespace detail {
 
@@ -164,6 +164,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/CredentialHelpers.h

@@ -11,7 +11,7 @@
 #include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/TER.h>
 
-namespace xrpl {
+namespace ripple {
 namespace credentials {
 
 // These function will be used by the code that use DepositPreauth / Credentials
@@ -93,6 +93,6 @@ verifyDepositPreauth(
     std::shared_ptr<SLE> const& sleDst,
     beast::Journal j);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/Dir.h

@@ -4,7 +4,7 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/protocol/Indexes.h>
 
-namespace xrpl {
+namespace ripple {
 
 /** A class that simplifies iterating ledger directory pages
 
@@ -108,6 +108,6 @@ private:
     std::vector<uint256>::const_iterator it_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/OpenView.h

@@ -13,7 +13,7 @@
 #include <functional>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 /** Open ledger construction tag.
 
@@ -252,6 +252,6 @@ public:
         std::shared_ptr<Serializer const> const& metaData) override;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/PaymentSandbox.h

@@ -8,7 +8,7 @@
 
 #include <map>
 
-namespace xrpl {
+namespace ripple {
 
 namespace detail {
 
@@ -188,6 +188,6 @@ private:
     PaymentSandbox const* ps_ = nullptr;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/RawView.h

@@ -5,7 +5,7 @@
 #include <xrpl/protocol/STLedgerEntry.h>
 #include <xrpl/protocol/Serializer.h>
 
-namespace xrpl {
+namespace ripple {
 
 /** Interface for ledger entry changes.
 
@@ -87,6 +87,6 @@ public:
         std::shared_ptr<Serializer const> const& metaData) = 0;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/ReadView.h

@@ -18,7 +18,7 @@
 #include <optional>
 #include <unordered_set>
 
-namespace xrpl {
+namespace ripple {
 
 //------------------------------------------------------------------------------
 
@@ -258,7 +258,7 @@ makeRulesGivenLedger(
     DigestAwareReadView const& ledger,
     std::unordered_set<uint256, beast::uhash<>> const& presets);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #include <xrpl/ledger/detail/ReadViewFwdRange.ipp>
 

include/xrpl/ledger/Sandbox.h

@@ -4,7 +4,7 @@
 #include <xrpl/ledger/RawView.h>
 #include <xrpl/ledger/detail/ApplyViewBase.h>
 
-namespace xrpl {
+namespace ripple {
 
 /** Discardable, editable view to a ledger.
 
@@ -39,6 +39,6 @@ public:
     }
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/View.h

@@ -20,7 +20,7 @@
 #include <map>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 
 enum class WaiveTransferFee : bool { No = false, Yes };
 enum class SkipEntry : bool { No = false, Yes };
@@ -1197,6 +1197,6 @@ sharesToAssetsWithdraw(
 bool
 after(NetClock::time_point now, std::uint32_t mark);
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/detail/ApplyStateTable.h

@@ -11,7 +11,7 @@
 
 #include <memory>
 
-namespace xrpl {
+namespace ripple {
 namespace detail {
 
 // Helper class that buffers modifications
@@ -139,6 +139,6 @@ private:
 };
 
 }  // namespace detail
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/detail/ApplyViewBase.h

@@ -6,7 +6,7 @@
 #include <xrpl/ledger/detail/ApplyStateTable.h>
 #include <xrpl/protocol/XRPAmount.h>
 
-namespace xrpl {
+namespace ripple {
 namespace detail {
 
 class ApplyViewBase : public ApplyView, public RawView
@@ -106,6 +106,6 @@ protected:
 };
 
 }  // namespace detail
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/detail/RawStateTable.h

@@ -10,7 +10,7 @@
 #include <map>
 #include <utility>
 
-namespace xrpl {
+namespace ripple {
 namespace detail {
 
 // Helper class that buffers raw modifications
@@ -118,6 +118,6 @@ private:
 };
 
 }  // namespace detail
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/detail/ReadViewFwdRange.h

@@ -5,7 +5,7 @@
 #include <memory>
 #include <optional>
 
-namespace xrpl {
+namespace ripple {
 
 class ReadView;
 
@@ -130,6 +130,6 @@ protected:
 };
 
 }  // namespace detail
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/ledger/detail/ReadViewFwdRange.ipp

@@ -1,7 +1,7 @@
 #ifndef XRPL_LEDGER_READVIEWFWDRANGEINL_H_INCLUDED
 #define XRPL_LEDGER_READVIEWFWDRANGEINL_H_INCLUDED
 
-namespace xrpl {
+namespace ripple {
 namespace detail {
 
 template <class ValueType>
@@ -63,7 +63,7 @@ ReadViewFwdRange<ValueType>::iterator::operator==(iterator const& other) const
 {
     XRPL_ASSERT(
         view_ == other.view_,
-        "xrpl::detail::ReadViewFwdRange::iterator::operator==(iterator) "
+        "ripple::detail::ReadViewFwdRange::iterator::operator==(iterator) "
         "const : input view match");
 
     if (impl_ != nullptr && other.impl_ != nullptr)
@@ -115,6 +115,6 @@ ReadViewFwdRange<ValueType>::iterator::operator++(int) -> iterator
 }
 
 }  // namespace detail
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/net/AutoSocket.h

@@ -269,7 +269,7 @@ protected:
         error_code const& ec,
         size_t bytesTransferred)
     {
-        using namespace xrpl;
+        using namespace ripple;
 
         if (ec)
         {

include/xrpl/net/HTTPClient.h

@@ -12,7 +12,7 @@
 #include <functional>
 #include <string>
 
-namespace xrpl {
+namespace ripple {
 
 /** Provides an asynchronous HTTP client implementation with optional SSL.
  */
@@ -75,6 +75,6 @@ public:
         beast::Journal& j);
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif

include/xrpl/net/HTTPClientSSLContext.h

@@ -11,7 +11,7 @@
 #include <boost/asio/ssl.hpp>
 #include <boost/format.hpp>
 
-namespace xrpl {
+namespace ripple {
 
 class HTTPClientSSLContext
 {
@@ -176,6 +176,6 @@ private:
     bool const verify_;
 };
 
-}  // namespace xrpl
+}  // namespace ripple
 
 #endif