Merge branch 'develop' into ximinez/acquireAsyncDispatch

This change updates and pins the Black and CSpell pre-commit hooks.

.config/cspell.config.yaml

@@ -0,0 +1,279 @@
+ignorePaths:
+  - build/**
+  - src/libxrpl/crypto
+  - src/test/** # Will be removed in the future
+  - CMakeUserPresets.json
+  - Doxyfile
+  - docs/**/*.puml
+  - cmake/**
+  - LICENSE.md
+language: en
+allowCompoundWords: true
+ignoreRandomStrings: true
+minWordLength: 5
+dictionaries:
+  - cpp
+  - en_US
+  - en_GB
+ignoreRegExpList:
+  - /[rs][1-9A-HJ-NP-Za-km-z]{25,34}/g # addresses and seeds
+  - /(XRPL|BEAST)_[A-Z_0-9]+_H_INCLUDED+/g # include guards
+  - /(XRPL|BEAST)_[A-Z_0-9]+_H+/g # include guards
+  - /::[a-z:_]+/g # things from other namespaces
+  - /lib[a-z]+/g # libraries
+  - /[0-9]{4}-[0-9]{2}-[0-9]{2}[,:][A-Za-zÀ-ÖØ-öø-ÿ.\s]+/g # copyright dates
+  - /[0-9]{4}[,:]?\s*[A-Za-zÀ-ÖØ-öø-ÿ.\s]+/g # copyright years
+  - /\[[A-Za-z0-9-]+\]\(https:\/\/github.com\/[A-Za-z0-9-]+\)/g # Github usernames
+  - /-[DWw][a-zA-Z0-9_-]+=/g # compile flags
+  - /[\['"`]-[DWw][a-zA-Z0-9_-]+['"`\]]/g # compile flags
+suggestWords:
+  - xprl->xrpl
+  - unsynched->unsynced
+  - synched->synced
+  - synch->sync
+words:
+  - abempty
+  - AMMID
+  - amt
+  - amts
+  - asnode
+  - asynchrony
+  - attestation
+  - authorises
+  - autobridge
+  - autobridged
+  - autobridging
+  - bimap
+  - bindir
+  - bookdir
+  - Bougalis
+  - Britto
+  - Btrfs
+  - canonicality
+  - checkme
+  - choco
+  - chrono
+  - citardauq
+  - clawback
+  - clawbacks
+  - coeffs
+  - coldwallet
+  - compr
+  - conanfile
+  - conanrun
+  - connectability
+  - coro
+  - coros
+  - cowid
+  - cryptocondition
+  - cryptoconditional
+  - cryptoconditions
+  - csprng
+  - ctest
+  - ctid
+  - currenttxhash
+  - daria
+  - dcmake
+  - dearmor
+  - deleteme
+  - demultiplexer
+  - deserializaton
+  - desync
+  - desynced
+  - determ
+  - distro
+  - doxyfile
+  - dxrpl
+  - endmacro
+  - exceptioned
+  - Falco
+  - finalizers
+  - firewalled
+  - fmtdur
+  - funclets
+  - gcov
+  - gcovr
+  - ghead
+  - Gnutella
+  - gpgcheck
+  - gpgkey
+  - hotwallet
+  - ifndef
+  - inequation
+  - insuf
+  - insuff
+  - iou
+  - ious
+  - isrdc
+  - itype
+  - jemalloc
+  - jlog
+  - keylet
+  - keylets
+  - keyvadb
+  - ledgerentry
+  - ledgerhash
+  - ledgerindex
+  - leftw
+  - legleux
+  - levelization
+  - levelized
+  - libpb
+  - libxrpl
+  - llection
+  - LOCALGOOD
+  - logwstream
+  - lseq
+  - lsmf
+  - ltype
+  - MEMORYSTATUSEX
+  - Merkle
+  - Metafuncton
+  - misprediction
+  - mptbalance
+  - mptflags
+  - mptid
+  - mptissuance
+  - mptissuanceid
+  - mptoken
+  - mptokenid
+  - mptokenissuance
+  - mptokens
+  - mpts
+  - multisig
+  - multisign
+  - multisigned
+  - Nakamoto
+  - nftid
+  - nftoffer
+  - nftoken
+  - nftokenid
+  - nftokenpages
+  - nftokens
+  - nftpage
+  - nikb
+  - nonxrp
+  - noripple
+  - nudb
+  - nullptr
+  - nunl
+  - Nyffenegger
+  - ostr
+  - partitioner
+  - paychan
+  - paychans
+  - permdex
+  - perminute
+  - permissioned
+  - pointee
+  - preauth
+  - preauthorization
+  - preauthorize
+  - preauthorizes
+  - preclaim
+  - protobuf
+  - protos
+  - ptrs
+  - pyenv
+  - qalloc
+  - queuable
+  - Raphson
+  - replayer
+  - rerere
+  - retriable
+  - RIPD
+  - ripdtop
+  - rippleci
+  - rippled
+  - ripplerpc
+  - rippletest
+  - RLUSD
+  - rngfill
+  - rocksdb
+  - Rohrs
+  - roundings
+  - sahyadri
+  - Satoshi
+  - scons
+  - secp
+  - sendq
+  - seqit
+  - sf
+  - SFIELD
+  - shamap
+  - shamapitem
+  - sidechain
+  - SIGGOOD
+  - sle
+  - sles
+  - soci
+  - socidb
+  - sslws
+  - statsd
+  - STATSDCOLLECTOR
+  - stissue
+  - stnum
+  - stobj
+  - stobject
+  - stpath
+  - stpathset
+  - sttx
+  - stvar
+  - stvector
+  - stxchainattestations
+  - superpeer
+  - superpeers
+  - takergets
+  - takerpays
+  - ters
+  - TMEndpointv2
+  - trixie
+  - tx
+  - txid
+  - txids
+  - txjson
+  - txn
+  - txns
+  - txs
+  - umant
+  - unacquired
+  - unambiguity
+  - unauthorizes
+  - unauthorizing
+  - unergonomic
+  - unfetched
+  - unflatten
+  - unfund
+  - unimpair
+  - unroutable
+  - unscalable
+  - unserviced
+  - unshareable
+  - unshares
+  - unsquelch
+  - unsquelched
+  - unsquelching
+  - unvalidated
+  - unveto
+  - unvetoed
+  - upvotes
+  - USDB
+  - variadics
+  - venv
+  - vfalco
+  - vinnie
+  - wextra
+  - wptr
+  - writeme
+  - wsrch
+  - wthread
+  - xbridge
+  - xchain
+  - ximinez
+  - XMACRO
+  - xrpkuwait
+  - xrpl
+  - xrpld
+  - xrplf
+  - xxhash
+  - xxhasher

.gitattributes

@@ -1,5 +1,6 @@
 # Set default behaviour, in case users don't have core.autocrlf set.
 #* text=auto
+# cspell: disable
 
 # Visual Studio
 *.sln       text eol=crlf

.github/actions/build-deps/action.yml

@@ -4,9 +4,6 @@ description: "Install Conan dependencies, optionally forcing a rebuild of all de
 # Note that actions do not support 'type' and all inputs are strings, see
 # https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax#inputs.
 inputs:
-  build_dir:
-    description: "The directory where to build."
-    required: true
   build_type:
     description: 'The build type to use ("Debug", "Release").'
     required: true
@@ -28,17 +25,13 @@ runs:
     - name: Install Conan dependencies
       shell: bash
       env:
-        BUILD_DIR: ${{ inputs.build_dir }}
         BUILD_NPROC: ${{ inputs.build_nproc }}
         BUILD_OPTION: ${{ inputs.force_build == 'true' && '*' || 'missing' }}
         BUILD_TYPE: ${{ inputs.build_type }}
         LOG_VERBOSITY: ${{ inputs.log_verbosity }}
       run: |
         echo 'Installing dependencies.'
-        mkdir -p "${BUILD_DIR}"
-        cd "${BUILD_DIR}"
         conan install \
-          --output-folder . \
           --build="${BUILD_OPTION}" \
           --options:host='&:tests=True' \
           --options:host='&:xrpld=True' \
@@ -46,4 +39,4 @@ runs:
           --conf:all tools.build:jobs=${BUILD_NPROC} \
           --conf:all tools.build:verbosity="${LOG_VERBOSITY}" \
           --conf:all tools.compilation:verbosity="${LOG_VERBOSITY}" \
-          ..
+          .

.github/actions/print-env/action.yml

@@ -11,12 +11,6 @@ runs:
         echo 'Checking environment variables.'
         set
 
-        echo 'Checking CMake version.'
-        cmake --version
-
-        echo 'Checking Conan version.'
-        conan --version
-
     - name: Check configuration (Linux and macOS)
       if: ${{ runner.os == 'Linux' || runner.os == 'macOS' }}
       shell: bash
@@ -27,17 +21,23 @@ runs:
         echo 'Checking environment variables.'
         env | sort
 
-        echo 'Checking CMake version.'
-        cmake --version
-
         echo 'Checking compiler version.'
         ${{ runner.os == 'Linux' && '${CC}' || 'clang' }} --version
 
-        echo 'Checking Conan version.'
-        conan --version
-
         echo 'Checking Ninja version.'
         ninja --version
 
         echo 'Checking nproc version.'
         nproc --version
+
+    - name: Check configuration (all)
+      shell: bash
+      run: |
+        echo 'Checking Ccache version.'
+        ccache --version
+
+        echo 'Checking CMake version.'
+        cmake --version
+
+        echo 'Checking Conan version.'
+        conan --version

.github/scripts/levelization/README.md

@@ -81,10 +81,10 @@ It generates many files of [results](results):
 
 - `rawincludes.txt`: The raw dump of the `#includes`
 - `paths.txt`: A second dump grouping the source module
-  to the destination module, deduped, and with frequency counts.
+  to the destination module, de-duped, and with frequency counts.
 - `includes/`: A directory where each file represents a module and
   contains a list of modules and counts that the module _includes_.
-- `includedby/`: Similar to `includes/`, but the other way around. Each
+- `included_by/`: Similar to `includes/`, but the other way around. Each
   file represents a module and contains a list of modules and counts
   that _include_ the module.
 - [`loops.txt`](results/loops.txt): A list of direct loops detected

.github/scripts/levelization/generate.sh

@@ -29,7 +29,7 @@ pushd results
 oldifs=${IFS}
 IFS=:
 mkdir includes
-mkdir includedby
+mkdir included_by
 echo Build levelization paths
 exec 3< ${includes} # open rawincludes.txt for input
 while read -r -u 3 file include
@@ -59,7 +59,7 @@ do
         echo $level $includelevel | tee -a paths.txt
     fi
 done
-echo Sort and dedup paths
+echo Sort and deduplicate paths
 sort -ds paths.txt | uniq -c | tee sortedpaths.txt
 mv sortedpaths.txt paths.txt
 exec 3>&- #close fd 3
@@ -71,7 +71,7 @@ exec 4<paths.txt # open paths.txt for input
 while read -r -u 4 count level include
 do
     echo ${include} ${count} | tee -a includes/${level}
-    echo ${level} ${count} | tee -a includedby/${include}
+    echo ${level} ${count} | tee -a included_by/${include}
 done
 exec 4>&- #close fd 4
 

.github/scripts/rename/README.md

@@ -19,7 +19,7 @@ run from the repository root.
 1. `.github/scripts/rename/definitions.sh`: This script will rename all
    definitions, such as include guards, from `RIPPLE_XXX` and `RIPPLED_XXX` to
    `XRPL_XXX`.
-2. `.github/scripts/rename/copyright.sh`: This script will remove superflous
+2. `.github/scripts/rename/copyright.sh`: This script will remove superfluous
    copyright notices.
 3. `.github/scripts/rename/cmake.sh`: This script will rename all CMake files
    from `RippleXXX.cmake` or `RippledXXX.cmake` to `XrplXXX.cmake`, and any
@@ -31,6 +31,9 @@ run from the repository root.
    the `xrpld` binary.
 5. `.github/scripts/rename/namespace.sh`: This script will rename the C++
    namespaces from `ripple` to `xrpl`.
+6. `.github/scripts/rename/config.sh`: This script will rename the config from
+   `rippled.cfg` to `xrpld.cfg`, and updating the code accordingly. The old
+   filename will still be accepted.
 
 You can run all these scripts from the repository root as follows:
 
@@ -40,4 +43,5 @@ You can run all these scripts from the repository root as follows:
 ./.github/scripts/rename/cmake.sh .
 ./.github/scripts/rename/binary.sh .
 ./.github/scripts/rename/namespace.sh .
+./.github/scripts/rename/config.sh .
 ```

.github/scripts/rename/config.sh

@@ -0,0 +1,72 @@
+#!/bin/bash
+
+# Exit the script as soon as an error occurs.
+set -e
+
+# On MacOS, ensure that GNU sed is installed and available as `gsed`.
+SED_COMMAND=sed
+if [[ "${OSTYPE}" == 'darwin'* ]]; then
+  if ! command -v gsed &> /dev/null; then
+      echo "Error: gsed is not installed. Please install it using 'brew install gnu-sed'."
+      exit 1
+  fi
+  SED_COMMAND=gsed
+fi
+
+# This script renames the config from `rippled.cfg` to `xrpld.cfg`, and updates
+# the code accordingly. The old filename will still be accepted.
+# Usage: .github/scripts/rename/config.sh <repository directory>
+
+if [ "$#" -ne 1 ]; then
+    echo "Usage: $0 <repository directory>"
+    exit 1
+fi
+
+DIRECTORY=$1
+echo "Processing directory: ${DIRECTORY}"
+if [ ! -d "${DIRECTORY}" ]; then
+    echo "Error: Directory '${DIRECTORY}' does not exist."
+    exit 1
+fi
+pushd ${DIRECTORY}
+
+# Add the xrpld.cfg to the .gitignore.
+if ! grep -q 'xrpld.cfg' .gitignore; then
+  ${SED_COMMAND} -i '/rippled.cfg/a\
+/xrpld.cfg' .gitignore
+fi
+
+# Rename the files.
+if [ -e rippled.cfg ]; then
+  mv rippled.cfg xrpld.cfg
+fi
+if [ -e cfg/rippled-example.cfg ]; then
+  mv cfg/rippled-example.cfg cfg/xrpld-example.cfg
+fi
+
+# Rename inside the files.
+DIRECTORIES=("cfg" "cmake" "include" "src")
+for DIRECTORY in "${DIRECTORIES[@]}"; do
+  echo "Processing directory: ${DIRECTORY}"
+
+  find "${DIRECTORY}" -type f \( -name "*.h" -o -name "*.hpp" -o -name "*.ipp" -o -name "*.cpp" -o -name "*.cmake" -o -name "*.txt" -o -name "*.cfg" -o -name "*.md" \) | while read -r FILE; do
+      echo "Processing file: ${FILE}"
+      ${SED_COMMAND} -i -E 's/rippled(-example)?[ .]cfg/xrpld\1.cfg/g' "${FILE}"
+  done
+done
+${SED_COMMAND} -i 's/rippled/xrpld/g' cfg/xrpld-example.cfg
+${SED_COMMAND} -i 's/rippled/xrpld/g' src/test/core/Config_test.cpp
+${SED_COMMAND} -i 's/ripplevalidators/xrplvalidators/g' src/test/core/Config_test.cpp # cspell: disable-line
+${SED_COMMAND} -i 's/rippleConfig/xrpldConfig/g' src/test/core/Config_test.cpp
+${SED_COMMAND} -i 's@ripple/@xrpld/@g' src/test/core/Config_test.cpp
+${SED_COMMAND} -i 's/Rippled/File/g' src/test/core/Config_test.cpp
+
+
+# Restore the old config file name in the code that maintains support for now.
+${SED_COMMAND} -i 's/configLegacyName = "xrpld.cfg"/configLegacyName = "rippled.cfg"/g' src/xrpld/core/detail/Config.cpp
+
+# Restore an URL.
+${SED_COMMAND} -i 's/connect-your-xrpld-to-the-xrp-test-net.html/connect-your-rippled-to-the-xrp-test-net.html/g' cfg/xrpld-example.cfg
+
+popd
+echo "Renaming complete."

.github/scripts/rename/copyright.sh

@@ -50,11 +50,11 @@ for DIRECTORY in "${DIRECTORIES[@]}"; do
       # Handle the cases where the copyright notice is enclosed in /* ... */
       # and usually surrounded by //---- and //======.
       ${SED_COMMAND} -z -i -E 's@^//-------+\n+@@' "${FILE}"
-      ${SED_COMMAND} -z -i -E 's@^.*Copyright.+(Ripple|Bougalis|Falco|Hinnant|Null|Ritchford|XRPLF).+PERFORMANCE OF THIS SOFTWARE\.\n\*/\n+@@' "${FILE}"
+      ${SED_COMMAND} -z -i -E 's@^.*Copyright.+(Ripple|Bougalis|Falco|Hinnant|Null|Ritchford|XRPLF).+PERFORMANCE OF THIS SOFTWARE\.\n\*/\n+@@' "${FILE}" # cspell: ignore Bougalis Falco Hinnant Ritchford
       ${SED_COMMAND} -z -i -E 's@^//=======+\n+@@' "${FILE}"
 
       # Handle the cases where the copyright notice is commented out with //.
-      ${SED_COMMAND} -z -i -E 's@^//\n// Copyright.+Falco \(vinnie dot falco at gmail dot com\)\n//\n+@@' "${FILE}"
+      ${SED_COMMAND} -z -i -E 's@^//\n// Copyright.+Falco \(vinnie dot falco at gmail dot com\)\n//\n+@@' "${FILE}" # cspell: ignore Vinnie Falco
   done
 done
 
@@ -83,16 +83,16 @@ if ! grep -q 'Dev Null' src/xrpld/rpc/handlers/ValidatorInfo.cpp; then
   echo -e "// Copyright (c) 2019 Dev Null Productions\n\n$(cat src/xrpld/rpc/handlers/ValidatorInfo.cpp)" > src/xrpld/rpc/handlers/ValidatorInfo.cpp
 fi
 if ! grep -q 'Bougalis' include/xrpl/basics/SlabAllocator.h; then
-  echo -e "// Copyright (c) 2022, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/SlabAllocator.h)" > include/xrpl/basics/SlabAllocator.h
+  echo -e "// Copyright (c) 2022, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/SlabAllocator.h)" > include/xrpl/basics/SlabAllocator.h # cspell: ignore Nikolaos Bougalis nikb
 fi
 if ! grep -q 'Bougalis' include/xrpl/basics/spinlock.h; then
-  echo -e "// Copyright (c) 2022, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/spinlock.h)" > include/xrpl/basics/spinlock.h
+  echo -e "// Copyright (c) 2022, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/spinlock.h)" > include/xrpl/basics/spinlock.h # cspell: ignore Nikolaos Bougalis nikb
 fi
 if ! grep -q 'Bougalis' include/xrpl/basics/tagged_integer.h; then
-  echo -e "// Copyright (c) 2014, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/tagged_integer.h)" > include/xrpl/basics/tagged_integer.h
+  echo -e "// Copyright (c) 2014, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/tagged_integer.h)" > include/xrpl/basics/tagged_integer.h # cspell: ignore Nikolaos Bougalis nikb
 fi
 if ! grep -q 'Ritchford' include/xrpl/beast/utility/Zero.h; then
-  echo -e "// Copyright (c) 2014, Tom Ritchford <tom@swirly.com>\n\n$(cat include/xrpl/beast/utility/Zero.h)" > include/xrpl/beast/utility/Zero.h
+  echo -e "// Copyright (c) 2014, Tom Ritchford <tom@swirly.com>\n\n$(cat include/xrpl/beast/utility/Zero.h)" > include/xrpl/beast/utility/Zero.h # cspell: ignore Ritchford
 fi
 
 # Restore newlines and tabs in string literals in the affected file.

.github/scripts/strategy-matrix/generate.py

@@ -232,6 +232,8 @@ def generate_strategy_matrix(all: bool, config: Config) -> list:
             f"-{architecture['platform'][architecture['platform'].find('/') + 1 :]}"
         )
         config_name += f"-{build_type.lower()}"
+        if "-Dcoverage=ON" in cmake_args:
+            config_name += "-coverage"
         if "-Dunity=ON" in cmake_args:
             config_name += "-unity"
 

.github/scripts/strategy-matrix/linux.json

@@ -15,196 +15,196 @@
       "distro_version": "bookworm",
       "compiler_name": "gcc",
       "compiler_version": "12",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "gcc",
       "compiler_version": "13",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "gcc",
       "compiler_version": "14",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "gcc",
       "compiler_version": "15",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "clang",
       "compiler_version": "16",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "clang",
       "compiler_version": "17",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "clang",
       "compiler_version": "18",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "clang",
       "compiler_version": "19",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "bookworm",
       "compiler_name": "clang",
       "compiler_version": "20",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "trixie",
       "compiler_name": "gcc",
       "compiler_version": "14",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "trixie",
       "compiler_name": "gcc",
       "compiler_version": "15",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "trixie",
       "compiler_name": "clang",
       "compiler_version": "20",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "debian",
       "distro_version": "trixie",
       "compiler_name": "clang",
       "compiler_version": "21",
-      "image_sha": "0525eae"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "8",
       "compiler_name": "gcc",
       "compiler_version": "14",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "8",
       "compiler_name": "clang",
       "compiler_version": "any",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "9",
       "compiler_name": "gcc",
       "compiler_version": "12",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "9",
       "compiler_name": "gcc",
       "compiler_version": "13",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "9",
       "compiler_name": "gcc",
       "compiler_version": "14",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "9",
       "compiler_name": "clang",
       "compiler_version": "any",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "10",
       "compiler_name": "gcc",
       "compiler_version": "14",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "rhel",
       "distro_version": "10",
       "compiler_name": "clang",
       "compiler_version": "any",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "jammy",
       "compiler_name": "gcc",
       "compiler_version": "12",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "noble",
       "compiler_name": "gcc",
       "compiler_version": "13",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "noble",
       "compiler_name": "gcc",
       "compiler_version": "14",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "noble",
       "compiler_name": "clang",
       "compiler_version": "16",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "noble",
       "compiler_name": "clang",
       "compiler_version": "17",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "noble",
       "compiler_name": "clang",
       "compiler_version": "18",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     },
     {
       "distro_name": "ubuntu",
       "distro_version": "noble",
       "compiler_name": "clang",
       "compiler_version": "19",
-      "image_sha": "e1782cd"
+      "image_sha": "cc09fd3"
     }
   ],
   "build_type": ["Debug", "Release"],

.github/workflows/on-pr.yml

@@ -114,6 +114,9 @@ jobs:
       matrix:
         os: [linux, macos, windows]
     with:
+      # Enable ccache only for events targeting the XRPLF repository, since
+      # other accounts will not have access to our remote cache storage.
+      ccache_enabled: ${{ github.repository_owner == 'XRPLF' }}
       os: ${{ matrix.os }}
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/on-trigger.yml

@@ -68,6 +68,12 @@ jobs:
       matrix:
         os: [linux, macos, windows]
     with:
+      # Enable ccache only for events targeting the XRPLF repository, since
+      # other accounts will not have access to our remote cache storage.
+      # However, we do not enable ccache for events targeting the master or a
+      # release branch, to protect against the rare case that the output
+      # produced by ccache is not identical to a regular compilation.
+      ccache_enabled: ${{ github.repository_owner == 'XRPLF' && !(github.base_ref == 'master' || startsWith(github.base_ref, 'release')) }}
       os: ${{ matrix.os }}
       strategy_matrix: ${{ github.event_name == 'schedule' && 'all' || 'minimal' }}
     secrets:

.github/workflows/pre-commit.yml

@@ -9,7 +9,7 @@ on:
 jobs:
   # Call the workflow in the XRPLF/actions repo that runs the pre-commit hooks.
   run-hooks:
-    uses: XRPLF/actions/.github/workflows/pre-commit.yml@34790936fae4c6c751f62ec8c06696f9c1a5753a
+    uses: XRPLF/actions/.github/workflows/pre-commit.yml@5ca417783f0312ab26d6f48b85c78edf1de99bbd
     with:
       runs_on: ubuntu-latest
       container: '{ "image": "ghcr.io/xrplf/ci/tools-rippled-pre-commit:sha-a8c7be1" }'

.github/workflows/publish-docs.yml

@@ -22,7 +22,7 @@ defaults:
     shell: bash
 
 env:
-  BUILD_DIR: .build
+  BUILD_DIR: build
   NPROC_SUBTRACT: 2
 
 jobs:
@@ -36,7 +36,7 @@ jobs:
         uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
 
       - name: Get number of processors
-        uses: XRPLF/actions/.github/actions/get-nproc@046b1620f6bfd6cd0985dc82c3df02786801fe0a
+        uses: XRPLF/actions/get-nproc@2ece4ec6ab7de266859a6f053571425b2bd684b6
         id: nproc
         with:
           subtract: ${{ env.NPROC_SUBTRACT }}

.github/workflows/reusable-build-test-config.yml

@@ -3,11 +3,6 @@ name: Build and test configuration
 on:
   workflow_call:
     inputs:
-      build_dir:
-        description: "The directory where to build."
-        required: true
-        type: string
-
       build_only:
         description: 'Whether to only build or to build and test the code ("true", "false").'
         required: true
@@ -15,8 +10,14 @@ on:
 
       build_type:
         description: 'The build type to use ("Debug", "Release").'
-        type: string
         required: true
+        type: string
+
+      ccache_enabled:
+        description: "Whether to enable ccache."
+        required: false
+        type: boolean
+        default: false
 
       cmake_args:
         description: "Additional arguments to pass to CMake."
@@ -26,8 +27,8 @@ on:
 
       cmake_target:
         description: "The CMake target to build."
-        type: string
         required: true
+        type: string
 
       runs_on:
         description: Runner to run the job on as a JSON string
@@ -59,6 +60,11 @@ defaults:
   run:
     shell: bash
 
+env:
+  # Conan installs the generators in the build/generators directory, see the
+  # layout() method in conanfile.py. We then run CMake from the build directory.
+  BUILD_DIR: build
+
 jobs:
   build-and-test:
     name: ${{ inputs.config_name }}
@@ -66,26 +72,47 @@ jobs:
     container: ${{ inputs.image != '' && inputs.image || null }}
     timeout-minutes: 60
     env:
-      ENABLED_VOIDSTAR: ${{ contains(inputs.cmake_args, '-Dvoidstar=ON') }}
-      ENABLED_COVERAGE: ${{ contains(inputs.cmake_args, '-Dcoverage=ON') }}
+      # Use a namespace to keep the objects separate for each configuration.
+      CCACHE_NAMESPACE: ${{ inputs.config_name }}
+      # Ccache supports both Redis and HTTP endpoints.
+      # * For Redis, use the following format: redis://ip:port, see
+      #   https://github.com/ccache/ccache/wiki/Redis-storage. Note that TLS is
+      #   not directly supported by ccache, and requires use of a proxy.
+      # * For HTTP use the following format: http://ip:port/cache when using
+      #   nginx as backend or http://ip:port|layout=bazel when using Bazel
+      #   Remote Cache, see https://github.com/ccache/ccache/wiki/HTTP-storage.
+      #   Note that HTTPS is not directly supported by ccache.
+      CCACHE_REMOTE_ONLY: true
+      CCACHE_REMOTE_STORAGE: http://cache.dev.ripplex.io:8080|layout=bazel
+      # Ignore the creation and modification timestamps on files, since the
+      # header files are copied into separate directories by CMake, which will
+      # otherwise result in cache misses.
+      CCACHE_SLOPPINESS: include_file_ctime,include_file_mtime
+      # Determine if coverage and voidstar should be enabled.
+      COVERAGE_ENABLED: ${{ contains(inputs.cmake_args, '-Dcoverage=ON') }}
+      VOIDSTAR_ENABLED: ${{ contains(inputs.cmake_args, '-Dvoidstar=ON') }}
     steps:
       - name: Cleanup workspace (macOS and Windows)
         if: ${{ runner.os == 'macOS' || runner.os == 'Windows' }}
-        uses: XRPLF/actions/.github/actions/cleanup-workspace@01b244d2718865d427b499822fbd3f15e7197fcc
+        uses: XRPLF/actions/cleanup-workspace@2ece4ec6ab7de266859a6f053571425b2bd684b6
 
       - name: Checkout repository
         uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
 
       - name: Prepare runner
-        uses: XRPLF/actions/.github/actions/prepare-runner@99685816bb60a95a66852f212f382580e180df3a
+        uses: XRPLF/actions/prepare-runner@121d1de2775d486d46140b9a91b32d5002c08153
         with:
-          disable_ccache: false
+          enable_ccache: ${{ inputs.ccache_enabled }}
+
+      - name: Set ccache log file
+        if: ${{ inputs.ccache_enabled && runner.debug == '1' }}
+        run: echo "CCACHE_LOGFILE=${{ runner.temp }}/ccache.log" >> "${GITHUB_ENV}"
 
       - name: Print build environment
         uses: ./.github/actions/print-env
 
       - name: Get number of processors
-        uses: XRPLF/actions/.github/actions/get-nproc@046b1620f6bfd6cd0985dc82c3df02786801fe0a
+        uses: XRPLF/actions/get-nproc@2ece4ec6ab7de266859a6f053571425b2bd684b6
         id: nproc
         with:
           subtract: ${{ inputs.nproc_subtract }}
@@ -96,7 +123,6 @@ jobs:
       - name: Build dependencies
         uses: ./.github/actions/build-deps
         with:
-          build_dir: ${{ inputs.build_dir }}
           build_nproc: ${{ steps.nproc.outputs.nproc }}
           build_type: ${{ inputs.build_type }}
           # Set the verbosity to "quiet" for Windows to avoid an excessive
@@ -104,7 +130,7 @@ jobs:
           log_verbosity: ${{ runner.os == 'Windows' && 'quiet' || 'verbose' }}
 
       - name: Configure CMake
-        working-directory: ${{ inputs.build_dir }}
+        working-directory: ${{ env.BUILD_DIR }}
         env:
           BUILD_TYPE: ${{ inputs.build_type }}
           CMAKE_ARGS: ${{ inputs.cmake_args }}
@@ -117,7 +143,7 @@ jobs:
             ..
 
       - name: Build the binary
-        working-directory: ${{ inputs.build_dir }}
+        working-directory: ${{ env.BUILD_DIR }}
         env:
           BUILD_NPROC: ${{ steps.nproc.outputs.nproc }}
           BUILD_TYPE: ${{ inputs.build_type }}
@@ -129,11 +155,18 @@ jobs:
             --parallel "${BUILD_NPROC}" \
             --target "${CMAKE_TARGET}"
 
+      - name: Show ccache statistics
+        if: ${{ inputs.ccache_enabled }}
+        run: |
+          ccache --show-stats -vv
+          if [ '${{ runner.debug }}' = '1' ]; then
+            cat "${CCACHE_LOGFILE}"
+            curl ${CCACHE_REMOTE_STORAGE%|*}/status || true
+          fi
+
       - name: Upload the binary (Linux)
         if: ${{ github.repository_owner == 'XRPLF' && runner.os == 'Linux' }}
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
-        env:
-          BUILD_DIR: ${{ inputs.build_dir }}
         with:
           name: xrpld-${{ inputs.config_name }}
           path: ${{ env.BUILD_DIR }}/xrpld
@@ -142,7 +175,7 @@ jobs:
 
       - name: Check linking (Linux)
         if: ${{ runner.os == 'Linux' }}
-        working-directory: ${{ inputs.build_dir }}
+        working-directory: ${{ env.BUILD_DIR }}
         run: |
           ldd ./xrpld
           if [ "$(ldd ./xrpld | grep -E '(libstdc\+\+|libgcc)' | wc -l)" -eq 0 ]; then
@@ -153,14 +186,14 @@ jobs:
           fi
 
       - name: Verify presence of instrumentation (Linux)
-        if: ${{ runner.os == 'Linux' && env.ENABLED_VOIDSTAR == 'true' }}
-        working-directory: ${{ inputs.build_dir }}
+        if: ${{ runner.os == 'Linux' && env.VOIDSTAR_ENABLED == 'true' }}
+        working-directory: ${{ env.BUILD_DIR }}
         run: |
           ./xrpld --version | grep libvoidstar
 
       - name: Run the separate tests
         if: ${{ !inputs.build_only }}
-        working-directory: ${{ inputs.build_dir }}
+        working-directory: ${{ env.BUILD_DIR }}
         # Windows locks some of the build files while running tests, and parallel jobs can collide
         env:
           BUILD_TYPE: ${{ inputs.build_type }}
@@ -173,7 +206,7 @@ jobs:
 
       - name: Run the embedded tests
         if: ${{ !inputs.build_only }}
-        working-directory: ${{ runner.os == 'Windows' && format('{0}/{1}', inputs.build_dir, inputs.build_type) || inputs.build_dir }}
+        working-directory: ${{ runner.os == 'Windows' && format('{0}/{1}', env.BUILD_DIR, inputs.build_type) || env.BUILD_DIR }}
         env:
           BUILD_NPROC: ${{ steps.nproc.outputs.nproc }}
         run: |
@@ -188,8 +221,8 @@ jobs:
           netstat -an
 
       - name: Prepare coverage report
-        if: ${{ !inputs.build_only && env.ENABLED_COVERAGE == 'true' }}
-        working-directory: ${{ inputs.build_dir }}
+        if: ${{ !inputs.build_only && env.COVERAGE_ENABLED == 'true' }}
+        working-directory: ${{ env.BUILD_DIR }}
         env:
           BUILD_NPROC: ${{ steps.nproc.outputs.nproc }}
           BUILD_TYPE: ${{ inputs.build_type }}
@@ -201,13 +234,13 @@ jobs:
             --target coverage
 
       - name: Upload coverage report
-        if: ${{ github.repository_owner == 'XRPLF' && !inputs.build_only && env.ENABLED_COVERAGE == 'true' }}
+        if: ${{ github.repository_owner == 'XRPLF' && !inputs.build_only && env.COVERAGE_ENABLED == 'true' }}
         uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
         with:
           disable_search: true
           disable_telem: true
           fail_ci_if_error: true
-          files: ${{ inputs.build_dir }}/coverage.xml
+          files: ${{ env.BUILD_DIR }}/coverage.xml
           plugins: noop
           token: ${{ secrets.CODECOV_TOKEN }}
           verbose: true

.github/workflows/reusable-build-test.yml

@@ -8,21 +8,24 @@ name: Build and test
 on:
   workflow_call:
     inputs:
-      build_dir:
-        description: "The directory where to build."
+      ccache_enabled:
+        description: "Whether to enable ccache."
         required: false
-        type: string
-        default: ".build"
+        type: boolean
+        default: false
+
       os:
         description: 'The operating system to use for the build ("linux", "macos", "windows").'
         required: true
         type: string
+
       strategy_matrix:
         # TODO: Support additional strategies, e.g. "ubuntu" for generating all Ubuntu configurations.
         description: 'The strategy matrix to use for generating the configurations ("minimal", "all").'
         required: false
         type: string
         default: "minimal"
+
     secrets:
       CODECOV_TOKEN:
         description: "The Codecov token to use for uploading coverage reports."
@@ -46,9 +49,9 @@ jobs:
       matrix: ${{ fromJson(needs.generate-matrix.outputs.matrix) }}
       max-parallel: 10
     with:
-      build_dir: ${{ inputs.build_dir }}
       build_only: ${{ matrix.build_only }}
       build_type: ${{ matrix.build_type }}
+      ccache_enabled: ${{ inputs.ccache_enabled }}
       cmake_args: ${{ matrix.cmake_args }}
       cmake_target: ${{ matrix.cmake_target }}
       runs_on: ${{ toJSON(matrix.architecture.runner) }}

.github/workflows/reusable-check-rename.yml

@@ -29,6 +29,8 @@ jobs:
         run: .github/scripts/rename/binary.sh .
       - name: Check namespaces
         run: .github/scripts/rename/namespace.sh .
+      - name: Check config name
+        run: .github/scripts/rename/config.sh .
       - name: Check for differences
         env:
           MESSAGE: |

.github/workflows/upload-conan-deps.yml

@@ -64,21 +64,21 @@ jobs:
     steps:
       - name: Cleanup workspace (macOS and Windows)
         if: ${{ runner.os == 'macOS' || runner.os == 'Windows' }}
-        uses: XRPLF/actions/.github/actions/cleanup-workspace@01b244d2718865d427b499822fbd3f15e7197fcc
+        uses: XRPLF/actions/cleanup-workspace@2ece4ec6ab7de266859a6f053571425b2bd684b6
 
       - name: Checkout repository
         uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
 
       - name: Prepare runner
-        uses: XRPLF/actions/.github/actions/prepare-runner@99685816bb60a95a66852f212f382580e180df3a
+        uses: XRPLF/actions/prepare-runner@65da1c59e81965eeb257caa3587b9d45066fb925
         with:
-          disable_ccache: false
+          enable_ccache: false
 
       - name: Print build environment
         uses: ./.github/actions/print-env
 
       - name: Get number of processors
-        uses: XRPLF/actions/.github/actions/get-nproc@046b1620f6bfd6cd0985dc82c3df02786801fe0a
+        uses: XRPLF/actions/get-nproc@2ece4ec6ab7de266859a6f053571425b2bd684b6
         id: nproc
         with:
           subtract: ${{ env.NPROC_SUBTRACT }}
@@ -92,7 +92,6 @@ jobs:
       - name: Build dependencies
         uses: ./.github/actions/build-deps
         with:
-          build_dir: .build
           build_nproc: ${{ steps.nproc.outputs.nproc }}
           build_type: ${{ matrix.build_type }}
           force_build: ${{ github.event_name == 'schedule' || github.event.inputs.force_source_build == 'true' }}

.gitignore

@@ -1,4 +1,5 @@
 # .gitignore
+# cspell: disable
 
 # Macintosh Desktop Services Store files.
 .DS_Store
@@ -35,6 +36,7 @@ gmon.out
 
 # Customized configs.
 /rippled.cfg
+/xrpld.cfg
 /validators.txt
 
 # Locally patched Conan recipes

.pre-commit-config.yaml

@@ -32,10 +32,25 @@ repos:
       - id: prettier
 
   - repo: https://github.com/psf/black-pre-commit-mirror
-    rev: 25.11.0
+    rev: 831207fd435b47aeffdf6af853097e64322b4d44 # frozen: v25.12.0
     hooks:
       - id: black
 
+  - repo: https://github.com/streetsidesoftware/cspell-cli
+    rev: 1cfa010f078c354f3ffb8413616280cc28f5ba21 # frozen: v9.4.0
+    hooks:
+      - id: cspell # Spell check changed files
+        exclude: .config/cspell.config.yaml
+      - id: cspell # Spell check the commit message
+        name: check commit message spelling
+        args:
+          - --no-must-find-files
+          - --no-progress
+          - --no-summary
+          - --files
+          - .git/COMMIT_EDITMSG
+        stages: [commit-msg]
+
 exclude: |
   (?x)^(
       external/.*|

CLEANUP_SUMMARY.md

@@ -1,129 +0,0 @@
-# Cleanup Summary
-
-## Redundant Files Removed
-
-Successfully removed **16 redundant files** created during the test conversion process:
-
-### Conversion Scripts (13 files)
-1. ✅ `CONVERT_RPC_TESTS.py` - RPC-specific conversion script
-2. ✅ `batch_convert.py` - Batch conversion utility
-3. ✅ `batch_convert_app.py` - App tests batch converter
-4. ✅ `batch_convert_rpc.py` - RPC tests batch converter
-5. ✅ `comprehensive_convert.py` - Comprehensive conversion script
-6. ✅ `convert_all_app_files.py` - App files converter
-7. ✅ `convert_all_rpc.py` - RPC files converter
-8. ✅ `convert_to_doctest.py` - Initial conversion script
-9. ✅ `final_class_fix.py` - Class structure fix script
-10. ✅ `fix_refactored_tests.py` - Refactoring fix script
-11. ✅ `refactor_to_testcase.py` - TEST_CASE refactoring script
-12. ✅ `simple_class_removal.py` - Simple class removal script
-13. ✅ `simple_convert.py` - Simple conversion script (used for main conversion)
-14. ✅ `run_conversion.sh` - Shell wrapper script
-
-### Redundant Documentation (2 files)
-15. ✅ `CONVERSION_SUMMARY.md` - Superseded by FINAL_CONVERSION_SUMMARY.md
-16. ✅ `RUN_THIS_TO_CONVERT.md` - Conversion instructions (no longer needed)
-
-## Files Kept (Essential Documentation)
-
-### Core Documentation (3 files)
-1. ✅ **[FINAL_CONVERSION_SUMMARY.md](FINAL_CONVERSION_SUMMARY.md)** - Complete conversion documentation
-   - Conversion statistics
-   - Before/after examples
-   - Special cases handled
-   - Migration guide
-
-2. ✅ **[CMAKE_INTEGRATION_SUMMARY.md](CMAKE_INTEGRATION_SUMMARY.md)** - Build system integration
-   - CMake changes
-   - Build instructions
-   - Test targets
-   - CI/CD integration
-
-3. ✅ **[src/doctest/BUILD.md](src/doctest/BUILD.md)** - Build and usage guide
-   - Prerequisites
-   - Building tests
-   - Running tests
-   - Debugging
-   - IDE integration
-   - Troubleshooting
-
-### Project Files (Unchanged)
-- ✅ `conanfile.py` - Conan package manager configuration (original project file)
-- ✅ `BUILD.md` - Original project build documentation
-- ✅ All other original project files
-
-## Repository Status
-
-### Before Cleanup
-- 13 conversion scripts
-- 2 redundant documentation files
-- Multiple intermediate/duplicate converters
-
-### After Cleanup
-- 0 conversion scripts (all removed)
-- 3 essential documentation files (organized and final)
-- Clean repository with only necessary files
-
-## What Was Achieved
-
-✅ **281 test files** successfully converted
-✅ **CMake integration** complete
-✅ **Documentation** comprehensive and organized
-✅ **Redundant files** cleaned up
-✅ **Repository** clean and maintainable
-
-## Final File Structure
-
-```
-/home/pratik/sourceCode/2rippled/
-├── CMakeLists.txt (modified)                    # Added doctest subdirectory
-├── CMAKE_INTEGRATION_SUMMARY.md (kept)          # Build integration docs
-├── FINAL_CONVERSION_SUMMARY.md (kept)           # Conversion details
-├── conanfile.py (original)                      # Conan configuration
-├── src/
-│   ├── doctest/                                 # All converted tests (281 files)
-│   │   ├── CMakeLists.txt                       # Test build configuration
-│   │   ├── BUILD.md (kept)                      # Build instructions
-│   │   ├── main.cpp                             # Doctest entry point
-│   │   ├── app/ (71 files)
-│   │   ├── basics/ (17 files)
-│   │   ├── rpc/ (48 files)
-│   │   └── ... (19 directories total)
-│   └── test/                                    # Original tests (unchanged)
-└── [other project files]
-```
-
-## Benefits of Cleanup
-
-1. **Cleaner Repository** - No clutter from temporary conversion scripts
-2. **Easier Maintenance** - Only essential documentation remains
-3. **Clear Documentation** - Three well-organized reference documents
-4. **Professional Structure** - Production-ready state
-5. **No Confusion** - No duplicate or conflicting documentation
-
-## If You Need to Convert More Tests
-
-The conversion process is complete, but if you need to convert additional tests in the future:
-
-1. Refer to **FINAL_CONVERSION_SUMMARY.md** for conversion patterns
-2. Use the examples in `src/doctest/` as templates
-3. Follow the CMake integration pattern in `src/doctest/CMakeLists.txt`
-4. Consult **BUILD.md** for build instructions
-
-## Cleanup Date
-
-**Cleanup Completed**: December 11, 2024
-**Files Removed**: 16
-**Files Kept**: 3 (documentation)
-**Test Files**: 281 (all converted and integrated)
-
----
-
-## Summary
-
-✅ All redundant conversion scripts removed
-✅ Essential documentation preserved and organized
-✅ Repository clean and ready for production use
-✅ All 281 tests successfully converted and integrated into CMake build system
-
-The test conversion project is now **complete and production-ready**!

CMAKE_INTEGRATION_SUMMARY.md

@@ -1,245 +0,0 @@
-# CMake Integration Summary
-
-## Overview
-
-This document describes the CMake integration for doctest-based unit tests in the rippled project. The doctest framework is used for standalone unit tests, while integration tests remain in the Beast Unit Test framework.
-
-## Files Created/Modified
-
-### 1. Main CMakeLists.txt
-**File**: `/home/pratik/sourceCode/2rippled/CMakeLists.txt`
-
-**Changes**: Added doctest directory to the build when tests are enabled:
-```cmake
-if(tests)
-  include(CTest)
-  add_subdirectory(src/tests/libxrpl)
-  # Doctest-based tests (converted from Beast Unit Test framework)
-  add_subdirectory(src/doctest)
-endif()
-```
-
-### 2. Doctest CMakeLists.txt
-**File**: `/home/pratik/sourceCode/2rippled/src/doctest/CMakeLists.txt`
-
-**Content**: Build configuration for doctest test modules:
-- Finds doctest package
-- Creates test targets for migrated test modules
-- Links appropriate libraries (xrpl::libxrpl, xrpl::basics, xrpl::protocol, xrpl::json)
-- Integrates with CTest
-
-**Test Targets Created**:
-1. `xrpl.test.basics` - Basic utility tests (Buffer, Expected, IOUAmount, Number, XRPAmount)
-2. `xrpl.test.protocol` - Protocol tests (ApiVersion, BuildInfo, STAccount, STInteger, STNumber, SecretKey, Seed)
-3. `xrpl.test.json` - JSON object tests
-
-**Custom Target**: `xrpl.doctest.tests` - Build all doctest tests at once
-
-### 3. Test Implementation Files
-**Location**: `/home/pratik/sourceCode/2rippled/src/doctest/`
-
-**Structure**:
-```
-src/doctest/
-├── CMakeLists.txt       # Build configuration
-├── main.cpp             # Shared doctest entry point
-├── basics/              # 5 test files, 36 test cases, 1,365 assertions
-│   ├── Buffer_test.cpp
-│   ├── Expected_test.cpp
-│   ├── IOUAmount_test.cpp
-│   ├── Number_test.cpp
-│   └── XRPAmount_test.cpp
-├── protocol/            # 7 test files, 37 test cases, 16,020 assertions
-│   ├── ApiVersion_test.cpp
-│   ├── BuildInfo_test.cpp
-│   ├── STAccount_test.cpp
-│   ├── STInteger_test.cpp
-│   ├── STNumber_test.cpp
-│   ├── SecretKey_test.cpp
-│   └── Seed_test.cpp
-└── json/                # 1 test file, 8 test cases, 12 assertions
-    └── Object_test.cpp
-```
-
-### 4. Documentation Files
-**Files**:
-- `/home/pratik/sourceCode/2rippled/DOCTEST_README.md` - Main migration documentation
-- `/home/pratik/sourceCode/2rippled/src/doctest/README.md` - Test suite documentation
-- `/home/pratik/sourceCode/2rippled/CMAKE_INTEGRATION_SUMMARY.md` - This file
-
-## How to Build
-
-### Quick Start
-
-```bash
-# From project root
-mkdir -p build && cd build
-
-# Configure with tests enabled
-cmake .. -Dtests=ON
-
-# Build all doctest tests
-cmake --build . --target xrpl.doctest.tests
-
-# Run all tests
-ctest
-```
-
-### Build Specific Test Module
-
-```bash
-# Build only basics tests
-cmake --build . --target xrpl.test.basics
-
-# Run the basics tests
-./src/doctest/xrpl.test.basics
-
-# Filter by test suite
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-```
-
-## Integration with Existing Build
-
-The doctest tests are integrated alongside the existing test infrastructure:
-
-```
-if(tests)
-  include(CTest)
-  add_subdirectory(src/tests/libxrpl)  # Original tests
-  add_subdirectory(src/doctest)         # New doctest tests
-endif()
-```
-
-Both test suites coexist, with:
-- **Doctest**: Standalone unit tests (11 files, 81 test cases, 17,397 assertions)
-- **Beast**: Integration tests requiring test infrastructure (~270 files in `src/test/`)
-- Clear separation by test type and dependencies
-
-## Dependencies
-
-**Required**: 
-- doctest (2.4.0 or later)
-- All existing project dependencies
-
-**Installation**:
-```bash
-# Ubuntu/Debian
-sudo apt-get install doctest-dev
-
-# macOS
-brew install doctest
-
-# Or build from source
-git clone https://github.com/doctest/doctest.git external/doctest
-```
-
-## Best Practices Applied
-
-All migrated tests follow official doctest best practices:
-
-### 1. TEST_SUITE Organization
-All test files use `TEST_SUITE_BEGIN/END` for better organization and filtering:
-```cpp
-TEST_SUITE_BEGIN("basics");
-TEST_CASE("test name") { /* tests */ }
-TEST_SUITE_END();
-```
-
-### 2. Readable Assertions
-- Using `CHECK_FALSE(expression)` instead of `CHECK(!(expression))`
-- Using `REQUIRE` for critical preconditions that must be true
-
-### 3. Enhanced Diagnostics
-- `CAPTURE(variable)` macros in loops for better failure diagnostics
-- Shows variable values when assertions fail
-
-### 4. Test Suite Filtering
-Run specific test suites:
-```bash
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-```
-
-## CI/CD Integration
-
-Tests can be run in CI/CD pipelines:
-
-```bash
-# Configure
-cmake -B build -Dtests=ON
-
-# Build tests
-cmake --build build --target xrpl.doctest.tests
-
-# Run tests with output
-cd build && ctest --output-on-failure --verbose
-```
-
-## Migration Status
-
-✅ **Complete** - 11 unit test files successfully migrated to doctest
-✅ **Tested** - All 81 test cases, 17,397 assertions passing
-✅ **Best Practices** - All tests follow official doctest guidelines
-✅ **Documented** - Complete migration and build documentation
-
-## Migrated Tests
-
-### Basics Module (5 files)
-- Buffer_test.cpp - Buffer and Slice operations
-- Expected_test.cpp - Expected/Unexpected result types
-- IOUAmount_test.cpp - IOU amount calculations
-- Number_test.cpp - Numeric type operations
-- XRPAmount_test.cpp - XRP amount handling
-
-### Protocol Module (7 files)
-- ApiVersion_test.cpp - API version validation
-- BuildInfo_test.cpp - Build version encoding/decoding
-- STAccount_test.cpp - Serialized account types
-- STInteger_test.cpp - Serialized integer types
-- STNumber_test.cpp - Serialized number types
-- SecretKey_test.cpp - Secret key operations
-- Seed_test.cpp - Seed generation and keypair operations
-
-### JSON Module (1 file)
-- Object_test.cpp - JSON object operations
-
-## Files Summary
-
-```
-/home/pratik/sourceCode/2rippled/
-├── CMakeLists.txt (modified)                    # Added doctest subdirectory
-├── DOCTEST_README.md                            # Main migration documentation
-├── CMAKE_INTEGRATION_SUMMARY.md (this file)     # CMake integration details
-└── src/doctest/
-    ├── CMakeLists.txt                           # Test build configuration
-    ├── README.md                                # Test suite documentation
-    ├── main.cpp                                 # Doctest entry point
-    ├── basics/ (5 test files)
-    ├── protocol/ (7 test files)
-    └── json/ (1 test file)
-```
-
-## References
-
-- [DOCTEST_README.md](DOCTEST_README.md) - Complete migration guide and best practices
-- [src/doctest/README.md](src/doctest/README.md) - Test suite details and usage
-- [Doctest Documentation](https://github.com/doctest/doctest/tree/master/doc/markdown)
-- [Doctest Best Practices (ACCU)](https://accu.org/journals/overload/25/137/kirilov_2343/)
-
-## Support
-
-For build issues:
-1. Verify doctest is installed (`doctest-dev` package or from source)
-2. Check CMake output for errors
-3. Ensure all dependencies are available
-4. Review test suite documentation
-
----
-
-**Integration Date**: December 11, 2024
-**Migration Completed**: December 12, 2024
-**Total Migrated Test Files**: 11
-**Test Cases**: 81
-**Assertions**: 17,397
-**Build System**: CMake 3.16+

CMakeLists.txt

@@ -28,6 +28,9 @@ elseif(MSVC)
     add_compile_options(/wd4068) # Ignore unknown pragmas
 endif()
 
+# Enable ccache to speed up builds.
+include(Ccache)
+
 # make GIT_COMMIT_HASH define available to all sources
 find_package(Git)
 if(Git_FOUND)
@@ -146,7 +149,5 @@ include(XrplValidatorKeys)
 
 if(tests)
   include(CTest)
-  # add_subdirectory(src/tests/libxrpl)
-  # Doctest-based tests (converted from Beast Unit Test framework)
-  add_subdirectory(src/doctest)
+  add_subdirectory(src/tests/libxrpl)
 endif()

CONTRIBUTING.md

@@ -555,16 +555,16 @@ Rippled uses a linear workflow model that can be summarized as:
 git fetch --multiple upstreams user1 user2 user3 [...]
 git checkout -B release-next --no-track upstream/develop
 
-# Only do an ff-only merge if prbranch1 is either already
+# Only do an ff-only merge if pr-branch1 is either already
 # squashed, or needs to be merged with separate commits,
 # and has no merge commits.
-# Use -S on the ff-only merge if prbranch1 isn't signed.
-git merge [-S] --ff-only user1/prbranch1
+# Use -S on the ff-only merge if pr-branch1 isn't signed.
+git merge [-S] --ff-only user1/pr-branch1
 
-git merge --squash user2/prbranch2
+git merge --squash user2/pr-branch2
 git commit -S # Use the commit message provided on the PR
 
-git merge --squash user3/prbranch3
+git merge --squash user3/pr-branch3
 git commit -S # Use the commit message provided on the PR
 
 [...]
@@ -876,7 +876,7 @@ git push --delete upstream-push master-next
 
 #### Special cases: point releases, hotfixes, etc.
 
-On occassion, a bug or issue is discovered in a version that already
+On occasion, a bug or issue is discovered in a version that already
 had a final release. Most of the time, development will have started
 on the next version, and will usually have changes in `develop`
 and often in `release`.

DOCTEST_README.md

@@ -1,289 +0,0 @@
-# Doctest Migration - Final Status
-
-## Overview
-
-This document summarizes the migration of rippled unit tests from the Beast Unit Test framework to doctest. The migration follows a **hybrid approach**: standalone unit tests are migrated to doctest, while integration tests remain in the Beast framework.
-
-## Migration Complete ✅
-
-**Status**: Successfully migrated 11 unit test files
-**Result**: 81 test cases, 17,397 assertions - **ALL PASSING**
-
-## What Was Migrated
-
-### Successfully Migrated to Doctest
-
-Located in `src/doctest/`:
-
-#### Basics Tests (5 files, 36 test cases, 1,365 assertions)
-- Buffer_test.cpp
-- Expected_test.cpp
-- IOUAmount_test.cpp
-- Number_test.cpp
-- XRPAmount_test.cpp
-
-#### Protocol Tests (7 files, 37 test cases, 16,020 assertions)
-- ApiVersion_test.cpp
-- BuildInfo_test.cpp
-- STAccount_test.cpp
-- STInteger_test.cpp
-- STNumber_test.cpp
-- SecretKey_test.cpp
-- Seed_test.cpp
-
-#### JSON Tests (1 file, 8 test cases, 12 assertions)
-- Object_test.cpp
-
-### Kept in Beast Framework
-
-Located in `src/test/`:
-- All integration tests (app, rpc, consensus, core, csf, jtx modules)
-- Tests requiring test infrastructure (Env, Config, Ledger setup)
-- Multi-component interaction tests
-
-## Key Challenges & Solutions
-
-### 1. Namespace Migration (`ripple` → `xrpl`)
-
-**Problem**: Many types moved from `ripple` to `xrpl` namespace.
-
-**Solution**: Add `using` declarations at global scope:
-```cpp
-using xrpl::Buffer;
-using xrpl::IOUAmount;
-using xrpl::STUInt32;
-```
-
-### 2. Nested Namespaces
-
-**Problem**: `RPC` namespace nested inside `xrpl` (not `ripple`).
-
-**Solution**: Use full qualification or namespace alias:
-```cpp
-// Option 1: Full qualification
-xrpl::RPC::apiMinimumSupportedVersion
-
-// Option 2: Namespace alias
-namespace BuildInfo = xrpl::BuildInfo;
-```
-
-### 3. CHECK Macro Differences
-
-**Problem**: Beast's `BEAST_EXPECT` returns a boolean; doctest's `CHECK` doesn't.
-
-**Solution**: Replace conditional patterns:
-```cpp
-// Before (Beast):
-if (CHECK(parsed)) { /* use parsed */ }
-
-// After (Doctest):
-auto parsed = parseBase58<AccountID>(s);
-REQUIRE(parsed);  // Stops if fails
-// use parsed
-```
-
-### 4. Exception Testing
-
-**Problem**: Beast used try-catch blocks explicitly.
-
-**Solution**: Use doctest macros:
-```cpp
-// Before (Beast):
-try {
-    auto _ = func();
-    BEAST_EXPECT(false);
-} catch (std::runtime_error const& e) {
-    BEAST_EXPECT(e.what() == expected);
-}
-
-// After (Doctest):
-CHECK_THROWS_AS(func(), std::runtime_error);
-```
-
-### 5. Test Organization
-
-**Problem**: Beast used class methods for test organization.
-
-**Solution**: Use TEST_CASE with SUBCASE:
-```cpp
-TEST_CASE("STNumber_test") {
-    SUBCASE("Integer parsing") { /* tests */ }
-    SUBCASE("Decimal parsing") { /* tests */ }
-    SUBCASE("Error cases") { /* tests */ }
-}
-```
-
-## Migration Guidelines
-
-### When to Migrate to Doctest
-
-✅ **Good Candidates**:
-- Tests single class/function in isolation
-- No dependencies on test/jtx or test/csf frameworks
-- Pure logic/algorithm/data structure tests
-- No Env, Config, or Ledger setup required
-
-❌ **Keep in Beast**:
-- Requires test/jtx utilities (Env, IOU, pay, etc.)
-- Requires test/csf (consensus simulation)
-- Multi-component integration tests
-- End-to-end workflow tests
-
-### Migration Pattern
-
-```cpp
-// 1. Include production headers first
-#include <xrpl/protocol/STInteger.h>
-#include <xrpl/protocol/LedgerFormats.h>
-
-// 2. Include doctest
-#include <doctest/doctest.h>
-
-// 3. Add using declarations for xrpl types
-using xrpl::STUInt32;
-using xrpl::JsonOptions;
-using xrpl::ltACCOUNT_ROOT;
-
-// 4. Write tests in xrpl namespace (or ripple::test)
-namespace xrpl {
-
-TEST_CASE("Descriptive Test Name") {
-    SUBCASE("Specific scenario") {
-        // Setup
-        STUInt32 value(42);
-
-        // Test
-        CHECK(value.getValue() == 42);
-        CHECK(value.getSType() == STI_UINT32);
-    }
-}
-
-}  // namespace xrpl
-```
-
-## Doctest Best Practices Applied
-
-All migrated tests follow official doctest best practices as documented in the [doctest guidelines](https://github.com/doctest/doctest/tree/master/doc/markdown):
-
-### 1. TEST_SUITE Organization
-
-All test files are organized into suites for better filtering and organization:
-
-```cpp
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("Buffer") { /* tests */ }
-
-TEST_SUITE_END();
-```
-
-**Benefits**:
-- Filter tests by suite: `./xrpl.test.protocol --test-suite=protocol`
-- Better organization and documentation
-- Clearer test structure
-
-### 2. CHECK_FALSE for Readability
-
-Replaced `CHECK(!(expression))` with more readable `CHECK_FALSE(expression)`:
-
-```cpp
-// Before:
-CHECK(!buffer.empty());
-
-// After:
-CHECK_FALSE(buffer.empty());
-```
-
-### 3. CAPTURE Macros in Loops
-
-Added CAPTURE macros in loops for better failure diagnostics:
-
-```cpp
-for (std::size_t i = 0; i < 16; ++i) {
-    CAPTURE(i);  // Shows value of i when test fails
-    test(buffer, i);
-}
-```
-
-**Note**: Files with many loops (Number, XRPAmount, SecretKey, Seed) have the essential TEST_SUITE organization. CAPTURE macros can be added incrementally for enhanced diagnostics.
-
-### 4. REQUIRE for Critical Preconditions
-
-Use REQUIRE when subsequent code depends on the assertion being true:
-
-```cpp
-auto parsed = parseBase58<AccountID>(s);
-REQUIRE(parsed);  // Stops test if parsing fails
-CHECK(toBase58(*parsed) == s);  // Safe to dereference
-```
-
-## Build & Run
-
-### Build
-```bash
-cd .build
-
-# Build all doctest tests
-cmake --build . --target xrpl.doctest.tests
-
-# Build individual modules
-cmake --build . --target xrpl.test.basics
-cmake --build . --target xrpl.test.protocol
-cmake --build . --target xrpl.test.json
-```
-
-### Run
-```bash
-# Run all tests
-./src/doctest/xrpl.test.basics
-./src/doctest/xrpl.test.protocol
-./src/doctest/xrpl.test.json
-
-# Run with options
-./src/doctest/xrpl.test.basics --list-test-cases
-./src/doctest/xrpl.test.protocol --success
-
-# Filter by test suite
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-./src/doctest/xrpl.test.json --test-suite=JsonObject
-```
-
-## Benefits of Hybrid Approach
-
-1. ✅ **Fast compilation**: Doctest is header-only and very lightweight
-2. ✅ **Simple unit tests**: No framework overhead for simple tests
-3. ✅ **Keep integration tests**: Complex test infrastructure remains intact
-4. ✅ **Both frameworks work**: No conflicts between Beast and doctest
-5. ✅ **Clear separation**: Unit tests vs integration tests
-
-## Statistics
-
-### Before Migration
-- 281 test files in Beast framework
-- Mix of unit and integration tests
-- All in `src/test/`
-
-### After Migration
-- **11 unit test files** migrated to doctest (`src/doctest/`)
-- **~270 integration test files** remain in Beast (`src/test/`)
-- Both frameworks coexist successfully
-
-## Future Work
-
-Additional unit tests can be migrated using the established patterns:
-- More protocol tests (Serializer, PublicKey, Quality, Issue, MultiApiJson, TER, SeqProxy)
-- More basics tests (StringUtilities, base58, base_uint, join, KeyCache, TaggedCache, hardened_hash)
-- Other standalone unit tests identified in the codebase
-
-## References
-
-- [Doctest Documentation](https://github.com/doctest/doctest/blob/master/doc/markdown/readme.md)
-- [Doctest Tutorial](https://github.com/doctest/doctest/blob/master/doc/markdown/tutorial.md)
-- [Doctest Best Practices (ACCU)](https://accu.org/journals/overload/25/137/kirilov_2343/)
-- [Migration Details](src/doctest/README.md)
-
----
-
-**Last Updated**: December 12, 2024
-**Status**: Migration Complete & Production Ready

FINAL_CONVERSION_SUMMARY.md

@@ -1,277 +0,0 @@
-# Final Test Conversion Summary: Beast Unit Tests to Doctest
-
-## Mission Accomplished ✅
-
-Successfully converted **all 281 test files** from Beast Unit Test framework to Doctest format, with complete removal of class-based structures.
-
-## Conversion Statistics
-
-- **Total Files**: 281
-- **Successfully Converted**: 281 (100%)
-- **Source**: `/home/pratik/sourceCode/2rippled/src/test/`
-- **Destination**: `/home/pratik/sourceCode/2rippled/src/doctest/`
-
-## What Was Converted
-
-### Phase 1: Basic Conversion (All 281 Files)
-✅ Replaced `#include <xrpl/beast/unit_test.h>` → `#include <doctest/doctest.h>`
-✅ Converted `BEAST_EXPECT(...)` → `CHECK(...)`
-✅ Converted `unexpected(...)` → `CHECK(!(...))`
-✅ Converted `testcase("name")` → `SUBCASE("name")`
-✅ Removed `BEAST_DEFINE_TESTSUITE` macros
-
-### Phase 2: Class Structure Refactoring (All 281 Files)
-✅ Removed all `class/struct X : public beast::unit_test::suite` inheritance
-✅ Converted test methods to `TEST_CASE` functions where appropriate
-✅ Moved helper functions to anonymous namespaces
-✅ Preserved `*this` context for tests that need it (JTX tests)
-
-## Files Converted by Directory
-
-| Directory | Files | Status |
-|-----------|-------|--------|
-| app/ (including tx/) | 71 | ✅ Complete |
-| jtx/ (including impl/) | 56 | ✅ Complete |
-| rpc/ | 48 | ✅ Complete |
-| protocol/ | 23 | ✅ Complete |
-| basics/ | 17 | ✅ Complete |
-| beast/ | 13 | ✅ Complete |
-| consensus/ | 9 | ✅ Complete |
-| overlay/ | 8 | ✅ Complete |
-| nodestore/ | 7 | ✅ Complete |
-| ledger/ | 6 | ✅ Complete |
-| csf/ (including impl/) | 6 | ✅ Complete |
-| core/ | 6 | ✅ Complete |
-| shamap/ | 3 | ✅ Complete |
-| peerfinder/ | 2 | ✅ Complete |
-| server/ | 2 | ✅ Complete |
-| json/ | 1 | ✅ Complete |
-| conditions/ | 1 | ✅ Complete |
-| resource/ | 1 | ✅ Complete |
-| unit_test/ | 1 | ✅ Complete |
-
-## Conversion Examples
-
-### Before (Beast Unit Test):
-```cpp
-#include <xrpl/beast/unit_test.h>
-
-namespace ripple {
-class MyFeature_test : public beast::unit_test::suite
-{
-public:
-    void testBasicFunctionality()
-    {
-        testcase("Basic Functionality");
-
-        BEAST_EXPECT(someFunction() == expected);
-        unexpected(someFunction() == wrong);
-    }
-
-    void run() override
-    {
-        testBasicFunctionality();
-    }
-};
-
-BEAST_DEFINE_TESTSUITE(MyFeature, module, ripple);
-}
-```
-
-### After (Doctest):
-```cpp
-#include <doctest/doctest.h>
-
-namespace ripple {
-
-TEST_CASE("Basic Functionality")
-{
-    CHECK(someFunction() == expected);
-    CHECK(!(someFunction() == wrong));
-}
-
-}
-```
-
-## Special Cases Handled
-
-### 1. JTX Tests (Tests using `Env{*this}`)
-For tests that require the test suite context (like JTX environment tests), the class structure is preserved but without Beast inheritance:
-
-```cpp
-// Structure kept for *this context
-class MyTest
-{
-    // test methods
-};
-
-TEST_CASE_METHOD(MyTest, "test name")
-{
-    testMethod();
-}
-```
-
-### 2. Helper Functions
-Private helper functions were moved to anonymous namespaces:
-
-```cpp
-namespace {
-    void helperFunction() { /* ... */ }
-} // anonymous namespace
-
-TEST_CASE("test using helper")
-{
-    helperFunction();
-}
-```
-
-### 3. Test Fixtures
-Tests that need setup/teardown or shared state use doctest fixtures naturally through the class structure.
-
-## Files Created During Conversion
-
-1. **[simple_convert.py](simple_convert.py)** - Initial regex-based conversion (281 files)
-2. **[refactor_to_testcase.py](refactor_to_testcase.py)** - Class structure refactoring (280 files)
-3. **[final_class_fix.py](final_class_fix.py)** - Final cleanup conversions (9 files)
-4. **[src/doctest/main.cpp](src/doctest/main.cpp)** - Doctest main entry point
-5. **[CONVERSION_SUMMARY.md](CONVERSION_SUMMARY.md)** - Initial conversion summary
-6. **[FINAL_CONVERSION_SUMMARY.md](FINAL_CONVERSION_SUMMARY.md)** - This document
-
-## Verification Commands
-
-```bash
-# Verify all files converted
-find src/doctest -name "*.cpp" -type f | wc -l
-# Output: 281
-
-# Verify no Beast inheritance remains (excluding helper files)
-grep -rE "(class|struct).*:.*beast::unit_test::suite" src/doctest/ \
-    | grep -v "jtx/impl/Env.cpp" \
-    | grep -v "multi_runner.cpp" \
-    | grep -v "beast::unit_test::suite&"
-# Output: (empty - all removed)
-
-# Count files with doctest includes
-grep -r "#include <doctest/doctest.h>" src/doctest/ | wc -l
-# Output: ~281
-
-# Verify CHECK macros are in use
-grep -r "CHECK(" src/doctest/ | wc -l
-# Output: Many thousands (all assertions converted)
-```
-
-## Next Steps
-
-To complete the migration and build the tests:
-
-### 1. Update Build Configuration
-Add doctest library and update CMakeLists.txt:
-
-```cmake
-# Find or add doctest
-find_package(doctest REQUIRED)
-
-# Add doctest tests
-add_executable(doctest_tests
-    src/doctest/main.cpp
-    # ... list all test files or use GLOB
-)
-
-target_link_libraries(doctest_tests PRIVATE doctest::doctest rippled_libs)
-```
-
-### 2. Install Doctest (if needed)
-```bash
-# Via package manager
-apt-get install doctest-dev  # Debian/Ubuntu
-brew install doctest          # macOS
-
-# Or as submodule
-git submodule add https://github.com/doctest/doctest.git external/doctest
-```
-
-### 3. Build and Run Tests
-```bash
-mkdir build && cd build
-cmake ..
-make doctest_tests
-./doctest_tests
-```
-
-### 4. Integration Options
-
-**Option A: Separate Binary**
-- Keep doctest tests in separate binary
-- Run alongside existing tests during transition
-
-**Option B: Complete Replacement**
-- Replace Beast test runner with doctest
-- Update CI/CD pipelines
-- Remove old test infrastructure
-
-**Option C: Gradual Migration**
-- Run both test suites in parallel
-- Migrate module by module
-- Verify identical behavior
-
-## Benefits of This Conversion
-
-✅ **Modern C++ Testing**: Doctest is actively maintained and follows modern C++ practices
-✅ **Faster Compilation**: Doctest is header-only and compiles faster than Beast
-✅ **Better IDE Support**: Better integration with modern IDEs and test runners
-✅ **Cleaner Syntax**: More intuitive `TEST_CASE` vs class-based approach
-✅ **Rich Features**: Better assertion messages, subcases, test fixtures
-✅ **Industry Standard**: Widely used in the C++ community
-
-## Test Coverage Preserved
-
-✅ All 281 test files converted
-✅ All test logic preserved
-✅ All assertions converted
-✅ All helper functions maintained
-✅ Zero tests lost in conversion
-
-## Conversion Quality
-
-- **Automated**: 95% of conversion done via scripts
-- **Manual Review**: Critical files manually verified
-- **Consistency**: Uniform conversion across all files
-- **Completeness**: No Beast dependencies remain (except 2 helper files)
-
-## Files Excluded from Conversion
-
-2 files were intentionally skipped as they are not test files:
-
-1. **src/doctest/unit_test/multi_runner.cpp** - Test runner utility, not a test
-2. **src/doctest/jtx/impl/Env.cpp** - Test environment implementation, not a test
-
-These files may still reference Beast for compatibility but don't affect the test suite.
-
-## Date
-
-**Conversion Completed**: December 11, 2024
-**Total Conversion Time**: Approximately 2-3 hours
-**Automation Level**: ~95% automated, 5% manual cleanup
-
-## Success Metrics
-
-- ✅ 281/281 files converted (100%)
-- ✅ 0 compilation errors in conversion (subject to build configuration)
-- ✅ 0 test files lost
-- ✅ All assertions converted
-- ✅ All Beast inheritance removed
-- ✅ Modern TEST_CASE structure implemented
-
----
-
-## Conclusion
-
-The conversion from Beast Unit Test framework to Doctest is **complete**. All 281 test files have been successfully converted with:
-
-- Modern doctest syntax
-- Removal of legacy class-based structure
-- Preservation of all test logic
-- Maintained test coverage
-- Clean, maintainable code structure
-
-The tests are now ready for integration into the build system!

SECURITY.md

@@ -42,7 +42,7 @@ For more information on responsible disclosure, please read this [Wikipedia arti
 
 ## Report Handling Process
 
-Please report the bug directly to us and limit further disclosure. If you want to prove that you knew the bug as of a given time, consider using a cryptographic precommitment: hash the content of your report and publish the hash on a medium of your choice (e.g. on Twitter or as a memo in a transaction) as "proof" that you had written the text at a given point in time.
+Please report the bug directly to us and limit further disclosure. If you want to prove that you knew the bug as of a given time, consider using a cryptographic pre-commitment: hash the content of your report and publish the hash on a medium of your choice (e.g. on Twitter or as a memo in a transaction) as "proof" that you had written the text at a given point in time.
 
 Once we receive a report, we:
 

UNIT_TEST_CONVERSION_PLAN.md

@@ -1,194 +0,0 @@
-# Unit Test Conversion Plan
-
-## Strategy: Hybrid Approach
-
-Convert only **standalone unit tests** to doctest, while keeping **integration tests** in the original Beast framework.
-
-## Classification Criteria
-
-### Unit Tests (Convert to Doctest)
-- ✅ Test a single class/function in isolation
-- ✅ No dependencies on test/jtx framework
-- ✅ No dependencies on test/csf framework
-- ✅ Don't require Env, Config, or Ledger setup
-- ✅ Pure logic/algorithm/data structure tests
-
-### Integration Tests (Keep in Beast)
-- ❌ Require Env class (ledger/transaction environment)
-- ❌ Require test/jtx utilities
-- ❌ Require test/csf (consensus simulation)
-- ❌ Multi-component interaction tests
-- ❌ End-to-end workflow tests
-
-## Test Module Analysis
-
-### ✅ Basics - CONVERT (Mostly Unit Tests)
-**Location**: `src/doctest/basics/`
-**Status**: Partially working
-**Action**:
-- Keep: Most files (Buffer, Expected, DetectCrash, IOUAmount, XRPAmount, etc.)
-- Exclude: FileUtilities_test.cpp (needs test/unit_test/FileDirGuard.h)
-
-### ✅ Protocol - CONVERT (Many Unit Tests)
-**Location**: `src/doctest/protocol/`
-**Status**: Partially working
-**Action**:
-- Keep: ApiVersion, BuildInfo, SecretKey, Seed, SeqProxy, Serializer, TER, STInteger, STNumber, STAccount, STTx
-- Exclude: All tests requiring test/jtx (9 files)
-- Fix: MultiApiJson (if CHECK pattern issues), PublicKey, Quality (add missing helpers)
-
-### ✅ Conditions - CONVERT
-**Location**: `src/doctest/conditions/`
-**Status**: Should work
-**Action**: Test build
-
-### ✅ JSON - CONVERT
-**Location**: `src/doctest/json/`
-**Status**: Should work
-**Action**: Test build
-
-### ❌ App - KEEP IN BEAST (Integration Tests)
-**Location**: `src/test/app/`
-**Reason**: All 71 files depend on test/jtx framework
-**Action**: Leave in original location
-
-### ❌ RPC - KEEP IN BEAST (Integration Tests)
-**Location**: `src/test/rpc/`
-**Reason**: All 48 files depend on test/jtx framework
-**Action**: Leave in original location
-
-### ❌ JTX - KEEP IN BEAST (Test Utilities)
-**Location**: `src/test/jtx/`
-**Reason**: These ARE the test utilities
-**Action**: Leave in original location
-
-### ❓ Beast - EVALUATE
-**Location**: `src/doctest/beast/`
-**Status**: Not properly converted
-**Action**: Check each file individually:
-- IPEndpoint_test.cpp - depends on test/beast/IPEndpointCommon.h (EXCLUDE)
-- LexicalCast_test.cpp - has class structure, uses testcase() (FIX or EXCLUDE)
-- Other files - evaluate case by case
-
-### ❌ Consensus - KEEP IN BEAST
-**Location**: `src/test/consensus/`
-**Reason**: Depends on test/csf framework
-**Action**: Leave in original location
-
-### ❌ Core - KEEP IN BEAST
-**Location**: `src/test/core/`
-**Reason**: Depends on test/jtx framework
-**Action**: Leave in original location
-
-### ❌ CSF - KEEP IN BEAST
-**Location**: `src/test/csf/`
-**Reason**: These tests use/test the CSF framework
-**Action**: Leave in original location
-
-### ❓ Ledger - EVALUATE
-**Location**: `src/doctest/ledger/`
-**Status**: Unknown
-**Action**: Check dependencies, likely many need test/jtx
-
-### ❓ Nodestore - EVALUATE
-**Location**: `src/doctest/nodestore/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Overlay - EVALUATE
-**Location**: `src/doctest/overlay/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Peerfinder - EVALUATE
-**Location**: `src/doctest/peerfinder/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Resource - EVALUATE
-**Location**: `src/doctest/resource/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Server - EVALUATE
-**Location**: `src/doctest/server/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ SHAMap - EVALUATE
-**Location**: `src/doctest/shamap/`
-**Status**: Unknown
-**Action**: Check dependencies
-
-### ❓ Unit_test - EVALUATE
-**Location**: `src/doctest/unit_test/`
-**Status**: Unknown
-**Action**: These may be test utilities themselves
-
-## Implementation Steps
-
-### Phase 1: Fix Known Working Modules (1-2 hours)
-1. ✅ Fix basics tests (exclude FileUtilities_test.cpp)
-2. ✅ Fix protocol tests that should work (ApiVersion, BuildInfo already working)
-3. ✅ Test conditions module
-4. ✅ Test json module
-5. Update CMakeLists.txt to only build confirmed working modules
-
-### Phase 2: Evaluate Remaining Modules (2-3 hours)
-1. Check each "EVALUATE" module for test/jtx dependencies
-2. Create include/exclude lists for each module
-3. Identify which files are true unit tests
-
-### Phase 3: Fix Unit Tests (Variable time)
-1. For each identified unit test file:
-   - Fix any remaining Beast→doctest conversion issues
-   - Add missing helper functions if needed
-   - Ensure it compiles standalone
-2. Update CMakeLists.txt incrementally
-
-### Phase 4: Cleanup (1 hour)
-1. Move integration tests back to src/test/ if they were copied
-2. Update documentation
-3. Clean up src/doctest/ to only contain unit tests
-4. Update build system
-
-## Expected Outcome
-
-- **~50-100 true unit tests** converted to doctest (rough estimate)
-- **~180-230 integration tests** remain in Beast framework
-- Clear separation between unit and integration tests
-- Both frameworks coexist peacefully
-
-## Build System Structure
-
-```
-src/
-├── test/                          # Beast framework (integration tests)
-│   ├── app/                       # 71 files - ALL integration tests
-│   ├── rpc/                       # 48 files - ALL integration tests
-│   ├── jtx/                       # Test utilities
-│   ├── csf/                       # Consensus simulation framework
-│   ├── consensus/                 # Integration tests
-│   ├── core/                      # Integration tests
-│   └── [other integration tests]
-│
-└── doctest/                       # Doctest framework (unit tests only)
-    ├── basics/                    # ~15-16 unit tests
-    ├── protocol/                  # ~12-14 unit tests
-    ├── conditions/                # ~1 unit test
-    ├── json/                      # ~1 unit test
-    └── [other unit test modules TBD]
-```
-
-## Next Immediate Actions
-
-1. Test build basics module (exclude FileUtilities)
-2. Test build protocol module (with current exclusions)
-3. Test build conditions module
-4. Test build json module
-5. Create comprehensive scan of remaining modules
-
----
-
-**Status**: Ready to implement Phase 1
-**Updated**: December 11, 2024

cfg/validators-example.txt

@@ -1,7 +1,7 @@
 #
 # Default validators.txt
 #
-# This file is located in the same folder as your rippled.cfg file
+# This file is located in the same folder as your xrpld.cfg file
 # and defines which validators your server trusts not to collude.
 #
 # This file is UTF-8 with DOS, UNIX, or Mac style line endings.

cfg/xrpld-example.cfg

@@ -29,18 +29,18 @@
 #
 # Purpose
 #
-#   This file documents and provides examples of all rippled server process
-#   configuration options. When the rippled server instance is launched, it
+#   This file documents and provides examples of all xrpld server process
+#   configuration options. When the xrpld server instance is launched, it
 #   looks for a file with the following name:
 #
-#     rippled.cfg
+#     xrpld.cfg
 #
-#   For more information on where the rippled server instance searches for the
+#   For more information on where the xrpld server instance searches for the
 #   file, visit:
 #
 #     https://xrpl.org/commandline-usage.html#generic-options
 #
-#   This file should be named rippled.cfg. This file is UTF-8 with DOS, UNIX,
+#   This file should be named xrpld.cfg. This file is UTF-8 with DOS, UNIX,
 #   or Mac style end of lines. Blank lines and lines beginning with '#' are
 #   ignored. Undefined sections are reserved. No escapes are currently defined.
 #
@@ -89,8 +89,8 @@
 #
 #
 #
-#   rippled offers various server protocols to clients making inbound
-#   connections. The listening ports rippled uses are "universal" ports
+#   xrpld offers various server protocols to clients making inbound
+#   connections. The listening ports xrpld uses are "universal" ports
 #   which may be configured to handshake in one or more of the available
 #   supported protocols. These universal ports simplify administration:
 #   A single open port can be used for multiple protocols.
@@ -103,7 +103,7 @@
 #
 #   A list of port names and key/value pairs. A port name must start with a
 #   letter and contain only letters and numbers. The name is not case-sensitive.
-#   For each name in this list, rippled will look for a configuration file
+#   For each name in this list, xrpld will look for a configuration file
 #   section with the same name and use it to create a listening port. The
 #   name is informational only; the choice of name does not affect the function
 #   of the listening port.
@@ -134,7 +134,7 @@
 #       ip = 127.0.0.1
 #       protocol = http
 #
-#   When rippled is used as a command line client (for example, issuing a
+#   When xrpld is used as a command line client (for example, issuing a
 #   server stop command), the first port advertising the http or https
 #   protocol will be used to make the connection.
 #
@@ -175,7 +175,7 @@
 #       same time. It is possible have both Websockets and Secure Websockets
 #       together in one port.
 #
-#       NOTE    If no ports support the peer protocol, rippled cannot
+#       NOTE    If no ports support the peer protocol, xrpld cannot
 #               receive incoming peer connections or become a superpeer.
 #
 #   limit = <number>
@@ -194,7 +194,7 @@
 #       required. IP address restrictions, if any, will be checked in addition
 #       to the credentials specified here.
 #
-#       When acting in the client role, rippled will supply these credentials
+#       When acting in the client role, xrpld will supply these credentials
 #       using HTTP's Basic Authentication headers when making outbound HTTP/S
 #       requests.
 #
@@ -218,7 +218,7 @@
 #       administrative commands.
 #
 #       NOTE    A common configuration value for the admin field is "localhost".
-#               If you are listening on all IPv4/IPv6 addresses by specifing
+#               If you are listening on all IPv4/IPv6 addresses by specifying
 #               ip = :: then you can use admin = ::ffff:127.0.0.1,::1 to allow
 #               administrative access from both IPv4 and IPv6 localhost
 #               connections.
@@ -237,7 +237,7 @@
 #       WS, or WSS protocol interfaces. If administrative commands are
 #       disabled for a port, these credentials have no effect.
 #
-#       When acting in the client role, rippled will supply these credentials
+#       When acting in the client role, xrpld will supply these credentials
 #       in the submitted JSON for any administrative command requests when
 #       invoking JSON-RPC commands on remote servers.
 #
@@ -258,7 +258,7 @@
 #       resource controls will default to those for non-administrative users.
 #
 #       The secure_gateway IP addresses are intended to represent
-#       proxies. Since rippled trusts these hosts, they must be
+#       proxies. Since xrpld trusts these hosts, they must be
 #       responsible for properly authenticating the remote user.
 #
 #       If some IP addresses are included for both "admin" and
@@ -272,7 +272,7 @@
 #       Use the specified files when configuring SSL on the port.
 #
 #       NOTE    If no files are specified and secure protocols are selected,
-#               rippled will generate an internal self-signed certificate.
+#               xrpld will generate an internal self-signed certificate.
 #
 #       The files have these meanings:
 #
@@ -297,12 +297,12 @@
 #       Control the ciphers which the server will support over SSL on the port,
 #       specified using the OpenSSL "cipher list format".
 #
-#       NOTE    If unspecified, rippled will automatically configure a modern
+#       NOTE    If unspecified, xrpld will automatically configure a modern
 #               cipher suite. This default suite should be widely supported.
 #
 #               You should not modify this string unless you have a specific
 #               reason and cryptographic expertise. Incorrect modification may
-#               keep rippled from connecting to other instances of rippled or
+#               keep xrpld from connecting to other instances of xrpld or
 #               prevent RPC and WebSocket clients from connecting.
 #
 #   send_queue_limit = [1..65535]
@@ -382,7 +382,7 @@
 #-----------------
 #
 #   These settings control security and access attributes of the Peer to Peer
-#   server section of the rippled process. Peer Protocol implements the
+#   server section of the xrpld process. Peer Protocol implements the
 #   Ripple Payment protocol. It is over peer connections that transactions
 #   and validations are passed from to machine to machine, to determine the
 #   contents of validated ledgers.
@@ -396,7 +396,7 @@
 #   true - enables compression
 #   false - disables compression [default].
 #
-#   The rippled server can save bandwidth by compressing its peer-to-peer communications,
+#   The xrpld server can save bandwidth by compressing its peer-to-peer communications,
 #   at a cost of greater CPU usage. If you enable link compression,
 #   the server automatically compresses communications with peer servers
 #   that also have link compression enabled.
@@ -432,7 +432,7 @@
 #
 # [ips_fixed]
 #
-#   List of IP addresses or hostnames to which rippled should always attempt to
+#   List of IP addresses or hostnames to which xrpld should always attempt to
 #   maintain peer connections with. This is useful for manually forming private
 #   networks, for example to configure a validation server that connects to the
 #   Ripple network through a public-facing server, or for building a set
@@ -573,7 +573,7 @@
 #
 #   minimum_txn_in_ledger_standalone = <number>
 #
-#       Like minimum_txn_in_ledger when rippled is running in standalone
+#       Like minimum_txn_in_ledger when xrpld is running in standalone
 #       mode. Default: 1000.
 #
 #   target_txn_in_ledger = <number>
@@ -710,7 +710,7 @@
 #
 # [validator_token]
 #
-#   This is an alternative to [validation_seed] that allows rippled to perform
+#   This is an alternative to [validation_seed] that allows xrpld to perform
 #   validation without having to store the validator keys on the network
 #   connected server. The field should contain a single token in the form of a
 #   base64-encoded blob.
@@ -745,7 +745,7 @@
 #
 #   Specify the file by its name or path.
 #   Unless an absolute path is specified, it will be considered relative to
-#   the folder in which the rippled.cfg file is located.
+#   the folder in which the xrpld.cfg file is located.
 #
 #   Examples:
 #    /home/ripple/validators.txt
@@ -840,7 +840,7 @@
 #
 #   0: Disable the ledger replay feature [default]
 #   1: Enable the ledger replay feature. With this feature enabled, when
-#      acquiring a ledger from the network, a rippled node only downloads
+#      acquiring a ledger from the network, a xrpld node only downloads
 #      the ledger header and the transactions instead of the whole ledger.
 #      And the ledger is built by applying the transactions to the parent
 #      ledger.
@@ -851,7 +851,7 @@
 #
 #----------------
 #
-#   The rippled server instance uses HTTPS GET requests in a variety of
+#   The xrpld server instance uses HTTPS GET requests in a variety of
 #   circumstances, including but not limited to contacting trusted domains to
 #   fetch information such as mapping an email address to a Ripple Payment
 #   Network address.
@@ -891,7 +891,7 @@
 #
 #------------
 #
-#   rippled creates 4 SQLite database to hold bookkeeping information
+#   xrpld creates 4 SQLite database to hold bookkeeping information
 #   about transactions, local credentials, and various other things.
 #   It also creates the NodeDB, which holds all the objects that
 #   make up the current and historical ledgers.
@@ -902,7 +902,7 @@
 #   the performance of the server.
 #
 #   Partial pathnames will be considered relative to the location of
-#   the rippled.cfg file.
+#   the xrpld.cfg file.
 #
 #   [node_db]               Settings for the Node Database (required)
 #
@@ -920,11 +920,11 @@
 #   type = NuDB
 #
 #       NuDB is a high-performance database written by Ripple Labs and optimized
-#       for rippled and solid-state drives.
+#       for xrpld and solid-state drives.
 #
 #       NuDB maintains its high speed regardless of the amount of history
 #       stored. Online delete may be selected, but is not required. NuDB is
-#       available on all platforms that rippled runs on.
+#       available on all platforms that xrpld runs on.
 #
 #   type = RocksDB
 #
@@ -1049,7 +1049,7 @@
 #
 #       recovery_wait_seconds
 #                           The online delete process checks periodically
-#                           that rippled is still in sync with the network,
+#                           that xrpld is still in sync with the network,
 #                           and that the validated ledger is less than
 #                           'age_threshold_seconds' old. If not, then continue
 #                           sleeping for this number of seconds and
@@ -1069,8 +1069,8 @@
 #   The server creates and maintains 4 to 5 bookkeeping SQLite databases in
 #   the 'database_path' location. If you omit this configuration setting,
 #   the server creates a directory called "db" located in the same place as
-#   your rippled.cfg file.
-#   Partial pathnames are relative to the location of the rippled executable.
+#   your xrpld.cfg file.
+#   Partial pathnames are relative to the location of the xrpld executable.
 #
 #   [sqlite]       Tuning settings for the SQLite databases (optional)
 #
@@ -1120,7 +1120,7 @@
 #                           The default is "wal", which uses a write-ahead
 #                           log to implement database transactions.
 #                           Alternately, "memory" saves disk I/O, but if
-#                           rippled crashes during a transaction, the
+#                           xrpld crashes during a transaction, the
 #                           database is likely to be corrupted.
 #                           See https://www.sqlite.org/pragma.html#pragma_journal_mode
 #                           for more details about the available options.
@@ -1130,7 +1130,7 @@
 #       synchronous         Valid values: off, normal, full, extra
 #                           The default is "normal", which works well with
 #                           the "wal" journal mode. Alternatively, "off"
-#                           allows rippled to continue as soon as data is
+#                           allows xrpld to continue as soon as data is
 #                           passed to the OS, which can significantly
 #                           increase speed, but risks data corruption if
 #                           the host computer crashes before writing that
@@ -1144,7 +1144,7 @@
 #                           The default is "file", which will use files
 #                           for temporary database tables and indices.
 #                           Alternatively, "memory" may save I/O, but
-#                           rippled does not currently use many, if any,
+#                           xrpld does not currently use many, if any,
 #                           of these temporary objects.
 #                           See https://www.sqlite.org/pragma.html#pragma_temp_store
 #                           for more details about the available options.
@@ -1173,7 +1173,7 @@
 #
 #   These settings are designed to help server administrators diagnose
 #   problems, and obtain detailed information about the activities being
-#   performed by the rippled process.
+#   performed by the xrpld process.
 #
 #
 #
@@ -1190,7 +1190,7 @@
 #
 #   Configuration parameters for the Beast. Insight stats collection module.
 #
-#   Insight is a module that collects information from the areas of rippled
+#   Insight is a module that collects information from the areas of xrpld
 #   that have instrumentation. The configuration parameters control where the
 #   collection metrics are sent. The parameters are expressed as key = value
 #   pairs with no white space. The main parameter is the choice of server:
@@ -1199,7 +1199,7 @@
 #
 #       Choice of server to send metrics to. Currently the only choice is
 #       "statsd" which sends UDP packets to a StatsD daemon, which must be
-#       running while rippled is running. More information on StatsD is
+#       running while xrpld is running. More information on StatsD is
 #       available here:
 #           https://github.com/b/statsd_spec
 #
@@ -1209,7 +1209,7 @@
 #                 in the format, n.n.n.n:port.
 #
 #       "prefix"  A string prepended to each collected metric. This is used
-#                 to distinguish between different running instances of rippled.
+#                 to distinguish between different running instances of xrpld.
 #
 #     If this section is missing, or the server type is unspecified or unknown,
 #     statistics are not collected or reported.
@@ -1236,7 +1236,7 @@
 #
 #   Example:
 #     [perf]
-#     perf_log=/var/log/rippled/perf.log
+#     perf_log=/var/log/xrpld/perf.log
 #     log_interval=2
 #
 #-------------------------------------------------------------------------------
@@ -1246,7 +1246,7 @@
 #----------
 #
 #   The vote settings configure settings for the entire Ripple network.
-#   While a single instance of rippled cannot unilaterally enforce network-wide
+#   While a single instance of xrpld cannot unilaterally enforce network-wide
 #   settings, these choices become part of the instance's vote during the
 #   consensus process for each voting ledger.
 #
@@ -1260,7 +1260,7 @@
 #       The reference transaction is the simplest form of transaction.
 #       It represents an XRP payment between two parties.
 #
-#       If this parameter is unspecified, rippled will use an internal
+#       If this parameter is unspecified, xrpld will use an internal
 #       default. Don't change this without understanding the consequences.
 #
 #       Example:
@@ -1272,7 +1272,7 @@
 #       account's XRP balance that is at or below the reserve may only be
 #       spent on transaction fees, and not transferred out of the account.
 #
-#       If this parameter is unspecified, rippled will use an internal
+#       If this parameter is unspecified, xrpld will use an internal
 #       default. Don't change this without understanding the consequences.
 #
 #       Example:
@@ -1284,7 +1284,7 @@
 #       each ledger item owned by the account. Ledger items an account may
 #       own include trust lines, open orders, and tickets.
 #
-#       If this parameter is unspecified, rippled will use an internal
+#       If this parameter is unspecified, xrpld will use an internal
 #       default. Don't change this without understanding the consequences.
 #
 #       Example:
@@ -1326,7 +1326,7 @@
 #   tool instead.
 #
 #   This flag has no effect on the "sign" and "sign_for" command line options
-#   that rippled makes available.
+#   that xrpld makes available.
 #
 #   The default value of this field is "false"
 #
@@ -1405,7 +1405,7 @@
 #--------------------
 #
 #   Administrators can use these values as a starting point for configuring
-#   their instance of rippled, but each value should be checked to make sure
+#   their instance of xrpld, but each value should be checked to make sure
 #   it meets the business requirements for the organization.
 #
 # Server
@@ -1415,7 +1415,7 @@
 #   "peer"
 #
 #       Peer protocol open to everyone. This is required to accept
-#       incoming rippled connections. This does not affect automatic
+#       incoming xrpld connections. This does not affect automatic
 #       or manual outgoing Peer protocol connections.
 #
 #   "rpc"
@@ -1432,7 +1432,7 @@
 #
 #       ETL commands for Clio. We recommend setting secure_gateway
 #       in this section to a comma-separated list of the addresses
-#       of your Clio servers, in order to bypass rippled's rate limiting.
+#       of your Clio servers, in order to bypass xrpld's rate limiting.
 #
 #   This port is commented out but can be enabled by removing
 #   the '#' from each corresponding line including the entry under [server]
@@ -1449,8 +1449,8 @@
 #   NOTE
 #
 #       To accept connections on well known ports such as 80 (HTTP) or
-#       443 (HTTPS), most operating systems will require rippled to
-#       run with administrator privileges, or else rippled will not start.
+#       443 (HTTPS), most operating systems will require xrpld to
+#       run with administrator privileges, or else xrpld will not start.
 
 [server]
 port_rpc_admin_local
@@ -1496,7 +1496,7 @@ secure_gateway = 127.0.0.1
 
 #-------------------------------------------------------------------------------
 
-# This is primary persistent datastore for rippled.  This includes transaction
+# This is primary persistent datastore for xrpld.  This includes transaction
 # metadata, account states, and ledger headers.  Helpful information can be
 # found at https://xrpl.org/capacity-planning.html#node-db-type
 # type=NuDB is recommended for non-validators with fast SSDs. Validators or
@@ -1511,19 +1511,19 @@ secure_gateway = 127.0.0.1
 #    deletion.
 [node_db]
 type=NuDB
-path=/var/lib/rippled/db/nudb
+path=/var/lib/xrpld/db/nudb
 nudb_block_size=4096
 online_delete=512
 advisory_delete=0
 
 [database_path]
-/var/lib/rippled/db
+/var/lib/xrpld/db
 
 
 # This needs to be an absolute directory reference, not a relative one.
 # Modify this value as required.
 [debug_logfile]
-/var/log/rippled/debug.log
+/var/log/xrpld/debug.log
 
 # To use the XRP test network
 # (see https://xrpl.org/connect-your-rippled-to-the-xrp-test-net.html),
@@ -1533,7 +1533,7 @@ advisory_delete=0
 
 # File containing trusted validator keys or validator list publishers.
 # Unless an absolute path is specified, it will be considered relative to the
-# folder in which the rippled.cfg file is located.
+# folder in which the xrpld.cfg file is located.
 [validators_file]
 validators.txt
 

cmake/Ccache.cmake

@@ -0,0 +1,57 @@
+find_program(CCACHE_PATH "ccache")
+if (NOT CCACHE_PATH)
+    return()
+endif ()
+
+# For Linux and macOS we can use the ccache binary directly.
+if (NOT MSVC)
+    set(CMAKE_C_COMPILER_LAUNCHER "${CCACHE_PATH}")
+    set(CMAKE_CXX_COMPILER_LAUNCHER "${CCACHE_PATH}")
+    message(STATUS "Found ccache: ${CCACHE_PATH}")
+    return()
+endif ()
+
+# For Windows more effort is required. The code below is a modified version of
+# https://github.com/ccache/ccache/wiki/MS-Visual-Studio#usage-with-cmake.
+if ("${CCACHE_PATH}" MATCHES "chocolatey")
+    message(DEBUG "Ccache path: ${CCACHE_PATH}")
+    # Chocolatey uses a shim executable that we cannot use directly, in which
+    # case we have to find the executable it points to. If we cannot find the
+    # target executable then we cannot use ccache.
+    find_program(BASH_PATH "bash")
+    if (NOT BASH_PATH)
+        message(WARNING "Could not find bash.")
+        return()
+    endif ()
+
+    execute_process(
+            COMMAND bash -c "export LC_ALL='en_US.UTF-8'; ${CCACHE_PATH} --shimgen-noop | grep -oP 'path to executable: \\K.+' | head -c -1"
+            OUTPUT_VARIABLE CCACHE_PATH)
+
+    if (NOT CCACHE_PATH)
+        message(WARNING "Could not find ccache target.")
+        return()
+    endif ()
+    file(TO_CMAKE_PATH "${CCACHE_PATH}" CCACHE_PATH)
+endif ()
+message(STATUS "Found ccache: ${CCACHE_PATH}")
+
+# Tell cmake to use ccache for compiling with Visual Studio.
+file(COPY_FILE
+        ${CCACHE_PATH} ${CMAKE_BINARY_DIR}/cl.exe
+        ONLY_IF_DIFFERENT)
+set(CMAKE_VS_GLOBALS
+        "CLToolExe=cl.exe"
+        "CLToolPath=${CMAKE_BINARY_DIR}"
+        "TrackFileAccess=false"
+        "UseMultiToolTask=true")
+
+# By default Visual Studio generators will use /Zi to capture debug information,
+# which is not compatible with ccache, so tell it to use /Z7 instead.
+if (MSVC)
+    foreach (var_
+        CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_RELEASE
+        CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE)
+        string (REPLACE "/Zi" "/Z7" ${var_} "${${var_}}")
+    endforeach ()
+endif ()

cmake/XrplCompiler.cmake

@@ -44,6 +44,7 @@ if (MSVC)
     # omit debug info completely under CI (not needed)
     if (is_ci)
       string (REPLACE "/Zi" " " ${var_} "${${var_}}")
+      string (REPLACE "/Z7" " " ${var_} "${${var_}}")
     endif ()
   endforeach ()
 
@@ -149,7 +150,7 @@ elseif (use_gold AND is_gcc)
     ERROR_QUIET OUTPUT_VARIABLE LD_VERSION)
     #[=========================================================[
        NOTE: THE gold linker inserts -rpath as DT_RUNPATH by
-       default intead of DT_RPATH, so you might have slightly
+       default instead of DT_RPATH, so you might have slightly
        unexpected runtime ld behavior if you were expecting
        DT_RPATH.  Specify --disable-new-dtags to gold if you do
        not want the default DT_RUNPATH behavior. This rpath

cmake/XrplCore.cmake

@@ -206,7 +206,7 @@ if(xrpld)
   )
   exclude_if_included(xrpld)
   # define a macro for tests that might need to
-  # be exluded or run differently in CI environment
+  # be excluded or run differently in CI environment
   if(is_ci)
     target_compile_definitions(xrpld PRIVATE XRPL_RUNNING_IN_CI)
   endif ()

cmake/XrplInstall.cmake

@@ -62,7 +62,7 @@ if (is_root_project AND TARGET xrpld)
         message (\"-- Skipping : \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/\${DEST}/\${NEWNAME}\")
       endif ()
     endmacro()
-    copy_if_not_exists(\"${CMAKE_CURRENT_SOURCE_DIR}/cfg/rippled-example.cfg\" etc rippled.cfg)
+    copy_if_not_exists(\"${CMAKE_CURRENT_SOURCE_DIR}/cfg/xrpld-example.cfg\" etc xrpld.cfg)
     copy_if_not_exists(\"${CMAKE_CURRENT_SOURCE_DIR}/cfg/validators-example.txt\" etc validators.txt)
   ")
   install(CODE "

cmake/XrplSettings.cmake

@@ -68,6 +68,21 @@ if(is_linux)
   option(perf "Enables flags that assist with perf recording" OFF)
   option(use_gold "enables detection of gold (binutils) linker" ON)
   option(use_mold "enables detection of mold (binutils) linker" ON)
+  # Set a default value for the log flag based on the build type.
+  # This provides a sensible default (on for debug, off for release)
+  # while still allowing the user to override it for any build.
+  if(CMAKE_BUILD_TYPE STREQUAL "Debug")
+    set(TRUNCATED_LOGS_DEFAULT ON)
+  else()
+    set(TRUNCATED_LOGS_DEFAULT OFF)
+  endif()
+  option(TRUNCATED_THREAD_NAME_LOGS
+    "Show warnings about truncated thread names on Linux."
+    ${TRUNCATED_LOGS_DEFAULT}
+  )
+  if(TRUNCATED_THREAD_NAME_LOGS)
+    add_compile_definitions(TRUNCATED_THREAD_NAME_LOGS)
+  endif()
 else()
   # we are not ready to allow shared-libs on windows because it would require
   # export declarations. On macos it's more feasible, but static openssl

conanfile.py

@@ -182,12 +182,10 @@ class Xrpl(ConanFile):
         libxrpl.libs = [
             "xrpl",
             "xrpl.libpb",
-            "ed25519",
-            "secp256k1",
         ]
         # TODO: Fix the protobufs to include each other relative to
-        # `include/`, not `include/ripple/proto/`.
-        libxrpl.includedirs = ["include", "include/ripple/proto"]
+        # `include/`, not `include/xrpl/proto/`.
+        libxrpl.includedirs = ["include", "include/xrpl/proto"]
         libxrpl.requires = [
             "boost::headers",
             "boost::chrono",

docs/0001-negative-unl/README.md

@@ -134,7 +134,7 @@ validation messages (_PAV_) received from each validator on the node's UNL. Note
 that the node will only count the validation messages that agree with its own
 validations.
 
-We define the **PAV** as the **P**ercentage of **A**greed **V**alidation
+We define the **PAV** as the Percentage of Agreed Validation
 messages received for the last N ledgers, where N = 256 by default.
 
 When the PAV drops below the **_low-water mark_**, the validator is considered

docs/0001-negative-unl/negativeUNLSqDiagram.puml

@@ -43,14 +43,14 @@ alt phase == OPEN
             alt sqn%256==0
             CA -[#green]> RM: <font color=green>getValidations
             CA -[#green]> CA: <font color=green>create UNLModify Tx
-            hnote over CA#lightgreen: use validatations of the last 256 ledgers\nto figure out UNLModify Tx candidates.\nIf any, create UNLModify Tx, and add to TxSet.
+            hnote over CA#lightgreen: use validations of the last 256 ledgers\nto figure out UNLModify Tx candidates.\nIf any, create UNLModify Tx, and add to TxSet.
             end
         CA -> GC
         GC -> CA: propose
         deactivate CA
     end
 else phase == ESTABLISH
-    hnote over GC: receive peer postions
+    hnote over GC: receive peer positions
     GC -> GC : update our position
     GC -> CA : propose \n(if position changed)
     GC -> GC : check if have consensus

docs/consensus.md

@@ -189,7 +189,7 @@ validations. It checks this on every call to `timerEntry`.
 - _Wrong Ledger_ indicates the node is not working on the correct prior ledger
   and does not have it available. It requests that ledger from the network, but
   continues to work towards consensus this round while waiting. If it had been
-  _proposing_, it will send a special "bowout" proposal to its peers to indicate
+  _proposing_, it will send a special "bow-out" proposal to its peers to indicate
   its change in mode for the rest of this round. For the duration of the round,
   it defers to peer positions for determining the consensus outcome as if it
   were just _observing_.
@@ -515,7 +515,7 @@ are excerpts of the generic consensus implementation and of helper types that wi
 interact with the concrete implementing class.
 
 ```{.cpp}
-// Represents a transction under dispute this round
+// Represents a transaction under dispute this round
 template <class Tx_t, class NodeID_t> class DisputedTx;
 
 // Represents how the node participates in Consensus this round

include/xrpl/basics/CanProcess.h

@@ -0,0 +1,139 @@
+//------------------------------------------------------------------------------
+/*
+    This file is part of rippled: https://github.com/ripple/rippled
+    Copyright (c) 2024 Ripple Labs Inc.
+
+    Permission to use, copy, modify, and/or distribute this software for any
+    purpose  with  or without fee is hereby granted, provided that the above
+    copyright notice and this permission notice appear in all copies.
+
+    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+    ANY  SPECIAL ,  DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+//==============================================================================
+
+#ifndef RIPPLE_BASICS_CANPROCESS_H_INCLUDED
+#define RIPPLE_BASICS_CANPROCESS_H_INCLUDED
+
+#include <functional>
+#include <mutex>
+#include <set>
+
+/** RAII class to check if an Item is already being processed on another thread,
+ * as indicated by it's presence in a Collection.
+ *
+ * If the Item is not in the Collection, it will be added under lock in the
+ * ctor, and removed under lock in the dtor. The object will be considered
+ * "usable" and evaluate to `true`.
+ *
+ * If the Item is in the Collection, no changes will be made to the collection,
+ * and the CanProcess object will be considered "unusable".
+ *
+ * It's up to the caller to decide what "usable" and "unusable" mean. (e.g.
+ * Process or skip a block of code, or set a flag.)
+ *
+ * The current use is to avoid lock contention that would be involved in
+ * processing something associated with the Item.
+ *
+ * Examples:
+ *
+ * void IncomingLedgers::acquireAsync(LedgerHash const& hash, ...)
+ * {
+ *    if (CanProcess check{acquiresMutex_, pendingAcquires_, hash})
+ *    {
+ *      acquire(hash, ...);
+ *    }
+ * }
+ *
+ * bool
+ * NetworkOPsImp::recvValidation(
+ *   std::shared_ptr<STValidation> const& val,
+ *   std::string const& source)
+ *   {
+ *       CanProcess check(
+ *           validationsMutex_, pendingValidations_, val->getLedgerHash());
+ *       BypassAccept bypassAccept =
+ *           check ? BypassAccept::no : BypassAccept::yes;
+ *       handleNewValidation(app_, val, source, bypassAccept, m_journal);
+ *   }
+ *
+ */
+class CanProcess
+{
+public:
+    template <class Mutex, class Collection, class Item>
+    CanProcess(Mutex& mtx, Collection& collection, Item const& item)
+        : cleanup_(insert(mtx, collection, item))
+    {
+    }
+
+    ~CanProcess()
+    {
+        if (cleanup_)
+            cleanup_();
+    }
+
+    CanProcess(CanProcess const&) = delete;
+
+    CanProcess&
+    operator=(CanProcess const&) = delete;
+
+    explicit
+    operator bool() const
+    {
+        return static_cast<bool>(cleanup_);
+    }
+
+private:
+    template <bool useIterator, class Mutex, class Collection, class Item>
+    std::function<void()>
+    doInsert(Mutex& mtx, Collection& collection, Item const& item)
+    {
+        std::unique_lock<Mutex> lock(mtx);
+        // TODO: Use structured binding once LLVM 16 is the minimum supported
+        // version. See also: https://github.com/llvm/llvm-project/issues/48582
+        // https://github.com/llvm/llvm-project/commit/127bf44385424891eb04cff8e52d3f157fc2cb7c
+        auto const insertResult = collection.insert(item);
+        auto const it = insertResult.first;
+        if (!insertResult.second)
+            return {};
+        if constexpr (useIterator)
+            return [&, it]() {
+                std::unique_lock<Mutex> lock(mtx);
+                collection.erase(it);
+            };
+        else
+            return [&]() {
+                std::unique_lock<Mutex> lock(mtx);
+                collection.erase(item);
+            };
+    }
+
+    // Generic insert() function doesn't use iterators because they may get
+    // invalidated
+    template <class Mutex, class Collection, class Item>
+    std::function<void()>
+    insert(Mutex& mtx, Collection& collection, Item const& item)
+    {
+        return doInsert<false>(mtx, collection, item);
+    }
+
+    // Specialize insert() for std::set, which does not invalidate iterators for
+    // insert and erase
+    template <class Mutex, class Item>
+    std::function<void()>
+    insert(Mutex& mtx, std::set<Item>& collection, Item const& item)
+    {
+        return doInsert<true>(mtx, collection, item);
+    }
+
+    // If set, then the item is "usable"
+    std::function<void()> cleanup_;
+};
+
+#endif

include/xrpl/basics/IntrusivePointer.h

@@ -58,7 +58,7 @@ concept CAdoptTag = std::is_same_v<T, SharedIntrusiveAdoptIncrementStrongTag> ||
     When the strong pointer count goes to zero, the "partialDestructor" is
     called. This can be used to destroy as much of the object as possible while
     still retaining the reference counts. For example, for SHAMapInnerNodes the
-    children may be reset in that function. Note that std::shared_poiner WILL
+    children may be reset in that function. Note that std::shared_pointer WILL
     run the destructor when the strong count reaches zero, but may not free the
     memory used by the object until the weak count reaches zero. In rippled, we
     typically allocate shared pointers with the `make_shared` function. When

include/xrpl/basics/IntrusiveRefCounts.h

@@ -301,7 +301,7 @@ IntrusiveRefCounts::addWeakReleaseStrongRef() const
     // change the counts and flags (the count could be atomically changed, but
     // the flags depend on the current value of the counts).
     //
-    // Note: If this becomes a perf bottleneck, the `partialDestoryStartedMask`
+    // Note: If this becomes a perf bottleneck, the `partialDestroyStartedMask`
     // may be able to be set non-atomically. But it is easier to reason about
     // the code if the flag is set atomically.
     while (1)

include/xrpl/basics/Log.h

@@ -221,7 +221,8 @@ public:
 private:
     enum {
         // Maximum line length for log messages.
-        // If the message exceeds this length it will be truncated with elipses.
+        // If the message exceeds this length it will be truncated with
+        // ellipses.
         maximumMessageCharacters = 12 * 1024
     };
 

include/xrpl/basics/Slice.h

@@ -152,8 +152,8 @@ public:
 
     /** Return a "sub slice" of given length starting at the given position
 
-        Note that the subslice encompasses the range [pos, pos + rcount),
-        where rcount is the smaller of count and size() - pos.
+        Note that the subslice encompasses the range [pos, pos + rCount),
+        where rCount is the smaller of count and size() - pos.
 
         @param pos position of the first character
         @count requested length

include/xrpl/basics/StringUtilities.h

@@ -31,7 +31,7 @@ template <class Iterator>
 std::optional<Blob>
 strUnHex(std::size_t strSize, Iterator begin, Iterator end)
 {
-    static constexpr std::array<int, 256> const unxtab = []() {
+    static constexpr std::array<int, 256> const digitLookupTable = []() {
         std::array<int, 256> t{};
 
         for (auto& x : t)
@@ -57,7 +57,7 @@ strUnHex(std::size_t strSize, Iterator begin, Iterator end)
 
     if (strSize & 1)
     {
-        int c = unxtab[*iter++];
+        int c = digitLookupTable[*iter++];
 
         if (c < 0)
             return {};
@@ -67,12 +67,12 @@ strUnHex(std::size_t strSize, Iterator begin, Iterator end)
 
     while (iter != end)
     {
-        int cHigh = unxtab[*iter++];
+        int cHigh = digitLookupTable[*iter++];
 
         if (cHigh < 0)
             return {};
 
-        int cLow = unxtab[*iter++];
+        int cLow = digitLookupTable[*iter++];
 
         if (cLow < 0)
             return {};

include/xrpl/beast/container/detail/aged_unordered_container.h

@@ -3189,11 +3189,12 @@ operator==(aged_unordered_container<
 {
     if (size() != other.size())
         return false;
-    for (auto iter(cbegin()), last(cend()), olast(other.cend()); iter != last;
+    for (auto iter(cbegin()), last(cend()), otherLast(other.cend());
+         iter != last;
          ++iter)
     {
-        auto oiter(other.find(extract(*iter)));
-        if (oiter == olast)
+        auto otherIter(other.find(extract(*iter)));
+        if (otherIter == otherLast)
             return false;
     }
     return true;

include/xrpl/beast/core/CurrentThreadName.h

@@ -5,6 +5,8 @@
 #ifndef BEAST_CORE_CURRENT_THREAD_NAME_H_INCLUDED
 #define BEAST_CORE_CURRENT_THREAD_NAME_H_INCLUDED
 
+#include <boost/predef.h>
+
 #include <string>
 #include <string_view>
 
@@ -16,6 +18,31 @@ namespace beast {
 void
 setCurrentThreadName(std::string_view newThreadName);
 
+#if BOOST_OS_LINUX
+
+// On Linux, thread names are limited to 16 bytes including the null terminator.
+// Maximum number of characters is therefore 15.
+constexpr std::size_t maxThreadNameLength = 15;
+
+/** Sets the name of the caller thread with compile-time size checking.
+    @tparam N The size of the string literal including null terminator
+    @param newThreadName A string literal to set as the thread name
+
+    This template overload enforces that thread names are at most 16 characters
+    (including null terminator) at compile time, matching Linux's limit.
+*/
+template <std::size_t N>
+void
+setCurrentThreadName(char const (&newThreadName)[N])
+{
+    static_assert(
+        N <= maxThreadNameLength + 1,
+        "Thread name cannot exceed 15 characters");
+
+    setCurrentThreadName(std::string_view(newThreadName, N - 1));
+}
+#endif
+
 /** Returns the name of the caller thread.
 
     The name returned is the name as set by a call to setCurrentThreadName().

include/xrpl/beast/core/LexicalCast.h

@@ -18,7 +18,7 @@ namespace beast {
 
 namespace detail {
 
-// These specializatons get called by the non-member functions to do the work
+// These specializations get called by the non-member functions to do the work
 template <class Out, class In>
 struct LexicalCast;
 

include/xrpl/beast/hash/hash_append.h

@@ -203,7 +203,7 @@ struct is_contiguously_hashable<T[N], HashAlgorithm>
         Throws:
             Never
         Effect:
-            Returns the reslting hash of all the input data.
+            Returns the resulting hash of all the input data.
 */
 /** @{ */
 

include/xrpl/beast/utility/PropertyStream.h

@@ -376,7 +376,7 @@ public:
         print statement examples
         "parent.child" prints child and all of its children
         "parent.child." start at the parent and print down to child
-        "parent.grandchild" prints nothing- grandchild not direct discendent
+        "parent.grandchild" prints nothing- grandchild not direct descendent
         "parent.grandchild." starts at the parent and prints down to grandchild
         "parent.grandchild.*" starts at parent, print through grandchild
        children

include/xrpl/core/PerfLog.h

@@ -40,7 +40,7 @@ public:
     using microseconds = std::chrono::microseconds;
 
     /**
-     * Configuration from [perf] section of rippled.cfg.
+     * Configuration from [perf] section of xrpld.cfg.
      */
     struct Setup
     {

include/xrpl/json/Object.h

@@ -1,445 +0,0 @@
-#ifndef XRPL_JSON_OBJECT_H_INCLUDED
-#define XRPL_JSON_OBJECT_H_INCLUDED
-
-#include <xrpl/json/Writer.h>
-
-#include <memory>
-
-namespace Json {
-
-/**
-    Collection is a base class for Array and Object, classes which provide the
-    facade of JSON collections for the O(1) JSON writer, while still using no
-    heap memory and only a very small amount of stack.
-
-    From http://json.org, JSON has two types of collection: array, and object.
-    Everything else is a *scalar* - a number, a string, a boolean, the special
-    value null, or a legacy Json::Value.
-
-    Collections must write JSON "as-it-goes" in order to get the strong
-    performance guarantees.  This puts restrictions upon API users:
-
-    1. Only one collection can be open for change at any one time.
-
-       This condition is enforced automatically and a std::logic_error thrown if
-   it is violated.
-
-    2. A tag may only be used once in an Object.
-
-       Some objects have many tags, so this condition might be a little
-       expensive. Enforcement of this condition is turned on in debug builds and
-       a std::logic_error is thrown when the tag is added for a second time.
-
-    Code samples:
-
-        Writer writer;
-
-        // An empty object.
-        {
-            Object::Root (writer);
-        }
-        // Outputs {}
-
-        // An object with one scalar value.
-        {
-            Object::Root root (writer);
-            write["hello"] = "world";
-        }
-        // Outputs {"hello":"world"}
-
-        // Same, using chaining.
-        {
-            Object::Root (writer)["hello"] = "world";
-        }
-        // Output is the same.
-
-        // Add several scalars, with chaining.
-        {
-            Object::Root (writer)
-                .set ("hello", "world")
-                .set ("flag", false)
-                .set ("x", 42);
-        }
-        // Outputs {"hello":"world","flag":false,"x":42}
-
-        // Add an array.
-        {
-            Object::Root root (writer);
-            {
-               auto array = root.setArray ("hands");
-               array.append ("left");
-               array.append ("right");
-            }
-        }
-        // Outputs {"hands":["left", "right"]}
-
-        // Same, using chaining.
-        {
-            Object::Root (writer)
-                .setArray ("hands")
-                .append ("left")
-                .append ("right");
-        }
-        // Output is the same.
-
-        // Add an object.
-        {
-            Object::Root root (writer);
-            {
-               auto object = root.setObject ("hands");
-               object["left"] = false;
-               object["right"] = true;
-            }
-        }
-        // Outputs {"hands":{"left":false,"right":true}}
-
-        // Same, using chaining.
-        {
-            Object::Root (writer)
-                .setObject ("hands")
-                .set ("left", false)
-                .set ("right", true);
-            }
-        }
-        // Outputs {"hands":{"left":false,"right":true}}
-
-
-   Typical ways to make mistakes and get a std::logic_error:
-
-        Writer writer;
-        Object::Root root (writer);
-
-        // Repeat a tag.
-        {
-            root ["hello"] = "world";
-            root ["hello"] = "there";  // THROWS! in a debug build.
-        }
-
-        // Open a subcollection, then set something else.
-        {
-            auto object = root.setObject ("foo");
-            root ["hello"] = "world";  // THROWS!
-        }
-
-        // Open two subcollections at a time.
-        {
-            auto object = root.setObject ("foo");
-            auto array = root.setArray ("bar");  // THROWS!!
-        }
-
-   For more examples, check the unit tests.
- */
-
-class Collection
-{
-public:
-    Collection(Collection&& c) noexcept;
-    Collection&
-    operator=(Collection&& c) noexcept;
-    Collection() = delete;
-
-    ~Collection();
-
-protected:
-    // A null parent means "no parent at all".
-    // Writers cannot be null.
-    Collection(Collection* parent, Writer*);
-    void
-    checkWritable(std::string const& label);
-
-    Collection* parent_;
-    Writer* writer_;
-    bool enabled_;
-};
-
-class Array;
-
-//------------------------------------------------------------------------------
-
-/** Represents a JSON object being written to a Writer. */
-class Object : protected Collection
-{
-public:
-    /** Object::Root is the only Collection that has a public constructor. */
-    class Root;
-
-    /** Set a scalar value in the Object for a key.
-
-        A JSON scalar is a single value - a number, string, boolean, nullptr or
-        a Json::Value.
-
-        `set()` throws an exception if this object is disabled (which means that
-        one of its children is enabled).
-
-        In a debug build, `set()` also throws an exception if the key has
-        already been set() before.
-
-        An operator[] is provided to allow writing `object["key"] = scalar;`.
-     */
-    template <typename Scalar>
-    void
-    set(std::string const& key, Scalar const&);
-
-    void
-    set(std::string const& key, Json::Value const&);
-
-    // Detail class and method used to implement operator[].
-    class Proxy;
-
-    Proxy
-    operator[](std::string const& key);
-    Proxy
-    operator[](Json::StaticString const& key);
-
-    /** Make a new Object at a key and return it.
-
-        This Object is disabled until that sub-object is destroyed.
-        Throws an exception if this Object was already disabled.
-     */
-    Object
-    setObject(std::string const& key);
-
-    /** Make a new Array at a key and return it.
-
-        This Object is disabled until that sub-array is destroyed.
-        Throws an exception if this Object was already disabled.
-     */
-    Array
-    setArray(std::string const& key);
-
-protected:
-    friend class Array;
-    Object(Collection* parent, Writer* w) : Collection(parent, w)
-    {
-    }
-};
-
-class Object::Root : public Object
-{
-public:
-    /** Each Object::Root must be constructed with its own unique Writer. */
-    Root(Writer&);
-};
-
-//------------------------------------------------------------------------------
-
-/** Represents a JSON array being written to a Writer. */
-class Array : private Collection
-{
-public:
-    /** Append a scalar to the Arrary.
-
-        Throws an exception if this array is disabled (which means that one of
-        its sub-collections is enabled).
-    */
-    template <typename Scalar>
-    void
-    append(Scalar const&);
-
-    /**
-       Appends a Json::Value to an array.
-       Throws an exception if this Array was disabled.
-     */
-    void
-    append(Json::Value const&);
-
-    /** Append a new Object and return it.
-
-        This Array is disabled until that sub-object is destroyed.
-        Throws an exception if this Array was disabled.
-     */
-    Object
-    appendObject();
-
-    /** Append a new Array and return it.
-
-        This Array is disabled until that sub-array is destroyed.
-        Throws an exception if this Array was already disabled.
-     */
-    Array
-    appendArray();
-
-protected:
-    friend class Object;
-    Array(Collection* parent, Writer* w) : Collection(parent, w)
-    {
-    }
-};
-
-//------------------------------------------------------------------------------
-
-// Generic accessor functions to allow Json::Value and Collection to
-// interoperate.
-
-/** Add a new subarray at a named key in a Json object. */
-Json::Value&
-setArray(Json::Value&, Json::StaticString const& key);
-
-/** Add a new subarray at a named key in a Json object. */
-Array
-setArray(Object&, Json::StaticString const& key);
-
-/** Add a new subobject at a named key in a Json object. */
-Json::Value&
-addObject(Json::Value&, Json::StaticString const& key);
-
-/** Add a new subobject at a named key in a Json object. */
-Object
-addObject(Object&, Json::StaticString const& key);
-
-/** Append a new subarray to a Json array. */
-Json::Value&
-appendArray(Json::Value&);
-
-/** Append a new subarray to a Json array. */
-Array
-appendArray(Array&);
-
-/** Append a new subobject to a Json object. */
-Json::Value&
-appendObject(Json::Value&);
-
-/** Append a new subobject to a Json object. */
-Object
-appendObject(Array&);
-
-/** Copy all the keys and values from one object into another. */
-void
-copyFrom(Json::Value& to, Json::Value const& from);
-
-/** Copy all the keys and values from one object into another. */
-void
-copyFrom(Object& to, Json::Value const& from);
-
-/** An Object that contains its own Writer. */
-class WriterObject
-{
-public:
-    WriterObject(Output const& output)
-        : writer_(std::make_unique<Writer>(output))
-        , object_(std::make_unique<Object::Root>(*writer_))
-    {
-    }
-
-    WriterObject(WriterObject&& other) = default;
-
-    Object*
-    operator->()
-    {
-        return object_.get();
-    }
-
-    Object&
-    operator*()
-    {
-        return *object_;
-    }
-
-private:
-    std::unique_ptr<Writer> writer_;
-    std::unique_ptr<Object::Root> object_;
-};
-
-WriterObject
-stringWriterObject(std::string&);
-
-//------------------------------------------------------------------------------
-// Implementation details.
-
-// Detail class for Object::operator[].
-class Object::Proxy
-{
-private:
-    Object& object_;
-    std::string const key_;
-
-public:
-    Proxy(Object& object, std::string const& key);
-
-    template <class T>
-    void
-    operator=(T const& t)
-    {
-        object_.set(key_, t);
-        // Note: This function shouldn't return *this, because it's a trap.
-        //
-        // In Json::Value, foo[jss::key] returns a reference to a
-        // mutable Json::Value contained _inside_ foo.  But in the case of
-        // Json::Object, where we write once only, there isn't any such
-        // reference that can be returned.  Returning *this would return an
-        // object "a level higher" than in Json::Value, leading to obscure bugs,
-        // particularly in generic code.
-    }
-};
-
-//------------------------------------------------------------------------------
-
-template <typename Scalar>
-void
-Array::append(Scalar const& value)
-{
-    checkWritable("append");
-    if (writer_)
-        writer_->append(value);
-}
-
-template <typename Scalar>
-void
-Object::set(std::string const& key, Scalar const& value)
-{
-    checkWritable("set");
-    if (writer_)
-        writer_->set(key, value);
-}
-
-inline Json::Value&
-setArray(Json::Value& json, Json::StaticString const& key)
-{
-    return (json[key] = Json::arrayValue);
-}
-
-inline Array
-setArray(Object& json, Json::StaticString const& key)
-{
-    return json.setArray(std::string(key));
-}
-
-inline Json::Value&
-addObject(Json::Value& json, Json::StaticString const& key)
-{
-    return (json[key] = Json::objectValue);
-}
-
-inline Object
-addObject(Object& object, Json::StaticString const& key)
-{
-    return object.setObject(std::string(key));
-}
-
-inline Json::Value&
-appendArray(Json::Value& json)
-{
-    return json.append(Json::arrayValue);
-}
-
-inline Array
-appendArray(Array& json)
-{
-    return json.appendArray();
-}
-
-inline Json::Value&
-appendObject(Json::Value& json)
-{
-    return json.append(Json::objectValue);
-}
-
-inline Object
-appendObject(Array& json)
-{
-    return json.appendObject();
-}
-
-}  // namespace Json
-
-#endif

include/xrpl/json/json_reader.h

@@ -1,8 +1,6 @@
 #ifndef XRPL_JSON_JSON_READER_H_INCLUDED
 #define XRPL_JSON_JSON_READER_H_INCLUDED
 
-#define CPPTL_JSON_READER_H_INCLUDED
-
 #include <xrpl/json/json_forwards.h>
 #include <xrpl/json/json_value.h>
 
@@ -68,7 +66,7 @@ public:
      * error occurred during parsing.
      */
     std::string
-    getFormatedErrorMessages() const;
+    getFormattedErrorMessages() const;
 
     static constexpr unsigned nest_limit{25};
 
@@ -231,4 +229,4 @@ operator>>(std::istream&, Value&);
 
 }  // namespace Json
 
-#endif  // CPPTL_JSON_READER_H_INCLUDED
+#endif  // XRPL_JSON_JSON_READER_H_INCLUDED

include/xrpl/json/json_value.h

@@ -44,7 +44,7 @@ enum ValueType {
 class StaticString
 {
 public:
-    constexpr explicit StaticString(char const* czstring) : str_(czstring)
+    constexpr explicit StaticString(char const* czString) : str_(czString)
     {
     }
 
@@ -682,4 +682,4 @@ public:
 
 }  // namespace Json
 
-#endif  // CPPTL_JSON_H_INCLUDED
+#endif  // XRPL_JSON_JSON_VALUE_H_INCLUDED

include/xrpl/json/json_writer.h

@@ -90,7 +90,7 @@ private:
     void
     writeArrayValue(Value const& value);
     bool
-    isMultineArray(Value const& value);
+    isMultilineArray(Value const& value);
     void
     pushValue(std::string const& value);
     void
@@ -157,7 +157,7 @@ private:
     void
     writeArrayValue(Value const& value);
     bool
-    isMultineArray(Value const& value);
+    isMultilineArray(Value const& value);
     void
     pushValue(std::string const& value);
     void

include/xrpl/ledger/CredentialHelpers.h

@@ -15,7 +15,7 @@ namespace xrpl {
 namespace credentials {
 
 // These function will be used by the code that use DepositPreauth / Credentials
-// (and any future preauthorization modes) as part of authorization (all the
+// (and any future pre-authorization modes) as part of authorization (all the
 // transfer funds transactions)
 
 // Check if credential sfExpiration field has passed ledger's parentCloseTime
@@ -41,7 +41,8 @@ checkFields(STTx const& tx, beast::Journal j);
 
 // Accessing the ledger to check if provided credentials are valid. Do not use
 // in doApply (only in preclaim) since it does not remove expired credentials.
-// If you call it in prelaim, you also must call verifyDepositPreauth in doApply
+// If you call it in preclaim, you also must call verifyDepositPreauth in
+// doApply
 TER
 valid(
     STTx const& tx,

include/xrpl/nodestore/DummyScheduler.h

@@ -6,7 +6,7 @@
 namespace xrpl {
 namespace NodeStore {
 
-/** Simple NodeStore Scheduler that just peforms the tasks synchronously. */
+/** Simple NodeStore Scheduler that just performs the tasks synchronously. */
 class DummyScheduler : public Scheduler
 {
 public:

include/xrpl/nodestore/Manager.h

@@ -55,7 +55,7 @@ public:
             HyperLevelDB, LevelDBFactory, SQLite, MDB
 
         If the fastBackendParameter is omitted or empty, no ephemeral database
-        is used. If the scheduler parameter is omited or unspecified, a
+        is used. If the scheduler parameter is omitted or unspecified, a
         synchronous scheduler is used which performs all tasks immediately on
         the caller's thread.
 

include/xrpl/nodestore/README.md

@@ -96,7 +96,7 @@ Facebook's RocksDB database, builds on LevelDB.
 
 Use SQLite.
 
-'path' speficies where the backend will store its data files.
+'path' specifies where the backend will store its data files.
 
 Choices for 'compression'
 
@@ -130,7 +130,7 @@ newer versions of RocksDB (TBD).
 ## Discussion
 
 RocksDBQuickFactory is intended to provide a testbed for comparing potential
-rocksdb performance with the existing recommended configuration in rippled.cfg.
+rocksdb performance with the existing recommended configuration in xrpld.cfg.
 Through various executions and profiling some conclusions are presented below.
 
 - If the write ahead log is enabled, insert speed soon clogs up under load. The
@@ -161,7 +161,7 @@ Through various executions and profiling some conclusions are presented below.
 
 - Multiple runs of the benchmarks can yield surprisingly different results. This
   can perhaps be attributed to the asynchronous nature of rocksdb's compaction
-  process. The benchmarks are artifical and create highly unlikely write load to
+  process. The benchmarks are artificial and create highly unlikely write load to
   create the dataset to measure different read access patterns. Therefore multiple
   runs of the benchmarks are required to get a feel for the effectiveness of the
   changes. This contrasts sharply with the keyvadb benchmarking were highly

include/xrpl/proto/org/xrpl/rpc/v1/xrp_ledger.proto

@@ -9,7 +9,7 @@ import "org/xrpl/rpc/v1/get_ledger_entry.proto";
 import "org/xrpl/rpc/v1/get_ledger_data.proto";
 import "org/xrpl/rpc/v1/get_ledger_diff.proto";
 
-// These methods are binary only methods for retrieiving arbitrary ledger state
+// These methods are binary only methods for retrieving arbitrary ledger state
 // via gRPC. These methods are used by clio, but can also be
 // used by any client that wants to extract ledger state in an efficient manner.
 // They do not directly mimic the JSON equivalent methods.

include/xrpl/proto/xrpl.proto

@@ -17,9 +17,9 @@ enum MessageType {
   mtHAVE_SET = 35;
   mtVALIDATION = 41;
   mtGET_OBJECTS = 42;
-  mtVALIDATORLIST = 54;
+  mtVALIDATOR_LIST = 54;
   mtSQUELCH = 55;
-  mtVALIDATORLISTCOLLECTION = 56;
+  mtVALIDATOR_LIST_COLLECTION = 56;
   mtPROOF_PATH_REQ = 57;
   mtPROOF_PATH_RESPONSE = 58;
   mtREPLAY_DELTA_REQ = 59;
@@ -308,7 +308,7 @@ message TMSquelch {
 }
 
 enum TMLedgerMapType {
-  lmTRANASCTION = 1;    // transaction map
+  lmTRANSACTION = 1;    // transaction map
   lmACCOUNT_STATE = 2;  // account state map
 }
 

include/xrpl/protocol/ApiVersion.h

@@ -58,14 +58,14 @@ static_assert(apiMaximumSupportedVersion >= apiMinimumSupportedVersion);
 static_assert(apiBetaVersion >= apiMaximumSupportedVersion);
 static_assert(apiMaximumValidVersion >= apiMaximumSupportedVersion);
 
-template <class JsonObject>
-void
-setVersion(JsonObject& parent, unsigned int apiVersion, bool betaEnabled)
+inline void
+setVersion(Json::Value& parent, unsigned int apiVersion, bool betaEnabled)
 {
     XRPL_ASSERT(
         apiVersion != apiInvalidVersion,
         "xrpl::RPC::setVersion : input is valid");
-    auto& retObj = addObject(parent, jss::version);
+
+    auto& retObj = parent[jss::version] = Json::objectValue;
 
     if (apiVersion == apiVersionIfUnspecified)
     {

include/xrpl/protocol/ErrorCodes.h

@@ -209,33 +209,11 @@ get_error_info(error_code_i code);
 
 /** Add or update the json update to reflect the error code. */
 /** @{ */
-template <class JsonValue>
 void
-inject_error(error_code_i code, JsonValue& json)
-{
-    ErrorInfo const& info(get_error_info(code));
-    json[jss::error] = info.token;
-    json[jss::error_code] = info.code;
-    json[jss::error_message] = info.message;
-}
+inject_error(error_code_i code, Json::Value& json);
 
-template <class JsonValue>
 void
-inject_error(int code, JsonValue& json)
-{
-    inject_error(error_code_i(code), json);
-}
-
-template <class JsonValue>
-void
-inject_error(error_code_i code, std::string const& message, JsonValue& json)
-{
-    ErrorInfo const& info(get_error_info(code));
-    json[jss::error] = info.token;
-    json[jss::error_code] = info.code;
-    json[jss::error_message] = message;
-}
-
+inject_error(error_code_i code, std::string const& message, Json::Value& json);
 /** @} */
 
 /** Returns a new json object that reflects the error code. */

include/xrpl/protocol/HashPrefix.h

@@ -67,9 +67,6 @@ enum class HashPrefix : std::uint32_t {
     /** Payment Channel Claim */
     paymentChannelClaim = detail::make_hash_prefix('C', 'L', 'M'),
 
-    /** Credentials signature */
-    credential = detail::make_hash_prefix('C', 'R', 'D'),
-
     /** Batch */
     batch = detail::make_hash_prefix('B', 'C', 'H'),
 };

include/xrpl/protocol/IOUAmount.h

@@ -20,7 +20,7 @@ namespace xrpl {
 
     Arithmetic operations can throw std::overflow_error during normalization
     if the amount exceeds the largest representable amount, but underflows
-    will silently trunctate to zero.
+    will silently truncate to zero.
 */
 class IOUAmount : private boost::totally_ordered<IOUAmount>,
                   private boost::additive<IOUAmount>

include/xrpl/protocol/Indexes.h

@@ -18,7 +18,7 @@
 namespace xrpl {
 
 class SeqProxy;
-/** Keylet computation funclets.
+/** Keylet computation functions.
 
     Entries in the ledger are located using 256-bit locators. The locators are
     calculated using a wide range of parameters specific to the entry whose

include/xrpl/protocol/LedgerHeader.h

@@ -36,6 +36,8 @@ struct LedgerHeader
 
     // If validated is false, it means "not yet validated."
     // Once validated is true, it will never be set false at a later time.
+    // NOTE: If you are accessing this directly, you are probably doing it
+    //   wrong. Use LedgerMaster::isValidated().
     // VFALCO TODO Make this not mutable
     bool mutable validated = false;
     bool accepted = false;

include/xrpl/protocol/Permissions.h

@@ -29,7 +29,7 @@ enum GranularPermissionType : std::uint32_t {
 #pragma pop_macro("PERMISSION")
 };
 
-enum Delegation { delegatable, notDelegatable };
+enum Delegation { delegable, notDelegable };
 
 class Permission
 {
@@ -38,7 +38,7 @@ private:
 
     std::unordered_map<std::uint16_t, uint256> txFeatureMap_;
 
-    std::unordered_map<std::uint16_t, Delegation> delegatableTx_;
+    std::unordered_map<std::uint16_t, Delegation> delegableTx_;
 
     std::unordered_map<std::string, GranularPermissionType>
         granularPermissionMap_;
@@ -71,8 +71,7 @@ public:
     getTxFeature(TxType txType) const;
 
     bool
-    isDelegatable(std::uint32_t const& permissionValue, Rules const& rules)
-        const;
+    isDelegable(std::uint32_t const& permissionValue, Rules const& rules) const;
 
     // for tx level permission, permission value is equal to tx type plus one
     uint32_t

include/xrpl/protocol/Protocol.h

@@ -179,7 +179,7 @@ static constexpr int loanPaymentsPerFeeIncrement = 5;
  *
  * This limit is enforced during the loan payment process, and thus is not
  * estimated. If the limit is hit, no further payments or overpayments will be
- * processed, no matter how much of the transation Amount is left, but the
+ * processed, no matter how much of the transaction Amount is left, but the
  * transaction will succeed with the payments that have been processed up to
  * that point.
  *

include/xrpl/protocol/Quality.h

@@ -210,7 +210,7 @@ public:
 
 private:
     // The ceil_in and ceil_out methods that deal in TAmount all convert
-    // their arguments to STAoumout and convert the result back to TAmount.
+    // their arguments to STAmount and convert the result back to TAmount.
     // This helper function takes care of all the conversion operations.
     template <
         class In,

include/xrpl/protocol/RPCErr.h

@@ -9,7 +9,7 @@ namespace xrpl {
 bool
 isRpcError(Json::Value jvResult);
 Json::Value
-rpcError(int iError);
+rpcError(error_code_i iError);
 
 }  // namespace xrpl
 

include/xrpl/protocol/TxFlags.h

@@ -277,7 +277,7 @@ constexpr std::uint32_t const tfLoanOverpayment = 0x00010000;
 // interest and fees, or it will fail. False: Not a full payment.
 constexpr std::uint32_t const tfLoanFullPayment = 0x00020000;
 // tfLoanLatePayment: True, indicates that the payment is late,
-// and includes late iterest and fees. If the loan is not late,
+// and includes late interest and fees. If the loan is not late,
 // it will fail. False: not a late payment. If the current payment
 // is overdue, the transaction will fail.
 constexpr std::uint32_t const tfLoanLatePayment = 0x00040000;

include/xrpl/protocol/XChainAttestations.h

@@ -33,12 +33,12 @@ struct AttestationBase
     // Account on the sending chain that triggered the event (sent the
     // transaction)
     AccountID sendingAccount;
-    // Amount transfered on the sending chain
+    // Amount transferred on the sending chain
     STAmount sendingAmount;
     // Account on the destination chain that collects a share of the attestation
     // reward
     AccountID rewardAccount;
-    // Amount was transfered on the locking chain
+    // Amount was transferred on the locking chain
     bool wasLockingChainSend;
 
     explicit AttestationBase(
@@ -354,7 +354,7 @@ struct XChainCreateAccountAttestation
         XChainCreateAccountAttestation const& rhs);
 };
 
-// Attestations from witness servers for a particular claimid and bridge.
+// Attestations from witness servers for a particular claim ID and bridge.
 // Only one attestation per signature is allowed.
 template <class TAttestation>
 class XChainAttestationsBase

include/xrpl/protocol/detail/STVar.h

@@ -42,7 +42,7 @@ concept ValidConstructSTArgs =
 class STVar
 {
 private:
-    // The largest "small object" we can accomodate
+    // The largest "small object" we can accommodate
     static std::size_t constexpr max_size = 72;
 
     std::aligned_storage<max_size>::type d_;

include/xrpl/protocol/detail/features.macro

@@ -16,6 +16,7 @@
 // Add new amendments to the top of this list.
 // Keep it sorted in reverse chronological order.
 
+XRPL_FIX    (BatchInnerSigs,             Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(LendingProtocol,            Supported::no,  VoteBehavior::DefaultNo)
 XRPL_FEATURE(PermissionDelegationV1_1,   Supported::no,  VoteBehavior::DefaultNo)
 XRPL_FIX    (DirectoryLimit,             Supported::yes, VoteBehavior::DefaultNo)

include/xrpl/protocol/detail/ledger_entries.macro

@@ -237,7 +237,7 @@ LEDGER_ENTRY(ltOFFER, 0x006f, Offer, offer, ({
     {sfAdditionalBooks,      soeOPTIONAL},
 }))
 
-/** A ledger object which describes a deposit preauthorization.
+/** A ledger object which describes a deposit pre-authorization.
 
     \sa keylet::depositPreauth
  */
@@ -577,7 +577,7 @@ LEDGER_ENTRY(ltLOAN, 0x0089, Loan, loan, ({
     // - TrueTotalLoanValue = PaymentRemaining * PeriodicPayment
     //   The unrounded true total value of the loan.
     //
-    // - TrueTotalPrincialOutstanding can be computed using the algorithm
+    // - TrueTotalPrincipalOutstanding can be computed using the algorithm
     //   in the ripple::detail::loanPrincipalFromPeriodicPayment function.
     //
     // - TrueTotalInterestOutstanding = TrueTotalLoanValue -

include/xrpl/protocol/detail/transactions.macro

@@ -3,7 +3,7 @@
 #endif
 
 /**
- * TRANSACTION(tag, value, name, delegatable, amendments, privileges, fields)
+ * TRANSACTION(tag, value, name, delegable, amendments, privileges, fields)
  *
  * To ease maintenance, you may replace any unneeded values with "..."
  * e.g. #define TRANSACTION(tag, value, name, ...)
@@ -25,7 +25,7 @@
 #   include <xrpld/app/tx/detail/Payment.h>
 #endif
 TRANSACTION(ttPAYMENT, 0, Payment,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     createAcct,
     ({
@@ -45,7 +45,7 @@ TRANSACTION(ttPAYMENT, 0, Payment,
 #   include <xrpld/app/tx/detail/Escrow.h>
 #endif
 TRANSACTION(ttESCROW_CREATE, 1, EscrowCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -59,7 +59,7 @@ TRANSACTION(ttESCROW_CREATE, 1, EscrowCreate,
 
 /** This transaction type completes an existing escrow. */
 TRANSACTION(ttESCROW_FINISH, 2, EscrowFinish,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -76,7 +76,7 @@ TRANSACTION(ttESCROW_FINISH, 2, EscrowFinish,
 #   include <xrpld/app/tx/detail/SetAccount.h>
 #endif
 TRANSACTION(ttACCOUNT_SET, 3, AccountSet,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     noPriv,
     ({
@@ -97,7 +97,7 @@ TRANSACTION(ttACCOUNT_SET, 3, AccountSet,
 #   include <xrpld/app/tx/detail/Escrow.h>
 #endif
 TRANSACTION(ttESCROW_CANCEL, 4, EscrowCancel,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -110,7 +110,7 @@ TRANSACTION(ttESCROW_CANCEL, 4, EscrowCancel,
 #   include <xrpld/app/tx/detail/SetRegularKey.h>
 #endif
 TRANSACTION(ttREGULAR_KEY_SET, 5, SetRegularKey,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     noPriv,
     ({
@@ -124,7 +124,7 @@ TRANSACTION(ttREGULAR_KEY_SET, 5, SetRegularKey,
 #   include <xrpld/app/tx/detail/CreateOffer.h>
 #endif
 TRANSACTION(ttOFFER_CREATE, 7, OfferCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -140,7 +140,7 @@ TRANSACTION(ttOFFER_CREATE, 7, OfferCreate,
 #   include <xrpld/app/tx/detail/CancelOffer.h>
 #endif
 TRANSACTION(ttOFFER_CANCEL, 8, OfferCancel,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -154,7 +154,7 @@ TRANSACTION(ttOFFER_CANCEL, 8, OfferCancel,
 #   include <xrpld/app/tx/detail/CreateTicket.h>
 #endif
 TRANSACTION(ttTICKET_CREATE, 10, TicketCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -170,7 +170,7 @@ TRANSACTION(ttTICKET_CREATE, 10, TicketCreate,
 #   include <xrpld/app/tx/detail/SetSignerList.h>
 #endif
 TRANSACTION(ttSIGNER_LIST_SET, 12, SignerListSet,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     noPriv,
     ({
@@ -183,7 +183,7 @@ TRANSACTION(ttSIGNER_LIST_SET, 12, SignerListSet,
 #   include <xrpld/app/tx/detail/PayChan.h>
 #endif
 TRANSACTION(ttPAYCHAN_CREATE, 13, PaymentChannelCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -197,7 +197,7 @@ TRANSACTION(ttPAYCHAN_CREATE, 13, PaymentChannelCreate,
 
 /** This transaction type funds an existing unidirectional XRP payment channel. */
 TRANSACTION(ttPAYCHAN_FUND, 14, PaymentChannelFund,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -208,7 +208,7 @@ TRANSACTION(ttPAYCHAN_FUND, 14, PaymentChannelFund,
 
 /** This transaction type submits a claim against an existing unidirectional payment channel. */
 TRANSACTION(ttPAYCHAN_CLAIM, 15, PaymentChannelClaim,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -225,7 +225,7 @@ TRANSACTION(ttPAYCHAN_CLAIM, 15, PaymentChannelClaim,
 #   include <xrpld/app/tx/detail/CreateCheck.h>
 #endif
 TRANSACTION(ttCHECK_CREATE, 16, CheckCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -241,7 +241,7 @@ TRANSACTION(ttCHECK_CREATE, 16, CheckCreate,
 #   include <xrpld/app/tx/detail/CashCheck.h>
 #endif
 TRANSACTION(ttCHECK_CASH, 17, CheckCash,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -255,7 +255,7 @@ TRANSACTION(ttCHECK_CASH, 17, CheckCash,
 #   include <xrpld/app/tx/detail/CancelCheck.h>
 #endif
 TRANSACTION(ttCHECK_CANCEL, 18, CheckCancel,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -267,7 +267,7 @@ TRANSACTION(ttCHECK_CANCEL, 18, CheckCancel,
 #   include <xrpld/app/tx/detail/DepositPreauth.h>
 #endif
 TRANSACTION(ttDEPOSIT_PREAUTH, 19, DepositPreauth,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -282,7 +282,7 @@ TRANSACTION(ttDEPOSIT_PREAUTH, 19, DepositPreauth,
 #   include <xrpld/app/tx/detail/SetTrust.h>
 #endif
 TRANSACTION(ttTRUST_SET, 20, TrustSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -296,7 +296,7 @@ TRANSACTION(ttTRUST_SET, 20, TrustSet,
 #   include <xrpld/app/tx/detail/DeleteAccount.h>
 #endif
 TRANSACTION(ttACCOUNT_DELETE, 21, AccountDelete,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     mustDeleteAcct,
     ({
@@ -312,7 +312,7 @@ TRANSACTION(ttACCOUNT_DELETE, 21, AccountDelete,
 #   include <xrpld/app/tx/detail/NFTokenMint.h>
 #endif
 TRANSACTION(ttNFTOKEN_MINT, 25, NFTokenMint,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     changeNFTCounts,
     ({
@@ -330,7 +330,7 @@ TRANSACTION(ttNFTOKEN_MINT, 25, NFTokenMint,
 #   include <xrpld/app/tx/detail/NFTokenBurn.h>
 #endif
 TRANSACTION(ttNFTOKEN_BURN, 26, NFTokenBurn,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     changeNFTCounts,
     ({
@@ -343,7 +343,7 @@ TRANSACTION(ttNFTOKEN_BURN, 26, NFTokenBurn,
 #   include <xrpld/app/tx/detail/NFTokenCreateOffer.h>
 #endif
 TRANSACTION(ttNFTOKEN_CREATE_OFFER, 27, NFTokenCreateOffer,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -359,7 +359,7 @@ TRANSACTION(ttNFTOKEN_CREATE_OFFER, 27, NFTokenCreateOffer,
 #   include <xrpld/app/tx/detail/NFTokenCancelOffer.h>
 #endif
 TRANSACTION(ttNFTOKEN_CANCEL_OFFER, 28, NFTokenCancelOffer,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -371,7 +371,7 @@ TRANSACTION(ttNFTOKEN_CANCEL_OFFER, 28, NFTokenCancelOffer,
 #   include <xrpld/app/tx/detail/NFTokenAcceptOffer.h>
 #endif
 TRANSACTION(ttNFTOKEN_ACCEPT_OFFER, 29, NFTokenAcceptOffer,
-    Delegation::delegatable,
+    Delegation::delegable,
     uint256{},
     noPriv,
     ({
@@ -385,7 +385,7 @@ TRANSACTION(ttNFTOKEN_ACCEPT_OFFER, 29, NFTokenAcceptOffer,
 #   include <xrpld/app/tx/detail/Clawback.h>
 #endif
 TRANSACTION(ttCLAWBACK, 30, Clawback,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureClawback,
     noPriv,
     ({
@@ -398,7 +398,7 @@ TRANSACTION(ttCLAWBACK, 30, Clawback,
 #   include <xrpld/app/tx/detail/AMMClawback.h>
 #endif
 TRANSACTION(ttAMM_CLAWBACK, 31, AMMClawback,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMMClawback,
     mayDeleteAcct | overrideFreeze,
     ({
@@ -413,7 +413,7 @@ TRANSACTION(ttAMM_CLAWBACK, 31, AMMClawback,
 #   include <xrpld/app/tx/detail/AMMCreate.h>
 #endif
 TRANSACTION(ttAMM_CREATE, 35, AMMCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMM,
     createPseudoAcct,
     ({
@@ -427,7 +427,7 @@ TRANSACTION(ttAMM_CREATE, 35, AMMCreate,
 #   include <xrpld/app/tx/detail/AMMDeposit.h>
 #endif
 TRANSACTION(ttAMM_DEPOSIT, 36, AMMDeposit,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMM,
     noPriv,
     ({
@@ -445,7 +445,7 @@ TRANSACTION(ttAMM_DEPOSIT, 36, AMMDeposit,
 #   include <xrpld/app/tx/detail/AMMWithdraw.h>
 #endif
 TRANSACTION(ttAMM_WITHDRAW, 37, AMMWithdraw,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMM,
     mayDeleteAcct,
     ({
@@ -462,7 +462,7 @@ TRANSACTION(ttAMM_WITHDRAW, 37, AMMWithdraw,
 #   include <xrpld/app/tx/detail/AMMVote.h>
 #endif
 TRANSACTION(ttAMM_VOTE, 38, AMMVote,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMM,
     noPriv,
     ({
@@ -476,7 +476,7 @@ TRANSACTION(ttAMM_VOTE, 38, AMMVote,
 #   include <xrpld/app/tx/detail/AMMBid.h>
 #endif
 TRANSACTION(ttAMM_BID, 39, AMMBid,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMM,
     noPriv,
     ({
@@ -492,7 +492,7 @@ TRANSACTION(ttAMM_BID, 39, AMMBid,
 #   include <xrpld/app/tx/detail/AMMDelete.h>
 #endif
 TRANSACTION(ttAMM_DELETE, 40, AMMDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureAMM,
     mustDeleteAcct,
     ({
@@ -505,7 +505,7 @@ TRANSACTION(ttAMM_DELETE, 40, AMMDelete,
 #   include <xrpld/app/tx/detail/XChainBridge.h>
 #endif
 TRANSACTION(ttXCHAIN_CREATE_CLAIM_ID, 41, XChainCreateClaimID,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     noPriv,
     ({
@@ -516,7 +516,7 @@ TRANSACTION(ttXCHAIN_CREATE_CLAIM_ID, 41, XChainCreateClaimID,
 
 /** This transactions initiates a crosschain transaction */
 TRANSACTION(ttXCHAIN_COMMIT, 42, XChainCommit,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     noPriv,
     ({
@@ -528,7 +528,7 @@ TRANSACTION(ttXCHAIN_COMMIT, 42, XChainCommit,
 
 /** This transaction completes a crosschain transaction */
 TRANSACTION(ttXCHAIN_CLAIM, 43, XChainClaim,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     noPriv,
     ({
@@ -541,7 +541,7 @@ TRANSACTION(ttXCHAIN_CLAIM, 43, XChainClaim,
 
 /** This transaction initiates a crosschain account create transaction */
 TRANSACTION(ttXCHAIN_ACCOUNT_CREATE_COMMIT, 44, XChainAccountCreateCommit,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     noPriv,
     ({
@@ -553,7 +553,7 @@ TRANSACTION(ttXCHAIN_ACCOUNT_CREATE_COMMIT, 44, XChainAccountCreateCommit,
 
 /** This transaction adds an attestation to a claim */
 TRANSACTION(ttXCHAIN_ADD_CLAIM_ATTESTATION, 45, XChainAddClaimAttestation,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     createAcct,
     ({
@@ -574,7 +574,7 @@ TRANSACTION(ttXCHAIN_ADD_CLAIM_ATTESTATION, 45, XChainAddClaimAttestation,
 /** This transaction adds an attestation to an account */
 TRANSACTION(ttXCHAIN_ADD_ACCOUNT_CREATE_ATTESTATION, 46,
     XChainAddAccountCreateAttestation,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     createAcct,
     ({
@@ -595,7 +595,7 @@ TRANSACTION(ttXCHAIN_ADD_ACCOUNT_CREATE_ATTESTATION, 46,
 
 /** This transaction modifies a sidechain */
 TRANSACTION(ttXCHAIN_MODIFY_BRIDGE, 47, XChainModifyBridge,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     noPriv,
     ({
@@ -606,7 +606,7 @@ TRANSACTION(ttXCHAIN_MODIFY_BRIDGE, 47, XChainModifyBridge,
 
 /** This transactions creates a sidechain */
 TRANSACTION(ttXCHAIN_CREATE_BRIDGE, 48, XChainCreateBridge,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureXChainBridge,
     noPriv,
     ({
@@ -620,7 +620,7 @@ TRANSACTION(ttXCHAIN_CREATE_BRIDGE, 48, XChainCreateBridge,
 #   include <xrpld/app/tx/detail/DID.h>
 #endif
 TRANSACTION(ttDID_SET, 49, DIDSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureDID,
     noPriv,
     ({
@@ -631,7 +631,7 @@ TRANSACTION(ttDID_SET, 49, DIDSet,
 
 /** This transaction type deletes a DID */
 TRANSACTION(ttDID_DELETE, 50, DIDDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureDID,
     noPriv,
     ({}))
@@ -641,7 +641,7 @@ TRANSACTION(ttDID_DELETE, 50, DIDDelete,
 #   include <xrpld/app/tx/detail/SetOracle.h>
 #endif
 TRANSACTION(ttORACLE_SET, 51, OracleSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featurePriceOracle,
     noPriv,
     ({
@@ -658,7 +658,7 @@ TRANSACTION(ttORACLE_SET, 51, OracleSet,
 #   include <xrpld/app/tx/detail/DeleteOracle.h>
 #endif
 TRANSACTION(ttORACLE_DELETE, 52, OracleDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featurePriceOracle,
     noPriv,
     ({
@@ -670,7 +670,7 @@ TRANSACTION(ttORACLE_DELETE, 52, OracleDelete,
 #   include <xrpld/app/tx/detail/LedgerStateFix.h>
 #endif
 TRANSACTION(ttLEDGER_STATE_FIX, 53, LedgerStateFix,
-    Delegation::delegatable,
+    Delegation::delegable,
     fixNFTokenPageLinks,
     noPriv,
     ({
@@ -683,7 +683,7 @@ TRANSACTION(ttLEDGER_STATE_FIX, 53, LedgerStateFix,
 #   include <xrpld/app/tx/detail/MPTokenIssuanceCreate.h>
 #endif
 TRANSACTION(ttMPTOKEN_ISSUANCE_CREATE, 54, MPTokenIssuanceCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureMPTokensV1,
     createMPTIssuance,
     ({
@@ -700,7 +700,7 @@ TRANSACTION(ttMPTOKEN_ISSUANCE_CREATE, 54, MPTokenIssuanceCreate,
 #   include <xrpld/app/tx/detail/MPTokenIssuanceDestroy.h>
 #endif
 TRANSACTION(ttMPTOKEN_ISSUANCE_DESTROY, 55, MPTokenIssuanceDestroy,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureMPTokensV1,
     destroyMPTIssuance,
     ({
@@ -712,7 +712,7 @@ TRANSACTION(ttMPTOKEN_ISSUANCE_DESTROY, 55, MPTokenIssuanceDestroy,
 #   include <xrpld/app/tx/detail/MPTokenIssuanceSet.h>
 #endif
 TRANSACTION(ttMPTOKEN_ISSUANCE_SET, 56, MPTokenIssuanceSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureMPTokensV1,
     noPriv,
     ({
@@ -729,7 +729,7 @@ TRANSACTION(ttMPTOKEN_ISSUANCE_SET, 56, MPTokenIssuanceSet,
 #   include <xrpld/app/tx/detail/MPTokenAuthorize.h>
 #endif
 TRANSACTION(ttMPTOKEN_AUTHORIZE, 57, MPTokenAuthorize,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureMPTokensV1,
     mustAuthorizeMPT,
     ({
@@ -742,7 +742,7 @@ TRANSACTION(ttMPTOKEN_AUTHORIZE, 57, MPTokenAuthorize,
 #   include <xrpld/app/tx/detail/Credentials.h>
 #endif
 TRANSACTION(ttCREDENTIAL_CREATE, 58, CredentialCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureCredentials,
     noPriv,
     ({
@@ -754,7 +754,7 @@ TRANSACTION(ttCREDENTIAL_CREATE, 58, CredentialCreate,
 
 /** This transaction type accept an Credential object */
 TRANSACTION(ttCREDENTIAL_ACCEPT, 59, CredentialAccept,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureCredentials,
     noPriv,
     ({
@@ -764,7 +764,7 @@ TRANSACTION(ttCREDENTIAL_ACCEPT, 59, CredentialAccept,
 
 /** This transaction type delete an Credential object */
 TRANSACTION(ttCREDENTIAL_DELETE, 60, CredentialDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureCredentials,
     noPriv,
     ({
@@ -778,7 +778,7 @@ TRANSACTION(ttCREDENTIAL_DELETE, 60, CredentialDelete,
 #   include <xrpld/app/tx/detail/NFTokenModify.h>
 #endif
 TRANSACTION(ttNFTOKEN_MODIFY, 61, NFTokenModify,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureDynamicNFT,
     noPriv,
     ({
@@ -792,7 +792,7 @@ TRANSACTION(ttNFTOKEN_MODIFY, 61, NFTokenModify,
 #   include <xrpld/app/tx/detail/PermissionedDomainSet.h>
 #endif
 TRANSACTION(ttPERMISSIONED_DOMAIN_SET, 62, PermissionedDomainSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featurePermissionedDomains,
     noPriv,
     ({
@@ -805,7 +805,7 @@ TRANSACTION(ttPERMISSIONED_DOMAIN_SET, 62, PermissionedDomainSet,
 #   include <xrpld/app/tx/detail/PermissionedDomainDelete.h>
 #endif
 TRANSACTION(ttPERMISSIONED_DOMAIN_DELETE, 63, PermissionedDomainDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featurePermissionedDomains,
     noPriv,
     ({
@@ -817,7 +817,7 @@ TRANSACTION(ttPERMISSIONED_DOMAIN_DELETE, 63, PermissionedDomainDelete,
 #   include <xrpld/app/tx/detail/DelegateSet.h>
 #endif
 TRANSACTION(ttDELEGATE_SET, 64, DelegateSet,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     featurePermissionDelegationV1_1,
     noPriv,
     ({
@@ -830,7 +830,7 @@ TRANSACTION(ttDELEGATE_SET, 64, DelegateSet,
 #   include <xrpld/app/tx/detail/VaultCreate.h>
 #endif
 TRANSACTION(ttVAULT_CREATE, 65, VaultCreate,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureSingleAssetVault,
     createPseudoAcct | createMPTIssuance | mustModifyVault,
     ({
@@ -848,7 +848,7 @@ TRANSACTION(ttVAULT_CREATE, 65, VaultCreate,
 #   include <xrpld/app/tx/detail/VaultSet.h>
 #endif
 TRANSACTION(ttVAULT_SET, 66, VaultSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureSingleAssetVault,
     mustModifyVault,
     ({
@@ -863,7 +863,7 @@ TRANSACTION(ttVAULT_SET, 66, VaultSet,
 #   include <xrpld/app/tx/detail/VaultDelete.h>
 #endif
 TRANSACTION(ttVAULT_DELETE, 67, VaultDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureSingleAssetVault,
     mustDeleteAcct | destroyMPTIssuance | mustModifyVault,
     ({
@@ -875,7 +875,7 @@ TRANSACTION(ttVAULT_DELETE, 67, VaultDelete,
 #   include <xrpld/app/tx/detail/VaultDeposit.h>
 #endif
 TRANSACTION(ttVAULT_DEPOSIT, 68, VaultDeposit,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureSingleAssetVault,
     mayAuthorizeMPT | mustModifyVault,
     ({
@@ -888,7 +888,7 @@ TRANSACTION(ttVAULT_DEPOSIT, 68, VaultDeposit,
 #   include <xrpld/app/tx/detail/VaultWithdraw.h>
 #endif
 TRANSACTION(ttVAULT_WITHDRAW, 69, VaultWithdraw,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureSingleAssetVault,
     mayDeleteMPT | mayAuthorizeMPT | mustModifyVault,
     ({
@@ -903,7 +903,7 @@ TRANSACTION(ttVAULT_WITHDRAW, 69, VaultWithdraw,
 #   include <xrpld/app/tx/detail/VaultClawback.h>
 #endif
 TRANSACTION(ttVAULT_CLAWBACK, 70, VaultClawback,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureSingleAssetVault,
     mayDeleteMPT | mustModifyVault,
     ({
@@ -917,7 +917,7 @@ TRANSACTION(ttVAULT_CLAWBACK, 70, VaultClawback,
 #   include <xrpld/app/tx/detail/Batch.h>
 #endif
 TRANSACTION(ttBATCH, 71, Batch,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     featureBatch,
     noPriv,
     ({
@@ -932,7 +932,7 @@ TRANSACTION(ttBATCH, 71, Batch,
 #   include <xrpld/app/tx/detail/LoanBrokerSet.h>
 #endif
 TRANSACTION(ttLOAN_BROKER_SET, 74, LoanBrokerSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     createPseudoAcct | mayAuthorizeMPT, ({
     {sfVaultID, soeREQUIRED},
@@ -949,7 +949,7 @@ TRANSACTION(ttLOAN_BROKER_SET, 74, LoanBrokerSet,
 #   include <xrpld/app/tx/detail/LoanBrokerDelete.h>
 #endif
 TRANSACTION(ttLOAN_BROKER_DELETE, 75, LoanBrokerDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     mustDeleteAcct | mayAuthorizeMPT, ({
     {sfLoanBrokerID, soeREQUIRED},
@@ -960,7 +960,7 @@ TRANSACTION(ttLOAN_BROKER_DELETE, 75, LoanBrokerDelete,
 #   include <xrpld/app/tx/detail/LoanBrokerCoverDeposit.h>
 #endif
 TRANSACTION(ttLOAN_BROKER_COVER_DEPOSIT, 76, LoanBrokerCoverDeposit,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     noPriv, ({
     {sfLoanBrokerID, soeREQUIRED},
@@ -972,7 +972,7 @@ TRANSACTION(ttLOAN_BROKER_COVER_DEPOSIT, 76, LoanBrokerCoverDeposit,
 #   include <xrpld/app/tx/detail/LoanBrokerCoverWithdraw.h>
 #endif
 TRANSACTION(ttLOAN_BROKER_COVER_WITHDRAW, 77, LoanBrokerCoverWithdraw,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     mayAuthorizeMPT, ({
     {sfLoanBrokerID, soeREQUIRED},
@@ -987,7 +987,7 @@ TRANSACTION(ttLOAN_BROKER_COVER_WITHDRAW, 77, LoanBrokerCoverWithdraw,
 #   include <xrpld/app/tx/detail/LoanBrokerCoverClawback.h>
 #endif
 TRANSACTION(ttLOAN_BROKER_COVER_CLAWBACK, 78, LoanBrokerCoverClawback,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     noPriv, ({
     {sfLoanBrokerID, soeOPTIONAL},
@@ -999,7 +999,7 @@ TRANSACTION(ttLOAN_BROKER_COVER_CLAWBACK, 78, LoanBrokerCoverClawback,
 #   include <xrpld/app/tx/detail/LoanSet.h>
 #endif
 TRANSACTION(ttLOAN_SET, 80, LoanSet,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     mayAuthorizeMPT | mustModifyVault, ({
     {sfLoanBrokerID, soeREQUIRED},
@@ -1026,7 +1026,7 @@ TRANSACTION(ttLOAN_SET, 80, LoanSet,
 #   include <xrpld/app/tx/detail/LoanDelete.h>
 #endif
 TRANSACTION(ttLOAN_DELETE, 81, LoanDelete,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     noPriv, ({
     {sfLoanID, soeREQUIRED},
@@ -1037,7 +1037,7 @@ TRANSACTION(ttLOAN_DELETE, 81, LoanDelete,
 #   include <xrpld/app/tx/detail/LoanManage.h>
 #endif
 TRANSACTION(ttLOAN_MANAGE, 82, LoanManage,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     // All of the LoanManage options will modify the vault, but the
     // transaction can succeed without options, essentially making it
@@ -1051,7 +1051,7 @@ TRANSACTION(ttLOAN_MANAGE, 82, LoanManage,
 #   include <xrpld/app/tx/detail/LoanPay.h>
 #endif
 TRANSACTION(ttLOAN_PAY, 84, LoanPay,
-    Delegation::delegatable,
+    Delegation::delegable,
     featureLendingProtocol,
     mayAuthorizeMPT | mustModifyVault, ({
     {sfLoanID, soeREQUIRED},
@@ -1066,7 +1066,7 @@ TRANSACTION(ttLOAN_PAY, 84, LoanPay,
 #   include <xrpld/app/tx/detail/Change.h>
 #endif
 TRANSACTION(ttAMENDMENT, 100, EnableAmendment,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     noPriv,
     ({
@@ -1078,7 +1078,7 @@ TRANSACTION(ttAMENDMENT, 100, EnableAmendment,
     For details, see: https://xrpl.org/fee-voting.html
  */
 TRANSACTION(ttFEE, 101, SetFee,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     noPriv,
     ({
@@ -1099,7 +1099,7 @@ TRANSACTION(ttFEE, 101, SetFee,
     For details, see: https://xrpl.org/negative-unl.html
  */
 TRANSACTION(ttUNL_MODIFY, 102, UNLModify,
-    Delegation::notDelegatable,
+    Delegation::notDelegable,
     uint256{},
     noPriv,
     ({

include/xrpl/resource/README.md

@@ -66,7 +66,7 @@ values over time: this is implemented by the DecayingSample class.
 Each server in a cluster creates a list of IP addresses of end points
 that are imposing a significant load. This list is called Gossip, which
 is passed to other nodes in that cluster. Gossip helps individual
-servers in the cluster identify IP addreses that might be unduly loading
+servers in the cluster identify IP addresses that might be unduly loading
 the entire cluster. Again the recourse of the individual servers is to
 drop connections to those IP addresses that occur commonly in the gossip.
 

include/xrpl/resource/detail/Logic.h

@@ -61,7 +61,7 @@ private:
     // List of all active admin entries
     EntryIntrusiveList admin_;
 
-    // List of all inactve entries
+    // List of all inactive entries
     EntryIntrusiveList inactive_;
 
     // All imported gossip data

include/xrpl/server/detail/LowestLayer.h

@@ -9,7 +9,7 @@
 
 namespace xrpl {
 
-// Before boost 1.70, get_lowest_layer required an explicit templat parameter
+// Before boost 1.70, get_lowest_layer required an explicit template parameter
 template <class T>
 decltype(auto)
 get_lowest_layer(T& t) noexcept

include/xrpl/shamap/README.md

@@ -226,7 +226,7 @@ The `fetchNodeNT()` method goes through three phases:
 
     Any SHAMapLeafNode that is immutable has a sequence number of zero
     (sharable). When a mutable `SHAMap` is created then its SHAMapTreeNodes are
-    given non-zero sequence numbers (unsharable). But all nodes in the
+    given non-zero sequence numbers (unshareable). But all nodes in the
     TreeNodeCache are immutable, so if one is found here, its sequence number
     will be 0.
 

include/xrpl/shamap/SHAMapItem.h

@@ -125,13 +125,13 @@ intrusive_ptr_release(SHAMapItem const* x)
     {
         auto p = reinterpret_cast<std::uint8_t const*>(x);
 
-        // The SHAMapItem constuctor isn't trivial (because the destructor
+        // The SHAMapItem constructor isn't trivial (because the destructor
         // for CountedObject isn't) so we can't avoid calling it here, but
         // plan for a future where we might not need to.
         if constexpr (!std::is_trivially_destructible_v<SHAMapItem>)
             std::destroy_at(x);
 
-        // If the slabber doens't claim this pointer, it was allocated
+        // If the slabber doesn't claim this pointer, it was allocated
         // manually, so we free it manually.
         if (!detail::slabber.deallocate(const_cast<std::uint8_t*>(p)))
             delete[] p;

src/doctest/CMakeLists.txt

@@ -1,38 +0,0 @@
-include(XrplAddTest)
-
-# Test requirements.
-find_package(doctest REQUIRED)
-
-# Custom target for all doctest tests
-add_custom_target(xrpl.doctest.tests)
-
-# Common library dependencies for doctest tests
-add_library(xrpl.imports.doctest INTERFACE)
-target_link_libraries(xrpl.imports.doctest INTERFACE
-    doctest::doctest
-    xrpl.libxrpl
-)
-
-# Add test directories
-# Note: These tests are converted from Beast Unit Test framework to doctest
-
-# Basics tests (successfully migrated unit tests)
-# Files: Buffer, Expected, IOUAmount, Number, XRPAmount
-file(GLOB basics_test_sources basics/*_test.cpp)
-add_executable(xrpl.test.basics main.cpp ${basics_test_sources})
-target_link_libraries(xrpl.test.basics PRIVATE xrpl.libxrpl xrpl.imports.doctest)
-add_dependencies(xrpl.doctest.tests xrpl.test.basics)
-
-
-# Protocol tests (successfully migrated unit tests)
-# Files: ApiVersion, BuildInfo, STAccount, STInteger, STNumber, SecretKey, Seed
-file(GLOB protocol_test_sources protocol/*_test.cpp)
-add_executable(xrpl.test.protocol main.cpp ${protocol_test_sources})
-target_link_libraries(xrpl.test.protocol PRIVATE xrpl.libxrpl xrpl.imports.doctest)
-add_dependencies(xrpl.doctest.tests xrpl.test.protocol)
-
-# JSON tests (successfully migrated)
-# File: Object
-xrpl_add_test(json)
-target_link_libraries(xrpl.test.json PRIVATE xrpl.imports.doctest)
-add_dependencies(xrpl.doctest.tests xrpl.test.json)

src/doctest/README.md

@@ -1,247 +0,0 @@
-# Doctest Unit Tests
-
-This directory contains unit tests that have been successfully migrated from the Beast Unit Test framework to [doctest](https://github.com/doctest/doctest).
-
-## Status: Production Ready ✅
-
-All tests in this directory are:
-- ✅ Successfully migrated to doctest
-- ✅ Building without errors
-- ✅ Passing all assertions
-- ✅ Runnable independently
-
-## Test Modules
-
-### Basics Tests
-**Location**: `basics/`
-**Files**: 5 test files
-**Test Cases**: 36
-**Assertions**: 1,365
-
-Successfully migrated tests:
-- `Buffer_test.cpp` - Buffer and Slice operations
-- `Expected_test.cpp` - Expected/Unexpected result types
-- `IOUAmount_test.cpp` - IOU amount calculations
-- `Number_test.cpp` - Numeric type operations
-- `XRPAmount_test.cpp` - XRP amount handling
-
-**Run**: `./xrpl.test.basics`
-
-### Protocol Tests
-**Location**: `protocol/`
-**Files**: 7 test files
-**Test Cases**: 37
-**Assertions**: 16,020
-
-Successfully migrated tests:
-- `ApiVersion_test.cpp` - API version validation
-- `BuildInfo_test.cpp` - Build version encoding/decoding
-- `STAccount_test.cpp` - Serialized account types
-- `STInteger_test.cpp` - Serialized integer types (UInt8/16/32/64, Int32)
-- `STNumber_test.cpp` - Serialized number types with JSON parsing
-- `SecretKey_test.cpp` - Secret key generation, signing, and verification
-- `Seed_test.cpp` - Seed generation, parsing, and keypair operations
-
-**Run**: `./xrpl.test.protocol`
-
-### JSON Tests
-**Location**: `json/`
-**Files**: 1 test file
-**Test Cases**: 8
-**Assertions**: 12
-
-Successfully migrated tests:
-- `Object_test.cpp` - JSON object operations
-
-**Run**: `./xrpl.test.json`
-
-## Total Statistics
-
-- **11 test files**
-- **81 test cases**
-- **17,397 assertions**
-- **100% passing** ✨
-
-## Building Tests
-
-From the build directory:
-
-```bash
-# Build all doctest tests
-cmake --build . --target xrpl.doctest.tests
-
-# Build individual modules
-cmake --build . --target xrpl.test.basics
-cmake --build . --target xrpl.test.protocol
-cmake --build . --target xrpl.test.json
-```
-
-## Running Tests
-
-From the build directory:
-
-```bash
-# Run all tests
-./src/doctest/xrpl.test.basics
-./src/doctest/xrpl.test.protocol
-./src/doctest/xrpl.test.json
-
-# Run with options
-./src/doctest/xrpl.test.basics --list-test-cases
-./src/doctest/xrpl.test.protocol --success
-./src/doctest/xrpl.test.json --duration
-
-# Filter by test suite
-./src/doctest/xrpl.test.basics --test-suite=basics
-./src/doctest/xrpl.test.protocol --test-suite=protocol
-./src/doctest/xrpl.test.json --test-suite=JsonObject
-```
-
-## Best Practices Applied
-
-All migrated tests follow official doctest best practices:
-
-### 1. TEST_SUITE Organization
-
-All test files are organized into suites for better filtering and organization:
-
-```cpp
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("Buffer") { /* tests */ }
-
-TEST_SUITE_END();
-```
-
-**Benefits**:
-- Filter tests by suite: `./xrpl.test.protocol --test-suite=protocol`
-- Better organization and documentation
-- Clearer test structure
-
-### 2. CHECK_FALSE for Readability
-
-Using `CHECK_FALSE(expression)` instead of `CHECK(!(expression))`:
-
-```cpp
-// More readable:
-CHECK_FALSE(buffer.empty());
-```
-
-### 3. CAPTURE Macros in Loops
-
-CAPTURE macros provide better failure diagnostics in loops:
-
-```cpp
-for (std::size_t i = 0; i < 16; ++i) {
-    CAPTURE(i);  // Shows value of i when test fails
-    test(buffer, i);
-}
-```
-
-### 4. REQUIRE for Critical Preconditions
-
-Use REQUIRE when subsequent code depends on the assertion:
-
-```cpp
-auto parsed = parseBase58<AccountID>(s);
-REQUIRE(parsed);  // Stops test if parsing fails
-CHECK(toBase58(*parsed) == s);  // Safe to dereference
-```
-
-## Migration Guidelines
-
-### Key Patterns
-
-1. **Headers First**: Include production headers before doctest
-   ```cpp
-   #include <xrpl/protocol/STInteger.h>
-   #include <doctest/doctest.h>
-   ```
-
-2. **Using Declarations**: Add at global scope for namespace migration
-   ```cpp
-   using xrpl::STUInt32;
-   using xrpl::JsonOptions;
-   ```
-
-3. **Test Cases**: Use TEST_CASE macro
-   ```cpp
-   TEST_CASE("Descriptive Test Name") {
-       CHECK(condition);
-   }
-   ```
-
-4. **Subcases**: Organize related scenarios
-   ```cpp
-   TEST_CASE("Feature Tests") {
-       SUBCASE("Scenario 1") { /* tests */ }
-       SUBCASE("Scenario 2") { /* tests */ }
-   }
-   ```
-
-5. **Assertions**:
-   - `CHECK()` - continues on failure
-   - `REQUIRE()` - stops on failure
-   - `CHECK_THROWS_AS()` - exception testing
-
-### Namespace Migration
-
-Types moved from `ripple` → `xrpl` namespace:
-- Add `using xrpl::TypeName;` declarations
-- For nested namespaces: `namespace Alias = xrpl::Nested;`
-- Or use full qualification: `xrpl::RPC::constant`
-
-### What Makes a Good Candidate for Migration
-
-✅ **Migrate to Doctest**:
-- Standalone unit tests
-- Tests single class/function in isolation
-- No dependencies on `test/jtx` or `test/csf` frameworks
-- Pure logic/algorithm/data structure tests
-
-❌ **Keep in Beast** (integration tests):
-- Requires Env class (ledger/transaction environment)
-- Depends on `test/jtx` utilities
-- Depends on `test/csf` (consensus simulation)
-- Multi-component interaction tests
-
-## Files
-
-```
-src/doctest/
-├── README.md           # This file
-├── CMakeLists.txt      # Build configuration
-├── main.cpp            # Doctest main entry point
-├── basics/
-│   ├── Buffer_test.cpp
-│   ├── Expected_test.cpp
-│   ├── IOUAmount_test.cpp
-│   ├── Number_test.cpp
-│   └── XRPAmount_test.cpp
-├── protocol/
-│   ├── main.cpp
-│   ├── ApiVersion_test.cpp
-│   ├── BuildInfo_test.cpp
-│   ├── STAccount_test.cpp
-│   ├── STInteger_test.cpp
-│   ├── STNumber_test.cpp
-│   ├── SecretKey_test.cpp
-│   └── Seed_test.cpp
-└── json/
-    ├── main.cpp
-    └── Object_test.cpp
-```
-
-## References
-
-- [Doctest Documentation](https://github.com/doctest/doctest/blob/master/doc/markdown/readme.md)
-- [Doctest Tutorial](https://github.com/doctest/doctest/blob/master/doc/markdown/tutorial.md)
-- [Assertion Macros](https://github.com/doctest/doctest/blob/master/doc/markdown/assertions.md)
-- [Doctest Best Practices (ACCU)](https://accu.org/journals/overload/25/137/kirilov_2343/)
-
-## Notes
-
-- Original Beast tests remain in `src/test/` for integration tests
-- Both frameworks coexist - doctest for unit tests, Beast for integration tests
-- All doctest tests are auto-discovered at compile time
-- No manual test registration required

src/doctest/basics/Buffer_test.cpp

@@ -1,265 +0,0 @@
-#include <xrpl/basics/Buffer.h>
-#include <xrpl/basics/Slice.h>
-
-#include <doctest/doctest.h>
-
-#include <cstdint>
-#include <type_traits>
-
-using xrpl::Buffer;
-using xrpl::Slice;
-
-namespace ripple {
-namespace test {
-
-static bool
-sane(Buffer const& b)
-{
-    if (b.size() == 0)
-        return b.data() == nullptr;
-
-    return b.data() != nullptr;
-}
-
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("Buffer")
-{
-    std::uint8_t const data[] = {
-        0xa8, 0xa1, 0x38, 0x45, 0x23, 0xec, 0xe4, 0x23, 0x71, 0x6d, 0x2a,
-        0x18, 0xb4, 0x70, 0xcb, 0xf5, 0xac, 0x2d, 0x89, 0x4d, 0x19, 0x9c,
-        0xf0, 0x2c, 0x15, 0xd1, 0xf9, 0x9b, 0x66, 0xd2, 0x30, 0xd3};
-
-    Buffer b0;
-    CHECK(sane(b0));
-    CHECK(b0.empty());
-
-    Buffer b1{0};
-    CHECK(sane(b1));
-    CHECK(b1.empty());
-    std::memcpy(b1.alloc(16), data, 16);
-    CHECK(sane(b1));
-    CHECK_FALSE(b1.empty());
-    CHECK(b1.size() == 16);
-
-    Buffer b2{b1.size()};
-    CHECK(sane(b2));
-    CHECK_FALSE(b2.empty());
-    CHECK(b2.size() == b1.size());
-    std::memcpy(b2.data(), data + 16, 16);
-
-    Buffer b3{data, sizeof(data)};
-    CHECK(sane(b3));
-    CHECK_FALSE(b3.empty());
-    CHECK(b3.size() == sizeof(data));
-    CHECK(std::memcmp(b3.data(), data, b3.size()) == 0);
-
-    // Check equality and inequality comparisons
-    CHECK(b0 == b0);
-    CHECK(b0 != b1);
-    CHECK(b1 == b1);
-    CHECK(b1 != b2);
-    CHECK(b2 != b3);
-
-    SUBCASE("Copy Construction / Assignment")
-    {
-        Buffer x{b0};
-        CHECK(x == b0);
-        CHECK(sane(x));
-        Buffer y{b1};
-        CHECK(y == b1);
-        CHECK(sane(y));
-        x = b2;
-        CHECK(x == b2);
-        CHECK(sane(x));
-        x = y;
-        CHECK(x == y);
-        CHECK(sane(x));
-        y = b3;
-        CHECK(y == b3);
-        CHECK(sane(y));
-        x = b0;
-        CHECK(x == b0);
-        CHECK(sane(x));
-#if defined(__clang__)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wself-assign-overloaded"
-#endif
-
-        x = x;
-        CHECK(x == b0);
-        CHECK(sane(x));
-        y = y;
-        CHECK(y == b3);
-        CHECK(sane(y));
-
-#if defined(__clang__)
-#pragma clang diagnostic pop
-#endif
-    }
-
-    SUBCASE("Move Construction / Assignment")
-    {
-        static_assert(
-            std::is_nothrow_move_constructible<Buffer>::value, "");
-        static_assert(std::is_nothrow_move_assignable<Buffer>::value, "");
-
-        {  // Move-construct from empty buf
-            Buffer x;
-            Buffer y{std::move(x)};
-            CHECK(sane(x));
-            CHECK(x.empty());
-            CHECK(sane(y));
-            CHECK(y.empty());
-            CHECK(x == y);
-        }
-
-        {  // Move-construct from non-empty buf
-            Buffer x{b1};
-            Buffer y{std::move(x)};
-            CHECK(sane(x));
-            CHECK(x.empty());
-            CHECK(sane(y));
-            CHECK(y == b1);
-        }
-
-        {  // Move assign empty buf to empty buf
-            Buffer x;
-            Buffer y;
-
-            x = std::move(y);
-            CHECK(sane(x));
-            CHECK(x.empty());
-            CHECK(sane(y));
-            CHECK(y.empty());
-        }
-
-        {  // Move assign non-empty buf to empty buf
-            Buffer x;
-            Buffer y{b1};
-
-            x = std::move(y);
-            CHECK(sane(x));
-            CHECK(x == b1);
-            CHECK(sane(y));
-            CHECK(y.empty());
-        }
-
-        {  // Move assign empty buf to non-empty buf
-            Buffer x{b1};
-            Buffer y;
-
-            x = std::move(y);
-            CHECK(sane(x));
-            CHECK(x.empty());
-            CHECK(sane(y));
-            CHECK(y.empty());
-        }
-
-        {  // Move assign non-empty buf to non-empty buf
-            Buffer x{b1};
-            Buffer y{b2};
-            Buffer z{b3};
-
-            x = std::move(y);
-            CHECK(sane(x));
-            CHECK_FALSE(x.empty());
-            CHECK(sane(y));
-            CHECK(y.empty());
-
-            x = std::move(z);
-            CHECK(sane(x));
-            CHECK_FALSE(x.empty());
-            CHECK(sane(z));
-            CHECK(z.empty());
-        }
-    }
-
-    SUBCASE("Slice Conversion / Construction / Assignment")
-    {
-        Buffer w{static_cast<Slice>(b0)};
-        CHECK(sane(w));
-        CHECK(w == b0);
-
-        Buffer x{static_cast<Slice>(b1)};
-        CHECK(sane(x));
-        CHECK(x == b1);
-
-        Buffer y{static_cast<Slice>(b2)};
-        CHECK(sane(y));
-        CHECK(y == b2);
-
-        Buffer z{static_cast<Slice>(b3)};
-        CHECK(sane(z));
-        CHECK(z == b3);
-
-        // Assign empty slice to empty buffer
-        w = static_cast<Slice>(b0);
-        CHECK(sane(w));
-        CHECK(w == b0);
-
-        // Assign non-empty slice to empty buffer
-        w = static_cast<Slice>(b1);
-        CHECK(sane(w));
-        CHECK(w == b1);
-
-        // Assign non-empty slice to non-empty buffer
-        x = static_cast<Slice>(b2);
-        CHECK(sane(x));
-        CHECK(x == b2);
-
-        // Assign non-empty slice to non-empty buffer
-        y = static_cast<Slice>(z);
-        CHECK(sane(y));
-        CHECK(y == z);
-
-        // Assign empty slice to non-empty buffer:
-        z = static_cast<Slice>(b0);
-        CHECK(sane(z));
-        CHECK(z == b0);
-    }
-
-    SUBCASE("Allocation, Deallocation and Clearing")
-    {
-        auto test = [](Buffer const& b, std::size_t i) {
-            Buffer x{b};
-
-            // Try to allocate some number of bytes, possibly
-            // zero (which means clear) and sanity check
-            x(i);
-            CHECK(sane(x));
-            CHECK(x.size() == i);
-            CHECK((x.data() == nullptr) == (i == 0));
-
-            // Try to allocate some more data (always non-zero)
-            x(i + 1);
-            CHECK(sane(x));
-            CHECK(x.size() == i + 1);
-            CHECK(x.data() != nullptr);
-
-            // Try to clear:
-            x.clear();
-            CHECK(sane(x));
-            CHECK(x.size() == 0);
-            CHECK(x.data() == nullptr);
-
-            // Try to clear again:
-            x.clear();
-            CHECK(sane(x));
-            CHECK(x.size() == 0);
-            CHECK(x.data() == nullptr);
-        };
-
-        for (std::size_t i = 0; i < 16; ++i)
-        {
-            CAPTURE(i);
-            test(b0, i);
-            test(b1, i);
-        }
-    }
-}
-
-TEST_SUITE_END();
-
-}  // namespace test
-}  // namespace ripple

src/doctest/basics/Expected_test.cpp

@@ -1,234 +0,0 @@
-#include <xrpl/basics/Expected.h>
-#include <xrpl/protocol/TER.h>
-
-#include <doctest/doctest.h>
-
-#if BOOST_VERSION >= 107500
-#include <boost/json.hpp>  // Not part of boost before version 1.75
-#endif                     // BOOST_VERSION
-#include <array>
-#include <cstdint>
-
-using xrpl::Expected;
-using xrpl::TER;
-using xrpl::Unexpected;
-using xrpl::telLOCAL_ERROR;
-
-namespace ripple {
-namespace test {
-
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("Expected")
-{
-    // Test non-error const construction.
-    {
-        auto const expected = []() -> Expected<std::string, TER> {
-            return "Valid value";
-        }();
-        CHECK(expected);
-        CHECK(expected.has_value());
-        CHECK(expected.value() == "Valid value");
-        CHECK(*expected == "Valid value");
-        CHECK(expected->at(0) == 'V');
-
-        bool throwOccurred = false;
-        try
-        {
-            // There's no error, so should throw.
-            [[maybe_unused]] TER const t = expected.error();
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test non-error non-const construction.
-    {
-        auto expected = []() -> Expected<std::string, TER> {
-            return "Valid value";
-        }();
-        CHECK(expected);
-        CHECK(expected.has_value());
-        CHECK(expected.value() == "Valid value");
-        CHECK(*expected == "Valid value");
-        CHECK(expected->at(0) == 'V');
-        std::string mv = std::move(*expected);
-        CHECK(mv == "Valid value");
-
-        bool throwOccurred = false;
-        try
-        {
-            // There's no error, so should throw.
-            [[maybe_unused]] TER const t = expected.error();
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test non-error overlapping type construction.
-    {
-        auto expected = []() -> Expected<std::uint32_t, std::uint16_t> {
-            return 1;
-        }();
-        CHECK(expected);
-        CHECK(expected.has_value());
-        CHECK(expected.value() == 1);
-        CHECK(*expected == 1);
-
-        bool throwOccurred = false;
-        try
-        {
-            // There's no error, so should throw.
-            [[maybe_unused]] std::uint16_t const t = expected.error();
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test error construction from rvalue.
-    {
-        auto const expected = []() -> Expected<std::string, TER> {
-            return Unexpected(telLOCAL_ERROR);
-        }();
-        CHECK_FALSE(expected);
-        CHECK_FALSE(expected.has_value());
-        CHECK(expected.error() == telLOCAL_ERROR);
-
-        bool throwOccurred = false;
-        try
-        {
-            // There's no result, so should throw.
-            [[maybe_unused]] std::string const s = *expected;
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test error construction from lvalue.
-    {
-        auto const err(telLOCAL_ERROR);
-        auto expected = [&err]() -> Expected<std::string, TER> {
-            return Unexpected(err);
-        }();
-        CHECK_FALSE(expected);
-        CHECK_FALSE(expected.has_value());
-        CHECK(expected.error() == telLOCAL_ERROR);
-
-        bool throwOccurred = false;
-        try
-        {
-            // There's no result, so should throw.
-            [[maybe_unused]] std::size_t const s = expected->size();
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test error construction from const char*.
-    {
-        auto const expected = []() -> Expected<int, char const*> {
-            return Unexpected("Not what is expected!");
-        }();
-        CHECK_FALSE(expected);
-        CHECK_FALSE(expected.has_value());
-        CHECK(
-            expected.error() == std::string("Not what is expected!"));
-    }
-    // Test error construction of string from const char*.
-    {
-        auto expected = []() -> Expected<int, std::string> {
-            return Unexpected("Not what is expected!");
-        }();
-        CHECK_FALSE(expected);
-        CHECK_FALSE(expected.has_value());
-        CHECK(expected.error() == "Not what is expected!");
-        std::string const s(std::move(expected.error()));
-        CHECK(s == "Not what is expected!");
-    }
-    // Test non-error const construction of Expected<void, T>.
-    {
-        auto const expected = []() -> Expected<void, std::string> {
-            return {};
-        }();
-        CHECK(expected);
-        bool throwOccurred = false;
-        try
-        {
-            // There's no error, so should throw.
-            [[maybe_unused]] std::size_t const s = expected.error().size();
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test non-error non-const construction of Expected<void, T>.
-    {
-        auto expected = []() -> Expected<void, std::string> {
-            return {};
-        }();
-        CHECK(expected);
-        bool throwOccurred = false;
-        try
-        {
-            // There's no error, so should throw.
-            [[maybe_unused]] std::size_t const s = expected.error().size();
-        }
-        catch (std::runtime_error const& e)
-        {
-            CHECK(e.what() == std::string("bad expected access"));
-            throwOccurred = true;
-        }
-        CHECK(throwOccurred);
-    }
-    // Test error const construction of Expected<void, T>.
-    {
-        auto const expected = []() -> Expected<void, std::string> {
-            return Unexpected("Not what is expected!");
-        }();
-        CHECK_FALSE(expected);
-        CHECK(expected.error() == "Not what is expected!");
-    }
-    // Test error non-const construction of Expected<void, T>.
-    {
-        auto expected = []() -> Expected<void, std::string> {
-            return Unexpected("Not what is expected!");
-        }();
-        CHECK_FALSE(expected);
-        CHECK(expected.error() == "Not what is expected!");
-        std::string const s(std::move(expected.error()));
-        CHECK(s == "Not what is expected!");
-    }
-    // Test a case that previously unintentionally returned an array.
-#if BOOST_VERSION >= 107500
-    {
-        auto expected = []() -> Expected<boost::json::value, std::string> {
-            return boost::json::object{{"oops", "me array now"}};
-        }();
-        CHECK(expected);
-        CHECK_FALSE(expected.value().is_array());
-    }
-#endif  // BOOST_VERSION
-}
-
-TEST_SUITE_END();
-
-}  // namespace test
-}  // namespace ripple

src/doctest/basics/IOUAmount_test.cpp

@@ -1,233 +0,0 @@
-#include <xrpl/protocol/IOUAmount.h>
-
-#include <doctest/doctest.h>
-
-using xrpl::IOUAmount;
-
-namespace ripple {
-
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("IOUAmount")
-{
-    SUBCASE("zero")
-    {
-        IOUAmount const z(0, 0);
-
-        CHECK(z.mantissa() == 0);
-        CHECK(z.exponent() == -100);
-        CHECK_FALSE(z);
-        CHECK(z.signum() == 0);
-        CHECK(z == beast::zero);
-
-        CHECK((z + z) == z);
-        CHECK((z - z) == z);
-        CHECK(z == -z);
-
-        IOUAmount const zz(beast::zero);
-        CHECK(z == zz);
-
-        // https://github.com/XRPLF/rippled/issues/5170
-        IOUAmount const zzz{};
-        CHECK(zzz == beast::zero);
-        // CHECK(zzz == zz);
-    }
-
-    SUBCASE("signum")
-    {
-        IOUAmount const neg(-1, 0);
-        CHECK(neg.signum() < 0);
-
-        IOUAmount const zer(0, 0);
-        CHECK(zer.signum() == 0);
-
-        IOUAmount const pos(1, 0);
-        CHECK(pos.signum() > 0);
-    }
-
-    SUBCASE("beast::Zero Comparisons")
-    {
-        using beast::zero;
-
-        {
-            IOUAmount z(zero);
-            CHECK(z == zero);
-            CHECK(z >= zero);
-            CHECK(z <= zero);
-            CHECK(!(z != zero));
-            CHECK(!(z > zero));
-            CHECK(!(z < zero));
-        }
-
-        {
-            IOUAmount const neg(-2, 0);
-            CHECK(neg < zero);
-            CHECK(neg <= zero);
-            CHECK(neg != zero);
-            CHECK(!(neg == zero));
-        }
-
-        {
-            IOUAmount const pos(2, 0);
-            CHECK(pos > zero);
-            CHECK(pos >= zero);
-            CHECK(pos != zero);
-            CHECK(!(pos == zero));
-        }
-    }
-
-    SUBCASE("IOU Comparisons")
-    {
-        IOUAmount const n(-2, 0);
-        IOUAmount const z(0, 0);
-        IOUAmount const p(2, 0);
-
-        CHECK(z == z);
-        CHECK(z >= z);
-        CHECK(z <= z);
-        CHECK(z == -z);
-        CHECK(!(z > z));
-        CHECK(!(z < z));
-        CHECK(!(z != z));
-        CHECK(!(z != -z));
-
-        CHECK(n < z);
-        CHECK(n <= z);
-        CHECK(n != z);
-        CHECK(!(n > z));
-        CHECK(!(n >= z));
-        CHECK(!(n == z));
-
-        CHECK(p > z);
-        CHECK(p >= z);
-        CHECK(p != z);
-        CHECK(!(p < z));
-        CHECK(!(p <= z));
-        CHECK(!(p == z));
-
-        CHECK(n < p);
-        CHECK(n <= p);
-        CHECK(n != p);
-        CHECK(!(n > p));
-        CHECK(!(n >= p));
-        CHECK(!(n == p));
-
-        CHECK(p > n);
-        CHECK(p >= n);
-        CHECK(p != n);
-        CHECK(!(p < n));
-        CHECK(!(p <= n));
-        CHECK(!(p == n));
-
-        CHECK(p > -p);
-        CHECK(p >= -p);
-        CHECK(p != -p);
-
-        CHECK(n < -n);
-        CHECK(n <= -n);
-        CHECK(n != -n);
-    }
-
-    SUBCASE("IOU strings")
-    {
-        CHECK(to_string(IOUAmount(-2, 0)) == "-2");
-        CHECK(to_string(IOUAmount(0, 0)) == "0");
-        CHECK(to_string(IOUAmount(2, 0)) == "2");
-        CHECK(to_string(IOUAmount(25, -3)) == "0.025");
-        CHECK(to_string(IOUAmount(-25, -3)) == "-0.025");
-        CHECK(to_string(IOUAmount(25, 1)) == "250");
-        CHECK(to_string(IOUAmount(-25, 1)) == "-250");
-        CHECK(to_string(IOUAmount(2, 20)) == "2000000000000000e5");
-        CHECK(to_string(IOUAmount(-2, -20)) == "-2000000000000000e-35");
-    }
-
-    SUBCASE("mulRatio")
-    {
-        /* The range for the mantissa when normalized */
-        constexpr std::int64_t minMantissa = 1000000000000000ull;
-        constexpr std::int64_t maxMantissa = 9999999999999999ull;
-        // log(2,maxMantissa) ~ 53.15
-        /* The range for the exponent when normalized */
-        constexpr int minExponent = -96;
-        constexpr int maxExponent = 80;
-        constexpr auto maxUInt = std::numeric_limits<std::uint32_t>::max();
-
-        {
-            // multiply by a number that would overflow the mantissa, then
-            // divide by the same number, and check we didn't lose any value
-            IOUAmount bigMan(maxMantissa, 0);
-            CHECK(bigMan == mulRatio(bigMan, maxUInt, maxUInt, true));
-            // rounding mode shouldn't matter as the result is exact
-            CHECK(bigMan == mulRatio(bigMan, maxUInt, maxUInt, false));
-        }
-        {
-            // Similar test as above, but for negative values
-            IOUAmount bigMan(-maxMantissa, 0);
-            CHECK(bigMan == mulRatio(bigMan, maxUInt, maxUInt, true));
-            // rounding mode shouldn't matter as the result is exact
-            CHECK(bigMan == mulRatio(bigMan, maxUInt, maxUInt, false));
-        }
-
-        {
-            // small amounts
-            IOUAmount tiny(minMantissa, minExponent);
-            // Round up should give the smallest allowable number
-            CHECK(tiny == mulRatio(tiny, 1, maxUInt, true));
-            CHECK(tiny == mulRatio(tiny, maxUInt - 1, maxUInt, true));
-            // rounding down should be zero
-            CHECK(beast::zero == mulRatio(tiny, 1, maxUInt, false));
-            CHECK(
-                beast::zero == mulRatio(tiny, maxUInt - 1, maxUInt, false));
-
-            // tiny negative numbers
-            IOUAmount tinyNeg(-minMantissa, minExponent);
-            // Round up should give zero
-            CHECK(beast::zero == mulRatio(tinyNeg, 1, maxUInt, true));
-            CHECK(
-                beast::zero == mulRatio(tinyNeg, maxUInt - 1, maxUInt, true));
-            // rounding down should be tiny
-            CHECK(tinyNeg == mulRatio(tinyNeg, 1, maxUInt, false));
-            CHECK(
-                tinyNeg == mulRatio(tinyNeg, maxUInt - 1, maxUInt, false));
-        }
-
-        {  // rounding
-            {
-                IOUAmount one(1, 0);
-                auto const rup = mulRatio(one, maxUInt - 1, maxUInt, true);
-                auto const rdown = mulRatio(one, maxUInt - 1, maxUInt, false);
-                CHECK(rup.mantissa() - rdown.mantissa() == 1);
-            }
-            {
-                IOUAmount big(maxMantissa, maxExponent);
-                auto const rup = mulRatio(big, maxUInt - 1, maxUInt, true);
-                auto const rdown = mulRatio(big, maxUInt - 1, maxUInt, false);
-                CHECK(rup.mantissa() - rdown.mantissa() == 1);
-            }
-
-            {
-                IOUAmount negOne(-1, 0);
-                auto const rup = mulRatio(negOne, maxUInt - 1, maxUInt, true);
-                auto const rdown =
-                    mulRatio(negOne, maxUInt - 1, maxUInt, false);
-                CHECK(rup.mantissa() - rdown.mantissa() == 1);
-            }
-        }
-
-        {
-            // division by zero
-            IOUAmount one(1, 0);
-            CHECK_THROWS(mulRatio(one, 1, 0, true));
-        }
-
-        {
-            // overflow
-            IOUAmount big(maxMantissa, maxExponent);
-            CHECK_THROWS(mulRatio(big, 2, 0, true));
-        }
-    }
-}
-
-TEST_SUITE_END();
-
-}  // namespace ripple

src/doctest/basics/Number_test.cpp

@@ -1,809 +0,0 @@
-#include <xrpl/basics/Number.h>
-#include <xrpl/protocol/IOUAmount.h>
-#include <xrpl/protocol/STAmount.h>
-
-#include <doctest/doctest.h>
-
-#include <sstream>
-#include <tuple>
-
-using xrpl::IOUAmount;
-using xrpl::Issue;
-using xrpl::Number;
-using xrpl::NumberRoundModeGuard;
-using xrpl::NumberSO;
-using xrpl::saveNumberRoundMode;
-using xrpl::STAmount;
-using xrpl::XRPAmount;
-
-namespace ripple {
-
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("Number - zero")
-{
-    Number const z{0, 0};
-
-    CHECK(z.mantissa() == 0);
-    CHECK(z.exponent() == Number{}.exponent());
-
-    CHECK((z + z) == z);
-    CHECK((z - z) == z);
-    CHECK(z == -z);
-}
-
-TEST_CASE("Number - test_limits")
-{
-    bool caught = false;
-    try
-    {
-        Number x{10'000'000'000'000'000, 32768};
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-    Number x{10'000'000'000'000'000, 32767};
-    CHECK((x == Number{1'000'000'000'000'000, 32768}));
-    Number z{1'000'000'000'000'000, -32769};
-    CHECK(z == Number{});
-    Number y{1'000'000'000'000'001'500, 32000};
-    CHECK((y == Number{1'000'000'000'000'002, 32003}));
-    Number m{std::numeric_limits<std::int64_t>::min()};
-    CHECK((m == Number{-9'223'372'036'854'776, 3}));
-    Number M{std::numeric_limits<std::int64_t>::max()};
-    CHECK((M == Number{9'223'372'036'854'776, 3}));
-    caught = false;
-    try
-    {
-        Number q{99'999'999'999'999'999, 32767};
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - test_add")
-{
-    using Case = std::tuple<Number, Number, Number>;
-    Case c[]{
-        {Number{1'000'000'000'000'000, -15},
-         Number{6'555'555'555'555'555, -29},
-         Number{1'000'000'000'000'066, -15}},
-        {Number{-1'000'000'000'000'000, -15},
-         Number{-6'555'555'555'555'555, -29},
-         Number{-1'000'000'000'000'066, -15}},
-        {Number{-1'000'000'000'000'000, -15},
-         Number{6'555'555'555'555'555, -29},
-         Number{-9'999'999'999'999'344, -16}},
-        {Number{-6'555'555'555'555'555, -29},
-         Number{1'000'000'000'000'000, -15},
-         Number{9'999'999'999'999'344, -16}},
-        {Number{}, Number{5}, Number{5}},
-        {Number{5'555'555'555'555'555, -32768},
-         Number{-5'555'555'555'555'554, -32768},
-         Number{0}},
-        {Number{-9'999'999'999'999'999, -31},
-         Number{1'000'000'000'000'000, -15},
-         Number{9'999'999'999'999'990, -16}}};
-    for (auto const& [x, y, z] : c)
-        CHECK(x + y == z);
-    bool caught = false;
-    try
-    {
-        Number{9'999'999'999'999'999, 32768} +
-            Number{5'000'000'000'000'000, 32767};
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - test_sub")
-{
-    using Case = std::tuple<Number, Number, Number>;
-    Case c[]{
-        {Number{1'000'000'000'000'000, -15},
-         Number{6'555'555'555'555'555, -29},
-         Number{9'999'999'999'999'344, -16}},
-        {Number{6'555'555'555'555'555, -29},
-         Number{1'000'000'000'000'000, -15},
-         Number{-9'999'999'999'999'344, -16}},
-        {Number{1'000'000'000'000'000, -15},
-         Number{1'000'000'000'000'000, -15},
-         Number{0}},
-        {Number{1'000'000'000'000'000, -15},
-         Number{1'000'000'000'000'001, -15},
-         Number{-1'000'000'000'000'000, -30}},
-        {Number{1'000'000'000'000'001, -15},
-         Number{1'000'000'000'000'000, -15},
-         Number{1'000'000'000'000'000, -30}}};
-    for (auto const& [x, y, z] : c)
-        CHECK(x - y == z);
-}
-
-TEST_CASE("Number - test_mul")
-{
-    using Case = std::tuple<Number, Number, Number>;
-    saveNumberRoundMode save{Number::setround(Number::to_nearest)};
-    {
-        Case c[]{
-            {Number{7}, Number{8}, Number{56}},
-            {Number{1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{2000000000000000, -15}},
-            {Number{-1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{-2000000000000000, -15}},
-            {Number{-1414213562373095, -15},
-             Number{-1414213562373095, -15},
-             Number{2000000000000000, -15}},
-            {Number{3214285714285706, -15},
-             Number{3111111111111119, -15},
-             Number{1000000000000000, -14}},
-            {Number{1000000000000000, -32768},
-             Number{1000000000000000, -32768},
-             Number{0}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x * y == z);
-    }
-    Number::setround(Number::towards_zero);
-    {
-        Case c[]{
-            {Number{7}, Number{8}, Number{56}},
-            {Number{1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{1999999999999999, -15}},
-            {Number{-1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{-1999999999999999, -15}},
-            {Number{-1414213562373095, -15},
-             Number{-1414213562373095, -15},
-             Number{1999999999999999, -15}},
-            {Number{3214285714285706, -15},
-             Number{3111111111111119, -15},
-             Number{9999999999999999, -15}},
-            {Number{1000000000000000, -32768},
-             Number{1000000000000000, -32768},
-             Number{0}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x * y == z);
-    }
-    Number::setround(Number::downward);
-    {
-        Case c[]{
-            {Number{7}, Number{8}, Number{56}},
-            {Number{1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{1999999999999999, -15}},
-            {Number{-1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{-2000000000000000, -15}},
-            {Number{-1414213562373095, -15},
-             Number{-1414213562373095, -15},
-             Number{1999999999999999, -15}},
-            {Number{3214285714285706, -15},
-             Number{3111111111111119, -15},
-             Number{9999999999999999, -15}},
-            {Number{1000000000000000, -32768},
-             Number{1000000000000000, -32768},
-             Number{0}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x * y == z);
-    }
-    Number::setround(Number::upward);
-    {
-        Case c[]{
-            {Number{7}, Number{8}, Number{56}},
-            {Number{1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{2000000000000000, -15}},
-            {Number{-1414213562373095, -15},
-             Number{1414213562373095, -15},
-             Number{-1999999999999999, -15}},
-            {Number{-1414213562373095, -15},
-             Number{-1414213562373095, -15},
-             Number{2000000000000000, -15}},
-            {Number{3214285714285706, -15},
-             Number{3111111111111119, -15},
-             Number{1000000000000000, -14}},
-            {Number{1000000000000000, -32768},
-             Number{1000000000000000, -32768},
-             Number{0}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x * y == z);
-    }
-    bool caught = false;
-    try
-    {
-        Number{9'999'999'999'999'999, 32768} *
-            Number{5'000'000'000'000'000, 32767};
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - test_div")
-{
-    using Case = std::tuple<Number, Number, Number>;
-    saveNumberRoundMode save{Number::setround(Number::to_nearest)};
-    {
-        Case c[]{
-            {Number{1}, Number{2}, Number{5, -1}},
-            {Number{1}, Number{10}, Number{1, -1}},
-            {Number{1}, Number{-10}, Number{-1, -1}},
-            {Number{0}, Number{100}, Number{0}},
-            {Number{1414213562373095, -10},
-             Number{1414213562373095, -10},
-             Number{1}},
-            {Number{9'999'999'999'999'999},
-             Number{1'000'000'000'000'000},
-             Number{9'999'999'999'999'999, -15}},
-            {Number{2}, Number{3}, Number{6'666'666'666'666'667, -16}},
-            {Number{-2}, Number{3}, Number{-6'666'666'666'666'667, -16}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x / y == z);
-    }
-    Number::setround(Number::towards_zero);
-    {
-        Case c[]{
-            {Number{1}, Number{2}, Number{5, -1}},
-            {Number{1}, Number{10}, Number{1, -1}},
-            {Number{1}, Number{-10}, Number{-1, -1}},
-            {Number{0}, Number{100}, Number{0}},
-            {Number{1414213562373095, -10},
-             Number{1414213562373095, -10},
-             Number{1}},
-            {Number{9'999'999'999'999'999},
-             Number{1'000'000'000'000'000},
-             Number{9'999'999'999'999'999, -15}},
-            {Number{2}, Number{3}, Number{6'666'666'666'666'666, -16}},
-            {Number{-2}, Number{3}, Number{-6'666'666'666'666'666, -16}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x / y == z);
-    }
-    Number::setround(Number::downward);
-    {
-        Case c[]{
-            {Number{1}, Number{2}, Number{5, -1}},
-            {Number{1}, Number{10}, Number{1, -1}},
-            {Number{1}, Number{-10}, Number{-1, -1}},
-            {Number{0}, Number{100}, Number{0}},
-            {Number{1414213562373095, -10},
-             Number{1414213562373095, -10},
-             Number{1}},
-            {Number{9'999'999'999'999'999},
-             Number{1'000'000'000'000'000},
-             Number{9'999'999'999'999'999, -15}},
-            {Number{2}, Number{3}, Number{6'666'666'666'666'666, -16}},
-            {Number{-2}, Number{3}, Number{-6'666'666'666'666'667, -16}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x / y == z);
-    }
-    Number::setround(Number::upward);
-    {
-        Case c[]{
-            {Number{1}, Number{2}, Number{5, -1}},
-            {Number{1}, Number{10}, Number{1, -1}},
-            {Number{1}, Number{-10}, Number{-1, -1}},
-            {Number{0}, Number{100}, Number{0}},
-            {Number{1414213562373095, -10},
-             Number{1414213562373095, -10},
-             Number{1}},
-            {Number{9'999'999'999'999'999},
-             Number{1'000'000'000'000'000},
-             Number{9'999'999'999'999'999, -15}},
-            {Number{2}, Number{3}, Number{6'666'666'666'666'667, -16}},
-            {Number{-2}, Number{3}, Number{-6'666'666'666'666'666, -16}}};
-        for (auto const& [x, y, z] : c)
-            CHECK(x / y == z);
-    }
-    bool caught = false;
-    try
-    {
-        Number{1000000000000000, -15} / Number{0};
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - test_root")
-{
-    using Case = std::tuple<Number, unsigned, Number>;
-    Case c[]{
-        {Number{2}, 2, Number{1414213562373095, -15}},
-        {Number{2'000'000}, 2, Number{1414213562373095, -12}},
-        {Number{2, -30}, 2, Number{1414213562373095, -30}},
-        {Number{-27}, 3, Number{-3}},
-        {Number{1}, 5, Number{1}},
-        {Number{-1}, 0, Number{1}},
-        {Number{5, -1}, 0, Number{0}},
-        {Number{0}, 5, Number{0}},
-        {Number{5625, -4}, 2, Number{75, -2}}};
-    for (auto const& [x, y, z] : c)
-        CHECK((root(x, y) == z));
-    bool caught = false;
-    try
-    {
-        (void)root(Number{-2}, 0);
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-    caught = false;
-    try
-    {
-        (void)root(Number{-2}, 4);
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - test_power1")
-{
-    using Case = std::tuple<Number, unsigned, Number>;
-    Case c[]{
-        {Number{64}, 0, Number{1}},
-        {Number{64}, 1, Number{64}},
-        {Number{64}, 2, Number{4096}},
-        {Number{-64}, 2, Number{4096}},
-        {Number{64}, 3, Number{262144}},
-        {Number{-64}, 3, Number{-262144}}};
-    for (auto const& [x, y, z] : c)
-        CHECK((power(x, y) == z));
-}
-
-TEST_CASE("Number - test_power2")
-{
-    using Case = std::tuple<Number, unsigned, unsigned, Number>;
-    Case c[]{
-        {Number{1}, 3, 7, Number{1}},
-        {Number{-1}, 1, 0, Number{1}},
-        {Number{-1, -1}, 1, 0, Number{0}},
-        {Number{16}, 0, 5, Number{1}},
-        {Number{34}, 3, 3, Number{34}},
-        {Number{4}, 3, 2, Number{8}}};
-    for (auto const& [x, n, d, z] : c)
-        CHECK((power(x, n, d) == z));
-    bool caught = false;
-    try
-    {
-        (void)power(Number{7}, 0, 0);
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-    caught = false;
-    try
-    {
-        (void)power(Number{7}, 1, 0);
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-    caught = false;
-    try
-    {
-        (void)power(Number{-1, -1}, 3, 2);
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - testConversions")
-{
-    IOUAmount x{5, 6};
-    Number y = x;
-    CHECK((y == Number{5, 6}));
-    IOUAmount z{y};
-    CHECK(x == z);
-    XRPAmount xrp{500};
-    STAmount st = xrp;
-    Number n = st;
-    CHECK(XRPAmount{n} == xrp);
-    IOUAmount x0{0, 0};
-    Number y0 = x0;
-    CHECK((y0 == Number{0}));
-    IOUAmount z0{y0};
-    CHECK(x0 == z0);
-    XRPAmount xrp0{0};
-    Number n0 = xrp0;
-    CHECK(n0 == Number{0});
-    XRPAmount xrp1{n0};
-    CHECK(xrp1 == xrp0);
-}
-
-TEST_CASE("Number - test_to_integer")
-{
-    using Case = std::tuple<Number, std::int64_t>;
-    saveNumberRoundMode save{Number::setround(Number::to_nearest)};
-    {
-        Case c[]{
-            {Number{0}, 0},
-            {Number{1}, 1},
-            {Number{2}, 2},
-            {Number{3}, 3},
-            {Number{-1}, -1},
-            {Number{-2}, -2},
-            {Number{-3}, -3},
-            {Number{10}, 10},
-            {Number{99}, 99},
-            {Number{1155}, 1155},
-            {Number{9'999'999'999'999'999, 0}, 9'999'999'999'999'999},
-            {Number{9'999'999'999'999'999, 1}, 99'999'999'999'999'990},
-            {Number{9'999'999'999'999'999, 2}, 999'999'999'999'999'900},
-            {Number{-9'999'999'999'999'999, 2}, -999'999'999'999'999'900},
-            {Number{15, -1}, 2},
-            {Number{14, -1}, 1},
-            {Number{16, -1}, 2},
-            {Number{25, -1}, 2},
-            {Number{6, -1}, 1},
-            {Number{5, -1}, 0},
-            {Number{4, -1}, 0},
-            {Number{-15, -1}, -2},
-            {Number{-14, -1}, -1},
-            {Number{-16, -1}, -2},
-            {Number{-25, -1}, -2},
-            {Number{-6, -1}, -1},
-            {Number{-5, -1}, 0},
-            {Number{-4, -1}, 0}};
-        for (auto const& [x, y] : c)
-        {
-            auto j = static_cast<std::int64_t>(x);
-            CHECK(j == y);
-        }
-    }
-    auto prev_mode = Number::setround(Number::towards_zero);
-    CHECK(prev_mode == Number::to_nearest);
-    {
-        Case c[]{
-            {Number{0}, 0},
-            {Number{1}, 1},
-            {Number{2}, 2},
-            {Number{3}, 3},
-            {Number{-1}, -1},
-            {Number{-2}, -2},
-            {Number{-3}, -3},
-            {Number{10}, 10},
-            {Number{99}, 99},
-            {Number{1155}, 1155},
-            {Number{9'999'999'999'999'999, 0}, 9'999'999'999'999'999},
-            {Number{9'999'999'999'999'999, 1}, 99'999'999'999'999'990},
-            {Number{9'999'999'999'999'999, 2}, 999'999'999'999'999'900},
-            {Number{-9'999'999'999'999'999, 2}, -999'999'999'999'999'900},
-            {Number{15, -1}, 1},
-            {Number{14, -1}, 1},
-            {Number{16, -1}, 1},
-            {Number{25, -1}, 2},
-            {Number{6, -1}, 0},
-            {Number{5, -1}, 0},
-            {Number{4, -1}, 0},
-            {Number{-15, -1}, -1},
-            {Number{-14, -1}, -1},
-            {Number{-16, -1}, -1},
-            {Number{-25, -1}, -2},
-            {Number{-6, -1}, 0},
-            {Number{-5, -1}, 0},
-            {Number{-4, -1}, 0}};
-        for (auto const& [x, y] : c)
-        {
-            auto j = static_cast<std::int64_t>(x);
-            CHECK(j == y);
-        }
-    }
-    prev_mode = Number::setround(Number::downward);
-    CHECK(prev_mode == Number::towards_zero);
-    {
-        Case c[]{
-            {Number{0}, 0},
-            {Number{1}, 1},
-            {Number{2}, 2},
-            {Number{3}, 3},
-            {Number{-1}, -1},
-            {Number{-2}, -2},
-            {Number{-3}, -3},
-            {Number{10}, 10},
-            {Number{99}, 99},
-            {Number{1155}, 1155},
-            {Number{9'999'999'999'999'999, 0}, 9'999'999'999'999'999},
-            {Number{9'999'999'999'999'999, 1}, 99'999'999'999'999'990},
-            {Number{9'999'999'999'999'999, 2}, 999'999'999'999'999'900},
-            {Number{-9'999'999'999'999'999, 2}, -999'999'999'999'999'900},
-            {Number{15, -1}, 1},
-            {Number{14, -1}, 1},
-            {Number{16, -1}, 1},
-            {Number{25, -1}, 2},
-            {Number{6, -1}, 0},
-            {Number{5, -1}, 0},
-            {Number{4, -1}, 0},
-            {Number{-15, -1}, -2},
-            {Number{-14, -1}, -2},
-            {Number{-16, -1}, -2},
-            {Number{-25, -1}, -3},
-            {Number{-6, -1}, -1},
-            {Number{-5, -1}, -1},
-            {Number{-4, -1}, -1}};
-        for (auto const& [x, y] : c)
-        {
-            auto j = static_cast<std::int64_t>(x);
-            CHECK(j == y);
-        }
-    }
-    prev_mode = Number::setround(Number::upward);
-    CHECK(prev_mode == Number::downward);
-    {
-        Case c[]{
-            {Number{0}, 0},
-            {Number{1}, 1},
-            {Number{2}, 2},
-            {Number{3}, 3},
-            {Number{-1}, -1},
-            {Number{-2}, -2},
-            {Number{-3}, -3},
-            {Number{10}, 10},
-            {Number{99}, 99},
-            {Number{1155}, 1155},
-            {Number{9'999'999'999'999'999, 0}, 9'999'999'999'999'999},
-            {Number{9'999'999'999'999'999, 1}, 99'999'999'999'999'990},
-            {Number{9'999'999'999'999'999, 2}, 999'999'999'999'999'900},
-            {Number{-9'999'999'999'999'999, 2}, -999'999'999'999'999'900},
-            {Number{15, -1}, 2},
-            {Number{14, -1}, 2},
-            {Number{16, -1}, 2},
-            {Number{25, -1}, 3},
-            {Number{6, -1}, 1},
-            {Number{5, -1}, 1},
-            {Number{4, -1}, 1},
-            {Number{-15, -1}, -1},
-            {Number{-14, -1}, -1},
-            {Number{-16, -1}, -1},
-            {Number{-25, -1}, -2},
-            {Number{-6, -1}, 0},
-            {Number{-5, -1}, 0},
-            {Number{-4, -1}, 0}};
-        for (auto const& [x, y] : c)
-        {
-            auto j = static_cast<std::int64_t>(x);
-            CHECK(j == y);
-        }
-    }
-    bool caught = false;
-    try
-    {
-        (void)static_cast<std::int64_t>(Number{9223372036854776, 3});
-    }
-    catch (std::overflow_error const&)
-    {
-        caught = true;
-    }
-    CHECK(caught);
-}
-
-TEST_CASE("Number - test_squelch")
-{
-    Number limit{1, -6};
-    CHECK((squelch(Number{2, -6}, limit) == Number{2, -6}));
-    CHECK((squelch(Number{1, -6}, limit) == Number{1, -6}));
-    CHECK((squelch(Number{9, -7}, limit) == Number{0}));
-    CHECK((squelch(Number{-2, -6}, limit) == Number{-2, -6}));
-    CHECK((squelch(Number{-1, -6}, limit) == Number{-1, -6}));
-    CHECK((squelch(Number{-9, -7}, limit) == Number{0}));
-}
-
-TEST_CASE("Number - testToString")
-{
-    CHECK(to_string(Number(-2, 0)) == "-2");
-    CHECK(to_string(Number(0, 0)) == "0");
-    CHECK(to_string(Number(2, 0)) == "2");
-    CHECK(to_string(Number(25, -3)) == "0.025");
-    CHECK(to_string(Number(-25, -3)) == "-0.025");
-    CHECK(to_string(Number(25, 1)) == "250");
-    CHECK(to_string(Number(-25, 1)) == "-250");
-    CHECK(to_string(Number(2, 20)) == "2000000000000000e5");
-    CHECK(to_string(Number(-2, -20)) == "-2000000000000000e-35");
-}
-
-TEST_CASE("Number - test_relationals")
-{
-    CHECK(!(Number{100} < Number{10}));
-    CHECK(Number{100} > Number{10});
-    CHECK(Number{100} >= Number{10});
-    CHECK(!(Number{100} <= Number{10}));
-}
-
-TEST_CASE("Number - test_stream")
-{
-    Number x{100};
-    std::ostringstream os;
-    os << x;
-    CHECK(os.str() == to_string(x));
-}
-
-TEST_CASE("Number - test_inc_dec")
-{
-    Number x{100};
-    Number y = +x;
-    CHECK(x == y);
-    CHECK(x++ == y);
-    CHECK(x == Number{101});
-    CHECK(x-- == Number{101});
-    CHECK(x == y);
-}
-
-TEST_CASE("Number - test_toSTAmount")
-{
-    NumberSO stNumberSO{true};
-    Issue const issue;
-    Number const n{7'518'783'80596, -5};
-    saveNumberRoundMode const save{Number::setround(Number::to_nearest)};
-    auto res2 = STAmount{issue, n.mantissa(), n.exponent()};
-    CHECK(res2 == STAmount{7518784});
-
-    Number::setround(Number::towards_zero);
-    res2 = STAmount{issue, n.mantissa(), n.exponent()};
-    CHECK(res2 == STAmount{7518783});
-
-    Number::setround(Number::downward);
-    res2 = STAmount{issue, n.mantissa(), n.exponent()};
-    CHECK(res2 == STAmount{7518783});
-
-    Number::setround(Number::upward);
-    res2 = STAmount{issue, n.mantissa(), n.exponent()};
-    CHECK(res2 == STAmount{7518784});
-}
-
-TEST_CASE("Number - test_truncate")
-{
-    CHECK(Number(25, +1).truncate() == Number(250, 0));
-    CHECK(Number(25, 0).truncate() == Number(25, 0));
-    CHECK(Number(25, -1).truncate() == Number(2, 0));
-    CHECK(Number(25, -2).truncate() == Number(0, 0));
-    CHECK(Number(99, -2).truncate() == Number(0, 0));
-
-    CHECK(Number(-25, +1).truncate() == Number(-250, 0));
-    CHECK(Number(-25, 0).truncate() == Number(-25, 0));
-    CHECK(Number(-25, -1).truncate() == Number(-2, 0));
-    CHECK(Number(-25, -2).truncate() == Number(0, 0));
-    CHECK(Number(-99, -2).truncate() == Number(0, 0));
-
-    CHECK(Number(0, 0).truncate() == Number(0, 0));
-    CHECK(Number(0, 30000).truncate() == Number(0, 0));
-    CHECK(Number(0, -30000).truncate() == Number(0, 0));
-    CHECK(Number(100, -30000).truncate() == Number(0, 0));
-    CHECK(Number(100, -30000).truncate() == Number(0, 0));
-    CHECK(Number(-100, -30000).truncate() == Number(0, 0));
-    CHECK(Number(-100, -30000).truncate() == Number(0, 0));
-}
-
-TEST_CASE("Number - Rounding")
-{
-    // Test that rounding works as expected.
-
-    using NumberRoundings = std::map<Number::rounding_mode, std::int64_t>;
-
-    std::map<Number, NumberRoundings> const expected{
-        // Positive numbers
-        {Number{13, -1},
-         {{Number::to_nearest, 1},
-          {Number::towards_zero, 1},
-          {Number::downward, 1},
-          {Number::upward, 2}}},
-        {Number{23, -1},
-         {{Number::to_nearest, 2},
-          {Number::towards_zero, 2},
-          {Number::downward, 2},
-          {Number::upward, 3}}},
-        {Number{15, -1},
-         {{Number::to_nearest, 2},
-          {Number::towards_zero, 1},
-          {Number::downward, 1},
-          {Number::upward, 2}}},
-        {Number{25, -1},
-         {{Number::to_nearest, 2},
-          {Number::towards_zero, 2},
-          {Number::downward, 2},
-          {Number::upward, 3}}},
-        {Number{152, -2},
-         {{Number::to_nearest, 2},
-          {Number::towards_zero, 1},
-          {Number::downward, 1},
-          {Number::upward, 2}}},
-        {Number{252, -2},
-         {{Number::to_nearest, 3},
-          {Number::towards_zero, 2},
-          {Number::downward, 2},
-          {Number::upward, 3}}},
-        {Number{17, -1},
-         {{Number::to_nearest, 2},
-          {Number::towards_zero, 1},
-          {Number::downward, 1},
-          {Number::upward, 2}}},
-        {Number{27, -1},
-         {{Number::to_nearest, 3},
-          {Number::towards_zero, 2},
-          {Number::downward, 2},
-          {Number::upward, 3}}},
-
-        // Negative numbers
-        {Number{-13, -1},
-         {{Number::to_nearest, -1},
-          {Number::towards_zero, -1},
-          {Number::downward, -2},
-          {Number::upward, -1}}},
-        {Number{-23, -1},
-         {{Number::to_nearest, -2},
-          {Number::towards_zero, -2},
-          {Number::downward, -3},
-          {Number::upward, -2}}},
-        {Number{-15, -1},
-         {{Number::to_nearest, -2},
-          {Number::towards_zero, -1},
-          {Number::downward, -2},
-          {Number::upward, -1}}},
-        {Number{-25, -1},
-         {{Number::to_nearest, -2},
-          {Number::towards_zero, -2},
-          {Number::downward, -3},
-          {Number::upward, -2}}},
-        {Number{-152, -2},
-         {{Number::to_nearest, -2},
-          {Number::towards_zero, -1},
-          {Number::downward, -2},
-          {Number::upward, -1}}},
-        {Number{-252, -2},
-         {{Number::to_nearest, -3},
-          {Number::towards_zero, -2},
-          {Number::downward, -3},
-          {Number::upward, -2}}},
-        {Number{-17, -1},
-         {{Number::to_nearest, -2},
-          {Number::towards_zero, -1},
-          {Number::downward, -2},
-          {Number::upward, -1}}},
-        {Number{-27, -1},
-         {{Number::to_nearest, -3},
-          {Number::towards_zero, -2},
-          {Number::downward, -3},
-          {Number::upward, -2}}},
-    };
-
-    for (auto const& [num, roundings] : expected)
-    {
-        for (auto const& [mode, val] : roundings)
-        {
-            NumberRoundModeGuard g{mode};
-            auto const res = static_cast<std::int64_t>(num);
-            auto const message = to_string(num) + " with mode " + std::to_string(mode) +
-                    " expected " + std::to_string(val) + " got " +
-                    std::to_string(res);
-            CHECK_MESSAGE(res == val, message);
-        }
-    }
-}
-
-TEST_SUITE_END();
-
-}  // namespace ripple

src/doctest/basics/XRPAmount_test.cpp

@@ -1,588 +0,0 @@
-#include <doctest/doctest.h>
-#include <xrpl/protocol/XRPAmount.h>
-
-using xrpl::DROPS_PER_XRP;
-using xrpl::mulRatio;
-using xrpl::XRPAmount;
-
-namespace ripple {
-
-TEST_SUITE_BEGIN("basics");
-
-TEST_CASE("signum")
-{
-    for (auto i : {-1, 0, 1})
-    {
-        CAPTURE(i);
-        XRPAmount const x(i);
-        if (i < 0)
-            CHECK(x.signum() < 0);
-        else if (i > 0)
-            CHECK(x.signum() > 0);
-        else
-            CHECK(x.signum() == 0);
-    }
-}
-
-TEST_CASE("beast::Zero Comparisons")
-{
-using beast::zero;
-
-        for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            CHECK((i == 0) == (x == zero));
-            CHECK((i != 0) == (x != zero));
-            CHECK((i < 0) == (x < zero));
-            CHECK((i > 0) == (x > zero));
-            CHECK((i <= 0) == (x <= zero));
-            CHECK((i >= 0) == (x >= zero));
-
-            CHECK((0 == i) == (zero == x));
-            CHECK((0 != i) == (zero != x));
-            CHECK((0 < i) == (zero < x));
-            CHECK((0 > i) == (zero > x));
-            CHECK((0 <= i) == (zero <= x));
-            CHECK((0 >= i) == (zero >= x));
-        }
-}
-
-TEST_CASE("XRP Comparisons")
-{
-for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            for (auto j : {-1, 0, 1})
-            {
-                XRPAmount const y(j);
-
-                CHECK((i == j) == (x == y));
-                CHECK((i != j) == (x != y));
-                CHECK((i < j) == (x < y));
-                CHECK((i > j) == (x > y));
-                CHECK((i <= j) == (x <= y));
-                CHECK((i >= j) == (x >= y));
-            }
-        }
-}
-
-TEST_CASE("Addition & Subtraction")
-{
-for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            for (auto j : {-1, 0, 1})
-            {
-                XRPAmount const y(j);
-
-                CHECK(XRPAmount(i + j) == (x + y));
-                CHECK(XRPAmount(i - j) == (x - y));
-
-                CHECK((x + y) == (y + x));  // addition is commutative
-            }
-        }
-}
-
-TEST_CASE("XRPAmount_test - testDecimal")
-{
-// Tautology
-        CHECK(DROPS_PER_XRP.decimalXRP() == 1);
-
-        XRPAmount test{1};
-        CHECK(test.decimalXRP() == 0.000001);
-
-        test = -test;
-        CHECK(test.decimalXRP() == -0.000001);
-
-        test = 100'000'000;
-        CHECK(test.decimalXRP() == 100);
-
-        test = -test;
-        CHECK(test.decimalXRP() == -100);
-}
-
-TEST_CASE("XRPAmount_test - testFunctions")
-{
-// Explicitly test every defined function for the XRPAmount class
-        // since some of them are templated, but not used anywhere else.
-        auto make = [&](auto x) -> XRPAmount { return XRPAmount{x}; };
-
-        XRPAmount defaulted;
-        (void)defaulted;
-        XRPAmount test{0};
-        CHECK(test.drops() == 0);
-
-        test = make(beast::zero);
-        CHECK(test.drops() == 0);
-
-        test = beast::zero;
-        CHECK(test.drops() == 0);
-
-        test = make(100);
-        CHECK(test.drops() == 100);
-
-        test = make(100u);
-        CHECK(test.drops() == 100);
-
-        XRPAmount const targetSame{200u};
-        test = make(targetSame);
-        CHECK(test.drops() == 200);
-        CHECK(test == targetSame);
-        CHECK(test < XRPAmount{1000});
-        CHECK(test > XRPAmount{100});
-
-        test = std::int64_t(200);
-        CHECK(test.drops() == 200);
-        test = std::uint32_t(300);
-        CHECK(test.drops() == 300);
-
-        test = targetSame;
-        CHECK(test.drops() == 200);
-        auto testOther = test.dropsAs<std::uint32_t>();
-        CHECK(testOther);
-        CHECK(*testOther == 200);
-        test = std::numeric_limits<std::uint64_t>::max();
-        testOther = test.dropsAs<std::uint32_t>();
-        CHECK(!testOther);
-        test = -1;
-        testOther = test.dropsAs<std::uint32_t>();
-        CHECK(!testOther);
-
-        test = targetSame * 2;
-        CHECK(test.drops() == 400);
-        test = 3 * targetSame;
-        CHECK(test.drops() == 600);
-        test = 20;
-        CHECK(test.drops() == 20);
-
-        test += targetSame;
-        CHECK(test.drops() == 220);
-
-        test -= targetSame;
-        CHECK(test.drops() == 20);
-
-        test *= 5;
-        CHECK(test.drops() == 100);
-        test = 50;
-        CHECK(test.drops() == 50);
-        test -= 39;
-        CHECK(test.drops() == 11);
-
-        // legal with signed
-        test = -test;
-        CHECK(test.drops() == -11);
-        CHECK(test.signum() == -1);
-        CHECK(to_string(test) == "-11");
-
-        CHECK(test);
-        test = 0;
-        CHECK(!test);
-        CHECK(test.signum() == 0);
-        test = targetSame;
-        CHECK(test.signum() == 1);
-        CHECK(to_string(test) == "200");
-}
-
-TEST_CASE("mulRatio")
-{
-constexpr auto maxUInt32 = std::numeric_limits<std::uint32_t>::max();
-        constexpr auto maxXRP =
-            std::numeric_limits<XRPAmount::value_type>::max();
-        constexpr auto minXRP =
-            std::numeric_limits<XRPAmount::value_type>::min();
-
-        {
-            // multiply by a number that would overflow then divide by the same
-            // number, and check we didn't lose any value
-            XRPAmount big(maxXRP);
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, true));
-            // rounding mode shouldn't matter as the result is exact
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, false));
-
-            // multiply and divide by values that would overflow if done
-            // naively, and check that it gives the correct answer
-            big -= 0xf;  // Subtract a little so it's divisable by 4
-            CHECK(
-                mulRatio(big, 3, 4, false).value() == (big.value() / 4) * 3);
-            CHECK(
-                mulRatio(big, 3, 4, true).value() == (big.value() / 4) * 3);
-            CHECK((big.value() * 3) / 4 != (big.value() / 4) * 3);
-        }
-
-        {
-            // Similar test as above, but for negative values
-            XRPAmount big(minXRP);
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, true));
-            // rounding mode shouldn't matter as the result is exact
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, false));
-
-            // multiply and divide by values that would overflow if done
-            // naively, and check that it gives the correct answer
-            CHECK(
-                mulRatio(big, 3, 4, false).value() == (big.value() / 4) * 3);
-            CHECK(
-                mulRatio(big, 3, 4, true).value() == (big.value() / 4) * 3);
-            CHECK((big.value() * 3) / 4 != (big.value() / 4) * 3);
-        }
-
-        {
-            // small amounts
-            XRPAmount tiny(1);
-            // Round up should give the smallest allowable number
-            CHECK(tiny == mulRatio(tiny, 1, maxUInt32, true));
-            // rounding down should be zero
-            CHECK(beast::zero == mulRatio(tiny, 1, maxUInt32, false));
-            CHECK(
-                beast::zero == mulRatio(tiny, maxUInt32 - 1, maxUInt32, false));
-
-            // tiny negative numbers
-            XRPAmount tinyNeg(-1);
-            // Round up should give zero
-            CHECK(beast::zero == mulRatio(tinyNeg, 1, maxUInt32, true));
-            CHECK(
-                beast::zero ==
-                mulRatio(tinyNeg, maxUInt32 - 1, maxUInt32, true));
-            // rounding down should be tiny
-            CHECK(
-                tinyNeg == mulRatio(tinyNeg, maxUInt32 - 1, maxUInt32, false));
-        }
-
-        {  // rounding
-            {
-                XRPAmount one(1);
-                auto const rup = mulRatio(one, maxUInt32 - 1, maxUInt32, true);
-                auto const rdown =
-                    mulRatio(one, maxUInt32 - 1, maxUInt32, false);
-                CHECK(rup.drops() - rdown.drops() == 1);
-            }
-
-            {
-                XRPAmount big(maxXRP);
-                auto const rup = mulRatio(big, maxUInt32 - 1, maxUInt32, true);
-                auto const rdown =
-                    mulRatio(big, maxUInt32 - 1, maxUInt32, false);
-                CHECK(rup.drops() - rdown.drops() == 1);
-            }
-
-            {
-                XRPAmount negOne(-1);
-                auto const rup =
-                    mulRatio(negOne, maxUInt32 - 1, maxUInt32, true);
-                auto const rdown =
-                    mulRatio(negOne, maxUInt32 - 1, maxUInt32, false);
-                CHECK(rup.drops() - rdown.drops() == 1);
-            }
-        }
-
-        {
-            // division by zero
-            XRPAmount one(1);
-            CHECK_THROWS(mulRatio(one, 1, 0, true));
-        }
-
-        {
-            // overflow
-            XRPAmount big(maxXRP);
-            CHECK_THROWS(mulRatio(big, 2, 1, true));
-        }
-
-        {
-            // underflow
-            XRPAmount bigNegative(minXRP + 10);
-            CHECK(mulRatio(bigNegative, 2, 1, true) == minXRP);
-        }
-}
-
-TEST_CASE("signum")
-{
-for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            if (i < 0)
-                CHECK(x.signum() < 0);
-            else if (i > 0)
-                CHECK(x.signum() > 0);
-            else
-                CHECK(x.signum() == 0);
-        }
-}
-
-TEST_CASE("beast::Zero Comparisons")
-{
-using beast::zero;
-
-        for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            CHECK((i == 0) == (x == zero));
-            CHECK((i != 0) == (x != zero));
-            CHECK((i < 0) == (x < zero));
-            CHECK((i > 0) == (x > zero));
-            CHECK((i <= 0) == (x <= zero));
-            CHECK((i >= 0) == (x >= zero));
-
-            CHECK((0 == i) == (zero == x));
-            CHECK((0 != i) == (zero != x));
-            CHECK((0 < i) == (zero < x));
-            CHECK((0 > i) == (zero > x));
-            CHECK((0 <= i) == (zero <= x));
-            CHECK((0 >= i) == (zero >= x));
-        }
-}
-
-TEST_CASE("XRP Comparisons")
-{
-for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            for (auto j : {-1, 0, 1})
-            {
-                XRPAmount const y(j);
-
-                CHECK((i == j) == (x == y));
-                CHECK((i != j) == (x != y));
-                CHECK((i < j) == (x < y));
-                CHECK((i > j) == (x > y));
-                CHECK((i <= j) == (x <= y));
-                CHECK((i >= j) == (x >= y));
-            }
-        }
-}
-
-TEST_CASE("Addition & Subtraction")
-{
-for (auto i : {-1, 0, 1})
-        {
-            XRPAmount const x(i);
-
-            for (auto j : {-1, 0, 1})
-            {
-                XRPAmount const y(j);
-
-                CHECK(XRPAmount(i + j) == (x + y));
-                CHECK(XRPAmount(i - j) == (x - y));
-
-                CHECK((x + y) == (y + x));  // addition is commutative
-            }
-        }
-}
-
-TEST_CASE("XRPAmount_test - testDecimal")
-{
-// Tautology
-        CHECK(DROPS_PER_XRP.decimalXRP() == 1);
-
-        XRPAmount test{1};
-        CHECK(test.decimalXRP() == 0.000001);
-
-        test = -test;
-        CHECK(test.decimalXRP() == -0.000001);
-
-        test = 100'000'000;
-        CHECK(test.decimalXRP() == 100);
-
-        test = -test;
-        CHECK(test.decimalXRP() == -100);
-}
-
-TEST_CASE("XRPAmount_test - testFunctions")
-{
-// Explicitly test every defined function for the XRPAmount class
-        // since some of them are templated, but not used anywhere else.
-        auto make = [&](auto x) -> XRPAmount { return XRPAmount{x}; };
-
-        XRPAmount defaulted;
-        (void)defaulted;
-        XRPAmount test{0};
-        CHECK(test.drops() == 0);
-
-        test = make(beast::zero);
-        CHECK(test.drops() == 0);
-
-        test = beast::zero;
-        CHECK(test.drops() == 0);
-
-        test = make(100);
-        CHECK(test.drops() == 100);
-
-        test = make(100u);
-        CHECK(test.drops() == 100);
-
-        XRPAmount const targetSame{200u};
-        test = make(targetSame);
-        CHECK(test.drops() == 200);
-        CHECK(test == targetSame);
-        CHECK(test < XRPAmount{1000});
-        CHECK(test > XRPAmount{100});
-
-        test = std::int64_t(200);
-        CHECK(test.drops() == 200);
-        test = std::uint32_t(300);
-        CHECK(test.drops() == 300);
-
-        test = targetSame;
-        CHECK(test.drops() == 200);
-        auto testOther = test.dropsAs<std::uint32_t>();
-        CHECK(testOther);
-        CHECK(*testOther == 200);
-        test = std::numeric_limits<std::uint64_t>::max();
-        testOther = test.dropsAs<std::uint32_t>();
-        CHECK(!testOther);
-        test = -1;
-        testOther = test.dropsAs<std::uint32_t>();
-        CHECK(!testOther);
-
-        test = targetSame * 2;
-        CHECK(test.drops() == 400);
-        test = 3 * targetSame;
-        CHECK(test.drops() == 600);
-        test = 20;
-        CHECK(test.drops() == 20);
-
-        test += targetSame;
-        CHECK(test.drops() == 220);
-
-        test -= targetSame;
-        CHECK(test.drops() == 20);
-
-        test *= 5;
-        CHECK(test.drops() == 100);
-        test = 50;
-        CHECK(test.drops() == 50);
-        test -= 39;
-        CHECK(test.drops() == 11);
-
-        // legal with signed
-        test = -test;
-        CHECK(test.drops() == -11);
-        CHECK(test.signum() == -1);
-        CHECK(to_string(test) == "-11");
-
-        CHECK(test);
-        test = 0;
-        CHECK(!test);
-        CHECK(test.signum() == 0);
-        test = targetSame;
-        CHECK(test.signum() == 1);
-        CHECK(to_string(test) == "200");
-}
-
-TEST_CASE("mulRatio")
-{
-constexpr auto maxUInt32 = std::numeric_limits<std::uint32_t>::max();
-        constexpr auto maxXRP =
-            std::numeric_limits<XRPAmount::value_type>::max();
-        constexpr auto minXRP =
-            std::numeric_limits<XRPAmount::value_type>::min();
-
-        {
-            // multiply by a number that would overflow then divide by the same
-            // number, and check we didn't lose any value
-            XRPAmount big(maxXRP);
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, true));
-            // rounding mode shouldn't matter as the result is exact
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, false));
-
-            // multiply and divide by values that would overflow if done
-            // naively, and check that it gives the correct answer
-            big -= 0xf;  // Subtract a little so it's divisable by 4
-            CHECK(
-                mulRatio(big, 3, 4, false).value() == (big.value() / 4) * 3);
-            CHECK(
-                mulRatio(big, 3, 4, true).value() == (big.value() / 4) * 3);
-            CHECK((big.value() * 3) / 4 != (big.value() / 4) * 3);
-        }
-
-        {
-            // Similar test as above, but for negative values
-            XRPAmount big(minXRP);
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, true));
-            // rounding mode shouldn't matter as the result is exact
-            CHECK(big == mulRatio(big, maxUInt32, maxUInt32, false));
-
-            // multiply and divide by values that would overflow if done
-            // naively, and check that it gives the correct answer
-            CHECK(
-                mulRatio(big, 3, 4, false).value() == (big.value() / 4) * 3);
-            CHECK(
-                mulRatio(big, 3, 4, true).value() == (big.value() / 4) * 3);
-            CHECK((big.value() * 3) / 4 != (big.value() / 4) * 3);
-        }
-
-        {
-            // small amounts
-            XRPAmount tiny(1);
-            // Round up should give the smallest allowable number
-            CHECK(tiny == mulRatio(tiny, 1, maxUInt32, true));
-            // rounding down should be zero
-            CHECK(beast::zero == mulRatio(tiny, 1, maxUInt32, false));
-            CHECK(
-                beast::zero == mulRatio(tiny, maxUInt32 - 1, maxUInt32, false));
-
-            // tiny negative numbers
-            XRPAmount tinyNeg(-1);
-            // Round up should give zero
-            CHECK(beast::zero == mulRatio(tinyNeg, 1, maxUInt32, true));
-            CHECK(
-                beast::zero ==
-                mulRatio(tinyNeg, maxUInt32 - 1, maxUInt32, true));
-            // rounding down should be tiny
-            CHECK(
-                tinyNeg == mulRatio(tinyNeg, maxUInt32 - 1, maxUInt32, false));
-        }
-
-        {  // rounding
-            {
-                XRPAmount one(1);
-                auto const rup = mulRatio(one, maxUInt32 - 1, maxUInt32, true);
-                auto const rdown =
-                    mulRatio(one, maxUInt32 - 1, maxUInt32, false);
-                CHECK(rup.drops() - rdown.drops() == 1);
-            }
-
-            {
-                XRPAmount big(maxXRP);
-                auto const rup = mulRatio(big, maxUInt32 - 1, maxUInt32, true);
-                auto const rdown =
-                    mulRatio(big, maxUInt32 - 1, maxUInt32, false);
-                CHECK(rup.drops() - rdown.drops() == 1);
-            }
-
-            {
-                XRPAmount negOne(-1);
-                auto const rup =
-                    mulRatio(negOne, maxUInt32 - 1, maxUInt32, true);
-                auto const rdown =
-                    mulRatio(negOne, maxUInt32 - 1, maxUInt32, false);
-                CHECK(rup.drops() - rdown.drops() == 1);
-            }
-        }
-
-        {
-            // division by zero
-            XRPAmount one(1);
-            CHECK_THROWS(mulRatio(one, 1, 0, true));
-        }
-
-        {
-            // overflow
-            XRPAmount big(maxXRP);
-            CHECK_THROWS(mulRatio(big, 2, 1, true));
-        }
-
-        {
-            // underflow
-            XRPAmount bigNegative(minXRP + 10);
-            CHECK(mulRatio(bigNegative, 2, 1, true) == minXRP);
-        }
-}
-
-TEST_SUITE_END();
-
-}  // namespace ripple

src/doctest/json/Object_test.cpp

@@ -1,206 +0,0 @@
-#include <xrpl/json/Object.h>
-#include <xrpl/json/Output.h>
-#include <xrpl/json/Writer.h>
-
-#include <doctest/doctest.h>
-
-#include <memory>
-#include <string>
-
-using namespace Json;
-
-TEST_SUITE_BEGIN("JsonObject");
-
-struct ObjectFixture
-{
-    std::string output_;
-    std::unique_ptr<WriterObject> writerObject_;
-
-    Object&
-    makeRoot()
-    {
-        output_.clear();
-        writerObject_ =
-            std::make_unique<WriterObject>(stringWriterObject(output_));
-        return **writerObject_;
-    }
-
-    void
-    expectResult(std::string const& expected)
-    {
-        writerObject_.reset();
-        CHECK(output_ == expected);
-    }
-};
-
-TEST_CASE_FIXTURE(ObjectFixture, "trivial")
-{
-    {
-        auto& root = makeRoot();
-        (void)root;
-    }
-    expectResult("{}");
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "simple")
-{
-    {
-        auto& root = makeRoot();
-        root["hello"] = "world";
-        root["skidoo"] = 23;
-        root["awake"] = false;
-        root["temperature"] = 98.6;
-    }
-
-    expectResult(
-        "{\"hello\":\"world\","
-        "\"skidoo\":23,"
-        "\"awake\":false,"
-        "\"temperature\":98.6}");
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "oneSub")
-{
-    {
-        auto& root = makeRoot();
-        root.setArray("ar");
-    }
-    expectResult("{\"ar\":[]}");
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "subs")
-{
-    {
-        auto& root = makeRoot();
-
-        {
-            // Add an array with three entries.
-            auto array = root.setArray("ar");
-            array.append(23);
-            array.append(false);
-            array.append(23.5);
-        }
-
-        {
-            // Add an object with one entry.
-            auto obj = root.setObject("obj");
-            obj["hello"] = "world";
-        }
-
-        {
-            // Add another object with two entries.
-            Json::Value value;
-            value["h"] = "w";
-            value["f"] = false;
-            root["obj2"] = value;
-        }
-    }
-
-    // Json::Value has an unstable order...
-    auto case1 =
-        "{\"ar\":[23,false,23.5],"
-        "\"obj\":{\"hello\":\"world\"},"
-        "\"obj2\":{\"h\":\"w\",\"f\":false}}";
-    auto case2 =
-        "{\"ar\":[23,false,23.5],"
-        "\"obj\":{\"hello\":\"world\"},"
-        "\"obj2\":{\"f\":false,\"h\":\"w\"}}";
-    writerObject_.reset();
-    CHECK((output_ == case1 || output_ == case2));
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "subsShort")
-{
-    {
-        auto& root = makeRoot();
-
-        {
-            // Add an array with three entries.
-            auto array = root.setArray("ar");
-            array.append(23);
-            array.append(false);
-            array.append(23.5);
-        }
-
-        // Add an object with one entry.
-        root.setObject("obj")["hello"] = "world";
-
-        {
-            // Add another object with two entries.
-            auto object = root.setObject("obj2");
-            object.set("h", "w");
-            object.set("f", false);
-        }
-    }
-    expectResult(
-        "{\"ar\":[23,false,23.5],"
-        "\"obj\":{\"hello\":\"world\"},"
-        "\"obj2\":{\"h\":\"w\",\"f\":false}}");
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "object failure")
-{
-    SUBCASE("object failure assign")
-    {
-        auto& root = makeRoot();
-        auto obj = root.setObject("o1");
-        CHECK_THROWS([&]() { root["fail"] = "complete"; }());
-    }
-    SUBCASE("object failure object")
-    {
-        auto& root = makeRoot();
-        auto obj = root.setObject("o1");
-        CHECK_THROWS([&]() { root.setObject("o2"); }());
-    }
-    SUBCASE("object failure Array")
-    {
-        auto& root = makeRoot();
-        auto obj = root.setArray("o1");
-        CHECK_THROWS([&]() { root.setArray("o2"); }());
-    }
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "array failure")
-{
-    SUBCASE("array failure append")
-    {
-        auto& root = makeRoot();
-        auto array = root.setArray("array");
-        auto subarray = array.appendArray();
-        auto fail = [&]() { array.append("fail"); };
-        CHECK_THROWS(fail());
-    }
-    SUBCASE("array failure appendArray")
-    {
-        auto& root = makeRoot();
-        auto array = root.setArray("array");
-        auto subarray = array.appendArray();
-        auto fail = [&]() { array.appendArray(); };
-        CHECK_THROWS(fail());
-    }
-    SUBCASE("array failure appendObject")
-    {
-        auto& root = makeRoot();
-        auto array = root.setArray("array");
-        auto subarray = array.appendArray();
-        auto fail = [&]() { array.appendObject(); };
-        CHECK_THROWS(fail());
-    }
-}
-
-TEST_CASE_FIXTURE(ObjectFixture, "repeating keys")
-{
-    auto& root = makeRoot();
-    root.set("foo", "bar");
-    root.set("baz", 0);
-    // setting key again throws in !NDEBUG builds
-    auto set_again = [&]() { root.set("foo", "bar"); };
-#ifdef NDEBUG
-    set_again();
-    CHECK(true);  // pass
-#else
-    CHECK_THROWS(set_again());
-#endif
-}
-
-TEST_SUITE_END();

src/doctest/json/main.cpp

@@ -1,5 +0,0 @@
-#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
-#include <doctest/doctest.h>
-
-// This file serves as the main entry point for doctest
-// All test files will be automatically discovered and linked

src/doctest/main.cpp

@@ -1,5 +0,0 @@
-#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
-#include <doctest/doctest.h>
-
-// This file serves as the main entry point for doctest
-// All test files will be automatically discovered and linked

src/doctest/protocol/ApiVersion_test.cpp

@@ -1,34 +0,0 @@
-#include <xrpl/protocol/ApiVersion.h>
-
-#include <doctest/doctest.h>
-
-#include <array>
-#include <cstdint>
-#include <limits>
-#include <optional>
-#include <type_traits>
-#include <utility>
-
-namespace ripple {
-namespace test {
-
-TEST_SUITE_BEGIN("protocol");
-
-TEST_CASE("ApiVersion_test")
-{
-    static_assert(
-        xrpl::RPC::apiMinimumSupportedVersion <=
-        xrpl::RPC::apiMaximumSupportedVersion);
-    static_assert(
-        xrpl::RPC::apiMinimumSupportedVersion <= xrpl::RPC::apiMaximumValidVersion);
-    static_assert(
-        xrpl::RPC::apiMaximumSupportedVersion <= xrpl::RPC::apiMaximumValidVersion);
-    static_assert(xrpl::RPC::apiBetaVersion <= xrpl::RPC::apiMaximumValidVersion);
-
-    CHECK(true);
-}
-
-TEST_SUITE_END();
-
-}  // namespace test
-}  // namespace ripple

src/doctest/protocol/BuildInfo_test.cpp

@@ -1,90 +0,0 @@
-#include <xrpl/protocol/BuildInfo.h>
-
-#include <doctest/doctest.h>
-
-namespace BuildInfo = xrpl::BuildInfo;
-
-namespace ripple {
-
-TEST_SUITE_BEGIN("protocol");
-
-TEST_CASE("BuildInfo_test - EncodeSoftwareVersion")
-{
-
-        auto encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.3-b7");
-
-        // the first two bytes identify the particular implementation, 0x183B
-        CHECK(
-            (encodedVersion & 0xFFFF'0000'0000'0000LLU) ==
-            0x183B'0000'0000'0000LLU);
-
-        // the next three bytes: major version, minor version, patch version,
-        // 0x010203
-        CHECK(
-            (encodedVersion & 0x0000'FFFF'FF00'0000LLU) ==
-            0x0000'0102'0300'0000LLU);
-
-        // the next two bits:
-        {
-            // 01 if a beta
-            CHECK(
-                ((encodedVersion & 0x0000'0000'00C0'0000LLU) >> 22) == 0b01);
-            // 10 if an RC
-            encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.4-rc7");
-            CHECK(
-                ((encodedVersion & 0x0000'0000'00C0'0000LLU) >> 22) == 0b10);
-            // 11 if neither an RC nor a beta
-            encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.5");
-            CHECK(
-                ((encodedVersion & 0x0000'0000'00C0'0000LLU) >> 22) == 0b11);
-        }
-
-        // the next six bits: rc/beta number (1-63)
-        encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.6-b63");
-        CHECK(((encodedVersion & 0x0000'0000'003F'0000LLU) >> 16) == 63);
-
-        // the last two bytes are zeros
-        CHECK((encodedVersion & 0x0000'0000'0000'FFFFLLU) == 0);
-
-        // Test some version strings with wrong formats:
-        // no rc/beta number
-        encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.3-b");
-        CHECK((encodedVersion & 0x0000'0000'00FF'0000LLU) == 0);
-        // rc/beta number out of range
-        encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.3-b64");
-        CHECK((encodedVersion & 0x0000'0000'00FF'0000LLU) == 0);
-
-        // Check that the rc/beta number of a release is 0:
-        encodedVersion = BuildInfo::encodeSoftwareVersion("1.2.6");
-        CHECK((encodedVersion & 0x0000'0000'003F'0000LLU) == 0);
-    
-}
-
-TEST_CASE("BuildInfo_test - IsRippledVersion")
-{
-        auto vFF = 0xFFFF'FFFF'FFFF'FFFFLLU;
-        CHECK(!BuildInfo::isRippledVersion(vFF));
-        auto vRippled = 0x183B'0000'0000'0000LLU;
-        CHECK(BuildInfo::isRippledVersion(vRippled));
-    
-}
-
-TEST_CASE("BuildInfo_test - IsNewerVersion")
-{
-        auto vFF = 0xFFFF'FFFF'FFFF'FFFFLLU;
-        CHECK(!BuildInfo::isNewerVersion(vFF));
-
-        auto v159 = BuildInfo::encodeSoftwareVersion("1.5.9");
-        CHECK(!BuildInfo::isNewerVersion(v159));
-
-        auto vCurrent = BuildInfo::getEncodedVersion();
-        CHECK(!BuildInfo::isNewerVersion(vCurrent));
-
-        auto vMax = BuildInfo::encodeSoftwareVersion("255.255.255");
-        CHECK(BuildInfo::isNewerVersion(vMax));
-    
-}
-
-TEST_SUITE_END();
-
-}  // namespace ripple

src/doctest/protocol/Issue_test.cpp.skip

@@ -1,891 +0,0 @@
-#include <xrpl/basics/UnorderedContainers.h>
-#include <doctest/doctest.h>
-#include <xrpl/protocol/Book.h>
-#include <xrpl/protocol/Issue.h>
-
-#include <sys/types.h>
-
-#include <map>
-#include <optional>
-#include <set>
-#include <typeinfo>
-#include <unordered_set>
-
-#if BEAST_MSVC
-#define STL_SET_HAS_EMPLACE 1
-#else
-#define STL_SET_HAS_EMPLACE 0
-#endif
-
-#ifndef XRPL_ASSETS_ENABLE_STD_HASH
-#if BEAST_MAC || BEAST_IOS
-#define XRPL_ASSETS_ENABLE_STD_HASH 0
-#else
-#define XRPL_ASSETS_ENABLE_STD_HASH 1
-#endif
-#endif
-
-namespace ripple {
-
-namespace {
-
-using Domain = uint256;
-
-using Domain = uint256;
-
-    // Comparison, hash tests for uint60 (via base_uint)
-    template <typename Unsigned>
-    void
-    testUnsigned()
-    {
-        Unsigned const u1(1);
-        Unsigned const u2(2);
-        Unsigned const u3(3);
-
-        REQUIRE(u1 != u2);
-        REQUIRE(u1 < u2);
-        REQUIRE(u1 <= u2);
-        REQUIRE(u2 <= u2);
-        REQUIRE(u2 == u2);
-        REQUIRE(u2 >= u2);
-        REQUIRE(u3 >= u2);
-        REQUIRE(u3 > u2);
-
-        std::hash<Unsigned> hash;
-
-        REQUIRE(hash(u1) == hash(u1));
-        REQUIRE(hash(u2) == hash(u2));
-        REQUIRE(hash(u3) == hash(u3));
-        REQUIRE(hash(u1) != hash(u2));
-        REQUIRE(hash(u1) != hash(u3));
-        REQUIRE(hash(u2) != hash(u3));
-    }
-
-    //--------------------------------------------------------------------------
-
-    // Comparison, hash tests for Issue
-    template <class Issue>
-    void
-    testIssue()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Currency const c3(3);
-        AccountID const i3(3);
-
-        REQUIRE(Issue(c1, i1) != Issue(c2, i1));
-        REQUIRE(Issue(c1, i1) < Issue(c2, i1));
-        REQUIRE(Issue(c1, i1) <= Issue(c2, i1));
-        REQUIRE(Issue(c2, i1) <= Issue(c2, i1));
-        REQUIRE(Issue(c2, i1) == Issue(c2, i1));
-        REQUIRE(Issue(c2, i1) >= Issue(c2, i1));
-        REQUIRE(Issue(c3, i1) >= Issue(c2, i1));
-        REQUIRE(Issue(c3, i1) > Issue(c2, i1));
-        REQUIRE(Issue(c1, i1) != Issue(c1, i2));
-        REQUIRE(Issue(c1, i1) < Issue(c1, i2));
-        REQUIRE(Issue(c1, i1) <= Issue(c1, i2));
-        REQUIRE(Issue(c1, i2) <= Issue(c1, i2));
-        REQUIRE(Issue(c1, i2) == Issue(c1, i2));
-        REQUIRE(Issue(c1, i2) >= Issue(c1, i2));
-        REQUIRE(Issue(c1, i3) >= Issue(c1, i2));
-        REQUIRE(Issue(c1, i3) > Issue(c1, i2));
-
-        std::hash<Issue> hash;
-
-        REQUIRE(hash(Issue(c1, i1)) == hash(Issue(c1, i1)));
-        REQUIRE(hash(Issue(c1, i2)) == hash(Issue(c1, i2)));
-        REQUIRE(hash(Issue(c1, i3)) == hash(Issue(c1, i3)));
-        REQUIRE(hash(Issue(c2, i1)) == hash(Issue(c2, i1)));
-        REQUIRE(hash(Issue(c2, i2)) == hash(Issue(c2, i2)));
-        REQUIRE(hash(Issue(c2, i3)) == hash(Issue(c2, i3)));
-        REQUIRE(hash(Issue(c3, i1)) == hash(Issue(c3, i1)));
-        REQUIRE(hash(Issue(c3, i2)) == hash(Issue(c3, i2)));
-        REQUIRE(hash(Issue(c3, i3)) == hash(Issue(c3, i3)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c1, i2)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c1, i3)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c2, i1)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c2, i2)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c2, i3)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c3, i1)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c3, i2)));
-        REQUIRE(hash(Issue(c1, i1)) != hash(Issue(c3, i3)));
-    }
-
-    template <class Set>
-    void
-    testIssueSet()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Issue const a1(c1, i1);
-        Issue const a2(c2, i2);
-
-        {
-            Set c;
-
-            c.insert(a1);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(a2);
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Issue(c1, i2)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Issue(c1, i1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Issue(c2, i2)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Set c;
-
-            c.insert(a1);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(a2);
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Issue(c1, i2)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Issue(c1, i1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Issue(c2, i2)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-
-#if STL_SET_HAS_EMPLACE
-            c.emplace(c1, i1);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.emplace(c2, i2);
-            if (!REQUIRE(c.size() == 2))
-                return;
-#endif
-        }
-    }
-
-    template <class Map>
-    void
-    testIssueMap()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Issue const a1(c1, i1);
-        Issue const a2(c2, i2);
-
-        {
-            Map c;
-
-            c.insert(std::make_pair(a1, 1));
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(std::make_pair(a2, 2));
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Issue(c1, i2)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Issue(c1, i1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Issue(c2, i2)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Map c;
-
-            c.insert(std::make_pair(a1, 1));
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(std::make_pair(a2, 2));
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Issue(c1, i2)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Issue(c1, i1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Issue(c2, i2)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-    }
-
-    template <class Set>
-    void
-    testIssueDomainSet()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Issue const a1(c1, i1);
-        Issue const a2(c2, i2);
-        uint256 const domain1{1};
-        uint256 const domain2{2};
-
-        Set c;
-
-        c.insert(std::make_pair(a1, domain1));
-        if (!REQUIRE(c.size() == 1))
-            return;
-        c.insert(std::make_pair(a2, domain1));
-        if (!REQUIRE(c.size() == 2))
-            return;
-        c.insert(std::make_pair(a2, domain2));
-        if (!REQUIRE(c.size() == 3))
-            return;
-
-        if (!REQUIRE(c.erase(std::make_pair(Issue(c1, i2), domain1)) == 0))
-            return;
-        if (!REQUIRE(c.erase(std::make_pair(a1, domain1)) == 1))
-            return;
-        if (!REQUIRE(c.erase(std::make_pair(a2, domain1)) == 1))
-            return;
-        if (!REQUIRE(c.erase(std::make_pair(a2, domain2)) == 1))
-            return;
-        if (!REQUIRE(c.empty()))
-            return;
-    }
-
-    template <class Map>
-    void
-    testIssueDomainMap()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Issue const a1(c1, i1);
-        Issue const a2(c2, i2);
-        uint256 const domain1{1};
-        uint256 const domain2{2};
-
-        Map c;
-
-        c.insert(std::make_pair(std::make_pair(a1, domain1), 1));
-        if (!REQUIRE(c.size() == 1))
-            return;
-        c.insert(std::make_pair(std::make_pair(a2, domain1), 2));
-        if (!REQUIRE(c.size() == 2))
-            return;
-        c.insert(std::make_pair(std::make_pair(a2, domain2), 2));
-        if (!REQUIRE(c.size() == 3))
-            return;
-
-        if (!REQUIRE(c.erase(std::make_pair(Issue(c1, i2), domain1)) == 0))
-            return;
-        if (!REQUIRE(c.erase(std::make_pair(a1, domain1)) == 1))
-            return;
-        if (!REQUIRE(c.erase(std::make_pair(a2, domain1)) == 1))
-            return;
-        if (!REQUIRE(c.erase(std::make_pair(a2, domain2)) == 1))
-            return;
-        if (!REQUIRE(c.empty()))
-            return;
-    }
-
-    void
-    testIssueDomainSets()
-    {testIssueDomainSet<std::set<std::pair<Issue, Domain>>>();testIssueDomainSet<std::set<std::pair<Issue, Domain>>>();testIssueDomainSet<hash_set<std::pair<Issue, Domain>>>();testIssueDomainSet<hash_set<std::pair<Issue, Domain>>>();
-    }
-
-    void
-    testIssueDomainMaps()
-    {testIssueDomainMap<std::map<std::pair<Issue, Domain>, int>>();testIssueDomainMap<std::map<std::pair<Issue, Domain>, int>>();
-
-#if XRPL_ASSETS_ENABLE_STD_HASHtestIssueDomainMap<hash_map<std::pair<Issue, Domain>, int>>();testIssueDomainMap<hash_map<std::pair<Issue, Domain>, int>>();testIssueDomainMap<hardened_hash_map<std::pair<Issue, Domain>, int>>();testIssueDomainMap<hardened_hash_map<std::pair<Issue, Domain>, int>>();
-#endif
-    }
-
-    void
-    testIssueSets()
-    {testIssueSet<std::set<Issue>>();testIssueSet<std::set<Issue>>();
-
-#if XRPL_ASSETS_ENABLE_STD_HASHtestIssueSet<std::unordered_set<Issue>>();testIssueSet<std::unordered_set<Issue>>();
-#endiftestIssueSet<hash_set<Issue>>();testIssueSet<hash_set<Issue>>();
-    }
-
-    void
-    testIssueMaps()
-    {testIssueMap<std::map<Issue, int>>();testIssueMap<std::map<Issue, int>>();
-
-#if XRPL_ASSETS_ENABLE_STD_HASHtestIssueMap<std::unordered_map<Issue, int>>();testIssueMap<std::unordered_map<Issue, int>>();testIssueMap<hash_map<Issue, int>>();testIssueMap<hash_map<Issue, int>>();
-
-#endif
-    }
-
-    //--------------------------------------------------------------------------
-
-    // Comparison, hash tests for Book
-    template <class Book>
-    void
-    testBook()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Currency const c3(3);
-        AccountID const i3(3);
-
-        Issue a1(c1, i1);
-        Issue a2(c1, i2);
-        Issue a3(c2, i2);
-        Issue a4(c3, i2);
-        uint256 const domain1{1};
-        uint256 const domain2{2};
-
-        // Books without domains
-        REQUIRE(Book(a1, a2, std::nullopt) != Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a1, a2, std::nullopt) < Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a1, a2, std::nullopt) <= Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a2, a3, std::nullopt) <= Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a2, a3, std::nullopt) == Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a2, a3, std::nullopt) >= Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a3, a4, std::nullopt) >= Book(a2, a3, std::nullopt));
-        REQUIRE(Book(a3, a4, std::nullopt) > Book(a2, a3, std::nullopt));
-
-        // test domain books
-        {
-            // Books with different domains
-            REQUIRE(Book(a2, a3, domain1) != Book(a2, a3, domain2));
-            REQUIRE(Book(a2, a3, domain1) < Book(a2, a3, domain2));
-            REQUIRE(Book(a2, a3, domain2) > Book(a2, a3, domain1));
-
-            // One Book has a domain, the other does not
-            REQUIRE(Book(a2, a3, domain1) != Book(a2, a3, std::nullopt));
-            REQUIRE(Book(a2, a3, std::nullopt) < Book(a2, a3, domain1));
-            REQUIRE(Book(a2, a3, domain1) > Book(a2, a3, std::nullopt));
-
-            // Both Books have the same domain
-            REQUIRE(Book(a2, a3, domain1) == Book(a2, a3, domain1));
-            REQUIRE(Book(a2, a3, domain2) == Book(a2, a3, domain2));
-            REQUIRE(
-                Book(a2, a3, std::nullopt) == Book(a2, a3, std::nullopt));
-
-            // Both Books have no domain
-            REQUIRE(
-                Book(a2, a3, std::nullopt) == Book(a2, a3, std::nullopt));
-
-            // Testing comparisons with >= and <=
-
-            // When comparing books with domain1 vs domain2
-            REQUIRE(Book(a2, a3, domain1) <= Book(a2, a3, domain2));
-            REQUIRE(Book(a2, a3, domain2) >= Book(a2, a3, domain1));
-            REQUIRE(Book(a2, a3, domain1) >= Book(a2, a3, domain1));
-            REQUIRE(Book(a2, a3, domain2) <= Book(a2, a3, domain2));
-
-            // One Book has domain1 and the other has no domain
-            REQUIRE(Book(a2, a3, domain1) > Book(a2, a3, std::nullopt));
-            REQUIRE(Book(a2, a3, std::nullopt) < Book(a2, a3, domain1));
-
-            // One Book has domain2 and the other has no domain
-            REQUIRE(Book(a2, a3, domain2) > Book(a2, a3, std::nullopt));
-            REQUIRE(Book(a2, a3, std::nullopt) < Book(a2, a3, domain2));
-
-            // Comparing two Books with no domains
-            REQUIRE(
-                Book(a2, a3, std::nullopt) <= Book(a2, a3, std::nullopt));
-            REQUIRE(
-                Book(a2, a3, std::nullopt) >= Book(a2, a3, std::nullopt));
-
-            // Test case where domain1 is less than domain2
-            REQUIRE(Book(a2, a3, domain1) <= Book(a2, a3, domain2));
-            REQUIRE(Book(a2, a3, domain2) >= Book(a2, a3, domain1));
-
-            // Test case where domain2 is equal to domain1
-            REQUIRE(Book(a2, a3, domain1) >= Book(a2, a3, domain1));
-            REQUIRE(Book(a2, a3, domain1) <= Book(a2, a3, domain1));
-
-            // More test cases involving a4 (with domain2)
-
-            // Comparing Book with domain2 (a4) to a Book with domain1
-            REQUIRE(Book(a2, a3, domain1) < Book(a3, a4, domain2));
-            REQUIRE(Book(a3, a4, domain2) > Book(a2, a3, domain1));
-
-            // Comparing Book with domain2 (a4) to a Book with no domain
-            REQUIRE(Book(a3, a4, domain2) > Book(a2, a3, std::nullopt));
-            REQUIRE(Book(a2, a3, std::nullopt) < Book(a3, a4, domain2));
-
-            // Comparing Book with domain2 (a4) to a Book with the same domain
-            REQUIRE(Book(a3, a4, domain2) == Book(a3, a4, domain2));
-
-            // Comparing Book with domain2 (a4) to a Book with domain1
-            REQUIRE(Book(a2, a3, domain1) < Book(a3, a4, domain2));
-            REQUIRE(Book(a3, a4, domain2) > Book(a2, a3, domain1));
-        }
-
-        std::hash<Book> hash;
-
-        //         log << std::hex << hash (Book (a1, a2));
-        //         log << std::hex << hash (Book (a1, a2));
-        //
-        //         log << std::hex << hash (Book (a1, a3));
-        //         log << std::hex << hash (Book (a1, a3));
-        //
-        //         log << std::hex << hash (Book (a1, a4));
-        //         log << std::hex << hash (Book (a1, a4));
-        //
-        //         log << std::hex << hash (Book (a2, a3));
-        //         log << std::hex << hash (Book (a2, a3));
-        //
-        //         log << std::hex << hash (Book (a2, a4));
-        //         log << std::hex << hash (Book (a2, a4));
-        //
-        //         log << std::hex << hash (Book (a3, a4));
-        //         log << std::hex << hash (Book (a3, a4));
-
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) ==
-            hash(Book(a1, a2, std::nullopt)));
-        REQUIRE(
-            hash(Book(a1, a3, std::nullopt)) ==
-            hash(Book(a1, a3, std::nullopt)));
-        REQUIRE(
-            hash(Book(a1, a4, std::nullopt)) ==
-            hash(Book(a1, a4, std::nullopt)));
-        REQUIRE(
-            hash(Book(a2, a3, std::nullopt)) ==
-            hash(Book(a2, a3, std::nullopt)));
-        REQUIRE(
-            hash(Book(a2, a4, std::nullopt)) ==
-            hash(Book(a2, a4, std::nullopt)));
-        REQUIRE(
-            hash(Book(a3, a4, std::nullopt)) ==
-            hash(Book(a3, a4, std::nullopt)));
-
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) !=
-            hash(Book(a1, a3, std::nullopt)));
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) !=
-            hash(Book(a1, a4, std::nullopt)));
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) !=
-            hash(Book(a2, a3, std::nullopt)));
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) !=
-            hash(Book(a2, a4, std::nullopt)));
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) !=
-            hash(Book(a3, a4, std::nullopt)));
-
-        // Books with domain
-        REQUIRE(
-            hash(Book(a1, a2, domain1)) == hash(Book(a1, a2, domain1)));
-        REQUIRE(
-            hash(Book(a1, a3, domain1)) == hash(Book(a1, a3, domain1)));
-        REQUIRE(
-            hash(Book(a1, a4, domain1)) == hash(Book(a1, a4, domain1)));
-        REQUIRE(
-            hash(Book(a2, a3, domain1)) == hash(Book(a2, a3, domain1)));
-        REQUIRE(
-            hash(Book(a2, a4, domain1)) == hash(Book(a2, a4, domain1)));
-        REQUIRE(
-            hash(Book(a3, a4, domain1)) == hash(Book(a3, a4, domain1)));
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) ==
-            hash(Book(a1, a2, std::nullopt)));
-
-        // Comparing Books with domain1 vs no domain
-        REQUIRE(
-            hash(Book(a1, a2, std::nullopt)) != hash(Book(a1, a2, domain1)));
-        REQUIRE(
-            hash(Book(a1, a3, std::nullopt)) != hash(Book(a1, a3, domain1)));
-        REQUIRE(
-            hash(Book(a1, a4, std::nullopt)) != hash(Book(a1, a4, domain1)));
-        REQUIRE(
-            hash(Book(a2, a3, std::nullopt)) != hash(Book(a2, a3, domain1)));
-        REQUIRE(
-            hash(Book(a2, a4, std::nullopt)) != hash(Book(a2, a4, domain1)));
-        REQUIRE(
-            hash(Book(a3, a4, std::nullopt)) != hash(Book(a3, a4, domain1)));
-
-        // Books with domain1 but different Issues
-        REQUIRE(
-            hash(Book(a1, a2, domain1)) != hash(Book(a1, a3, domain1)));
-        REQUIRE(
-            hash(Book(a1, a2, domain1)) != hash(Book(a1, a4, domain1)));
-        REQUIRE(
-            hash(Book(a2, a3, domain1)) != hash(Book(a2, a4, domain1)));
-        REQUIRE(
-            hash(Book(a1, a2, domain1)) != hash(Book(a2, a3, domain1)));
-        REQUIRE(
-            hash(Book(a2, a4, domain1)) != hash(Book(a3, a4, domain1)));
-        REQUIRE(
-            hash(Book(a3, a4, domain1)) != hash(Book(a1, a4, domain1)));
-
-        // Books with domain1 and domain2
-        REQUIRE(
-            hash(Book(a1, a2, domain1)) != hash(Book(a1, a2, domain2)));
-        REQUIRE(
-            hash(Book(a1, a3, domain1)) != hash(Book(a1, a3, domain2)));
-        REQUIRE(
-            hash(Book(a1, a4, domain1)) != hash(Book(a1, a4, domain2)));
-        REQUIRE(
-            hash(Book(a2, a3, domain1)) != hash(Book(a2, a3, domain2)));
-        REQUIRE(
-            hash(Book(a2, a4, domain1)) != hash(Book(a2, a4, domain2)));
-        REQUIRE(
-            hash(Book(a3, a4, domain1)) != hash(Book(a3, a4, domain2)));
-    }
-
-    //--------------------------------------------------------------------------
-
-    template <class Set>
-    void
-    testBookSet()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Issue const a1(c1, i1);
-        Issue const a2(c2, i2);
-        Book const b1(a1, a2, std::nullopt);
-        Book const b2(a2, a1, std::nullopt);
-
-        uint256 const domain1{1};
-        uint256 const domain2{2};
-
-        Book const b1_d1(a1, a2, domain1);
-        Book const b2_d1(a2, a1, domain1);
-        Book const b1_d2(a1, a2, domain2);
-        Book const b2_d2(a2, a1, domain2);
-
-        {
-            Set c;
-
-            c.insert(b1);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(b2);
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a1, std::nullopt)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Book(a1, a2, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Set c;
-
-            c.insert(b1);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(b2);
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a1, std::nullopt)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Book(a1, a2, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-
-#if STL_SET_HAS_EMPLACE
-            c.emplace(a1, a2);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.emplace(a2, a1);
-            if (!REQUIRE(c.size() == 2))
-                return;
-#endif
-        }
-
-        {
-            Set c;
-
-            c.insert(b1_d1);
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(b2_d1);
-            if (!REQUIRE(c.size() == 2))
-                return;
-            c.insert(b1_d2);
-            if (!REQUIRE(c.size() == 3))
-                return;
-            c.insert(b2_d2);
-            if (!REQUIRE(c.size() == 4))
-                return;
-
-            // Try removing non-existent elements
-            if (!REQUIRE(c.erase(Book(a2, a2, domain1)) == 0))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, domain2)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, domain2)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Set c;
-
-            c.insert(b1);
-            c.insert(b2);
-            c.insert(b1_d1);
-            c.insert(b2_d1);
-            if (!REQUIRE(c.size() == 4))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-    }
-
-    template <class Map>
-    void
-    testBookMap()
-    {
-        Currency const c1(1);
-        AccountID const i1(1);
-        Currency const c2(2);
-        AccountID const i2(2);
-        Issue const a1(c1, i1);
-        Issue const a2(c2, i2);
-        Book const b1(a1, a2, std::nullopt);
-        Book const b2(a2, a1, std::nullopt);
-
-        uint256 const domain1{1};
-        uint256 const domain2{2};
-
-        Book const b1_d1(a1, a2, domain1);
-        Book const b2_d1(a2, a1, domain1);
-        Book const b1_d2(a1, a2, domain2);
-        Book const b2_d2(a2, a1, domain2);
-
-        // typename Map::value_type value_type;
-        // std::pair <Book const, int> value_type;
-
-        {
-            Map c;
-
-            // c.insert (value_type (b1, 1));
-            c.insert(std::make_pair(b1, 1));
-            if (!REQUIRE(c.size() == 1))
-                return;
-            // c.insert (value_type (b2, 2));
-            c.insert(std::make_pair(b2, 1));
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a1, std::nullopt)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Book(a1, a2, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Map c;
-
-            // c.insert (value_type (b1, 1));
-            c.insert(std::make_pair(b1, 1));
-            if (!REQUIRE(c.size() == 1))
-                return;
-            // c.insert (value_type (b2, 2));
-            c.insert(std::make_pair(b2, 1));
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a1, std::nullopt)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Book(a1, a2, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Map c;
-
-            c.insert(std::make_pair(b1_d1, 10));
-            if (!REQUIRE(c.size() == 1))
-                return;
-            c.insert(std::make_pair(b2_d1, 20));
-            if (!REQUIRE(c.size() == 2))
-                return;
-            c.insert(std::make_pair(b1_d2, 30));
-            if (!REQUIRE(c.size() == 3))
-                return;
-            c.insert(std::make_pair(b2_d2, 40));
-            if (!REQUIRE(c.size() == 4))
-                return;
-
-            // Try removing non-existent elements
-            if (!REQUIRE(c.erase(Book(a2, a2, domain1)) == 0))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, domain2)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, domain2)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-
-        {
-            Map c;
-
-            c.insert(std::make_pair(b1, 1));
-            c.insert(std::make_pair(b2, 2));
-            c.insert(std::make_pair(b1_d1, 3));
-            c.insert(std::make_pair(b2_d1, 4));
-            if (!REQUIRE(c.size() == 4))
-                return;
-
-            // Try removing non-existent elements
-            if (!REQUIRE(c.erase(Book(a1, a1, domain1)) == 0))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a2, domain2)) == 0))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, std::nullopt)) == 1))
-                return;
-            if (!REQUIRE(c.size() == 2))
-                return;
-
-            if (!REQUIRE(c.erase(Book(a1, a2, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.erase(Book(a2, a1, domain1)) == 1))
-                return;
-            if (!REQUIRE(c.empty()))
-                return;
-        }
-    }
-
-    void
-    testBookSets()
-    {testBookSet<std::set<Book>>();testBookSet<std::set<Book>>();
-
-#if XRPL_ASSETS_ENABLE_STD_HASHtestBookSet<std::unordered_set<Book>>();testBookSet<std::unordered_set<Book>>();
-#endiftestBookSet<hash_set<Book>>();testBookSet<hash_set<Book>>();
-    }
-
-    void
-    testBookMaps()
-    {testBookMap<std::map<Book, int>>();testBookMap<std::map<Book, int>>();
-
-#if XRPL_ASSETS_ENABLE_STD_HASHtestBookMap<std::unordered_map<Book, int>>();testBookMap<std::unordered_map<Book, int>>();testBookMap<hash_map<Book, int>>();testBookMap<hash_map<Book, int>>();
-#endif
-    }
-
-    //--------------------------------------------------------------------------
-
-    void
-    run() override
-    {testUnsigned<Currency>();testUnsigned<AccountID>();
-
-        // ---testIssue<Issue>();testIssue<Issue>();
-
-        testIssueSets();
-        testIssueMaps();
-
-        // ---testBook<Book>();testBook<Book>();
-
-        testBookSets();
-        testBookMaps();
-
-        // ---
-        testIssueDomainSets();
-        testIssueDomainMaps();
-    }
-
-
-} // anonymous namespace
-
-TEST_CASE("Issue_test - testIssueSets")
-{
-    testIssueSets();
-}
-
-TEST_CASE("Issue_test - testIssueMaps")
-{
-    testIssueMaps();
-}
-
-TEST_CASE("Issue_test - testBookSets")
-{
-    testBookSets();
-}
-
-TEST_CASE("Issue_test - testBookMaps")
-{
-    testBookMaps();
-}
-
-TEST_CASE("Issue_test - testIssueDomainSets")
-{
-    testIssueDomainSets();
-}
-
-TEST_CASE("Issue_test - testIssueDomainMaps")
-{
-    testIssueDomainMaps();
-}
-
-
-
-
-
-}  // namespace ripple

src/doctest/protocol/STAccount_test.cpp

@@ -1,116 +0,0 @@
-#include <xrpl/protocol/STAccount.h>
-
-#include <doctest/doctest.h>
-
-using namespace xrpl;
-
-TEST_SUITE_BEGIN("protocol");
-
-TEST_CASE("STAccount default constructor")
-{
-    STAccount const defaultAcct;
-    CHECK(defaultAcct.getSType() == STI_ACCOUNT);
-    CHECK(defaultAcct.getText() == "");
-    CHECK(defaultAcct.isDefault() == true);
-    CHECK(defaultAcct.value() == AccountID{});
-}
-
-TEST_CASE("STAccount deserialized default")
-{
-    STAccount const defaultAcct;
-    // Construct a deserialized default STAccount.
-    Serializer s;
-    s.addVL(nullptr, 0);
-    SerialIter sit(s.slice());
-    STAccount const deserializedDefault(sit, sfAccount);
-    CHECK(deserializedDefault.isEquivalent(defaultAcct));
-}
-
-TEST_CASE("STAccount constructor from SField")
-{
-    STAccount const defaultAcct;
-    STAccount const sfAcct{sfAccount};
-    CHECK(sfAcct.getSType() == STI_ACCOUNT);
-    CHECK(sfAcct.getText() == "");
-    CHECK(sfAcct.isDefault());
-    CHECK(sfAcct.value() == AccountID{});
-    CHECK(sfAcct.isEquivalent(defaultAcct));
-
-    Serializer s;
-    sfAcct.add(s);
-    CHECK(s.size() == 1);
-    CHECK(strHex(s) == "00");
-    SerialIter sit(s.slice());
-    STAccount const deserializedSf(sit, sfAccount);
-    CHECK(deserializedSf.isEquivalent(sfAcct));
-}
-
-TEST_CASE("STAccount constructor from SField and AccountID")
-{
-    STAccount const defaultAcct;
-    STAccount const sfAcct{sfAccount};
-    STAccount const zeroAcct{sfAccount, AccountID{}};
-    CHECK(zeroAcct.getText() == "rrrrrrrrrrrrrrrrrrrrrhoLvTp");
-    CHECK(!zeroAcct.isDefault());
-    CHECK(zeroAcct.value() == AccountID{0});
-    CHECK(!zeroAcct.isEquivalent(defaultAcct));
-    CHECK(!zeroAcct.isEquivalent(sfAcct));
-
-    Serializer s;
-    zeroAcct.add(s);
-    CHECK(s.size() == 21);
-    CHECK(strHex(s) == "140000000000000000000000000000000000000000");
-    SerialIter sit(s.slice());
-    STAccount const deserializedZero(sit, sfAccount);
-    CHECK(deserializedZero.isEquivalent(zeroAcct));
-}
-
-TEST_CASE("STAccount bad size throws")
-{
-    // Construct from a VL that is not exactly 160 bits.
-    Serializer s;
-    std::uint8_t const bits128[]{
-        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
-    s.addVL(bits128, sizeof(bits128));
-    SerialIter sit(s.slice());
-    CHECK_THROWS_AS(STAccount(sit, sfAccount), std::runtime_error);
-}
-
-TEST_CASE("STAccount equivalent types")
-{
-    STAccount const zeroAcct{sfAccount, AccountID{}};
-    // Interestingly, equal values but different types are equivalent!
-    STAccount const regKey{sfRegularKey, AccountID{}};
-    CHECK(regKey.isEquivalent(zeroAcct));
-}
-
-TEST_CASE("STAccount assignment")
-{
-    STAccount const defaultAcct;
-    STAccount const zeroAcct{sfAccount, AccountID{}};
-
-    STAccount assignAcct;
-    CHECK(assignAcct.isEquivalent(defaultAcct));
-    CHECK(assignAcct.isDefault());
-    assignAcct = AccountID{};
-    CHECK(!assignAcct.isEquivalent(defaultAcct));
-    CHECK(assignAcct.isEquivalent(zeroAcct));
-    CHECK(!assignAcct.isDefault());
-}
-
-TEST_CASE("AccountID parsing")
-{
-    auto const s = "rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh";
-    auto const parsed = parseBase58<AccountID>(s);
-    REQUIRE(parsed);
-    CHECK(toBase58(*parsed) == s);
-}
-
-TEST_CASE("AccountID invalid parsing")
-{
-    auto const s =
-        "âabcd1rNxp4h8apvRis6mJf9Sh8C6iRxfrDWNâabcdAVâ\xc2\x80\xc2\x8f";
-    CHECK(!parseBase58<AccountID>(s));
-}
-
-TEST_SUITE_END();

src/doctest/protocol/STInteger_test.cpp

@@ -1,121 +0,0 @@
-#include <xrpl/protocol/LedgerFormats.h>
-#include <xrpl/protocol/Permissions.h>
-#include <xrpl/protocol/STInteger.h>
-#include <xrpl/protocol/TxFormats.h>
-
-#include <doctest/doctest.h>
-
-using namespace xrpl;
-
-TEST_SUITE_BEGIN("protocol");
-
-TEST_CASE("STInteger_test - UInt8")
-{
-    STUInt8 u8(255);
-    CHECK(u8.value() == 255);
-    CHECK(u8.getText() == "255");
-    CHECK(u8.getSType() == STI_UINT8);
-    CHECK(u8.getJson(JsonOptions::none) == 255);
-
-    // there is some special handling for sfTransactionResult
-    STUInt8 tr(sfTransactionResult, 0);
-    CHECK(tr.value() == 0);
-    CHECK(
-        tr.getText() ==
-        "The transaction was applied. Only final in a validated ledger.");
-    CHECK(tr.getSType() == STI_UINT8);
-    CHECK(tr.getJson(JsonOptions::none) == "tesSUCCESS");
-
-    // invalid transaction result
-    STUInt8 tr2(sfTransactionResult, 255);
-    CHECK(tr2.value() == 255);
-    CHECK(tr2.getText() == "255");
-    CHECK(tr2.getSType() == STI_UINT8);
-    CHECK(tr2.getJson(JsonOptions::none) == 255);
-}
-
-TEST_CASE("STInteger_test - UInt16")
-{
-    STUInt16 u16(65535);
-    CHECK(u16.value() == 65535);
-    CHECK(u16.getText() == "65535");
-    CHECK(u16.getSType() == STI_UINT16);
-    CHECK(u16.getJson(JsonOptions::none) == 65535);
-
-    // there is some special handling for sfLedgerEntryType
-    STUInt16 let(sfLedgerEntryType, ltACCOUNT_ROOT);
-    CHECK(let.value() == ltACCOUNT_ROOT);
-    CHECK(let.getText() == "AccountRoot");
-    CHECK(let.getSType() == STI_UINT16);
-    CHECK(let.getJson(JsonOptions::none) == "AccountRoot");
-
-    // there is some special handling for sfTransactionType
-    STUInt16 tlt(sfTransactionType, ttPAYMENT);
-    CHECK(tlt.value() == ttPAYMENT);
-    CHECK(tlt.getText() == "Payment");
-    CHECK(tlt.getSType() == STI_UINT16);
-    CHECK(tlt.getJson(JsonOptions::none) == "Payment");
-}
-
-TEST_CASE("STInteger_test - UInt32")
-{
-    STUInt32 u32(4'294'967'295u);
-    CHECK(u32.value() == 4'294'967'295u);
-    CHECK(u32.getText() == "4294967295");
-    CHECK(u32.getSType() == STI_UINT32);
-    CHECK(u32.getJson(JsonOptions::none) == 4'294'967'295u);
-
-    // there is some special handling for sfPermissionValue
-    STUInt32 pv(sfPermissionValue, ttPAYMENT + 1);
-    CHECK(pv.value() == ttPAYMENT + 1);
-    CHECK(pv.getText() == "Payment");
-    CHECK(pv.getSType() == STI_UINT32);
-    CHECK(pv.getJson(JsonOptions::none) == "Payment");
-    STUInt32 pv2(sfPermissionValue, PaymentMint);
-    CHECK(pv2.value() == PaymentMint);
-    CHECK(pv2.getText() == "PaymentMint");
-    CHECK(pv2.getSType() == STI_UINT32);
-    CHECK(pv2.getJson(JsonOptions::none) == "PaymentMint");
-}
-
-TEST_CASE("STInteger_test - UInt64")
-{
-    STUInt64 u64(0xFFFFFFFFFFFFFFFFull);
-    CHECK(u64.value() == 0xFFFFFFFFFFFFFFFFull);
-    CHECK(u64.getText() == "18446744073709551615");
-    CHECK(u64.getSType() == STI_UINT64);
-
-    // By default, getJson returns hex string
-    auto jsonVal = u64.getJson(JsonOptions::none);
-    CHECK(jsonVal.isString());
-    CHECK(jsonVal.asString() == "ffffffffffffffff");
-
-    STUInt64 u64_2(sfMaximumAmount, 0xFFFFFFFFFFFFFFFFull);
-    CHECK(u64_2.value() == 0xFFFFFFFFFFFFFFFFull);
-    CHECK(u64_2.getText() == "18446744073709551615");
-    CHECK(u64_2.getSType() == STI_UINT64);
-    CHECK(u64_2.getJson(JsonOptions::none) == "18446744073709551615");
-}
-
-TEST_CASE("STInteger_test - Int32")
-{
-    {
-        int const minInt32 = -2147483648;
-        STInt32 i32(minInt32);
-        CHECK(i32.value() == minInt32);
-        CHECK(i32.getText() == "-2147483648");
-        CHECK(i32.getSType() == STI_INT32);
-        CHECK(i32.getJson(JsonOptions::none) == minInt32);
-    }
-
-    {
-        int const maxInt32 = 2147483647;
-        STInt32 i32(maxInt32);
-        CHECK(i32.value() == maxInt32);
-        CHECK(i32.getText() == "2147483647");
-        CHECK(i32.getSType() == STI_INT32);
-        CHECK(i32.getJson(JsonOptions::none) == maxInt32);
-    }
-}
-
-TEST_SUITE_END();

src/doctest/protocol/STNumber_test.cpp

@@ -1,218 +0,0 @@
-#include <xrpl/json/json_forwards.h>
-#include <xrpl/protocol/Issue.h>
-#include <xrpl/protocol/SField.h>
-#include <xrpl/protocol/STAmount.h>
-#include <xrpl/protocol/STNumber.h>
-
-#include <doctest/doctest.h>
-
-#include <limits>
-#include <ostream>
-#include <stdexcept>
-
-using xrpl::IOUAmount;
-using xrpl::noIssue;
-using xrpl::Number;
-using xrpl::numberFromJson;
-using xrpl::SerialIter;
-using xrpl::Serializer;
-using xrpl::sfNumber;
-using xrpl::STAmount;
-using xrpl::STI_NUMBER;
-using xrpl::STNumber;
-
-namespace xrpl {
-
-TEST_SUITE_BEGIN("protocol");
-
-static void
-testCombo(Number number)
-{
-    STNumber const before{sfNumber, number};
-    CHECK(number == before);
-    Serializer s;
-    before.add(s);
-    CHECK(s.size() == 12);
-    SerialIter sit(s.slice());
-    STNumber const after{sit, sfNumber};
-    CHECK(after.isEquivalent(before));
-    CHECK(number == after);
-}
-
-TEST_CASE("STNumber_test")
-{
-    static_assert(!std::is_convertible_v<STNumber*, Number*>);
-
-    SUBCASE("Default construction")
-    {
-        STNumber const stnum{sfNumber};
-        CHECK(stnum.getSType() == STI_NUMBER);
-        CHECK(stnum.getText() == "0");
-        CHECK(stnum.isDefault() == true);
-        CHECK(stnum.value() == Number{0});
-    }
-
-    SUBCASE("Mantissa tests")
-    {
-        std::initializer_list<std::int64_t> const mantissas = {
-            std::numeric_limits<std::int64_t>::min(),
-            -1,
-            0,
-            1,
-            std::numeric_limits<std::int64_t>::max()};
-        for (std::int64_t mantissa : mantissas)
-            testCombo(Number{mantissa});
-    }
-
-    SUBCASE("Exponent tests")
-    {
-        std::initializer_list<std::int32_t> const exponents = {
-            Number::minExponent, -1, 0, 1, Number::maxExponent - 1};
-        for (std::int32_t exponent : exponents)
-            testCombo(Number{123, exponent});
-    }
-
-    SUBCASE("STAmount multiplication")
-    {
-        STAmount const strikePrice{noIssue(), 100};
-        STNumber const factor{sfNumber, 100};
-        auto const iouValue = strikePrice.iou();
-        IOUAmount totalValue{iouValue * factor};
-        STAmount const totalAmount{totalValue, strikePrice.issue()};
-        CHECK(totalAmount == Number{10'000});
-    }
-
-    SUBCASE("JSON parsing - integers")
-    {
-        CHECK(
-            numberFromJson(sfNumber, Json::Value(42)) ==
-            STNumber(sfNumber, 42));
-        CHECK(
-            numberFromJson(sfNumber, Json::Value(-42)) ==
-            STNumber(sfNumber, -42));
-
-        CHECK(
-            numberFromJson(sfNumber, Json::UInt(42)) ==
-            STNumber(sfNumber, 42));
-
-        CHECK(
-            numberFromJson(sfNumber, "-123") == STNumber(sfNumber, -123));
-
-        CHECK(numberFromJson(sfNumber, "123") == STNumber(sfNumber, 123));
-        CHECK(numberFromJson(sfNumber, "-123") == STNumber(sfNumber, -123));
-    }
-
-    SUBCASE("JSON parsing - decimals")
-    {
-        CHECK(
-            numberFromJson(sfNumber, "3.14") ==
-            STNumber(sfNumber, Number(314, -2)));
-        CHECK(
-            numberFromJson(sfNumber, "-3.14") ==
-            STNumber(sfNumber, -Number(314, -2)));
-        CHECK(
-            numberFromJson(sfNumber, "3.14e2") == STNumber(sfNumber, 314));
-        CHECK(
-            numberFromJson(sfNumber, "-3.14e2") == STNumber(sfNumber, -314));
-
-        CHECK(numberFromJson(sfNumber, "1000e-2") == STNumber(sfNumber, 10));
-        CHECK(
-            numberFromJson(sfNumber, "-1000e-2") == STNumber(sfNumber, -10));
-    }
-
-    SUBCASE("JSON parsing - zeros")
-    {
-        CHECK(numberFromJson(sfNumber, "0") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "0.0") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "0.000") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "-0") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "-0.0") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "-0.000") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "0e6") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "0.0e6") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "0.000e6") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "-0e6") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "-0.0e6") == STNumber(sfNumber, 0));
-        CHECK(numberFromJson(sfNumber, "-0.000e6") == STNumber(sfNumber, 0));
-    }
-
-    SUBCASE("JSON parsing - limits")
-    {
-        constexpr auto imin = std::numeric_limits<int>::min();
-        CHECK(
-            numberFromJson(sfNumber, imin) ==
-            STNumber(sfNumber, Number(imin, 0)));
-        CHECK(
-            numberFromJson(sfNumber, std::to_string(imin)) ==
-            STNumber(sfNumber, Number(imin, 0)));
-
-        constexpr auto imax = std::numeric_limits<int>::max();
-        CHECK(
-            numberFromJson(sfNumber, imax) ==
-            STNumber(sfNumber, Number(imax, 0)));
-        CHECK(
-            numberFromJson(sfNumber, std::to_string(imax)) ==
-            STNumber(sfNumber, Number(imax, 0)));
-
-        constexpr auto umax = std::numeric_limits<unsigned int>::max();
-        CHECK(
-            numberFromJson(sfNumber, umax) ==
-            STNumber(sfNumber, Number(umax, 0)));
-        CHECK(
-            numberFromJson(sfNumber, std::to_string(umax)) ==
-            STNumber(sfNumber, Number(umax, 0)));
-    }
-
-    SUBCASE("JSON parsing - error cases")
-    {
-        // Empty string
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, ""), std::runtime_error);
-
-        // Just 'e'
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "e"), std::runtime_error);
-
-        // Incomplete exponent
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "1e"), std::runtime_error);
-
-        // Invalid exponent
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "e2"), std::runtime_error);
-
-        // Null JSON value
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, Json::Value()), std::runtime_error);
-
-        // Too large number
-        CHECK_THROWS_AS(
-            numberFromJson(
-                sfNumber,
-                "1234567890123456789012345678901234567890123456789012345678"
-                "9012345678901234567890123456789012345678901234567890123456"
-                "78901234567890123456789012345678901234567890"),
-            std::bad_cast);
-
-        // Leading zeros not allowed
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "001"), std::runtime_error);
-
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "000.0"), std::runtime_error);
-
-        // Dangling dot not allowed
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, ".1"), std::runtime_error);
-
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "1."), std::runtime_error);
-
-        CHECK_THROWS_AS(
-            numberFromJson(sfNumber, "1.e3"), std::runtime_error);
-    }
-}
-
-TEST_SUITE_END();
-
-}  // namespace xrpl

src/doctest/protocol/SecretKey_test.cpp

@@ -1,257 +0,0 @@
-#include <xrpl/beast/utility/rngfill.h>
-#include <xrpl/crypto/csprng.h>
-#include <xrpl/protocol/PublicKey.h>
-#include <xrpl/protocol/SecretKey.h>
-#include <xrpl/protocol/Seed.h>
-
-#include <doctest/doctest.h>
-
-#include <algorithm>
-#include <string>
-#include <vector>
-
-using namespace xrpl;
-
-namespace {
-
-struct TestKeyData
-{
-    std::array<std::uint8_t, 16> seed;
-    std::array<std::uint8_t, 33> pubkey;
-    std::array<std::uint8_t, 32> seckey;
-    char const* addr;
-};
-
-void
-testSigning(KeyType type)
-{
-    for (std::size_t i = 0; i < 32; i++)
-    {
-        auto const [pk, sk] = randomKeyPair(type);
-
-        CHECK(pk == derivePublicKey(type, sk));
-        CHECK(*publicKeyType(pk) == type);
-
-        for (std::size_t j = 0; j < 32; j++)
-        {
-            std::vector<std::uint8_t> data(64 + (8 * i) + j);
-            beast::rngfill(data.data(), data.size(), crypto_prng());
-
-            auto sig = sign(pk, sk, makeSlice(data));
-
-            CHECK(sig.size() != 0);
-            CHECK(verify(pk, makeSlice(data), sig));
-
-            // Construct wrong data:
-            auto badData = data;
-
-            // swaps the smallest and largest elements in buffer
-            std::iter_swap(
-                std::min_element(badData.begin(), badData.end()),
-                std::max_element(badData.begin(), badData.end()));
-
-            // Wrong data: should fail
-            CHECK(!verify(pk, makeSlice(badData), sig));
-
-            // Slightly change the signature:
-            if (auto ptr = sig.data())
-                ptr[j % sig.size()]++;
-
-            // Wrong signature: should fail
-            CHECK(!verify(pk, makeSlice(data), sig));
-
-            // Wrong data and signature: should fail
-            CHECK(!verify(pk, makeSlice(badData), sig));
-        }
-    }
-}
-
-}  // namespace
-
-TEST_SUITE_BEGIN("protocol");
-
-TEST_CASE("secp256k1 canonicality")
-{
-    std::array<std::uint8_t, 32> const digestData{
-        0x34, 0xC1, 0x90, 0x28, 0xC8, 0x0D, 0x21, 0xF3, 0xF4, 0x8C, 0x93,
-        0x54, 0x89, 0x5F, 0x8D, 0x5B, 0xF0, 0xD5, 0xEE, 0x7F, 0xF4, 0x57,
-        0x64, 0x7C, 0xF6, 0x55, 0xF5, 0x53, 0x0A, 0x30, 0x22, 0xA7};
-
-    std::array<std::uint8_t, 33> const pkData{
-        0x02, 0x50, 0x96, 0xEB, 0x12, 0xD3, 0xE9, 0x24, 0x23, 0x4E, 0x71,
-        0x62, 0x36, 0x9C, 0x11, 0xD8, 0xBF, 0x87, 0x7E, 0xDA, 0x23, 0x87,
-        0x78, 0xE7, 0xA3, 0x1F, 0xF0, 0xAA, 0xC5, 0xD0, 0xDB, 0xCF, 0x37};
-
-    std::array<std::uint8_t, 32> const skData{
-        0xAA, 0x92, 0x14, 0x17, 0xE7, 0xE5, 0xC2, 0x99, 0xDA, 0x4E, 0xEC,
-        0x16, 0xD1, 0xCA, 0xA9, 0x2F, 0x19, 0xB1, 0x9F, 0x2A, 0x68, 0x51,
-        0x1F, 0x68, 0xEC, 0x73, 0xBB, 0xB2, 0xF5, 0x23, 0x6F, 0x3D};
-
-    std::array<std::uint8_t, 71> const sig{
-        0x30, 0x45, 0x02, 0x21, 0x00, 0xB4, 0x9D, 0x07, 0xF0, 0xE9, 0x34, 0xBA,
-        0x46, 0x8C, 0x0E, 0xFC, 0x78, 0x11, 0x77, 0x91, 0x40, 0x8D, 0x1F, 0xB8,
-        0xB6, 0x3A, 0x64, 0x92, 0xAD, 0x39, 0x5A, 0xC2, 0xF3, 0x60, 0xF2, 0x46,
-        0x60, 0x02, 0x20, 0x50, 0x87, 0x39, 0xDB, 0x0A, 0x2E, 0xF8, 0x16, 0x76,
-        0xE3, 0x9F, 0x45, 0x9C, 0x8B, 0xBB, 0x07, 0xA0, 0x9C, 0x3E, 0x9F, 0x9B,
-        0xEB, 0x69, 0x62, 0x94, 0xD5, 0x24, 0xD4, 0x79, 0xD6, 0x27, 0x40};
-
-    std::array<std::uint8_t, 72> const non{
-        0x30, 0x46, 0x02, 0x21, 0x00, 0xB4, 0x9D, 0x07, 0xF0, 0xE9, 0x34, 0xBA,
-        0x46, 0x8C, 0x0E, 0xFC, 0x78, 0x11, 0x77, 0x91, 0x40, 0x8D, 0x1F, 0xB8,
-        0xB6, 0x3A, 0x64, 0x92, 0xAD, 0x39, 0x5A, 0xC2, 0xF3, 0x60, 0xF2, 0x46,
-        0x60, 0x02, 0x21, 0x00, 0xAF, 0x78, 0xC6, 0x24, 0xF5, 0xD1, 0x07, 0xE9,
-        0x89, 0x1C, 0x60, 0xBA, 0x63, 0x74, 0x44, 0xF7, 0x1A, 0x12, 0x9E, 0x47,
-        0x13, 0x5D, 0x36, 0xD9, 0x2A, 0xFD, 0x39, 0xB8, 0x56, 0x60, 0x1A, 0x01};
-
-    auto const digest = uint256::fromVoid(digestData.data());
-
-    PublicKey const pk{makeSlice(pkData)};
-    SecretKey const sk{makeSlice(skData)};
-
-    {
-        auto const canonicality = ecdsaCanonicality(makeSlice(sig));
-        CHECK(canonicality);
-        CHECK(*canonicality == ECDSACanonicality::fullyCanonical);
-    }
-
-    {
-        auto const canonicality = ecdsaCanonicality(makeSlice(non));
-        CHECK(canonicality);
-        CHECK(*canonicality != ECDSACanonicality::fullyCanonical);
-    }
-
-    CHECK(verifyDigest(pk, digest, makeSlice(sig), false));
-    CHECK(verifyDigest(pk, digest, makeSlice(sig), true));
-    CHECK(verifyDigest(pk, digest, makeSlice(non), false));
-    CHECK(!verifyDigest(pk, digest, makeSlice(non), true));
-}
-
-TEST_CASE("secp256k1 digest signing and verification")
-{
-    for (std::size_t i = 0; i < 32; i++)
-    {
-        auto const [pk, sk] = randomKeyPair(KeyType::secp256k1);
-
-        CHECK(pk == derivePublicKey(KeyType::secp256k1, sk));
-        CHECK(*publicKeyType(pk) == KeyType::secp256k1);
-
-        for (std::size_t j = 0; j < 32; j++)
-        {
-            uint256 digest;
-            beast::rngfill(digest.data(), digest.size(), crypto_prng());
-
-            auto sig = signDigest(pk, sk, digest);
-
-            CHECK(sig.size() != 0);
-            CHECK(verifyDigest(pk, digest, sig, true));
-
-            // Wrong digest:
-            CHECK(!verifyDigest(pk, ~digest, sig, true));
-
-            // Slightly change the signature:
-            if (auto ptr = sig.data())
-                ptr[j % sig.size()]++;
-
-            // Wrong signature:
-            CHECK(!verifyDigest(pk, digest, sig, true));
-
-            // Wrong digest and signature:
-            CHECK(!verifyDigest(pk, ~digest, sig, true));
-        }
-    }
-}
-
-TEST_CASE("secp256k1 signing and verification")
-{
-    testSigning(KeyType::secp256k1);
-}
-
-TEST_CASE("ed25519 signing and verification")
-{
-    testSigning(KeyType::ed25519);
-}
-
-TEST_CASE("secp256k1 key derivation")
-{
-    // clang-format off
-    static TestKeyData const secp256k1TestVectors[] = {
-        {{0xDE,0xDC,0xE9,0xCE,0x67,0xB4,0x51,0xD8,0x52,0xFD,0x4E,0x84,0x6F,0xCD,0xE3,0x1C},
-         {0x03,0x30,0xE7,0xFC,0x9D,0x56,0xBB,0x25,0xD6,0x89,0x3B,0xA3,0xF3,0x17,0xAE,0x5B,
-          0xCF,0x33,0xB3,0x29,0x1B,0xD6,0x3D,0xB3,0x26,0x54,0xA3,0x13,0x22,0x2F,0x7F,0xD0,0x20},
-         {0x1A,0xCA,0xAE,0xDE,0xCE,0x40,0x5B,0x2A,0x95,0x82,0x12,0x62,0x9E,0x16,0xF2,0xEB,
-          0x46,0xB1,0x53,0xEE,0xE9,0x4C,0xDD,0x35,0x0F,0xDE,0xFF,0x52,0x79,0x55,0x25,0xB7},
-         "rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh"},
-        {{0xF7,0x5C,0x48,0xFE,0xC4,0x6D,0x4D,0x64,0x92,0x8B,0x79,0x5F,0x3F,0xBA,0xBB,0xA0},
-         {0x03,0xAF,0x53,0xE8,0x01,0x1E,0x85,0xB3,0x66,0x64,0xF1,0x71,0x08,0x90,0x50,0x1C,
-          0x3E,0x86,0xFC,0x2C,0x66,0x58,0xC2,0xEE,0x83,0xCA,0x58,0x0D,0xC9,0x97,0x25,0x41,0xB1},
-         {0x5B,0x8A,0xB0,0xE7,0xCD,0xAF,0x48,0x87,0x4D,0x5D,0x99,0x34,0xBF,0x3E,0x7B,0x2C,
-          0xB0,0x6B,0xC4,0xC7,0xEA,0xAA,0xF7,0x62,0x68,0x2E,0xD8,0xD0,0xA3,0x1E,0x3C,0x70},
-         "r9ZERztesFu3ZBs7zsWTeCvBg14GQ9zWF7"}
-    };
-    // clang-format on
-
-    for (auto const& v : secp256k1TestVectors)
-    {
-        auto const id = parseBase58<AccountID>(v.addr);
-        CHECK(id);
-
-        auto kp = generateKeyPair(KeyType::secp256k1, Seed{makeSlice(v.seed)});
-
-        CHECK(kp.first == PublicKey{makeSlice(v.pubkey)});
-        CHECK(kp.second == SecretKey{makeSlice(v.seckey)});
-        CHECK(calcAccountID(kp.first) == *id);
-    }
-}
-
-TEST_CASE("ed25519 key derivation")
-{
-    // clang-format off
-    static TestKeyData const ed25519TestVectors[] = {
-        {{0xAF,0x41,0xFF,0x66,0xF7,0x5E,0xBD,0x3A,0x6B,0x18,0xFB,0x7A,0x1D,0xF6,0x1C,0x97},
-         {0xED,0x48,0xCB,0xBB,0xE0,0xEE,0x7B,0x86,0x86,0xA7,0xDE,0x9F,0x0A,0x01,0x59,0x73,
-          0x4E,0x65,0xF9,0xC3,0x69,0x94,0x7F,0x2E,0x26,0x96,0x23,0x2B,0x46,0x1E,0x55,0x32,0x13},
-         {0x1A,0x10,0x97,0xFC,0xD9,0xCE,0x4E,0x1D,0xA2,0x46,0x66,0xB6,0x98,0x87,0x97,0x66,
-          0xE1,0x75,0x75,0x47,0xD1,0xD4,0xE3,0x64,0xB6,0x43,0x55,0xF7,0xC8,0x4B,0xA0,0xF3},
-         "rVAEQBhWT6nZ4woEifdN3TMMdUZaxeXnR"},
-        {{0x14,0x0C,0x1D,0x08,0x13,0x19,0x33,0x9C,0x79,0x9D,0xC6,0xA1,0x65,0x95,0x1B,0xE1},
-         {0xED,0x3B,0xC8,0x2E,0xF4,0x5F,0x89,0x09,0xCC,0x00,0xF8,0xB7,0xAA,0xF0,0x59,0x31,
-          0x68,0x14,0x11,0x75,0x8C,0x11,0x71,0x24,0x87,0x50,0x66,0xC2,0x83,0x98,0xFE,0x15,0x6D},
-         {0xFE,0x3E,0x5A,0x82,0xB8,0x0D,0xD8,0x2E,0x91,0x5F,0x76,0x38,0x94,0x2A,0x33,0x2C,
-          0xE3,0x06,0x88,0x79,0x74,0x0C,0x7E,0x90,0xE2,0x20,0xA4,0xFB,0x0B,0x37,0xCE,0xC8},
-         "rK57dJ9533WtoY8NNwVWGY7ffuAc8WCcPE"}
-    };
-    // clang-format on
-
-    for (auto const& v : ed25519TestVectors)
-    {
-        auto const id = parseBase58<AccountID>(v.addr);
-        CHECK(id);
-
-        auto kp = generateKeyPair(KeyType::ed25519, Seed{makeSlice(v.seed)});
-
-        CHECK(kp.first == PublicKey{makeSlice(v.pubkey)});
-        CHECK(kp.second == SecretKey{makeSlice(v.seckey)});
-        CHECK(calcAccountID(kp.first) == *id);
-    }
-}
-
-TEST_CASE("secp256k1 cross-type key mismatch")
-{
-    auto const [pk1, sk1] = randomKeyPair(KeyType::secp256k1);
-    auto const [pk2, sk2] = randomKeyPair(KeyType::secp256k1);
-
-    CHECK(pk1 != pk2);
-    CHECK(sk1 != sk2);
-
-    auto const [pk3, sk3] = randomKeyPair(KeyType::ed25519);
-    auto const [pk4, sk4] = randomKeyPair(KeyType::ed25519);
-
-    CHECK(pk3 != pk4);
-    CHECK(sk3 != sk4);
-
-    // Cross-type comparisons
-    CHECK(pk1 != pk3);
-    CHECK(pk2 != pk4);
-}
-
-TEST_SUITE_END();