ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
13,865 Commits 236 Branches 183 Tags
767f423ec4ec920aba01a44bece1884b08ff0160
Commit Graph

13865 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pratik Mankawde
767f423ec4 Phase 8: Log-trace correlation with Loki and filelog receiver 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:25:00 +00:00
Pratik Mankawde
3c6d7f1c48 Phase 7: Native OTel metrics migration 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:23:51 +00:00
Pratik Mankawde
73443096e5 Phase 6: StatsD metrics integration into telemetry pipeline 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:21:55 +00:00
Pratik Mankawde
94bef31c84 Phase 5b: Ledger, peer, and tx spans with expanded Grafana dashboards 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:19:28 +00:00
Pratik Mankawde
0fc3f6b5c2 Phase 5: Documentation, deployment configs, integration test infrastructure 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:18:33 +00:00
Pratik Mankawde
41e4f0a240 Phase 4: Consensus tracing - round lifecycle, proposals, validations, close time 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:18:12 +00:00
Pratik Mankawde
b4e5a60e7c Phase 4: Consensus tracing - round lifecycle, proposals, validations, close time 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:17:59 +00:00
Pratik Mankawde
9d62d6d4cd Phase 3: Transaction tracing - protobuf context propagation, PeerImp, NetworkOPs 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:17:37 +00:00
Pratik Mankawde
9b0ce6da08 Phase 2: RPC tracing - span macros, attributes, WebSocket, command spans 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:17:05 +00:00
Pratik Mankawde
833559c183 Phase 1b: Telemetry core infrastructure - CMake, Conan, SpanGuard, config 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:15:00 +00:00
Pratik Mankawde
26bc7e7321 Phase 1c: RPC integration - ServerHandler tracing, telemetry config wiring 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:14:41 +00:00
Pratik Mankawde
a726c62885 Phase 1b: Telemetry core infrastructure - CMake, Conan, SpanGuard, config 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:14:41 +00:00
Pratik Mankawde
6c39ad86ef Phase 1b: Telemetry core infrastructure - CMake, Conan, SpanGuard, config 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:14:20 +00:00
Pratik Mankawde
180838d985 docs: correct OTel overhead estimates against SDK benchmarks 
Verified CPU, memory, and network overhead calculations against
official OTel C++ SDK benchmarks (969 CI runs) and source code
analysis. Key corrections:

- Span creation: 200-500ns → 500-1000ns (SDK BM_SpanCreation median
  ~1000ns; original estimate matched API no-op, not SDK path)
- Per-TX overhead: 2.4μs → 4.0μs (2.0% vs 1.2%; still within 1-3%)
- Active span memory: ~200 bytes → ~500-800 bytes (Span wrapper +
  SpanData + std::map attribute storage)
- Static memory: ~456KB → ~8.3MB (BatchSpanProcessor worker thread
  stack ~8MB was omitted)
- Total memory ceiling: ~2.3MB → ~10MB
- Memory success metric target: <5MB → <10MB
- AddEvent: 50-80ns → 100-200ns

Added Section 3.5.4 with links to all benchmark sources.
Updated presentation.md with matching corrections.
High-level conclusions unchanged (1-3% CPU, negligible consensus).

Also includes: review fixes, cross-document consistency improvements,
additional component tracing docs (PathFinding, TxQ, Validator, etc.),
context size corrections (32 → 25 bytes).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-24 19:11:12 +00:00
Pratik Mankawde
9ff66f03a6 Merge branch 'develop' into pratik/otel-phase1a-plan-docs 2026-03-24 16:33:15 +00:00
Pratik Mankawde
30d1c286c9 Merge remote-tracking branch 'origin/develop' into pratik/otel-phase1a-plan-docs 2026-03-24 16:26:14 +00:00
Pratik Mankawde
402933af78 moved presentation.md file 
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
 2026-03-24 16:26:03 +00:00
Alex Kremer
0eedefbf45 refactor: Enable more clang-tidy readability checks (#6595) 
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com>
 2026-03-24 15:42:12 +00:00
Mayukha Vadari
8b986e4ab0 refactor: Improve imports to only call the needed helpers (#6624) 2026-03-24 10:20:32 +00:00
Olek
dcfcdab14e fix: Remove superfluous view update from credentials (#6545) 2026-03-23 18:29:34 +00:00
Mayukha Vadari
e0dbe90370 refactor: Move ledger entry helper functions from View.h/View.cpp to dedicated helper files (#6453) 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-03-23 15:39:58 +00:00
dependabot[bot]
c463d0ff06 ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.2 to 5.5.3 (#6615) 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2026-03-23 14:04:22 +00:00
Mayukha Vadari
be1cc48d84 fix: Assorted Oracle fixes (#6570) 2026-03-22 18:08:18 +00:00
Pratik Mankawde
346927d673 Merge branch 'develop' into pratik/otel-phase1a-plan-docs 2026-03-20 16:55:10 +00:00
Ayaz Salikhov
cf2eb149ee fix: Update .git-blame-ignore-revs (#6577) 2026-03-19 22:48:20 +00:00
Ayaz Salikhov
762922a07f chore: Don't allow files more than 400kb to be added to the repo (#6597) 2026-03-19 21:20:56 +00:00
Bart
fd28656ded ci: Check for signed commits in PR (#6559) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
 2026-03-19 17:38:09 +00:00
Ayaz Salikhov
9316da784a ci: Update XRPLF/actions (#6594) 2026-03-19 17:29:22 +00:00
Michael Legleux
6efd31229a fix: Use correct format and event for workflows for release tags (#6554) 2026-03-19 10:23:51 +00:00
Alex Kremer
12954d5392 fix: Address remaining issue after clang-tidy merge (#6582) 2026-03-18 22:41:09 +00:00
Jingchen
b1e5ba0518 feat: Add code generator for transactions and ledger entries (#6443) 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
 2026-03-18 21:11:51 +00:00
Mayukha Vadari
d360e7c5b6 refactor: Rename transactor files/classes to match the tx name (#6580) 2026-03-18 19:52:07 +00:00
Ayaz Salikhov
804a351773 ci: Use external action implementation of check-pr-title (#6578) 2026-03-18 18:31:42 +00:00
Ayaz Salikhov
697fb64e8c ci: Don't check PR title for drafts (#6573) 2026-03-18 17:46:27 +00:00
Alex Kremer
57e4cbbcd9 refactor: Add simple clang-tidy readability checks (#6556) 
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
 2026-03-18 16:41:49 +00:00
Mayukha Vadari
b92a9a3053 fix: Make assorted NFT fixes (#6566) 
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
 2026-03-18 14:47:59 +00:00
Mayukha Vadari
dcaef828b4 refactor: Replace !=/== tesSuccess with using isTesSuccess (#6409) 
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
 2026-03-18 14:15:10 +00:00
yinyiqian1
6fbeb04d9e fix: Disallow empty permission list when Delegate object is absent (#6542) 
This change fixes delegation:
* If the Delegate object is not present, we should disallow empty permission list in DelegateSet preclaim.
* Empty permission list is only allowed to delete the existing Delegate object.
* In `doApply`, permission list being empty returns `tecINTERNAL`, which should not happen.
 2026-03-18 13:39:31 +00:00
Alex Kremer
2a325e7e2c chore: Enable clang-tidy bugprone-use-after-move check (#6476) 2026-03-18 00:12:06 +00:00
Bart
808e814489 ci: Update check-pr-title action hash (#6572) 2026-03-17 23:26:01 +00:00
Copilot
9e14707e77 fix: Peer crawler port field type inconsistency (#6318) 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>
Co-authored-by: Mayukha Vadari <mvadari@gmail.com>
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
 2026-03-17 22:03:56 +00:00
Mayukha Vadari
95a45d7442 chore: Add comment explaining why ammLPHolds is called twice (#6546) 2026-03-17 20:11:36 +00:00
Bart
5fc4ab3e37 ci: Let required runs be triggered by merge group events (#6563) 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
 2026-03-17 20:03:48 +00:00
tequ
b129b71c33 refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() (#6560) 2026-03-17 15:56:51 -04:00
tequ
013c2d6a56 refactor: Add const qualifier to SLE in verifyDepositPreauth parameter (#6555) 2026-03-17 19:33:18 +00:00
Alex Kremer
72f4cb097f refactor: Enable remaining clang-tidy cppcoreguidelines checks (#6538) 2026-03-17 19:09:05 +00:00
Michael Legleux
b523770486 fix: Remove nonexistent boost::coroutine2 library (#6561) 2026-03-17 18:46:46 +00:00
Mayukha Vadari
a5185890ff refactor: Remove dead code in escrow helper logic (#6553) 2026-03-17 18:13:08 +00:00
Jingchen
0a9513e7f3 ci: Fix build errors on Windows (#6562) 2026-03-17 13:50:44 -04:00
Pratik Mankawde
3cc13976dc Remove effort estimates from implementation phases document 
Strip effort/risk columns from task tables and remove the §6.9 Effort
Summary section with its pie chart and resource requirements table.
Renumber §6.10 Quick Wins → §6.9.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-03-17 15:00:19 +00:00