ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-03 12:11:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Remove dead code in escrow helper logic (#6553)

Browse Source
This commit is contained in:
Mayukha Vadari
2026-03-17 14:13:08 -04:00
committed by GitHub
parent 0a9513e7f3
commit a5185890ff
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libxrpl/tx/transactors/escrow/EscrowHelpers.h
View File

@@ -42,7 +42,6 @@ escrowUnlockApplyHelper<Issue>(
bool const recvLow = issuer > receiver;
bool const senderIssuer = issuer == sender;
bool const receiverIssuer = issuer == receiver;
bool const issuerHigh = issuer > receiver;
if (senderIssuer)
return tecINTERNAL; // LCOV_EXCL_LINE
@@ -50,7 +49,7 @@ escrowUnlockApplyHelper<Issue>(
if (receiverIssuer)
return tesSUCCESS;
if (!view.exists(trustLineKey) && createAsset && !receiverIssuer)
if (!view.exists(trustLineKey) && createAsset)
{
// Can the account cover the trust line's reserve?
if (std::uint32_t const ownerCount = {sleDest->at(sfOwnerCount)};
@@ -129,12 +128,12 @@ escrowUnlockApplyHelper<Issue>(
// if the issuer is the high, then we use the low limit
// otherwise we use the high limit
STAmount const lineLimit =
sleRippleState->getFieldAmount(issuerHigh ? sfLowLimit : sfHighLimit);
sleRippleState->getFieldAmount(recvLow ? sfLowLimit : sfHighLimit);
STAmount lineBalance = sleRippleState->getFieldAmount(sfBalance);
// flip the sign of the line balance if the issuer is not high
if (!issuerHigh)
if (!recvLow)
lineBalance.negate();
// add the final amount to the line balance