* XRPLF/ximinez/number-division-accuracy:
CI feedback: Add test cases covering other rounding modes
Apply suggestions from code review
Accept AI suggestion
Update the testUpwardRoundsDown test to run under all scales
Review feedback from Tapanito and AI
Skip clang-tidy false positive: misc-include-cleaner
ci: Run PR title and description checks on staging and release branches (7331)
style: Run shfmt on workflows, actions and markdown bash code (7333)
Remove TMax entirely from normalizeToRange; check type matching directly
Tweak how the denominator is handled in division
Minor fixes: missing include, variable init, typo
Test optimization: Number_test::pow10
Significant rewrite
Use the local range instead of calling a function
Make Number::operator/= significantly more accurate
- Add missing headers.
- Improve code coverage exclusions.
- Clean up several variable names.
- Improve explanatory comments.
- Remove the switch statement from MantissaRange::getMin. Change it to
a straight power of ten lookup.
* XRPLF/develop:
release: Bump version to 3.2.0-rc2 (7348)
refactor: Enable support for `fixCleanup3_2_0` amendment (7347)
release: Bump version to 3.2.0-rc1 (7335)
fix: Fix a rounding error at the `Number::maxRep` cusp (7051)
- Simplify Number::operator/= to use more constexpr values, and fewer
variations.
- Most significantly, rounding up doesn't need more precision, it only
needs to know if there's a remainder after the current precision work
is done. Tracked similarly Guard::xbit_.
- Build a constexpr lookup array for powers of 10. Only a handful of
values are used, but since it's built at compile time, and constexpr,
unused values do not affect memory or performance.
* XRPLF/ximinez/number-fix-maxrepcusp:
Fix more AMM tests, and to not exclude fixCleanup3_2_0
docs: Add --parallel flag to cmake build commands in BUILD.md (7302)
fix: Fix wrong hybrid offer orderbook placement and update `LedgerStateFix` to amend `ExchangeRate` meta (7087)
Change the priority of the amendments for large mantissas
Apply suggestions from @Tapanito code review
Apply suggestions from Copilot code review
Review feedback from @tapanito: lambda checks condition in doRoundUp
style: More clang-tidy identifier renaming (7290)
fix: Update pDEX invariant firing under a valid offer deletion (7118)
fix: Fix multisign and signfor to check for delegate (7064)
refactor: Fix `sfGeneric` and `sfInvalid` field names (7300)
docs: Fix some comments to improve readability (7122)
feat: Propagate underlying MPT flags to vault shares (7077)
- Order the checks so that large mantissa is only enabled if SAV or LP
are enabled. fixCleanup3_2_0 only enables the rounding fix.
- Fix tests, and don't exclude fixCleanup3_2_0 in AMM tests
- Also fix formatting
* XRPLF/ximinez/number-fix-maxrepcusp:
fix: Disable unnecessary sanity-check in VaultDeposit (7288)
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (7286)
ci: Only run reusable package in public repos (7293)
fix: Set default peering port to 2459 (6848)
fix: Use account ledger entry when canceling token escrows (6171)
refactor: Rename `account_` to `accountID_` (7284)
ci: Add Linux package builds (DEB + RPM) to CI (6639)
refactor: Clean up comments post-clang-tidy changes (7283)
release: Set version to 3.3.0-b0 (7280)
refactor: Rename static constants (7120)
refactor: Use `isFlag` where possible instead of bitwise math (7278)
ci: Update XRPLF/actions (7281)
clang-tidy: this is ridiculous
clang-tidy: {}
* XRPLF/develop:
release: Set version to 3.3.0-b0 (7280)
refactor: Rename static constants (7120)
refactor: Use `isFlag` where possible instead of bitwise math (7278)
ci: Update XRPLF/actions (7281)
- Refactor the Guard decision in withTxnType into createGuards, which
lives in Rules.cpp. It is physically located near
setCurrentTransactionRules, and documented to explain that changes
need to be synchronized.
* mywork/ximinez/number-fix-maxrepcusp:
Address more nitpicky AI comments
What is it going to take to get clang-tidy to shut up?
More clang-tidy changes: AMMExtended_test member and Number_test includes
Fix clang-tidy issues, and more AI complaints
Fix AI-identified mistakes
fix: Fix a rounding error at the Number::maxRep cusp
- Add helper function, doDropDigit, to wrap the common pattern:
push(mantissa % 10);
mantissa /= 10;
++exponent;
- Might have been helpful to catch this issue when developing.
* XRPLF/develop:
refactor: Revert certain `Throw`s by `LogicError`s (7036)
ci: Rename print-env -> print-build-env (7061)
fix: Gate -mcmodel flags to x86_64 in sanitizer builds (7049)
fix: Prevents overwriting a bool value in an invariant (6609)
fix: Address code review comments regarding `boost::coroutine2` (6977)
refactor: Apply various minor improvements and corrections (7045)
fix: Store `Delegate` object in delegating and authorized account directories for proper deletion (6681)
ci: Use print-env from XRPLF/actions (7052)
fix: Make assorted RPC fixes (6529)
chore: Enable clang-tidy v21 new checks (7031)
* XRPLF/develop:
fix: Disallow MPTClearRequireAuth if is set (6712)
feat: Add GRPC TLS support (6374)
fix: Check for empty `sfAdditionalBooks` array in hybrid offer invariant (6716)
chore: Remove repetitive word in multiple files (6978)
ci: Add workflow to check PR description has been filled (6965)
ci: [DEPENDABOT] Bump tj-actions/changed-files from 47.0.5 to 47.0.6 (6973)
chore: Enable clang-tidy include cleaner (6947)
fix: Change AMMClawback return code to tecNO_PERMISSION (6946)
ci: [DEPENDABOT] bump actions/upload-pages-artifact from 4.0.0 to 5.0.0 (6927)
ci: [DEPENDABOT] bump actions/upload-artifact from 7.0.0 to 7.0.1 (6928)
chore: Enable clang-tidy readability checks (6930)
- Simplify shiftExponent().
- Clean up to_string() to prevent integers from including "e0".
- Fix root() and root2() computations by ensuring the mantissas have
a consistent length.
