ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-22 06:40:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixup! fixup! fixup! Address review feedback from @copilot

Browse Source
This commit is contained in:
Ed Hennis
2026-02-05 19:56:18 -05:00
parent cc2406bf3f
commit f19ecb3b80
2 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/xrpl/basics/Number.h
View File

@@ -625,10 +625,10 @@ private:
/** Rebuilds the number from components.
*
* If "normalized" is true, the values are expected to be normalized - all
* If "expectNormal" is true, the values are expected to be normalized - all
* in their valid ranges.
*
* If "normalized" is false, the values are expected to be "near
* If "expectNormal" is false, the values are expected to be "near
* normalized", meaning that the mantissa has to be modified at most once to
* bring it back into range.
*
@@ -639,10 +639,10 @@ private:
/** Rebuilds the number from components.
*
* If "normalized" is true, the values are expected to be normalized - all
* If "expectNormal" is true, the values are expected to be normalized - all
* in their valid ranges.
*
* If "normalized" is false, the values are expected to be "near
* If "expectNormal" is false, the values are expected to be "near
* normalized", meaning that the mantissa has to be modified at most once to
* bring it back into range.
*
@@ -827,7 +827,6 @@ std::pair<T, int>
Number::normalizeToRange(T minMantissa, T maxMantissa) const
{
bool negative = mantissa_ < 0;
auto const sign = negative ? -1 : 1;
internalrep mantissa = externalToInternal(mantissa_);
int exponent = exponent_;

11
src/libxrpl/basics/Number.cpp
View File

@@ -323,7 +323,6 @@ Number::toInternal(MantissaRange const& range) const
{
auto exponent = exponent_;
bool const negative = mantissa_ < 0;
auto const sign = negative ? -1 : 1;
// It should be impossible for mantissa_ to be INT64_MIN, but use externalToInternal just in case.
Rep mantissa = static_cast<Rep>(externalToInternal(mantissa_));
@@ -358,10 +357,10 @@ Number::toInternal() const
/** Rebuilds the number from components.
*
* If "normalized" is true, the values are expected to be normalized - all
* If "expectNormal" is true, the values are expected to be normalized - all
* in their valid ranges.
*
* If "normalized" is false, the values are expected to be "near
* If "expectNormal" is false, the values are expected to be "near
* normalized", meaning that the mantissa has to be modified at most once to
* bring it back into range.
*
@@ -390,8 +389,6 @@ Number::fromInternal(bool negative, Rep mantissa, int exponent, MantissaRange co
mantissa >= minMantissa && mantissa <= maxMantissa, "xrpl::Number::fromInternal", "mantissa in range");
}
auto const sign = negative ? -1 : 1;
// mantissa is unsigned, but it might not be uint64
mantissa_ = static_cast<rep>(static_cast<internalrep>(mantissa));
if (negative)
@@ -404,10 +401,10 @@ Number::fromInternal(bool negative, Rep mantissa, int exponent, MantissaRange co
/** Rebuilds the number from components.
*
* If "normalized" is true, the values are expected to be normalized - all in
* If "expectNormal" is true, the values are expected to be normalized - all in
* their valid ranges.
*
* If "normalized" is false, the values are expected to be "near normalized",
* If "expectNormal" is false, the values are expected to be "near normalized",
* meaning that the mantissa has to be modified at most once to bring it back
* into range.
*