ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-10-02 17:58:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from AI code review

Browse Source 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Ed Hennis
2026-06-12 19:29:01 -04:00
committed by GitHub
parent 305977058b
commit 095e14193e
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/app/Vault_test.cpp
View File

@@ -5846,7 +5846,7 @@ class Vault_test : public beast::unit_test::Suite
// This value will be rounded
auto const insertAt = maxInt64Plus2.size() - 3;
auto const decimalTest = maxInt64Plus2.substr(0, insertAt) + "." +
maxInt64Plus2.substr(insertAt); // (max int64+1) / 1000
maxInt64Plus2.substr(insertAt); // (max int64+2) / 1000
BEAST_EXPECT(decimalTest == "9223372036854775.809");
tx[sfAssetsMaximum] = decimalTest;
auto const newKeylet = keylet::vault(owner.id(), env.seq(owner));
@@ -5898,7 +5898,7 @@ class Vault_test : public beast::unit_test::Suite
// This value will be rounded
auto const insertAt = maxInt64Plus2.size() - 1;
auto const decimalTest = maxInt64Plus2.substr(0, insertAt) + "." +
maxInt64Plus2.substr(insertAt); // (max int64+1) / 10
maxInt64Plus2.substr(insertAt); // (max int64+2) / 10
BEAST_EXPECT(decimalTest == "922337203685477580.9");
tx[sfAssetsMaximum] = decimalTest;
auto const newKeylet = keylet::vault(owner.id(), env.seq(owner));
@@ -5950,7 +5950,7 @@ class Vault_test : public beast::unit_test::Suite
{
auto const insertAt = maxInt64Plus2.size() - 1;
auto const decimalTest = maxInt64Plus2.substr(0, insertAt) + "." +
maxInt64Plus2.substr(insertAt); // (max int64+1) / 10
maxInt64Plus2.substr(insertAt); // (max int64+2) / 10
BEAST_EXPECT(decimalTest == "922337203685477580.9");
tx[sfAssetsMaximum] = decimalTest;
auto const newKeylet = keylet::vault(owner.id(), env.seq(owner));

3
src/test/basics/Number_test.cpp
View File

@@ -2267,8 +2267,7 @@ public:
}
{
testcase << "normalization cusp: ToNearest and Downward disagree " << to_string(scale);
testcase << "normalization cusp: ToNearest and Downward behavior " << to_string(scale);
constexpr auto kMaxRep = Number::kMaxRep;
// Both ToNearest and Downward should round to `below`