ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-18 21:10:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'XRPLF/ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep

Browse Source 
* XRPLF/ximinez/number-round-maxrep-down:
  Apply suggestions from AI code review
This commit is contained in:
Ed Hennis
2026-06-12 19:08:04 -04:00
parent 1ef0c5ab44 b30a70bbf8
commit 305977058b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/xrpl/basics/Number.h
View File

@@ -52,7 +52,7 @@ namespace detail {
* inefficient.
*/
constexpr std::size_t kUint64Digits = 20;
constexpr std::size_t kUint128Digits = 39;
[[maybe_unused]] constexpr std::size_t kUint128Digits = 39;
template <typename T, std::size_t Digits>
consteval std::array<T, Digits>

2
src/libxrpl/basics/Number.cpp
View File

@@ -212,7 +212,7 @@ concept UnsignedMantissa = std::is_unsigned_v<T> || std::is_same_v<T, uint128_t>
precision to an operation. This enables the final result
to be correctly rounded to the internal precision of Number.
At it's core, the Guard really only needs three pieces of information to determine how to round:
At its core, the Guard really only needs three pieces of information to determine how to round:
1. The rounding mode
2. The last digit dropped from the mantissa (i.e. the first digit after the decimal point).
(first byte of digits_)