Fix BEAST_ENHANCED_LOGGING not working and restore original behavior

Merge fixAMMClawbackRounding amendment into featureAMMClawback amendment
fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513 )
2026-03-10 06:32:22 +00:00 · 2026-03-06 20:58:07 +09:00 · 2026-02-25 19:07:45 +10:00 · 2026-02-25 19:07:45 +10:00 · 2026-02-25 16:20:43 +10:00 · 2026-02-25 16:20:43 +10:00
1 changed files with 11 additions and 0 deletions
--- a/cmake/RippledCore.cmake
+++ b/cmake/RippledCore.cmake
@@ -68,6 +68,17 @@ target_link_libraries(xrpl.imports.main
    $<$<BOOL:${voidstar}>:antithesis-sdk-cpp>
 )

+# date-tz for enhanced logging (always linked, code is #ifdef guarded)
+if(TARGET date::date-tz)
+  target_link_libraries(xrpl.imports.main INTERFACE date::date-tz)
+endif()
+
+# BEAST_ENHANCED_LOGGING: enable for Debug builds OR when explicitly requested
+# Uses generator expression so it works with multi-config generators (Xcode, VS, Ninja Multi-Config)
+target_compile_definitions(xrpl.imports.main INTERFACE
+  $<$<OR:$<CONFIG:Debug>,$<BOOL:${BEAST_ENHANCED_LOGGING}>>:BEAST_ENHANCED_LOGGING=1>
+)
+
 include(add_module)
 include(target_link_modules)
Author	SHA1	Message	Date
tequ	c7e5801a35	Fix BEAST_ENHANCED_LOGGING not working and restore original behavior	2026-03-06 20:58:07 +09:00
tequ	8cfee6c8a3	Merge fixAMMClawbackRounding amendment into featureAMMClawback amendment	2026-02-25 19:07:45 +10:00
yinyiqian1	8673599d2b	fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513 ) Due to rounding, the LPTokenBalance of the last LP might not match the LP's trustline balance. This was fixed for `AMMWithdraw` in `fixAMMv1_1` by adjusting the LPTokenBalance to be the same as the trustline balance. Since `AMMClawback` is also performing a withdrawal, we need to adjust LPTokenBalance as well in `AMMClawback.` This change includes: 1. Refactored `verifyAndAdjustLPTokenBalance` function in `AMMUtils`, which both`AMMWithdraw` and `AMMClawback` call to adjust LPTokenBalance. 2. Added the unit test `testLastHolderLPTokenBalance` to test the scenario. 3. Modify the existing unit tests for `fixAMMClawbackRounding`.	2026-02-25 19:07:45 +10:00
tequ	ec65e622aa	Merge fixAMMv1_3 amendment into featureAMM amendment	2026-02-25 16:20:43 +10:00
Gregory Tsipenyuk	65837f49e1	fix: Add AMMv1_3 amendment (#5203 ) * Add AMM bid/create/deposit/swap/withdraw/vote invariants: - Deposit, Withdrawal invariants: `sqrt(asset1Balance * asset2Balance) >= LPTokens`. - Bid: `sqrt(asset1Balance * asset2Balance) > LPTokens` and the pool balances don't change. - Create: `sqrt(asset1Balance * assetBalance2) == LPTokens`. - Swap: `asset1BalanceAfter * asset2BalanceAfter >= asset1BalanceBefore * asset2BalanceBefore` and `LPTokens` don't change. - Vote: `LPTokens` and pool balances don't change. - All AMM and swap transactions: amounts and tokens are greater than zero, except on withdrawal if all tokens are withdrawn. * Add AMM deposit and withdraw rounding to ensure AMM invariant: - On deposit, tokens out are rounded downward and deposit amount is rounded upward. - On withdrawal, tokens in are rounded upward and withdrawal amount is rounded downward. * Add Order Book Offer invariant to verify consumed amounts. Consumed amounts are less than the offer. * Fix Bid validation. `AuthAccount` can't have duplicate accounts or the submitter account.	2026-02-25 16:20:43 +10:00