actions/upload-artifact@v7

Due to rounding, the LPTokenBalance of the last LP might not match the LP's trustline balance. This was fixed for `AMMWithdraw` in `fixAMMv1_1` by adjusting the LPTokenBalance to be the same as the trustline balance. Since `AMMClawback` is also performing a withdrawal, we need to adjust LPTokenBalance as well in `AMMClawback.`

This change includes:
1. Refactored `verifyAndAdjustLPTokenBalance` function in `AMMUtils`, which both`AMMWithdraw` and `AMMClawback` call to adjust LPTokenBalance.
2. Added the unit test `testLastHolderLPTokenBalance` to test the scenario.
3. Modify the existing unit tests for `fixAMMClawbackRounding`.

.github/workflows/xahau-ga-nix.yml

@@ -375,3 +375,15 @@ jobs:
              echo "Error: rippled executable not found in ${{ env.build_dir }}"
              exit 1
           fi
+
+      - name: Export server definitions
+        run: |
+          ${{ env.build_dir }}/rippled --definitions | python3 -m json.tool > server_definitions.json
+
+      - name: Upload server definitions
+        if: matrix.compiler_id == 'gcc-13-libstdcxx'
+        uses: actions/upload-artifact@v7
+        with:
+          name: server-definitions
+          path: server_definitions.json
+          archive: false

src/xrpld/app/main/Main.cpp

@@ -24,6 +24,7 @@
 #include <xrpld/core/TimeKeeper.h>
 #include <xrpld/net/RPCCall.h>
 #include <xrpld/rpc/RPCHandler.h>
+#include <xrpld/rpc/handlers/Handlers.h>
 #include <xrpl/basics/Log.h>
 #include <xrpl/basics/StringUtilities.h>
 #include <xrpl/basics/contract.h>
@@ -387,7 +388,8 @@ run(int argc, char** argv)
          po::value<std::string>(),
          "Specify the range of present ledgers for testing purposes. Min and "
          "max values are comma separated.")(
-            "version", "Display the build version.");
+            "version", "Display the build version.")(
+            "definitions", "Output server definitions as JSON and exit.");
 
     po::options_description data("Ledger/Data Options");
     data.add_options()("import", importText.c_str())(
@@ -529,6 +531,13 @@ run(int argc, char** argv)
         return 0;
     }
 
+    if (vm.count("definitions"))
+    {
+        auto defs = getStaticServerDefinitions();
+        std::cout << Json::FastWriter().write(defs);
+        return 0;
+    }
+
 #ifndef ENABLE_TESTS
     if (vm.count("unittest") || vm.count("unittest-child"))
     {

src/xrpld/rpc/handlers/Handlers.h

@@ -129,6 +129,8 @@ doRipplePathFind(RPC::JsonContext&);
 Json::Value
 doServerDefinitions(RPC::JsonContext&);
 Json::Value
+getStaticServerDefinitions();
+Json::Value
 doServerInfo(RPC::JsonContext&);  // for humans
 Json::Value
 doServerState(RPC::JsonContext&);  // for machines

src/xrpld/rpc/handlers/ServerDefinitions.cpp

@@ -523,6 +523,15 @@ public:
     }
 };
 
+Json::Value
+getStaticServerDefinitions()
+{
+    static const Definitions defs{};
+    Json::Value ret = defs();
+    ret[jss::hash] = to_string(defs.getHash());
+    return ret;
+}
+
 Json::Value
 doServerDefinitions(RPC::JsonContext& context)
 {