chore: remove stale branch TODO comments

This commit is contained in:
Nicholas Dudfield
2026-06-24 12:48:52 +07:00
parent e55bf43986
commit f6d986bdbc
3 changed files with 6 additions and 10 deletions

View File

@@ -84,10 +84,6 @@ struct ExtendedPosition
txSetHash = set;
}
// TODO: replace operator== with a named method (e.g. txSetMatches())
// so call sites read as intent, not as "full equality". Overloading
// operator== to ignore most fields is surprising and fragile.
//
// CRITICAL: Only compare txSetHash for consensus convergence.
//
// Why not commitSetHash / entropySetHash?

View File

@@ -755,8 +755,9 @@ Import::preflight(PreflightContext const& ctx)
JLOG(ctx.j.trace()) << "totalValidatorCount: " << totalValidatorCount;
// TODO: upgrade to calculateQuorumThreshold() (ceiling) if Import is
// extended to handle Export transactions (symmetric import).
// Burn-to-mint import retains the legacy truncated 80% quorum calculation.
// If Import is extended to consume Export transactions directly, use
// calculateQuorumThreshold() for symmetry with Export/validator quorum.
uint64_t quorum = totalValidatorCount * 0.8;
if (quorum == 0)

View File

@@ -445,10 +445,9 @@ SetHook::validateHookSetEntry(SetHookCtx& ctx, STObject const& hookSetObj)
}
auto version = hookSetObj.getFieldU16(sfHookApiVersion);
// TODO: clarify API version history - version 1 was possibly
// JSHooks? For now only version 0 is valid. Export APIs (xport,
// xport_reserve) are gated by featureExport amendment via
// rulesVersion, not by sfHookApiVersion.
// Hook bytecode ABI version remains 0. New hook APIs such as
// xport/xport_reserve are exposed through amendment-gated rules,
// not by accepting a new sfHookApiVersion value here.
if (version != 0)
{
// we currently only accept api version 0