From f6d986bdbc2b2125e905748cfda98934ff5b6356 Mon Sep 17 00:00:00 2001 From: Nicholas Dudfield Date: Wed, 24 Jun 2026 12:48:52 +0700 Subject: [PATCH] chore: remove stale branch TODO comments --- src/xrpld/app/consensus/RCLCxPeerPos.h | 4 ---- src/xrpld/app/tx/detail/Import.cpp | 5 +++-- src/xrpld/app/tx/detail/SetHook.cpp | 7 +++---- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/xrpld/app/consensus/RCLCxPeerPos.h b/src/xrpld/app/consensus/RCLCxPeerPos.h index 6093ad4e3..6c4a1e143 100644 --- a/src/xrpld/app/consensus/RCLCxPeerPos.h +++ b/src/xrpld/app/consensus/RCLCxPeerPos.h @@ -84,10 +84,6 @@ struct ExtendedPosition txSetHash = set; } - // TODO: replace operator== with a named method (e.g. txSetMatches()) - // so call sites read as intent, not as "full equality". Overloading - // operator== to ignore most fields is surprising and fragile. - // // CRITICAL: Only compare txSetHash for consensus convergence. // // Why not commitSetHash / entropySetHash? diff --git a/src/xrpld/app/tx/detail/Import.cpp b/src/xrpld/app/tx/detail/Import.cpp index c48550e0f..45318de01 100644 --- a/src/xrpld/app/tx/detail/Import.cpp +++ b/src/xrpld/app/tx/detail/Import.cpp @@ -755,8 +755,9 @@ Import::preflight(PreflightContext const& ctx) JLOG(ctx.j.trace()) << "totalValidatorCount: " << totalValidatorCount; - // TODO: upgrade to calculateQuorumThreshold() (ceiling) if Import is - // extended to handle Export transactions (symmetric import). + // Burn-to-mint import retains the legacy truncated 80% quorum calculation. + // If Import is extended to consume Export transactions directly, use + // calculateQuorumThreshold() for symmetry with Export/validator quorum. uint64_t quorum = totalValidatorCount * 0.8; if (quorum == 0) diff --git a/src/xrpld/app/tx/detail/SetHook.cpp b/src/xrpld/app/tx/detail/SetHook.cpp index f59b5c95f..c060530bd 100644 --- a/src/xrpld/app/tx/detail/SetHook.cpp +++ b/src/xrpld/app/tx/detail/SetHook.cpp @@ -445,10 +445,9 @@ SetHook::validateHookSetEntry(SetHookCtx& ctx, STObject const& hookSetObj) } auto version = hookSetObj.getFieldU16(sfHookApiVersion); - // TODO: clarify API version history - version 1 was possibly - // JSHooks? For now only version 0 is valid. Export APIs (xport, - // xport_reserve) are gated by featureExport amendment via - // rulesVersion, not by sfHookApiVersion. + // Hook bytecode ABI version remains 0. New hook APIs such as + // xport/xport_reserve are exposed through amendment-gated rules, + // not by accepting a new sfHookApiVersion value here. if (version != 0) { // we currently only accept api version 0