Merge branch 'transia-beta' into amm

update definitions
refactor isIssue to isCurrency
2025-11-06 22:05:48 +00:00 · 2023-03-28 19:03:38 +00:00 · 2023-03-28 18:58:05 +00:00 · 2023-02-22 19:22:01 -05:00 · 2023-02-22 18:44:57 -05:00 · 2023-02-21 13:12:14 -05:00
2 changed files with 205 additions and 7 deletions
--- a/packages/ripple-binary-codec/src/enums/definitions.json
+++ b/packages/ripple-binary-codec/src/enums/definitions.json
@@ -21,6 +21,7 @@
    "UInt192": 21,
    "UInt384": 22,
    "UInt512": 23,
+    "Issue": 24,
    "Transaction": 10001,
    "LedgerEntry": 10002,
    "Validation": 10003,
@@ -44,6 +45,7 @@
    "NegativeUNL": 78,
    "NFTokenPage": 80,
    "NFTokenOffer": 55,
+    "AMM": 121,
    "URIToken": 85,
    "Any": -3,
    "Child": -2,
@@ -276,6 +278,16 @@
        "type": "UInt16"
      }
    ],
+    [
+      "TradingFee",
+      {
+        "nth": 5,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "UInt16"
+      }
+    ],
    [
      "Version",
      {
@@ -777,7 +789,7 @@
      }
    ],
    [
-      "LockCount",
+      "VoteWeight",
      {
        "nth": 47,
        "isVLEncoded": false,
@@ -786,6 +798,16 @@
        "type": "UInt32"
      }
    ],
+    [
+      "DiscountedFee",
+      {
+        "nth": 48,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "UInt32"
+      }
+    ],
    [
      "IndexNext",
      {
@@ -1126,6 +1148,16 @@
        "type": "Hash256"
      }
    ],
+    [
+      "AMMID",
+      {
+        "nth": 14,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Hash256"
+      }
+    ],
    [
      "BookDirectory",
      {
@@ -1436,6 +1468,36 @@
        "type": "Amount"
      }
    ],
+    [
+      "Amount2",
+      {
+        "nth": 11,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "BidMin",
+      {
+        "nth": 12,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "BidMax",
+      {
+        "nth": 13,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
    [
      "MinimumOffer",
      {
@@ -1477,9 +1539,9 @@
      }
    ],
    [
-      "HookCallbackFee",
+      "BaseFeeDrops",
      {
-        "nth": 20,
+        "nth": 22,
        "isVLEncoded": false,
        "isSerialized": true,
        "isSigningField": true,
@@ -1487,9 +1549,69 @@
      }
    ],
    [
-      "LockedBalance",
+      "ReserveBaseDrops",
      {
-        "nth": 21,
+        "nth": 23,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "ReserveIncrementDrops",
+      {
+        "nth": 24,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "LPTokenOut",
+      {
+        "nth": 25,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "LPTokenIn",
+      {
+        "nth": 26,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "EPrice",
+      {
+        "nth": 27,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "Price",
+      {
+        "nth": 28,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Amount"
+      }
+    ],
+    [
+      "LPTokenBalance",
+      {
+        "nth": 29,
        "isVLEncoded": false,
        "isSerialized": true,
        "isSigningField": true,
@@ -1906,6 +2028,26 @@
        "type": "PathSet"
      }
    ],
+    [
+      "Asset",
+      {
+        "nth": 3,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Issue"
+      }
+    ],
+    [
+      "Asset2",
+      {
+        "nth": 4,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "Issue"
+      }
+    ],
    [
      "TransactionMetaData",
      {
@@ -2116,6 +2258,36 @@
        "type": "STObject"
      }
    ],
+    [
+      "VoteEntry",
+      {
+        "nth": 25,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "STObject"
+      }
+    ],
+    [
+      "AuctionSlot",
+      {
+        "nth": 26,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "STObject"
+      }
+    ],
+    [
+      "AuthAccount",
+      {
+        "nth": 27,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "STObject"
+      }
+    ],
    [
      "Signers",
      {
@@ -2206,6 +2378,16 @@
        "type": "STArray"
      }
    ],
+    [
+      "VoteSlots",
+      {
+        "nth": 12,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "STArray"
+      }
+    ],
    [
      "Majorities",
      {
@@ -2255,6 +2437,16 @@
        "isSigningField": true,
        "type": "STArray"
      }
+    ],
+    [
+      "AuthAccounts",
+      {
+        "nth": 21,
+        "isVLEncoded": false,
+        "isSerialized": true,
+        "isSigningField": true,
+        "type": "STArray"
+      }
    ]
  ],
  "TRANSACTION_RESULTS": {
@@ -2324,7 +2516,6 @@
    "temXCHAIN_TOO_MANY_ATTESTATIONS": -254,
    "temHOOK_DATA_TOO_LARGE": -253,
    "temHOOK_REJECTED": -252,
-
    "tefFAILURE": -199,
    "tefALREADY": -198,
    "tefBAD_ADD_AUTH": -197,
@@ -2359,7 +2550,8 @@
    "terNO_RIPPLE": -90,
    "terQUEUED": -89,
    "terPRE_TICKET": -88,
-    "terNO_HOOK": -87,
+    "terNO_AMM": -87,
+    "terNO_HOOK": -86,

    "tesSUCCESS": 0,

@@ -2466,6 +2658,11 @@
    "NFTokenCreateOffer": 27,
    "NFTokenCancelOffer": 28,
    "NFTokenAcceptOffer": 29,
+    "AMMCreate": 35,
+    "AMMDeposit": 36,
+    "AMMWithdraw": 37,
+    "AMMVote": 38,
+    "AMMBid": 39,
    "URITokenMint": 45,
    "URITokenBurn": 46,
    "URITokenBuy": 47,
--- a/packages/ripple-binary-codec/src/types/index.ts
+++ b/packages/ripple-binary-codec/src/types/index.ts
@@ -50,6 +50,7 @@ export {
  Hash128,
  Hash160,
  Hash256,
+  Issue,
  PathSet,
  STArray,
  STObject,
Author	SHA1	Message	Date
Denis Angell	8eaf7bed7a	Merge branch 'transia-beta' into amm	2023-03-28 19:03:38 +00:00
Denis Angell	6e6fdadeac	update definitions	2023-03-28 18:58:05 +00:00
Omar Khan	f9f210715c	refactor isIssue to isCurrency	2023-02-22 19:22:01 -05:00
Omar Khan	5c7e315826	Merge branch 'main' into amm	2023-02-22 18:44:57 -05:00
Omar Khan	d43fd788d4	update asset pair to use Currency type	2023-02-21 13:12:14 -05:00
Omar Khan	651780fe67	refactor: convert flags to number	2023-02-16 12:37:29 -05:00
Omar Khan	d495903fb4	Merge branch 'main' into amm	2023-02-15 23:26:19 -05:00
Omar Khan	df75b4a908	replace Issue with IssuedCurrency	2023-02-15 23:13:05 -05:00
Omar Khan	d2f7fe622b	add missing asset_frozen field	2023-02-15 18:45:07 -05:00
Omar Khan	7e8427785c	add Owner Reserve Fee for AMMCreate transaction	2023-02-15 18:21:30 -05:00
Omar Khan	287dc1acf8	rename test model names and fix lint errors	2023-02-15 18:18:07 -05:00
Omar Khan	88b82118a3	Merge branch 'main' into amm	2023-02-15 17:53:13 -05:00
Omar Khan	8cdeb2ba99	update time_interval description	2023-01-09 18:13:18 -05:00
Omar Khan	f3d6bd4be4	remove invalid fields from ammInfo.ts response model	2023-01-09 17:51:33 -05:00
Omar Khan	f61cf02618	Merge branch 'main' into amm	2023-01-09 17:47:11 -05:00
Omar Khan	e634db3dd2	update ammInfo.ts response model	2023-01-09 17:43:48 -05:00
Omar Khan	218ca005e1	update definitions.json with refactored error codes	2023-01-09 17:30:05 -05:00
Omar Khan	ec1d8b67a5	refactor amm_info response fields to match AMMDevnet	2022-12-15 13:06:39 -05:00
Omar Khan	2bb4d7712c	Merge branch 'main' into amm	2022-12-15 12:46:56 -05:00
Omar Khan	98f8223b23	add one asset and withdraw all tests	2022-11-17 14:20:57 -05:00
Omar Khan	feafc0c91b	update Issue type	2022-11-17 13:37:45 -05:00
Omar Khan	0970753790	add AMM codec-fixtures	2022-11-17 13:14:25 -05:00
Omar Khan	434ad71672	update unit tests	2022-11-17 09:34:40 -05:00
Omar Khan	7f2b40740a	Merge branch 'main' into amm	2022-11-16 21:27:52 -05:00
Omar Khan	ff65441d33	fix lint errors	2022-11-16 21:24:40 -05:00
Omar Khan	e32db9dd39	update amm_info fields	2022-11-16 21:21:21 -05:00
Omar Khan	64e4242085	remove AMMID from amm_info and use Issue type	2022-11-16 21:03:08 -05:00
Omar Khan	0574fabf47	add Issue type and tests for Asset/Asset2	2022-11-16 20:58:57 -05:00
Omar Khan	40388cc1e5	update definitions	2022-11-16 14:02:24 -05:00
Omar Khan	007717a9d4	Merge branch 'main' into amm	2022-11-16 13:55:34 -05:00
Omar Khan	1c26e8b6d5	update definitions to change Asset & Asset2 nth values to 3 & 4	2022-11-09 15:20:37 -05:00
Omar Khan	eba8bd2ec1	rename MinBidPrice -> BidMin and MaxBidPrice -> BidMax	2022-11-09 15:09:33 -05:00
Omar Khan	bcdd8fe2cf	rename FeeVal -> TradingFee in VoteEntry	2022-11-09 14:59:12 -05:00
Omar Khan	64d8a904f0	add Deposit/Withdraw flags	2022-11-09 13:37:20 -05:00
Omar Khan	6a67715a01	Merge branch 'main' into amm	2022-11-09 11:58:15 -05:00
Omar Khan	25752d77a4	Use Asset/Asset2 instead of AMMID for Deposit/Withdraw/Bid/Vote	2022-11-09 11:51:08 -05:00
Omar Khan	3120abc627	change AMM_MAX_TRADING_FEE to 1%	2022-11-09 10:27:57 -05:00
Omar Khan	c99aa048da	fix typo	2022-11-09 10:21:14 -05:00
Omar Khan	54b86bc1d7	rename amm_info param asset1 -> asset	2022-11-09 10:16:25 -05:00
Omar Khan	acdfbd55e5	API name changes with updated definitions.json	2022-11-09 10:07:39 -05:00
Omar Khan	a76aeb2233	Change amm_info asset parameters to Currency type	2022-10-31 13:55:50 -04:00
Omar Khan	f04037859f	Merge branch 'main' into amm	2022-10-31 13:36:57 -04:00
Omar Khan	a2bce8f513	update definitions.json with different AuthAccounts number	2022-09-15 15:24:42 -04:00
Omar Khan	a80f159e01	fix AMMBid ValidationError	2022-09-14 21:52:54 -04:00
Omar Khan	220d9fb1b0	fix deposit and withdraw tests	2022-09-13 13:53:44 -04:00
Omar Khan	25efafa371	Merge branch 'develop' into amm	2022-09-13 13:49:31 -04:00
Omar Khan	aed4353c6c	update VoteEntry interface	2022-09-05 14:46:47 -04:00
Omar Khan	56b70aa845	add VoteSlots as optional param in AMMInfoResponse	2022-09-05 14:35:19 -04:00
Omar Khan	c0e0c15fc1	fix EPrice validation checks in AMMDeposit & AMMWithdraw	2022-09-02 00:18:45 -04:00
Omar Khan	533c8ab9ac	add AMMID as optional param in ammInfo response	2022-09-02 00:05:48 -04:00
Omar Khan	a174d09489	fix ammInfo response	2022-09-01 23:13:13 -04:00
Omar Khan	85b8a3930b	add negative TradingFee check	2022-08-30 19:09:55 -04:00
Omar Khan	6a06412b2d	update wording on AMMDeposit & AMMWithdraw validation errors	2022-08-30 19:01:08 -04:00
Omar Khan	e9778ebcdb	update HISTORY.md to specify XLS-30	2022-08-30 18:48:54 -04:00
Omar Khan	8ef2483e15	add negative FeeVal check	2022-08-30 18:45:34 -04:00
Omar Khan	6150d33a61	add missing test case Asset1Out and Asset2Out valid	2022-08-30 18:10:40 -04:00
Omar Khan	2796c2aeef	add missing test case Asset1In and Asset2In valid	2022-08-30 18:07:22 -04:00
Omar Khan	e13b27e43f	update definitions to fix AMM in LEDGER_ENTRY_TYPES	2022-08-30 17:45:22 -04:00
Omar Khan	0de755bb0b	update EPrice validation error message and add missing tests	2022-08-30 16:49:48 -04:00
Omar Khan	ed7760c555	fix EPrice type to be Amount	2022-08-30 16:29:49 -04:00
Omar Khan	b8e4f2405a	update amm_info docstrings	2022-08-30 10:59:03 -04:00
Omar Khan	c95f8afc21	add AMMID to AMMInfoResponse	2022-08-28 14:04:13 -04:00
Omar Khan	835dc67767	refactor tests	2022-08-20 10:54:14 -04:00
Omar Khan	4b18f06dbb	add AuthAccount interface to AMMBid	2022-08-20 09:43:33 -04:00
Omar Khan	7a035afca1	add AMMBid	2022-08-20 09:33:53 -04:00
Omar Khan	78e0a866cd	refactor MAX_TRADING_FEE to be in one place	2022-08-19 21:59:30 -04:00
Omar Khan	db6d32f98b	add max trading fee check to AMMVote	2022-08-19 21:48:26 -04:00
Omar Khan	e79dcb5d2f	fix lint error	2022-08-19 17:20:23 -04:00
Omar Khan	b794f909ad	add AMMVote	2022-08-19 17:18:46 -04:00
Omar Khan	3617487c32	add AMMWithdraw	2022-08-18 23:51:16 -04:00
Omar Khan	35fef6512f	use null check for missing fields	2022-08-18 23:11:24 -04:00
Omar Khan	e64a668ef6	add AMMDeposit	2022-08-18 22:19:50 -04:00
Omar Khan	3461fcc929	add amm_info RPC command	2022-08-18 16:00:25 -04:00
Omar Khan	ff60b547e3	update HISTORY.md	2022-08-18 14:14:30 -04:00
Omar Khan	6bcfc2be32	renamed LPTokens to LPToken in definitions.json	2022-08-18 13:38:44 -04:00
Omar Khan	2680c34689	add AMMInstanceCreate	2022-08-17 22:38:31 -04:00
Omar Khan	25bdb692cb	update definitions.json	2022-08-16 14:57:07 -04:00