ARCHIVE/xahau.js
1
0
Fork 0
mirror of https://github.com/Xahau/xahau.js.git synced 2026-08-23 16:40:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

add negative TradingFee check

Browse Source
This commit is contained in:
Omar Khan
2022-08-30 19:09:55 -04:00
parent 6a06412b2d
commit 85b8a3930b
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/xrpl/src/models/transactions/AMMInstanceCreate.ts
View File

@@ -68,9 +68,9 @@ export function validateAMMInstanceCreate(tx: Record<string, unknown>): void {
throw new ValidationError('AMMInstanceCreate: TradingFee must be a number')
}
if (tx.TradingFee > AMM_MAX_TRADING_FEE) {
if (tx.TradingFee < 0 || tx.TradingFee > AMM_MAX_TRADING_FEE) {
throw new ValidationError(
`AMMInstanceCreate: TradingFee must not be greater than ${AMM_MAX_TRADING_FEE}`,
`AMMInstanceCreate: TradingFee must be between 0 and ${AMM_MAX_TRADING_FEE}`,
)
}
}

13
packages/xrpl/test/models/AMMInstanceCreate.ts
View File

@@ -82,12 +82,21 @@ describe('AMMInstanceCreate', function () {
)
})
it(`throws w/ TradingFee must not be greater than 65000`, function () {
it(`throws when TradingFee is greater than 65000`, function () {
instanceCreate.TradingFee = 65001
assert.throws(
() => validate(instanceCreate),
ValidationError,
`AMMInstanceCreate: TradingFee must not be greater than 65000`,
`AMMInstanceCreate: TradingFee must be between 0 and 65000`,
)
})
it(`throws when TradingFee is a negative number`, function () {
instanceCreate.TradingFee = -1
assert.throws(
() => validate(instanceCreate),
ValidationError,
`AMMInstanceCreate: TradingFee must be between 0 and 65000`,
)
})
})