From 85b8a3930b3b4c3a506f41cf5bcc18413bc9e0db Mon Sep 17 00:00:00 2001 From: Omar Khan Date: Tue, 30 Aug 2022 19:09:55 -0400 Subject: [PATCH] add negative TradingFee check --- .../src/models/transactions/AMMInstanceCreate.ts | 4 ++-- packages/xrpl/test/models/AMMInstanceCreate.ts | 13 +++++++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/xrpl/src/models/transactions/AMMInstanceCreate.ts b/packages/xrpl/src/models/transactions/AMMInstanceCreate.ts index dec294e9..23faa330 100644 --- a/packages/xrpl/src/models/transactions/AMMInstanceCreate.ts +++ b/packages/xrpl/src/models/transactions/AMMInstanceCreate.ts @@ -68,9 +68,9 @@ export function validateAMMInstanceCreate(tx: Record): void { throw new ValidationError('AMMInstanceCreate: TradingFee must be a number') } - if (tx.TradingFee > AMM_MAX_TRADING_FEE) { + if (tx.TradingFee < 0 || tx.TradingFee > AMM_MAX_TRADING_FEE) { throw new ValidationError( - `AMMInstanceCreate: TradingFee must not be greater than ${AMM_MAX_TRADING_FEE}`, + `AMMInstanceCreate: TradingFee must be between 0 and ${AMM_MAX_TRADING_FEE}`, ) } } diff --git a/packages/xrpl/test/models/AMMInstanceCreate.ts b/packages/xrpl/test/models/AMMInstanceCreate.ts index 04d2a677..8e4f1597 100644 --- a/packages/xrpl/test/models/AMMInstanceCreate.ts +++ b/packages/xrpl/test/models/AMMInstanceCreate.ts @@ -82,12 +82,21 @@ describe('AMMInstanceCreate', function () { ) }) - it(`throws w/ TradingFee must not be greater than 65000`, function () { + it(`throws when TradingFee is greater than 65000`, function () { instanceCreate.TradingFee = 65001 assert.throws( () => validate(instanceCreate), ValidationError, - `AMMInstanceCreate: TradingFee must not be greater than 65000`, + `AMMInstanceCreate: TradingFee must be between 0 and 65000`, + ) + }) + + it(`throws when TradingFee is a negative number`, function () { + instanceCreate.TradingFee = -1 + assert.throws( + () => validate(instanceCreate), + ValidationError, + `AMMInstanceCreate: TradingFee must be between 0 and 65000`, ) }) })