Merge remote-tracking branch 'XRPLF/develop' into ximinez/acquireAsyncDispatch

* XRPLF/develop: (81 commits) ci: Only publish docs in public repos (6687) chore: Enable remaining clang-tidy `performance` checks (6648) refactor: Address PR comments after the modularisation PRs (6389) chore: Fix clang-tidy header filter (6686) ci: [DEPENDABOT] bump actions/deploy-pages from 4.0.5 to 5.0.0 (6684) ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.3 to 6.0.0 (6685) fix: Guard Coro::resume() against completed coroutines (6608) refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant (6674) ci: Don't publish docs on release branches (6673) refactor: Make function naming in ServiceRegistry consistent (6390) chore: Shorten job names to stay within Linux 15-char thread limit (6669) fix: Improve loan invariant message (6668) ci: Upload artifacts only in public repositories (6670) ci: Add conflicting-pr workflow (6656) chore: Add more AI tools to .gitignore (6658) chore: Show warning message if user may need to connect to VPN (6619) feat: Add placeholder amendment for assorted bug fixes (6652) chore: Update sqlite3->3.51.0, protobuf->6.33.5, openssl->3.6.1, grpc->1.78.1 (6653) refactor: Modularise ledger (6536) chore: Use unpatched version of soci (6649) ...
Merge branch 'develop' into ximinez/acquireAsyncDispatch
2026-04-05 03:22:30 +00:00 · 2026-03-30 22:38:24 -04:00 · 2026-03-12 15:05:10 -04:00 · 2026-03-10 13:38:46 -04:00 · 2026-03-06 13:04:22 -04:00 · 2026-03-04 17:11:47 -04:00
627 changed files with 6084 additions and 6213 deletions
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -78,28 +78,25 @@ Checks: "-*,
  bugprone-unused-return-value,
  bugprone-unused-local-non-trivial-variable,
  bugprone-virtual-near-miss,
-  cppcoreguidelines-init-variables,
-  cppcoreguidelines-misleading-capture-default-by-value,
+  # cppcoreguidelines-init-variables, # has issues
+  # cppcoreguidelines-misleading-capture-default-by-value, # has issues
  cppcoreguidelines-no-suspend-with-lock,
-  cppcoreguidelines-pro-type-member-init,
+  # cppcoreguidelines-pro-type-member-init, # has issues
  cppcoreguidelines-pro-type-static-cast-downcast,
-  cppcoreguidelines-rvalue-reference-param-not-moved,
-  cppcoreguidelines-use-default-member-init,
-  cppcoreguidelines-virtual-class-destructor,
+  # cppcoreguidelines-rvalue-reference-param-not-moved, # has issues
+  # cppcoreguidelines-use-default-member-init, # has issues
+  # cppcoreguidelines-virtual-class-destructor, # has issues
  hicpp-ignored-remove-result,
-  misc-const-correctness,
-  misc-definitions-in-headers,
+  # misc-definitions-in-headers, # has issues
  misc-header-include-cycle,
  misc-misplaced-const,
-  misc-redundant-expression,
  misc-static-assert,
-  misc-throw-by-value-catch-by-reference,
+  # misc-throw-by-value-catch-by-reference, # has issues
  misc-unused-alias-decls,
  misc-unused-using-decls,
  modernize-deprecated-headers,
  modernize-make-shared,
  modernize-make-unique,
-  llvm-namespace-comment,
  performance-faster-string-find,
  performance-for-range-copy,
  performance-implicit-conversion-in-loop,
@@ -137,7 +134,10 @@ Checks: "-*,
 # ---
 # other checks that have issues that need to be resolved:
 #
+# llvm-namespace-comment,
+# misc-const-correctness,
 # misc-include-cleaner,
+# misc-redundant-expression,
 #
 # readability-inconsistent-declaration-parameter-name, # in this codebase this check will break a lot of arg names
 # readability-static-accessed-through-instance,        # this check is probably unnecessary. it makes the code less readable
--- a/.github/scripts/rename/copyright.sh
+++ b/.github/scripts/rename/copyright.sh
@@ -76,11 +76,11 @@ fi
 if ! grep -q 'Dev Null' src/test/rpc/ValidatorInfo_test.cpp; then
  echo -e "// Copyright (c) 2020 Dev Null Productions\n\n$(cat src/test/rpc/ValidatorInfo_test.cpp)" > src/test/rpc/ValidatorInfo_test.cpp
 fi
-if ! grep -q 'Dev Null' src/xrpld/rpc/handlers/server_info/Manifest.cpp; then
-  echo -e "// Copyright (c) 2019 Dev Null Productions\n\n$(cat src/xrpld/rpc/handlers/server_info/Manifest.cpp)" > src/xrpld/rpc/handlers/server_info/Manifest.cpp
+if ! grep -q 'Dev Null' src/xrpld/rpc/handlers/DoManifest.cpp; then
+  echo -e "// Copyright (c) 2019 Dev Null Productions\n\n$(cat src/xrpld/rpc/handlers/DoManifest.cpp)" > src/xrpld/rpc/handlers/DoManifest.cpp
 fi
-if ! grep -q 'Dev Null' src/xrpld/rpc/handlers/admin/status/ValidatorInfo.cpp; then
-  echo -e "// Copyright (c) 2019 Dev Null Productions\n\n$(cat src/xrpld/rpc/handlers/admin/status/ValidatorInfo.cpp)" > src/xrpld/rpc/handlers/admin/status/ValidatorInfo.cpp
+if ! grep -q 'Dev Null' src/xrpld/rpc/handlers/ValidatorInfo.cpp; then
+  echo -e "// Copyright (c) 2019 Dev Null Productions\n\n$(cat src/xrpld/rpc/handlers/ValidatorInfo.cpp)" > src/xrpld/rpc/handlers/ValidatorInfo.cpp
 fi
 if ! grep -q 'Bougalis' include/xrpl/basics/SlabAllocator.h; then
  echo -e "// Copyright (c) 2022, Nikolaos D. Bougalis <nikb@bougalis.net>\n\n$(cat include/xrpl/basics/SlabAllocator.h)" > include/xrpl/basics/SlabAllocator.h # cspell: ignore Nikolaos Bougalis nikb
--- a/.github/workflows/check-pr-commits.yml
+++ b/.github/workflows/check-pr-commits.yml
@@ -1,7 +1,7 @@
 name: Check PR commits

 on:
-  pull_request_target:
+  pull_request:

 # The action needs to have write permissions to post comments on the PR.
 permissions:
@@ -10,4 +10,4 @@ permissions:

 jobs:
  check_commits:
-    uses: XRPLF/actions/.github/workflows/check-pr-commits.yml@e2c7f400d1e85ae65dad552fd425169fbacca4a3
+    uses: XRPLF/actions/.github/workflows/check-pr-commits.yml@481048b78b94ac3343d1292b4ef125a813879f2b
--- a/.github/workflows/check-pr-title.yml
+++ b/.github/workflows/check-pr-title.yml
@@ -11,4 +11,4 @@ on:
 jobs:
  check_title:
    if: ${{ github.event.pull_request.draft != true }}
-    uses: XRPLF/actions/.github/workflows/check-pr-title.yml@a5d8dd35be543365e90a11358447130c8763871d
+    uses: XRPLF/actions/.github/workflows/check-pr-title.yml@e2c7f400d1e85ae65dad552fd425169fbacca4a3
--- a/.github/workflows/pre-commit.yml
+++ b/.github/workflows/pre-commit.yml
@@ -14,7 +14,7 @@ on:
 jobs:
  # Call the workflow in the XRPLF/actions repo that runs the pre-commit hooks.
  run-hooks:
-    uses: XRPLF/actions/.github/workflows/pre-commit.yml@9307df762265e15c745ddcdb38a581c989f7f349
+    uses: XRPLF/actions/.github/workflows/pre-commit.yml@e7896f15cc60d0da1a272c77ee5c4026b424f9c7
    with:
      runs_on: ubuntu-latest
      container: '{ "image": "ghcr.io/xrplf/ci/tools-rippled-pre-commit:sha-41ec7c1" }'
--- a/.github/workflows/publish-docs.yml
+++ b/.github/workflows/publish-docs.yml
@@ -36,7 +36,7 @@ env:
  BUILD_DIR: build
  # ubuntu-latest has only 2 CPUs for private repositories
  # https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for--private-repositories
-  NPROC_SUBTRACT: ${{ github.event.repository.visibility == 'public' && '2' || '1' }}
+  NPROC_SUBTRACT: ${{ github.event.repository.private && '1' || '2' }}

 jobs:
  build:
@@ -47,7 +47,7 @@ jobs:
        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

      - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@90f11ee655d1687824fb8793db770477d52afbab
+        uses: XRPLF/actions/prepare-runner@2bbc2dc1abeec7bfaa886804ab86871ac201764e
        with:
          enable_ccache: false

@@ -81,13 +81,13 @@ jobs:
          cmake --build . --target docs --parallel ${BUILD_NPROC}

      - name: Create documentation artifact
-        if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && github.event_name == 'push' }}
+        if: ${{ github.event.repository.visibility == 'public' && github.event_name == 'push' }}
        uses: actions/upload-pages-artifact@7b1f4a764d45c48632c6b24a0339c27f5614fb0b # v4.0.0
        with:
          path: ${{ env.BUILD_DIR }}/docs/html

  deploy:
-    if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && github.event_name == 'push' }}
+    if: ${{ github.event.repository.visibility == 'public' && github.event_name == 'push' }}
    needs: build
    runs-on: ubuntu-latest
    permissions:
--- a/.github/workflows/reusable-build-test-config.yml
+++ b/.github/workflows/reusable-build-test-config.yml
@@ -107,7 +107,7 @@ jobs:
        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

      - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@90f11ee655d1687824fb8793db770477d52afbab
+        uses: XRPLF/actions/prepare-runner@2bbc2dc1abeec7bfaa886804ab86871ac201764e
        with:
          enable_ccache: ${{ inputs.ccache_enabled }}

@@ -199,7 +199,7 @@ jobs:
          fi

      - name: Upload the binary (Linux)
-        if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && runner.os == 'Linux' }}
+        if: ${{ github.event.repository.visibility == 'public' && runner.os == 'Linux' }}
        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
        with:
          name: xrpld-${{ inputs.config_name }}
--- a/.github/workflows/reusable-clang-tidy-files.yml
+++ b/.github/workflows/reusable-clang-tidy-files.yml
@@ -35,7 +35,7 @@ jobs:
        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

      - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@90f11ee655d1687824fb8793db770477d52afbab
+        uses: XRPLF/actions/prepare-runner@2bbc2dc1abeec7bfaa886804ab86871ac201764e
        with:
          enable_ccache: false

@@ -80,10 +80,10 @@ jobs:
        env:
          TARGETS: ${{ inputs.files != '' && inputs.files || 'src tests' }}
        run: |
-          run-clang-tidy -j ${{ steps.nproc.outputs.nproc }} -p "${BUILD_DIR}" -quiet -allow-no-checks ${TARGETS} 2>&1 | tee clang-tidy-output.txt
+          run-clang-tidy -j ${{ steps.nproc.outputs.nproc }} -p "${BUILD_DIR}" ${TARGETS} 2>&1 | tee clang-tidy-output.txt

      - name: Upload clang-tidy output
-        if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && steps.run_clang_tidy.outcome != 'success' }}
+        if: ${{ github.event.repository.visibility == 'public' && steps.run_clang_tidy.outcome != 'success' }}
        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
        with:
          name: clang-tidy-results
--- a/.github/workflows/upload-conan-deps.yml
+++ b/.github/workflows/upload-conan-deps.yml
@@ -70,7 +70,7 @@ jobs:
        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

      - name: Prepare runner
-        uses: XRPLF/actions/prepare-runner@90f11ee655d1687824fb8793db770477d52afbab
+        uses: XRPLF/actions/prepare-runner@2bbc2dc1abeec7bfaa886804ab86871ac201764e
        with:
          enable_ccache: false

--- a/API-CHANGELOG.md
+++ b/API-CHANGELOG.md
@@ -34,7 +34,6 @@ This section contains changes targeting a future version.
  - `TRANSACTION_FLAGS`: Maps transaction type names to their supported flags and flag values.
  - `LEDGER_ENTRY_FLAGS`: Maps ledger entry type names to their flags and flag values.
  - `ACCOUNT_SET_FLAGS`: Maps AccountSet flag names (asf flags) to their numeric values.
- `submit`: Augmented response fields (`accepted`, `applied`, `broadcast`, `queued`, `kept`, `account_sequence_next`, `account_sequence_available`, `open_ledger_cost`, `validated_ledger_index`) are now included in sign-and-submit mode. Previously, these fields were only returned when submitting a binary transaction blob.

 ### Bugfixes

@@ -89,12 +88,6 @@ This release contains bug fixes only and no API changes.

 This release contains bug fixes only and no API changes.

-## Unreleased Changes
-
-### Additions and bugfixes
-
- `submit`: Augmented response fields (`accepted`, `applied`, `broadcast`, `queued`, `kept`, `account_sequence_next`, `account_sequence_available`, `open_ledger_cost`, `validated_ledger_index`) are now included in sign-and-submit mode. Previously, these fields were only returned when submitting a binary transaction blob. ([#6304](https://github.com/XRPLF/rippled/pull/6304))
-
 ## XRP Ledger server version 2.5.0

 [Version 2.5.0](https://github.com/XRPLF/rippled/releases/tag/2.5.0) was released on Jun 24, 2025.
--- a/BUILD.md
+++ b/BUILD.md
@@ -141,7 +141,7 @@ Alternatively, you can pull our recipes from the repository and export them loca

 ```bash
 # Define which recipes to export.
-recipes=('abseil' 'ed25519' 'grpc' 'm4' 'mpt-crypto' 'openssl' 'secp256k1' 'snappy' 'soci' 'wasm-xrplf' 'wasmi')
+recipes=('abseil' 'ed25519' 'grpc' 'm4' 'mpt-crypto' 'nudb' 'openssl' 'secp256k1' 'snappy' 'soci' 'wasm-xrplf' 'wasmi')

 # Selectively check out the recipes from our CCI fork.
 cd external
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -270,14 +270,14 @@ Before running clang-tidy, you must build the project to generate required files
 Then run clang-tidy on your local changes:

 ```
-run-clang-tidy -p build -allow-no-checks src tests
+run-clang-tidy -p build src include tests
 ```

 This will check all source files in the `src`, `include` and `tests` directories using the compile commands from your `build` directory.
 If you wish to automatically fix whatever clang-tidy finds _and_ is capable of fixing, add `-fix` to the above command:

 ```
-run-clang-tidy -p build -quiet -fix -allow-no-checks src tests
+run-clang-tidy -p build -fix src include tests
 ```

 ## Contracts and instrumentation
--- a/conan.lock
+++ b/conan.lock
@@ -3,22 +3,22 @@
    "requires": [
        "zlib/1.3.1#cac0f6daea041b0ccf42934163defb20%1774439233.809",
        "xxhash/0.8.3#681d36a0a6111fc56e5e45ea182c19cc%1765850149.987",
-        "sqlite3/3.51.0#66aa11eabd0e34954c5c1c061ad44abe%1774467355.988",
+        "sqlite3/3.51.0#66aa11eabd0e34954c5c1c061ad44abe%1763899256.358",
        "soci/4.0.3#fe32b9ad5eb47e79ab9e45a68f363945%1774450067.231",
        "snappy/1.1.10#968fef506ff261592ec30c574d4a7809%1765850147.878",
        "secp256k1/0.7.1#481881709eb0bdd0185a12b912bbe8ad%1770910500.329",
        "rocksdb/10.5.1#4a197eca381a3e5ae8adf8cffa5aacd0%1765850186.86",
        "re2/20251105#8579cfd0bda4daf0683f9e3898f964b4%1774398111.888",
-        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1774467363.12",
+        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1773224203.27",
        "openssl/3.6.1#e6399de266349245a4542fc5f6c71552%1774458290.139",
-        "nudb/2.0.9#11149c73f8f2baff9a0198fe25971fc7%1774883011.384",
+        "nudb/2.0.9#0432758a24204da08fee953ec9ea03cb%1769436073.32",
        "lz4/1.10.0#59fc63cac7f10fbe8e05c7e62c2f3504%1765850143.914",
        "libiconv/1.17#1e65319e945f2d31941a9d28cc13c058%1765842973.492",
        "libbacktrace/cci.20210118#a7691bfccd8caaf66309df196790a5a1%1765842973.03",
        "libarchive/3.8.1#ffee18995c706e02bf96e7a2f7042e0d%1765850144.736",
        "jemalloc/5.3.0#e951da9cf599e956cebc117880d2d9f8%1729241615.244",
        "gtest/1.17.0#5224b3b3ff3b4ce1133cbdd27d53ee7d%1768312129.152",
-        "grpc/1.78.1#b1a9e74b145cc471bed4dc64dc6eb2c1%1774467387.342",
+        "grpc/1.78.1#b1a9e74b145cc471bed4dc64dc6eb2c1%1772623605.068",
        "ed25519/2015.03#ae761bdc52730a843f0809bdf6c1b1f6%1765850143.772",
        "date/3.0.4#862e11e80030356b53c2c38599ceb32b%1765850143.772",
        "c-ares/1.34.6#545240bb1c40e2cacd4362d6b8967650%1774439234.681",
@@ -29,7 +29,7 @@
    "build_requires": [
        "zlib/1.3.1#cac0f6daea041b0ccf42934163defb20%1774439233.809",
        "strawberryperl/5.32.1.1#8d114504d172cfea8ea1662d09b6333e%1774447376.964",
-        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1774467363.12",
+        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1773224203.27",
        "nasm/2.16.01#31e26f2ee3c4346ecd347911bd126904%1765850144.707",
        "msys2/cci.latest#d22fe7b2808f5fd34d0a7923ace9c54f%1770657326.649",
        "m4/1.4.19#5d7a4994e5875d76faf7acf3ed056036%1774365463.87",
@@ -41,15 +41,16 @@
    ],
    "python_requires": [],
    "overrides": {
+        "boost/1.90.0#d5e8defe7355494953be18524a7f135b": [
+            null,
+            "boost/1.90.0"
+        ],
        "protobuf/[>=5.27.0 <7]": [
            "protobuf/6.33.5"
        ],
        "lz4/1.9.4": [
            "lz4/1.10.0"
        ],
-        "boost/[>=1.83.0 <1.91.0]": [
-            "boost/1.90.0"
-        ],
        "sqlite3/[>=3.44 <4]": [
            "sqlite3/3.51.0"
        ],
--- a/include/xrpl/basics/BasicConfig.h
+++ b/include/xrpl/basics/BasicConfig.h
@@ -311,7 +311,7 @@ template <class T>
 bool
 set(T& target, T const& defaultValue, std::string const& name, Section const& section)
 {
-    bool const found_and_valid = set<T>(target, name, section);
+    bool found_and_valid = set<T>(target, name, section);
    if (!found_and_valid)
        target = defaultValue;
    return found_and_valid;
--- a/include/xrpl/basics/CanProcess.h
+++ b/include/xrpl/basics/CanProcess.h
@@ -0,0 +1,139 @@
+//------------------------------------------------------------------------------
+/*
+    This file is part of rippled: https://github.com/ripple/rippled
+    Copyright (c) 2024 Ripple Labs Inc.
+
+    Permission to use, copy, modify, and/or distribute this software for any
+    purpose  with  or without fee is hereby granted, provided that the above
+    copyright notice and this permission notice appear in all copies.
+
+    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+    ANY  SPECIAL ,  DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+//==============================================================================
+
+#ifndef RIPPLE_BASICS_CANPROCESS_H_INCLUDED
+#define RIPPLE_BASICS_CANPROCESS_H_INCLUDED
+
+#include <functional>
+#include <mutex>
+#include <set>
+
+/** RAII class to check if an Item is already being processed on another thread,
+ * as indicated by it's presence in a Collection.
+ *
+ * If the Item is not in the Collection, it will be added under lock in the
+ * ctor, and removed under lock in the dtor. The object will be considered
+ * "usable" and evaluate to `true`.
+ *
+ * If the Item is in the Collection, no changes will be made to the collection,
+ * and the CanProcess object will be considered "unusable".
+ *
+ * It's up to the caller to decide what "usable" and "unusable" mean. (e.g.
+ * Process or skip a block of code, or set a flag.)
+ *
+ * The current use is to avoid lock contention that would be involved in
+ * processing something associated with the Item.
+ *
+ * Examples:
+ *
+ * void IncomingLedgers::acquireAsync(LedgerHash const& hash, ...)
+ * {
+ *    if (CanProcess check{acquiresMutex_, pendingAcquires_, hash})
+ *    {
+ *      acquire(hash, ...);
+ *    }
+ * }
+ *
+ * bool
+ * NetworkOPsImp::recvValidation(
+ *   std::shared_ptr<STValidation> const& val,
+ *   std::string const& source)
+ *   {
+ *       CanProcess check(
+ *           validationsMutex_, pendingValidations_, val->getLedgerHash());
+ *       BypassAccept bypassAccept =
+ *           check ? BypassAccept::no : BypassAccept::yes;
+ *       handleNewValidation(app_, val, source, bypassAccept, m_journal);
+ *   }
+ *
+ */
+class CanProcess
+{
+public:
+    template <class Mutex, class Collection, class Item>
+    CanProcess(Mutex& mtx, Collection& collection, Item const& item)
+        : cleanup_(insert(mtx, collection, item))
+    {
+    }
+
+    ~CanProcess()
+    {
+        if (cleanup_)
+            cleanup_();
+    }
+
+    CanProcess(CanProcess const&) = delete;
+
+    CanProcess&
+    operator=(CanProcess const&) = delete;
+
+    explicit
+    operator bool() const
+    {
+        return static_cast<bool>(cleanup_);
+    }
+
+private:
+    template <bool useIterator, class Mutex, class Collection, class Item>
+    std::function<void()>
+    doInsert(Mutex& mtx, Collection& collection, Item const& item)
+    {
+        std::unique_lock<Mutex> lock(mtx);
+        // TODO: Use structured binding once LLVM 16 is the minimum supported
+        // version. See also: https://github.com/llvm/llvm-project/issues/48582
+        // https://github.com/llvm/llvm-project/commit/127bf44385424891eb04cff8e52d3f157fc2cb7c
+        auto const insertResult = collection.insert(item);
+        auto const it = insertResult.first;
+        if (!insertResult.second)
+            return {};
+        if constexpr (useIterator)
+            return [&, it]() {
+                std::unique_lock<Mutex> lock(mtx);
+                collection.erase(it);
+            };
+        else
+            return [&]() {
+                std::unique_lock<Mutex> lock(mtx);
+                collection.erase(item);
+            };
+    }
+
+    // Generic insert() function doesn't use iterators because they may get
+    // invalidated
+    template <class Mutex, class Collection, class Item>
+    std::function<void()>
+    insert(Mutex& mtx, Collection& collection, Item const& item)
+    {
+        return doInsert<false>(mtx, collection, item);
+    }
+
+    // Specialize insert() for std::set, which does not invalidate iterators for
+    // insert and erase
+    template <class Mutex, class Item>
+    std::function<void()>
+    insert(Mutex& mtx, std::set<Item>& collection, Item const& item)
+    {
+        return doInsert<true>(mtx, collection, item);
+    }
+
+    // If set, then the item is "usable"
+    std::function<void()> cleanup_;
+};
+
+#endif
--- a/include/xrpl/basics/CountedObject.h
+++ b/include/xrpl/basics/CountedObject.h
@@ -34,7 +34,7 @@ public:
        {
            // Insert ourselves at the front of the lock-free linked list
            CountedObjects& instance = CountedObjects::getInstance();
-            Counter* head = nullptr;
+            Counter* head;

            do
            {
--- a/include/xrpl/basics/DecayingSample.h
+++ b/include/xrpl/basics/DecayingSample.h
@@ -93,7 +93,7 @@ class DecayWindow
 public:
    using time_point = typename Clock::time_point;

-    explicit DecayWindow(time_point now) : when_(now)
+    explicit DecayWindow(time_point now) : value_(0), when_(now)
    {
    }

@@ -125,7 +125,7 @@ private:
        when_ = now;
    }

-    double value_{0};
+    double value_;
    time_point when_;
 };

--- a/include/xrpl/basics/IntrusivePointer.h
+++ b/include/xrpl/basics/IntrusivePointer.h
@@ -84,8 +84,7 @@ public:

    template <class TT>
        requires std::convertible_to<TT*, T*>
-    SharedIntrusive(
-        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    SharedIntrusive(SharedIntrusive<TT>&& rhs);

    SharedIntrusive&
    operator=(SharedIntrusive const& rhs);
@@ -107,8 +106,7 @@ public:
    template <class TT>
        requires std::convertible_to<TT*, T*>
    SharedIntrusive&
-    operator=(
-        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    operator=(SharedIntrusive<TT>&& rhs);

    /** Adopt the raw pointer. The strong reference may or may not be
        incremented, depending on the TAdoptTag
@@ -316,8 +314,7 @@ public:

    template <class TT>
        requires std::convertible_to<TT*, T*>
-    SharedWeakUnion(
-        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    SharedWeakUnion(SharedIntrusive<TT>&& rhs);

    SharedWeakUnion&
    operator=(SharedWeakUnion const& rhs);
@@ -330,8 +327,7 @@ public:
    template <class TT>
        requires std::convertible_to<TT*, T*>
    SharedWeakUnion&
-    operator=(
-        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    operator=(SharedIntrusive<TT>&& rhs);

    ~SharedWeakUnion();

--- a/include/xrpl/basics/IntrusivePointer.ipp
+++ b/include/xrpl/basics/IntrusivePointer.ipp
@@ -68,7 +68,9 @@ SharedIntrusive<T>::operator=(SharedIntrusive const& rhs)

 template <class T>
 template <class TT>
-    requires std::convertible_to<TT*, T*>
+// clang-format off
+requires std::convertible_to<TT*, T*>
+// clang-format on
 SharedIntrusive<T>&
 SharedIntrusive<T>::operator=(SharedIntrusive<TT> const& rhs)
 {
@@ -99,7 +101,9 @@ SharedIntrusive<T>::operator=(SharedIntrusive&& rhs)

 template <class T>
 template <class TT>
-    requires std::convertible_to<TT*, T*>
+// clang-format off
+requires std::convertible_to<TT*, T*>
+// clang-format on
 SharedIntrusive<T>&
 SharedIntrusive<T>::operator=(SharedIntrusive<TT>&& rhs)
 {
@@ -303,7 +307,9 @@ WeakIntrusive<T>::WeakIntrusive(SharedIntrusive<T> const& rhs) : ptr_{rhs.unsafe

 template <class T>
 template <class TT>
-    requires std::convertible_to<TT*, T*>
+// clang-format off
+requires std::convertible_to<TT*, T*>
+// clang-format on
 WeakIntrusive<T>&
 WeakIntrusive<T>::operator=(SharedIntrusive<TT> const& rhs)
 {
@@ -448,7 +454,9 @@ SharedWeakUnion<T>::operator=(SharedWeakUnion const& rhs)

 template <class T>
 template <class TT>
-    requires std::convertible_to<TT*, T*>
+// clang-format off
+requires std::convertible_to<TT*, T*>
+// clang-format on
 SharedWeakUnion<T>&
 SharedWeakUnion<T>::operator=(SharedIntrusive<TT> const& rhs)
 {
@@ -462,7 +470,9 @@ SharedWeakUnion<T>::operator=(SharedIntrusive<TT> const& rhs)

 template <class T>
 template <class TT>
-    requires std::convertible_to<TT*, T*>
+// clang-format off
+requires std::convertible_to<TT*, T*>
+// clang-format on
 SharedWeakUnion<T>&
 SharedWeakUnion<T>::operator=(SharedIntrusive<TT>&& rhs)
 {
--- a/include/xrpl/basics/IntrusiveRefCounts.h
+++ b/include/xrpl/basics/IntrusiveRefCounts.h
@@ -448,7 +448,7 @@ inline void
 partialDestructorFinished(T** o)
 {
    T& self = **o;
-    IntrusiveRefCounts::RefCountPair const p =
+    IntrusiveRefCounts::RefCountPair p =
        self.refCounts.fetch_or(IntrusiveRefCounts::partialDestroyFinishedMask);
    XRPL_ASSERT(
        (!p.partialDestroyFinishedBit && p.partialDestroyStartedBit && !p.strong),
--- a/include/xrpl/basics/Number.h
+++ b/include/xrpl/basics/Number.h
@@ -73,12 +73,12 @@ struct MantissaRange
    enum mantissa_scale { small, large };

    explicit constexpr MantissaRange(mantissa_scale scale_)
-        : min(getMin(scale_)), log(logTen(min).value_or(-1)), scale(scale_)
+        : min(getMin(scale_)), max(min * 10 - 1), log(logTen(min).value_or(-1)), scale(scale_)
    {
    }

    rep min;
-    rep max{min * 10 - 1};
+    rep max;
    int log;
    mantissa_scale scale;

--- a/include/xrpl/basics/SlabAllocator.h
+++ b/include/xrpl/basics/SlabAllocator.h
@@ -91,10 +91,10 @@ class SlabAllocator
        std::uint8_t*
        allocate() noexcept
        {
-            std::uint8_t* ret = nullptr;  // NOLINT(misc-const-correctness)
+            std::uint8_t* ret;

            {
-                std::lock_guard const l(m_);
+                std::lock_guard l(m_);

                ret = l_;

@@ -123,7 +123,7 @@ class SlabAllocator
        {
            XRPL_ASSERT(own(ptr), "xrpl::SlabAllocator::SlabBlock::deallocate : own input");

-            std::lock_guard const l(m_);
+            std::lock_guard l(m_);

            // Use memcpy to avoid unaligned UB
            // (will optimize to equivalent code)
@@ -210,13 +210,16 @@ public:

        // No slab can satisfy our request, so we attempt to allocate a new
        // one here:
-        std::size_t const size = slabSize_;
+        std::size_t size = slabSize_;

        // We want to allocate the memory at a 2 MiB boundary, to make it
        // possible to use hugepage mappings on Linux:
        auto buf = boost::alignment::aligned_alloc(megabytes(std::size_t(2)), size);
+
+        // clang-format off
        if (!buf) [[unlikely]]
            return nullptr;
+        // clang-format on

 #if BOOST_OS_LINUX
        // When allocating large blocks, attempt to leverage Linux's
--- a/include/xrpl/basics/StringUtilities.h
+++ b/include/xrpl/basics/StringUtilities.h
@@ -66,12 +66,12 @@ strUnHex(std::size_t strSize, Iterator begin, Iterator end)

    while (iter != end)
    {
-        int const cHigh = digitLookupTable[*iter++];
+        int cHigh = digitLookupTable[*iter++];

        if (cHigh < 0)
            return {};

-        int const cLow = digitLookupTable[*iter++];
+        int cLow = digitLookupTable[*iter++];

        if (cLow < 0)
            return {};
--- a/include/xrpl/basics/TaggedCache.h
+++ b/include/xrpl/basics/TaggedCache.h
@@ -182,7 +182,8 @@ private:
            : hook(collector->make_hook(handler))
            , size(collector->make_gauge(prefix, "size"))
            , hit_rate(collector->make_gauge(prefix, "hit_rate"))
-
+            , hits(0)
+            , misses(0)
        {
        }

@@ -190,8 +191,8 @@ private:
        beast::insight::Gauge size;
        beast::insight::Gauge hit_rate;

-        std::size_t hits{0};
-        std::size_t misses{0};
+        std::size_t hits;
+        std::size_t misses;
    };

    class KeyOnlyEntry
@@ -293,10 +294,10 @@ private:
    clock_type::duration const m_target_age;

    // Number of items cached
-    int m_cache_count{0};
+    int m_cache_count;
    cache_type m_cache;  // Hold strong reference to recent objects
-    std::uint64_t m_hits{0};
-    std::uint64_t m_misses{0};
+    std::uint64_t m_hits;
+    std::uint64_t m_misses;
 };

 }  // namespace xrpl
--- a/include/xrpl/basics/TaggedCache.ipp
+++ b/include/xrpl/basics/TaggedCache.ipp
@@ -36,7 +36,9 @@ inline TaggedCache<
    , m_name(name)
    , m_target_size(size)
    , m_target_age(expiration)
-
+    , m_cache_count(0)
+    , m_hits(0)
+    , m_misses(0)
 {
 }

--- a/include/xrpl/basics/base_uint.h
+++ b/include/xrpl/basics/base_uint.h
@@ -212,7 +212,7 @@ private:
        while (in != sv.end())
        {
            std::uint32_t accum = {};
-            for (std::uint32_t const shift : {4u, 0u, 12u, 8u, 20u, 16u, 28u, 24u})
+            for (std::uint32_t shift : {4u, 0u, 12u, 8u, 20u, 16u, 28u, 24u})
            {
                if (auto const result = hexCharToUInt(*in++, shift, accum);
                    result != ParseResult::okay)
@@ -335,13 +335,11 @@ public:
    operator=(std::uint64_t uHost)
    {
        *this = beast::zero;
-        // NOLINTBEGIN(cppcoreguidelines-pro-type-member-init)
        union
        {
            unsigned u[2];
            std::uint64_t ul;
        };
-        // NOLINTEND(cppcoreguidelines-pro-type-member-init)
        // Put in least significant bits.
        ul = boost::endian::native_to_big(uHost);
        data_[WIDTH - 2] = u[0];
@@ -446,7 +444,7 @@ public:

        for (int i = WIDTH; i--;)
        {
-            std::uint64_t const n = carry + boost::endian::big_to_native(data_[i]) +
+            std::uint64_t n = carry + boost::endian::big_to_native(data_[i]) +
                boost::endian::big_to_native(b.data_[i]);

            data_[i] = boost::endian::native_to_big(static_cast<std::uint32_t>(n));
@@ -623,7 +621,7 @@ template <>
 inline std::size_t
 extract(uint256 const& key)
 {
-    std::size_t result = 0;
+    std::size_t result;
    // Use memcpy to avoid unaligned UB
    // (will optimize to equivalent code)
    std::memcpy(&result, key.data(), sizeof(std::size_t));
--- a/include/xrpl/basics/contract.h
+++ b/include/xrpl/basics/contract.h
@@ -54,7 +54,7 @@ Throw(Args&&... args)

    E e(std::forward<Args>(args)...);
    LogThrow(std::string("Throwing exception of type " + beast::type_name<E>() + ": ") + e.what());
-    throw std::move(e);
+    throw e;
 }

 /** Called when faulty logic causes a broken invariant. */
--- a/include/xrpl/basics/hardened_hash.h
+++ b/include/xrpl/basics/hardened_hash.h
@@ -32,7 +32,7 @@ make_seed_pair() noexcept
        // state_t& operator=(state_t const&) = delete;
    };
    static state_t state;
-    std::lock_guard const lock(state.mutex);
+    std::lock_guard lock(state.mutex);
    return {state.dist(state.gen), state.dist(state.gen)};
 }

--- a/include/xrpl/basics/random.h
+++ b/include/xrpl/basics/random.h
@@ -14,13 +14,11 @@ namespace xrpl {

 #ifndef __INTELLISENSE__
 static_assert(
-    // NOLINTNEXTLINE(misc-redundant-expression)
    std::is_integral<beast::xor_shift_engine::result_type>::value &&
        std::is_unsigned<beast::xor_shift_engine::result_type>::value,
    "The Ripple default PRNG engine must return an unsigned integral type.");

 static_assert(
-    // NOLINTNEXTLINE(misc-redundant-expression)
    std::numeric_limits<beast::xor_shift_engine::result_type>::max() >=
        std::numeric_limits<std::uint64_t>::max(),
    "The Ripple default PRNG engine return must be at least 64 bits wide.");
@@ -58,9 +56,9 @@ default_prng()

    // The thread-specific PRNGs:
    thread_local beast::xor_shift_engine engine = [] {
-        std::uint64_t seed = 0;
+        std::uint64_t seed;
        {
-            std::lock_guard const lk(m);
+            std::lock_guard lk(m);
            std::uniform_int_distribution<std::uint64_t> distribution{1};
            seed = distribution(seeder);
        }
--- a/include/xrpl/beast/asio/io_latency_probe.h
+++ b/include/xrpl/beast/asio/io_latency_probe.h
@@ -23,15 +23,15 @@ private:

    std::recursive_mutex m_mutex;
    std::condition_variable_any m_cond;
-    std::size_t m_count{1};
+    std::size_t m_count;
    duration const m_period;
    boost::asio::io_context& m_ios;
    boost::asio::basic_waitable_timer<std::chrono::steady_clock> m_timer;
-    bool m_cancel{false};
+    bool m_cancel;

 public:
    io_latency_probe(duration const& period, boost::asio::io_context& ios)
-        : m_period(period), m_ios(ios), m_timer(m_ios)
+        : m_count(1), m_period(period), m_ios(ios), m_timer(m_ios), m_cancel(false)
    {
    }

@@ -83,7 +83,7 @@ public:
    void
    sample_one(Handler&& handler)
    {
-        std::lock_guard const lock(m_mutex);
+        std::lock_guard lock(m_mutex);
        if (m_cancel)
            throw std::logic_error("io_latency_probe is canceled");
        boost::asio::post(
@@ -98,7 +98,7 @@ public:
    void
    sample(Handler&& handler)
    {
-        std::lock_guard const lock(m_mutex);
+        std::lock_guard lock(m_mutex);
        if (m_cancel)
            throw std::logic_error("io_latency_probe is canceled");
        boost::asio::post(
@@ -122,14 +122,14 @@ private:
    void
    addref()
    {
-        std::lock_guard const lock(m_mutex);
+        std::lock_guard lock(m_mutex);
        ++m_count;
    }

    void
    release()
    {
-        std::lock_guard const lock(m_mutex);
+        std::lock_guard lock(m_mutex);
        if (--m_count == 0)
            m_cond.notify_all();
    }
@@ -192,7 +192,7 @@ private:
            m_handler(elapsed);

            {
-                std::lock_guard const lock(m_probe->m_mutex);
+                std::lock_guard lock(m_probe->m_mutex);
                if (m_probe->m_cancel)
                    return;
            }
--- a/include/xrpl/beast/container/aged_map.h
+++ b/include/xrpl/beast/container/aged_map.h
@@ -16,4 +16,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_map = detail::aged_ordered_container<false, true, Key, T, Clock, Compare, Allocator>;

-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_multimap.h
+++ b/include/xrpl/beast/container/aged_multimap.h
@@ -16,4 +16,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_multimap = detail::aged_ordered_container<true, true, Key, T, Clock, Compare, Allocator>;

-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_multiset.h
+++ b/include/xrpl/beast/container/aged_multiset.h
@@ -15,4 +15,4 @@ template <
    class Allocator = std::allocator<Key>>
 using aged_multiset =
    detail::aged_ordered_container<true, false, Key, void, Clock, Compare, Allocator>;
-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_set.h
+++ b/include/xrpl/beast/container/aged_set.h
@@ -15,4 +15,4 @@ template <
    class Allocator = std::allocator<Key>>
 using aged_set = detail::aged_ordered_container<false, false, Key, void, Clock, Compare, Allocator>;

-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_unordered_map.h
+++ b/include/xrpl/beast/container/aged_unordered_map.h
@@ -17,4 +17,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_unordered_map =
    detail::aged_unordered_container<false, true, Key, T, Clock, Hash, KeyEqual, Allocator>;
-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_unordered_multimap.h
+++ b/include/xrpl/beast/container/aged_unordered_multimap.h
@@ -17,4 +17,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_unordered_multimap =
    detail::aged_unordered_container<true, true, Key, T, Clock, Hash, KeyEqual, Allocator>;
-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_unordered_multiset.h
+++ b/include/xrpl/beast/container/aged_unordered_multiset.h
@@ -17,4 +17,4 @@ template <
 using aged_unordered_multiset =
    detail::aged_unordered_container<true, false, Key, void, Clock, Hash, KeyEqual, Allocator>;

-}  // namespace beast
+}
--- a/include/xrpl/beast/container/aged_unordered_set.h
+++ b/include/xrpl/beast/container/aged_unordered_set.h
@@ -16,4 +16,4 @@ template <
    class Allocator = std::allocator<Key>>
 using aged_unordered_set =
    detail::aged_unordered_container<false, false, Key, void, Clock, Hash, KeyEqual, Allocator>;
-}  // namespace beast
+}
--- a/include/xrpl/beast/container/detail/aged_ordered_container.h
+++ b/include/xrpl/beast/container/detail/aged_ordered_container.h
@@ -262,9 +262,7 @@ private:
        {
        }

-        config_t(
-            config_t&& other,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
-            Allocator const& alloc)
+        config_t(config_t&& other, Allocator const& alloc)
            : KeyValueCompare(std::move(other.key_compare()))
            , beast::detail::empty_base_optimization<ElementAllocator>(alloc)
            , clock(other.clock)
@@ -554,10 +552,7 @@ public:

    aged_ordered_container(aged_ordered_container&& other);

-    aged_ordered_container(
-        // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
-        aged_ordered_container&& other,
-        Allocator const& alloc);
+    aged_ordered_container(aged_ordered_container&& other, Allocator const& alloc);

    aged_ordered_container(std::initializer_list<value_type> init, clock_type& clock);

@@ -1295,7 +1290,7 @@ aged_ordered_container<IsMulti, IsMap, Key, T, Clock, Compare, Allocator>::aged_

 template <bool IsMulti, bool IsMap, class Key, class T, class Clock, class Compare, class Allocator>
 aged_ordered_container<IsMulti, IsMap, Key, T, Clock, Compare, Allocator>::aged_ordered_container(
-    aged_ordered_container&& other,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    aged_ordered_container&& other,
    Allocator const& alloc)
    : m_config(std::move(other.m_config), alloc)
 #if BOOST_VERSION >= 108000
--- a/include/xrpl/beast/container/detail/aged_unordered_container.h
+++ b/include/xrpl/beast/container/detail/aged_unordered_container.h
@@ -318,9 +318,7 @@ private:
        {
        }

-        config_t(
-            config_t&& other,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
-            Allocator const& alloc)
+        config_t(config_t&& other, Allocator const& alloc)
            : ValueHash(std::move(other.hash_function()))
            , KeyValueEqual(std::move(other.key_eq()))
            , beast::detail::empty_base_optimization<ElementAllocator>(alloc)
@@ -776,10 +774,7 @@ public:

    aged_unordered_container(aged_unordered_container&& other);

-    aged_unordered_container(
-        // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
-        aged_unordered_container&& other,
-        Allocator const& alloc);
+    aged_unordered_container(aged_unordered_container&& other, Allocator const& alloc);

    aged_unordered_container(std::initializer_list<value_type> init, clock_type& clock);

@@ -1843,10 +1838,7 @@ template <
    class KeyEqual,
    class Allocator>
 aged_unordered_container<IsMulti, IsMap, Key, T, Clock, Hash, KeyEqual, Allocator>::
-    aged_unordered_container(
-        // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
-        aged_unordered_container&& other,
-        Allocator const& alloc)
+    aged_unordered_container(aged_unordered_container&& other, Allocator const& alloc)
    : m_config(std::move(other.m_config), alloc)
    , m_buck(alloc)
    , m_cont(m_buck, std::cref(m_config.value_hash()), std::cref(m_config.key_value_equal()))
--- a/include/xrpl/beast/core/List.h
+++ b/include/xrpl/beast/core/List.h
@@ -449,7 +449,7 @@ public:
    iterator
    erase(iterator pos) noexcept
    {
-        Node const* node = &*pos;
+        Node* node = &*pos;
        ++pos;
        node->m_next->m_prev = node->m_prev;
        node->m_prev->m_next = node->m_next;
--- a/include/xrpl/beast/core/LockFreeStack.h
+++ b/include/xrpl/beast/core/LockFreeStack.h
@@ -187,7 +187,7 @@ public:
    bool
    push_front(Node* node)
    {
-        bool first = false;
+        bool first;
        Node* old_head = m_head.load(std::memory_order_relaxed);
        do
        {
@@ -211,7 +211,7 @@ public:
    pop_front()
    {
        Node* node = m_head.load();
-        Node* new_head = nullptr;
+        Node* new_head;
        do
        {
            if (node == &m_end)
--- a/include/xrpl/beast/hash/xxhasher.h
+++ b/include/xrpl/beast/hash/xxhasher.h
@@ -23,7 +23,7 @@ private:
    // A 64-byte buffer should to be big enough for us
    static constexpr std::size_t INTERNAL_BUFFER_SIZE = 64;

-    alignas(64) std::array<std::uint8_t, INTERNAL_BUFFER_SIZE> buffer_{};
+    alignas(64) std::array<std::uint8_t, INTERNAL_BUFFER_SIZE> buffer_;
    std::span<std::uint8_t> readBuffer_;
    std::span<std::uint8_t> writeBuffer_;

--- a/include/xrpl/beast/test/yield_to.h
+++ b/include/xrpl/beast/test/yield_to.h
@@ -114,7 +114,7 @@ enable_yield_to::spawn(F0&& f, FN&&... fn)
        boost::context::fixedsize_stack(2 * 1024 * 1024),
        [&](yield_context yield) {
            f(yield);
-            std::lock_guard const lock{m_};
+            std::lock_guard lock{m_};
            if (--running_ == 0)
                cv_.notify_all();
        },
--- a/include/xrpl/beast/unit_test/results.h
+++ b/include/xrpl/beast/unit_test/results.h
@@ -35,10 +35,10 @@ private:
    class tests_t : public detail::const_container<std::vector<test>>
    {
    private:
-        std::size_t failed_{0};
+        std::size_t failed_;

    public:
-        tests_t()
+        tests_t() : failed_(0)
        {
        }

@@ -167,12 +167,12 @@ public:
 class results : public detail::const_container<std::vector<suite_results>>
 {
 private:
-    std::size_t m_cases{0};
-    std::size_t total_{0};
-    std::size_t failed_{0};
+    std::size_t m_cases;
+    std::size_t total_;
+    std::size_t failed_;

 public:
-    results()
+    results() : m_cases(0), total_(0), failed_(0)
    {
    }

--- a/include/xrpl/beast/unit_test/runner.h
+++ b/include/xrpl/beast/unit_test/runner.h
@@ -228,7 +228,7 @@ template <class>
 void
 runner::testcase(std::string const& name)
 {
-    std::lock_guard const lock(mutex_);
+    std::lock_guard lock(mutex_);
    // Name may not be empty
    BOOST_ASSERT(default_ || !name.empty());
    // Forgot to call pass or fail
@@ -244,7 +244,7 @@ template <class>
 void
 runner::pass()
 {
-    std::lock_guard const lock(mutex_);
+    std::lock_guard lock(mutex_);
    if (default_)
        testcase("");
    on_pass();
@@ -255,7 +255,7 @@ template <class>
 void
 runner::fail(std::string const& reason)
 {
-    std::lock_guard const lock(mutex_);
+    std::lock_guard lock(mutex_);
    if (default_)
        testcase("");
    on_fail(reason);
@@ -267,7 +267,7 @@ template <class>
 void
 runner::log(std::string const& s)
 {
-    std::lock_guard const lock(mutex_);
+    std::lock_guard lock(mutex_);
    if (default_)
        testcase("");
    on_log(s);
--- a/include/xrpl/beast/unit_test/suite.h
+++ b/include/xrpl/beast/unit_test/suite.h
@@ -300,7 +300,7 @@ private:
    static suite**
    p_this_suite()
    {
-        static suite* pts = nullptr;  // NOLINT(misc-const-correctness)
+        static suite* pts = nullptr;
        return &pts;
    }

--- a/include/xrpl/beast/utility/PropertyStream.h
+++ b/include/xrpl/beast/utility/PropertyStream.h
@@ -311,7 +311,7 @@ private:
    std::string const m_name;
    std::recursive_mutex lock_;
    Item item_;
-    Source* parent_{nullptr};
+    Source* parent_;
    List<Item> children_;

 public:
--- a/include/xrpl/beast/utility/Zero.h
+++ b/include/xrpl/beast/utility/Zero.h
@@ -28,7 +28,7 @@ struct Zero

 namespace {
 static constexpr Zero zero{};
-}  // namespace
+}

 /** Default implementation of signum calls the method on the class. */
 template <typename T>
--- a/include/xrpl/beast/xor_shift_engine.h
+++ b/include/xrpl/beast/xor_shift_engine.h
@@ -37,7 +37,7 @@ public:
    }

 private:
-    result_type s_[2]{};
+    result_type s_[2];

    static result_type
    murmurhash3(result_type x);
--- a/include/xrpl/core/ClosureCounter.h
+++ b/include/xrpl/core/ClosureCounter.h
@@ -56,7 +56,7 @@ private:
        // a lock.  This removes a small timing window that occurs if the
        // waiting thread is handling a spurious wakeup when closureCount_
        // drops to zero.
-        std::lock_guard const lock{mutex_};
+        std::lock_guard lock{mutex_};

        // Update closureCount_.  Notify if stopping and closureCount_ == 0.
        if ((--closureCount_ == 0) && waitForClosures_)
@@ -92,9 +92,7 @@ private:
            ++counter_;
        }

-        Substitute(
-            ClosureCounter& counter,
-            Closure&& closure)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+        Substitute(ClosureCounter& counter, Closure&& closure)
            : counter_(counter), closure_(std::forward<Closure>(closure))
        {
            ++counter_;
@@ -170,7 +168,7 @@ public:
    {
        std::optional<Substitute<Closure>> ret;

-        std::lock_guard const lock{mutex_};
+        std::lock_guard lock{mutex_};
        if (!waitForClosures_)
            ret.emplace(*this, std::forward<Closure>(closure));

@@ -193,7 +191,7 @@ public:
    bool
    joined() const
    {
-        std::lock_guard const lock{mutex_};
+        std::lock_guard lock{mutex_};
        return waitForClosures_;
    }
 };
--- a/include/xrpl/core/Coro.ipp
+++ b/include/xrpl/core/Coro.ipp
@@ -7,6 +7,7 @@ JobQueue::Coro::Coro(Coro_create_t, JobQueue& jq, JobType type, std::string cons
    : jq_(jq)
    , type_(type)
    , name_(name)
+    , running_(false)
    , coro_(
          // Stack size of 1MB wasn't sufficient for deep calls. ASAN tests flagged the issue. Hence
          // increasing the size to 1.5MB.
--- a/include/xrpl/core/HashRouter.h
+++ b/include/xrpl/core/HashRouter.h
@@ -199,7 +199,7 @@ public:

    /** Add a suppression peer and get message's relay status.
     * Return pair:
-     * element 1: true if the peer is added.
+     * element 1: true if the key is added.
     * element 2: optional is seated to the relay time point or
     * is unseated if has not relayed yet. */
    std::pair<bool, std::optional<Stopwatch::time_point>>
--- a/include/xrpl/core/JobQueue.h
+++ b/include/xrpl/core/JobQueue.h
@@ -16,7 +16,7 @@ namespace xrpl {

 namespace perf {
 class PerfLog;
-}  // namespace perf
+}

 class Logs;
 struct Coro_create_t
@@ -45,7 +45,7 @@ public:
        JobQueue& jq_;
        JobType type_;
        std::string name_;
-        bool running_{false};
+        bool running_;
        std::mutex mutex_;
        std::mutex mutex_run_;
        std::condition_variable cv_;
@@ -224,7 +224,7 @@ private:

    beast::Journal m_journal;
    mutable std::mutex m_mutex;
-    std::uint64_t m_lastJob{0};
+    std::uint64_t m_lastJob;
    std::set<Job> m_jobSet;
    JobCounter jobCounter_;
    std::atomic_bool stopping_{false};
@@ -233,7 +233,7 @@ private:
    JobTypeData m_invalidJobData;

    // The number of jobs currently in processTask()
-    int m_processCount{0};
+    int m_processCount;

    // The number of suspended coroutines
    int nSuspend_ = 0;
--- a/include/xrpl/core/JobTypeData.h
+++ b/include/xrpl/core/JobTypeData.h
@@ -19,13 +19,13 @@ public:
    JobTypeInfo const& info;

    /* The number of jobs waiting */
-    int waiting{0};
+    int waiting;

    /* The number presently running */
-    int running{0};
+    int running;

    /* And the number we deferred executing because of job limits */
-    int deferred{0};
+    int deferred;

    /* Notification callbacks */
    beast::insight::Event dequeue;
@@ -35,8 +35,12 @@ public:
        JobTypeInfo const& info_,
        beast::insight::Collector::ptr const& collector,
        Logs& logs) noexcept
-        : m_load(logs.journal("LoadMonitor")), m_collector(collector), info(info_)
-
+        : m_load(logs.journal("LoadMonitor"))
+        , m_collector(collector)
+        , info(info_)
+        , waiting(0)
+        , running(0)
+        , deferred(0)
    {
        m_load.setTargetLatency(info.getAverageLatency(), info.getPeakLatency());

--- a/include/xrpl/core/JobTypes.h
+++ b/include/xrpl/core/JobTypes.h
@@ -24,7 +24,7 @@ private:
              std::chrono::milliseconds{0})
    {
        using namespace std::chrono_literals;
-        int const maxLimit = std::numeric_limits<int>::max();
+        int maxLimit = std::numeric_limits<int>::max();

        auto add = [this](
                       JobType jt,
--- a/include/xrpl/core/LoadMonitor.h
+++ b/include/xrpl/core/LoadMonitor.h
@@ -36,10 +36,10 @@ public:
    {
        Stats();

-        std::uint64_t count{0};
+        std::uint64_t count;
        std::chrono::milliseconds latencyAvg;
        std::chrono::milliseconds latencyPeak;
-        bool isOverloaded{false};
+        bool isOverloaded;
    };

    Stats
@@ -54,8 +54,8 @@ private:

    std::mutex mutex_;

-    std::uint64_t mCounts{0};
-    int mLatencyEvents{0};
+    std::uint64_t mCounts;
+    int mLatencyEvents;
    std::chrono::milliseconds mLatencyMSAvg;
    std::chrono::milliseconds mLatencyMSPeak;
    std::chrono::milliseconds mTargetLatencyAvg;
--- a/include/xrpl/core/PeerReservationTable.h
+++ b/include/xrpl/core/PeerReservationTable.h
@@ -67,7 +67,7 @@ public:
    bool
    contains(PublicKey const& nodeId)
    {
-        std::lock_guard const lock(this->mutex_);
+        std::lock_guard lock(this->mutex_);
        return table_.find({nodeId}) != table_.end();
    }

@@ -92,7 +92,7 @@ public:
 private:
    beast::Journal mutable journal_;
    std::mutex mutable mutex_;
-    DatabaseCon* connection_{};
+    DatabaseCon* connection_;
    std::unordered_set<PeerReservation, beast::uhash<>, KeyEqual> table_;
 };

--- a/include/xrpl/core/PerfLog.h
+++ b/include/xrpl/core/PerfLog.h
@@ -14,7 +14,7 @@

 namespace beast {
 class Journal;
-}  // namespace beast
+}

 namespace xrpl {
 class Application;
--- a/include/xrpl/core/ServiceRegistry.h
+++ b/include/xrpl/core/ServiceRegistry.h
@@ -11,13 +11,13 @@ namespace xrpl {
 // Forward declarations
 namespace NodeStore {
 class Database;
-}  // namespace NodeStore
+}
 namespace Resource {
 class Manager;
-}  // namespace Resource
+}
 namespace perf {
 class PerfLog;
-}  // namespace perf
+}

 // This is temporary until we migrate all code to use ServiceRegistry.
 class Application;
--- a/include/xrpl/core/detail/Workers.h
+++ b/include/xrpl/core/detail/Workers.h
@@ -13,7 +13,7 @@ namespace xrpl {

 namespace perf {
 class PerfLog;
-}  // namespace perf
+}

 /**
 * `Workers` is effectively a thread pool. The constructor takes a "callback"
@@ -183,8 +183,8 @@ private:
        std::thread thread_;
        std::mutex mutex_;
        std::condition_variable wakeup_;
-        int wakeCount_{0};  // how many times to un-pause
-        bool shouldExit_{false};
+        int wakeCount_;  // how many times to un-pause
+        bool shouldExit_;
    };

 private:
@@ -197,9 +197,9 @@ private:
    std::string m_threadNames;     // The name to give each thread
    std::condition_variable m_cv;  // signaled when all threads paused
    std::mutex m_mut;
-    bool m_allPaused{true};
+    bool m_allPaused;
    semaphore m_semaphore;                             // each pending task is 1 resource
-    int m_numberOfThreads{0};                          // how many we want active now
+    int m_numberOfThreads;                             // how many we want active now
    std::atomic<int> m_activeCount;                    // to know when all are paused
    std::atomic<int> m_pauseCount;                     // how many threads need to pause now
    std::atomic<int> m_runningTaskCount;               // how many calls to processTask() active
--- a/include/xrpl/core/detail/semaphore.h
+++ b/include/xrpl/core/detail/semaphore.h
@@ -55,7 +55,7 @@ public:
    void
    notify()
    {
-        std::lock_guard const lock{m_mutex};
+        std::lock_guard lock{m_mutex};
        ++m_count;
        m_cond.notify_one();
    }
--- a/include/xrpl/json/json_reader.h
+++ b/include/xrpl/json/json_reader.h
@@ -103,9 +103,9 @@ private:
    public:
        explicit ErrorInfo() = default;

-        Token token_{};
+        Token token_;
        std::string message_;
-        Location extra_{};
+        Location extra_;
    };

    using Errors = std::deque<ErrorInfo>;
@@ -173,11 +173,11 @@ private:
    Nodes nodes_;
    Errors errors_;
    std::string document_;
-    Location begin_{};
-    Location end_{};
-    Location current_{};
-    Location lastValueEnd_{};
-    Value* lastValue_{};
+    Location begin_;
+    Location end_;
+    Location current_;
+    Location lastValueEnd_;
+    Value* lastValue_;
 };

 template <class BufferSequence>
--- a/include/xrpl/json/json_value.h
+++ b/include/xrpl/json/json_value.h
@@ -641,7 +641,7 @@ public:
    SelfType
    operator++(int)
    {
-        SelfType const temp(*this);
+        SelfType temp(*this);
        ++*this;
        return temp;
    }
@@ -649,7 +649,7 @@ public:
    SelfType
    operator--(int)
    {
-        SelfType const temp(*this);
+        SelfType temp(*this);
        --*this;
        return temp;
    }
--- a/include/xrpl/json/json_writer.h
+++ b/include/xrpl/json/json_writer.h
@@ -106,8 +106,8 @@ private:
    ChildValues childValues_;
    std::string document_;
    std::string indentString_;
-    int rightMargin_{74};
-    int indentSize_{3};
+    int rightMargin_;
+    int indentSize_;
    bool addChildValues_{};
 };

@@ -171,9 +171,9 @@ private:
    using ChildValues = std::vector<std::string>;

    ChildValues childValues_;
-    std::ostream* document_{nullptr};
+    std::ostream* document_;
    std::string indentString_;
-    int rightMargin_{74};
+    int rightMargin_;
    std::string indentation_;
    bool addChildValues_{};
 };
--- a/include/xrpl/ledger/AmendmentTable.h
+++ b/include/xrpl/ledger/AmendmentTable.h
@@ -143,7 +143,7 @@ public:
        // Inject appropriate pseudo-transactions
        for (auto const& it : actions)
        {
-            STTx const amendTx(ttAMENDMENT, [&it, seq = lastClosedLedger->seq() + 1](auto& obj) {
+            STTx amendTx(ttAMENDMENT, [&it, seq = lastClosedLedger->seq() + 1](auto& obj) {
                obj.setAccountID(sfAccount, AccountID());
                obj.setFieldH256(sfAmendment, it.first);
                obj.setFieldU32(sfLedgerSequence, seq);
--- a/include/xrpl/ledger/CachedSLEs.h
+++ b/include/xrpl/ledger/CachedSLEs.h
@@ -6,4 +6,4 @@

 namespace xrpl {
 using CachedSLEs = TaggedCache<uint256, SLE const>;
-}  // namespace xrpl
+}
--- a/include/xrpl/ledger/PendingSaves.h
+++ b/include/xrpl/ledger/PendingSaves.h
@@ -31,7 +31,7 @@ public:
    bool
    startWork(LedgerIndex seq)
    {
-        std::lock_guard const lock(mutex_);
+        std::lock_guard lock(mutex_);

        auto it = map_.find(seq);

@@ -54,7 +54,7 @@ public:
    void
    finishWork(LedgerIndex seq)
    {
-        std::lock_guard const lock(mutex_);
+        std::lock_guard lock(mutex_);

        map_.erase(seq);
        await_.notify_all();
@@ -64,7 +64,7 @@ public:
    bool
    pending(LedgerIndex seq)
    {
-        std::lock_guard const lock(mutex_);
+        std::lock_guard lock(mutex_);
        return map_.find(seq) != map_.end();
    }

@@ -117,7 +117,7 @@ public:
    std::map<LedgerIndex, bool>
    getSnapshot() const
    {
-        std::lock_guard const lock(mutex_);
+        std::lock_guard lock(mutex_);

        return map_;
    }
--- a/include/xrpl/nodestore/Scheduler.h
+++ b/include/xrpl/nodestore/Scheduler.h
@@ -16,7 +16,7 @@ struct FetchReport
    {
    }

-    std::chrono::milliseconds elapsed{};
+    std::chrono::milliseconds elapsed;
    FetchType const fetchType;
    bool wasFound = false;
 };
--- a/include/xrpl/nodestore/detail/BatchWriter.h
+++ b/include/xrpl/nodestore/detail/BatchWriter.h
@@ -71,8 +71,8 @@ private:
    Scheduler& m_scheduler;
    LockType mWriteMutex;
    CondvarType mWriteCondition;
-    int mWriteLoad{0};
-    bool mWritePending{false};
+    int mWriteLoad;
+    bool mWritePending;
    Batch mWriteSet;
 };

--- a/include/xrpl/nodestore/detail/EncodedBlob.h
+++ b/include/xrpl/nodestore/detail/EncodedBlob.h
@@ -35,7 +35,7 @@ namespace NodeStore {
 class EncodedBlob
 {
    /** The 32-byte key of the serialized object. */
-    std::array<std::uint8_t, 32> key_{};
+    std::array<std::uint8_t, 32> key_;

    /** A pre-allocated buffer for the serialized object.

@@ -43,8 +43,7 @@ class EncodedBlob
         1024 more bytes. The precise size is calculated automatically
         at compile time so as to avoid wasting space on padding bytes.
     */
-    std::array<std::uint8_t, boost::alignment::align_up(9 + 1024, alignof(std::uint32_t))>
-        payload_{};
+    std::array<std::uint8_t, boost::alignment::align_up(9 + 1024, alignof(std::uint32_t))> payload_;

    /** The size of the serialized data. */
    std::uint32_t size_;
--- a/include/xrpl/nodestore/detail/codec.h
+++ b/include/xrpl/nodestore/detail/codec.h
@@ -56,7 +56,7 @@ lz4_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
    using std::runtime_error;
    using namespace nudb::detail;
    std::pair<void const*, std::size_t> result;
-    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi{};
+    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi;
    auto const n = write_varint(vi.data(), in_size);
    auto const out_max = LZ4_compressBound(in_size);
    std::uint8_t* out = reinterpret_cast<std::uint8_t*>(bf(n + out_max));
@@ -88,7 +88,7 @@ nodeobject_decompress(void const* in, std::size_t in_size, BufferFactory&& bf)
    using namespace nudb::detail;

    std::uint8_t const* p = reinterpret_cast<std::uint8_t const*>(in);
-    std::size_t type = 0;
+    std::size_t type;
    auto const vn = read_varint(p, in_size, type);
    if (vn == 0)
        Throw<std::runtime_error>("nodeobject decompress");
@@ -117,7 +117,7 @@ nodeobject_decompress(void const* in, std::size_t in_size, BufferFactory&& bf)
                    "nodeobject codec v1: short inner node size: " + std::string("in_size = ") +
                    std::to_string(in_size) + " hs = " + std::to_string(hs));
            istream is(p, in_size);
-            std::uint16_t mask = 0;
+            std::uint16_t mask;
            read<std::uint16_t>(is, mask);  // Mask
            in_size -= hs;
            result.second = 525;
@@ -196,10 +196,10 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
    if (in_size == 525)
    {
        istream is(in, in_size);
-        std::uint32_t index = 0;
-        std::uint32_t unused = 0;
-        std::uint8_t kind = 0;
-        std::uint32_t prefix = 0;
+        std::uint32_t index;
+        std::uint32_t unused;
+        std::uint8_t kind;
+        std::uint32_t prefix;
        read<std::uint32_t>(is, index);
        read<std::uint32_t>(is, unused);
        read<std::uint8_t>(is, kind);
@@ -208,7 +208,7 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
        {
            std::size_t n = 0;
            std::uint16_t mask = 0;
-            std::array<std::uint8_t, 512> vh{};
+            std::array<std::uint8_t, 512> vh;
            for (unsigned bit = 0x8000; bit; bit >>= 1)
            {
                void const* const h = is(32);
@@ -247,7 +247,7 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
        }
    }

-    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi{};
+    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi;

    constexpr std::size_t codecType = 1;
    auto const vn = write_varint(vi.data(), codecType);
@@ -257,7 +257,7 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
        // case 0 was uncompressed data; we always compress now.
        case 1:  // lz4
        {
-            std::uint8_t* p = nullptr;
+            std::uint8_t* p;
            auto const lzr = NodeStore::lz4_compress(in, in_size, [&p, &vn, &bf](std::size_t n) {
                p = reinterpret_cast<std::uint8_t*>(bf(vn + n));
                return p + vn;
@@ -287,10 +287,10 @@ filter_inner(void* in, std::size_t in_size)
    if (in_size == 525)
    {
        istream is(in, in_size);
-        std::uint32_t index = 0;
-        std::uint32_t unused = 0;
-        std::uint8_t kind = 0;
-        std::uint32_t prefix = 0;
+        std::uint32_t index;
+        std::uint32_t unused;
+        std::uint8_t kind;
+        std::uint32_t prefix;
        read<std::uint32_t>(is, index);
        read<std::uint32_t>(is, unused);
        read<std::uint8_t>(is, kind);
--- a/include/xrpl/nodestore/detail/varint.h
+++ b/include/xrpl/nodestore/detail/varint.h
@@ -82,7 +82,6 @@ template <class = void>
 std::size_t
 write_varint(void* p0, std::size_t v)
 {
-    // NOLINTNEXTLINE(misc-const-correctness)
    std::uint8_t* p = reinterpret_cast<std::uint8_t*>(p0);
    do
    {
--- a/include/xrpl/protocol/AmountConversions.h
+++ b/include/xrpl/protocol/AmountConversions.h
@@ -102,7 +102,7 @@ template <typename T>
 T
 toAmount(Issue const& issue, Number const& n, Number::rounding_mode mode = Number::getround())
 {
-    saveNumberRoundMode const rm(Number::getround());
+    saveNumberRoundMode rm(Number::getround());
    if (isXRP(issue))
        Number::setround(mode);

--- a/include/xrpl/protocol/IOUAmount.h
+++ b/include/xrpl/protocol/IOUAmount.h
@@ -26,8 +26,8 @@ class IOUAmount : private boost::totally_ordered<IOUAmount>, private boost::addi
 private:
    using mantissa_type = std::int64_t;
    using exponent_type = int;
-    mantissa_type mantissa_{};
-    exponent_type exponent_{};
+    mantissa_type mantissa_;
+    exponent_type exponent_;

    /** Adjusts the mantissa and exponent to the proper range.

--- a/include/xrpl/protocol/Indexes.h
+++ b/include/xrpl/protocol/Indexes.h
@@ -363,12 +363,11 @@ uint256
 getTicketIndex(AccountID const& account, SeqProxy ticketSeq);

 template <class... keyletParams>
-// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
 struct keyletDesc
 {
    std::function<Keylet(keyletParams...)> function;
    Json::StaticString expectedLEName;
-    bool includeInTests{};
+    bool includeInTests;
 };

 // This list should include all of the keylet functions that take a single
--- a/include/xrpl/protocol/Issue.h
+++ b/include/xrpl/protocol/Issue.h
@@ -96,7 +96,7 @@ operator<=>(Issue const& lhs, Issue const& rhs)
 inline Issue const&
 xrpIssue()
 {
-    static Issue const issue{xrpCurrency(), xrpAccount()};
+    static Issue issue{xrpCurrency(), xrpAccount()};
    return issue;
 }

@@ -104,7 +104,7 @@ xrpIssue()
 inline Issue const&
 noIssue()
 {
-    static Issue const issue{noCurrency(), noAccount()};
+    static Issue issue{noCurrency(), noAccount()};
    return issue;
 }

--- a/include/xrpl/protocol/LedgerHeader.h
+++ b/include/xrpl/protocol/LedgerHeader.h
@@ -35,6 +35,8 @@ struct LedgerHeader

    // If validated is false, it means "not yet validated."
    // Once validated is true, it will never be set false at a later time.
+    // NOTE: If you are accessing this directly, you are probably doing it
+    //   wrong. Use LedgerMaster::isValidated().
    // VFALCO TODO Make this not mutable
    bool mutable validated = false;
    bool accepted = false;
--- a/include/xrpl/protocol/Quality.h
+++ b/include/xrpl/protocol/Quality.h
@@ -56,8 +56,8 @@ struct TAmounts
        return *this;
    }

-    In in{};
-    Out out{};
+    In in;
+    Out out;
 };

 using Amounts = TAmounts<STAmount, STAmount>;
@@ -304,8 +304,8 @@ Quality::ceil_TAmounts_helper(

    // Use the existing STAmount implementation for now, but consider
    // replacing with code specific to IOUAMount and XRPAmount
-    Amounts const stAmt(toSTAmount(amount.in), toSTAmount(amount.out));
-    STAmount const stLim(toSTAmount(limit));
+    Amounts stAmt(toSTAmount(amount.in), toSTAmount(amount.out));
+    STAmount stLim(toSTAmount(limit));
    Amounts const stRes = ((*this).*ceil_function)(stAmt, stLim, roundUp...);
    return TAmounts<In, Out>(toAmount<In>(stRes.in), toAmount<Out>(stRes.out));
 }
--- a/include/xrpl/protocol/RippleLedgerHash.h
+++ b/include/xrpl/protocol/RippleLedgerHash.h
@@ -6,4 +6,4 @@ namespace xrpl {

 using LedgerHash = uint256;

-}  // namespace xrpl
+}
--- a/include/xrpl/protocol/STAmount.h
+++ b/include/xrpl/protocol/STAmount.h
@@ -35,9 +35,9 @@ public:

 private:
    Asset mAsset;
-    mantissa_type mValue{};
+    mantissa_type mValue;
    exponent_type mOffset;
-    bool mIsNegative{};
+    bool mIsNegative;

 public:
    using value_type = STAmount;
@@ -532,7 +532,7 @@ STAmount::fromNumber(A const& a, Number const& number)
 {
    bool const negative = number.mantissa() < 0;
    Number const working{negative ? -number : number};
-    Asset const asset{a};
+    Asset asset{a};
    if (asset.integral())
    {
        std::uint64_t const intValue = static_cast<std::int64_t>(working);
@@ -716,7 +716,7 @@ roundToAsset(
    std::int32_t scale,
    Number::rounding_mode rounding = Number::getround())
 {
-    NumberRoundModeGuard const mg(rounding);
+    NumberRoundModeGuard mg(rounding);
    STAmount const ret{asset, value};
    if (ret.integral())
        return ret;
--- a/include/xrpl/protocol/STBase.h
+++ b/include/xrpl/protocol/STBase.h
@@ -83,7 +83,7 @@ to_json(T const& t)

 namespace detail {
 class STVar;
-}  // namespace detail
+}

 // VFALCO TODO fix this restriction on copy assignment.
 //
--- a/include/xrpl/protocol/STLedgerEntry.h
+++ b/include/xrpl/protocol/STLedgerEntry.h
@@ -8,7 +8,7 @@ namespace xrpl {
 class Rules;
 namespace test {
 class Invariants_test;
-}  // namespace test
+}

 class STLedgerEntry final : public STObject, public CountedObject<STLedgerEntry>
 {
@@ -86,9 +86,7 @@ inline STLedgerEntry::STLedgerEntry(LedgerEntryType type, uint256 const& key)
 {
 }

-inline STLedgerEntry::STLedgerEntry(
-    SerialIter&& sit,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
-    uint256 const& index)
+inline STLedgerEntry::STLedgerEntry(SerialIter&& sit, uint256 const& index)
    : STLedgerEntry(sit, index)
 {
 }
--- a/include/xrpl/protocol/STObject.h
+++ b/include/xrpl/protocol/STObject.h
@@ -671,7 +671,7 @@ public:
    OptionalProxy&
    operator=(std::nullopt_t const&);
    OptionalProxy&
-    operator=(optional_type&& v);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    operator=(optional_type&& v);
    OptionalProxy&
    operator=(optional_type const& v);

@@ -766,7 +766,7 @@ STObject::Proxy<T>::assign(U&& u)
        st_->makeFieldAbsent(*f_);
        return;
    }
-    T* t = nullptr;
+    T* t;
    if (style_ == soeINVALID)
        t = dynamic_cast<T*>(st_->getPField(*f_, true));
    else
@@ -851,9 +851,7 @@ STObject::OptionalProxy<T>::operator=(std::nullopt_t const&) -> OptionalProxy&

 template <class T>
 auto
-STObject::OptionalProxy<T>::operator=(
-    optional_type&& v)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
-    -> OptionalProxy&
+STObject::OptionalProxy<T>::operator=(optional_type&& v) -> OptionalProxy&
 {
    if (v)
        this->assign(std::move(*v));
@@ -932,7 +930,6 @@ STObject::Transform::operator()(detail::STVar const& e) const

 //------------------------------------------------------------------------------

-// NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
 inline STObject::STObject(SerialIter&& sit, SField const& name) : STObject(sit, name)
 {
 }
@@ -1156,7 +1153,7 @@ STObject::getFieldByValue(SField const& field) const
    if (!rf)
        throwFieldNotFound(field);

-    SerializedTypeID const id = rf->getSType();
+    SerializedTypeID id = rf->getSType();

    if (id == STI_NOTPRESENT)
        return V();  // optional field not present
@@ -1183,7 +1180,7 @@ STObject::getFieldByConstRef(SField const& field, V const& empty) const
    if (!rf)
        throwFieldNotFound(field);

-    SerializedTypeID const id = rf->getSType();
+    SerializedTypeID id = rf->getSType();

    if (id == STI_NOTPRESENT)
        return empty;  // optional field not present
--- a/include/xrpl/protocol/STTx.h
+++ b/include/xrpl/protocol/STTx.h
@@ -179,8 +179,7 @@ sterilize(STTx const& stx);
 bool
 isPseudoTx(STObject const& tx);

-inline STTx::STTx(SerialIter&& sit)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
-    : STTx(sit)
+inline STTx::STTx(SerialIter&& sit) : STTx(sit)
 {
 }

--- a/include/xrpl/protocol/Serializer.h
+++ b/include/xrpl/protocol/Serializer.h
@@ -69,7 +69,7 @@ public:
    int
    add32(T i)
    {
-        int const ret = mData.size();
+        int ret = mData.size();
        mData.push_back(static_cast<unsigned char>((i >> 24) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 16) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 8) & 0xff));
@@ -85,7 +85,7 @@ public:
    int
    add64(T i)
    {
-        int const ret = mData.size();
+        int ret = mData.size();
        mData.push_back(static_cast<unsigned char>((i >> 56) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 48) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 40) & 0xff));
@@ -299,7 +299,7 @@ template <class Iter>
 int
 Serializer::addVL(Iter begin, Iter end, int len)
 {
-    int const ret = addEncoded(len);
+    int ret = addEncoded(len);
    for (; begin != end; ++begin)
    {
        addRaw(begin->data(), begin->size());
--- a/include/xrpl/protocol/TxSearched.h
+++ b/include/xrpl/protocol/TxSearched.h
@@ -4,4 +4,4 @@ namespace xrpl {

 enum class TxSearched { All, Some, Unknown };

-}  // namespace xrpl
+}
--- a/include/xrpl/protocol/detail/STVar.h
+++ b/include/xrpl/protocol/detail/STVar.h
@@ -25,10 +25,16 @@ extern nonPresentObject_t nonPresentObject;

 // Concept to constrain STVar constructors, which
 // instantiate ST* types from SerializedTypeID
+// clang-format off
 template <typename... Args>
 concept ValidConstructSTArgs =
-    (std::is_same_v<std::tuple<std::remove_cvref_t<Args>...>, std::tuple<SField>> ||
-     std::is_same_v<std::tuple<std::remove_cvref_t<Args>...>, std::tuple<SerialIter, SField>>);
+    (std::is_same_v<
+         std::tuple<std::remove_cvref_t<Args>...>,
+         std::tuple<SField>> ||
+     std::is_same_v<
+         std::tuple<std::remove_cvref_t<Args>...>,
+         std::tuple<SerialIter, SField>>);
+// clang-format on

 // "variant" that can hold any type of serialized object
 // and includes a small-object allocation optimization.
@@ -50,7 +56,7 @@ public:
    STVar&
    operator=(STVar&& rhs);

-    STVar(STBase&& t)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    STVar(STBase&& t)
    {
        p_ = t.move(max_size, &d_);
    }
--- a/include/xrpl/protocol/detail/b58_utils.h
+++ b/include/xrpl/protocol/detail/b58_utils.h
@@ -59,7 +59,7 @@ inplace_bigint_add(std::span<std::uint64_t> a, std::uint64_t b)
        return TokenCodecErrc::inputTooSmall;
    }

-    std::uint64_t carry = 0;
+    std::uint64_t carry;
    std::tie(a[0], carry) = carrying_add(a[0], b);

    for (auto& v : a.subspan(1))
@@ -162,7 +162,7 @@ b58_10_to_b58_be(std::uint64_t input)
    int i = 0;
    while (input > 0)
    {
-        std::uint64_t rem = 0;
+        std::uint64_t rem;
        std::tie(input, rem) = div_rem(input, 58);
        result[resultSize - 1 - i] = rem;
        i += 1;
--- a/include/xrpl/protocol/detail/features.macro
+++ b/include/xrpl/protocol/detail/features.macro
@@ -11,65 +11,66 @@
 #error "undefined macro: XRPL_RETIRE_FIX"
 #endif

+// clang-format off

 // Add new amendments to the top of this list.
 // Keep it sorted in reverse chronological order.

-XRPL_FIX    (Security3_1_3,               Supported::no, VoteBehavior::DefaultNo)
-XRPL_FIX    (PermissionedDomainInvariant, Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (ExpiredNFTokenOfferRemoval,  Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (BatchInnerSigs,              Supported::no, VoteBehavior::DefaultNo)
-XRPL_FEATURE(LendingProtocol,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PermissionDelegationV1_1,    Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FIX    (DirectoryLimit,              Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (IncludeKeyletFields,         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DynamicMPT,                  Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FIX    (TokenEscrowV1,               Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (PriceOracleOrder,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (MPTDeliveredAmount,          Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMClawbackRounding,         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(TokenEscrow,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (EnforceNFTokenTrustlineV2,   Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMv1_3,                     Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PermissionedDEX,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(Batch,                       Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FEATURE(SingleAssetVault,            Supported::yes,  VoteBehavior::DefaultNo)
-XRPL_FIX    (PayChanCancelAfter,          Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX   (Security3_1_3,               Supported::no, VoteBehavior::DefaultNo)
+XRPL_FIX   (PermissionedDomainInvariant, Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (ExpiredNFTokenOfferRemoval, Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (BatchInnerSigs,             Supported::no, VoteBehavior::DefaultNo)
+XRPL_FEATURE(LendingProtocol,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PermissionDelegationV1_1,   Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FIX    (DirectoryLimit,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (IncludeKeyletFields,        Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DynamicMPT,                 Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FIX    (TokenEscrowV1,              Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (PriceOracleOrder,           Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (MPTDeliveredAmount,         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMClawbackRounding,        Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(TokenEscrow,                Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (EnforceNFTokenTrustlineV2,  Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMv1_3,                    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PermissionedDEX,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(Batch,                      Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FEATURE(SingleAssetVault,           Supported::yes,  VoteBehavior::DefaultNo)
+XRPL_FIX    (PayChanCancelAfter,         Supported::yes, VoteBehavior::DefaultNo)
 // Check flags in Credential transactions
-XRPL_FIX    (InvalidTxFlags,              Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (FrozenLPTokenTransfer,       Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DeepFreeze,                  Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PermissionedDomains,         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DynamicNFT,                  Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(Credentials,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(AMMClawback,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMv1_2,                     Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(MPTokensV1,                  Supported::yes, VoteBehavior::DefaultNo)
-// InvariantsV1_1 will be changed to Supported::yes when all the invariants expected to be included
-// under it are complete.
-XRPL_FEATURE(InvariantsV1_1,              Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FIX    (NFTokenPageLinks,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (InnerObjTemplate2,           Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (EnforceNFTokenTrustline,     Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (ReducedOffersV2,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(NFTokenMintOffer,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMv1_1,                     Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (PreviousTxnID,               Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (XChainRewardRounding,        Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (EmptyDID,                    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PriceOracle,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMOverflowOffer,            Supported::yes, VoteBehavior::DefaultYes)
-XRPL_FIX    (InnerObjTemplate,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (NFTokenReserve,              Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (FillOrKill,                  Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DID,                         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (DisallowIncomingV1,          Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(XChainBridge,                Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(AMM,                         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(Clawback,                    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (UniversalNumber,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(XRPFees,                     Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (RemoveNFTokenAutoTrustLine,  Supported::yes, VoteBehavior::DefaultYes)
+XRPL_FIX    (InvalidTxFlags,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (FrozenLPTokenTransfer,      Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DeepFreeze,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PermissionedDomains,        Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DynamicNFT,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(Credentials,                Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(AMMClawback,                Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMv1_2,                    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(MPTokensV1,                 Supported::yes, VoteBehavior::DefaultNo)
+// InvariantsV1_1 will be changes to Supported::yes when all the
+// invariants expected to be included under it are complete.
+XRPL_FEATURE(InvariantsV1_1,             Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FIX    (NFTokenPageLinks,           Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (InnerObjTemplate2,          Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (EnforceNFTokenTrustline,    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (ReducedOffersV2,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(NFTokenMintOffer,           Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMv1_1,                    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (PreviousTxnID,              Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (XChainRewardRounding,       Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (EmptyDID,                   Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PriceOracle,                Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMOverflowOffer,           Supported::yes, VoteBehavior::DefaultYes)
+XRPL_FIX    (InnerObjTemplate,           Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (NFTokenReserve,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (FillOrKill,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DID,                        Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (DisallowIncomingV1,         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(XChainBridge,               Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(AMM,                        Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(Clawback,                   Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (UniversalNumber,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(XRPFees,                    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (RemoveNFTokenAutoTrustLine, Supported::yes, VoteBehavior::DefaultYes)

 // The following amendments are obsolete, but must remain supported
 // because they could potentially get enabled.
@@ -143,3 +144,5 @@ XRPL_RETIRE_FEATURE(SortedDirectories)
 XRPL_RETIRE_FEATURE(TicketBatch)
 XRPL_RETIRE_FEATURE(TickSize)
 XRPL_RETIRE_FEATURE(TrustSetAuth)
+
+// clang-format on
--- a/include/xrpl/protocol/detail/sfields.macro
+++ b/include/xrpl/protocol/detail/sfields.macro
@@ -5,6 +5,7 @@
 #error "undefined macro: TYPED_SFIELD"
 #endif

+// clang-format off

 // untyped
 UNTYPED_SFIELD(sfLedgerEntry,            LEDGERENTRY, 257)
@@ -420,3 +421,5 @@ UNTYPED_SFIELD(sfAcceptedCredentials,    ARRAY,     28)
 UNTYPED_SFIELD(sfPermissions,            ARRAY,     29)
 UNTYPED_SFIELD(sfRawTransactions,        ARRAY,     30)
 UNTYPED_SFIELD(sfBatchSigners,           ARRAY,     31, SField::sMD_Default, SField::notSigning)
+
+// clang-format on
--- a/include/xrpl/protocol/detail/token_errors.h
+++ b/include/xrpl/protocol/detail/token_errors.h
@@ -15,7 +15,7 @@ enum class TokenCodecErrc {
    overflowAdd,
    unknown,
 };
-}  // namespace xrpl
+}

 namespace std {
 template <>
@@ -69,7 +69,7 @@ public:
 inline xrpl::detail::TokenCodecErrcCategory const&
 TokenCodecErrcCategory()
 {
-    static xrpl::detail::TokenCodecErrcCategory const c;
+    static xrpl::detail::TokenCodecErrcCategory c;
    return c;
 }

--- a/include/xrpl/protocol/json_get_or_throw.h
+++ b/include/xrpl/protocol/json_get_or_throw.h
@@ -112,7 +112,7 @@ getOrThrow(Json::Value const& v, xrpl::SField const& field)
    {
        auto const s = inner.asString();
        // parse as hex
-        std::uint64_t val = 0;
+        std::uint64_t val;

        auto [p, ec] = std::from_chars(s.data(), s.data() + s.size(), val, 16);

--- a/include/xrpl/protocol/jss.h
+++ b/include/xrpl/protocol/jss.h
--- a/include/xrpl/protocol/nft.h
+++ b/include/xrpl/protocol/nft.h
@@ -39,7 +39,7 @@ constexpr std::uint16_t const flagMutable = 0x0010;
 inline std::uint16_t
 getFlags(uint256 const& id)
 {
-    std::uint16_t flags = 0;
+    std::uint16_t flags;
    memcpy(&flags, id.begin(), 2);
    return boost::endian::big_to_native(flags);
 }
@@ -47,7 +47,7 @@ getFlags(uint256 const& id)
 inline std::uint16_t
 getTransferFee(uint256 const& id)
 {
-    std::uint16_t fee = 0;
+    std::uint16_t fee;
    memcpy(&fee, id.begin() + 2, 2);
    return boost::endian::big_to_native(fee);
 }
@@ -55,7 +55,7 @@ getTransferFee(uint256 const& id)
 inline std::uint32_t
 getSerial(uint256 const& id)
 {
-    std::uint32_t seq = 0;
+    std::uint32_t seq;
    memcpy(&seq, id.begin() + 28, 4);
    return boost::endian::big_to_native(seq);
 }
@@ -87,7 +87,7 @@ cipheredTaxon(std::uint32_t tokenSeq, Taxon taxon)
 inline Taxon
 getTaxon(uint256 const& id)
 {
-    std::uint32_t taxon = 0;
+    std::uint32_t taxon;
    memcpy(&taxon, id.begin() + 24, 4);
    taxon = boost::endian::big_to_native(taxon);

--- a/include/xrpl/protocol_autogen/.clang-tidy
+++ b/include/xrpl/protocol_autogen/.clang-tidy
@@ -1,3 +0,0 @@
-# This disables all checks for this directory and its subdirectories
-Checks: "-*"
-InheritParentConfig: false
--- a/include/xrpl/rdb/DatabaseCon.h
+++ b/include/xrpl/rdb/DatabaseCon.h
@@ -14,7 +14,7 @@

 namespace soci {
 class session;
-}  // namespace soci
+}

 namespace xrpl {

--- a/include/xrpl/rdb/RelationalDatabase.h
+++ b/include/xrpl/rdb/RelationalDatabase.h
@@ -51,19 +51,19 @@ public:
        AccountID const& account;
        /// Ledger sequence range to search. A value of 0 for min or max
        /// means unbounded in that direction (no constraint applied).
-        LedgerRange ledgerRange{};
-        std::uint32_t offset = 0;
-        std::uint32_t limit = 0;
-        bool bUnlimited{};
+        LedgerRange ledgerRange;
+        std::uint32_t offset;
+        std::uint32_t limit;
+        bool bUnlimited;
    };

    struct AccountTxPageOptions
    {
        AccountID const& account;
-        LedgerRange ledgerRange{};
+        LedgerRange ledgerRange;
        std::optional<AccountTxMarker> marker;
-        std::uint32_t limit = 0;
-        bool bAdmin = false;
+        std::uint32_t limit;
+        bool bAdmin;
    };

    using AccountTx = std::pair<std::shared_ptr<Transaction>, std::shared_ptr<TxMeta>>;
@@ -88,8 +88,8 @@ public:
    struct AccountTxResult
    {
        std::variant<AccountTxs, MetaTxsList> transactions;
-        LedgerRange ledgerRange{};
-        uint32_t limit = 0;
+        LedgerRange ledgerRange;
+        uint32_t limit;
        std::optional<AccountTxMarker> marker;
    };

--- a/include/xrpl/rdb/SociDB.h
+++ b/include/xrpl/rdb/SociDB.h
@@ -25,7 +25,7 @@

 namespace sqlite_api {
 struct sqlite3;
-}  // namespace sqlite_api
+}

 namespace xrpl {

--- a/include/xrpl/resource/Fees.h
+++ b/include/xrpl/resource/Fees.h
@@ -5,30 +5,38 @@
 namespace xrpl {
 namespace Resource {

+// clang-format off
 /** Schedule of fees charged for imposing load on the server. */
 /** @{ */
-extern Charge const feeMalformedRequest;  // A request that we can immediately tell is invalid.
-extern Charge const feeRequestNoReply;    // A request that we cannot satisfy.
-extern Charge const feeInvalidSignature;  // An object whose signature we had to check that failed.
-extern Charge const feeUselessData;       // Data we have no use for.
-extern Charge const feeInvalidData;       // Data we have to verify before rejecting.
+extern Charge const feeMalformedRequest;    // A request that we can immediately
+                                          //   tell is invalid
+extern Charge const feeRequestNoReply;    // A request that we cannot satisfy
+extern Charge const feeInvalidSignature;  // An object whose signature we had
+                                          //   to check and it failed
+extern Charge const feeUselessData;      // Data we have no use for
+extern Charge const feeInvalidData;           // Data we have to verify before
+                                          //   rejecting

 // RPC loads
-extern Charge const feeMalformedRPC;     // An RPC request that we can immediately tell is invalid.
-extern Charge const feeReferenceRPC;     // A default "reference" unspecified load.
-extern Charge const feeExceptionRPC;     // RPC load that causes an exception.
-extern Charge const feeMediumBurdenRPC;  // A somewhat burdensome RPC load.
-extern Charge const feeHeavyBurdenRPC;   // A very burdensome RPC load.
+extern Charge const feeMalformedRPC;        // An RPC request that we can
+                                          //   immediately tell is invalid.
+extern Charge const feeReferenceRPC;      // A default "reference" unspecified
+                                          //   load
+extern Charge const feeExceptionRPC;      // RPC load that causes an exception
+extern Charge const feeMediumBurdenRPC;   // A somewhat burdensome RPC load
+extern Charge const feeHeavyBurdenRPC;     // A very burdensome RPC load

 // Peer loads
-extern Charge const feeTrivialPeer;         // Requires no reply.
-extern Charge const feeModerateBurdenPeer;  // Requires some work.
-extern Charge const feeHeavyBurdenPeer;     // Extensive work.
+extern Charge const feeTrivialPeer;         // Requires no reply
+extern Charge const feeModerateBurdenPeer;  // Requires some work
+extern Charge const feeHeavyBurdenPeer;    // Extensive work

 // Administrative
-extern Charge const feeWarning;  // The cost of receiving a warning.
-extern Charge const feeDrop;     // The cost of being dropped for excess load.
+extern Charge const feeWarning;           // The cost of receiving a warning
+extern Charge const feeDrop;              // The cost of being dropped for
+                                          //   excess load
 /** @} */
+// clang-format on

 }  // namespace Resource
 }  // namespace xrpl
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Ed Hennis	c65794da36	Merge remote-tracking branch 'XRPLF/develop' into ximinez/acquireAsyncDispatch * XRPLF/develop: (81 commits) ci: Only publish docs in public repos (6687) chore: Enable remaining clang-tidy `performance` checks (6648) refactor: Address PR comments after the modularisation PRs (6389) chore: Fix clang-tidy header filter (6686) ci: [DEPENDABOT] bump actions/deploy-pages from 4.0.5 to 5.0.0 (6684) ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.3 to 6.0.0 (6685) fix: Guard Coro::resume() against completed coroutines (6608) refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant (6674) ci: Don't publish docs on release branches (6673) refactor: Make function naming in ServiceRegistry consistent (6390) chore: Shorten job names to stay within Linux 15-char thread limit (6669) fix: Improve loan invariant message (6668) ci: Upload artifacts only in public repositories (6670) ci: Add conflicting-pr workflow (6656) chore: Add more AI tools to .gitignore (6658) chore: Show warning message if user may need to connect to VPN (6619) feat: Add placeholder amendment for assorted bug fixes (6652) chore: Update sqlite3->3.51.0, protobuf->6.33.5, openssl->3.6.1, grpc->1.78.1 (6653) refactor: Modularise ledger (6536) chore: Use unpatched version of soci (6649) ...	2026-03-30 22:38:24 -04:00
Ed Hennis	30716646d7	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-03-12 15:05:10 -04:00
Ed Hennis	49b69a59eb	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-03-10 13:38:46 -04:00
Ed Hennis	5e37aa63c2	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-03-06 13:04:22 -04:00
Ed Hennis	979beeb162	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-03-04 17:11:47 -04:00
Ed Hennis	75e134a1fd	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-03-03 20:46:56 -04:00
Ed Hennis	828bcb3a7d	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-03-03 15:54:51 -04:00
Ed Hennis	6fc972746d	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-24 17:35:00 -04:00
Ed Hennis	930afbdea8	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-20 18:50:00 -04:00
Ed Hennis	95c5bef48b	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-20 18:26:19 -04:00
Ed Hennis	b489b6c3ce	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-20 17:32:02 -04:00
Ed Hennis	70765acef4	Merge remote-tracking branch 'upstream/develop' into ximinez/acquireAsyncDispatch * upstream/develop: ci: [DEPENDABOT] bump tj-actions/changed-files from 46.0.5 to 47.0.4 (6394) ci: [DEPENDABOT] bump codecov/codecov-action from 5.4.3 to 5.5.2 (6398) ci: Build docs in PRs and in private repos (6400) ci: Add dependabot config (6379) Fix tautological assertion (6393) chore: Apply clang-format width 100 (6387)	2026-02-20 16:30:42 -05:00
Ed Hennis	77aa90bd0e	Update formatting	2026-02-20 16:27:59 -05:00
Ed Hennis	4758bb6dc9	Merge commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c' into ximinez/acquireAsyncDispatch * commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c': chore: Set clang-format width to 100 in config file (6387)	2026-02-20 16:27:39 -05:00
Ed Hennis	46e3dcb5fb	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-19 16:24:54 -05:00
Ed Hennis	d57579f10b	Merge remote-tracking branch 'XRPLF/develop' into ximinez/acquireAsyncDispatch * XRPLF/develop: refactor: Modularize app/tx (6228) refactor: Decouple app/tx from `Application` and `Config` (6227) chore: Update clang-format to 21.1.8 (6352) refactor: Modularize `HashRouter`, `Conditions`, and `OrderBookDB` (6226) chore: Fix minor issues in comments (6346) refactor: Modularize the NetworkOPs interface (6225) chore: Fix `gcov` lib coverage build failure on macOS (6350) refactor: Modularize RelationalDB (6224) refactor: Modularize WalletDB and Manifest (6223) fix: Update invariant checks for Permissioned Domains (6134) refactor: Change main thread name to `xrpld-main` (6336) refactor: Fix spelling issues in tests (6199) test: Add file and line location to Env (6276) chore: Remove CODEOWNERS (6337) perf: Remove unnecessary caches (5439) chore: Restore unity builds (6328) refactor: Update secp256k1 to 0.7.1 (6331) fix: Increment sequence when accepting new manifests (6059) fix typo in LendingHelpers unit-test (6215)	2026-02-18 19:52:18 -05:00
Ed Hennis	d8dd376d1c	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-04 16:30:10 -04:00
Ed Hennis	a8c03e2e6c	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-02-03 16:08:06 -04:00
Ed Hennis	2167a66bc7	Fix formatting	2026-01-28 19:39:15 -05:00
Ed Hennis	ed948a858c	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-28 18:49:15 -04:00
Ed Hennis	608c102743	Merge commit '5f638f55536def0d88b970d1018a465a238e55f4' into ximinez/acquireAsyncDispatch * commit '5f638f55536def0d88b970d1018a465a238e55f4': chore: Set ColumnLimit to 120 in clang-format (6288)	2026-01-28 17:47:53 -05:00
Ed Hennis	36d1607a4e	Merge commit '92046785d1fea5f9efe5a770d636792ea6cab78b' into ximinez/acquireAsyncDispatch * commit '92046785d1fea5f9efe5a770d636792ea6cab78b': test: Fix the `xrpl.net` unit test using async read (6241) ci: Upload Conan recipes for develop, release candidates, and releases (6286) fix: Stop embedded tests from hanging on ARM by using `atomic_flag` (6248) fix: Remove DEFAULT fields that change to the default in associateAsset (6259) (6273) refactor: Update Boost to 1.90 (6280) refactor: clean up uses of `std::source_location` (6272) ci: Pass missing sanitizers input to actions (6266) ci: Properly propagate Conan credentials (6265) ci: Explicitly set version when exporting the Conan recipe (6264) ci: Use plus instead of hyphen for Conan recipe version suffix (6261) chore: Detect uninitialized variables in CMake files (6247) ci: Run on-trigger and on-pr when generate-version is modified (6257) refactor: Enforce 15-char limit and simplify labels for thread naming (6212) docs: Update Ripple Bug Bounty public key (6258) ci: Add missing commit hash to Conan recipe version (6256) fix: Include `<functional>` header in `Number.h` (6254) ci: Upload Conan recipe for merges into develop and commits to release (6235) Limit reply size on `TMGetObjectByHash` queries (6110) ci: remove 'master' branch as a trigger (6234) Improve ledger_entry lookups for fee, amendments, NUNL, and hashes (5644)	2026-01-28 17:47:47 -05:00
Ed Hennis	53ebb86d60	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-15 13:03:36 -04:00
Ed Hennis	1d989bc6de	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-15 12:06:00 -04:00
Ed Hennis	64c0cb8c7e	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-13 18:19:11 -04:00
Ed Hennis	c77cfef41c	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-13 15:28:01 -04:00
Ed Hennis	08aa8c06d1	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-12 14:52:16 -04:00
Ed Hennis	9498672f8e	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-11 00:50:43 -04:00
Ed Hennis	e91d55a0e0	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-08 17:06:11 -04:00
Ed Hennis	afdc452cfc	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-08 13:04:20 -04:00
Ed Hennis	a0d4ef1a54	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2026-01-06 14:02:15 -05:00
Ed Hennis	8bc384f8bf	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-12-22 17:39:59 -05:00
Ed Hennis	bd961c484b	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-12-18 19:59:52 -05:00
Ed Hennis	aee242a8d4	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-12-12 20:34:59 -05:00
Ed Hennis	fcae74de58	Merge remote-tracking branch 'XRPLF/develop' into ximinez/acquireAsyncDispatch * XRPLF/develop: refactor: Rename `ripple` namespace to `xrpl` (5982) refactor: Move JobQueue and related classes into xrpl.core module (6121) refactor: Rename `rippled` binary to `xrpld` (5983) refactor: rename info() to header() (6138) refactor: rename `LedgerInfo` to `LedgerHeader` (6136) refactor: clean up `RPCHelpers` (5684) chore: Fix docs readme and cmake (6122) chore: Clean up .gitignore and .gitattributes (6001) chore: Use updated secp256k1 recipe (6118)	2025-12-11 15:33:12 -05:00
Ed Hennis	a56effcb00	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-12-05 21:13:10 -05:00
Ed Hennis	64c2eca465	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-12-02 17:37:29 -05:00
Ed Hennis	e56f750e1d	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-12-01 14:40:45 -05:00
Ed Hennis	fde000f3eb	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-28 15:46:44 -05:00
Ed Hennis	d0a62229da	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-27 01:48:56 -05:00
Ed Hennis	d5932cc7d4	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-26 00:25:17 -05:00
Ed Hennis	0b534da781	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-25 14:55:06 -05:00
Ed Hennis	71a70d343b	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-24 21:49:11 -05:00
Ed Hennis	0899e65030	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-24 21:30:22 -05:00
Ed Hennis	31ba529761	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-21 12:47:58 -05:00
Ed Hennis	e2c6e5ebb6	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-18 22:39:29 -05:00
Ed Hennis	9d807fce48	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-15 03:08:41 -05:00
Ed Hennis	9ef160765c	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-13 12:19:21 -05:00
Ed Hennis	d6c0eb243b	Merge branch 'develop' into ximinez/acquireAsyncDispatch	2025-11-12 14:12:55 -05:00
Ed Hennis	84c9fc123c	Fix formatting	2025-11-10 19:53:05 -05:00
Ed Hennis	00a2a58cfa	Add missing header	2025-11-10 19:53:05 -05:00
Ed Hennis	bb2098d873	Add a unit test for CanProcess - Delete the copy ctor & operator	2025-11-10 19:53:05 -05:00
Ed Hennis	46a5bc74db	refactor: acquireAsync will dispatch the job, not the other way around	2025-11-10 19:53:05 -05:00
Ed Hennis	7b72b9cc82	Improve job queue collision checks and logging - Improve logging related to ledger acquisition and operating mode changes - Class "CanProcess" to keep track of processing of distinct items	2025-11-10 19:53:05 -05:00