Merge branch 'develop' into copilot/fix-vetoed-type-error

fix: Check trustline limits for share-denominated vault withdrawals (#6645 )
fix: Remove fatal assertion on Linux thread name truncation (#6690 )
2026-04-03 10:32:30 +00:00 · 2026-04-01 16:19:18 -04:00 · 2026-04-01 19:31:45 +00:00 · 2026-04-01 16:56:45 +00:00 · 2026-04-01 15:46:14 +00:00 · 2026-04-01 13:37:35 +00:00
627 changed files with 6761 additions and 6544 deletions
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,4 +1,6 @@
 ---
+# This entire group of checks was applied to all cpp files but not all header files.
+# ---
 Checks: "-*,
  bugprone-argument-comment,
  bugprone-assert-side-effect,
@@ -8,26 +10,26 @@ Checks: "-*,
  bugprone-chained-comparison,
  bugprone-compare-pointer-to-member-virtual-function,
  bugprone-copy-constructor-init,
-  bugprone-crtp-constructor-accessibility,
+  # bugprone-crtp-constructor-accessibility, # has issues
  bugprone-dangling-handle,
  bugprone-dynamic-static-initializers,
-  bugprone-empty-catch,
+  # bugprone-empty-catch, # has issues
  bugprone-fold-init-type,
-  bugprone-forward-declaration-namespace,
-  bugprone-inaccurate-erase,
-  bugprone-inc-dec-in-conditions,
-  bugprone-incorrect-enable-if,
-  bugprone-incorrect-roundings,
-  bugprone-infinite-loop,
-  bugprone-integer-division,
+  # bugprone-forward-declaration-namespace, # has issues
+  # bugprone-inaccurate-erase,
+  # bugprone-inc-dec-in-conditions,
+  # bugprone-incorrect-enable-if,
+  # bugprone-incorrect-roundings,
+  # bugprone-infinite-loop,
+  # bugprone-integer-division,
  bugprone-lambda-function-name,
-  bugprone-macro-parentheses,
+  # bugprone-macro-parentheses, # has issues
  bugprone-macro-repeated-side-effects,
  bugprone-misplaced-operator-in-strlen-in-alloc,
  bugprone-misplaced-pointer-arithmetic-in-alloc,
  bugprone-misplaced-widening-cast,
  bugprone-move-forwarding-reference,
-  bugprone-multi-level-implicit-pointer-conversion,
+  # bugprone-multi-level-implicit-pointer-conversion, # has issues
  bugprone-multiple-new-in-one-expression,
  bugprone-multiple-statement-macro,
  bugprone-no-escape,
@@ -37,13 +39,13 @@ Checks: "-*,
  bugprone-pointer-arithmetic-on-polymorphic-object,
  bugprone-posix-return,
  bugprone-redundant-branch-condition,
-  bugprone-reserved-identifier,
-  bugprone-return-const-ref-from-parameter,
+  # bugprone-reserved-identifier, # has issues
+  # bugprone-return-const-ref-from-parameter, # has issues
  bugprone-shared-ptr-array-mismatch,
  bugprone-signal-handler,
  bugprone-signed-char-misuse,
  bugprone-sizeof-container,
-  bugprone-sizeof-expression,
+  # bugprone-sizeof-expression, # has issues
  bugprone-spuriously-wake-up-functions,
  bugprone-standalone-empty,
  bugprone-string-constructor,
@@ -60,7 +62,7 @@ Checks: "-*,
  bugprone-suspicious-string-compare,
  bugprone-suspicious-stringview-data-usage,
  bugprone-swapped-arguments,
-  bugprone-switch-missing-default-case,
+  # bugprone-switch-missing-default-case, # has issues
  bugprone-terminating-continue,
  bugprone-throw-keyword-missing,
  bugprone-too-small-loop-variable,
@@ -71,7 +73,7 @@ Checks: "-*,
  bugprone-unhandled-self-assignment,
  bugprone-unique-ptr-array-mismatch,
  bugprone-unsafe-functions,
-  bugprone-use-after-move,
+  # bugprone-use-after-move, # has issues
  bugprone-unused-raii,
  bugprone-unused-return-value,
  bugprone-unused-local-non-trivial-variable,
@@ -85,9 +87,11 @@ Checks: "-*,
  cppcoreguidelines-use-default-member-init,
  cppcoreguidelines-virtual-class-destructor,
  hicpp-ignored-remove-result,
+  misc-const-correctness,
  misc-definitions-in-headers,
  misc-header-include-cycle,
  misc-misplaced-const,
+  misc-redundant-expression,
  misc-static-assert,
  misc-throw-by-value-catch-by-reference,
  misc-unused-alias-decls,
@@ -95,46 +99,49 @@ Checks: "-*,
  modernize-deprecated-headers,
  modernize-make-shared,
  modernize-make-unique,
+  llvm-namespace-comment,
+  performance-faster-string-find,
+  performance-for-range-copy,
  performance-implicit-conversion-in-loop,
+  performance-inefficient-vector-operation,
+  performance-move-const-arg,
  performance-move-constructor-init,
+  performance-no-automatic-move,
  performance-trivially-destructible,
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-convert-member-functions-to-static,
+  # readability-avoid-nested-conditional-operator, # has issues
+  # readability-avoid-return-with-void-value, # has issues
+  # readability-braces-around-statements, # has issues
+  # readability-const-return-type, # has issues
+  # readability-container-contains, # has issues
+  # readability-container-size-empty, # has issues
+  # readability-convert-member-functions-to-static, # has issues
  readability-duplicate-include,
-  readability-else-after-return,
-  readability-enum-initial-value,
-  readability-implicit-bool-conversion,
-  readability-make-member-function-const,
-  readability-math-missing-parentheses,
+  # readability-else-after-return, # has issues
+  # readability-enum-initial-value, # has issues
+  # readability-implicit-bool-conversion, # has issues
+  # readability-make-member-function-const, # has issues
+  # readability-math-missing-parentheses, # has issues
  readability-misleading-indentation,
  readability-non-const-parameter,
-  readability-redundant-casting,
-  readability-redundant-declaration,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
+  # readability-redundant-casting, # has issues
+  # readability-redundant-declaration, # has issues
+  # readability-redundant-inline-specifier, # has issues
+  # readability-redundant-member-init, # has issues
  readability-redundant-string-init,
  readability-reference-to-constructed-temporary,
-  readability-simplify-boolean-expr,
-  readability-static-definition-in-anonymous-namespace,
-  readability-suspicious-call-argument,
+  # readability-simplify-boolean-expr, # has issues
+  # readability-static-definition-in-anonymous-namespace, # has issues
+  # readability-suspicious-call-argument, # has issues
  readability-use-std-min-max
  "
 # ---
-# checks that have some issues that need to be resolved:
+# other checks that have issues that need to be resolved:
 #
-# llvm-namespace-comment,
-# misc-const-correctness,
 # misc-include-cleaner,
-# misc-redundant-expression,
 #
 # readability-inconsistent-declaration-parameter-name, # in this codebase this check will break a lot of arg names
 # readability-static-accessed-through-instance,        # this check is probably unnecessary. it makes the code less readable
-# readability-identifier-naming,
+# readability-identifier-naming,                       # https://github.com/XRPLF/rippled/pull/6571
 #
 # modernize-concat-nested-namespaces,
 # modernize-pass-by-value,
@@ -148,12 +155,6 @@ Checks: "-*,
 # modernize-use-starts-ends-with,
 # modernize-use-std-numbers,
 # modernize-use-using,
-#
-# performance-faster-string-find,
-# performance-for-range-copy,
-# performance-inefficient-vector-operation,
-# performance-move-const-arg,
-# performance-no-automatic-move,
 # ---
 #
 CheckOptions:
@@ -195,5 +196,6 @@ CheckOptions:
  bugprone-unused-return-value.CheckedReturnTypes: ::std::error_code;::std::error_condition;::std::errc
 #   misc-include-cleaner.IgnoreHeaders: '.*/(detail|impl)/.*;.*(expected|unexpected).*;.*ranges_lower_bound\.h;time.h;stdlib.h;__chrono/.*;fmt/chrono.h;boost/uuid/uuid_hash.hpp'
 #
-# HeaderFilterRegex: '^.*/(src|tests)/.*\.(h|hpp)$'
+HeaderFilterRegex: '^.*/(test|xrpl|xrpld)/.*\.(h|hpp)$'
+ExcludeHeaderFilterRegex: '^.*/protocol_autogen/.*\.(h|hpp)$'
 WarningsAsErrors: "*"
--- a/.github/scripts/levelization/results/ordering.txt
+++ b/.github/scripts/levelization/results/ordering.txt
@@ -21,6 +21,7 @@ libxrpl.protocol > xrpl.json
 libxrpl.protocol > xrpl.protocol
 libxrpl.protocol_autogen > xrpl.protocol_autogen
 libxrpl.rdb > xrpl.basics
+libxrpl.rdb > xrpl.core
 libxrpl.rdb > xrpl.rdb
 libxrpl.resource > xrpl.basics
 libxrpl.resource > xrpl.json
@@ -184,7 +185,6 @@ xrpl.conditions > xrpl.basics
 xrpl.conditions > xrpl.protocol
 xrpl.core > xrpl.basics
 xrpl.core > xrpl.json
-xrpl.core > xrpl.ledger
 xrpl.core > xrpl.protocol
 xrpl.json > xrpl.basics
 xrpl.ledger > xrpl.basics
--- a/.github/workflows/check-pr-commits.yml
+++ b/.github/workflows/check-pr-commits.yml
@@ -1,7 +1,7 @@
 name: Check PR commits

 on:
-  pull_request:
+  pull_request_target:

 # The action needs to have write permissions to post comments on the PR.
 permissions:
--- a/.github/workflows/publish-docs.yml
+++ b/.github/workflows/publish-docs.yml
@@ -6,7 +6,6 @@ on:
  push:
    branches:
      - "develop"
-      - "release*"
    paths:
      - ".github/workflows/publish-docs.yml"
      - "*.md"
@@ -37,7 +36,7 @@ env:
  BUILD_DIR: build
  # ubuntu-latest has only 2 CPUs for private repositories
  # https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for--private-repositories
-  NPROC_SUBTRACT: ${{ github.event.repository.private && '1' || '2' }}
+  NPROC_SUBTRACT: ${{ github.event.repository.visibility == 'public' && '2' || '1' }}

 jobs:
  build:
@@ -82,13 +81,13 @@ jobs:
          cmake --build . --target docs --parallel ${BUILD_NPROC}

      - name: Create documentation artifact
-        if: ${{ github.event_name == 'push' }}
+        if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && github.event_name == 'push' }}
        uses: actions/upload-pages-artifact@7b1f4a764d45c48632c6b24a0339c27f5614fb0b # v4.0.0
        with:
          path: ${{ env.BUILD_DIR }}/docs/html

  deploy:
-    if: ${{ github.event_name == 'push' }}
+    if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && github.event_name == 'push' }}
    needs: build
    runs-on: ubuntu-latest
    permissions:
@@ -100,4 +99,4 @@ jobs:
    steps:
      - name: Deploy to GitHub Pages
        id: deploy
-        uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5
+        uses: actions/deploy-pages@cd2ce8fcbc39b97be8ca5fce6e763baed58fa128 # v5.0.0
--- a/.github/workflows/reusable-build-test-config.yml
+++ b/.github/workflows/reusable-build-test-config.yml
@@ -199,7 +199,7 @@ jobs:
          fi

      - name: Upload the binary (Linux)
-        if: ${{ github.repository == 'XRPLF/rippled' && runner.os == 'Linux' }}
+        if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && runner.os == 'Linux' }}
        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
        with:
          name: xrpld-${{ inputs.config_name }}
@@ -298,7 +298,7 @@ jobs:

      - name: Upload coverage report
        if: ${{ github.repository == 'XRPLF/rippled' && !inputs.build_only && env.COVERAGE_ENABLED == 'true' }}
-        uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
+        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
        with:
          disable_search: true
          disable_telem: true
--- a/.github/workflows/reusable-clang-tidy-files.yml
+++ b/.github/workflows/reusable-clang-tidy-files.yml
@@ -80,10 +80,10 @@ jobs:
        env:
          TARGETS: ${{ inputs.files != '' && inputs.files || 'src tests' }}
        run: |
-          run-clang-tidy -j ${{ steps.nproc.outputs.nproc }} -p "${BUILD_DIR}" ${TARGETS} 2>&1 | tee clang-tidy-output.txt
+          run-clang-tidy -j ${{ steps.nproc.outputs.nproc }} -p "${BUILD_DIR}" -quiet -allow-no-checks ${TARGETS} 2>&1 | tee clang-tidy-output.txt

      - name: Upload clang-tidy output
-        if: steps.run_clang_tidy.outcome != 'success'
+        if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && steps.run_clang_tidy.outcome != 'success' }}
        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
        with:
          name: clang-tidy-results
--- a/API-CHANGELOG.md
+++ b/API-CHANGELOG.md
@@ -92,6 +92,10 @@ This release contains bug fixes only and no API changes.

 [Version 2.5.0](https://github.com/XRPLF/rippled/releases/tag/2.5.0) was released on Jun 24, 2025.

+### Breaking changes in 2.5.0
+
+- `feature`: The `vetoed` field in admin-mode responses is now always a boolean. Disabled obsolete amendments now have `"vetoed": true` instead of the previous `"vetoed": "Obsolete"` string value, which was not type-safe. A new `"obsolete"` boolean field is now included in all responses (both admin and non-admin), indicating whether an amendment is obsolete.
+
 ### Additions and bugfixes in 2.5.0

 - `tx`: Added `ctid` field to the response and improved error handling. ([#4738](https://github.com/XRPLF/rippled/pull/4738))
--- a/BUILD.md
+++ b/BUILD.md
@@ -141,7 +141,7 @@ Alternatively, you can pull our recipes from the repository and export them loca

 ```bash
 # Define which recipes to export.
-recipes=('abseil' 'ed25519' 'grpc' 'm4' 'mpt-crypto' 'nudb' 'openssl' 'secp256k1' 'snappy' 'soci' 'wasm-xrplf' 'wasmi')
+recipes=('abseil' 'ed25519' 'grpc' 'm4' 'mpt-crypto' 'openssl' 'secp256k1' 'snappy' 'soci' 'wasm-xrplf' 'wasmi')

 # Selectively check out the recipes from our CCI fork.
 cd external
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -270,14 +270,14 @@ Before running clang-tidy, you must build the project to generate required files
 Then run clang-tidy on your local changes:

 ```
-run-clang-tidy -p build src include tests
+run-clang-tidy -p build -allow-no-checks src tests
 ```

 This will check all source files in the `src`, `include` and `tests` directories using the compile commands from your `build` directory.
 If you wish to automatically fix whatever clang-tidy finds _and_ is capable of fixing, add `-fix` to the above command:

 ```
-run-clang-tidy -p build -fix src include tests
+run-clang-tidy -p build -quiet -fix -allow-no-checks src tests
 ```

 ## Contracts and instrumentation
--- a/conan.lock
+++ b/conan.lock
@@ -3,22 +3,22 @@
    "requires": [
        "zlib/1.3.1#cac0f6daea041b0ccf42934163defb20%1774439233.809",
        "xxhash/0.8.3#681d36a0a6111fc56e5e45ea182c19cc%1765850149.987",
-        "sqlite3/3.51.0#66aa11eabd0e34954c5c1c061ad44abe%1763899256.358",
+        "sqlite3/3.51.0#66aa11eabd0e34954c5c1c061ad44abe%1774467355.988",
        "soci/4.0.3#fe32b9ad5eb47e79ab9e45a68f363945%1774450067.231",
        "snappy/1.1.10#968fef506ff261592ec30c574d4a7809%1765850147.878",
        "secp256k1/0.7.1#481881709eb0bdd0185a12b912bbe8ad%1770910500.329",
        "rocksdb/10.5.1#4a197eca381a3e5ae8adf8cffa5aacd0%1765850186.86",
        "re2/20251105#8579cfd0bda4daf0683f9e3898f964b4%1774398111.888",
-        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1773224203.27",
+        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1774467363.12",
        "openssl/3.6.1#e6399de266349245a4542fc5f6c71552%1774458290.139",
-        "nudb/2.0.9#0432758a24204da08fee953ec9ea03cb%1769436073.32",
+        "nudb/2.0.9#11149c73f8f2baff9a0198fe25971fc7%1774883011.384",
        "lz4/1.10.0#59fc63cac7f10fbe8e05c7e62c2f3504%1765850143.914",
        "libiconv/1.17#1e65319e945f2d31941a9d28cc13c058%1765842973.492",
        "libbacktrace/cci.20210118#a7691bfccd8caaf66309df196790a5a1%1765842973.03",
        "libarchive/3.8.1#ffee18995c706e02bf96e7a2f7042e0d%1765850144.736",
        "jemalloc/5.3.0#e951da9cf599e956cebc117880d2d9f8%1729241615.244",
        "gtest/1.17.0#5224b3b3ff3b4ce1133cbdd27d53ee7d%1768312129.152",
-        "grpc/1.78.1#b1a9e74b145cc471bed4dc64dc6eb2c1%1772623605.068",
+        "grpc/1.78.1#b1a9e74b145cc471bed4dc64dc6eb2c1%1774467387.342",
        "ed25519/2015.03#ae761bdc52730a843f0809bdf6c1b1f6%1765850143.772",
        "date/3.0.4#862e11e80030356b53c2c38599ceb32b%1765850143.772",
        "c-ares/1.34.6#545240bb1c40e2cacd4362d6b8967650%1774439234.681",
@@ -29,7 +29,7 @@
    "build_requires": [
        "zlib/1.3.1#cac0f6daea041b0ccf42934163defb20%1774439233.809",
        "strawberryperl/5.32.1.1#8d114504d172cfea8ea1662d09b6333e%1774447376.964",
-        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1773224203.27",
+        "protobuf/6.33.5#d96d52ba5baaaa532f47bda866ad87a5%1774467363.12",
        "nasm/2.16.01#31e26f2ee3c4346ecd347911bd126904%1765850144.707",
        "msys2/cci.latest#d22fe7b2808f5fd34d0a7923ace9c54f%1770657326.649",
        "m4/1.4.19#5d7a4994e5875d76faf7acf3ed056036%1774365463.87",
@@ -41,16 +41,15 @@
    ],
    "python_requires": [],
    "overrides": {
-        "boost/1.90.0#d5e8defe7355494953be18524a7f135b": [
-            null,
-            "boost/1.90.0"
-        ],
        "protobuf/[>=5.27.0 <7]": [
            "protobuf/6.33.5"
        ],
        "lz4/1.9.4": [
            "lz4/1.10.0"
        ],
+        "boost/[>=1.83.0 <1.91.0]": [
+            "boost/1.90.0"
+        ],
        "sqlite3/[>=3.44 <4]": [
            "sqlite3/3.51.0"
        ],
--- a/include/xrpl/basics/BasicConfig.h
+++ b/include/xrpl/basics/BasicConfig.h
@@ -311,7 +311,7 @@ template <class T>
 bool
 set(T& target, T const& defaultValue, std::string const& name, Section const& section)
 {
-    bool found_and_valid = set<T>(target, name, section);
+    bool const found_and_valid = set<T>(target, name, section);
    if (!found_and_valid)
        target = defaultValue;
    return found_and_valid;
--- a/include/xrpl/basics/CountedObject.h
+++ b/include/xrpl/basics/CountedObject.h
@@ -34,7 +34,7 @@ public:
        {
            // Insert ourselves at the front of the lock-free linked list
            CountedObjects& instance = CountedObjects::getInstance();
-            Counter* head;
+            Counter* head = nullptr;

            do
            {
--- a/include/xrpl/basics/DecayingSample.h
+++ b/include/xrpl/basics/DecayingSample.h
@@ -93,7 +93,7 @@ class DecayWindow
 public:
    using time_point = typename Clock::time_point;

-    explicit DecayWindow(time_point now) : value_(0), when_(now)
+    explicit DecayWindow(time_point now) : when_(now)
    {
    }

@@ -125,7 +125,7 @@ private:
        when_ = now;
    }

-    double value_;
+    double value_{0};
    time_point when_;
 };

--- a/include/xrpl/basics/IntrusivePointer.h
+++ b/include/xrpl/basics/IntrusivePointer.h
@@ -84,7 +84,8 @@ public:

    template <class TT>
        requires std::convertible_to<TT*, T*>
-    SharedIntrusive(SharedIntrusive<TT>&& rhs);
+    SharedIntrusive(
+        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)

    SharedIntrusive&
    operator=(SharedIntrusive const& rhs);
@@ -106,7 +107,8 @@ public:
    template <class TT>
        requires std::convertible_to<TT*, T*>
    SharedIntrusive&
-    operator=(SharedIntrusive<TT>&& rhs);
+    operator=(
+        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)

    /** Adopt the raw pointer. The strong reference may or may not be
        incremented, depending on the TAdoptTag
@@ -314,7 +316,8 @@ public:

    template <class TT>
        requires std::convertible_to<TT*, T*>
-    SharedWeakUnion(SharedIntrusive<TT>&& rhs);
+    SharedWeakUnion(
+        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)

    SharedWeakUnion&
    operator=(SharedWeakUnion const& rhs);
@@ -327,7 +330,8 @@ public:
    template <class TT>
        requires std::convertible_to<TT*, T*>
    SharedWeakUnion&
-    operator=(SharedIntrusive<TT>&& rhs);
+    operator=(
+        SharedIntrusive<TT>&& rhs);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)

    ~SharedWeakUnion();

--- a/include/xrpl/basics/IntrusivePointer.ipp
+++ b/include/xrpl/basics/IntrusivePointer.ipp
@@ -68,9 +68,7 @@ SharedIntrusive<T>::operator=(SharedIntrusive const& rhs)

 template <class T>
 template <class TT>
-// clang-format off
-requires std::convertible_to<TT*, T*>
-// clang-format on
+    requires std::convertible_to<TT*, T*>
 SharedIntrusive<T>&
 SharedIntrusive<T>::operator=(SharedIntrusive<TT> const& rhs)
 {
@@ -101,9 +99,7 @@ SharedIntrusive<T>::operator=(SharedIntrusive&& rhs)

 template <class T>
 template <class TT>
-// clang-format off
-requires std::convertible_to<TT*, T*>
-// clang-format on
+    requires std::convertible_to<TT*, T*>
 SharedIntrusive<T>&
 SharedIntrusive<T>::operator=(SharedIntrusive<TT>&& rhs)
 {
@@ -307,9 +303,7 @@ WeakIntrusive<T>::WeakIntrusive(SharedIntrusive<T> const& rhs) : ptr_{rhs.unsafe

 template <class T>
 template <class TT>
-// clang-format off
-requires std::convertible_to<TT*, T*>
-// clang-format on
+    requires std::convertible_to<TT*, T*>
 WeakIntrusive<T>&
 WeakIntrusive<T>::operator=(SharedIntrusive<TT> const& rhs)
 {
@@ -454,9 +448,7 @@ SharedWeakUnion<T>::operator=(SharedWeakUnion const& rhs)

 template <class T>
 template <class TT>
-// clang-format off
-requires std::convertible_to<TT*, T*>
-// clang-format on
+    requires std::convertible_to<TT*, T*>
 SharedWeakUnion<T>&
 SharedWeakUnion<T>::operator=(SharedIntrusive<TT> const& rhs)
 {
@@ -470,9 +462,7 @@ SharedWeakUnion<T>::operator=(SharedIntrusive<TT> const& rhs)

 template <class T>
 template <class TT>
-// clang-format off
-requires std::convertible_to<TT*, T*>
-// clang-format on
+    requires std::convertible_to<TT*, T*>
 SharedWeakUnion<T>&
 SharedWeakUnion<T>::operator=(SharedIntrusive<TT>&& rhs)
 {
--- a/include/xrpl/basics/IntrusiveRefCounts.h
+++ b/include/xrpl/basics/IntrusiveRefCounts.h
@@ -448,7 +448,7 @@ inline void
 partialDestructorFinished(T** o)
 {
    T& self = **o;
-    IntrusiveRefCounts::RefCountPair p =
+    IntrusiveRefCounts::RefCountPair const p =
        self.refCounts.fetch_or(IntrusiveRefCounts::partialDestroyFinishedMask);
    XRPL_ASSERT(
        (!p.partialDestroyFinishedBit && p.partialDestroyStartedBit && !p.strong),
--- a/include/xrpl/basics/Number.h
+++ b/include/xrpl/basics/Number.h
@@ -73,12 +73,12 @@ struct MantissaRange
    enum mantissa_scale { small, large };

    explicit constexpr MantissaRange(mantissa_scale scale_)
-        : min(getMin(scale_)), max(min * 10 - 1), log(logTen(min).value_or(-1)), scale(scale_)
+        : min(getMin(scale_)), log(logTen(min).value_or(-1)), scale(scale_)
    {
    }

    rep min;
-    rep max;
+    rep max{min * 10 - 1};
    int log;
    mantissa_scale scale;

--- a/include/xrpl/basics/SlabAllocator.h
+++ b/include/xrpl/basics/SlabAllocator.h
@@ -91,10 +91,10 @@ class SlabAllocator
        std::uint8_t*
        allocate() noexcept
        {
-            std::uint8_t* ret;
+            std::uint8_t* ret = nullptr;  // NOLINT(misc-const-correctness)

            {
-                std::lock_guard l(m_);
+                std::lock_guard const l(m_);

                ret = l_;

@@ -123,7 +123,7 @@ class SlabAllocator
        {
            XRPL_ASSERT(own(ptr), "xrpl::SlabAllocator::SlabBlock::deallocate : own input");

-            std::lock_guard l(m_);
+            std::lock_guard const l(m_);

            // Use memcpy to avoid unaligned UB
            // (will optimize to equivalent code)
@@ -210,16 +210,13 @@ public:

        // No slab can satisfy our request, so we attempt to allocate a new
        // one here:
-        std::size_t size = slabSize_;
+        std::size_t const size = slabSize_;

        // We want to allocate the memory at a 2 MiB boundary, to make it
        // possible to use hugepage mappings on Linux:
        auto buf = boost::alignment::aligned_alloc(megabytes(std::size_t(2)), size);
-
-        // clang-format off
        if (!buf) [[unlikely]]
            return nullptr;
-        // clang-format on

 #if BOOST_OS_LINUX
        // When allocating large blocks, attempt to leverage Linux's
--- a/include/xrpl/basics/StringUtilities.h
+++ b/include/xrpl/basics/StringUtilities.h
@@ -66,12 +66,12 @@ strUnHex(std::size_t strSize, Iterator begin, Iterator end)

    while (iter != end)
    {
-        int cHigh = digitLookupTable[*iter++];
+        int const cHigh = digitLookupTable[*iter++];

        if (cHigh < 0)
            return {};

-        int cLow = digitLookupTable[*iter++];
+        int const cLow = digitLookupTable[*iter++];

        if (cLow < 0)
            return {};
--- a/include/xrpl/basics/TaggedCache.h
+++ b/include/xrpl/basics/TaggedCache.h
@@ -182,8 +182,7 @@ private:
            : hook(collector->make_hook(handler))
            , size(collector->make_gauge(prefix, "size"))
            , hit_rate(collector->make_gauge(prefix, "hit_rate"))
-            , hits(0)
-            , misses(0)
+
        {
        }

@@ -191,8 +190,8 @@ private:
        beast::insight::Gauge size;
        beast::insight::Gauge hit_rate;

-        std::size_t hits;
-        std::size_t misses;
+        std::size_t hits{0};
+        std::size_t misses{0};
    };

    class KeyOnlyEntry
@@ -294,10 +293,10 @@ private:
    clock_type::duration const m_target_age;

    // Number of items cached
-    int m_cache_count;
+    int m_cache_count{0};
    cache_type m_cache;  // Hold strong reference to recent objects
-    std::uint64_t m_hits;
-    std::uint64_t m_misses;
+    std::uint64_t m_hits{0};
+    std::uint64_t m_misses{0};
 };

 }  // namespace xrpl
--- a/include/xrpl/basics/TaggedCache.ipp
+++ b/include/xrpl/basics/TaggedCache.ipp
@@ -36,9 +36,7 @@ inline TaggedCache<
    , m_name(name)
    , m_target_size(size)
    , m_target_age(expiration)
-    , m_cache_count(0)
-    , m_hits(0)
-    , m_misses(0)
+
 {
 }

--- a/include/xrpl/basics/base_uint.h
+++ b/include/xrpl/basics/base_uint.h
@@ -212,7 +212,7 @@ private:
        while (in != sv.end())
        {
            std::uint32_t accum = {};
-            for (std::uint32_t shift : {4u, 0u, 12u, 8u, 20u, 16u, 28u, 24u})
+            for (std::uint32_t const shift : {4u, 0u, 12u, 8u, 20u, 16u, 28u, 24u})
            {
                if (auto const result = hexCharToUInt(*in++, shift, accum);
                    result != ParseResult::okay)
@@ -335,11 +335,13 @@ public:
    operator=(std::uint64_t uHost)
    {
        *this = beast::zero;
+        // NOLINTBEGIN(cppcoreguidelines-pro-type-member-init)
        union
        {
            unsigned u[2];
            std::uint64_t ul;
        };
+        // NOLINTEND(cppcoreguidelines-pro-type-member-init)
        // Put in least significant bits.
        ul = boost::endian::native_to_big(uHost);
        data_[WIDTH - 2] = u[0];
@@ -444,7 +446,7 @@ public:

        for (int i = WIDTH; i--;)
        {
-            std::uint64_t n = carry + boost::endian::big_to_native(data_[i]) +
+            std::uint64_t const n = carry + boost::endian::big_to_native(data_[i]) +
                boost::endian::big_to_native(b.data_[i]);

            data_[i] = boost::endian::native_to_big(static_cast<std::uint32_t>(n));
@@ -621,7 +623,7 @@ template <>
 inline std::size_t
 extract(uint256 const& key)
 {
-    std::size_t result;
+    std::size_t result = 0;
    // Use memcpy to avoid unaligned UB
    // (will optimize to equivalent code)
    std::memcpy(&result, key.data(), sizeof(std::size_t));
--- a/include/xrpl/basics/contract.h
+++ b/include/xrpl/basics/contract.h
@@ -54,7 +54,7 @@ Throw(Args&&... args)

    E e(std::forward<Args>(args)...);
    LogThrow(std::string("Throwing exception of type " + beast::type_name<E>() + ": ") + e.what());
-    throw e;
+    throw std::move(e);
 }

 /** Called when faulty logic causes a broken invariant. */
--- a/include/xrpl/basics/hardened_hash.h
+++ b/include/xrpl/basics/hardened_hash.h
@@ -32,7 +32,7 @@ make_seed_pair() noexcept
        // state_t& operator=(state_t const&) = delete;
    };
    static state_t state;
-    std::lock_guard lock(state.mutex);
+    std::lock_guard const lock(state.mutex);
    return {state.dist(state.gen), state.dist(state.gen)};
 }

--- a/include/xrpl/basics/random.h
+++ b/include/xrpl/basics/random.h
@@ -14,11 +14,13 @@ namespace xrpl {

 #ifndef __INTELLISENSE__
 static_assert(
+    // NOLINTNEXTLINE(misc-redundant-expression)
    std::is_integral<beast::xor_shift_engine::result_type>::value &&
        std::is_unsigned<beast::xor_shift_engine::result_type>::value,
    "The Ripple default PRNG engine must return an unsigned integral type.");

 static_assert(
+    // NOLINTNEXTLINE(misc-redundant-expression)
    std::numeric_limits<beast::xor_shift_engine::result_type>::max() >=
        std::numeric_limits<std::uint64_t>::max(),
    "The Ripple default PRNG engine return must be at least 64 bits wide.");
@@ -56,9 +58,9 @@ default_prng()

    // The thread-specific PRNGs:
    thread_local beast::xor_shift_engine engine = [] {
-        std::uint64_t seed;
+        std::uint64_t seed = 0;
        {
-            std::lock_guard lk(m);
+            std::lock_guard const lk(m);
            std::uniform_int_distribution<std::uint64_t> distribution{1};
            seed = distribution(seeder);
        }
--- a/include/xrpl/beast/asio/io_latency_probe.h
+++ b/include/xrpl/beast/asio/io_latency_probe.h
@@ -23,15 +23,15 @@ private:

    std::recursive_mutex m_mutex;
    std::condition_variable_any m_cond;
-    std::size_t m_count;
+    std::size_t m_count{1};
    duration const m_period;
    boost::asio::io_context& m_ios;
    boost::asio::basic_waitable_timer<std::chrono::steady_clock> m_timer;
-    bool m_cancel;
+    bool m_cancel{false};

 public:
    io_latency_probe(duration const& period, boost::asio::io_context& ios)
-        : m_count(1), m_period(period), m_ios(ios), m_timer(m_ios), m_cancel(false)
+        : m_period(period), m_ios(ios), m_timer(m_ios)
    {
    }

@@ -83,7 +83,7 @@ public:
    void
    sample_one(Handler&& handler)
    {
-        std::lock_guard lock(m_mutex);
+        std::lock_guard const lock(m_mutex);
        if (m_cancel)
            throw std::logic_error("io_latency_probe is canceled");
        boost::asio::post(
@@ -98,7 +98,7 @@ public:
    void
    sample(Handler&& handler)
    {
-        std::lock_guard lock(m_mutex);
+        std::lock_guard const lock(m_mutex);
        if (m_cancel)
            throw std::logic_error("io_latency_probe is canceled");
        boost::asio::post(
@@ -122,14 +122,14 @@ private:
    void
    addref()
    {
-        std::lock_guard lock(m_mutex);
+        std::lock_guard const lock(m_mutex);
        ++m_count;
    }

    void
    release()
    {
-        std::lock_guard lock(m_mutex);
+        std::lock_guard const lock(m_mutex);
        if (--m_count == 0)
            m_cond.notify_all();
    }
@@ -192,7 +192,7 @@ private:
            m_handler(elapsed);

            {
-                std::lock_guard lock(m_probe->m_mutex);
+                std::lock_guard const lock(m_probe->m_mutex);
                if (m_probe->m_cancel)
                    return;
            }
--- a/include/xrpl/beast/container/aged_map.h
+++ b/include/xrpl/beast/container/aged_map.h
@@ -16,4 +16,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_map = detail::aged_ordered_container<false, true, Key, T, Clock, Compare, Allocator>;

-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_multimap.h
+++ b/include/xrpl/beast/container/aged_multimap.h
@@ -16,4 +16,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_multimap = detail::aged_ordered_container<true, true, Key, T, Clock, Compare, Allocator>;

-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_multiset.h
+++ b/include/xrpl/beast/container/aged_multiset.h
@@ -15,4 +15,4 @@ template <
    class Allocator = std::allocator<Key>>
 using aged_multiset =
    detail::aged_ordered_container<true, false, Key, void, Clock, Compare, Allocator>;
-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_set.h
+++ b/include/xrpl/beast/container/aged_set.h
@@ -15,4 +15,4 @@ template <
    class Allocator = std::allocator<Key>>
 using aged_set = detail::aged_ordered_container<false, false, Key, void, Clock, Compare, Allocator>;

-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_unordered_map.h
+++ b/include/xrpl/beast/container/aged_unordered_map.h
@@ -17,4 +17,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_unordered_map =
    detail::aged_unordered_container<false, true, Key, T, Clock, Hash, KeyEqual, Allocator>;
-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_unordered_multimap.h
+++ b/include/xrpl/beast/container/aged_unordered_multimap.h
@@ -17,4 +17,4 @@ template <
    class Allocator = std::allocator<std::pair<Key const, T>>>
 using aged_unordered_multimap =
    detail::aged_unordered_container<true, true, Key, T, Clock, Hash, KeyEqual, Allocator>;
-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_unordered_multiset.h
+++ b/include/xrpl/beast/container/aged_unordered_multiset.h
@@ -17,4 +17,4 @@ template <
 using aged_unordered_multiset =
    detail::aged_unordered_container<true, false, Key, void, Clock, Hash, KeyEqual, Allocator>;

-}
+}  // namespace beast
--- a/include/xrpl/beast/container/aged_unordered_set.h
+++ b/include/xrpl/beast/container/aged_unordered_set.h
@@ -16,4 +16,4 @@ template <
    class Allocator = std::allocator<Key>>
 using aged_unordered_set =
    detail::aged_unordered_container<false, false, Key, void, Clock, Hash, KeyEqual, Allocator>;
-}
+}  // namespace beast
--- a/include/xrpl/beast/container/detail/aged_ordered_container.h
+++ b/include/xrpl/beast/container/detail/aged_ordered_container.h
@@ -262,7 +262,9 @@ private:
        {
        }

-        config_t(config_t&& other, Allocator const& alloc)
+        config_t(
+            config_t&& other,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+            Allocator const& alloc)
            : KeyValueCompare(std::move(other.key_compare()))
            , beast::detail::empty_base_optimization<ElementAllocator>(alloc)
            , clock(other.clock)
@@ -552,7 +554,10 @@ public:

    aged_ordered_container(aged_ordered_container&& other);

-    aged_ordered_container(aged_ordered_container&& other, Allocator const& alloc);
+    aged_ordered_container(
+        // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
+        aged_ordered_container&& other,
+        Allocator const& alloc);

    aged_ordered_container(std::initializer_list<value_type> init, clock_type& clock);

@@ -1290,7 +1295,7 @@ aged_ordered_container<IsMulti, IsMap, Key, T, Clock, Compare, Allocator>::aged_

 template <bool IsMulti, bool IsMap, class Key, class T, class Clock, class Compare, class Allocator>
 aged_ordered_container<IsMulti, IsMap, Key, T, Clock, Compare, Allocator>::aged_ordered_container(
-    aged_ordered_container&& other,
+    aged_ordered_container&& other,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
    Allocator const& alloc)
    : m_config(std::move(other.m_config), alloc)
 #if BOOST_VERSION >= 108000
--- a/include/xrpl/beast/container/detail/aged_unordered_container.h
+++ b/include/xrpl/beast/container/detail/aged_unordered_container.h
@@ -318,7 +318,9 @@ private:
        {
        }

-        config_t(config_t&& other, Allocator const& alloc)
+        config_t(
+            config_t&& other,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+            Allocator const& alloc)
            : ValueHash(std::move(other.hash_function()))
            , KeyValueEqual(std::move(other.key_eq()))
            , beast::detail::empty_base_optimization<ElementAllocator>(alloc)
@@ -774,7 +776,10 @@ public:

    aged_unordered_container(aged_unordered_container&& other);

-    aged_unordered_container(aged_unordered_container&& other, Allocator const& alloc);
+    aged_unordered_container(
+        // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
+        aged_unordered_container&& other,
+        Allocator const& alloc);

    aged_unordered_container(std::initializer_list<value_type> init, clock_type& clock);

@@ -1838,7 +1843,10 @@ template <
    class KeyEqual,
    class Allocator>
 aged_unordered_container<IsMulti, IsMap, Key, T, Clock, Hash, KeyEqual, Allocator>::
-    aged_unordered_container(aged_unordered_container&& other, Allocator const& alloc)
+    aged_unordered_container(
+        // NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
+        aged_unordered_container&& other,
+        Allocator const& alloc)
    : m_config(std::move(other.m_config), alloc)
    , m_buck(alloc)
    , m_cont(m_buck, std::cref(m_config.value_hash()), std::cref(m_config.key_value_equal()))
--- a/include/xrpl/beast/core/List.h
+++ b/include/xrpl/beast/core/List.h
@@ -449,7 +449,7 @@ public:
    iterator
    erase(iterator pos) noexcept
    {
-        Node* node = &*pos;
+        Node const* node = &*pos;
        ++pos;
        node->m_next->m_prev = node->m_prev;
        node->m_prev->m_next = node->m_next;
--- a/include/xrpl/beast/core/LockFreeStack.h
+++ b/include/xrpl/beast/core/LockFreeStack.h
@@ -187,7 +187,7 @@ public:
    bool
    push_front(Node* node)
    {
-        bool first;
+        bool first = false;
        Node* old_head = m_head.load(std::memory_order_relaxed);
        do
        {
@@ -211,7 +211,7 @@ public:
    pop_front()
    {
        Node* node = m_head.load();
-        Node* new_head;
+        Node* new_head = nullptr;
        do
        {
            if (node == &m_end)
--- a/include/xrpl/beast/hash/xxhasher.h
+++ b/include/xrpl/beast/hash/xxhasher.h
@@ -23,7 +23,7 @@ private:
    // A 64-byte buffer should to be big enough for us
    static constexpr std::size_t INTERNAL_BUFFER_SIZE = 64;

-    alignas(64) std::array<std::uint8_t, INTERNAL_BUFFER_SIZE> buffer_;
+    alignas(64) std::array<std::uint8_t, INTERNAL_BUFFER_SIZE> buffer_{};
    std::span<std::uint8_t> readBuffer_;
    std::span<std::uint8_t> writeBuffer_;

--- a/include/xrpl/beast/test/yield_to.h
+++ b/include/xrpl/beast/test/yield_to.h
@@ -114,7 +114,7 @@ enable_yield_to::spawn(F0&& f, FN&&... fn)
        boost::context::fixedsize_stack(2 * 1024 * 1024),
        [&](yield_context yield) {
            f(yield);
-            std::lock_guard lock{m_};
+            std::lock_guard const lock{m_};
            if (--running_ == 0)
                cv_.notify_all();
        },
--- a/include/xrpl/beast/unit_test/results.h
+++ b/include/xrpl/beast/unit_test/results.h
@@ -35,10 +35,10 @@ private:
    class tests_t : public detail::const_container<std::vector<test>>
    {
    private:
-        std::size_t failed_;
+        std::size_t failed_{0};

    public:
-        tests_t() : failed_(0)
+        tests_t()
        {
        }

@@ -167,12 +167,12 @@ public:
 class results : public detail::const_container<std::vector<suite_results>>
 {
 private:
-    std::size_t m_cases;
-    std::size_t total_;
-    std::size_t failed_;
+    std::size_t m_cases{0};
+    std::size_t total_{0};
+    std::size_t failed_{0};

 public:
-    results() : m_cases(0), total_(0), failed_(0)
+    results()
    {
    }

--- a/include/xrpl/beast/unit_test/runner.h
+++ b/include/xrpl/beast/unit_test/runner.h
@@ -228,7 +228,7 @@ template <class>
 void
 runner::testcase(std::string const& name)
 {
-    std::lock_guard lock(mutex_);
+    std::lock_guard const lock(mutex_);
    // Name may not be empty
    BOOST_ASSERT(default_ || !name.empty());
    // Forgot to call pass or fail
@@ -244,7 +244,7 @@ template <class>
 void
 runner::pass()
 {
-    std::lock_guard lock(mutex_);
+    std::lock_guard const lock(mutex_);
    if (default_)
        testcase("");
    on_pass();
@@ -255,7 +255,7 @@ template <class>
 void
 runner::fail(std::string const& reason)
 {
-    std::lock_guard lock(mutex_);
+    std::lock_guard const lock(mutex_);
    if (default_)
        testcase("");
    on_fail(reason);
@@ -267,7 +267,7 @@ template <class>
 void
 runner::log(std::string const& s)
 {
-    std::lock_guard lock(mutex_);
+    std::lock_guard const lock(mutex_);
    if (default_)
        testcase("");
    on_log(s);
--- a/include/xrpl/beast/unit_test/suite.h
+++ b/include/xrpl/beast/unit_test/suite.h
@@ -300,7 +300,7 @@ private:
    static suite**
    p_this_suite()
    {
-        static suite* pts = nullptr;
+        static suite* pts = nullptr;  // NOLINT(misc-const-correctness)
        return &pts;
    }

--- a/include/xrpl/beast/utility/PropertyStream.h
+++ b/include/xrpl/beast/utility/PropertyStream.h
@@ -311,7 +311,7 @@ private:
    std::string const m_name;
    std::recursive_mutex lock_;
    Item item_;
-    Source* parent_;
+    Source* parent_{nullptr};
    List<Item> children_;

 public:
--- a/include/xrpl/beast/utility/Zero.h
+++ b/include/xrpl/beast/utility/Zero.h
@@ -28,7 +28,7 @@ struct Zero

 namespace {
 static constexpr Zero zero{};
-}
+}  // namespace

 /** Default implementation of signum calls the method on the class. */
 template <typename T>
--- a/include/xrpl/beast/xor_shift_engine.h
+++ b/include/xrpl/beast/xor_shift_engine.h
@@ -37,7 +37,7 @@ public:
    }

 private:
-    result_type s_[2];
+    result_type s_[2]{};

    static result_type
    murmurhash3(result_type x);
--- a/include/xrpl/core/ClosureCounter.h
+++ b/include/xrpl/core/ClosureCounter.h
@@ -56,7 +56,7 @@ private:
        // a lock.  This removes a small timing window that occurs if the
        // waiting thread is handling a spurious wakeup when closureCount_
        // drops to zero.
-        std::lock_guard lock{mutex_};
+        std::lock_guard const lock{mutex_};

        // Update closureCount_.  Notify if stopping and closureCount_ == 0.
        if ((--closureCount_ == 0) && waitForClosures_)
@@ -92,7 +92,9 @@ private:
            ++counter_;
        }

-        Substitute(ClosureCounter& counter, Closure&& closure)
+        Substitute(
+            ClosureCounter& counter,
+            Closure&& closure)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
            : counter_(counter), closure_(std::forward<Closure>(closure))
        {
            ++counter_;
@@ -168,7 +170,7 @@ public:
    {
        std::optional<Substitute<Closure>> ret;

-        std::lock_guard lock{mutex_};
+        std::lock_guard const lock{mutex_};
        if (!waitForClosures_)
            ret.emplace(*this, std::forward<Closure>(closure));

@@ -191,7 +193,7 @@ public:
    bool
    joined() const
    {
-        std::lock_guard lock{mutex_};
+        std::lock_guard const lock{mutex_};
        return waitForClosures_;
    }
 };
--- a/include/xrpl/core/Coro.ipp
+++ b/include/xrpl/core/Coro.ipp
@@ -7,7 +7,6 @@ JobQueue::Coro::Coro(Coro_create_t, JobQueue& jq, JobType type, std::string cons
    : jq_(jq)
    , type_(type)
    , name_(name)
-    , running_(false)
    , coro_(
          // Stack size of 1MB wasn't sufficient for deep calls. ASAN tests flagged the issue. Hence
          // increasing the size to 1.5MB.
@@ -70,14 +69,24 @@ JobQueue::Coro::resume()
        running_ = true;
    }
    {
-        std::lock_guard lock(jq_.m_mutex);
+        std::lock_guard lk(jq_.m_mutex);
        --jq_.nSuspend_;
    }
    auto saved = detail::getLocalValues().release();
    detail::getLocalValues().reset(&lvs_);
    std::lock_guard lock(mutex_);
-    XRPL_ASSERT(static_cast<bool>(coro_), "xrpl::JobQueue::Coro::resume : is runnable");
-    coro_();
+    // A late resume() can arrive after the coroutine has already completed.
+    // This is an expected (if rare) outcome of the race condition documented
+    // in JobQueue.h:354-377 where post() schedules a resume job before the
+    // coroutine yields — the mutex serializes access, but by the time this
+    // resume() acquires the lock the coroutine may have already run to
+    // completion. Calling operator() on a completed boost::coroutine2 is
+    // undefined behavior, so we must check and skip invoking the coroutine
+    // body if it has already completed.
+    if (coro_)
+    {
+        coro_();
+    }
    detail::getLocalValues().release();
    detail::getLocalValues().reset(saved);
    std::lock_guard lk(mutex_run_);
--- a/include/xrpl/core/JobQueue.h
+++ b/include/xrpl/core/JobQueue.h
@@ -16,7 +16,7 @@ namespace xrpl {

 namespace perf {
 class PerfLog;
-}
+}  // namespace perf

 class Logs;
 struct Coro_create_t
@@ -45,7 +45,7 @@ public:
        JobQueue& jq_;
        JobType type_;
        std::string name_;
-        bool running_;
+        bool running_{false};
        std::mutex mutex_;
        std::mutex mutex_run_;
        std::condition_variable cv_;
@@ -99,8 +99,8 @@ public:
            Effects:
               The coroutine continues execution from where it last left off
                 using this same thread.
-            Undefined behavior if called after the coroutine has completed
-              with a return (as opposed to a yield()).
+               If the coroutine has already completed, returns immediately
+                 (handles the documented post-before-yield race condition).
            Undefined behavior if resume() or post() called consecutively
              without a corresponding yield.
        */
@@ -224,7 +224,7 @@ private:

    beast::Journal m_journal;
    mutable std::mutex m_mutex;
-    std::uint64_t m_lastJob;
+    std::uint64_t m_lastJob{0};
    std::set<Job> m_jobSet;
    JobCounter jobCounter_;
    std::atomic_bool stopping_{false};
@@ -233,7 +233,7 @@ private:
    JobTypeData m_invalidJobData;

    // The number of jobs currently in processTask()
-    int m_processCount;
+    int m_processCount{0};

    // The number of suspended coroutines
    int nSuspend_ = 0;
@@ -357,8 +357,10 @@ private:
    If the post() job were to be executed before yield(), undefined behavior
    would occur. The lock ensures that coro_ is not called again until we exit
    the coroutine. At which point a scheduled resume() job waiting on the lock
-    would gain entry, harmlessly call coro_ and immediately return as we have
-    already completed the coroutine.
+    would gain entry. resume() checks if the coroutine has already completed
+    (coro_ converts to false) and, if so, skips invoking operator() since
+    calling operator() on a completed boost::coroutine2 pull_type is undefined
+    behavior.

    The race condition occurs as follows:

--- a/include/xrpl/core/JobTypeData.h
+++ b/include/xrpl/core/JobTypeData.h
@@ -19,13 +19,13 @@ public:
    JobTypeInfo const& info;

    /* The number of jobs waiting */
-    int waiting;
+    int waiting{0};

    /* The number presently running */
-    int running;
+    int running{0};

    /* And the number we deferred executing because of job limits */
-    int deferred;
+    int deferred{0};

    /* Notification callbacks */
    beast::insight::Event dequeue;
@@ -35,12 +35,8 @@ public:
        JobTypeInfo const& info_,
        beast::insight::Collector::ptr const& collector,
        Logs& logs) noexcept
-        : m_load(logs.journal("LoadMonitor"))
-        , m_collector(collector)
-        , info(info_)
-        , waiting(0)
-        , running(0)
-        , deferred(0)
+        : m_load(logs.journal("LoadMonitor")), m_collector(collector), info(info_)
+
    {
        m_load.setTargetLatency(info.getAverageLatency(), info.getPeakLatency());

--- a/include/xrpl/core/JobTypes.h
+++ b/include/xrpl/core/JobTypes.h
@@ -24,7 +24,7 @@ private:
              std::chrono::milliseconds{0})
    {
        using namespace std::chrono_literals;
-        int maxLimit = std::numeric_limits<int>::max();
+        int const maxLimit = std::numeric_limits<int>::max();

        auto add = [this](
                       JobType jt,
--- a/include/xrpl/core/LoadMonitor.h
+++ b/include/xrpl/core/LoadMonitor.h
@@ -36,10 +36,10 @@ public:
    {
        Stats();

-        std::uint64_t count;
+        std::uint64_t count{0};
        std::chrono::milliseconds latencyAvg;
        std::chrono::milliseconds latencyPeak;
-        bool isOverloaded;
+        bool isOverloaded{false};
    };

    Stats
@@ -54,8 +54,8 @@ private:

    std::mutex mutex_;

-    std::uint64_t mCounts;
-    int mLatencyEvents;
+    std::uint64_t mCounts{0};
+    int mLatencyEvents{0};
    std::chrono::milliseconds mLatencyMSAvg;
    std::chrono::milliseconds mLatencyMSPeak;
    std::chrono::milliseconds mTargetLatencyAvg;
--- a/include/xrpl/core/PeerReservationTable.h
+++ b/include/xrpl/core/PeerReservationTable.h
@@ -67,7 +67,7 @@ public:
    bool
    contains(PublicKey const& nodeId)
    {
-        std::lock_guard lock(this->mutex_);
+        std::lock_guard const lock(this->mutex_);
        return table_.find({nodeId}) != table_.end();
    }

@@ -92,7 +92,7 @@ public:
 private:
    beast::Journal mutable journal_;
    std::mutex mutable mutex_;
-    DatabaseCon* connection_;
+    DatabaseCon* connection_{};
    std::unordered_set<PeerReservation, beast::uhash<>, KeyEqual> table_;
 };

--- a/include/xrpl/core/PerfLog.h
+++ b/include/xrpl/core/PerfLog.h
@@ -14,7 +14,7 @@

 namespace beast {
 class Journal;
-}
+}  // namespace beast

 namespace xrpl {
 class Application;
--- a/include/xrpl/core/ServiceRegistry.h
+++ b/include/xrpl/core/ServiceRegistry.h
@@ -3,7 +3,6 @@
 #include <xrpl/basics/Blob.h>
 #include <xrpl/basics/SHAMapHash.h>
 #include <xrpl/basics/TaggedCache.h>
-#include <xrpl/ledger/CachedSLEs.h>

 #include <boost/asio.hpp>

@@ -12,17 +11,31 @@ namespace xrpl {
 // Forward declarations
 namespace NodeStore {
 class Database;
-}
+}  // namespace NodeStore
 namespace Resource {
 class Manager;
-}
+}  // namespace Resource
 namespace perf {
 class PerfLog;
-}
+}  // namespace perf

 // This is temporary until we migrate all code to use ServiceRegistry.
 class Application;

+template <
+    class Key,
+    class T,
+    bool IsKeyCache,
+    class SharedWeakUnionPointer,
+    class SharedPointerType,
+    class Hash,
+    class KeyEqual,
+    class Mutex>
+class TaggedCache;
+class STLedgerEntry;
+using SLE = STLedgerEntry;
+using CachedSLEs = TaggedCache<uint256, SLE const>;
+
 // Forward declarations
 class AcceptedLedger;
 class AmendmentTable;
@@ -89,7 +102,7 @@ public:
    getNodeFamily() = 0;

    virtual TimeKeeper&
-    timeKeeper() = 0;
+    getTimeKeeper() = 0;

    virtual JobQueue&
    getJobQueue() = 0;
@@ -98,7 +111,7 @@ public:
    getTempNodeCache() = 0;

    virtual CachedSLEs&
-    cachedSLEs() = 0;
+    getCachedSLEs() = 0;

    virtual NetworkIDService&
    getNetworkIDService() = 0;
@@ -120,26 +133,26 @@ public:
    getValidations() = 0;

    virtual ValidatorList&
-    validators() = 0;
+    getValidators() = 0;

    virtual ValidatorSite&
-    validatorSites() = 0;
+    getValidatorSites() = 0;

    virtual ManifestCache&
-    validatorManifests() = 0;
+    getValidatorManifests() = 0;

    virtual ManifestCache&
-    publisherManifests() = 0;
+    getPublisherManifests() = 0;

    // Network services
    virtual Overlay&
-    overlay() = 0;
+    getOverlay() = 0;

    virtual Cluster&
-    cluster() = 0;
+    getCluster() = 0;

    virtual PeerReservationTable&
-    peerReservations() = 0;
+    getPeerReservations() = 0;

    virtual Resource::Manager&
    getResourceManager() = 0;
@@ -174,13 +187,13 @@ public:
    getLedgerReplayer() = 0;

    virtual PendingSaves&
-    pendingSaves() = 0;
+    getPendingSaves() = 0;

    virtual OpenLedger&
-    openLedger() = 0;
+    getOpenLedger() = 0;

    virtual OpenLedger const&
-    openLedger() const = 0;
+    getOpenLedger() const = 0;

    // Transaction and operation services
    virtual NetworkOPs&
@@ -210,16 +223,16 @@ public:
    isStopping() const = 0;

    virtual beast::Journal
-    journal(std::string const& name) = 0;
+    getJournal(std::string const& name) = 0;

    virtual boost::asio::io_context&
    getIOContext() = 0;

    virtual Logs&
-    logs() = 0;
+    getLogs() = 0;

    virtual std::optional<uint256> const&
-    trapTxID() const = 0;
+    getTrapTxID() const = 0;

    /** Retrieve the "wallet database" */
    virtual DatabaseCon&
@@ -228,7 +241,7 @@ public:
    // Temporary: Get the underlying Application for functions that haven't
    // been migrated yet. This should be removed once all code is migrated.
    virtual Application&
-    app() = 0;
+    getApp() = 0;
 };

 }  // namespace xrpl
--- a/include/xrpl/core/StartUpType.h
+++ b/include/xrpl/core/StartUpType.h
@@ -5,7 +5,7 @@

 namespace xrpl {

-enum class StartUpType { FRESH, NORMAL, LOAD, LOAD_FILE, REPLAY, NETWORK };
+enum class StartUpType { Fresh, Normal, Load, LoadFile, Replay, Network };

 inline std::ostream&
 operator<<(std::ostream& os, StartUpType const& type)
--- a/include/xrpl/core/detail/Workers.h
+++ b/include/xrpl/core/detail/Workers.h
@@ -13,7 +13,7 @@ namespace xrpl {

 namespace perf {
 class PerfLog;
-}
+}  // namespace perf

 /**
 * `Workers` is effectively a thread pool. The constructor takes a "callback"
@@ -183,8 +183,8 @@ private:
        std::thread thread_;
        std::mutex mutex_;
        std::condition_variable wakeup_;
-        int wakeCount_;  // how many times to un-pause
-        bool shouldExit_;
+        int wakeCount_{0};  // how many times to un-pause
+        bool shouldExit_{false};
    };

 private:
@@ -197,9 +197,9 @@ private:
    std::string m_threadNames;     // The name to give each thread
    std::condition_variable m_cv;  // signaled when all threads paused
    std::mutex m_mut;
-    bool m_allPaused;
+    bool m_allPaused{true};
    semaphore m_semaphore;                             // each pending task is 1 resource
-    int m_numberOfThreads;                             // how many we want active now
+    int m_numberOfThreads{0};                          // how many we want active now
    std::atomic<int> m_activeCount;                    // to know when all are paused
    std::atomic<int> m_pauseCount;                     // how many threads need to pause now
    std::atomic<int> m_runningTaskCount;               // how many calls to processTask() active
--- a/include/xrpl/core/detail/semaphore.h
+++ b/include/xrpl/core/detail/semaphore.h
@@ -55,7 +55,7 @@ public:
    void
    notify()
    {
-        std::lock_guard lock{m_mutex};
+        std::lock_guard const lock{m_mutex};
        ++m_count;
        m_cond.notify_one();
    }
--- a/include/xrpl/json/json_reader.h
+++ b/include/xrpl/json/json_reader.h
@@ -103,9 +103,9 @@ private:
    public:
        explicit ErrorInfo() = default;

-        Token token_;
+        Token token_{};
        std::string message_;
-        Location extra_;
+        Location extra_{};
    };

    using Errors = std::deque<ErrorInfo>;
@@ -173,11 +173,11 @@ private:
    Nodes nodes_;
    Errors errors_;
    std::string document_;
-    Location begin_;
-    Location end_;
-    Location current_;
-    Location lastValueEnd_;
-    Value* lastValue_;
+    Location begin_{};
+    Location end_{};
+    Location current_{};
+    Location lastValueEnd_{};
+    Value* lastValue_{};
 };

 template <class BufferSequence>
--- a/include/xrpl/json/json_value.h
+++ b/include/xrpl/json/json_value.h
@@ -641,7 +641,7 @@ public:
    SelfType
    operator++(int)
    {
-        SelfType temp(*this);
+        SelfType const temp(*this);
        ++*this;
        return temp;
    }
@@ -649,7 +649,7 @@ public:
    SelfType
    operator--(int)
    {
-        SelfType temp(*this);
+        SelfType const temp(*this);
        --*this;
        return temp;
    }
--- a/include/xrpl/json/json_writer.h
+++ b/include/xrpl/json/json_writer.h
@@ -106,8 +106,8 @@ private:
    ChildValues childValues_;
    std::string document_;
    std::string indentString_;
-    int rightMargin_;
-    int indentSize_;
+    int rightMargin_{74};
+    int indentSize_{3};
    bool addChildValues_{};
 };

@@ -171,9 +171,9 @@ private:
    using ChildValues = std::vector<std::string>;

    ChildValues childValues_;
-    std::ostream* document_;
+    std::ostream* document_{nullptr};
    std::string indentString_;
-    int rightMargin_;
+    int rightMargin_{74};
    std::string indentation_;
    bool addChildValues_{};
 };
--- a/include/xrpl/ledger/AmendmentTable.h
+++ b/include/xrpl/ledger/AmendmentTable.h
@@ -143,7 +143,7 @@ public:
        // Inject appropriate pseudo-transactions
        for (auto const& it : actions)
        {
-            STTx amendTx(ttAMENDMENT, [&it, seq = lastClosedLedger->seq() + 1](auto& obj) {
+            STTx const amendTx(ttAMENDMENT, [&it, seq = lastClosedLedger->seq() + 1](auto& obj) {
                obj.setAccountID(sfAccount, AccountID());
                obj.setFieldH256(sfAmendment, it.first);
                obj.setFieldU32(sfLedgerSequence, seq);
--- a/include/xrpl/ledger/CachedSLEs.h
+++ b/include/xrpl/ledger/CachedSLEs.h
@@ -6,4 +6,4 @@

 namespace xrpl {
 using CachedSLEs = TaggedCache<uint256, SLE const>;
-}
+}  // namespace xrpl
--- a/include/xrpl/ledger/OrderBookDB.h
+++ b/include/xrpl/ledger/OrderBookDB.h
@@ -76,16 +76,33 @@ public:
        @return true if a book from this issue to XRP exists
    */
    virtual bool
-    isBookToXRP(Issue const& issue, std::optional<Domain> domain = std::nullopt) = 0;
+    isBookToXRP(Issue const& issue, std::optional<Domain> const& domain = std::nullopt) = 0;

+    /**
+     * Process a transaction for order book tracking.
+     * @param ledger The ledger the transaction was applied to
+     * @param alTx The transaction to process
+     * @param jvObj The JSON object of the transaction
+     */
    virtual void
    processTxn(
        std::shared_ptr<ReadView const> const& ledger,
        AcceptedLedgerTx const& alTx,
        MultiApiJson const& jvObj) = 0;

+    /**
+     * Get the book listeners for a book.
+     * @param book The book to get the listeners for
+     * @return The book listeners for the book
+     */
    virtual BookListeners::pointer
    getBookListeners(Book const&) = 0;
+
+    /**
+     * Create a new book listeners for a book.
+     * @param book The book to create the listeners for
+     * @return The new book listeners for the book
+     */
    virtual BookListeners::pointer
    makeBookListeners(Book const&) = 0;
 };
--- a/include/xrpl/ledger/PendingSaves.h
+++ b/include/xrpl/ledger/PendingSaves.h
@@ -31,7 +31,7 @@ public:
    bool
    startWork(LedgerIndex seq)
    {
-        std::lock_guard lock(mutex_);
+        std::lock_guard const lock(mutex_);

        auto it = map_.find(seq);

@@ -54,7 +54,7 @@ public:
    void
    finishWork(LedgerIndex seq)
    {
-        std::lock_guard lock(mutex_);
+        std::lock_guard const lock(mutex_);

        map_.erase(seq);
        await_.notify_all();
@@ -64,7 +64,7 @@ public:
    bool
    pending(LedgerIndex seq)
    {
-        std::lock_guard lock(mutex_);
+        std::lock_guard const lock(mutex_);
        return map_.find(seq) != map_.end();
    }

@@ -117,7 +117,7 @@ public:
    std::map<LedgerIndex, bool>
    getSnapshot() const
    {
-        std::lock_guard lock(mutex_);
+        std::lock_guard const lock(mutex_);

        return map_;
    }
--- a/include/xrpl/nodestore/Scheduler.h
+++ b/include/xrpl/nodestore/Scheduler.h
@@ -16,7 +16,7 @@ struct FetchReport
    {
    }

-    std::chrono::milliseconds elapsed;
+    std::chrono::milliseconds elapsed{};
    FetchType const fetchType;
    bool wasFound = false;
 };
--- a/include/xrpl/nodestore/detail/BatchWriter.h
+++ b/include/xrpl/nodestore/detail/BatchWriter.h
@@ -71,8 +71,8 @@ private:
    Scheduler& m_scheduler;
    LockType mWriteMutex;
    CondvarType mWriteCondition;
-    int mWriteLoad;
-    bool mWritePending;
+    int mWriteLoad{0};
+    bool mWritePending{false};
    Batch mWriteSet;
 };

--- a/include/xrpl/nodestore/detail/EncodedBlob.h
+++ b/include/xrpl/nodestore/detail/EncodedBlob.h
@@ -35,7 +35,7 @@ namespace NodeStore {
 class EncodedBlob
 {
    /** The 32-byte key of the serialized object. */
-    std::array<std::uint8_t, 32> key_;
+    std::array<std::uint8_t, 32> key_{};

    /** A pre-allocated buffer for the serialized object.

@@ -43,7 +43,8 @@ class EncodedBlob
         1024 more bytes. The precise size is calculated automatically
         at compile time so as to avoid wasting space on padding bytes.
     */
-    std::array<std::uint8_t, boost::alignment::align_up(9 + 1024, alignof(std::uint32_t))> payload_;
+    std::array<std::uint8_t, boost::alignment::align_up(9 + 1024, alignof(std::uint32_t))>
+        payload_{};

    /** The size of the serialized data. */
    std::uint32_t size_;
--- a/include/xrpl/nodestore/detail/codec.h
+++ b/include/xrpl/nodestore/detail/codec.h
@@ -56,7 +56,7 @@ lz4_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
    using std::runtime_error;
    using namespace nudb::detail;
    std::pair<void const*, std::size_t> result;
-    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi;
+    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi{};
    auto const n = write_varint(vi.data(), in_size);
    auto const out_max = LZ4_compressBound(in_size);
    std::uint8_t* out = reinterpret_cast<std::uint8_t*>(bf(n + out_max));
@@ -88,7 +88,7 @@ nodeobject_decompress(void const* in, std::size_t in_size, BufferFactory&& bf)
    using namespace nudb::detail;

    std::uint8_t const* p = reinterpret_cast<std::uint8_t const*>(in);
-    std::size_t type;
+    std::size_t type = 0;
    auto const vn = read_varint(p, in_size, type);
    if (vn == 0)
        Throw<std::runtime_error>("nodeobject decompress");
@@ -117,7 +117,7 @@ nodeobject_decompress(void const* in, std::size_t in_size, BufferFactory&& bf)
                    "nodeobject codec v1: short inner node size: " + std::string("in_size = ") +
                    std::to_string(in_size) + " hs = " + std::to_string(hs));
            istream is(p, in_size);
-            std::uint16_t mask;
+            std::uint16_t mask = 0;
            read<std::uint16_t>(is, mask);  // Mask
            in_size -= hs;
            result.second = 525;
@@ -196,10 +196,10 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
    if (in_size == 525)
    {
        istream is(in, in_size);
-        std::uint32_t index;
-        std::uint32_t unused;
-        std::uint8_t kind;
-        std::uint32_t prefix;
+        std::uint32_t index = 0;
+        std::uint32_t unused = 0;
+        std::uint8_t kind = 0;
+        std::uint32_t prefix = 0;
        read<std::uint32_t>(is, index);
        read<std::uint32_t>(is, unused);
        read<std::uint8_t>(is, kind);
@@ -208,7 +208,7 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
        {
            std::size_t n = 0;
            std::uint16_t mask = 0;
-            std::array<std::uint8_t, 512> vh;
+            std::array<std::uint8_t, 512> vh{};
            for (unsigned bit = 0x8000; bit; bit >>= 1)
            {
                void const* const h = is(32);
@@ -247,7 +247,7 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
        }
    }

-    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi;
+    std::array<std::uint8_t, varint_traits<std::size_t>::max> vi{};

    constexpr std::size_t codecType = 1;
    auto const vn = write_varint(vi.data(), codecType);
@@ -257,7 +257,7 @@ nodeobject_compress(void const* in, std::size_t in_size, BufferFactory&& bf)
        // case 0 was uncompressed data; we always compress now.
        case 1:  // lz4
        {
-            std::uint8_t* p;
+            std::uint8_t* p = nullptr;
            auto const lzr = NodeStore::lz4_compress(in, in_size, [&p, &vn, &bf](std::size_t n) {
                p = reinterpret_cast<std::uint8_t*>(bf(vn + n));
                return p + vn;
@@ -287,10 +287,10 @@ filter_inner(void* in, std::size_t in_size)
    if (in_size == 525)
    {
        istream is(in, in_size);
-        std::uint32_t index;
-        std::uint32_t unused;
-        std::uint8_t kind;
-        std::uint32_t prefix;
+        std::uint32_t index = 0;
+        std::uint32_t unused = 0;
+        std::uint8_t kind = 0;
+        std::uint32_t prefix = 0;
        read<std::uint32_t>(is, index);
        read<std::uint32_t>(is, unused);
        read<std::uint8_t>(is, kind);
--- a/include/xrpl/nodestore/detail/varint.h
+++ b/include/xrpl/nodestore/detail/varint.h
@@ -82,6 +82,7 @@ template <class = void>
 std::size_t
 write_varint(void* p0, std::size_t v)
 {
+    // NOLINTNEXTLINE(misc-const-correctness)
    std::uint8_t* p = reinterpret_cast<std::uint8_t*>(p0);
    do
    {
--- a/include/xrpl/protocol/AmountConversions.h
+++ b/include/xrpl/protocol/AmountConversions.h
@@ -102,7 +102,7 @@ template <typename T>
 T
 toAmount(Issue const& issue, Number const& n, Number::rounding_mode mode = Number::getround())
 {
-    saveNumberRoundMode rm(Number::getround());
+    saveNumberRoundMode const rm(Number::getround());
    if (isXRP(issue))
        Number::setround(mode);

--- a/include/xrpl/protocol/IOUAmount.h
+++ b/include/xrpl/protocol/IOUAmount.h
@@ -26,8 +26,8 @@ class IOUAmount : private boost::totally_ordered<IOUAmount>, private boost::addi
 private:
    using mantissa_type = std::int64_t;
    using exponent_type = int;
-    mantissa_type mantissa_;
-    exponent_type exponent_;
+    mantissa_type mantissa_{};
+    exponent_type exponent_{};

    /** Adjusts the mantissa and exponent to the proper range.

--- a/include/xrpl/protocol/Indexes.h
+++ b/include/xrpl/protocol/Indexes.h
@@ -363,11 +363,12 @@ uint256
 getTicketIndex(AccountID const& account, SeqProxy ticketSeq);

 template <class... keyletParams>
+// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
 struct keyletDesc
 {
    std::function<Keylet(keyletParams...)> function;
    Json::StaticString expectedLEName;
-    bool includeInTests;
+    bool includeInTests{};
 };

 // This list should include all of the keylet functions that take a single
--- a/include/xrpl/protocol/Issue.h
+++ b/include/xrpl/protocol/Issue.h
@@ -96,7 +96,7 @@ operator<=>(Issue const& lhs, Issue const& rhs)
 inline Issue const&
 xrpIssue()
 {
-    static Issue issue{xrpCurrency(), xrpAccount()};
+    static Issue const issue{xrpCurrency(), xrpAccount()};
    return issue;
 }

@@ -104,7 +104,7 @@ xrpIssue()
 inline Issue const&
 noIssue()
 {
-    static Issue issue{noCurrency(), noAccount()};
+    static Issue const issue{noCurrency(), noAccount()};
    return issue;
 }

--- a/include/xrpl/protocol/Quality.h
+++ b/include/xrpl/protocol/Quality.h
@@ -56,8 +56,8 @@ struct TAmounts
        return *this;
    }

-    In in;
-    Out out;
+    In in{};
+    Out out{};
 };

 using Amounts = TAmounts<STAmount, STAmount>;
@@ -304,8 +304,8 @@ Quality::ceil_TAmounts_helper(

    // Use the existing STAmount implementation for now, but consider
    // replacing with code specific to IOUAMount and XRPAmount
-    Amounts stAmt(toSTAmount(amount.in), toSTAmount(amount.out));
-    STAmount stLim(toSTAmount(limit));
+    Amounts const stAmt(toSTAmount(amount.in), toSTAmount(amount.out));
+    STAmount const stLim(toSTAmount(limit));
    Amounts const stRes = ((*this).*ceil_function)(stAmt, stLim, roundUp...);
    return TAmounts<In, Out>(toAmount<In>(stRes.in), toAmount<Out>(stRes.out));
 }
--- a/include/xrpl/protocol/RippleLedgerHash.h
+++ b/include/xrpl/protocol/RippleLedgerHash.h
@@ -6,4 +6,4 @@ namespace xrpl {

 using LedgerHash = uint256;

-}
+}  // namespace xrpl
--- a/include/xrpl/protocol/STAmount.h
+++ b/include/xrpl/protocol/STAmount.h
@@ -35,9 +35,9 @@ public:

 private:
    Asset mAsset;
-    mantissa_type mValue;
+    mantissa_type mValue{};
    exponent_type mOffset;
-    bool mIsNegative;
+    bool mIsNegative{};

 public:
    using value_type = STAmount;
@@ -532,7 +532,7 @@ STAmount::fromNumber(A const& a, Number const& number)
 {
    bool const negative = number.mantissa() < 0;
    Number const working{negative ? -number : number};
-    Asset asset{a};
+    Asset const asset{a};
    if (asset.integral())
    {
        std::uint64_t const intValue = static_cast<std::int64_t>(working);
@@ -716,7 +716,7 @@ roundToAsset(
    std::int32_t scale,
    Number::rounding_mode rounding = Number::getround())
 {
-    NumberRoundModeGuard mg(rounding);
+    NumberRoundModeGuard const mg(rounding);
    STAmount const ret{asset, value};
    if (ret.integral())
        return ret;
--- a/include/xrpl/protocol/STBase.h
+++ b/include/xrpl/protocol/STBase.h
@@ -83,7 +83,7 @@ to_json(T const& t)

 namespace detail {
 class STVar;
-}
+}  // namespace detail

 // VFALCO TODO fix this restriction on copy assignment.
 //
--- a/include/xrpl/protocol/STLedgerEntry.h
+++ b/include/xrpl/protocol/STLedgerEntry.h
@@ -8,7 +8,7 @@ namespace xrpl {
 class Rules;
 namespace test {
 class Invariants_test;
-}
+}  // namespace test

 class STLedgerEntry final : public STObject, public CountedObject<STLedgerEntry>
 {
@@ -86,7 +86,9 @@ inline STLedgerEntry::STLedgerEntry(LedgerEntryType type, uint256 const& key)
 {
 }

-inline STLedgerEntry::STLedgerEntry(SerialIter&& sit, uint256 const& index)
+inline STLedgerEntry::STLedgerEntry(
+    SerialIter&& sit,  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    uint256 const& index)
    : STLedgerEntry(sit, index)
 {
 }
--- a/include/xrpl/protocol/STObject.h
+++ b/include/xrpl/protocol/STObject.h
@@ -671,7 +671,7 @@ public:
    OptionalProxy&
    operator=(std::nullopt_t const&);
    OptionalProxy&
-    operator=(optional_type&& v);
+    operator=(optional_type&& v);  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
    OptionalProxy&
    operator=(optional_type const& v);

@@ -766,7 +766,7 @@ STObject::Proxy<T>::assign(U&& u)
        st_->makeFieldAbsent(*f_);
        return;
    }
-    T* t;
+    T* t = nullptr;
    if (style_ == soeINVALID)
        t = dynamic_cast<T*>(st_->getPField(*f_, true));
    else
@@ -851,7 +851,9 @@ STObject::OptionalProxy<T>::operator=(std::nullopt_t const&) -> OptionalProxy&

 template <class T>
 auto
-STObject::OptionalProxy<T>::operator=(optional_type&& v) -> OptionalProxy&
+STObject::OptionalProxy<T>::operator=(
+    optional_type&& v)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    -> OptionalProxy&
 {
    if (v)
        this->assign(std::move(*v));
@@ -930,6 +932,7 @@ STObject::Transform::operator()(detail::STVar const& e) const

 //------------------------------------------------------------------------------

+// NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
 inline STObject::STObject(SerialIter&& sit, SField const& name) : STObject(sit, name)
 {
 }
@@ -1153,7 +1156,7 @@ STObject::getFieldByValue(SField const& field) const
    if (!rf)
        throwFieldNotFound(field);

-    SerializedTypeID id = rf->getSType();
+    SerializedTypeID const id = rf->getSType();

    if (id == STI_NOTPRESENT)
        return V();  // optional field not present
@@ -1180,7 +1183,7 @@ STObject::getFieldByConstRef(SField const& field, V const& empty) const
    if (!rf)
        throwFieldNotFound(field);

-    SerializedTypeID id = rf->getSType();
+    SerializedTypeID const id = rf->getSType();

    if (id == STI_NOTPRESENT)
        return empty;  // optional field not present
--- a/include/xrpl/protocol/STTx.h
+++ b/include/xrpl/protocol/STTx.h
@@ -179,7 +179,8 @@ sterilize(STTx const& stx);
 bool
 isPseudoTx(STObject const& tx);

-inline STTx::STTx(SerialIter&& sit) : STTx(sit)
+inline STTx::STTx(SerialIter&& sit)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
+    : STTx(sit)
 {
 }

--- a/include/xrpl/protocol/STVector256.h
+++ b/include/xrpl/protocol/STVector256.h
@@ -69,9 +69,6 @@ public:
    std::vector<uint256>::iterator
    insert(std::vector<uint256>::const_iterator pos, uint256 const& value);

-    std::vector<uint256>::iterator
-    insert(std::vector<uint256>::const_iterator pos, uint256&& value);
-
    void
    push_back(uint256 const& v);

@@ -184,12 +181,6 @@ STVector256::insert(std::vector<uint256>::const_iterator pos, uint256 const& val
    return mValue.insert(pos, value);
 }

-inline std::vector<uint256>::iterator
-STVector256::insert(std::vector<uint256>::const_iterator pos, uint256&& value)
-{
-    return mValue.insert(pos, std::move(value));
-}
-
 inline void
 STVector256::push_back(uint256 const& v)
 {
--- a/include/xrpl/protocol/Serializer.h
+++ b/include/xrpl/protocol/Serializer.h
@@ -69,7 +69,7 @@ public:
    int
    add32(T i)
    {
-        int ret = mData.size();
+        int const ret = mData.size();
        mData.push_back(static_cast<unsigned char>((i >> 24) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 16) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 8) & 0xff));
@@ -85,7 +85,7 @@ public:
    int
    add64(T i)
    {
-        int ret = mData.size();
+        int const ret = mData.size();
        mData.push_back(static_cast<unsigned char>((i >> 56) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 48) & 0xff));
        mData.push_back(static_cast<unsigned char>((i >> 40) & 0xff));
@@ -299,7 +299,7 @@ template <class Iter>
 int
 Serializer::addVL(Iter begin, Iter end, int len)
 {
-    int ret = addEncoded(len);
+    int const ret = addEncoded(len);
    for (; begin != end; ++begin)
    {
        addRaw(begin->data(), begin->size());
--- a/include/xrpl/protocol/TxSearched.h
+++ b/include/xrpl/protocol/TxSearched.h
@@ -2,6 +2,6 @@

 namespace xrpl {

-enum class TxSearched { all, some, unknown };
+enum class TxSearched { All, Some, Unknown };

-}
+}  // namespace xrpl
--- a/include/xrpl/protocol/detail/STVar.h
+++ b/include/xrpl/protocol/detail/STVar.h
@@ -25,16 +25,10 @@ extern nonPresentObject_t nonPresentObject;

 // Concept to constrain STVar constructors, which
 // instantiate ST* types from SerializedTypeID
-// clang-format off
 template <typename... Args>
 concept ValidConstructSTArgs =
-    (std::is_same_v<
-         std::tuple<std::remove_cvref_t<Args>...>,
-         std::tuple<SField>> ||
-     std::is_same_v<
-         std::tuple<std::remove_cvref_t<Args>...>,
-         std::tuple<SerialIter, SField>>);
-// clang-format on
+    (std::is_same_v<std::tuple<std::remove_cvref_t<Args>...>, std::tuple<SField>> ||
+     std::is_same_v<std::tuple<std::remove_cvref_t<Args>...>, std::tuple<SerialIter, SField>>);

 // "variant" that can hold any type of serialized object
 // and includes a small-object allocation optimization.
@@ -56,7 +50,7 @@ public:
    STVar&
    operator=(STVar&& rhs);

-    STVar(STBase&& t)
+    STVar(STBase&& t)  // NOLINT(cppcoreguidelines-rvalue-reference-param-not-moved)
    {
        p_ = t.move(max_size, &d_);
    }
--- a/include/xrpl/protocol/detail/b58_utils.h
+++ b/include/xrpl/protocol/detail/b58_utils.h
@@ -59,7 +59,7 @@ inplace_bigint_add(std::span<std::uint64_t> a, std::uint64_t b)
        return TokenCodecErrc::inputTooSmall;
    }

-    std::uint64_t carry;
+    std::uint64_t carry = 0;
    std::tie(a[0], carry) = carrying_add(a[0], b);

    for (auto& v : a.subspan(1))
@@ -162,7 +162,7 @@ b58_10_to_b58_be(std::uint64_t input)
    int i = 0;
    while (input > 0)
    {
-        std::uint64_t rem;
+        std::uint64_t rem = 0;
        std::tie(input, rem) = div_rem(input, 58);
        result[resultSize - 1 - i] = rem;
        i += 1;
--- a/include/xrpl/protocol/detail/features.macro
+++ b/include/xrpl/protocol/detail/features.macro
@@ -11,66 +11,65 @@
 #error "undefined macro: XRPL_RETIRE_FIX"
 #endif

-// clang-format off

 // Add new amendments to the top of this list.
 // Keep it sorted in reverse chronological order.

-XRPL_FIX   (Security3_1_3,               Supported::no, VoteBehavior::DefaultNo)
-XRPL_FIX   (PermissionedDomainInvariant, Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (ExpiredNFTokenOfferRemoval, Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (BatchInnerSigs,             Supported::no, VoteBehavior::DefaultNo)
-XRPL_FEATURE(LendingProtocol,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PermissionDelegationV1_1,   Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FIX    (DirectoryLimit,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (IncludeKeyletFields,        Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DynamicMPT,                 Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FIX    (TokenEscrowV1,              Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (PriceOracleOrder,           Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (MPTDeliveredAmount,         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMClawbackRounding,        Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(TokenEscrow,                Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (EnforceNFTokenTrustlineV2,  Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMv1_3,                    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PermissionedDEX,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(Batch,                      Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FEATURE(SingleAssetVault,           Supported::yes,  VoteBehavior::DefaultNo)
-XRPL_FIX    (PayChanCancelAfter,         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (Security3_1_3,               Supported::no, VoteBehavior::DefaultNo)
+XRPL_FIX    (PermissionedDomainInvariant, Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (ExpiredNFTokenOfferRemoval,  Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (BatchInnerSigs,              Supported::no, VoteBehavior::DefaultNo)
+XRPL_FEATURE(LendingProtocol,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PermissionDelegationV1_1,    Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FIX    (DirectoryLimit,              Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (IncludeKeyletFields,         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DynamicMPT,                  Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FIX    (TokenEscrowV1,               Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (PriceOracleOrder,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (MPTDeliveredAmount,          Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMClawbackRounding,         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(TokenEscrow,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (EnforceNFTokenTrustlineV2,   Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMv1_3,                     Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PermissionedDEX,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(Batch,                       Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FEATURE(SingleAssetVault,            Supported::yes,  VoteBehavior::DefaultNo)
+XRPL_FIX    (PayChanCancelAfter,          Supported::yes, VoteBehavior::DefaultNo)
 // Check flags in Credential transactions
-XRPL_FIX    (InvalidTxFlags,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (FrozenLPTokenTransfer,      Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DeepFreeze,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PermissionedDomains,        Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DynamicNFT,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(Credentials,                Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(AMMClawback,                Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMv1_2,                    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(MPTokensV1,                 Supported::yes, VoteBehavior::DefaultNo)
-// InvariantsV1_1 will be changes to Supported::yes when all the
-// invariants expected to be included under it are complete.
-XRPL_FEATURE(InvariantsV1_1,             Supported::no,  VoteBehavior::DefaultNo)
-XRPL_FIX    (NFTokenPageLinks,           Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (InnerObjTemplate2,          Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (EnforceNFTokenTrustline,    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (ReducedOffersV2,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(NFTokenMintOffer,           Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMv1_1,                    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (PreviousTxnID,              Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (XChainRewardRounding,       Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (EmptyDID,                   Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(PriceOracle,                Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (AMMOverflowOffer,           Supported::yes, VoteBehavior::DefaultYes)
-XRPL_FIX    (InnerObjTemplate,           Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (NFTokenReserve,             Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (FillOrKill,                 Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(DID,                        Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (DisallowIncomingV1,         Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(XChainBridge,               Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(AMM,                        Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(Clawback,                   Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (UniversalNumber,            Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FEATURE(XRPFees,                    Supported::yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (RemoveNFTokenAutoTrustLine, Supported::yes, VoteBehavior::DefaultYes)
+XRPL_FIX    (InvalidTxFlags,              Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (FrozenLPTokenTransfer,       Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DeepFreeze,                  Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PermissionedDomains,         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DynamicNFT,                  Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(Credentials,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(AMMClawback,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMv1_2,                     Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(MPTokensV1,                  Supported::yes, VoteBehavior::DefaultNo)
+// InvariantsV1_1 will be changed to Supported::yes when all the invariants expected to be included
+// under it are complete.
+XRPL_FEATURE(InvariantsV1_1,              Supported::no,  VoteBehavior::DefaultNo)
+XRPL_FIX    (NFTokenPageLinks,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (InnerObjTemplate2,           Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (EnforceNFTokenTrustline,     Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (ReducedOffersV2,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(NFTokenMintOffer,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMv1_1,                     Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (PreviousTxnID,               Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (XChainRewardRounding,        Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (EmptyDID,                    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(PriceOracle,                 Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (AMMOverflowOffer,            Supported::yes, VoteBehavior::DefaultYes)
+XRPL_FIX    (InnerObjTemplate,            Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (NFTokenReserve,              Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (FillOrKill,                  Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(DID,                         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (DisallowIncomingV1,          Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(XChainBridge,                Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(AMM,                         Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(Clawback,                    Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (UniversalNumber,             Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FEATURE(XRPFees,                     Supported::yes, VoteBehavior::DefaultNo)
+XRPL_FIX    (RemoveNFTokenAutoTrustLine,  Supported::yes, VoteBehavior::DefaultYes)

 // The following amendments are obsolete, but must remain supported
 // because they could potentially get enabled.
@@ -144,5 +143,3 @@ XRPL_RETIRE_FEATURE(SortedDirectories)
 XRPL_RETIRE_FEATURE(TicketBatch)
 XRPL_RETIRE_FEATURE(TickSize)
 XRPL_RETIRE_FEATURE(TrustSetAuth)
-
-// clang-format on
--- a/include/xrpl/protocol/detail/sfields.macro
+++ b/include/xrpl/protocol/detail/sfields.macro
@@ -5,7 +5,6 @@
 #error "undefined macro: TYPED_SFIELD"
 #endif

-// clang-format off

 // untyped
 UNTYPED_SFIELD(sfLedgerEntry,            LEDGERENTRY, 257)
@@ -421,5 +420,3 @@ UNTYPED_SFIELD(sfAcceptedCredentials,    ARRAY,     28)
 UNTYPED_SFIELD(sfPermissions,            ARRAY,     29)
 UNTYPED_SFIELD(sfRawTransactions,        ARRAY,     30)
 UNTYPED_SFIELD(sfBatchSigners,           ARRAY,     31, SField::sMD_Default, SField::notSigning)
-
-// clang-format on
--- a/include/xrpl/protocol/detail/token_errors.h
+++ b/include/xrpl/protocol/detail/token_errors.h
@@ -15,7 +15,7 @@ enum class TokenCodecErrc {
    overflowAdd,
    unknown,
 };
-}
+}  // namespace xrpl

 namespace std {
 template <>
@@ -69,7 +69,7 @@ public:
 inline xrpl::detail::TokenCodecErrcCategory const&
 TokenCodecErrcCategory()
 {
-    static xrpl::detail::TokenCodecErrcCategory c;
+    static xrpl::detail::TokenCodecErrcCategory const c;
    return c;
 }

--- a/include/xrpl/protocol/json_get_or_throw.h
+++ b/include/xrpl/protocol/json_get_or_throw.h
@@ -112,7 +112,7 @@ getOrThrow(Json::Value const& v, xrpl::SField const& field)
    {
        auto const s = inner.asString();
        // parse as hex
-        std::uint64_t val;
+        std::uint64_t val = 0;

        auto [p, ec] = std::from_chars(s.data(), s.data() + s.size(), val, 16);

--- a/include/xrpl/protocol/jss.h
+++ b/include/xrpl/protocol/jss.h
--- a/include/xrpl/protocol/nft.h
+++ b/include/xrpl/protocol/nft.h
@@ -39,7 +39,7 @@ constexpr std::uint16_t const flagMutable = 0x0010;
 inline std::uint16_t
 getFlags(uint256 const& id)
 {
-    std::uint16_t flags;
+    std::uint16_t flags = 0;
    memcpy(&flags, id.begin(), 2);
    return boost::endian::big_to_native(flags);
 }
@@ -47,7 +47,7 @@ getFlags(uint256 const& id)
 inline std::uint16_t
 getTransferFee(uint256 const& id)
 {
-    std::uint16_t fee;
+    std::uint16_t fee = 0;
    memcpy(&fee, id.begin() + 2, 2);
    return boost::endian::big_to_native(fee);
 }
@@ -55,7 +55,7 @@ getTransferFee(uint256 const& id)
 inline std::uint32_t
 getSerial(uint256 const& id)
 {
-    std::uint32_t seq;
+    std::uint32_t seq = 0;
    memcpy(&seq, id.begin() + 28, 4);
    return boost::endian::big_to_native(seq);
 }
@@ -87,7 +87,7 @@ cipheredTaxon(std::uint32_t tokenSeq, Taxon taxon)
 inline Taxon
 getTaxon(uint256 const& id)
 {
-    std::uint32_t taxon;
+    std::uint32_t taxon = 0;
    memcpy(&taxon, id.begin() + 24, 4);
    taxon = boost::endian::big_to_native(taxon);

--- a/include/xrpl/protocol_autogen/.clang-tidy
+++ b/include/xrpl/protocol_autogen/.clang-tidy
@@ -0,0 +1,3 @@
+# This disables all checks for this directory and its subdirectories
+Checks: "-*"
+InheritParentConfig: false
--- a/include/xrpl/rdb/DatabaseCon.h
+++ b/include/xrpl/rdb/DatabaseCon.h
@@ -1,6 +1,7 @@
 #pragma once

 #include <xrpl/core/PerfLog.h>
+#include <xrpl/core/ServiceRegistry.h>
 #include <xrpl/core/StartUpType.h>
 #include <xrpl/rdb/DBInit.h>
 #include <xrpl/rdb/SociDB.h>
@@ -13,7 +14,7 @@

 namespace soci {
 class session;
-}
+}  // namespace soci

 namespace xrpl {

@@ -69,7 +70,7 @@ public:
    {
        explicit Setup() = default;

-        StartUpType startUp = StartUpType::NORMAL;
+        StartUpType startUp = StartUpType::Normal;
        bool standAlone = false;
        boost::filesystem::path dataDir;
        // Indicates whether or not to return the `globalPragma`
@@ -94,7 +95,7 @@ public:
    struct CheckpointerSetup
    {
        JobQueue* jobQueue;
-        Logs* logs;
+        std::reference_wrapper<ServiceRegistry> registry;
    };

    template <std::size_t N, std::size_t M>
@@ -106,9 +107,8 @@ public:
        beast::Journal journal)
        // Use temporary files or regular DB files?
        : DatabaseCon(
-              setup.standAlone && setup.startUp != StartUpType::LOAD &&
-                      setup.startUp != StartUpType::LOAD_FILE &&
-                      setup.startUp != StartUpType::REPLAY
+              setup.standAlone && setup.startUp != StartUpType::Load &&
+                      setup.startUp != StartUpType::LoadFile && setup.startUp != StartUpType::Replay
                  ? ""
                  : (setup.dataDir / dbName),
              setup.commonPragma(),
@@ -129,7 +129,7 @@ public:
        beast::Journal journal)
        : DatabaseCon(setup, dbName, pragma, initSQL, journal)
    {
-        setupCheckpointing(checkpointerSetup.jobQueue, *checkpointerSetup.logs);
+        setupCheckpointing(checkpointerSetup.jobQueue, checkpointerSetup.registry.get());
    }

    template <std::size_t N, std::size_t M>
@@ -154,7 +154,7 @@ public:
        beast::Journal journal)
        : DatabaseCon(dataDir, dbName, pragma, initSQL, journal)
    {
-        setupCheckpointing(checkpointerSetup.jobQueue, *checkpointerSetup.logs);
+        setupCheckpointing(checkpointerSetup.jobQueue, checkpointerSetup.registry.get());
    }

    ~DatabaseCon();
@@ -177,7 +177,7 @@ public:

 private:
    void
-    setupCheckpointing(JobQueue*, Logs&);
+    setupCheckpointing(JobQueue*, ServiceRegistry&);

    template <std::size_t N, std::size_t M>
    DatabaseCon(
--- a/include/xrpl/rdb/RelationalDatabase.h
+++ b/include/xrpl/rdb/RelationalDatabase.h
@@ -49,21 +49,21 @@ public:
    struct AccountTxOptions
    {
        AccountID const& account;
-        std::uint32_t minLedger;
-        std::uint32_t maxLedger;
-        std::uint32_t offset;
-        std::uint32_t limit;
-        bool bUnlimited;
+        /// Ledger sequence range to search. A value of 0 for min or max
+        /// means unbounded in that direction (no constraint applied).
+        LedgerRange ledgerRange{};
+        std::uint32_t offset = 0;
+        std::uint32_t limit = 0;
+        bool bUnlimited{};
    };

    struct AccountTxPageOptions
    {
        AccountID const& account;
-        std::uint32_t minLedger;
-        std::uint32_t maxLedger;
+        LedgerRange ledgerRange{};
        std::optional<AccountTxMarker> marker;
-        std::uint32_t limit;
-        bool bAdmin;
+        std::uint32_t limit = 0;
+        bool bAdmin = false;
    };

    using AccountTx = std::pair<std::shared_ptr<Transaction>, std::shared_ptr<TxMeta>>;
@@ -88,8 +88,8 @@ public:
    struct AccountTxResult
    {
        std::variant<AccountTxs, MetaTxsList> transactions;
-        LedgerRange ledgerRange;
-        uint32_t limit;
+        LedgerRange ledgerRange{};
+        uint32_t limit = 0;
        std::optional<AccountTxMarker> marker;
    };

@@ -247,7 +247,7 @@ public:
     * @return Struct CountMinMax which contains the minimum sequence,
     *         maximum sequence and number of ledgers.
     */
-    virtual struct CountMinMax
+    virtual CountMinMax
    getLedgerCountMinMax() = 0;

    /**
@@ -405,10 +405,10 @@ public:
     * @param id Hash of the transaction.
     * @param range Range of ledgers to check, if present.
     * @param ec Default error code value.
-     * @return Transaction and its metadata if found, otherwise TxSearched::all
+     * @return Transaction and its metadata if found, otherwise TxSearched::All
     *         if a range is provided and all ledgers from the range are present
-     *         in the database, TxSearched::some if a range is provided and not
-     *         all ledgers are present, TxSearched::unknown if the range is not
+     *         in the database, TxSearched::Some if a range is provided and not
+     *         all ledgers are present, TxSearched::Unknown if the range is not
     *         provided or a deserializing error occurred. In the last case the
     *         error code is returned via the ec parameter, in other cases the
     *         default error code is not changed.
@@ -455,9 +455,10 @@ public:
    closeTransactionDB() = 0;
 };

-template <class T, class C>
+template <typename T, typename C>
 T
 rangeCheckedCast(C c)
+    requires(std::is_arithmetic_v<T> && std::is_arithmetic_v<C> && std::convertible_to<C, T>)
 {
    if ((c > std::numeric_limits<T>::max()) || (!std::numeric_limits<T>::is_signed && c < 0) ||
        (std::numeric_limits<T>::is_signed && std::numeric_limits<C>::is_signed &&
--- a/include/xrpl/rdb/SociDB.h
+++ b/include/xrpl/rdb/SociDB.h
@@ -13,8 +13,8 @@
 #pragma clang diagnostic ignored "-Wdeprecated"
 #endif

-#include <xrpl/basics/Log.h>
 #include <xrpl/core/JobQueue.h>
+#include <xrpl/core/ServiceRegistry.h>

 #define SOCI_USE_BOOST
 #include <soci/soci.h>
@@ -25,7 +25,7 @@

 namespace sqlite_api {
 struct sqlite3;
-}
+}  // namespace sqlite_api

 namespace xrpl {

@@ -111,7 +111,7 @@ public:
    and so must outlive them both.
 */
 std::shared_ptr<Checkpointer>
-makeCheckpointer(std::uintptr_t id, std::weak_ptr<soci::session>, JobQueue&, Logs&);
+makeCheckpointer(std::uintptr_t id, std::weak_ptr<soci::session>, JobQueue&, ServiceRegistry&);

 }  // namespace xrpl

--- a/include/xrpl/resource/Fees.h
+++ b/include/xrpl/resource/Fees.h
@@ -5,38 +5,30 @@
 namespace xrpl {
 namespace Resource {

-// clang-format off
 /** Schedule of fees charged for imposing load on the server. */
 /** @{ */
-extern Charge const feeMalformedRequest;    // A request that we can immediately
-                                          //   tell is invalid
-extern Charge const feeRequestNoReply;    // A request that we cannot satisfy
-extern Charge const feeInvalidSignature;  // An object whose signature we had
-                                          //   to check and it failed
-extern Charge const feeUselessData;      // Data we have no use for
-extern Charge const feeInvalidData;           // Data we have to verify before
-                                          //   rejecting
+extern Charge const feeMalformedRequest;  // A request that we can immediately tell is invalid.
+extern Charge const feeRequestNoReply;    // A request that we cannot satisfy.
+extern Charge const feeInvalidSignature;  // An object whose signature we had to check that failed.
+extern Charge const feeUselessData;       // Data we have no use for.
+extern Charge const feeInvalidData;       // Data we have to verify before rejecting.

 // RPC loads
-extern Charge const feeMalformedRPC;        // An RPC request that we can
-                                          //   immediately tell is invalid.
-extern Charge const feeReferenceRPC;      // A default "reference" unspecified
-                                          //   load
-extern Charge const feeExceptionRPC;      // RPC load that causes an exception
-extern Charge const feeMediumBurdenRPC;   // A somewhat burdensome RPC load
-extern Charge const feeHeavyBurdenRPC;     // A very burdensome RPC load
+extern Charge const feeMalformedRPC;     // An RPC request that we can immediately tell is invalid.
+extern Charge const feeReferenceRPC;     // A default "reference" unspecified load.
+extern Charge const feeExceptionRPC;     // RPC load that causes an exception.
+extern Charge const feeMediumBurdenRPC;  // A somewhat burdensome RPC load.
+extern Charge const feeHeavyBurdenRPC;   // A very burdensome RPC load.

 // Peer loads
-extern Charge const feeTrivialPeer;         // Requires no reply
-extern Charge const feeModerateBurdenPeer;  // Requires some work
-extern Charge const feeHeavyBurdenPeer;    // Extensive work
+extern Charge const feeTrivialPeer;         // Requires no reply.
+extern Charge const feeModerateBurdenPeer;  // Requires some work.
+extern Charge const feeHeavyBurdenPeer;     // Extensive work.

 // Administrative
-extern Charge const feeWarning;           // The cost of receiving a warning
-extern Charge const feeDrop;              // The cost of being dropped for
-                                          //   excess load
+extern Charge const feeWarning;  // The cost of receiving a warning.
+extern Charge const feeDrop;     // The cost of being dropped for excess load.
 /** @} */
-// clang-format on

 }  // namespace Resource
 }  // namespace xrpl
--- a/include/xrpl/resource/Gossip.h
+++ b/include/xrpl/resource/Gossip.h
@@ -17,7 +17,7 @@ struct Gossip
    {
        explicit Item() = default;

-        int balance;
+        int balance{};
        beast::IP::Endpoint address;
    };

--- a/include/xrpl/resource/detail/Entry.h
+++ b/include/xrpl/resource/detail/Entry.h
@@ -62,7 +62,7 @@ struct Entry : public beast::List<Entry>::Node
    std::optional<PublicKey> publicKey;

    // Back pointer to the map key (bit of a hack here)
-    Key const* key;
+    Key const* key{};

    // Number of Consumer references
    int refcount;
--- a/include/xrpl/resource/detail/Import.h
+++ b/include/xrpl/resource/detail/Import.h
@@ -13,7 +13,7 @@ struct Import
    {
        explicit Item() = default;

-        int balance;
+        int balance{};
        Consumer consumer;
    };

--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Mayukha Vadari	c5037b0dc6	Merge branch 'develop' into copilot/fix-vetoed-type-error	2026-04-01 16:19:18 -04:00
Vito Tumas	02fa55df8d	fix: Check trustline limits for share-denominated vault withdrawals (#6645 )	2026-04-01 19:31:45 +00:00
Valentin Balaschenko	6e2452207d	fix: Remove fatal assertion on Linux thread name truncation (#6690 )	2026-04-01 16:56:45 +00:00
Alex Kremer	29e49abd3c	chore: Enable clang-tidy `coreguidelines` checks (#6698 ) Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>	2026-04-01 15:46:14 +00:00
Ayaz Salikhov	ae21f53e4d	ci: Allow uploading artifacts for XRPLF org (#6702 )	2026-04-01 13:37:35 +00:00
Vito Tumas	bee1056faa	fix: Enforce aggregate MaximumAmount in multi-send MPT (#6644 ) Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>	2026-04-01 13:35:13 +00:00
Ayaz Salikhov	b6aa4a8fde	chore: Use nudb recipe from the upstream (#6701 )	2026-04-01 10:33:02 +00:00
Mayukha Vadari	a9afd2c116	fix: Fix previous ledger size typo in RCLConsensus (#6696 )	2026-03-31 19:56:30 +00:00
Alex Kremer	2502befb42	chore: Enable clang-tidy misc checks (#6655 )	2026-03-31 17:29:45 +00:00
Ayaz Salikhov	c3fae847f3	ci: Use pull_request_target to check for signed commits (#6697 )	2026-03-31 17:14:41 +00:00
Bart	7f53351920	chore: Remove unnecessary clang-format off/on directives (#6682 ) Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>	2026-03-31 15:38:04 +00:00
Pratik Mankawde	bb95a7d6cd	fix: Fix Workers::stop() race between m_allPaused and m_runningTaskCount (#6574 ) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-31 15:06:04 +00:00
Ayaz Salikhov	5c8dfe5456	ci: Only publish docs in public repos (#6687 )	2026-03-30 17:15:40 +00:00
Alex Kremer	ab8c168e3b	chore: Enable remaining clang-tidy `performance` checks (#6648 ) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2026-03-30 17:08:47 +00:00
Jingchen	3a477e4d01	refactor: Address PR comments after the modularisation PRs (#6389 ) Signed-off-by: JCW <a1q123456@users.noreply.github.com> Co-authored-by: Bart <bthomee@users.noreply.github.com>	2026-03-30 15:22:38 +00:00
Alex Kremer	96bfc32fe2	chore: Fix clang-tidy header filter (#6686 )	2026-03-30 14:59:53 +00:00
dependabot[bot]	de671863e2	ci: [DEPENDABOT] bump actions/deploy-pages from 4.0.5 to 5.0.0 (#6684 ) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-30 14:09:57 +00:00
dependabot[bot]	e0cabb9f8c	ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.3 to 6.0.0 (#6685 ) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-03-30 13:57:32 +00:00
Pratik Mankawde	3d9c545f59	fix: Guard Coro::resume() against completed coroutines (#6608 ) Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-27 18:52:18 +00:00
Vito Tumas	9b944ee8c2	refactor: Split LoanInvariant into LoanBrokerInvariant and LoanInvariant (#6674 )	2026-03-27 18:35:42 +00:00
Ayaz Salikhov	509677abfd	ci: Don't publish docs on release branches (#6673 )	2026-03-26 14:11:37 +00:00
Jingchen	addc1e8e25	refactor: Make function naming in ServiceRegistry consistent (#6390 ) Signed-off-by: JCW <a1q123456@users.noreply.github.com> Co-authored-by: Ed Hennis <ed@ripple.com>	2026-03-26 14:11:16 +00:00
Valentin Balaschenko	faf69da4b0	chore: Shorten job names to stay within Linux 15-char thread limit (#6669 )	2026-03-26 14:10:51 +00:00
Vito Tumas	76e3b4fb0f	fix: Improve loan invariant message (#6668 )	2026-03-26 12:40:26 +00:00
Ayaz Salikhov	e8bdbf975a	ci: Upload artifacts only in public repositories (#6670 )	2026-03-26 12:37:37 +00:00
Mayukha Vadari	ec7039c0e7	update changelog accordingly	2026-03-24 11:55:11 -07:00
Mayukha Vadari	f170f4c2c2	fix tests, improve code	2026-03-24 11:54:02 -07:00
Mayukha Vadari	8719bc19bc	fix clang-tidy	2026-03-24 10:19:16 -07:00
Mayukha Vadari	137de6f8a8	add obsolete field to non-admin	2026-03-24 10:18:19 -07:00
copilot-swe-agent[bot]	5bf2674944	Add isBool() checks for obsolete field and clarify admin-mode in changelog Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>	2026-03-24 10:17:59 -07:00
copilot-swe-agent[bot]	3e2f6658c6	Update all test assertions to validate new boolean vetoed and obsolete fields Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>	2026-03-24 10:17:58 -07:00
copilot-swe-agent[bot]	ee368f7096	Fix amendment vetoed field type - use boolean and add obsolete field Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>	2026-03-24 10:16:50 -07:00