docs: Update hybrid offer invariant comment (#7007)

This commit is contained in:
Zhiyuan Wang
2026-04-24 12:35:10 -04:00
committed by GitHub
parent 9ae29612ea
commit a6bd9251d2

View File

@@ -62,7 +62,8 @@ offerInDomain(
if (view.rules().enabled(fixSecurity3_1_3))
{
// post-fixSecurity3_1_3: also catches empty sfAdditionalBooks (size == 0)
// post-fixSecurity3_1_3: a valid hybrid offer must have
// sfAdditionalBooks present with exactly 1 entry
if (sleOffer->isFlag(lsfHybrid) &&
(!sleOffer->isFieldPresent(sfAdditionalBooks) ||
sleOffer->getFieldArray(sfAdditionalBooks).size() != 1))
@@ -74,7 +75,8 @@ offerInDomain(
}
else
{
// pre-fixSecurity3_1_3: only check for missing sfAdditionalBooks
// pre-fixSecurity3_1_3: a valid hybrid offer must have
// sfAdditionalBooks present (size is not checked)
if (sleOffer->isFlag(lsfHybrid) && !sleOffer->isFieldPresent(sfAdditionalBooks))
{
JLOG(j.error()) << "Hybrid offer " << offerID << " missing AdditionalBooks field";