From a6bd9251d269e79f17c1037caa765f88e01d0967 Mon Sep 17 00:00:00 2001 From: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com> Date: Fri, 24 Apr 2026 12:35:10 -0400 Subject: [PATCH] docs: Update hybrid offer invariant comment (#7007) --- src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp b/src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp index d65462f0cd..456c4e95d6 100644 --- a/src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp +++ b/src/libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp @@ -62,7 +62,8 @@ offerInDomain( if (view.rules().enabled(fixSecurity3_1_3)) { - // post-fixSecurity3_1_3: also catches empty sfAdditionalBooks (size == 0) + // post-fixSecurity3_1_3: a valid hybrid offer must have + // sfAdditionalBooks present with exactly 1 entry if (sleOffer->isFlag(lsfHybrid) && (!sleOffer->isFieldPresent(sfAdditionalBooks) || sleOffer->getFieldArray(sfAdditionalBooks).size() != 1)) @@ -74,7 +75,8 @@ offerInDomain( } else { - // pre-fixSecurity3_1_3: only check for missing sfAdditionalBooks + // pre-fixSecurity3_1_3: a valid hybrid offer must have + // sfAdditionalBooks present (size is not checked) if (sleOffer->isFlag(lsfHybrid) && !sleOffer->isFieldPresent(sfAdditionalBooks)) { JLOG(j.error()) << "Hybrid offer " << offerID << " missing AdditionalBooks field";