Ed Hennis
e5941d5b23
Simplify flag exclusion check in LoanManage
2025-09-09 16:29:35 -04:00
Ed Hennis
3f1a0f3a3d
Fix some build errors from yesterday
2025-09-09 15:25:51 -04:00
Ed Hennis
fa2c595a59
Add more value validation in LoanSet
...
- Don't allow negative numbers.
- Don't send the origination fee if it's defined, but 0.
2025-09-08 17:57:56 -04:00
Ed Hennis
fc6fe9802e
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-08 11:42:09 -04:00
Ed Hennis
b3c40ad408
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-08 11:42:01 -04:00
Ed Hennis
779e94bc03
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-08 11:41:57 -04:00
Ed Hennis
f653ca03d9
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-08 11:41:53 -04:00
Ed Hennis
d46e477092
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-08 11:41:50 -04:00
Ayaz Salikhov
9ebeb413e4
feat: Implement separate upload workflow ( #5762 )
...
* feat: Implement separate upload workflow
* Use cleanup-workspace
* Name some workflows reusable
* Add dependencies
2025-09-08 15:15:59 +00:00
Bronek Kozicki
6d40b882a4
Switch on-trigger to minimal build ( #5773 )
2025-09-08 13:54:50 +00:00
tzchenxixi
9fe0a154f1
chore: remove redundant word in comment ( #5752 )
2025-09-08 13:13:32 +00:00
Ed Hennis
24f58a2e94
Fix test loop
2025-09-05 23:46:48 -04:00
Ed Hennis
e3358ad124
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-05 20:29:04 -04:00
Ed Hennis
5102147709
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-05 20:28:58 -04:00
Ed Hennis
0a54c09de1
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-05 20:28:54 -04:00
Ed Hennis
d594ca1401
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-05 20:28:50 -04:00
Ed Hennis
5335c04616
Fix constexpr expression
2025-09-05 20:28:12 -04:00
Ed Hennis
6db14ccb13
More review feedback from @gregtatcam
...
- Also fix a few build errors that I missed earlier.
- Updated freeze check rules for LoanSet.
- Fixed the debt total calculation and check in LoanSet.
- Removed _some_ unnecessary includes.
2025-09-05 20:00:10 -04:00
Ed Hennis
582f56487d
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-05 17:44:28 -04:00
Ed Hennis
d47c039941
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-05 17:44:20 -04:00
Ed Hennis
bf4ae57da4
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-05 17:44:17 -04:00
Ed Hennis
83702e79bf
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-05 17:44:13 -04:00
Ed Hennis
6379363bad
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-05 17:44:10 -04:00
Ed Hennis
f0c96ccfe6
Review feedback from @yinyiqian1
...
- Rewrite to_short_string to call strHex directly instead of building
the whole hex string first.
- Change PrettyAsset::scale_ back to a uint32 since the Number
conversion elides any potential multiplication overflow.
- Clean ups.
2025-09-05 17:41:06 -04:00
Ayaz Salikhov
cb52c9af00
fix: Remove extra @ in notify-clio.yml ( #5771 )
2025-09-05 14:08:17 +01:00
Ed Hennis
4c726838d1
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 20:25:16 -04:00
Ed Hennis
47bcc67d56
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-04 20:25:09 -04:00
Ed Hennis
4b48f9612b
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-04 20:25:05 -04:00
Ed Hennis
7bba34832b
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-04 20:25:02 -04:00
Ed Hennis
76ae61feb5
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-04 20:24:58 -04:00
Ed Hennis
adb260fe17
Review feedback from @dangell7 and @gregtatcam
...
- Mostly adding comments.
- Fixed some function parameter names that weren't updated after
a copy/paste.
- LoanBrokerCoverWithdraw does not need to check for freeze when sending
to the issuer.
- Reorder the fund transfer cases in LoanBrokerCoverWithdraw to make it
clearer that some transfers are direct, and some use the payment
engine.
- Only look up the vault ID once in LoanBrokerSet
2025-09-04 20:21:30 -04:00
Mayukha Vadari
6bf8338038
chore: Add conan.lock to workflow file checks ( #5769 )
...
* Add conan.lock to workflow file checks
* Add conan.lock to on-trigger.yml
2025-09-04 22:32:23 +00:00
Ed Hennis
8444a944af
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 16:44:10 -04:00
Ed Hennis
6d20e59212
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-04 16:44:03 -04:00
Ed Hennis
c49cf6cec6
Merge branch 'ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
2025-09-04 16:43:59 -04:00
Ed Hennis
e24f034b17
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-04 16:43:56 -04:00
Ed Hennis
72733b57e4
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-04 16:43:52 -04:00
Ayaz Salikhov
b0f4174e47
chore: Use tooling provided by pre-commit ( #5753 )
2025-09-04 20:30:54 +00:00
Ed Hennis
7a78449f6d
Fix minor review feedback from @Bronek
...
- Clean up assert, log, and comments
2025-09-04 15:53:04 -04:00
Ayaz Salikhov
3865dde0b8
fix: Add missing info to notify-clio workflow ( #5761 )
...
* Add missing info to notify-clio workflow, as conan_ref
2025-09-04 19:26:57 +00:00
Ed Hennis
0d500343ed
New invariant privilege "mayDeleteMPT", used by VauleDeposit & Clawback
2025-09-04 14:08:54 -04:00
Ed Hennis
f15e88c009
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 13:15:41 -04:00
Ed Hennis
0069c0c5fa
Merge branch 'ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
2025-09-04 13:15:35 -04:00
Ed Hennis
450d38293d
Remove unused variable
2025-09-04 13:14:19 -04:00
Ed Hennis
6d9001edac
Merge branch 'ximinez/lending-refactoring-4' into ximinez/lending-XLS-66
2025-09-04 12:37:00 -04:00
Ed Hennis
3dc14e7430
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-3' into ximinez/lending-refactoring-4
...
* XRPLF/ximinez/lending-refactoring-3:
ci: Use cleanup-workspace action (5763)
Add `Scale` to SingleAssetVault (5652)
2025-09-04 12:35:39 -04:00
Ed Hennis
9a8c2523ae
Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-2' into ximinez/lending-refactoring-3
...
* XRPLF/ximinez/lending-refactoring-2:
ci: Use cleanup-workspace action (5763)
Add `Scale` to SingleAssetVault (5652)
2025-09-04 12:29:41 -04:00
Ed Hennis
115161f7d2
Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2
2025-09-04 12:27:02 -04:00
Ed Hennis
77fcb9b9b3
Merge branch 'develop' into ximinez/lending-refactoring-1
2025-09-04 12:26:58 -04:00
Ed Hennis
d2e8144c53
Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-refactoring-1
...
* XRPLF/develop:
Add `Scale` to SingleAssetVault (5652)
2025-09-04 12:25:49 -04:00
