Fix minor review feedback from @Bronek

- Clean up assert, log, and comments
This commit is contained in:
Ed Hennis
2025-09-04 15:53:04 -04:00
parent 0069c0c5fa
commit 7a78449f6d

View File

@@ -685,15 +685,12 @@ Transactor::checkSign(
}
// Check Single Sign
// This ternary is only needed to handle `simulate`
XRPL_ASSERT(
!pkSigner.empty(),
"ripple::Transactor::checkSingleSign : non-empty signer or simulation");
!pkSigner.empty(), "ripple::Transactor::checkSign : non-empty signer");
if (!publicKeyType(makeSlice(pkSigner)))
{
JLOG(ctx.j.trace())
<< "checkSingleSign: signing public key type is unknown";
JLOG(ctx.j.trace()) << "checkSign: signing public key type is unknown";
return tefBAD_AUTH; // FIXME: should be better error!
}
@@ -823,7 +820,6 @@ Transactor::checkSingleSign(
return tesSUCCESS;
}
// TODO generalize
NotTEC
Transactor::checkMultiSign(
PreclaimContext const& ctx,