From 7a78449f6d319e21d5ce09a41d9611cc12a54b2f Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Thu, 4 Sep 2025 15:53:04 -0400 Subject: [PATCH] Fix minor review feedback from @Bronek - Clean up assert, log, and comments --- src/xrpld/app/tx/detail/Transactor.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/xrpld/app/tx/detail/Transactor.cpp b/src/xrpld/app/tx/detail/Transactor.cpp index 14faffd048..6da22de9fb 100644 --- a/src/xrpld/app/tx/detail/Transactor.cpp +++ b/src/xrpld/app/tx/detail/Transactor.cpp @@ -685,15 +685,12 @@ Transactor::checkSign( } // Check Single Sign - // This ternary is only needed to handle `simulate` XRPL_ASSERT( - !pkSigner.empty(), - "ripple::Transactor::checkSingleSign : non-empty signer or simulation"); + !pkSigner.empty(), "ripple::Transactor::checkSign : non-empty signer"); if (!publicKeyType(makeSlice(pkSigner))) { - JLOG(ctx.j.trace()) - << "checkSingleSign: signing public key type is unknown"; + JLOG(ctx.j.trace()) << "checkSign: signing public key type is unknown"; return tefBAD_AUTH; // FIXME: should be better error! } @@ -823,7 +820,6 @@ Transactor::checkSingleSign( return tesSUCCESS; } -// TODO generalize NotTEC Transactor::checkMultiSign( PreclaimContext const& ctx,