Ed Hennis
da396070ce
Address review feedback from @TimothyBanks and @gregtatcam
...
- Remove unnecessary if constexpr check
- Update scaling static_assert
- Remove unnecessary rounding logic from Number::Guard::doRound()
- Handle fractional rounding between kMaxRep and kMaxRepUp
2026-06-18 17:57:21 -04:00
Ed Hennis
6179b054c9
Merge remote-tracking branch 'XRPLF/ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
...
* XRPLF/ximinez/number-round-maxrep-down:
clang-tidy: Remove unused header
2026-06-18 13:18:07 -04:00
Ed Hennis
d373cb5db8
clang-tidy: Remove unused header
2026-06-18 13:16:16 -04:00
Ed Hennis
39d85076c4
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-17 21:50:55 -04:00
Ed Hennis
14a43cfc35
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-17 21:46:24 -04:00
Ed Hennis
6504042b8d
Review feedback from @TimothyBanks and @gregtatcam
...
- Get rid of MantissaRange::getRanges() function. Rewrite
getMantissaScale to use all constexpr values.
- In Number::Guard::round(), document the "intentional" shadowing of
"mode", and simplify one of the checks. Add an assert.
2026-06-17 21:45:56 -04:00
yinyiqian1
772ea80a25
fix: Use template for granular delegation permissions ( #6613 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-06-17 23:20:54 +00:00
Ed Hennis
069fc99b6a
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-17 15:01:40 -04:00
Ed Hennis
cebd4ecf15
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-17 15:01:35 -04:00
Pratik Mankawde
7e0ff536f5
refactor: Rerevert "Explicitly trim the heap after cache sweeps ( #6022 )"
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 13:31:43 +01:00
Pratik Mankawde
044ca7719d
release: Bump version to 3.3.0-b0
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:58:01 +01:00
Pratik Mankawde
cccce1c32e
Merge remote-tracking branch 'origin/release/3.2.x' into pratik/merge_3.2.x
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-06-17 12:53:02 +01:00
Ed Hennis
b16a761efc
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-16 18:56:17 -04:00
Ed Hennis
554bb62a65
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-15 20:31:43 -04:00
Ayaz Salikhov
3c43f4614f
release: Bump version to 3.2.0
2026-06-15 19:46:56 -04:00
Bart
0ac8e6cf1e
release: Bump version to 3.2.0-rc6
2026-06-15 22:24:03 +01:00
Vito Tumas
ed5f13481a
fix: Disable transaction invariants
2026-06-15 22:24:03 +01:00
Vito Tumas
781ef175c9
perf: Dispatch "hasInvalidAmount()" on type tag instead of dynamic_cast
2026-06-15 22:24:03 +01:00
Ed Hennis
e5785c4fcb
fix: Fix Number comparison operator
2026-06-15 22:24:02 +01:00
Bart
61dae6f792
release: Bump version to 3.2.0-rc5
2026-06-15 22:24:02 +01:00
yinyiqian1
fded06652a
fix: Add zero NFT Offer ID check for NFTokenCancelOffer
2026-06-15 22:24:02 +01:00
Valentin Balaschenko
e833e8884d
refactor: Revert "Explicitly trim the heap after cache sweeps ( #6022 )"
2026-06-15 22:24:02 +01:00
Sergey Kuznetsov
47b06ecd17
refactor: Use rocksdb includes only when it is available
2026-06-15 22:23:54 +01:00
Bart
5a25c9188b
release: Bump version to 3.2.0-rc4
2026-06-15 22:23:53 +01:00
Pratik Mankawde
f98c251011
refactor: Improve tracking of book (un)subscriptions
2026-06-15 22:23:38 +01:00
Sergey Kuznetsov
e29dc474b3
refactor: Improve payment channel closing and returned error codes
2026-06-15 22:23:28 +01:00
Pratik Mankawde
2728e11809
fix: Set request size limits and differential pricing for get-object-by-hash calls
2026-06-15 22:23:28 +01:00
Jingchen
9650fe8a6e
refactor: Use explicit types to help compiler
2026-06-15 22:22:53 +01:00
Ed Hennis
2f59cb0372
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-15 15:28:59 -04:00
Ed Hennis
6bc267c112
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-15 15:28:55 -04:00
Pratik Mankawde
2df96b1550
fix: Silence UBSan diagnostics in the ubsan build config ( #7531 )
...
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com >
2026-06-15 19:25:37 +00:00
Ed Hennis
51781c4cae
Merge remote-tracking branch 'XRPLF/ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
...
* XRPLF/ximinez/number-round-maxrep-down:
Clean up some comments, coverage exclusions, and an assert
2026-06-15 15:01:47 -04:00
Ed Hennis
8f51891631
Use constexpr in one more place
2026-06-15 14:57:39 -04:00
Ed Hennis
a8f4d790bd
Clean up some comments, coverage exclusions, and an assert
2026-06-15 14:05:44 -04:00
Ed Hennis
685367248c
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-15 12:12:15 -04:00
Ed Hennis
bebddb0e3e
Merge branch 'develop' into ximinez/number-round-maxrep-down
2026-06-15 12:12:10 -04:00
Zhiyuan Wang
b34aa84e5a
fix: Check Fee-Free Division by Zero in AMMWithdraw singleWithdrawEPrice ( #6989 )
2026-06-15 15:31:22 +00:00
Bart
f5985e73ec
fix: Always charge peer on strand ( #7422 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-06-15 14:55:56 +00:00
Ed Hennis
22a7f5bb49
Fix assertion typo src/libxrpl/basics/Number.cpp
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-12 19:44:08 -04:00
Ed Hennis
a63bab2a5e
Cleanups: Comments, variable names, one test case
...
- "ToNearest and Downward behavior Small" test case
2026-06-12 19:38:07 -04:00
Ed Hennis
095e14193e
Apply suggestions from AI code review
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-12 19:29:01 -04:00
Ed Hennis
305977058b
Merge remote-tracking branch 'XRPLF/ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
...
* XRPLF/ximinez/number-round-maxrep-down:
Apply suggestions from AI code review
2026-06-12 19:08:04 -04:00
Ed Hennis
b30a70bbf8
Apply suggestions from AI code review
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-06-12 18:44:00 -04:00
Ed Hennis
1ef0c5ab44
Merge branch 'ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
2026-06-11 23:02:58 -04:00
Ed Hennis
463fb88cd8
Apply suggestions from AI code review
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-11 23:02:47 -04:00
Ed Hennis
353b3ae07d
fixup! AI: Remove extranenous enum copy
2026-06-11 23:00:08 -04:00
Ed Hennis
b2790e2f50
AI: Remove extranenous enum copy
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-06-11 22:57:31 -04:00
Ed Hennis
f8f899dd8a
Merge remote-tracking branch 'XRPLF/ximinez/number-round-maxrep-down' into ximinez/number-round-maxrep
...
* XRPLF/ximinez/number-round-maxrep-down:
Change placeholder "fixNumberStuff" to "fixCleanup3_3_0"
test: Add null check unit test for `Oracle::aggregatePrice` (7306)
ci: Patch conan recipe for Nix to be able to use on macOS (7532)
ci: Run sanitizers on release builds too (7527)
fix: Correct hybrid offer deletion on credential expiry (6843)
ci: Make sanitizer flags lists in the profile, not a string (7449)
ci: Make configurations launch on certain event types (7447)
fix: Add [[maybe_unused]] to fix320Enabled for assert=OFF builds (7446)
ci: Add `gh` and `file` to nix packages (7444)
fix: Disable transaction invariants (7409)
perf: Dispatch "hasInvalidAmount()" on type tag instead of dynamic_cast (7402)
refactor: Retire fixUniversalNumber amendment (5962)
test: Do not create data directory for memory databases (7323)
ci: Launch upload-conan-deps on profile change (7442)
2026-06-11 22:55:31 -04:00
Ed Hennis
308e00f590
Merge commit 'b087545' into ximinez/number-round-maxrep
...
* commit 'b087545':
Number improvements
test: Add more Number edge case tests, showing failures
2026-06-11 22:48:22 -04:00
Ed Hennis
29d017c2a3
Change placeholder "fixNumberStuff" to "fixCleanup3_3_0"
2026-06-11 22:02:50 -04:00