Vito
d9487a02bb
Merge remote-tracking branch 'origin/tapanito/lending-fix-amendment' into tapanito/vault-share-pricing
2026-03-24 14:14:11 +01:00
Vito
df8bfbe5af
fix: errors introduced post-merge
2026-03-24 12:37:06 +01:00
Vito
347d1a19ef
Merge remote-tracking branch 'origin/develop' into tapanito/lending-fix-amendment
2026-03-24 12:35:50 +01:00
Vito
a5ce36ea42
refactor: docstrings, state validation, v1 routing tests
2026-03-24 12:33:02 +01:00
Vito
8f7a813ac1
refactor: add borrowFromVault helper with state validation
2026-03-24 11:53:04 +01:00
Vito
c0fc689113
refactor: add vault interest unrealized invariants
2026-03-24 11:52:28 +01:00
Mayukha Vadari
8b986e4ab0
refactor: Improve imports to only call the needed helpers ( #6624 )
2026-03-24 10:20:32 +00:00
Olek
dcfcdab14e
fix: Remove superfluous view update from credentials ( #6545 )
2026-03-23 18:29:34 +00:00
Mayukha Vadari
e0dbe90370
refactor: Move ledger entry helper functions from View.h/View.cpp to dedicated helper files ( #6453 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-23 15:39:58 +00:00
dependabot[bot]
c463d0ff06
ci: [DEPENDABOT] bump codecov/codecov-action from 5.5.2 to 5.5.3 ( #6615 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-23 14:04:22 +00:00
Mayukha Vadari
be1cc48d84
fix: Assorted Oracle fixes ( #6570 )
2026-03-22 18:08:18 +00:00
Vito Tumas
d65fab27a1
Merge branch 'develop' into tapanito/lending-fix-amendment
2026-03-21 14:39:10 +01:00
Ayaz Salikhov
cf2eb149ee
fix: Update .git-blame-ignore-revs ( #6577 )
2026-03-19 22:48:20 +00:00
Ayaz Salikhov
762922a07f
chore: Don't allow files more than 400kb to be added to the repo ( #6597 )
2026-03-19 21:20:56 +00:00
Bart
fd28656ded
ci: Check for signed commits in PR ( #6559 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-19 17:38:09 +00:00
Ayaz Salikhov
9316da784a
ci: Update XRPLF/actions ( #6594 )
2026-03-19 17:29:22 +00:00
Vito
a8914da275
refactor: document rounding behaviour, consolidate deposit NAV check
2026-03-19 17:48:08 +01:00
Vito
59148bb7a5
refactor: vault share pricing safety and Expected API
2026-03-19 12:35:33 +01:00
Michael Legleux
6efd31229a
fix: Use correct format and event for workflows for release tags ( #6554 )
2026-03-19 10:23:51 +00:00
Alex Kremer
12954d5392
fix: Address remaining issue after clang-tidy merge ( #6582 )
2026-03-18 22:41:09 +00:00
Jingchen
b1e5ba0518
feat: Add code generator for transactions and ledger entries ( #6443 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-18 21:11:51 +00:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Ayaz Salikhov
804a351773
ci: Use external action implementation of check-pr-title ( #6578 )
2026-03-18 18:31:42 +00:00
Ayaz Salikhov
697fb64e8c
ci: Don't check PR title for drafts ( #6573 )
2026-03-18 17:46:27 +00:00
Vito
bf2dbe11bf
Merge remote-tracking branch 'origin/tapanito/lending-fix-amendment' into tapanito/vault-share-pricing
2026-03-18 18:43:00 +01:00
Vito Tumas
b5d25c5ab1
Merge branch 'develop' into tapanito/lending-fix-amendment
2026-03-18 18:39:43 +01:00
Vito
7dcbb7b215
refactor: inline v2 math into SLE wrappers, remove public math::v2 namespace
...
The separate pure-math functions added unnecessary indirection since
they won't be unit-tested directly. Inline the arithmetic back into
the v2 SLE wrappers to match v1's pattern.
2026-03-18 18:38:16 +01:00
Vito Tumas
52afb76fd8
Merge branch 'tapanito/lending-fix-amendment' into tapanito/vault-share-pricing
2026-03-18 18:23:19 +01:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Mayukha Vadari
b92a9a3053
fix: Make assorted NFT fixes ( #6566 )
...
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
2026-03-18 14:47:59 +00:00
Mayukha Vadari
dcaef828b4
refactor: Replace !=/== tesSuccess with using isTesSuccess ( #6409 )
...
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
2026-03-18 14:15:10 +00:00
yinyiqian1
6fbeb04d9e
fix: Disallow empty permission list when Delegate object is absent ( #6542 )
...
This change fixes delegation:
* If the Delegate object is not present, we should disallow empty permission list in DelegateSet preclaim.
* Empty permission list is only allowed to delete the existing Delegate object.
* In `doApply`, permission list being empty returns `tecINTERNAL`, which should not happen.
2026-03-18 13:39:31 +00:00
Alex Kremer
2a325e7e2c
chore: Enable clang-tidy bugprone-use-after-move check ( #6476 )
2026-03-18 00:12:06 +00:00
Bart
808e814489
ci: Update check-pr-title action hash ( #6572 )
2026-03-17 23:26:01 +00:00
Copilot
9e14707e77
fix: Peer crawler port field type inconsistency ( #6318 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-17 22:03:56 +00:00
Mayukha Vadari
95a45d7442
chore: Add comment explaining why ammLPHolds is called twice ( #6546 )
2026-03-17 20:11:36 +00:00
Bart
5fc4ab3e37
ci: Let required runs be triggered by merge group events ( #6563 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-17 20:03:48 +00:00
tequ
b129b71c33
refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() ( #6560 )
2026-03-17 15:56:51 -04:00
tequ
013c2d6a56
refactor: Add const qualifier to SLE in verifyDepositPreauth parameter ( #6555 )
2026-03-17 19:33:18 +00:00
Vito
57d31c3842
adds initial vault valuation hsare implementation
2026-03-17 20:23:03 +01:00
Alex Kremer
72f4cb097f
refactor: Enable remaining clang-tidy cppcoreguidelines checks ( #6538 )
2026-03-17 19:09:05 +00:00
Vito
b45068b9dd
refactor: separate vault share pricing into versioned namespaces
...
Move vault pricing helpers from xrpl namespace into xrpl::vault with
amendment-gated dispatch (fixLendingProtocolV1_1). Extract v2 pure math
into public xrpl::vault::math::v2 for unit testability. v1 logic is
intentionally left as-is to avoid risk since Single Asset Vault is
already released.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
2026-03-17 20:07:23 +01:00
Michael Legleux
b523770486
fix: Remove nonexistent boost::coroutine2 library ( #6561 )
2026-03-17 18:46:46 +00:00
Mayukha Vadari
a5185890ff
refactor: Remove dead code in escrow helper logic ( #6553 )
2026-03-17 18:13:08 +00:00
Jingchen
0a9513e7f3
ci: Fix build errors on Windows ( #6562 )
2026-03-17 13:50:44 -04:00
Mayukha Vadari
78b2d70a11
refactor: Assorted small DID fixes ( #6552 )
...
This change:
* Makes `addSLE` in `DIDSet` a static function, instead of a free function.
* Renames `Attestation` to `Data` everywhere (an artifact of a previous name for the field).
* Actually runs a set of tests that were not included in the `run` function of `DID_test`.
2026-03-17 14:44:07 +00:00
Mayukha Vadari
252c6768df
refactor: Clean up getFeePayer, mSourceBalance, and mPriorBalance ( #6478 )
...
This change:
* Introduces a new helper function on `STTx`, `getFeePayer`.
* Removes the usage of `mSourceBalance` and replaces it with SLE balance lookups.
* Renames `mPriorBalance` to `preFeeBalance_`
This simplifies some of the code in the transactors and makes it a lot more readable.
2026-03-17 14:12:16 +00:00
Pratik Mankawde
5ae97fa8ae
refactor: Add no-ASAN macro for Throw statements ( #6373 )
...
Throwing exceptions from code sometime confuses ASAN, as it cannot keep track of stack frames. This change therefore adds a macro to skip instrumentation around the `Throw` function.
2026-03-17 13:10:32 +00:00
Pratik Mankawde
eff344faf9
chore: Move sanitizer runtime options out to files ( #6371 )
...
This change moves the sanitizer runtime options out to dedicated files, such that they can be used in multiple places (CI, local runs) without any need to rewrite them.
2026-03-17 11:22:49 +00:00
Alex Kremer
7e7b71d84c
chore: Fix tests for clang-tidy bugprone-unchecked-optional-access check ( #6502 )
2026-03-16 19:47:40 -04:00