Ed Hennis
cd0f49a003
Address more nitpicky AI comments
2026-05-07 17:05:10 -04:00
Ed Hennis
22d2703ce8
What is it going to take to get clang-tidy to shut up?
2026-05-07 16:50:43 -04:00
Ed Hennis
d03274b731
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-07 14:18:28 -04:00
Ed Hennis
1b6047afe1
More clang-tidy changes: AMMExtended_test member and Number_test includes
2026-05-07 13:51:48 -04:00
Ed Hennis
175a04160d
Merge branch 'develop' into ximinez/number-fix-maxrepcusp
2026-05-07 13:28:33 -04:00
Ayaz Salikhov
4a9f72c73e
style: Make .clang-tidy style a bit more consistent with Clio ( #7096 )
2026-05-07 17:14:01 +00:00
Alex Kremer
7afdd71a54
chore: More fixes for bad renames ( #7092 )
2026-05-07 17:04:30 +00:00
Olek
af89854a43
fix: Stop tx processing if failed to delete expired credentials ( #6715 ) ( #6962 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-07 12:57:50 +00:00
Ed Hennis
d6c4e6cb93
fix: Cap the base fee for LoanPay ( #6969 ) ( #6970 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-07 12:48:55 +00:00
Bronek Kozicki
d67e06102a
chore: Upgrade Clang sanitizer to clang-22 and switch gcc-15 sanitizer to Release ( #7079 )
2026-05-07 10:36:36 +00:00
Bart
8c71ec803d
fix: Restore clang-tidy change to section name in config ( #7091 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-07 10:34:47 +00:00
Ed Hennis
b050c151f8
Fix clang-tidy issues, and more AI complaints
2026-05-06 23:26:11 -04:00
Ed Hennis
a2b21d75ce
Fix AI-identified mistakes
2026-05-06 22:56:07 -04:00
Ed Hennis
b40d2a8e7d
fix: Fix a rounding error at the Number::maxRep cusp
...
- Add helper function, doDropDigit, to wrap the common pattern:
push(mantissa % 10);
mantissa /= 10;
++exponent;
- Might have been helpful to catch this issue when developing.
2026-05-06 22:49:44 -04:00
Ayaz Salikhov
8e2aa33f64
chore: Add IWYU pragma for boost::optional to fix clang-tidy ( #7088 )
2026-05-06 23:31:10 +00:00
Ayaz Salikhov
13b72a4120
chore: Update zlib to 1.3.2, sqlite to 3.53.0, libarchive to 3.8.7, jemalloc to 5.3.1, boost to 1.91.0 ( #7084 )
2026-05-06 17:05:11 +00:00
Ayaz Salikhov
fcae50a487
chore: Update conan.lock ( #7081 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-06 14:36:42 +00:00
Vito Tumas
a4720d0449
chore: Mark empty transactor invariants as future work ( #7080 )
2026-05-06 12:55:24 +00:00
Vet
50244a8637
chore: Update default values of base and owner reserve to 1/0.2 ( #6382 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-05-06 11:19:57 +00:00
Mayukha Vadari
5e1c35f7f7
fix: Fix regressions in server_definitions ( #7008 )
2026-05-05 17:18:26 +00:00
Ayaz Salikhov
27f7fdb3a6
chore: Do not duplicate sanitizer flags ( #7058 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-05 16:32:43 +00:00
Ayaz Salikhov
6e6fb9cdf3
ci: Run pre-commit on diff in clang-tidy workflow ( #7078 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-05 16:31:46 +00:00
Ayaz Salikhov
e092c52409
ci: Use XRPLF/create-issue ( #7076 )
2026-05-05 13:49:13 +00:00
Ayaz Salikhov
d050073842
ci: Rewrite clang-tidy workflow(s) in a reusable manner ( #7062 )
2026-05-04 12:51:07 +00:00
Alex Kremer
8490206228
chore: Ignore identifier-naming update in git blame ( #7066 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-05-03 21:42:44 +00:00
Alex Kremer
8995564ed6
refactor: Enable clang-tidy readability-identifier-naming check ( #6571 )
2026-05-03 10:31:53 +00:00
Bart
182d844996
refactor: Revert certain Throws by LogicErrors ( #7036 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-05-01 09:50:00 +00:00
Ayaz Salikhov
37b895b678
ci: Rename print-env -> print-build-env ( #7061 )
2026-05-01 09:44:52 +00:00
Pratik Mankawde
c6053f5d64
fix: Gate -mcmodel flags to x86_64 in sanitizer builds ( #7049 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 13:33:33 +00:00
Vito Tumas
31180f94c2
fix: Prevents overwriting a bool value in an invariant ( #6609 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-30 13:05:09 +00:00
Pratik Mankawde
6407f0fa52
fix: Address code review comments regarding boost::coroutine2 ( #6977 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-04-30 10:36:12 +00:00
Bart
4d0ea8ae36
refactor: Apply various minor improvements and corrections ( #7045 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-30 10:22:11 +00:00
Zhiyuan Wang
dbd646bd53
fix: Store Delegate object in delegating and authorized account directories for proper deletion ( #6681 )
2026-04-29 18:17:01 +00:00
Ayaz Salikhov
6ae090ba45
ci: Use print-env from XRPLF/actions ( #7052 )
2026-04-29 18:14:16 +00:00
Mayukha Vadari
7be98d95de
fix: Make assorted RPC fixes ( #6529 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-29 18:05:34 +00:00
Alex Kremer
f7275b7ad9
chore: Enable clang-tidy v21 new checks ( #7031 )
2026-04-29 15:17:35 +00:00
Jingchen
46b997b774
feat: Create new transaction testing framework TxTest ( #6537 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com >
2026-04-28 14:16:10 +00:00
Vito Tumas
147da57348
feat: Add cleanup amendment for 3.2.0 ( #7037 )
2026-04-28 10:22:32 +00:00
Pratik Mankawde
3547112540
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-27 20:34:16 +00:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Pratik Mankawde
158df5394c
fix: Resolve MSVC Debug build failure in JobQueue.h; re-enable _CRTDBG_MAP_ALLOC in CI ( #6993 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-24 16:47:16 +00:00
Zhiyuan Wang
a6bd9251d2
docs: Update hybrid offer invariant comment ( #7007 )
2026-04-24 16:35:10 +00:00
Mayukha Vadari
9ae29612ea
fix: Fix flaky CI tests ( #7005 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-24 13:23:43 +00:00
Mayukha Vadari
82abf2a849
docs: Update bug bounty information ( #7006 )
2026-04-24 13:15:12 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Jingchen
7a449edebb
refactor: Clean up NetworkOPs ( #6575 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
2026-04-23 17:59:49 +00:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Jingchen
7cd503859e
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-04-23 13:59:23 +00:00
Alex Kremer
b41cbb08c6
chore: Add pre-commit hook to fix include style ( #6995 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-22 22:20:14 +00:00