Ed Hennis
b230b073aa
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-28 16:23:28 -04:00
Jingchen
46b997b774
feat: Create new transaction testing framework TxTest ( #6537 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com >
2026-04-28 14:16:10 +00:00
Vito Tumas
147da57348
feat: Add cleanup amendment for 3.2.0 ( #7037 )
2026-04-28 10:22:32 +00:00
Pratik Mankawde
3547112540
fix: Fix ubsan flagged issues ( #6151 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-27 20:34:16 +00:00
Ed Hennis
23c40cc54f
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-25 14:45:44 -04:00
Alex Kremer
4dc923dcc5
chore: Enable clang-tidy modernize-use-nodiscard check ( #7015 )
2026-04-24 17:19:30 +00:00
Pratik Mankawde
158df5394c
fix: Resolve MSVC Debug build failure in JobQueue.h; re-enable _CRTDBG_MAP_ALLOC in CI ( #6993 )
...
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-24 16:47:16 +00:00
Zhiyuan Wang
a6bd9251d2
docs: Update hybrid offer invariant comment ( #7007 )
2026-04-24 16:35:10 +00:00
Mayukha Vadari
9ae29612ea
fix: Fix flaky CI tests ( #7005 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-24 13:23:43 +00:00
Mayukha Vadari
82abf2a849
docs: Update bug bounty information ( #7006 )
2026-04-24 13:15:12 +00:00
Mayukha Vadari
7cfa5d4610
fix: Make assorted Payments fixes ( #6585 )
2026-04-24 12:56:50 +00:00
Mayukha Vadari
248cb29681
refactor: Move LendingHelpers into libxrpl/ledger/helpers ( #6638 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-24 12:06:26 +00:00
Ed Hennis
114278ce3f
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-23 15:56:00 -04:00
Jingchen
7a449edebb
refactor: Clean up NetworkOPs ( #6575 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
2026-04-23 17:59:49 +00:00
Alex Kremer
19da25812b
fix: Remaining clang-tidy unchecked optionals ( #6979 )
2026-04-23 16:21:01 +00:00
Jingchen
7cd503859e
refactor: Remove seq from TMGetObjectByHash ( #6976 )
2026-04-23 13:59:23 +00:00
Ed Hennis
8f9425f91f
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-22 23:39:47 -04:00
Alex Kremer
b41cbb08c6
chore: Add pre-commit hook to fix include style ( #6995 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-22 22:20:14 +00:00
pdp2121
bd1b126230
feat: Add --definitions flag and artifact ( #6858 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-22 20:10:52 +00:00
Ed Hennis
cf9128f94f
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-22 14:49:03 -04:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Ed Hennis
f314f6efe1
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-22 13:10:33 -04:00
Alex Kremer
4ab20770f7
chore: Optionally run clang-tidy via pre-commit ( #6680 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-22 15:06:36 +00:00
Vito Tumas
2e307329f0
refactor: Add transaction-specific invariant checking ( #6551 )
2026-04-22 14:41:19 +00:00
Ayaz Salikhov
3429845c40
style: Add bashate pre-commit hook to unify bash style ( #6994 )
2026-04-22 14:26:02 +00:00
Ed Hennis
569baada85
AI review feedback: don't specify "seq", and don't call "env.jt" twice
2026-04-21 20:17:40 -04:00
Ed Hennis
6d5c944c15
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-21 18:35:38 -04:00
Ed Hennis
50003403a8
Fix clang-tidy complaint
2026-04-21 18:25:25 -04:00
Ed Hennis
a7d17f3bbf
Fix missed ripple -> xrpl rename
2026-04-21 18:19:35 -04:00
Ed Hennis
e427d3a4d5
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-21 15:20:15 -04:00
Ed Hennis
bf62b6efd7
Review feedback from @vlntb: Add tests, fix bug
...
- Add test cases to exercise the LoanPay fee cap calculation
- Fix a bug in the fee cap calculation.
2026-04-21 15:16:43 -04:00
Alex Kremer
7c7c1894b9
chore: Add -fix to clang-tidy invocation ( #6990 )
2026-04-21 19:00:00 +00:00
Jingchen
45d4aacb53
chore: Remove empty Taker.h ( #6984 )
2026-04-21 18:15:58 +00:00
Ed Hennis
c31251e6d8
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-21 11:33:40 -04:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Ayaz Salikhov
ab887f5049
ci: Upload clang-tidy git diff ( #6983 )
2026-04-21 14:22:33 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
Ed Hennis
24d850d637
fixup! fix: base max fee on max payment increments
2026-04-20 20:03:48 -04:00
Ed Hennis
9315d246bf
fix: base max fee on max payment increments
...
- Old and busted: Computing max fee as loanMaximumPaymentsPerTransaction * normalCost;
- New hotness: Computing max fee increments as
loanMaximumPaymentsPerTransaction / loanPaymentsPerFeeIncrement,
then computing max fee as
maxFeeIncrements * normalCost,
if payment amount >= maxFeeIncrements * periodicPayment.
2026-04-20 19:39:34 -04:00
Ed Hennis
f83127d447
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-20 17:49:38 -04:00
yinyiqian1
4b198cd5bb
fix: Disallow MPTClearRequireAuth if is set ( #6712 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-20 21:25:52 +00:00
Ed Hennis
92f8de4b51
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-20 15:44:55 -04:00
Alex Kremer
726f20c8f6
feat: Add GRPC TLS support ( #6374 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-04-20 17:12:14 +00:00
Zhiyuan Wang
96643bb0fa
fix: Check for empty sfAdditionalBooks array in hybrid offer invariant ( #6716 )
2026-04-20 17:10:28 +00:00
chuanshanjida
e83818241a
chore: Remove repetitive word in multiple files ( #6978 )
...
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
2026-04-20 16:56:03 +00:00
Ed Hennis
7c248f3fe6
Merge branch 'develop' into ximinez/loanpay-fee-overflow-develop
2026-04-20 11:38:49 -04:00
Ayaz Salikhov
852fbe955d
ci: Add workflow to check PR description has been filled ( #6965 )
2026-04-20 12:12:58 +00:00
dependabot[bot]
b33d0a0479
ci: [DEPENDABOT] Bump tj-actions/changed-files from 47.0.5 to 47.0.6 ( #6973 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-04-20 11:20:42 +00:00
Ed Hennis
669617af99
Cap the base fee for LoanPay based on loanMaximumPaymentsPerTransaction
2026-04-17 19:11:18 -04:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00