yinyiqian1
be8de20a0b
Merge branch 'develop' into merge-ct2
2026-04-23 00:41:44 -04:00
yinyiqian1
235547f460
Revert "Merge develop into ConfidentialTransfer ( #6987 )" ( #7001 )
2026-04-22 23:57:01 -04:00
yinyiqian1
1e73f3f3ff
Merge develop into ConfidentialTransfer ( #6987 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com >
Co-authored-by: chuanshanjida <chuanshanjida@outlook.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-04-22 23:34:03 -04:00
Shawn Xie
2b65b740d0
Add destination tag to ConfidentialMPTSend ( #6988 )
2026-04-22 17:07:31 -04:00
Mayukha Vadari
1c6cdc653c
fix: More clang-tidy issues ( #6992 )
2026-04-22 17:42:15 +00:00
Alex Kremer
ce3951bbb3
chore: Enable clang-tidy modernize checks ( #6975 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-21 15:32:51 +00:00
Alex Kremer
ea023121f5
fix: Add rounding to Vault invariants ( #6217 ) ( #6955 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-04-21 12:14:07 +00:00
yinyiqian1
f08121de35
Address coding style comments ( #6966 )
2026-04-20 13:31:09 -04:00
Alex Kremer
653a383ff5
chore: Enable clang-tidy include cleaner ( #6947 )
2026-04-17 16:43:49 +00:00
Alex Kremer
f1a5ba43ad
chore: Enable clang-tidy readability checks ( #6930 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-17 13:30:52 +00:00
yinyiqian1
09778f2fec
Support compact AND-composed sigma proof ( #6859 )
2026-04-16 17:51:31 -04:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Shawn Xie
5229ff5a45
fix: fix pipeline failures ( #6850 )
2026-04-10 13:42:59 -04:00
Shawn Xie
6f4fddc1ae
Merge remote-tracking branch 'upstream/develop' into ct-merge-mpt-dex
2026-04-09 11:05:31 -04:00
Peter Chen
4ae17f193f
Add JS fields required for Clio mpt_holder_api ( #6810 )
2026-04-09 10:49:10 -04:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Shawn Xie
042b09563b
Merge remote-tracking branch 'upstream/develop' into ct-merge
2026-04-06 11:57:06 -04:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Bart
7f53351920
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-31 15:38:04 +00:00
yinyiqian1
6f1232140b
remove dead functions due to integration ( #6683 )
2026-03-30 16:37:55 -04:00
Alex Kremer
ab8c168e3b
chore: Enable remaining clang-tidy performance checks ( #6648 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-03-30 17:08:47 +00:00
Jingchen
3a477e4d01
refactor: Address PR comments after the modularisation PRs ( #6389 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-30 15:22:38 +00:00
yinyiqian1
2472ef7df7
Integrate mpt-crypto SDK lib for on-chain verification ( #6679 )
2026-03-27 16:26:37 -04:00
Shawn Xie
b34ecc476a
Add ProofReader and auth/lock and overflow edge case checks ( #6651 )
2026-03-26 13:16:51 -04:00
Vito Tumas
b9d07730f3
feat: Add placeholder amendment for assorted bug fixes ( #6652 )
2026-03-25 23:54:33 +00:00
Jingchen
8f182e825a
refactor: Modularise ledger ( #6536 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
Co-authored-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com >
2026-03-25 16:32:45 +00:00
Alex Kremer
0eedefbf45
refactor: Enable more clang-tidy readability checks ( #6595 )
...
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com >
2026-03-24 15:42:12 +00:00
Shawn Xie
4c0e6012e3
Handle edge cases checks in flag setting and token deletion ( #6596 )
2026-03-24 11:41:27 -04:00
Shawn Xie
a43cf94ff7
update sfBlindingFactor to type uint256 and refactor helper functions to return std::optional
2026-03-19 14:04:03 -04:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Copilot
9e14707e77
fix: Peer crawler port field type inconsistency ( #6318 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-17 22:03:56 +00:00
Alex Kremer
72f4cb097f
refactor: Enable remaining clang-tidy cppcoreguidelines checks ( #6538 )
2026-03-17 19:09:05 +00:00
Shawn Xie
9f4cf28aea
Rename privacy flag and public key names ( #6550 )
...
Corresponding spec change:
https://github.com/XRPLF/XRPL-Standards/pull/501
### Field Renames (SFields)
| Before | After |
|--------|-------|
| `sfIssuerElGamalPublicKey` | `sfIssuerEncryptionKey` |
| `sfHolderElGamalPublicKey` | `sfHolderEncryptionKey` |
| `sfAuditorElGamalPublicKey` | `sfAuditorEncryptionKey` |
### Flag Renames
#### Transaction Flags (`tf`)
| Before | After |
|--------|-------|
| `tfMPTCanPrivacy` | `tfMPTCanConfidentialAmount` |
#### Ledger State Flags (`lsf`)
| Before | After |
|--------|-------|
| `lsfMPTCanPrivacy` | `lsfMPTCanConfidentialAmount` |
#### Ledger State Mutable Flags (`lsmf`)
| Before | After |
|--------|-------|
| `lsmfMPTCannotMutatePrivacy` |
`lsmfMPTCannotMutateCanConfidentialAmount` |
#### Transaction Mutable Flags (`tmf`)
| Before | After |
|--------|-------|
| `tmfMPTCannotMutatePrivacy` |
`tmfMPTCannotMutateCanConfidentialAmount` |
| `tmfMPTSetPrivacy` | `tmfMPTSetCanConfidentialAmount` |
| `tmfMPTClearPrivacy` | `tmfMPTClearCanConfidentialAmount` |
2026-03-17 10:53:17 -04:00
Mayukha Vadari
78b2d70a11
refactor: Assorted small DID fixes ( #6552 )
...
This change:
* Makes `addSLE` in `DIDSet` a static function, instead of a free function.
* Renames `Attestation` to `Data` everywhere (an artifact of a previous name for the field).
* Actually runs a set of tests that were not included in the `run` function of `DID_test`.
2026-03-17 14:44:07 +00:00
Mayukha Vadari
252c6768df
refactor: Clean up getFeePayer, mSourceBalance, and mPriorBalance ( #6478 )
...
This change:
* Introduces a new helper function on `STTx`, `getFeePayer`.
* Removes the usage of `mSourceBalance` and replaces it with SLE balance lookups.
* Renames `mPriorBalance` to `preFeeBalance_`
This simplifies some of the code in the transactors and makes it a lot more readable.
2026-03-17 14:12:16 +00:00
Bart
ffea3977f0
refactor: Rename system name from 'ripple' to 'xrpld' ( #6347 )
...
Per [XLS-0095](https://xls.xrpl.org/xls/XLS-0095-rename-rippled-to-xrpld.html ), we are taking steps to rename ripple(d) to xrpl(d). This change modifies the system name from `rippled` to `xrpld`.
The system name is used in limited places:
* When no explicit config file is passed via the `--config` flag, then the system name is used to construct the path where the config file and database may be stored, via the `$XDG_CONFIG_HOME` and `$XDG_DATA_HOME` directories, respectively.
* It is used in the metadata and user-agent as part of RPC calls.
* It is newly used in the full version string.
2026-03-16 21:51:31 +00:00
Alex Kremer
47a235b7be
chore: Enable clang-tidy switch-missing-default-case check ( #6461 )
2026-03-16 17:19:37 -04:00
Shawn Xie
d615098849
refactor: improve readability and clean up code from review comments ( #6544 )
2026-03-16 10:47:39 -04:00
Pratik Mankawde
1738a69619
refactor: Delete SecretKey compare op from library and move it to tests module ( #6503 )
...
This change deletes the `SecretKey` equality/inequality operators from the public library header and moves the comparison logic into test-only code.
Specifically, the `operator==` and `operator!=` free functions on `SecretKey` have been removed from `include/xrpl/protocol/SecretKey.h` and have been replaced with explicitly deleted member functions to prevent accidental use in production code. A named `test::equal()` helper has also been added in `src/test/unit_test/utils.h` for test assertions that need to compare secret keys.
2026-03-16 10:55:12 +00:00
Bronek Kozicki
0446bef7e5
feat: Enforce feature name lengths and character set ( #5555 )
...
This change enforces a maximum length of 63 characters on feature names, as well as not permitting an exactly 32 character long feature name to avoid confusion with those that use a `uint256` hex representation, as that is an alternative way to specify a feature. This change further prevents the use of Unicode characters in feature names, because some can be confused with regular ASCII characters despite being valid in identifiers.
2026-03-13 13:41:50 -04:00
Vito Tumas
2b14ee3018
refactor: Split combined transactor files into individual classes ( #6495 )
...
DID, Escrows, PaymentChannels, and Credentials previously contained multiple unrelated transactor classes in a single header/implementation pair. This change splits each into one class per file, following the same pattern established by the rest of the codebase.
2026-03-12 17:19:29 +00:00
yinyiqian1
46d5c67a8d
fix: Mark SAV and Lending transactions as NotDelegable ( #6489 )
...
New transactions should be marked as `NotDelegable`, until the interactions with other transactions have been fully tested and validated.
2026-03-11 21:27:35 +00:00
Shawn Xie
eeb0d15ea9
refactor: return optional buffers for helper functions ( #6520 )
2026-03-11 12:02:27 -04:00
Shawn Xie
84cc8599af
chore: Apply clang-format width 100 ( #6516 )
2026-03-10 11:24:01 -04:00
Shawn Xie
2c94e213c2
Resolve conflicts
2026-03-09 15:32:42 -04:00
Shawn Xie
cbcc75ff2d
Merge remote-tracking branch 'upstream/develop' into ct-merge-dev-100col
2026-03-09 15:25:10 -04:00