ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-09-27 15:28:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy switch-missing-default-case check (#6461)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-16 21:19:37 +00:00
committed by GitHub
parent f5e2415c98
commit 47a235b7be
12 changed files with 51 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.clang-tidy
View File

@@ -60,6 +60,7 @@ Checks: "-*,
bugprone-suspicious-string-compare,
bugprone-suspicious-stringview-data-usage,
bugprone-swapped-arguments,
bugprone-switch-missing-default-case,
bugprone-terminating-continue,
bugprone-throw-keyword-missing,
bugprone-too-small-loop-variable,
@@ -100,7 +101,6 @@ Checks: "-*,
# checks that have some issues that need to be resolved:
#
# bugprone-move-forwarding-reference,
# bugprone-switch-missing-default-case,
# bugprone-use-after-move,
#
# cppcoreguidelines-misleading-capture-default-by-value,

4
include/xrpl/protocol/STTx.h
View File

@@ -15,7 +15,7 @@
namespace xrpl {
enum TxnSql : char {
enum class TxnSql : char {
txnSqlNew = 'N',
txnSqlConflict = 'C',
txnSqlHeld = 'H',
@@ -122,7 +122,7 @@ public:
getMetaSQL(
Serializer rawTxn,
std::uint32_t inLedger,
char status,
TxnSql status,
std::string const& escapedMetaData) const;
std::vector<uint256> const&

1
src/libxrpl/basics/base64.cpp
View File

@@ -116,6 +116,7 @@ encode(void* dest, void const* src, std::size_t len)
in += 3;
}
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
switch (len % 3)
{
case 2:

8
src/libxrpl/protocol/STTx.cpp
View File

@@ -351,7 +351,7 @@ STTx::getMetaSQL(std::uint32_t inLedger, std::string const& escapedMetaData) con
{
Serializer s;
add(s);
return getMetaSQL(s, inLedger, txnSqlValidated, escapedMetaData);
return getMetaSQL(s, inLedger, TxnSql::txnSqlValidated, escapedMetaData);
}
// VFALCO This could be a free function elsewhere
@@ -359,7 +359,7 @@ std::string
STTx::getMetaSQL(
Serializer rawTxn,
std::uint32_t inLedger,
char status,
TxnSql status,
std::string const& escapedMetaData) const
{
static boost::format bfTrans("('%s', '%s', '%s', '%d', '%d', '%c', %s, %s)");
@@ -370,8 +370,8 @@ STTx::getMetaSQL(
return str(
boost::format(bfTrans) % to_string(getTransactionID()) % format->getName() %
toBase58(getAccountID(sfAccount)) % getFieldU32(sfSequence) % inLedger % status % rTxn %
escapedMetaData);
toBase58(getAccountID(sfAccount)) % getFieldU32(sfSequence) % inLedger %
safe_cast<char>(status) % rTxn % escapedMetaData);
}
static Expected<void, std::string>

1
src/libxrpl/server/JSONRPCUtil.cpp
View File

@@ -68,6 +68,7 @@ HTTPReply(int nStatus, std::string const& content, Json::Output const& output, b
return;
}
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
switch (nStatus)
{
case 200:

21
src/libxrpl/tx/transactors/system/LedgerStateFix.cpp
View File

@@ -35,15 +35,13 @@ LedgerStateFix::calculateBaseFee(ReadView const& view, STTx const& tx)
TER
LedgerStateFix::preclaim(PreclaimContext const& ctx)
{
switch (ctx.tx[sfLedgerFixType])
if (ctx.tx[sfLedgerFixType] == FixType::nfTokenPageLink)
{
case FixType::nfTokenPageLink: {
AccountID const owner{ctx.tx[sfOwner]};
if (!ctx.view.read(keylet::account(owner)))
return tecOBJECT_NOT_FOUND;
AccountID const owner{ctx.tx[sfOwner]};
if (!ctx.view.read(keylet::account(owner)))
return tecOBJECT_NOT_FOUND;
return tesSUCCESS;
}
return tesSUCCESS;
}
// preflight is supposed to verify that only valid FixTypes get to preclaim.
@@ -53,13 +51,12 @@ LedgerStateFix::preclaim(PreclaimContext const& ctx)
TER
LedgerStateFix::doApply()
{
switch (ctx_.tx[sfLedgerFixType])
if (ctx_.tx[sfLedgerFixType] == FixType::nfTokenPageLink)
{
case FixType::nfTokenPageLink:
if (!nft::repairNFTokenDirectoryLinks(view(), ctx_.tx[sfOwner]))
return tecFAILED_PROCESSING;
if (!nft::repairNFTokenDirectoryLinks(view(), ctx_.tx[sfOwner]))
return tecFAILED_PROCESSING;
return tesSUCCESS;
return tesSUCCESS;
}
// preflight is supposed to verify that only valid FixTypes get to doApply.

1
src/test/nodestore/Timing_test.cpp
View File

@@ -550,6 +550,7 @@ public:
p[1] = 1 - p[0];
for (int q = 0; q < 2; ++q)
{
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
switch (p[q])
{
case 0: {

3
src/xrpld/app/misc/NetworkOPs.cpp
View File

@@ -2535,6 +2535,9 @@ NetworkOPsImp::getServerInfo(bool human, bool admin, bool counters)
if (admin)
{
// Note: By default the node size is "tiny". When parsing it's an error if the final
// NODE_SIZE is over 4 so below code should be safe.
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
switch (registry_.app().config().NODE_SIZE)
{
case 0:

22
src/xrpld/app/misc/detail/Transaction.cpp
View File

@@ -53,26 +53,26 @@ Transaction::setStatus(
TransStatus
Transaction::sqlTransactionStatus(boost::optional<std::string> const& status)
{
char const c = (status) ? (*status)[0] : safe_cast<char>(txnSqlUnknown);
auto const c = (status) ? safe_cast<TxnSql>((*status)[0]) : TxnSql::txnSqlUnknown;
switch (c)
switch (static_cast<TxnSql>(c))
{
case txnSqlNew:
case TxnSql::txnSqlNew:
return NEW;
case txnSqlConflict:
case TxnSql::txnSqlConflict:
return CONFLICTED;
case txnSqlHeld:
case TxnSql::txnSqlHeld:
return HELD;
case txnSqlValidated:
case TxnSql::txnSqlValidated:
return COMMITTED;
case txnSqlIncluded:
case TxnSql::txnSqlIncluded:
return INCLUDED;
default:
XRPL_ASSERT(
c == TxnSql::txnSqlUnknown,
"xrpl::Transaction::sqlTransactionStatus : unknown transaction status");
}
XRPL_ASSERT(
c == txnSqlUnknown,
"xrpl::Transaction::sqlTransactionStatus : unknown transaction "
"status");
return INVALID;
}

1
src/xrpld/app/paths/Pathfinder.cpp
View File

@@ -1158,6 +1158,7 @@ makePath(char const* string)
while (true)
{
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
switch (*string++)
{
case 's': // source

2
src/xrpld/overlay/detail/Message.cpp
View File

@@ -58,6 +58,8 @@ Message::compress()
bool const compressible = [&] {
if (messageBytes <= 70)
return false;
// NOLINTNEXTLINE(bugprone-switch-missing-default-case)
switch (type)
{
case protocol::mtMANIFESTS:

30
src/xrpld/overlay/detail/OverlayImpl.cpp
View File

@@ -907,9 +907,9 @@ OverlayImpl::processHealth(http_request_type const& req, Handoff& handoff)
std::string server_state = info[jss::server_state].asString();
auto load_factor = info[jss::load_factor_server].asDouble() / info[jss::load_base].asDouble();
enum { healthy, warning, critical };
int health = healthy;
auto set_health = [&health](int state) {
enum class HealthState { healthy, warning, critical };
auto health = HealthState::healthy;
auto set_health = [&health](HealthState state) {
if (health < state)
health = state;
};
@@ -919,24 +919,24 @@ OverlayImpl::processHealth(http_request_type const& req, Handoff& handoff)
{
msg.body()[jss::info][jss::validated_ledger] = last_validated_ledger_age;
if (last_validated_ledger_age < 20)
set_health(warning);
set_health(HealthState::warning);
else
set_health(critical);
set_health(HealthState::critical);
}
if (amendment_blocked)
{
msg.body()[jss::info][jss::amendment_blocked] = true;
set_health(critical);
set_health(HealthState::critical);
}
if (number_peers <= 7)
{
msg.body()[jss::info][jss::peers] = number_peers;
if (number_peers != 0)
set_health(warning);
set_health(HealthState::warning);
else
set_health(critical);
set_health(HealthState::critical);
}
if (!(server_state == "full" || server_state == "validating" || server_state == "proposing"))
@@ -944,30 +944,30 @@ OverlayImpl::processHealth(http_request_type const& req, Handoff& handoff)
msg.body()[jss::info][jss::server_state] = server_state;
if (server_state == "syncing" || server_state == "tracking" || server_state == "connected")
{
set_health(warning);
set_health(HealthState::warning);
}
else
set_health(critical);
set_health(HealthState::critical);
}
if (load_factor > 100)
{
msg.body()[jss::info][jss::load_factor] = load_factor;
if (load_factor < 1000)
set_health(warning);
set_health(HealthState::warning);
else
set_health(critical);
set_health(HealthState::critical);
}
switch (health)
{
case healthy:
case HealthState::healthy:
msg.result(boost::beast::http::status::ok);
break;
case warning:
case HealthState::warning:
msg.result(boost::beast::http::status::service_unavailable);
break;
case critical:
case HealthState::critical:
msg.result(boost::beast::http::status::internal_server_error);
break;
}