Ed Hennis
88266077e1
Merge branch 'develop' into tapanito/invariant-bugfix
2026-04-16 17:34:45 -04:00
Jingchen
4a73be499d
fix: Fix unity build for book step ( #6942 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-16 17:12:00 +00:00
Ed Hennis
be0e099386
Improve Invariant check handling if not in Transactor context
...
- Adds an option to isFeatureEnabled to return true if no global rules
set. Can be used for functionality that uses the post-amendment
behavior when called outside of a Transactor context.
2026-04-15 16:17:56 -04:00
Sergey Kuznetsov
d52d735543
chore: Move codegen venv setup into build stage ( #6617 )
...
Co-authored-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-15 18:50:49 +00:00
Ed Hennis
c86e8ce532
Fix review feedback from @pratikmankawde
...
- Remove unused function parameters due to the simplification.
2026-04-14 21:16:03 -04:00
Ed Hennis
6ccc393ab9
fixup! Change the "Legacy" variables to amendment checks in visitNodes
2026-04-14 21:11:48 -04:00
Alex Kremer
6a0ce46755
chore: Enable most clang-tidy bugprone checks ( #6929 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-14 20:24:21 +00:00
Bart
2f029a2120
refactor: Improve exception handling ( #6540 ) ( #6735 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-14 17:14:24 +00:00
Zhiyuan Wang
61fbde3a71
refactor: Remove unused notTooManyOffers function from NFTokenUtils ( #6737 )
2026-04-13 23:18:10 +00:00
Bart
e2e537b3bb
fix: Change Tuning::bookOffers minimum limit to 1 ( #6812 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-10 14:38:46 +00:00
Ed Hennis
a873250019
chore: Make pre-commit line ending conversions work on Windows ( #6832 ) ( #6833 )
2026-04-10 10:12:52 +00:00
Ed Hennis
d3e85087e0
Fix redundant trinary result
2026-04-09 17:06:10 -04:00
Ed Hennis
d01cfb63ff
Change the "Legacy" variables to amendment checks in visitNodes
...
- Having parallel variables is error prone in case of any future
developments. It could also explode if another fix needs to be made
later.
2026-04-09 13:54:26 -04:00
Ed Hennis
f86acbf127
Merge remote-tracking branch 'XRPLF/develop' into tapanito/invariant-bugfix
...
* XRPLF/develop: (22 commits)
fix: Add description for `terLOCKED` error (6811)
fix: Address AI reviewer comments for Permission Delegation (6675)
refactor: Combine `AMMHelpers` and `AMMUtils` (6733)
feat: Add MPT support to DEX (5285)
fix: Handle WSClient write failure when server closes WebSocket (6671)
ci: Change conditions for uploading artifacts in public/private/org repos (6734)
refactor: Rename non-functional uses of `ripple(d)` to `xrpl(d)` (6676)
refactor: Move more helper files into `libxrpl/ledger/helpers` (6731)
fix: Minor RPC fixes (6730)
fix: Prevent deletion of MPTokens with active escrow (6635)
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback (6646)
fix: Add assorted Lending Protocol fixes (6678)
fix: Change variable signedness and correctly handle `std::optional` (6657)
refactor: Reorganize RPC handler files (6628)
chore: Update XRPLF/actions (6713)
docs: Add explanatory comment to checkFee (6631)
fix: Decouple reserve from fee in delegate payment (6568)
fix: Check trustline limits for share-denominated vault withdrawals (6645)
fix: Remove fatal assertion on Linux thread name truncation (6690)
chore: Enable clang-tidy `coreguidelines` checks (6698)
...
2026-04-09 12:45:04 -04:00
Gregory Tsipenyuk
56c9d1d497
fix: Add description for terLOCKED error ( #6811 )
2026-04-08 20:56:19 +00:00
yinyiqian1
d52dd29d20
fix: Address AI reviewer comments for Permission Delegation ( #6675 )
2026-04-08 20:22:19 +00:00
Mayukha Vadari
7793b5f10b
refactor: Combine AMMHelpers and AMMUtils ( #6733 )
2026-04-08 17:38:33 +00:00
Gregory Tsipenyuk
dfcad69155
feat: Add MPT support to DEX ( #5285 )
2026-04-08 16:17:37 +00:00
Pratik Mankawde
6d1a5be8d2
fix: Handle WSClient write failure when server closes WebSocket ( #6671 )
...
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-07 19:15:40 +00:00
Ayaz Salikhov
b0fe2ec58a
ci: Change conditions for uploading artifacts in public/private/org repos ( #6734 )
2026-04-07 14:32:13 +00:00
Bart
c00ed673a8
refactor: Rename non-functional uses of ripple(d) to xrpl(d) ( #6676 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-04-07 13:00:17 +00:00
Mayukha Vadari
f239256d87
refactor: Move more helper files into libxrpl/ledger/helpers ( #6731 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-06 22:36:32 +00:00
Mayukha Vadari
00761dbb67
fix: Minor RPC fixes ( #6730 )
2026-04-06 22:15:16 +00:00
Zhiyuan Wang
077e03ff33
fix: Prevent deletion of MPTokens with active escrow ( #6635 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-04-06 17:51:46 +00:00
Vito Tumas
7d524a03b8
fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback ( #6646 )
2026-04-06 15:13:03 +00:00
Vito Tumas
c0ee813666
fix: Add assorted Lending Protocol fixes ( #6678 )
...
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com >
2026-04-03 17:41:45 +00:00
Mayukha Vadari
8e05416211
fix: Change variable signedness and correctly handle std::optional ( #6657 )
2026-04-03 15:16:50 +00:00
Vito
3cccbdf966
fix: unify invariant overwrite tests into single parameterized helper
...
Consolidate the regression tests and legacy tests into a single
testInvariantOverwrite(FeatureBitset) that tests both pre- and
post-amendment behavior for all three affected invariants.
2026-04-03 15:03:31 +02:00
Vito
d5fa8485e8
fix: address review comments
...
- Rename local variables in finalize to effectiveXrpTrustLine and
effectiveDeepFreezeWithoutFreeze to match effectiveBad naming
- Use 'Regression:' prefix for MPT overwrite test comment
2026-04-03 14:54:57 +02:00
Mayukha Vadari
81555d5456
refactor: Reorganize RPC handler files ( #6628 )
2026-04-02 23:46:17 +00:00
Ayaz Salikhov
6b55c4cdc8
chore: Update XRPLF/actions ( #6713 )
2026-04-02 21:34:20 +00:00
yinyiqian1
3414a1776b
docs: Add explanatory comment to checkFee ( #6631 )
2026-04-02 20:48:35 +00:00
yinyiqian1
6d9ed125f3
fix: Decouple reserve from fee in delegate payment ( #6568 )
2026-04-02 20:48:00 +00:00
Vito Tumas
02fa55df8d
fix: Check trustline limits for share-denominated vault withdrawals ( #6645 )
2026-04-01 19:31:45 +00:00
Valentin Balaschenko
6e2452207d
fix: Remove fatal assertion on Linux thread name truncation ( #6690 )
2026-04-01 16:56:45 +00:00
Alex Kremer
29e49abd3c
chore: Enable clang-tidy coreguidelines checks ( #6698 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-04-01 15:46:14 +00:00
Ayaz Salikhov
ae21f53e4d
ci: Allow uploading artifacts for XRPLF org ( #6702 )
2026-04-01 13:37:35 +00:00
Vito Tumas
bee1056faa
fix: Enforce aggregate MaximumAmount in multi-send MPT ( #6644 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-04-01 13:35:13 +00:00
Vito
9ccf4a9e3f
fix: address review comments
...
- Replace {{}} with {} for empty expect_logs in legacy tests
- Simplify currency pair loop into computed key ordering
- Update GatewayBalances_test comment
2026-04-01 15:28:27 +02:00
Vito
ec70c47f07
chore: fix remaining clang-tidy const-correctness in Vault_test
2026-04-01 15:19:07 +02:00
Vito
322207e9ce
chore: fix clang-tidy misc-const-correctness warnings
2026-04-01 14:56:19 +02:00
Vito
70fe92312d
Merge remote-tracking branch 'origin/develop' into tapanito/invariant-bugfix
2026-04-01 13:40:51 +02:00
Vito
a1591a9c23
fix: add const to shared_ptr variables in legacy invariant tests
2026-04-01 13:40:38 +02:00
Ayaz Salikhov
b6aa4a8fde
chore: Use nudb recipe from the upstream ( #6701 )
2026-04-01 10:33:02 +00:00
Vito
e3a3b77dc4
Merge remote-tracking branch 'origin/develop' into tapanito/invariant-bugfix
2026-04-01 12:25:40 +02:00
Mayukha Vadari
a9afd2c116
fix: Fix previous ledger size typo in RCLConsensus ( #6696 )
2026-03-31 19:56:30 +00:00
Alex Kremer
2502befb42
chore: Enable clang-tidy misc checks ( #6655 )
2026-03-31 17:29:45 +00:00
Ayaz Salikhov
c3fae847f3
ci: Use pull_request_target to check for signed commits ( #6697 )
2026-03-31 17:14:41 +00:00
Vito
baeaf09ae6
fix: remove enabled amendments from tests
2026-03-31 18:52:08 +02:00
Bart
7f53351920
chore: Remove unnecessary clang-format off/on directives ( #6682 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-31 15:38:04 +00:00