Pratik Mankawde
7ab34d2e37
fix(telemetry): resolve phase-7 clang-tidy findings
...
- OTelCollector::formatName made static (no member state); braces added;
<cctype> added for std::tolower.
- Telemetry.cpp getMeter(): braces around single-statement if.
- GetMeter.cpp: drop unused <opentelemetry/metrics/meter.h> and
sync_instruments.h; add <xrpl/beast/utility/Journal.h> and <memory>;
make sdkProvider const.
- ValidationTracker.h: add <cstddef> for std::size_t.
- detail/ValidationTracker.cpp: use std::views::reverse range-based loop;
add <ranges>.
- test ValidationTracker.cpp: use auto for cast result.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-09 15:09:43 +01:00
Pratik Mankawde
e304d65d63
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-09 15:01:54 +01:00
Pratik Mankawde
71f725204c
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-07-09 14:01:37 +01:00
Pratik Mankawde
48c3c7ecfc
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-09 14:01:37 +01:00
Pratik Mankawde
bbdb8dc19b
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-09 14:01:37 +01:00
Pratik Mankawde
c2e5e0d808
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
2026-07-09 14:01:27 +01:00
Pratik Mankawde
9240dc2a12
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-09 14:00:33 +01:00
Pratik Mankawde
baacd054c9
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-09 14:00:33 +01:00
Pratik Mankawde
ebf8b6e8a9
fix(telemetry): add <cstdint> to TxTracing.h for std::uint8_t (misc-include-cleaner)
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-09 14:00:22 +01:00
Pratik Mankawde
84f2ff6b58
fix(telemetry): drop unused <ranges> from Redaction.cpp and its test (misc-include-cleaner)
...
std::ranges::transform/all_of come from <algorithm>, which is already included.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-09 14:00:20 +01:00
Pratik Mankawde
c7b04a043e
fix(telemetry): drop unused <cstddef> from SpanGuard.h (misc-include-cleaner)
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-07-09 14:00:17 +01:00
Pratik Mankawde
6512ce604f
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-08 18:44:34 +01:00
Pratik Mankawde
f6b5b663dc
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-08 18:44:34 +01:00
Pratik Mankawde
1732c913a3
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-08 18:44:34 +01:00
Pratik Mankawde
d17c1c5c7f
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase7-native-metrics
2026-07-08 18:44:16 +01:00
Pratik Mankawde
2321b4985d
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-08 18:44:04 +01:00
Pratik Mankawde
1d6475ac0e
fix(telemetry): add missing SpanNames.h and cstdint includes (misc-include-cleaner)
2026-07-08 18:43:43 +01:00
Pratik Mankawde
04f1775e10
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-08 18:42:58 +01:00
Pratik Mankawde
ec7d99228a
fix(telemetry): add missing OTel headers for TraceContextPropagator (misc-include-cleaner)
2026-07-08 18:42:31 +01:00
Pratik Mankawde
09e083a718
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase3-tx-tracing
2026-07-08 18:42:10 +01:00
Pratik Mankawde
e7ba376839
fix(telemetry): add missing span_metadata.h for SpanKind (misc-include-cleaner)
2026-07-08 18:41:59 +01:00
Pratik Mankawde
77f35c03db
fix(telemetry): remove metric prefix, lowercase names, fix spaces in formatName
...
Drop the xrpld_ prefix from beast::insight metric names — the OTel
resource (service.name=xrpld) already identifies the service. formatName()
now lowercases and sanitizes spaces/dots to underscores for
Prometheus-compatible names.
Also fix 4 source strings containing spaces that produced invalid OTel
instrument names (silently rejected by the SDK).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 17:45:36 +01:00
Pratik Mankawde
11d2d9038b
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-07-08 16:02:58 +01:00
Pratik Mankawde
12060bc219
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-08 16:02:58 +01:00
Pratik Mankawde
a8ce1408a9
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-08 16:02:51 +01:00
Pratik Mankawde
c0a3e113d9
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-08 16:02:51 +01:00
Pratik Mankawde
ce9bdfcc55
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-08 16:02:51 +01:00
Pratik Mankawde
02b32ecdd8
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-08 16:02:51 +01:00
Pratik Mankawde
61ae9998e1
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-08 16:02:51 +01:00
Pratik Mankawde
22f5b77e0c
Merge branch 'pratik/otel-phase1a-plan-docs' into pratik/otel-phase1b-telemetry-infra
2026-07-08 16:02:43 +01:00
Pratik Mankawde
adeda255f0
Merge remote-tracking branch 'origin/develop' into pratik/otel-phase1a-plan-docs
2026-07-08 16:02:37 +01:00
Pratik Mankawde
d64608e8a7
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-07-08 15:41:21 +01:00
Pratik Mankawde
087e6e5b63
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-08 15:41:21 +01:00
Pratik Mankawde
2ac68427fc
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
2026-07-08 15:41:21 +01:00
Pratik Mankawde
5ba27cc90f
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-08 15:41:07 +01:00
Pratik Mankawde
f4549b68c7
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
...
# Conflicts:
# include/xrpl/telemetry/SpanGuard.h
2026-07-08 15:41:04 +01:00
Pratik Mankawde
7848574a38
Merge branch 'pratik/otel-phase1b-telemetry-infra' into pratik/otel-phase1c-rpc-integration
2026-07-08 15:40:50 +01:00
Pratik Mankawde
8800160bb5
Merge branch 'pratik/otel-phase1c-rpc-integration' into pratik/otel-phase2-rpc-tracing
2026-07-08 15:40:50 +01:00
Pratik Mankawde
4e9df8b5c3
fix(telemetry): add missing <cstddef> include for std::size_t in SpanGuard.h
...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:40:38 +01:00
Pratik Mankawde
a396fe073f
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-08 15:38:26 +01:00
Pratik Mankawde
0bfb338666
Merge branch 'pratik/otel-phase5-docs-deployment' into pratik/otel-phase6-statsd
2026-07-08 15:38:21 +01:00
Pratik Mankawde
0a373f631c
fix(telemetry): resolve otel-naming and UBSAN CI failures
...
- Add job_type to otel-naming builtins (standard Prometheus label for
job-queue metrics used in node-health dashboard)
- Add OpenTelemetry SDK to UBSAN suppressions (intentional unsigned
integer overflow in attributemap_hash.h hash computation)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:25:59 +01:00
Pratik Mankawde
b1091a482c
Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment
...
# Conflicts:
# src/libxrpl/telemetry/Telemetry.cpp
2026-07-08 15:23:03 +01:00
Pratik Mankawde
a1a9d45bff
Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics
2026-07-08 15:22:52 +01:00
Pratik Mankawde
4826038068
fix(telemetry): run rename scripts for CI compliance
...
Rename rippled → xrpld in statsd config prefix.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:22:45 +01:00
Pratik Mankawde
749535a3ca
fix(telemetry): resolve clang-tidy CI errors in consensus tracing
...
Add missing <string_view> include in Consensus.h and RCLConsensus.h.
Remove unused SHAMap.h include from RCLConsensus.h.
Add braces around single-line if/else bodies in RCLConsensus.cpp.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:22:24 +01:00
Pratik Mankawde
87c003230c
Merge branch 'pratik/otel-phase3-tx-tracing' into pratik/otel-phase4-consensus-tracing
2026-07-08 15:20:07 +01:00
Pratik Mankawde
6938614468
fix(telemetry): remove unused includes (misc-include-cleaner)
...
Remove unused SpanNames.h from Transactor.cpp (transitively included
via TxApplySpanNames.h). Remove unused <ranges> from
TraceContextValidation.h (std::ranges::any_of lives in <algorithm>).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:20:01 +01:00
Pratik Mankawde
8108caffe3
Merge branch 'pratik/otel-phase2-rpc-tracing' into pratik/otel-phase3-tx-tracing
2026-07-08 15:19:01 +01:00
Pratik Mankawde
db38ba268f
fix(telemetry): use std::ranges algorithms (modernize-use-ranges)
...
Replace std::transform with std::ranges::transform in Redaction.cpp.
Replace std::all_of with std::ranges::all_of in Redaction test.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-07-08 15:18:55 +01:00
