Vito
59c779fc01
refactor: Use static_cast instead of switch in getVaultVersion
...
Address PR review comment: VaultVersion's enumerators already have
explicit values, so static_cast<VaultVersion>(leVersion) avoids
repeating them as switch-case magic numbers. Out-of-range values
still hit the UNREACHABLE guard.
2026-07-27 14:50:56 +02:00
Vito Tumas
63e8158769
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-27 14:43:27 +02:00
Vito
ed4c5e141c
test: Drop obsolete amendment-disabled cash-basis dispatch cases
...
Now that cashBasisEnabled only checks the Vault's LEVersion, dispatch
no longer depends on the amendment flag. The "amendment disabled picks
Accrual" sub-cases fed a CashBasis-versioned vault while disabling the
amendment, a combination that can no longer occur (LEVersion is fixed
at Vault creation) and that the current dispatch correctly ignores,
so they failed. The remaining legacy-vault/cash-basis-vault cases
already cover the dispatch logic.
2026-07-27 14:39:27 +02:00
Andrzej Budzanowski
20801d98ac
test: Improve the server status test to not race and randomly fail ( #7304 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-27 11:58:15 +00:00
Vito
0e19cf9c3d
Merge remote-tracking branch 'origin/develop' into tapanito/lending-cash-basis
2026-07-27 11:50:09 +02:00
Vito
9a2b4b7dc4
refactor: Drop unused rules argument from cashBasisEnabled callers
...
cashBasisEnabled now only checks the Vault's LEVersion, so the Rules
parameter threaded through loanOriginationDeltas,
loanOriginationExceedsVaultMaximum, loanVaultExposure, and
loanPaymentDeltas is dead weight. Remove it from the declarations,
definitions, and call sites.
2026-07-27 11:49:22 +02:00
Vito
20358587ce
fix: Use cash-basis-aware debt delta for LoanSet DebtMaximum guard
...
Remove unused vaultMaximum local left over from the AssetsMaximum
guard refactor, and stop the DebtMaximum guard from unconditionally
adding interestDue to the projected DebtTotal. Reuse the existing
loanOriginationDeltas dispatcher, which already excludes interestDue
under cash-basis accounting.
2026-07-24 11:55:58 +02:00
Vito
b9b3aedc88
fix: Skip AssetsMaximum interest check under cash-basis accounting
...
Cash-basis origination never recognizes interest into Vault.AssetsTotal,
so checking interestDue against remaining AssetsMaximum headroom rejects
loans for no reason. Split the check into Accrual/CashBasis namespaces,
mirroring the existing loanOriginationDeltas/loanPaymentDeltas dispatch.
2026-07-24 10:44:43 +02:00
Kassaking7
9afa1cf4d1
fix: Update PermissionedDEX invariant domain tracking for valid offer replacement ( #7387 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-23 21:40:21 +00:00
Ed Hennis
7908aec2ec
feat: Check default fields are not default when serializing ( #6267 )
...
Co-authored-by: Vito <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-23 21:39:11 +00:00
Marek Foss
4c0180b3db
test: Migrate csf and xrpld-consensus Beast non-JTx tests to GTest ( #7046 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-23 21:38:21 +00:00
Marek Foss
4acccfeda8
test: Modularize Peerfinder component and migrate Peerfinder tests from Beast to GTest and GMock ( #7054 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-23 21:00:06 +00:00
Ed Hennis
b89d75a2d5
test: Add an RAII class to manage the env.parseFailureExpected flag ( #7669 )
2026-07-23 20:57:00 +00:00
Vito
209ee243d3
fix: Address PR review comments on LEVersion naming
...
Reference VaultVersion::Legacy instead of raw 0 in getVaultVersion's
docstring, correct a stale test label, and rename LoanPay's precision
log fields from ValueChange to AssetsTotalDelta to match what they
actually print
2026-07-22 12:58:37 +02:00
Vito
fac3dfccc8
fix: VaultVersion
2026-07-22 11:59:03 +02:00
Vito Tumas
a63a326886
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-22 11:58:32 +02:00
Vito
e5d6f256cd
fix: autogen files
2026-07-21 18:21:57 +02:00
Vito
cc03abd79b
adds LEVersion field to Vault
2026-07-21 15:26:16 +02:00
Mayukha Vadari
ee0a3dfad7
ci: Improve test debuggability ( #7619 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-21 13:14:40 +00:00
Vito Tumas
c0bd10ccec
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-21 11:31:19 +02:00
Vito
c1a0f94c2e
feat: Implement LendingProtocolV1_1 cash-basis accounting
...
Gate Vault AssetsTotal and LoanBroker DebtTotal to principal-only
tracking under featureLendingProtocolV1_1, replacing whole-life
(accrual) interest recognition. Adds Accrual/CashBasis namespaces and
three public dispatchers in LendingHelpers, consumed by LoanSet,
LoanPay, and LoanManage without any amendment-awareness in the
transactors themselves. Pre-amendment behavior is unchanged.
2026-07-16 18:12:42 +02:00
Vito Tumas
5ce0b1c2c7
refactor: Restructure LendingHelpers to improve readability ( #7807 )
2026-07-16 15:47:56 +00:00
Andrzej Budzanowski
701311f27e
test: Add google benchmark dependency and migrate nodestore timing test as a benchmark ( #7317 )
...
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-16 15:44:43 +00:00
Bart
18e311e1e2
chore: Bump version to 3.3.0-rc1 ( #7806 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-16 13:54:12 +00:00
Denis Angell
69b70d7a0d
fix: Refactor Batch Transaction IDs ( #7736 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-16 13:15:59 +00:00
Mayukha Vadari
b42cde3e85
refactor: Remove redundant enable checks in ConfidentialMPT txs ( #7809 )
2026-07-16 09:51:19 +00:00
Vlad
433e5f6896
fix: Reject zero CheckID in CheckCancel and CheckCash ( #7685 )
2026-07-15 22:08:45 +00:00
Sophia Xie
a0fd1cce54
fix: Re-store nodes missing from both backends during online_delete rotation ( #7763 )
...
Co-authored-by: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com >
2026-07-14 23:42:40 +00:00
Kassaking7
cda63d00a2
fix: Add amendment sponsor for AccountRootsDeletedClean ( #7801 )
2026-07-14 19:41:53 +00:00
Ed Hennis
530e09dbe8
fix: Update base_uint and test changes released in 3.1.3 ( #7570 )
...
Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-14 18:48:10 +00:00
Ed Hennis
f10dd7b450
fix: Handle rounding just above kMaxRep more accurately ( #7389 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
2026-07-14 18:47:41 +00:00
Ed Hennis
0a4676d947
fix: Document and assert "after" is never null in invariants ( #7354 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-14 18:16:46 +00:00
Gregory Tsipenyuk
2403670da9
fix: Strengthen Clawback invariant checks for MPT balances ( #7285 )
2026-07-14 14:31:06 +00:00
Jingchen
c621136748
test: Add unit tests for IP address related functions ( #7744 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ed Hennis <ed@ripple.com >
2026-07-14 14:29:18 +00:00
Alex Kremer
73e97b8b84
test: Add JSON array size tests ( #7592 )
2026-07-14 12:35:04 +00:00
Ayaz Salikhov
e1d4f357dc
chore: Enable most readability checks ( #7772 )
2026-07-14 12:21:40 +00:00
Peter Chen
752dab8b30
feat: Add delegate filter param for account_tx RPC ( #6126 )
2026-07-13 18:44:59 +00:00
Mayukha Vadari
86583bc34e
refactor: Move jss.h include out of Indexes.h ( #7799 )
2026-07-13 17:44:47 +00:00
Ayaz Salikhov
73b6852a12
style: Unify style for all Doxygen comments ( #7776 )
2026-07-13 10:40:40 +00:00
Ed Hennis
8306ac7710
fix: Improve Number addition/subtraction rounding ( #7369 )
...
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-07-11 00:18:31 +00:00
Olek
fd2cc6dcb3
feat: XLS-68: Sponsor, #5887 continuation ( #7350 )
...
Co-authored-by: tequ <git@tequ.dev >
Co-authored-by: yinyiqian1 <yqian@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Peter Chen <34582813+PeterChen13579@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <96991820+Kassaking7@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <asalikhov@ripple.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Zhiyuan Wang <1830604455@qq.com >
2026-07-10 21:58:19 +00:00
Ayaz Salikhov
58af1e6f18
release: Bump version to 3.3.0-b1 ( #7755 )
2026-07-08 12:40:24 +00:00
Ayaz Salikhov
e372c45836
chore: Enable most performance checks ( #7727 )
2026-07-07 21:03:56 +00:00
Ayaz Salikhov
2ebc96a4a6
perf: Use std::from/to_chars for JSON double parsing/formating ( #7735 )
2026-07-07 21:02:39 +00:00
Ayaz Salikhov
c5a6de6ef7
chore: Enable most cppcoreguidelines checks ( #7660 )
2026-07-07 13:12:52 +00:00
Marek Foss
f5e63f8a91
test: Migrate basics Beast tests to GTest ( #7136 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 19:48:36 +00:00
Marek Foss
7a153a2bce
test: Migrate resource, shamap Beast tests to GTest ( #7133 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-06 17:26:19 +00:00
Ayaz Salikhov
f59d5c0894
chore: Enable most misc checks ( #7663 )
2026-07-06 15:22:11 +00:00
Ayaz Salikhov
d07d2aba2e
chore: Enable most modernize checks ( #7664 )
2026-07-06 12:19:52 +00:00
Ayaz Salikhov
c92285f10d
chore: Delete dead code ( #7718 )
2026-07-03 15:59:20 +00:00