Vito
59c779fc01
refactor: Use static_cast instead of switch in getVaultVersion
...
Address PR review comment: VaultVersion's enumerators already have
explicit values, so static_cast<VaultVersion>(leVersion) avoids
repeating them as switch-case magic numbers. Out-of-range values
still hit the UNREACHABLE guard.
2026-07-27 14:50:56 +02:00
Vito Tumas
63e8158769
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-27 14:43:27 +02:00
Vito
ed4c5e141c
test: Drop obsolete amendment-disabled cash-basis dispatch cases
...
Now that cashBasisEnabled only checks the Vault's LEVersion, dispatch
no longer depends on the amendment flag. The "amendment disabled picks
Accrual" sub-cases fed a CashBasis-versioned vault while disabling the
amendment, a combination that can no longer occur (LEVersion is fixed
at Vault creation) and that the current dispatch correctly ignores,
so they failed. The remaining legacy-vault/cash-basis-vault cases
already cover the dispatch logic.
2026-07-27 14:39:27 +02:00
Andrzej Budzanowski
20801d98ac
test: Improve the server status test to not race and randomly fail ( #7304 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-27 11:58:15 +00:00
dependabot[bot]
b878818e80
ci: [DEPENDABOT] bump actions/checkout from 7.0.0 to 7.0.1 ( #7871 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-27 09:55:01 +00:00
Vito
0e19cf9c3d
Merge remote-tracking branch 'origin/develop' into tapanito/lending-cash-basis
2026-07-27 11:50:09 +02:00
Vito
9a2b4b7dc4
refactor: Drop unused rules argument from cashBasisEnabled callers
...
cashBasisEnabled now only checks the Vault's LEVersion, so the Rules
parameter threaded through loanOriginationDeltas,
loanOriginationExceedsVaultMaximum, loanVaultExposure, and
loanPaymentDeltas is dead weight. Remove it from the declarations,
definitions, and call sites.
2026-07-27 11:49:22 +02:00
Sergey Kuznetsov
fecfc0cf3f
chore: Fix clang version in devshell ( #7860 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-24 17:30:20 +00:00
Ayaz Salikhov
ea0a6904f0
chore: Verify tooling version for Nix-managed environments ( #7862 )
2026-07-24 15:52:45 +00:00
Ayaz Salikhov
29d74142ae
build: Patсh binary in local Linux nix environment ( #7859 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-07-24 14:59:24 +00:00
Vito
20358587ce
fix: Use cash-basis-aware debt delta for LoanSet DebtMaximum guard
...
Remove unused vaultMaximum local left over from the AssetsMaximum
guard refactor, and stop the DebtMaximum guard from unconditionally
adding interestDue to the projected DebtTotal. Reuse the existing
loanOriginationDeltas dispatcher, which already excludes interestDue
under cash-basis accounting.
2026-07-24 11:55:58 +02:00
Vito
b9b3aedc88
fix: Skip AssetsMaximum interest check under cash-basis accounting
...
Cash-basis origination never recognizes interest into Vault.AssetsTotal,
so checking interestDue against remaining AssetsMaximum headroom rejects
loans for no reason. Split the check into Accrual/CashBasis namespaces,
mirroring the existing loanOriginationDeltas/loanPaymentDeltas dispatch.
2026-07-24 10:44:43 +02:00
Kassaking7
9afa1cf4d1
fix: Update PermissionedDEX invariant domain tracking for valid offer replacement ( #7387 )
...
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-23 21:40:21 +00:00
Ed Hennis
7908aec2ec
feat: Check default fields are not default when serializing ( #6267 )
...
Co-authored-by: Vito <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-07-23 21:39:11 +00:00
Marek Foss
4c0180b3db
test: Migrate csf and xrpld-consensus Beast non-JTx tests to GTest ( #7046 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-23 21:38:21 +00:00
Marek Foss
4acccfeda8
test: Modularize Peerfinder component and migrate Peerfinder tests from Beast to GTest and GMock ( #7054 )
...
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-23 21:00:06 +00:00
Ed Hennis
b89d75a2d5
test: Add an RAII class to manage the env.parseFailureExpected flag ( #7669 )
2026-07-23 20:57:00 +00:00
Ayaz Salikhov
40cdf49d15
build: Use custom libc in a devshell by default ( #7852 )
2026-07-23 19:05:24 +00:00
Mayukha Vadari
38c54c3f36
feat: Add fixCleanup3_4_0 amendment (no functionality yet) ( #7854 )
2026-07-23 18:50:59 +00:00
Sergey Kuznetsov
95e1ffea6e
ci: Add llvm-tools-preview to rust toolchain ( #7853 )
2026-07-23 16:49:44 +00:00
Sergey Kuznetsov
74cfb3586a
ci: Update CI image ( #7850 )
2026-07-23 11:21:49 +00:00
Ayaz Salikhov
0072ced94c
ci: Update XRPLF/actions ( #7849 )
2026-07-23 10:22:18 +00:00
Vito Tumas
495a4690df
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-23 10:21:33 +02:00
Mayukha Vadari
12ed506565
chore: Clean up grammar in PR template ( #7846 )
2026-07-22 18:50:10 +00:00
Ayaz Salikhov
3122de86bf
build: Create versioned compiler/tooling symlinks in nix environments ( #7844 )
2026-07-22 17:04:02 +00:00
Sergey Kuznetsov
7edf39e622
ci: Use rust-overlay to bring Rust into nix ( #7837 )
2026-07-22 14:00:17 +00:00
Vito
209ee243d3
fix: Address PR review comments on LEVersion naming
...
Reference VaultVersion::Legacy instead of raw 0 in getVaultVersion's
docstring, correct a stale test label, and rename LoanPay's precision
log fields from ValueChange to AssetsTotalDelta to match what they
actually print
2026-07-22 12:58:37 +02:00
Vito
fac3dfccc8
fix: VaultVersion
2026-07-22 11:59:03 +02:00
Vito Tumas
a63a326886
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-22 11:58:32 +02:00
Vito
e5d6f256cd
fix: autogen files
2026-07-21 18:21:57 +02:00
dependabot[bot]
ba01b05f33
ci: [DEPENDABOT] bump actions/setup-python from 6.3.0 to 7.0.0 ( #7830 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-21 16:04:45 +00:00
Sergey Kuznetsov
c414e1877d
ci: Update pre-commit image ( #7838 )
2026-07-21 15:37:47 +00:00
Sergey Kuznetsov
f56b79f00d
ci: Add cargo to pre-commit image ( #7835 )
2026-07-21 13:39:37 +00:00
Ayaz Salikhov
4918f3bb20
chore: Add doxygen in pre-commit image ( #7836 )
2026-07-21 13:38:26 +00:00
Vito
cc03abd79b
adds LEVersion field to Vault
2026-07-21 15:26:16 +02:00
Mayukha Vadari
ee0a3dfad7
ci: Improve test debuggability ( #7619 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-21 13:14:40 +00:00
Vito Tumas
c0bd10ccec
Merge branch 'develop' into tapanito/lending-cash-basis
2026-07-21 11:31:19 +02:00
Bart
042c9660cd
chore: Add CODEOWNERS for CI-related changes ( #7832 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-07-20 21:06:24 +00:00
Ayaz Salikhov
60b49f3fe0
ci: Use in-house image for pre-commit ( #7610 )
2026-07-20 19:11:09 +00:00
Ayaz Salikhov
4c869ee16c
ci: Build separate pre-commit docker image ( #7831 )
2026-07-20 17:40:38 +00:00
Ayaz Salikhov
b2f45813e0
chore: Workaround boost compiler resolution inside Nix environment ( #7826 )
2026-07-20 14:04:08 +00:00
Vito
c1a0f94c2e
feat: Implement LendingProtocolV1_1 cash-basis accounting
...
Gate Vault AssetsTotal and LoanBroker DebtTotal to principal-only
tracking under featureLendingProtocolV1_1, replacing whole-life
(accrual) interest recognition. Adds Accrual/CashBasis namespaces and
three public dispatchers in LendingHelpers, consumed by LoanSet,
LoanPay, and LoanManage without any amendment-awareness in the
transactors themselves. Pre-amendment behavior is unchanged.
2026-07-16 18:12:42 +02:00
Vito Tumas
5ce0b1c2c7
refactor: Restructure LendingHelpers to improve readability ( #7807 )
2026-07-16 15:47:56 +00:00
Andrzej Budzanowski
701311f27e
test: Add google benchmark dependency and migrate nodestore timing test as a benchmark ( #7317 )
...
Co-authored-by: Marek Foss <marek.foss@neti-soft.com >
Co-authored-by: Alex Kremer <akremer@ripple.com >
2026-07-16 15:44:43 +00:00
Sergey Kuznetsov
b1a670c46e
ci: Add Rust to CI ( #7808 )
...
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-07-16 15:28:04 +00:00
Bart
18e311e1e2
chore: Bump version to 3.3.0-rc1 ( #7806 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
3.3.0-rc1
2026-07-16 13:54:12 +00:00
Denis Angell
69b70d7a0d
fix: Refactor Batch Transaction IDs ( #7736 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
2026-07-16 13:15:59 +00:00
Mayukha Vadari
b42cde3e85
refactor: Remove redundant enable checks in ConfidentialMPT txs ( #7809 )
2026-07-16 09:51:19 +00:00
Peter Chen
cd38c0e800
chore: Update mpt-crypto-lib to 0.4.0-rc4 ( #7813 )
2026-07-15 23:47:22 +00:00
Vlad
433e5f6896
fix: Reject zero CheckID in CheckCancel and CheckCash ( #7685 )
2026-07-15 22:08:45 +00:00