ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-28 17:40:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Drop obsolete amendment-disabled cash-basis dispatch cases

Browse Source 
Now that cashBasisEnabled only checks the Vault's LEVersion, dispatch
no longer depends on the amendment flag. The "amendment disabled picks
Accrual" sub-cases fed a CashBasis-versioned vault while disabling the
amendment, a combination that can no longer occur (LEVersion is fixed
at Vault creation) and that the current dispatch correctly ignores,
so they failed. The remaining legacy-vault/cash-basis-vault cases
already cover the dispatch logic.
This commit is contained in:
Vito
2026-07-27 14:39:27 +02:00
parent 0e19cf9c3d
commit ed4c5e141c
1 changed files with 0 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/test/app/LendingHelpers_test.cpp
View File

@@ -1668,18 +1668,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
auto const legacyVault = makeVaultSle();
auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis);
{
testcase("loanOriginationDeltas dispatcher: amendment disabled picks Accrual");
Env env{*this};
env.disableFeature(featureLendingProtocolV1_1);
auto const deltas =
loanOriginationDeltas(cashBasisVault, principalRequested, interestDue);
auto const expected =
xrpl::Accrual::loanOriginationDeltas(principalRequested, interestDue);
BEAST_EXPECT(deltas.assetsTotalDelta == expected.assetsTotalDelta);
BEAST_EXPECT(deltas.debtTotalDelta == expected.debtTotalDelta);
}
{
testcase(
"loanOriginationDeltas dispatcher: amendment enabled, legacy vault picks "
@@ -1718,18 +1706,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
auto const legacyVault = makeVaultSle(std::nullopt, vaultMaximum, vaultTotal);
auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis, vaultMaximum, vaultTotal);
{
testcase(
"loanOriginationExceedsVaultMaximum dispatcher: amendment disabled picks "
"Accrual");
Env env{*this};
env.disableFeature(featureLendingProtocolV1_1);
BEAST_EXPECT(
loanOriginationExceedsVaultMaximum(cashBasisVault, vaultTotal, interestDue) ==
xrpl::Accrual::loanOriginationExceedsVaultMaximum(
vaultMaximum, vaultTotal, interestDue));
}
{
testcase(
"loanOriginationExceedsVaultMaximum dispatcher: amendment enabled, legacy vault "
@@ -1760,15 +1736,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
auto const legacyVault = makeVaultSle();
auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis);
{
testcase("loanVaultExposure dispatcher: amendment disabled picks Accrual");
Env env{*this};
env.disableFeature(featureLendingProtocolV1_1);
auto sle = makeLoanSle(Number{1'000}, Number{800}, Number{50});
BEAST_EXPECT(
loanVaultExposure(cashBasisVault, sle) == xrpl::Accrual::loanVaultExposure(sle));
}
{
testcase("loanVaultExposure dispatcher: amendment enabled, legacy vault picks Accrual");
Env const env{*this};
@@ -1803,16 +1770,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
auto const legacyVault = makeVaultSle();
auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis);
{
testcase("loanPaymentDeltas dispatcher: amendment disabled picks Accrual");
Env env{*this};
env.disableFeature(featureLendingProtocolV1_1);
auto const deltas = loanPaymentDeltas(cashBasisVault, parts);
auto const expected = xrpl::Accrual::loanPaymentDeltas(parts);
BEAST_EXPECT(deltas.assetsTotalDelta == expected.assetsTotalDelta);
BEAST_EXPECT(deltas.debtTotalDelta == expected.debtTotalDelta);
}
{
testcase("loanPaymentDeltas dispatcher: amendment enabled, legacy vault picks Accrual");
Env const env{*this};