From ed4c5e141c3057659ccbe384c2abe465090ba8b0 Mon Sep 17 00:00:00 2001
From: Vito <5780819+Tapanito@users.noreply.github.com>
Date: Mon, 27 Jul 2026 14:39:27 +0200
Subject: [PATCH] test: Drop obsolete amendment-disabled cash-basis dispatch
 cases

Now that cashBasisEnabled only checks the Vault's LEVersion, dispatch
no longer depends on the amendment flag. The "amendment disabled picks
Accrual" sub-cases fed a CashBasis-versioned vault while disabling the
amendment, a combination that can no longer occur (LEVersion is fixed
at Vault creation) and that the current dispatch correctly ignores,
so they failed. The remaining legacy-vault/cash-basis-vault cases
already cover the dispatch logic.
---
 src/test/app/LendingHelpers_test.cpp | 43 ----------------------------
 1 file changed, 43 deletions(-)

diff --git a/src/test/app/LendingHelpers_test.cpp b/src/test/app/LendingHelpers_test.cpp
index 94f5813bd8..1235920fab 100644
--- a/src/test/app/LendingHelpers_test.cpp
+++ b/src/test/app/LendingHelpers_test.cpp
@@ -1668,18 +1668,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
         auto const legacyVault = makeVaultSle();
         auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis);
 
-        {
-            testcase("loanOriginationDeltas dispatcher: amendment disabled picks Accrual");
-            Env env{*this};
-            env.disableFeature(featureLendingProtocolV1_1);
-            auto const deltas =
-                loanOriginationDeltas(cashBasisVault, principalRequested, interestDue);
-            auto const expected =
-                xrpl::Accrual::loanOriginationDeltas(principalRequested, interestDue);
-            BEAST_EXPECT(deltas.assetsTotalDelta == expected.assetsTotalDelta);
-            BEAST_EXPECT(deltas.debtTotalDelta == expected.debtTotalDelta);
-        }
-
         {
             testcase(
                 "loanOriginationDeltas dispatcher: amendment enabled, legacy vault picks "
@@ -1718,18 +1706,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
         auto const legacyVault = makeVaultSle(std::nullopt, vaultMaximum, vaultTotal);
         auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis, vaultMaximum, vaultTotal);
 
-        {
-            testcase(
-                "loanOriginationExceedsVaultMaximum dispatcher: amendment disabled picks "
-                "Accrual");
-            Env env{*this};
-            env.disableFeature(featureLendingProtocolV1_1);
-            BEAST_EXPECT(
-                loanOriginationExceedsVaultMaximum(cashBasisVault, vaultTotal, interestDue) ==
-                xrpl::Accrual::loanOriginationExceedsVaultMaximum(
-                    vaultMaximum, vaultTotal, interestDue));
-        }
-
         {
             testcase(
                 "loanOriginationExceedsVaultMaximum dispatcher: amendment enabled, legacy vault "
@@ -1760,15 +1736,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
         auto const legacyVault = makeVaultSle();
         auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis);
 
-        {
-            testcase("loanVaultExposure dispatcher: amendment disabled picks Accrual");
-            Env env{*this};
-            env.disableFeature(featureLendingProtocolV1_1);
-            auto sle = makeLoanSle(Number{1'000}, Number{800}, Number{50});
-            BEAST_EXPECT(
-                loanVaultExposure(cashBasisVault, sle) == xrpl::Accrual::loanVaultExposure(sle));
-        }
-
         {
             testcase("loanVaultExposure dispatcher: amendment enabled, legacy vault picks Accrual");
             Env const env{*this};
@@ -1803,16 +1770,6 @@ class LendingHelpers_test : public beast::unit_test::Suite
         auto const legacyVault = makeVaultSle();
         auto const cashBasisVault = makeVaultSle(VaultVersion::CashBasis);
 
-        {
-            testcase("loanPaymentDeltas dispatcher: amendment disabled picks Accrual");
-            Env env{*this};
-            env.disableFeature(featureLendingProtocolV1_1);
-            auto const deltas = loanPaymentDeltas(cashBasisVault, parts);
-            auto const expected = xrpl::Accrual::loanPaymentDeltas(parts);
-            BEAST_EXPECT(deltas.assetsTotalDelta == expected.assetsTotalDelta);
-            BEAST_EXPECT(deltas.debtTotalDelta == expected.debtTotalDelta);
-        }
-
         {
             testcase("loanPaymentDeltas dispatcher: amendment enabled, legacy vault picks Accrual");
             Env const env{*this};