tequ
1adaeac8a7
fix L14
2026-03-23 12:14:44 +09:00
tequ
7ddda1b1e6
fix L5
2026-03-23 12:01:30 +09:00
tequ
5280a185d0
fix L4
2026-03-23 11:59:46 +09:00
tequ
64f699a974
fix M17
2026-03-23 11:14:41 +09:00
tequ
968493f43b
fix M16
2026-03-23 11:10:45 +09:00
tequ
22bfc5e743
fix M15
2026-03-23 11:02:59 +09:00
tequ
2f0adfae3b
fix M11
2026-03-23 10:55:42 +09:00
tequ
53bdfb2bc7
Add comment to clarify that the door account should not have a sponsor in the reserve check
2026-03-23 10:28:27 +09:00
tequ
b695b4bf9b
Add comments for PreFunded sponsor reserve checks on TrustSet
2026-03-23 10:27:18 +09:00
tequ
6d7ffcbb91
fix M7
2026-03-19 15:39:55 +09:00
tequ
d1346fa3f6
fix M6
2026-03-19 15:14:14 +09:00
tequ
d6803868a1
fix M5
2026-03-19 15:00:09 +09:00
tequ
9a6432dd66
fix M3
2026-03-19 14:50:09 +09:00
tequ
f8a8c2301c
fix M2
2026-03-19 14:33:55 +09:00
tequ
e40e15a866
fix C2, C4
2026-03-19 14:01:11 +09:00
tequ
6555001cd9
make sponsor helpers inline
2026-03-19 11:50:55 +09:00
tequ
f13945eff9
Merge remote-tracking branch 'upstream/develop' into sponsor
2026-03-19 11:10:44 +09:00
Alex Kremer
12954d5392
fix: Address remaining issue after clang-tidy merge ( #6582 )
2026-03-18 22:41:09 +00:00
Jingchen
b1e5ba0518
feat: Add code generator for transactions and ledger entries ( #6443 )
...
Signed-off-by: JCW <a1q123456@users.noreply.github.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-18 21:11:51 +00:00
Mayukha Vadari
d360e7c5b6
refactor: Rename transactor files/classes to match the tx name ( #6580 )
2026-03-18 19:52:07 +00:00
Ayaz Salikhov
804a351773
ci: Use external action implementation of check-pr-title ( #6578 )
2026-03-18 18:31:42 +00:00
Ayaz Salikhov
697fb64e8c
ci: Don't check PR title for drafts ( #6573 )
2026-03-18 17:46:27 +00:00
Alex Kremer
57e4cbbcd9
refactor: Add simple clang-tidy readability checks ( #6556 )
...
This change enables the following clang-tidy checks:
- readability-avoid-nested-conditional-operator,
- readability-avoid-return-with-void-value,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-contains,
- readability-container-size-empty,
- readability-else-after-return,
- readability-make-member-function-const,
- readability-redundant-casting,
- readability-redundant-inline-specifier,
- readability-redundant-member-init,
- readability-redundant-string-init,
- readability-reference-to-constructed-temporary,
- readability-static-definition
2026-03-18 16:41:49 +00:00
Mayukha Vadari
b92a9a3053
fix: Make assorted NFT fixes ( #6566 )
...
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
2026-03-18 14:47:59 +00:00
Mayukha Vadari
dcaef828b4
refactor: Replace !=/== tesSuccess with using isTesSuccess ( #6409 )
...
This change replaces all instances of `<variable> != tesSUCCESS` with `!isTesSuccess(<variable>)` and `<variable> == tesSUCCESS` with `isTesSuccess(<variable>)`.
2026-03-18 14:15:10 +00:00
yinyiqian1
6fbeb04d9e
fix: Disallow empty permission list when Delegate object is absent ( #6542 )
...
This change fixes delegation:
* If the Delegate object is not present, we should disallow empty permission list in DelegateSet preclaim.
* Empty permission list is only allowed to delete the existing Delegate object.
* In `doApply`, permission list being empty returns `tecINTERNAL`, which should not happen.
2026-03-18 13:39:31 +00:00
Alex Kremer
2a325e7e2c
chore: Enable clang-tidy bugprone-use-after-move check ( #6476 )
2026-03-18 00:12:06 +00:00
Bart
808e814489
ci: Update check-pr-title action hash ( #6572 )
2026-03-17 23:26:01 +00:00
Copilot
9e14707e77
fix: Peer crawler port field type inconsistency ( #6318 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Bart <bthomee@users.noreply.github.com >
2026-03-17 22:03:56 +00:00
Mayukha Vadari
95a45d7442
chore: Add comment explaining why ammLPHolds is called twice ( #6546 )
2026-03-17 20:11:36 +00:00
Bart
5fc4ab3e37
ci: Let required runs be triggered by merge group events ( #6563 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-03-17 20:03:48 +00:00
tequ
b129b71c33
refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() ( #6560 )
2026-03-17 15:56:51 -04:00
tequ
013c2d6a56
refactor: Add const qualifier to SLE in verifyDepositPreauth parameter ( #6555 )
2026-03-17 19:33:18 +00:00
Alex Kremer
72f4cb097f
refactor: Enable remaining clang-tidy cppcoreguidelines checks ( #6538 )
2026-03-17 19:09:05 +00:00
Michael Legleux
b523770486
fix: Remove nonexistent boost::coroutine2 library ( #6561 )
2026-03-17 18:46:46 +00:00
Mayukha Vadari
a5185890ff
refactor: Remove dead code in escrow helper logic ( #6553 )
2026-03-17 18:13:08 +00:00
Jingchen
0a9513e7f3
ci: Fix build errors on Windows ( #6562 )
2026-03-17 13:50:44 -04:00
tequ
b32ff18c21
refactor getFeePayer()
2026-03-18 00:19:21 +09:00
tequ
8baec5634c
pre-commit run --all-files
2026-03-18 00:03:31 +09:00
tequ
37c95ead69
Merge remote-tracking branch 'upstream/develop' into sponsor
2026-03-18 00:02:57 +09:00
Mayukha Vadari
78b2d70a11
refactor: Assorted small DID fixes ( #6552 )
...
This change:
* Makes `addSLE` in `DIDSet` a static function, instead of a free function.
* Renames `Attestation` to `Data` everywhere (an artifact of a previous name for the field).
* Actually runs a set of tests that were not included in the `run` function of `DID_test`.
2026-03-17 14:44:07 +00:00
Mayukha Vadari
252c6768df
refactor: Clean up getFeePayer, mSourceBalance, and mPriorBalance ( #6478 )
...
This change:
* Introduces a new helper function on `STTx`, `getFeePayer`.
* Removes the usage of `mSourceBalance` and replaces it with SLE balance lookups.
* Renames `mPriorBalance` to `preFeeBalance_`
This simplifies some of the code in the transactors and makes it a lot more readable.
2026-03-17 14:12:16 +00:00
Pratik Mankawde
5ae97fa8ae
refactor: Add no-ASAN macro for Throw statements ( #6373 )
...
Throwing exceptions from code sometime confuses ASAN, as it cannot keep track of stack frames. This change therefore adds a macro to skip instrumentation around the `Throw` function.
2026-03-17 13:10:32 +00:00
tequ
234d2e5414
Refactor ownerCount and calculateReserve to use SLE::const_ref
2026-03-17 21:38:25 +09:00
tequ
024ab07eb4
minor fixes
2026-03-17 21:35:08 +09:00
tequ
d95b6e41e5
Refactor variable declarations in xrpLiquid
2026-03-17 21:15:41 +09:00
tequ
8d75f3bdc6
remove asfDisallowIncomingSponsor
2026-03-17 21:13:35 +09:00
tequ
eb7e01de7e
Remove unused tx parameter from removeEmptyHolding()
2026-03-17 21:04:40 +09:00
tequ
c79814a037
remove unused Sponsor.h
2026-03-17 20:39:57 +09:00
tequ
15be71469d
remove unnecessary reserveCount check
2026-03-17 20:35:50 +09:00
