Mayukha Vadari
0a1708dbfe
docs: Add subsystem AGENTS.md files for transactors, ledger helpers, and READMEs
...
Round 2 of PR-review mining: found two subsystem-specific, unrecorded
conventions (pseudo-account auth/freeze exemption in vault/lending
transactors; SLE-type assertion in ledger helpers) that warrant their
own nested AGENTS.md rather than more root-level bullets.
Also added thin AGENTS.md pointer files (with CLAUDE.md symlinks,
matching the existing convention) for subsystems that already have a
substantial README.md but no AGENTS.md — agent tooling auto-loads
AGENTS.md when working in a directory but not README.md, so those
conventions were otherwise invisible to an agent that didn't think to
look.
2026-09-08 17:05:08 -04:00
Mayukha Vadari
5b6cd13a59
docs: Codify recurring PR review feedback into AGENTS.md
...
Mined 6 months of merged PR review comments (human reviewers only) for
conventions that recur across multiple PRs/reviewers but aren't already
documented in CONTRIBUTING.md/CodingStyle.md, and folded them in:
- Doxygen comments expected on new public functions/methods.
- API-CHANGELOG.md requirement is repo-wide, not RPC-directory-scoped.
- Shared test setup belongs in jtx/, not copy-pasted across test files.
- Amendment requirement test and a design-considerations checklist,
sourced from the internal "Considerations for Future Amendments" doc.
- Amendment gating shape (single enabled/disabled block), per-amendment
flag naming, and UNREACHABLE/LCOV_EXCL pairing, all recurring asks in
tx/vault/invariant PR reviews.
2026-09-04 23:07:38 -04:00
Mayukha Vadari
e3c8996e44
feat: Add fixCleanup3_5_0 amendment placeholder ( #8174 )
2026-09-05 00:06:14 +00:00
yinyiqian1
d5bfe94f15
feat: Support key rotation in MPTokenIssuanceSet ( #7915 )
2026-09-03 21:13:06 +00:00
Bart
2ad4def35f
chore: Bump version to 3.4.0-rc1 ( #8171 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
3.4.0-rc1
2026-09-03 20:07:24 +00:00
Mayukha Vadari
f7f50caa6e
docs: Backfill API-CHANGELOG.md for 3.1.1 through 3.3.0 ( #8159 )
2026-09-03 19:48:15 +00:00
Ayaz Salikhov
3e54e7d00b
fix: Don't use github.workspace as it slow downs gcovr ( #8173 )
2026-09-03 19:20:38 +00:00
Valentin Balaschenko
827b50f169
fix: Flaky online delete tests, and cover the health checks added in #5531 ( #8137 )
2026-09-03 18:56:30 +00:00
Mayukha Vadari
58a59c37ed
fix: Add signature prefixes for sfCounterpartySignature and sfSponsorSignature ( #8162 )
2026-09-03 17:19:07 +00:00
Ayaz Salikhov
986065c16f
build: Verify glibc version was determined in debian package ( #8170 )
2026-09-03 16:54:54 +00:00
Denis Angell
37cb4cdbe3
fix: Recycle the escrow reserve in EscrowCancel and EscrowFinish ( #8142 )
2026-09-03 16:27:45 +00:00
Bart
2ddf6ee148
ci: Update pre-commit SHA ( #8169 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-09-03 14:52:42 +00:00
Pratik Mankawde
8ce4f71427
docs: Use consistent heading levels in PR template ( #8155 )
2026-09-03 14:48:32 +00:00
Bart
6e1eb88e6e
ci: Update prepare-runner SHA ( #8168 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-09-03 11:52:08 +00:00
Ayaz Salikhov
49cdc105de
fix: Correct and simplify Linux packaging ( #8165 )
2026-09-02 21:18:13 +00:00
Chenna Keshava B S
636d2d4851
fix: Reinforce the priority of AMMClawback in case of insufficient reserves ( #7796 )
...
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-09-02 20:48:53 +00:00
Kassaking7
7d7275847d
fix: PermissionedDEX (CreateOffer/Payment) never deletes expired credentials ( #6827 )
2026-09-02 19:38:01 +00:00
Bart
f0fd6ad85e
fix: Clamp the depth used to index selectBranch's key byte ( #7941 )
...
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com >
2026-09-02 18:06:48 +00:00
Timur Yalymov
5d8fd9824e
fix: Revert credential cleanup for pseudo-accounts ( #8161 )
2026-09-02 15:00:50 +00:00
Vito Tumas
346ea40f69
fix: Allow zero-value MPT vault withdraw when the asset holding is missing ( #8153 )
2026-09-02 13:45:52 +00:00
Vito Tumas
8809bdf3f0
fix: Treat an existing IOU line as a no-op in addEmptyHolding ( #8154 )
2026-09-02 12:15:29 +00:00
Mayukha Vadari
deaf596494
docs: Add AGENTS.md/CLAUDE.md for AI coding agent guidance ( #8067 )
2026-09-01 21:57:34 +00:00
Vito Tumas
7863ac8cf6
fix: Add 60s buffer before closed-ended vault redemption ( #8151 )
2026-09-01 18:27:05 +00:00
Vito Tumas
b3b38e4416
fix: Correct fee-payer XRP delta in ValidVault for sponsored VaultWithdraw ( #8141 )
2026-09-01 14:43:11 +00:00
Vito Tumas
ccd5dc5e06
fix: Keep LoanBrokerDelete valid for auth-required MPT cover ( #8144 )
2026-09-01 14:40:53 +00:00
Vito Tumas
b2453b626e
fix: Unblock VaultSet and cash-basis LoanSet at AssetsMaximum ( #8143 )
2026-09-01 14:06:17 +00:00
Vito Tumas
de6e5d3a94
fix: Keep VaultDeposit share count after the assetsTotal clamp ( #8140 )
2026-09-01 13:51:39 +00:00
Copilot
fac20a06f3
refactor: Add common helper function for injected metadata fields in RPCs ( #5706 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: Mayukha Vadari <mvadari@gmail.com >
Co-authored-by: Mayukha Vadari <mvadari@ripple.com >
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
Co-authored-by: Cursor <cursoragent@cursor.com >
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com >
2026-08-31 17:21:25 +00:00
Ayaz Salikhov
9a7c5ea593
chore: Bump version to 3.4.0-b3 ( #8132 )
3.4.0-b3
2026-08-27 17:26:55 +00:00
Jingchen
7281e0606a
feat: Add vault invariants ( #7732 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-27 17:15:17 +00:00
Jingchen
71f5555873
feat: Remove pseudo account field filter ( #8042 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-27 13:52:23 +00:00
Ayaz Salikhov
3967ed6d54
build: Update release-info to get better pkg_release ( #8131 )
2026-08-27 13:34:38 +00:00
Vito Tumas
e0151229b6
fix: Waive unrealized-loss discount on sole-holder VaultClawback ( #8119 )
2026-08-27 08:15:38 +00:00
Ayaz Salikhov
b6a899583b
build: Make packaging reusable ( #8126 )
2026-08-26 19:44:31 +00:00
Gregory Tsipenyuk
dc3bd9cf00
fix: Fix MPT/DEX Audit/Attackathon reports (Phase 1) ( #7334 )
2026-08-26 18:09:46 +00:00
Vito Tumas
1e8b136bfb
feat: Enable LendingProtocolV1_1 amendment ( #8125 )
2026-08-26 17:35:54 +00:00
Vito Tumas
3c47af779c
fix: Clamp Vault Deposit, Withdraw, and Clawback to assetsTotal grid ( #8057 )
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
2026-08-26 17:02:05 +00:00
Ayaz Salikhov
c28d389e0e
build: Refactor generate.py to make packaging_config part of config ( #8115 )
2026-08-26 14:04:58 +00:00
Ayaz Salikhov
d83a84510e
chore: Bump version to 3.4.0-b2 ( #8120 )
3.4.0-b2
2026-08-26 14:03:01 +00:00
Timur Yalymov
f8fba079fe
fix: Refuse a pseudo-account as the vault clawback holder ( #8111 )
...
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com >
2026-08-26 13:55:04 +00:00
Sergey Kuznetsov
42502e4263
ci: Update CI image ( #8121 )
2026-08-26 13:42:19 +00:00
Vito Tumas
36c165f74d
fix: Prevent early loan impairment and due-date manipulation ( #6557 )
...
Co-authored-by: Ed Hennis <ed@ripple.com >
Co-authored-by: Timur Yalymov <36795566+tyalymov@users.noreply.github.com >
2026-08-26 13:38:24 +00:00
Peter Chen
f7ea645bf4
fix: AMMClawback exact LP token boundary ( #7373 )
2026-08-26 13:14:53 +00:00
Ayaz Salikhov
50527485d3
build: Rename release channels: unstable->rc, experimental->beta ( #8116 )
2026-08-26 13:13:59 +00:00
Vito Tumas
421af6db79
fix: Reject open-ended vaults at LoanBrokerSet ( #8076 )
...
Co-authored-by: Kenny Lei <3003853+kennyzlei@users.noreply.github.com >
2026-08-26 00:08:25 +00:00
Ayaz Salikhov
fee4bfc22e
build: Implement packaging in Python ( #8109 )
2026-08-25 19:32:03 +00:00
Vito Tumas
5e3d20b3ed
fix: Prevent vault clawback and withdraw overrun ( #8075 )
2026-08-25 17:59:37 +00:00
Ayaz Salikhov
9e2aaf6f60
build: Add rust-toolchain.toml to .envrc ( #8107 )
2026-08-25 17:09:03 +00:00
Vito Tumas
ec042fefee
fix: Absorb Vault invariant rounding noise ( #8055 )
2026-08-25 17:07:58 +00:00
Ayaz Salikhov
45e4b8899d
build: Update packaging images; add Python ( #8106 )
2026-08-25 14:34:41 +00:00