ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-09-27 15:28:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Keep VaultDeposit share count after the assetsTotal clamp (#8140)

Browse Source
This commit is contained in:
Vito Tumas
2026-09-01 13:51:39 +00:00
committed by GitHub
parent fac20a06f3
commit de6e5d3a94
2 changed files with 10 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/libxrpl/tx/transactors/vault/VaultDeposit.cpp
View File

@@ -347,37 +347,14 @@ VaultDeposit::doApply()
if (fix340Enabled)
{
// Round down at the posterior sfAssetsTotal scale so the vault is credited by no more
// than the depositor paid.
// than the depositor paid. Keep the share count from the first round trip: the clamp
// only drops a last digit of the new total. Converting the clamped amount back to
// shares would mint fewer shares while still charging the N-share debit.
auto const maybeClamped = clampToAssetsTotalScale(vault, assetsDeposited);
if (!maybeClamped)
return maybeClamped.error();
assetsDeposited = *maybeClamped;
// The pre-clamp share count would over-issue by the trimmed ULP and give the depositor
// more value than they credited.
auto const maybeReShares = assetsToSharesDeposit(vault, sleIssuance, assetsDeposited);
if (!maybeReShares)
return tecINTERNAL; // LCOV_EXCL_LINE
sharesCreated = *maybeReShares;
if (sharesCreated == beast::kZero)
return tecPRECISION_LOSS;
// The re-derived share count would over-issue if it round-trips back to more assets
// than the clamped amount actually paid. Unreachable unless a conversion helper is
// broken.
// LCOV_EXCL_START
auto const maybeReAssets = sharesToAssetsDeposit(vault, sleIssuance, sharesCreated);
if (!maybeReAssets)
return tecINTERNAL;
if (*maybeReAssets > assetsDeposited)
{
JLOG(j_.error()) << "VaultDeposit: would take more than offered.";
return tecINTERNAL;
}
// LCOV_EXCL_STOP
// The actual deposit amount is truncated to whole shares, converted back to assets,
// and clamped to the sfAssetsTotal scale (post-fixCleanup3_4_0). Check the depositor's
// balance here—after clamping—before making any state changes.

9
src/test/app/vault/VaultTransactorPrecision_test.cpp
View File

@@ -92,9 +92,14 @@ class VaultTransactorPrecision_test : public VaultPrecisionFixture
if (before.sharesTotal == Number{0})
continue;
Number const shareValue = (before.assetsTotal * sharesMinted) / before.sharesTotal;
// The depositor is never charged more than the shares they received are worth.
BEAST_EXPECTS(
shareValue <= tDelta,
"amount=" + std::to_string(amount) + " shareValue > assetsTaken");
tDelta <= shareValue,
"amount=" + std::to_string(amount) + " assetsTaken > shareValue");
// Discount is strictly less than one ULP of the new AssetsTotal
BEAST_EXPECTS(
shareValue - tDelta < oneUnit(asset.raw(), after.assetsTotal),
"amount=" + std::to_string(amount) + " discount is not below one unit");
}
{