ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 16:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Copilot review feedback

Browse Source
This commit is contained in:
Bart
2026-03-01 15:10:57 -05:00
parent ddc15ad612
commit ebf336f472
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libxrpl/shamap/SHAMapSync.cpp
View File

@@ -486,7 +486,7 @@ SHAMap::addRootNode(
intr_ptr::SharedPtr<SHAMapTreeNode> rootNode,
SHAMapSyncFilter const* filter)
{
XRPL_ASSERT(rootNode, "xrpl::SHAMap::addKnownNode : non-null root node");
XRPL_ASSERT(rootNode, "xrpl::SHAMap::addRootNode : non-null root node");
if (!rootNode)
{
JLOG(journal_.error()) << "Null node received";

2
src/test/app/LedgerNodeHelpers_test.cpp
View File

@@ -1,5 +1,3 @@
#include <test/jtx.h>
#include <test/jtx/Env.h>
#include <test/shamap/common.h>
#include <xrpld/app/ledger/detail/LedgerNodeHelpers.h>

4
src/xrpld/overlay/detail/PeerImp.cpp
View File

@@ -3252,6 +3252,8 @@ PeerImp::processLedgerRequest(std::shared_ptr<protocol::TMGetLedger> const& m)
try
{
auto const useLedgerNodeDepth = supportsFeature(ProtocolFeature::LedgerNodeDepth);
if (map->getNodeFat(*shaMapNodeId, data, fatLeaves, queryDepth))
{
JLOG(p_journal_.trace())
@@ -3271,7 +3273,7 @@ PeerImp::processLedgerRequest(std::shared_ptr<protocol::TMGetLedger> const& m)
// we always set the node ID. However, when it is supported then we only set
// it for inner nodes, while for leaf nodes we set the node depth instead.
auto const& nodeID = std::get<0>(d);
if (!supportsFeature(ProtocolFeature::LedgerNodeDepth))
if (!useLedgerNodeDepth)
node->set_nodeid(nodeID.getRawString());
else if (std::get<2>(d))
node->set_depth(nodeID.getDepth());