From ebf336f47270e4135bacb010d4229b380997f1d7 Mon Sep 17 00:00:00 2001
From: Bart <11445373+bthomee@users.noreply.github.com>
Date: Sun, 1 Mar 2026 15:10:57 -0500
Subject: [PATCH] Copilot review feedback

---
 src/libxrpl/shamap/SHAMapSync.cpp       | 2 +-
 src/test/app/LedgerNodeHelpers_test.cpp | 2 --
 src/xrpld/overlay/detail/PeerImp.cpp    | 4 +++-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libxrpl/shamap/SHAMapSync.cpp b/src/libxrpl/shamap/SHAMapSync.cpp
index f6936cdccc..1a80604116 100644
--- a/src/libxrpl/shamap/SHAMapSync.cpp
+++ b/src/libxrpl/shamap/SHAMapSync.cpp
@@ -486,7 +486,7 @@ SHAMap::addRootNode(
     intr_ptr::SharedPtr<SHAMapTreeNode> rootNode,
     SHAMapSyncFilter const* filter)
 {
-    XRPL_ASSERT(rootNode, "xrpl::SHAMap::addKnownNode : non-null root node");
+    XRPL_ASSERT(rootNode, "xrpl::SHAMap::addRootNode : non-null root node");
     if (!rootNode)
     {
         JLOG(journal_.error()) << "Null node received";
diff --git a/src/test/app/LedgerNodeHelpers_test.cpp b/src/test/app/LedgerNodeHelpers_test.cpp
index 076d9c1d19..8a9b32d474 100644
--- a/src/test/app/LedgerNodeHelpers_test.cpp
+++ b/src/test/app/LedgerNodeHelpers_test.cpp
@@ -1,5 +1,3 @@
-#include <test/jtx.h>
-#include <test/jtx/Env.h>
 #include <test/shamap/common.h>
 
 #include <xrpld/app/ledger/detail/LedgerNodeHelpers.h>
diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp
index bf769929be..742ec1645f 100644
--- a/src/xrpld/overlay/detail/PeerImp.cpp
+++ b/src/xrpld/overlay/detail/PeerImp.cpp
@@ -3252,6 +3252,8 @@ PeerImp::processLedgerRequest(std::shared_ptr<protocol::TMGetLedger> const& m)
 
             try
             {
+                auto const useLedgerNodeDepth = supportsFeature(ProtocolFeature::LedgerNodeDepth);
+
                 if (map->getNodeFat(*shaMapNodeId, data, fatLeaves, queryDepth))
                 {
                     JLOG(p_journal_.trace())
@@ -3271,7 +3273,7 @@ PeerImp::processLedgerRequest(std::shared_ptr<protocol::TMGetLedger> const& m)
                         // we always set the node ID. However, when it is supported then we only set
                         // it for inner nodes, while for leaf nodes we set the node depth instead.
                         auto const& nodeID = std::get<0>(d);
-                        if (!supportsFeature(ProtocolFeature::LedgerNodeDepth))
+                        if (!useLedgerNodeDepth)
                             node->set_nodeid(nodeID.getRawString());
                         else if (std::get<2>(d))
                             node->set_depth(nodeID.getDepth());