ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Log.cpp: ToLowerBase16 requires nostd::span, not raw char arrays

Browse Source 
The OTel SDK's TraceId::ToLowerBase16 and SpanId::ToLowerBase16 expect
opentelemetry::nostd::span<char, N> rather than raw char arrays. Also
corrected array sizes from 33/17 to 32/16 (no null terminator needed
since we use output.append(buf, N)).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Pratik Mankawde
2026-03-11 11:05:53 +00:00
parent 124a510a53
commit 7192a374a8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libxrpl/basics/Log.cpp
View File

@@ -366,9 +366,9 @@ Logs::format(
{
// Append trace context as structured key=value fields that the
// OTel Collector filelog receiver regex_parser can extract.
char traceId[33], spanId[17];
ctx.trace_id().ToLowerBase16(traceId);
ctx.span_id().ToLowerBase16(spanId);
char traceId[32], spanId[16];
ctx.trace_id().ToLowerBase16(opentelemetry::nostd::span<char, 32>{traceId});
ctx.span_id().ToLowerBase16(opentelemetry::nostd::span<char, 16>{spanId});
output += "trace_id=";
output.append(traceId, 32);
output += " span_id=";