From 7192a374a8ea5f8aa7c2d3740d5b4276c84b57c3 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Wed, 11 Mar 2026 11:05:53 +0000 Subject: [PATCH] Fix Log.cpp: ToLowerBase16 requires nostd::span, not raw char arrays The OTel SDK's TraceId::ToLowerBase16 and SpanId::ToLowerBase16 expect opentelemetry::nostd::span rather than raw char arrays. Also corrected array sizes from 33/17 to 32/16 (no null terminator needed since we use output.append(buf, N)). Co-Authored-By: Claude Opus 4.6 --- src/libxrpl/basics/Log.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libxrpl/basics/Log.cpp b/src/libxrpl/basics/Log.cpp index 6cbc477bff..e686effe5a 100644 --- a/src/libxrpl/basics/Log.cpp +++ b/src/libxrpl/basics/Log.cpp @@ -366,9 +366,9 @@ Logs::format( { // Append trace context as structured key=value fields that the // OTel Collector filelog receiver regex_parser can extract. - char traceId[33], spanId[17]; - ctx.trace_id().ToLowerBase16(traceId); - ctx.span_id().ToLowerBase16(spanId); + char traceId[32], spanId[16]; + ctx.trace_id().ToLowerBase16(opentelemetry::nostd::span{traceId}); + ctx.span_id().ToLowerBase16(opentelemetry::nostd::span{spanId}); output += "trace_id="; output.append(traceId, 32); output += " span_id=";