ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-08 03:07:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review feedback

Browse Source
This commit is contained in:
Bart
2026-06-07 16:50:49 -04:00
parent e51d6680a1
commit 6c388b434d
6 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/xrpl/basics/StringUtilities.h
View File

@@ -11,6 +11,7 @@
#include <cstdint>
#include <optional>
#include <string>
#include <string_view>
#include <type_traits>
namespace xrpl {

1
include/xrpl/basics/base64.h
View File

@@ -36,6 +36,7 @@
#include <cstdint>
#include <string>
#include <string_view>
namespace xrpl {

2
include/xrpl/beast/unit_test/match.h
View File

@@ -53,7 +53,7 @@ public:
template <class>
Selector::Selector(ModeT mode, std::string pattern) : mode_(mode), pat_(std::move(pattern))
{
if (mode_ == ModeT::Automatch && pattern.empty())
if (mode_ == ModeT::Automatch && pat_.empty())
mode_ = ModeT::All;
}

1
include/xrpl/shamap/SHAMapNodeID.h
View File

@@ -5,6 +5,7 @@
#include <optional>
#include <string>
#include <string_view>
#include <tuple>
namespace xrpl {

5
src/libxrpl/ledger/CanonicalTXSet.cpp
View File

@@ -42,9 +42,8 @@ CanonicalTXSet::accountKey(AccountID const& account)
void
CanonicalTXSet::insert(std::shared_ptr<STTx const> txn)
{
Key const key(
accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID());
map_.insert(std::make_pair(key, std::move(txn)));
Key key(accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID());
map_.insert(std::make_pair(std::move(key), std::move(txn)));
}
std::shared_ptr<STTx const>

2
src/xrpld/rpc/Status.h
View File

@@ -43,7 +43,7 @@ public:
}
Status(ErrorCodeI e, std::string s)
: type_(Type::ErrorCodeI), code_(e), messages_({std::move(s)})
: type_(Type::ErrorCodeI), code_(e), messages_(1, std::move(s))
{
}