diff --git a/include/xrpl/basics/StringUtilities.h b/include/xrpl/basics/StringUtilities.h index ae118e95bb..1d3434b7ed 100644 --- a/include/xrpl/basics/StringUtilities.h +++ b/include/xrpl/basics/StringUtilities.h @@ -11,6 +11,7 @@ #include #include #include +#include #include namespace xrpl { diff --git a/include/xrpl/basics/base64.h b/include/xrpl/basics/base64.h index 96a6dacdbf..660958ce14 100644 --- a/include/xrpl/basics/base64.h +++ b/include/xrpl/basics/base64.h @@ -36,6 +36,7 @@ #include #include +#include namespace xrpl { diff --git a/include/xrpl/beast/unit_test/match.h b/include/xrpl/beast/unit_test/match.h index ca6540348d..da466ab228 100644 --- a/include/xrpl/beast/unit_test/match.h +++ b/include/xrpl/beast/unit_test/match.h @@ -53,7 +53,7 @@ public: template Selector::Selector(ModeT mode, std::string pattern) : mode_(mode), pat_(std::move(pattern)) { - if (mode_ == ModeT::Automatch && pattern.empty()) + if (mode_ == ModeT::Automatch && pat_.empty()) mode_ = ModeT::All; } diff --git a/include/xrpl/shamap/SHAMapNodeID.h b/include/xrpl/shamap/SHAMapNodeID.h index ceb458830c..248c9cb80b 100644 --- a/include/xrpl/shamap/SHAMapNodeID.h +++ b/include/xrpl/shamap/SHAMapNodeID.h @@ -5,6 +5,7 @@ #include #include +#include #include namespace xrpl { diff --git a/src/libxrpl/ledger/CanonicalTXSet.cpp b/src/libxrpl/ledger/CanonicalTXSet.cpp index 5d335567ef..ffb50adf40 100644 --- a/src/libxrpl/ledger/CanonicalTXSet.cpp +++ b/src/libxrpl/ledger/CanonicalTXSet.cpp @@ -42,9 +42,8 @@ CanonicalTXSet::accountKey(AccountID const& account) void CanonicalTXSet::insert(std::shared_ptr txn) { - Key const key( - accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID()); - map_.insert(std::make_pair(key, std::move(txn))); + Key key(accountKey(txn->getAccountID(sfAccount)), txn->getSeqProxy(), txn->getTransactionID()); + map_.insert(std::make_pair(std::move(key), std::move(txn))); } std::shared_ptr diff --git a/src/xrpld/rpc/Status.h b/src/xrpld/rpc/Status.h index ec81d833c9..6d064af62e 100644 --- a/src/xrpld/rpc/Status.h +++ b/src/xrpld/rpc/Status.h @@ -43,7 +43,7 @@ public: } Status(ErrorCodeI e, std::string s) - : type_(Type::ErrorCodeI), code_(e), messages_({std::move(s)}) + : type_(Type::ErrorCodeI), code_(e), messages_(1, std::move(s)) { }