fix: Cleanup per self review of code

This commit is contained in:
TimothyBanks
2026-08-17 15:10:35 -04:00
parent 7122bb8a43
commit 6c32ca3538
2 changed files with 0 additions and 19 deletions

View File

@@ -3,15 +3,6 @@
// #define DEBUG_OUTPUT 1
#endif
// The wasm engine is now the Rust `xrpl-wasm-vm` crate, reached only through
// `runEscrowWasm` / `preflightEscrowWasm`. The old C++ engine surface this suite used for
// its lower-level cases -- `WasmEngine`, `createWasmImport` / `WasmImpFunc` /
// `WASM_IMPORT_FUNC2` (arbitrary host imports), and `wasmParams` -- no longer exists, so the
// tests built on it (raw `addTwo` module, ledger-sqn/host-function-cost engine runs, bad
// alignment) were removed; that engine/ABI coverage now lives in the crate tests
// (`crates/xrpl-wasm-vm/tests/budgets.rs`, `memory_policy.rs`). What remains here is the
// app-tier escrow integration that still runs through `runEscrowWasm`.
#include <test/app/TestHostFunctions.h>
#include <test/app/wasm_fixtures/fixtures.h>
#include <test/jtx/Env.h>

View File

@@ -55,13 +55,6 @@ public:
/**
* Minimal AmendmentTable for tests.
*
* The real table is built by `makeAmendmentTable`, which lives in the app (xrpld) tier and
* so cannot link into a libxrpl-tier test binary. But the wasm host only ever calls
* `find(name)` — a name -> amendment-id resolve — and whether an amendment is *enabled* is
* read from the ledger's `Rules`, never from here. So `find` delegates to the feature
* registry (the same source `makeAmendmentTable` would seed from) and every other method,
* unused by these tests, throws if reached.
*/
class TestAmendmentTable final : public AmendmentTable
{
@@ -255,9 +248,6 @@ public:
}
// Protocol and validation services
// See `TestAmendmentTable`: the wasm host only resolves a name -> id here; enabled
// state is read from the ledger's `Rules`. The real factory (`makeAmendmentTable`) is
// app-tier and won't link into a libxrpl test binary, so a stub table is used.
AmendmentTable&
getAmendmentTable() override
{