From 6c32ca353860d1df659209a0458f5da22864ae95 Mon Sep 17 00:00:00 2001 From: TimothyBanks Date: Mon, 17 Aug 2026 15:10:35 -0400 Subject: [PATCH] fix: Cleanup per self review of code --- src/test/app/Wasm_test.cpp | 9 --------- src/tests/libxrpl/helpers/TestServiceRegistry.h | 10 ---------- 2 files changed, 19 deletions(-) diff --git a/src/test/app/Wasm_test.cpp b/src/test/app/Wasm_test.cpp index aa37b41ab3..939fc815c3 100644 --- a/src/test/app/Wasm_test.cpp +++ b/src/test/app/Wasm_test.cpp @@ -3,15 +3,6 @@ // #define DEBUG_OUTPUT 1 #endif -// The wasm engine is now the Rust `xrpl-wasm-vm` crate, reached only through -// `runEscrowWasm` / `preflightEscrowWasm`. The old C++ engine surface this suite used for -// its lower-level cases -- `WasmEngine`, `createWasmImport` / `WasmImpFunc` / -// `WASM_IMPORT_FUNC2` (arbitrary host imports), and `wasmParams` -- no longer exists, so the -// tests built on it (raw `addTwo` module, ledger-sqn/host-function-cost engine runs, bad -// alignment) were removed; that engine/ABI coverage now lives in the crate tests -// (`crates/xrpl-wasm-vm/tests/budgets.rs`, `memory_policy.rs`). What remains here is the -// app-tier escrow integration that still runs through `runEscrowWasm`. - #include #include #include diff --git a/src/tests/libxrpl/helpers/TestServiceRegistry.h b/src/tests/libxrpl/helpers/TestServiceRegistry.h index 66bf520b73..d4211571f3 100644 --- a/src/tests/libxrpl/helpers/TestServiceRegistry.h +++ b/src/tests/libxrpl/helpers/TestServiceRegistry.h @@ -55,13 +55,6 @@ public: /** * Minimal AmendmentTable for tests. - * - * The real table is built by `makeAmendmentTable`, which lives in the app (xrpld) tier and - * so cannot link into a libxrpl-tier test binary. But the wasm host only ever calls - * `find(name)` — a name -> amendment-id resolve — and whether an amendment is *enabled* is - * read from the ledger's `Rules`, never from here. So `find` delegates to the feature - * registry (the same source `makeAmendmentTable` would seed from) and every other method, - * unused by these tests, throws if reached. */ class TestAmendmentTable final : public AmendmentTable { @@ -255,9 +248,6 @@ public: } // Protocol and validation services - // See `TestAmendmentTable`: the wasm host only resolves a name -> id here; enabled - // state is read from the ledger's `Rules`. The real factory (`makeAmendmentTable`) is - // app-tier and won't link into a libxrpl test binary, so a stub table is used. AmendmentTable& getAmendmentTable() override {