ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-09-27 23:38:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Align zero-withdraw comments with missing-recipient path

Browse Source 
ValidVault only allows a missing destination delta when zeroDeltaIsLegitimate; a present zero delta is still rejected.
This commit is contained in:
Vito
2026-09-02 10:40:36 +02:00
parent 5acab52b09
commit 692567078a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/app/vault/VaultBugs_test.cpp
View File

@@ -1686,8 +1686,9 @@ private:
// so this is not the vault's final outstanding share.
//
// Post-fixCleanup3_4_0, doWithdraw skips addEmptyHolding on a zero
// payout. ValidVault also treats a one-sided zero destination delta as
// valid when zeroDeltaIsLegitimate.
// payout. ValidVault accepts a missing recipient delta when
// zeroDeltaIsLegitimate; a present destination delta of zero is still
// rejected.
void
testBugMptZeroWithdrawMissingHolding()
{
@@ -2010,8 +2011,7 @@ private:
// sponsored-withdraw fee-payer fix, deltaAssetsForParty collapses that
// economically-zero XRP delta to absence, so tesSUCCESS takes the
// missing-recipient-delta arm gated by zeroDeltaIsLegitimate. This test
// covers that live SUCCESS path; it does not execute the present-delta
// zeroDeltaIsLegitimate disjunct. Pre-fixCleanup3_4_0 still fails the
// covers that live SUCCESS path. Pre-fixCleanup3_4_0 still fails the
// invariant.
void
testBugXrpZeroWithdrawSponsoredFee()