From 692567078a689e39f68ccb522f5dc09b36111693 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Wed, 2 Sep 2026 10:40:36 +0200 Subject: [PATCH] test: Align zero-withdraw comments with missing-recipient path ValidVault only allows a missing destination delta when zeroDeltaIsLegitimate; a present zero delta is still rejected. --- src/test/app/vault/VaultBugs_test.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/app/vault/VaultBugs_test.cpp b/src/test/app/vault/VaultBugs_test.cpp index 552b7b44d8..0ff39bd9de 100644 --- a/src/test/app/vault/VaultBugs_test.cpp +++ b/src/test/app/vault/VaultBugs_test.cpp @@ -1686,8 +1686,9 @@ private: // so this is not the vault's final outstanding share. // // Post-fixCleanup3_4_0, doWithdraw skips addEmptyHolding on a zero - // payout. ValidVault also treats a one-sided zero destination delta as - // valid when zeroDeltaIsLegitimate. + // payout. ValidVault accepts a missing recipient delta when + // zeroDeltaIsLegitimate; a present destination delta of zero is still + // rejected. void testBugMptZeroWithdrawMissingHolding() { @@ -2010,8 +2011,7 @@ private: // sponsored-withdraw fee-payer fix, deltaAssetsForParty collapses that // economically-zero XRP delta to absence, so tesSUCCESS takes the // missing-recipient-delta arm gated by zeroDeltaIsLegitimate. This test - // covers that live SUCCESS path; it does not execute the present-delta - // zeroDeltaIsLegitimate disjunct. Pre-fixCleanup3_4_0 still fails the + // covers that live SUCCESS path. Pre-fixCleanup3_4_0 still fails the // invariant. void testBugXrpZeroWithdrawSponsoredFee()