fix Clang-tidy

This commit is contained in:
Oleksandr
2026-04-02 21:33:37 -04:00
parent c5598a4284
commit 65322d9e78
3 changed files with 15 additions and 15 deletions

View File

@@ -14,7 +14,7 @@ getIntBytes(STBase const* obj)
{
static_assert(std::is_integral<T>::value, "Only integral types");
auto const& num(static_cast<STInteger<T> const*>(obj));
auto const& num(static_cast<STInteger<T> const*>(obj)); // NOLINT
T const data = adjustWasmEndianess(num->value());
auto const* b = reinterpret_cast<uint8_t const*>(&data);
auto const* e = reinterpret_cast<uint8_t const*>(&data + 1);
@@ -42,13 +42,13 @@ getAnyFieldData(STBase const* obj)
return Unexpected(HostFunctionError::NOT_LEAF_FIELD);
case STI_ACCOUNT: {
auto const* account(dynamic_cast<STAccount const*>(obj));
auto const* account(static_cast<STAccount const*>(obj)); // NOLINT
auto const& data = account->value();
return Bytes{data.begin(), data.end()};
}
case STI_ISSUE: {
auto const* issue(dynamic_cast<STIssue const*>(obj));
auto const* issue(static_cast<STIssue const*>(obj)); // NOLINT
Asset const& asset(issue->value());
// XRP and IOU will be processed by serializer
if (asset.holds<MPTIssue>())
@@ -61,7 +61,7 @@ getAnyFieldData(STBase const* obj)
}
case STI_VL: {
auto const* vl(dynamic_cast<STBlob const*>(obj));
auto const* vl(static_cast<STBlob const*>(obj)); // NOLINT
auto const& data = vl->value();
return Bytes{data.begin(), data.end()};
}
@@ -84,7 +84,7 @@ getAnyFieldData(STBase const* obj)
// LCOV_EXCL_STOP
case STI_UINT256: {
auto const* uint256Obj(dynamic_cast<STUInt256 const*>(obj));
auto const* uint256Obj(static_cast<STUInt256 const*>(obj)); // NOLINT
auto const& data = uint256Obj->value();
return Bytes{data.begin(), data.end()};
}
@@ -165,14 +165,14 @@ locateField(STObject const& obj, Slice const& locator)
if (STI_ARRAY == field->getSType())
{
auto const* arr = dynamic_cast<STArray const*>(field);
auto const* arr = static_cast<STArray const*>(field); // NOLINT
if (sfieldCode < 0 || std::cmp_greater_equal(sfieldCode, arr->size()))
return Unexpected(HostFunctionError::INDEX_OUT_OF_BOUNDS);
field = &(arr->operator[](sfieldCode));
}
else if (STI_OBJECT == field->getSType())
{
auto const* o = dynamic_cast<STObject const*>(field);
auto const* o = static_cast<STObject const*>(field); // NOLINT
auto const it = knownSFields.find(sfieldCode);
if (it == knownSFields.end())
@@ -183,7 +183,7 @@ locateField(STObject const& obj, Slice const& locator)
}
else if (STI_VECTOR256 == field->getSType())
{
auto const* v = dynamic_cast<STVector256 const*>(field);
auto const* v = static_cast<STVector256 const*>(field); // NOLINT
if (sfieldCode < 0 || std::cmp_greater_equal(sfieldCode, v->size()))
return Unexpected(HostFunctionError::INDEX_OUT_OF_BOUNDS);
return FieldValue(&(v->operator[](sfieldCode)));
@@ -206,9 +206,9 @@ getArrayLen(FieldValue const& variantField)
if (STBase const* const* field = std::get_if<STBase const*>(&variantField))
{
if ((*field)->getSType() == STI_VECTOR256)
return dynamic_cast<STVector256 const*>(*field)->size();
return static_cast<STVector256 const*>(*field)->size(); // NOLINT
if ((*field)->getSType() == STI_ARRAY)
return dynamic_cast<STArray const*>(*field)->size();
return static_cast<STArray const*>(*field)->size(); // NOLINT
}
// uint256 is not an array so that variant should still return NO_ARRAY

View File

@@ -328,7 +328,7 @@ static inline HostFunctions*
getHF(void* env)
{
auto const* udata = reinterpret_cast<WasmUserData*>(env);
HostFunctions const* hf = reinterpret_cast<HostFunctions*>(udata->first);
HostFunctions* hf = reinterpret_cast<HostFunctions*>(udata->first); // NOLINT
return hf;
}
@@ -341,7 +341,7 @@ checkGas(void* env)
auto const* runtime = reinterpret_cast<InstanceWrapper const*>(hf->getRT());
if (runtime == nullptr)
{
wasm_trap_t const* trap = reinterpret_cast<wasm_trap_t*>(
wasm_trap_t* trap = reinterpret_cast<wasm_trap_t*>( // NOLINT
WasmEngine::instance().newTrap("hf no runtime")); // LCOV_EXCL_LINE
return Unexpected(trap); // LCOV_EXCL_LINE
}
@@ -352,14 +352,14 @@ checkGas(void* env)
if (runtime->setGas(x) < 0)
{
wasm_trap_t const* trap = reinterpret_cast<wasm_trap_t*>(
wasm_trap_t* trap = reinterpret_cast<wasm_trap_t*>( // NOLINT
WasmEngine::instance().newTrap("can't set gas")); // LCOV_EXCL_LINE
return Unexpected(trap); // LCOV_EXCL_LINE
}
if (gas < impFunc.gas)
{
wasm_trap_t const* trap =
wasm_trap_t* const trap = // NOLINT
reinterpret_cast<wasm_trap_t*>(WasmEngine::instance().newTrap("hf out of gas"));
return Unexpected(trap);
}

View File

@@ -918,7 +918,7 @@ WasmiEngine::newTrap(std::string const& txt)
if (!txt.empty())
wasm_name_new(&msg, txt.size() + 1, txt.c_str()); // include 0
wasm_trap_t const* trap = wasm_trap_new(store_.get(), &msg);
wasm_trap_t* trap = wasm_trap_new(store_.get(), &msg); // NOLINT
if (!txt.empty())
wasm_byte_vec_delete(&msg);