diff --git a/src/libxrpl/tx/wasm/HostFuncImplGetter.cpp b/src/libxrpl/tx/wasm/HostFuncImplGetter.cpp index 67542ac559..46744c17a7 100644 --- a/src/libxrpl/tx/wasm/HostFuncImplGetter.cpp +++ b/src/libxrpl/tx/wasm/HostFuncImplGetter.cpp @@ -14,7 +14,7 @@ getIntBytes(STBase const* obj) { static_assert(std::is_integral::value, "Only integral types"); - auto const& num(static_cast const*>(obj)); + auto const& num(static_cast const*>(obj)); // NOLINT T const data = adjustWasmEndianess(num->value()); auto const* b = reinterpret_cast(&data); auto const* e = reinterpret_cast(&data + 1); @@ -42,13 +42,13 @@ getAnyFieldData(STBase const* obj) return Unexpected(HostFunctionError::NOT_LEAF_FIELD); case STI_ACCOUNT: { - auto const* account(dynamic_cast(obj)); + auto const* account(static_cast(obj)); // NOLINT auto const& data = account->value(); return Bytes{data.begin(), data.end()}; } case STI_ISSUE: { - auto const* issue(dynamic_cast(obj)); + auto const* issue(static_cast(obj)); // NOLINT Asset const& asset(issue->value()); // XRP and IOU will be processed by serializer if (asset.holds()) @@ -61,7 +61,7 @@ getAnyFieldData(STBase const* obj) } case STI_VL: { - auto const* vl(dynamic_cast(obj)); + auto const* vl(static_cast(obj)); // NOLINT auto const& data = vl->value(); return Bytes{data.begin(), data.end()}; } @@ -84,7 +84,7 @@ getAnyFieldData(STBase const* obj) // LCOV_EXCL_STOP case STI_UINT256: { - auto const* uint256Obj(dynamic_cast(obj)); + auto const* uint256Obj(static_cast(obj)); // NOLINT auto const& data = uint256Obj->value(); return Bytes{data.begin(), data.end()}; } @@ -165,14 +165,14 @@ locateField(STObject const& obj, Slice const& locator) if (STI_ARRAY == field->getSType()) { - auto const* arr = dynamic_cast(field); + auto const* arr = static_cast(field); // NOLINT if (sfieldCode < 0 || std::cmp_greater_equal(sfieldCode, arr->size())) return Unexpected(HostFunctionError::INDEX_OUT_OF_BOUNDS); field = &(arr->operator[](sfieldCode)); } else if (STI_OBJECT == field->getSType()) { - auto const* o = dynamic_cast(field); + auto const* o = static_cast(field); // NOLINT auto const it = knownSFields.find(sfieldCode); if (it == knownSFields.end()) @@ -183,7 +183,7 @@ locateField(STObject const& obj, Slice const& locator) } else if (STI_VECTOR256 == field->getSType()) { - auto const* v = dynamic_cast(field); + auto const* v = static_cast(field); // NOLINT if (sfieldCode < 0 || std::cmp_greater_equal(sfieldCode, v->size())) return Unexpected(HostFunctionError::INDEX_OUT_OF_BOUNDS); return FieldValue(&(v->operator[](sfieldCode))); @@ -206,9 +206,9 @@ getArrayLen(FieldValue const& variantField) if (STBase const* const* field = std::get_if(&variantField)) { if ((*field)->getSType() == STI_VECTOR256) - return dynamic_cast(*field)->size(); + return static_cast(*field)->size(); // NOLINT if ((*field)->getSType() == STI_ARRAY) - return dynamic_cast(*field)->size(); + return static_cast(*field)->size(); // NOLINT } // uint256 is not an array so that variant should still return NO_ARRAY diff --git a/src/libxrpl/tx/wasm/HostFuncWrapper.cpp b/src/libxrpl/tx/wasm/HostFuncWrapper.cpp index 88598469e0..e420565727 100644 --- a/src/libxrpl/tx/wasm/HostFuncWrapper.cpp +++ b/src/libxrpl/tx/wasm/HostFuncWrapper.cpp @@ -328,7 +328,7 @@ static inline HostFunctions* getHF(void* env) { auto const* udata = reinterpret_cast(env); - HostFunctions const* hf = reinterpret_cast(udata->first); + HostFunctions* hf = reinterpret_cast(udata->first); // NOLINT return hf; } @@ -341,7 +341,7 @@ checkGas(void* env) auto const* runtime = reinterpret_cast(hf->getRT()); if (runtime == nullptr) { - wasm_trap_t const* trap = reinterpret_cast( + wasm_trap_t* trap = reinterpret_cast( // NOLINT WasmEngine::instance().newTrap("hf no runtime")); // LCOV_EXCL_LINE return Unexpected(trap); // LCOV_EXCL_LINE } @@ -352,14 +352,14 @@ checkGas(void* env) if (runtime->setGas(x) < 0) { - wasm_trap_t const* trap = reinterpret_cast( + wasm_trap_t* trap = reinterpret_cast( // NOLINT WasmEngine::instance().newTrap("can't set gas")); // LCOV_EXCL_LINE return Unexpected(trap); // LCOV_EXCL_LINE } if (gas < impFunc.gas) { - wasm_trap_t const* trap = + wasm_trap_t* const trap = // NOLINT reinterpret_cast(WasmEngine::instance().newTrap("hf out of gas")); return Unexpected(trap); } diff --git a/src/libxrpl/tx/wasm/WasmiVM.cpp b/src/libxrpl/tx/wasm/WasmiVM.cpp index 622311540a..e624d1540d 100644 --- a/src/libxrpl/tx/wasm/WasmiVM.cpp +++ b/src/libxrpl/tx/wasm/WasmiVM.cpp @@ -918,7 +918,7 @@ WasmiEngine::newTrap(std::string const& txt) if (!txt.empty()) wasm_name_new(&msg, txt.size() + 1, txt.c_str()); // include 0 - wasm_trap_t const* trap = wasm_trap_new(store_.get(), &msg); + wasm_trap_t* trap = wasm_trap_new(store_.get(), &msg); // NOLINT if (!txt.empty()) wasm_byte_vec_delete(&msg);