ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-22 06:40:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Silence -Wunused-variable on Vault clawback/withdraw asserts

Browse Source 
Mark `assetsAvailable`/`assetsTotal` in VaultClawback::doApply and
`assetsTotalBefore` in VaultWithdraw::doApply as [[maybe_unused]]: each
is only referenced from XRPL_ASSERT, which is compiled out in Release
(NDEBUG) builds. Without the attribute clang -Werror,-Wunused-variable
would break the release CI configurations, matching the pattern already
addressed for VaultHelpers and LoanPay.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Vito
2026-08-10 15:36:07 +02:00
parent 00889a4307
commit 5d839f4811
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libxrpl/tx/transactors/vault/VaultClawback.cpp
View File

@@ -350,8 +350,8 @@ VaultClawback::doApply()
Asset const vaultAsset = vault->at(sfAsset);
STAmount const amount = clawbackAmount(vault, tx[~sfAmount], accountID_);
Number const assetsAvailable = vault->at(sfAssetsAvailable);
Number const assetsTotal = vault->at(sfAssetsTotal);
[[maybe_unused]] Number const assetsAvailable = vault->at(sfAssetsAvailable);
[[maybe_unused]] Number const assetsTotal = vault->at(sfAssetsTotal);
[[maybe_unused]] auto const lossUnrealized = vault->at(sfLossUnrealized);
XRPL_ASSERT(

2
src/libxrpl/tx/transactors/vault/VaultWithdraw.cpp
View File

@@ -289,7 +289,7 @@ VaultWithdraw::doApply()
}
Number const assetsAvailableBefore = vault->at(sfAssetsAvailable);
Number const assetsTotalBefore = vault->at(sfAssetsTotal);
[[maybe_unused]] Number const assetsTotalBefore = vault->at(sfAssetsTotal);
auto const lossUnrealized = vault->at(sfLossUnrealized);
XRPL_ASSERT(
lossUnrealized <= (assetsTotalBefore - assetsAvailableBefore),